11523 Commits

Author	SHA1	Message	Date
Yuri Rubinsky	6521eccaae	Merge pull request #68477 from dzil123/visual_shader_ufunc_input_fix ... Fixes https://github.com/godotengine/godot/issues/68463	2022-11-12 06:50:35 +03:00
Rémi Verschelde	340fb33e54	Merge pull request #68412 from bruvzg/le_caret_pl ... [Line Edit] Ignore placeholder text when drawing caret.	2022-11-11 16:49:47 +01:00
Rémi Verschelde	5c7af7f391	Merge pull request #68418 from Sauermann/fix-escape-dnd ... Allow canceling Drag and Drop with the Escape-Key	2022-11-11 16:49:09 +01:00
Rémi Verschelde	a2ad59fb8e	Merge pull request #68513 from Chaosus/fix_shader_param ... Fix `Shader::has_parameter` to return a correct value	2022-11-11 10:54:50 +01:00
Rémi Verschelde	bbe8ff24f4	Merge pull request #68358 from Sauermann/fix-pink-512-viewport ... Fix SubViewport with default size being pink	2022-11-11 10:44:24 +01:00
Rémi Verschelde	3263970cf6	Merge pull request #68428 from nikitalita/fix-mesh-convert ... Fix deprecated mesh conversion	2022-11-11 10:44:10 +01:00
Yuri Rubinsky	9d4816fd4a	Fix Shader::has_parameter to return a correct value	2022-11-11 11:30:34 +03:00
nikitalita	5683aa2498	fix old mesh conversion offsets	2022-11-10 22:55:01 +00:00
smix8	f30ebacbe8	Add detail to NavigationPolygon outline error msg ... Adds additional information to the error msg when the convex partition fails due to invalid outline arrays.	2022-11-10 21:12:51 +01:00
dzil123	445062e43b	Visual Shader UVFunc keep existing input value on function change	2022-11-10 04:31:05 -08:00
bruvzg	35528b800c	[Font] Add an import option to pre-render all glyphs required for the translation.	2022-11-10 10:43:15 +02:00
Yuri Rubinsky	dca5cb8e40	Merge pull request #68413 from Chaosus/fix_instance_uniforms	2022-11-09 22:55:41 +03:00
Yuri Rubinsky	c07d13182c	Some fixes for instance shader parameters	2022-11-09 21:20:11 +03:00
Markus Sauermann	e8af3e7e8d	Fix crash from impossible Object::cast_to ... A Vector<>-variant can't be used in an Object::cast_to, because Vector doesn't inherit from Object and this cast always returns a nullptr. This patch replaces the Object::cast_to and accesses the contained Vector directly.	2022-11-08 22:34:01 +01:00
Markus Sauermann	226044b944	Allow canceling Drag and Drop with the Escape-Key ... This patch implements the functionality to cancel Drag and Drop by using the escape key or more general, the ui_cancel action. Since this would be the third location, where the finalization of Drag and Drop would have to be implemented, that functionality was put into the private function _perform_drop. Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging because they are equivalent.	2022-11-08 19:10:16 +01:00
bruvzg	c624b1eeac	[Line Edit] Ignore placeholder text when drawing caret.	2022-11-08 15:15:13 +02:00
kobewi	d9f066d5fa	Remove duplicate project settings definitions	2022-11-08 01:29:39 +01:00
Rémi Verschelde	e2b39bfdc4	Merge pull request #68346 from Calinou/particles-rename-trail-length-property ... Rename GPUParticles2D/3D's `trail_length_secs` to `trail_lifetime`	2022-11-07 15:05:55 +01:00
Hugo Locurcio	ab7a807f2b	Rename GPUParticles2D/3D's trail_length_secs to trail_lifetime ... The property already has a "seconds" suffix in the inspector. The "lifetime" term makes it more obvious that the property is specified as time, not a distance in units. The property hint now allows manually entering values greater than 10 seconds. The internal rendering value's default now matches the particles nodes' default.	2022-11-07 13:37:40 +01:00
Rémi Verschelde	a1bc636098	Merge pull request #68337 from alfredbaudisch/multi-caret-selection-fix ... Fixes mouse click deselect for multi and single carets	2022-11-07 10:20:45 +01:00
Rémi Verschelde	2c8498c8a6	Merge pull request #68351 from Sauermann/fix-code-simplifications ... Code simplifications	2022-11-07 10:01:37 +01:00
Markus Sauermann	7445ab95fc	Fix SubViewport with default size being pink ... A SubViewport with default-size doesn't display its content, but shows pink color, until it is resized. This patch makes sure, that the size gets set during initialization.	2022-11-07 09:23:32 +01:00
Rémi Verschelde	c4f3b94abf	Merge pull request #68321 from BastiaanOlij/xrorigin_start_pos ... Update XRServer with starting position of (new) current XROrigin3D	2022-11-07 08:45:24 +01:00
Markus Sauermann	18978881fe	Code simplifications ... CanvasItemEditor: - p_result == ADD_MOVE is always true in this switch-clause - both parts of the if-else-clause do the same thing and simplified an affine_inverse call ControlEditorToolbar: - private function ControlEditorToolbar::_anchor_to_position is used nowhere. Looks like copy and paste from CanvasItemEditor::_anchor_to_position ScrollContainer: - screen_is_touchscreen is always true, because otherwise the function already returned TextLine: - both parts of the if-else-clause do the same thing and simplified return statement	2022-11-07 01:21:25 +01:00
kobewi	f8f25adc0b	Don't free instanced scenes when recreating tiles	2022-11-07 00:32:41 +01:00
Alfred Reinold Baudisch	0d2953074b	Mouse click deselect removes secondary carets and puts primary caret under mouse position ... Fixes and closes #67993.	2022-11-06 20:03:06 +01:00
Rémi Verschelde	cf1e6bb6fc	Merge pull request #68282 from alfredbaudisch/backspace-multi-care ... Correctly deletes multi-caret selection with backspace	2022-11-06 16:10:32 +01:00
Bastiaan Olij	23e0afec1d	Update XRServer with starting position of (new) current XROrigin3D	2022-11-06 22:19:44 +11:00
Alfred Reinold Baudisch	7127e57bf8	Pass caret index when deleting selection with backspace ... Fixes and closes #67992	2022-11-05 08:55:18 +01:00
Markus Sauermann	65647e9c7d	Fix Windowfocus on resizing ... When resizing a non-focused window, the previously focused Window got resized. This patch grabs focus for the actually resized window, before starting with the resizing.	2022-11-04 22:24:00 +01:00
kobewi	1778301cd0	Add call_deferred() method to Callable	2022-11-04 17:24:34 +01:00
Rémi Verschelde	4e47324b3f	Merge pull request #68097 from KoBeWi/no_signal🔕 ... Add `set_value_no_signal()` to Range	2022-11-04 10:48:47 +01:00
Rémi Verschelde	d48ba545ef	Merge pull request #67741 from cridenour/modular-color-picker ... Modularize the Color Picker via properties and new picker mode.	2022-11-04 10:48:37 +01:00
Rémi Verschelde	21675625a0	Merge pull request #68228 from pasi1991/fix_typo_in_visual_instance_3d ... Fix typo in method (set_transparecy) of visual_instance_3d	2022-11-04 10:06:27 +01:00
Rémi Verschelde	05ce0e3de1	Merge pull request #68222 from groud/fix_corner_terrain_painting ... Fix terrain painting in corner-only matching mode	2022-11-04 10:05:58 +01:00
Chris Ridenour	286e7da162	Modularize the Color Picker via properties.	2022-11-04 00:08:46 -04:00
Patrick Siemsen	0b480c7d99	Fix typo in method of visual_instance_3d	2022-11-03 19:42:14 +01:00
Gilles Roudière	ffacb31734	Fix terrain painting in corner-only matching mode	2022-11-03 19:08:43 +01:00
Hugo Locurcio	a19e389f4f	Hide Antialiasing import option on DynamicFonts with MSDF enabled ... Antialiasing cannot be adjusted on fonts rendered with MSDF. Internally, Godot always uses grayscale antialiasing for those fonts. This also tweaks property hints for consistency, and renames uses of "sub-pixel" to the more commonly used "subpixel".	2022-11-03 18:40:44 +01:00
Rémi Verschelde	3eaf49765b	Merge pull request #68192 from aaronfranke/unify-node3d-euler ... Unify Node3D RotationOrder with global EulerOrder	2022-11-03 12:07:42 +01:00
Rémi Verschelde	3cde6c0432	Merge pull request #67540 from KoBeWi/hue_hue_hue ... Add a separate hue gradient for OKHSL mode	2022-11-03 11:51:45 +01:00
Aaron Franke	9225eb461e	Unify Node3D RotationOrder with global EulerOrder	2022-11-02 17:46:03 -05:00
Rémi Verschelde	08d56ac2f1	Merge pull request #66747 from aaronfranke/move-euler-order ... Move EulerOrder enum to math_defs.h and global scope	2022-11-02 22:37:12 +01:00
Rémi Verschelde	9ec7aadc06	Merge pull request #66017 from Mickeon/rename-image-copy-rect ... Rename Image's `get_rect` to `get_region`	2022-11-02 22:36:57 +01:00
Rémi Verschelde	c9e0d787fe	Merge pull request #67928 from YeldhamDev/we_really_need_a_callback_for_after_children_is_removed ... Fix problems with `tab_changed` signal when removing multiple tabs at once	2022-11-02 22:36:49 +01:00
Rémi Verschelde	efefd9b198	Merge pull request #68120 from akien-mga/style-doc-cleanup ... Style: Misc docs and comment style and language fixes	2022-11-02 22:36:31 +01:00
Rémi Verschelde	d4bf7f4458	Fixup Clang -Wtype-limits warnings introduced by #52350	2022-11-02 22:36:01 +01:00
Markus Sauermann	022d24a9ae	Fix Viewport root order after Node2D raise	2022-11-02 21:45:00 +01:00
Aaron Franke	8556fdd4bc	Move EulerOrder enum to math_defs.h and global scope	2022-11-02 13:44:13 -05:00
Rémi Verschelde	f7c611ab71	Style: Misc docs and comment style and language fixes ... - Removed empty paragraphs in XML. - Consistently use bold style for "Example:", on a new line. - Fix usage of `[code]` when hyperlinks could be used (`[member]`, `[constant]`). - Fix invalid usage of backticks for inline code in BBCode. - Fix some American/British English spelling inconsistencies. - Other minor fixes spotted along the way, including typo fixes with codespell. - Don't specify `@GlobalScope` for `enum` and `constant`.	2022-11-02 19:01:18 +01:00
Rémi Verschelde	39cece382d	Merge pull request #68170 from alfredbaudisch/clear-selection-shortcut ... Unified shortcut to clear carets and selections from TextEdit	2022-11-02 18:54:19 +01:00
Rémi Verschelde	30e4e7c083	Merge pull request #67917 from Faless/mp/4.x_auth ... [MP] Add peer authentication support to the default MultiplayerAPI.	2022-11-02 18:53:38 +01:00
Rémi Verschelde	23e793fd18	Merge pull request #68137 from kleonc/shape-cast-get-collider-rid ... Add `ShapeCast2D/3D::get_collider_rid` method	2022-11-02 18:53:23 +01:00
Rémi Verschelde	7488b4724e	Merge pull request #67788 from 98teg/flow-container-alignment ... Add alignment options to flow container	2022-11-02 18:52:53 +01:00
Rémi Verschelde	76092fb684	Merge pull request #63956 from xiongyaohua/interpolate_on_curve2d ... Move rotation interpolation logic from PathFollower2D to Curve2D	2022-11-02 18:50:48 +01:00
Alfred Reinold Baudisch	a862583d05	Unified shortcut to clear carets and selections ... Refactors`ui_text_remove_secondary_carets` from https://github.com/godotengine/godot/pull/68089 as `ui_text_clear_carets_and_selection`, with extra behaviour: - If there's only one active caret active with a selection, clears the selection. - In case there's more than one caret active, removes the secondary carets and clears selections. With this change, `TextEdit` then imitates the behaviour of VSCode for clearing carets and selections.	2022-11-02 18:23:24 +01:00
Rémi Verschelde	604abb434f	Merge pull request #52350 from BimDav/viewport_canvas_cull ... Added Viewport canvas cull mask feature	2022-11-02 17:14:24 +01:00
Rémi Verschelde	06c8e406e4	Merge pull request #63335 from Spartan322/button-shortcut-feedback ... Make `BaseButton` Shortcut feedback togglable	2022-11-02 17:14:00 +01:00
kobewi	84d6549c75	Change hue icons to horizontal GradientTexture2D	2022-11-02 15:34:15 +01:00
Fabio Alessandrelli	33dda2e68a	[MP] Remove connection state signals from MultiplayerPeer. ... Now handled directly by the MultiplayerAPI implementation.	2022-11-02 15:17:23 +01:00
kobewi	f5981ff19d	Add a separate hue gradient for OKHSL mode	2022-11-02 14:44:41 +01:00
Rémi Verschelde	eddaab17ea	Merge pull request #63562 from Rindbee/better-scroll-conditions ... Use more reasonable scrollable conditions in `ScrollContainer`	2022-11-02 14:21:21 +01:00
Rémi Verschelde	ad0349c0e3	Merge pull request #59479 from Sauermann/fix-rootorder-on-layerchange ... Update root order on layer change	2022-11-02 14:20:24 +01:00
Rémi Verschelde	910cf9a9b3	Merge pull request #67810 from MrBlockers/reged-fixes ... Fix multiple issues with region editor	2022-11-02 14:18:12 +01:00
Rémi Verschelde	87cdc2ea60	Merge pull request #67994 from YeldhamDev/how_suggestive ... Stop centering clicked suggestions in the autocomplete popup	2022-11-02 14:15:32 +01:00
Micky	ebf86c96e9	Rename Image's get_rect to get_region ... Also renames its parameter to from "rect" to "region".	2022-11-01 23:35:48 +01:00
kleonc	bbd225a804	Add ShapeCast2D/3D::get_collider_rid method	2022-11-01 21:17:18 +01:00
Fabio Alessandrelli	0a0e99cadc	Merge pull request #67982 from Faless/mp/4.x_disconnect_close ... [MP] Add MultiplayerPeer disconnect_peer, close.	2022-11-01 20:35:04 +01:00
Yaohua Xiong	399c2a8dea	Move rotation sampling from Path2D to Curve2D ... The rotation sampling code is moved from Path2D to a new method `sample_baked_with_rotation` on Curve2D.	2022-11-01 13:18:52 +08:00
kobewi	4aa1efb0fe	Add set_value_no_signal() to Range	2022-10-31 23:59:01 +01:00
Alfred Reinold Baudisch	fcff978763	Shortcut and Bind to Remove Secondary Carets ... Adds the bind `ui_text_remove_secondary_carets` to TextEdit, with ESC as the default shortcut. When the bind is performed, if the TextEdit has multiple carets, `remove_secondary_carets` is called and secondary carets are removed. This is useful when multiple selects are performed with `add_select_for_next_occurrence` #67644 or when multiple multiple carets are manually added, then it's possible to go back to a single caret with a shortcut. Closes #67991	2022-10-31 17:44:47 +01:00
Rémi Verschelde	c866f349ce	Merge pull request #67895 from bruvzg/ts_fix_obj_rects ... Fix `TextLine` and `TextParagraph` `get_*_object_rect` methods not accounting for alignment and drop cap.	2022-10-31 14:29:34 +01:00
Rémi Verschelde	2529006134	Merge pull request #67486 from bruvzg/bmp_oem ... [Font] Add support for OEM encoded bitmap fonts.	2022-10-31 14:20:53 +01:00
BimDav	fcb9be66a2	Viewport canvas cull mask feature ... Co-authored-by: Valentin Zagura <puthre@gmail.com>	2022-10-31 14:09:49 +01:00
Rémi Verschelde	5947f22be9	Merge pull request #67578 from KoBeWi/GEDITOR ... Unify usage of GLOBAL/EDITOR_GET	2022-10-31 13:15:58 +01:00
Rémi Verschelde	4b92533efa	Merge pull request #68073 from timothyqiu/marker-3d-extents ... Make Marker3D gizmo resizable	2022-10-31 12:17:13 +01:00
Rémi Verschelde	1518bb716e	Merge pull request #67282 from CheesecakeCG/fix-pb-start-sim ... Fix Skeleton3D falsely assuming all physical bones will be children of their first bone	2022-10-31 12:04:33 +01:00
hare_ware	913f57f695	Fix Skeleton3D falsely assuming all physical bones will be children of their first bone	2022-10-31 06:59:42 -04:00
Rémi Verschelde	71a6aba3d7	Merge pull request #67710 from KoBeWi/a_bit_local_global_transform ... Remove error condition from get_global_transform()	2022-10-31 11:59:08 +01:00
Rémi Verschelde	0844f0ed10	Merge pull request #65452 from timothyqiu/agent-target ... Make NavigationAgent `target_location` a property	2022-10-31 11:56:17 +01:00
Rémi Verschelde	be126d42d4	Merge pull request #67588 from KoBeWi/if(!GDVIRTUAL_CALL)don't ... Simplify GDVIRTUAL_CALL calls	2022-10-31 11:55:56 +01:00
Rémi Verschelde	33c7c8020a	Merge pull request #67489 from timothyqiu/auto-select-all ... Allow selecting SpinBox & LineEdit text when focus enters	2022-10-31 11:55:06 +01:00
Rémi Verschelde	b6cbea5e58	Merge pull request #63590 from golfinq/fbg-padding ... Add padding options in theme for fg/bgcolor tags in RichTextLabel	2022-10-31 11:14:55 +01:00
Rémi Verschelde	dcd86f9848	Merge pull request #67046 from Cykyrios/fix-invalid-tooltip-position ... Fix invalid tooltip position	2022-10-31 11:05:19 +01:00
Rémi Verschelde	8b1a42cd47	Merge pull request #67888 from KoBeWi/overridead ... Remove `override_selected_font_color` property	2022-10-31 10:59:07 +01:00
Rémi Verschelde	420eb1aa34	Merge pull request #67445 from Zylann/rename_queue_delete ... Rename queue_delete => queue_free	2022-10-31 10:51:18 +01:00
Rémi Verschelde	fa73211754	Merge pull request #65118 from Mickeon/editor-remote-tree-buttons ... Add a few buttons in Remote Scene Tree	2022-10-31 10:46:08 +01:00
Rémi Verschelde	40258bbbe8	Merge pull request #67577 from qarmin/fix_exporting_big_templates ... Fix exporting with big export templates	2022-10-31 10:39:08 +01:00
Rémi Verschelde	d831ba1d6f	Merge pull request #67534 from KoBeWi/more_OK_in_OKHSL ... Improve ColorPicker sliders in OKHSL mode	2022-10-31 10:37:27 +01:00
Rémi Verschelde	d0fbeec66a	Merge pull request #67580 from KoBeWi/little_things ... Minor code improvements	2022-10-31 10:34:57 +01:00
Rémi Verschelde	32548f9608	Merge pull request #67467 from timothyqiu/who-ami-i ... Fix get_path() error when calling get_node()	2022-10-31 10:33:51 +01:00
Rémi Verschelde	68623c75b3	Merge pull request #67496 from Paulb23/text-edit-crashes ... Fix TextEdit action and CodeEdit completion crash	2022-10-31 10:32:41 +01:00
Rémi Verschelde	273410ba5a	Merge pull request #67139 from PucklaMotzer09/insert_caret_at_carets ... Add Caret Insert Below and Above shortcuts to TextEdit	2022-10-31 10:32:07 +01:00
Rémi Verschelde	996f7e5142	Merge pull request #66352 from arkology/progressbar_atlastexture_radial ... Support AtlasTexture in radial modes of TextureProgressBar	2022-10-31 10:31:07 +01:00
Haoyu Qiu	3ded27c62d	Make Marker3D gizmo resizable	2022-10-31 15:19:48 +08:00
Max Hilbrunner	f013315980	Merge pull request #67754 from kleonc/tilemap-fix-collision-shapes-debug-draw ... Fix `TileMap` collision shapes debug draw	2022-10-30 00:15:42 +02:00
Max Hilbrunner	11d74d606a	Merge pull request #67980 from DeeJayLSP/webpcase ... Change all WEBP strings and comments to WebP	2022-10-29 19:28:47 +02:00
Haoyu Qiu	3aed3edc06	Allow selecting SpinBox & LineEdit text when focus enters	2022-10-29 09:58:42 +08:00
Michael Alexsander	4b6e6c6758	Stop centering clicked suggestions in the autocomplete popup	2022-10-28 20:22:28 -03:00
Fabio Alessandrelli	39f3d9d59e	[MP] Add MultiplayerPeer disconnect_peer, close. ... Update ENet, WebRTC, and WebSocket to support peer disconnection and unify the close function.	2022-10-28 21:18:01 +02:00
DeeJayLSP	dd64ceab47	Change all WEBP strings and comments to WebP	2022-10-28 15:17:49 -03:00
Clay John	ada2661a2c	Merge pull request #67956 from RedMser/safe-velocity-type ... Fix type of `safe_velocity` parameter	2022-10-28 10:57:46 -07:00
Micky	0e0a233859	Fix spacing of few PROPERTY_HINT_ENUM hint_strings	2022-10-28 14:51:26 +02:00
Clay John	0486810697	Merge pull request #67644 from alfredbaudisch/add-selection-next-occurrence ... Add Selection and Caret for Next Occurrence of Selection	2022-10-27 17:21:49 -07:00
RedMser	b9c3a5534b	Fix type of safe_velocity parameter	2022-10-27 22:45:24 +02:00
Clay John	4dc2c8ae6f	Merge pull request #67939 from sambriels/emit-signal-after-target-reached ... [NavigationAgent2D/3D]: target_reached signal is emitted before internal state is updated	2022-10-27 12:52:13 -07:00
Clay John	8fd92ed867	Merge pull request #64710 from MinusKube/window-size-crash ... Prevent windows from having a size greater than device limit	2022-10-27 10:02:44 -07:00
Clay John	e1caa8797b	Merge pull request #67043 from clayjohn/clip_children ... Improve behaviour of clip_children by clipping to parent alpha value but still retaining parent color	2022-10-27 09:59:27 -07:00
Clay John	2f2c138b44	Merge pull request #67926 from Rindbee/fix_call_shortcut_input ... Fix calling `_call_shortcut_input` on a node that has been removed	2022-10-27 09:56:55 -07:00
Clay John	d1cc93af89	Merge pull request #67832 from Sauermann/fix-remove-unnecessary-casts ... Remove unnecessary casts	2022-10-27 09:47:34 -07:00
Clay John	682156e1f0	Merge pull request #66383 from aaronfranke/basis-from-euler ... Clean up Basis from Euler code	2022-10-27 09:44:21 -07:00
Fabio Alessandrelli	7536d15fe3	[MP] Let MultiplayerAPI handle packet relaying and peer signaling. ... MultiplayerPeer changes: - Adds is_server_relay_supported virtual method Informs the upper MultiplayerAPI layer if it can signal peers connected to the server to other clients, and perform packet relaying among them. - Adds get_packet_channel and get_packet_mode virtual methods Allows the MultiplayerAPI to retrieve the channel and transfer modes to use when relaying the last received packet. SceneMultiplayerPeer changes: - Implement peer signaling and packet relaying when the MultiplayerPeer advertise they are supported. ENet, WebRTC, WebSocket changes: - Removed custom code for relaying from WebSocket and ENet, and let it be handled by the upper layer. - Update WebRTC to split create_client, create_server, and create_mesh, with the latter behaving like the old initialize with "server_compatibility = false", and the first two supporting the upper layer relaying protocol.	2022-10-27 18:08:58 +02:00
Sam Briels	815231943b	Emit target_reached signal after state is updated	2022-10-27 14:05:43 +02:00
Michael Alexsander	fb8588e68e	Fix problems with tab_changed signal when removing multiple tabs at once	2022-10-27 03:16:01 -03:00
Rindbee	c77349ecb7	Fix calling _call_shortcut_input on a node that has been removed ... Nodes may have been deleted by shortcuts. For example, when switching scenes with `Ctrl` + `Tab` / `Ctrl` + `Shift` + `Tab`, some controls will be deleted and recreated.	2022-10-27 14:05:51 +08:00
Haoyu Qiu	e4100495b5	Make NavigationAgent target_location a property	2022-10-27 13:51:38 +08:00
kobewi	c7eb814ede	Remove override_selected_font_color property	2022-10-26 12:59:18 +02:00
bruvzg	4a6d39c6b9	Fix TextLine and TextParagraph get_*_object_rect methods not accounting for alignment and drop cap.	2022-10-26 10:46:08 +03:00
MrBlockers	92ebbf2c0a	Fix multiple issues with region editor ... Make the filter mode of the texture preview match the node/resource being edited where applicable, and nearest neighbor with mipmaps as a fallback. Make the Edit Region button for Sprite3D only appear when region is enabled, to match behavior of Sprite2D. Fix the editor not correctly clearing reference to previously edited resources, resulting in a visual bug displaying the incorrect texture.	2022-10-25 18:23:23 -04:00
Yuri Rubinsky	2b505b74b9	Merge pull request #67431 from Chaosus/vs_fix_nodes_code	2022-10-25 20:38:24 +03:00
Marc Gilleron	7543a5e014	Rename queue_delete => queue_free ... # Conflicts: # editor/plugins/tiles/tiles_editor_plugin.cpp	2022-10-24 22:07:02 +01:00
kleonc	471f2da9b6	SceneTree Fix storing removed nodes to be skipped by the group calls	2022-10-24 21:38:19 +02:00
Markus Sauermann	5ee449efec	Remove unnecessary casts ... button_add_item and button_add are both Button p_parent is a Node3D CanvasItem can never be cast to Viewport	2022-10-24 15:59:18 +02:00
Clay John	040f49ed6e	Merge pull request #67390 from groud/more_conservative_terrain_painting ... Make terrain painting not change neighbors centers bits	2022-10-23 17:11:06 -07:00
Clay John	9be3fd640b	Merge pull request #67513 from Calinou/editor-light2d-fix-shadow-filter-smooth-visibility ... Fix Light2D Shadow Filter Smooth property being visible with filter None	2022-10-23 17:03:07 -07:00
Clay John	4134f2a464	Merge pull request #67566 from Sauermann/fix-code-simplifications ... Code simplifications	2022-10-23 17:02:04 -07:00
Teggy	2b08675f37	Add alignment options to flow container	2022-10-23 13:40:17 +02:00
kleonc	fcb663df51	Fix TileMap collision shapes debug draw	2022-10-22 16:14:54 +02:00
Aaron Franke	7f9a8c99c9	Clean up Basis from Euler code	2022-10-21 17:54:49 -05:00
Max Hilbrunner	d145c9b1a7	Merge pull request #67684 from patchfx/fix-typo-in-draw-rect-region ... Fix tp_canvas_item typo in _draw_rect_region	2022-10-21 18:13:45 +02:00
kobewi	2ff676a696	Remove error condition from get_global_transform()	2022-10-21 14:52:43 +02:00
Max Hilbrunner	c4c35ab77a	Merge pull request #67627 from KoBeWi/tilter ... Fix texture filter and repeat in TileMap	2022-10-21 13:54:31 +02:00
Alfred Reinold Baudisch	7d15ecc3af	Add Selection and Caret for Next Occurrence of Selection ... Adds the bind `add_selection_for_next_occurrence` to TextEdit, with CTRL+D as the default shortcut. When the bind is performed, ff a selection is currently active with the last caret in text fields, searches for the next occurrence of the selection, adds a caret and selects the next occurrence. If no selection is currently active with the last caret in text fields, selects the word currently under the caret. The action can be performed sequentially for all occurrences of the selection of the last caret and for all existing carets. The viewport is adjusted to the latest newly added caret. The bind and the behaviour is similar to VS Code's "Add Selection to Next Find Match" and JetBrains' "Add Selection for Next Occurrence". It takes advantage of the multi-caret API. The default shortcut for `select_word_under_caret` has been changed to ALT+G, in order to give priority to CTRL+D for `add_selection_for_next_occurrence` to better align with popular IDEs and editors.	2022-10-21 08:26:53 +02:00
Clay John	72b845b287	Merge pull request #67506 from squashiv/master ... Expose Shape2D::get_rect to scripting	2022-10-20 13:26:40 -07:00
Richard Patching	5de65bb2d7	Fix tp_canvas_item typo in _draw_rect_region	2022-10-20 20:04:45 +01:00
Micky	809dad907a	Add buttons in Remote Scene Tree ... A Scene button to any scene instantiated from file. When clicked, it opens the original PackedScene. A toggle visibility button is also available.	2022-10-20 18:02:41 +02:00
Gilles Roudière	fe65d7aa7b	Make terrain painting not change neighbors centers bits	2022-10-20 14:47:45 +02:00
squash	247a93845d	Expose Shape2D::get_rect to scripting	2022-10-20 11:26:49 +03:00
Rindbee	075e79bf04	Improve validation when setting max/min/page in Range ... The incoming value is validated first and then compared. Previously, when the ScrollContainer was scrolled, the ScrollBar of the other axis of the ScrollContainer would emit the changed signal. This commit avoids that.	2022-10-20 14:04:09 +08:00
George L. Albany	d846dd6e91	Make BaseButton Shortcut feedback togglable	2022-10-20 02:02:12 -04:00
kobewi	2f9cbbe0fb	Fix texture filter and repeat in TileMap	2022-10-19 23:23:40 +02:00
Clay John	a8c805be29	Merge pull request #66546 from KoBeWi/rfeipletaetr ... Add methods to get target filter and repeat	2022-10-19 13:55:57 -07:00
Max Hilbrunner	d148613bb1	Merge pull request #66279 from aaronfranke/control-min-size ... Revert `custom_minimum_size` type back to `Vector2` instead of `Vector2i`	2022-10-19 22:40:52 +02:00
Max Hilbrunner	f066f2c0de	Merge pull request #66940 from aaronfranke/doc-get-tr-aabb ... Remove the global space `get_transformed_aabb` helper method	2022-10-19 22:40:02 +02:00
Max Hilbrunner	523f6263e4	Merge pull request #67249 from wuyingnan/fix_quaternion_typo ... Fix a comment typo in node_3d.h	2022-10-19 21:02:14 +02:00
Max Hilbrunner	5f7906a289	Merge pull request #67527 from BastiaanOlij/fix_tracker_names ... Fix two typos in tracker names and a bug in OpenXR haptic feedback	2022-10-19 18:18:36 +02:00
kobewi	4efa851d7f	Add methods to get target filter and repeat	2022-10-19 14:41:42 +02:00
Rafał Mikrut	86fa3ba560	Fix exporting big templates	2022-10-19 08:29:29 +02:00
Yuri Rubinsky	19126d22a4	Fix code generation for some visual shader nodes	2022-10-19 09:09:56 +03:00
kobewi	d06a8320e5	Simplify GDVIRTUAL_CALL calls	2022-10-19 00:05:48 +02:00
kobewi	b42c1f82fc	Improve ColorPicker sliders in OKHSL mode	2022-10-18 23:59:55 +02:00
kobewi	e48c5daddf	Unify usage of GLOBAL/EDITOR_GET	2022-10-18 19:01:48 +02:00
Patrick	91a9e7af3f	Fix typo in VisualShader DistanceFade node	2022-10-18 18:20:31 +02:00
kobewi	4aaed4fee1	Minor code improvements	2022-10-18 16:44:57 +02:00
Aaron Franke	9ebd8c5bb5	Remove the global space get_transformed_aabb helper method	2022-10-18 07:30:31 -05:00
Markus Sauermann	b8031bb7d6	Code simplifications ... 1. Viewport::get_visible_rect().position is always zero. So Control::get_window_rect is identical to Control::get_global_rect. Remove Control::get_window_rect since it is not used in the source code. 2. sqrt(a * a) = abs(a) for doubles 3. Simplify affine_inverse combination 4. Simplify calculation in shaders	2022-10-18 12:47:40 +02:00
PucklaMotzer09	e5354cacd0	Add Caret Insert Below and Above shortcuts to TextEdit	2022-10-18 10:38:53 +02:00
Rindbee	42073fc2bb	Use more reasonable scrollable conditions in ScrollContainer ... The visibility of the `ScrollBar` was used as a condition for judging whether it should scroll. **Visible** and **scrollable** are currently not the same in some cases (`SCROLL_MODE_SHOW_NEVER`). This makes `SCROLL_MODE_SHOW_NEVER` not working properly. This patch will make `SCROLL_MODE_SHOW_NEVER` available, so that the external `SrollBar` can share the internal `ScrollBar`'s data, we can achieve the purpose of replacing the internal `ScrollBar` with a custom external one.	2022-10-18 16:32:39 +08:00
arkology	825f5671f1	Support AtlasTexture in radial modes of TextureProgressBar	2022-10-17 20:44:25 +03:00
Rémi Verschelde	ebca8b8aea	Merge pull request #67491 from Paulb23/fix-undo-redo-viewport-adjust ... Fix undo redo not adjusting TextEdit viewport to caret	2022-10-17 17:31:26 +02:00
Bastiaan Olij	1e7f009492	Fix two typos in tracker names and a bug in OpenXR haptic feedback	2022-10-17 20:29:19 +11:00
Hugo Locurcio	6dcb295a07	Fix Light2D Shadow Filter Smooth property being visible with filter None	2022-10-17 01:35:10 +02:00
Paulb23	4bfb1d953c	Fix undo redo not adjusting TextEdit viewport to caret	2022-10-16 19:30:03 +01:00
Paulb23	b5dc8e24be	Fix crash in code completion when using an invalid / null font	2022-10-16 16:47:27 +01:00
Paulb23	76005e5ff7	Forcibly end current TextEdit action on undo redo	2022-10-16 16:28:22 +01:00
bruvzg	2aa350f701	[Font] Add support for OEM encoded bitmap fonts.	2022-10-16 18:22:21 +03:00
Haoyu Qiu	64c20a51c1	Fix get_path() error when calling get_node()	2022-10-16 10:48:59 +08:00
Markus Sauermann	39e49a8bdd	Expose Viewport::get_screen_transform to GDScript	2022-10-15 23:37:59 +02:00
Rémi Verschelde	dc4b616596	Merge pull request #63332 from KoBeWi/static_images_aka_photos ... Make some Image methods static	2022-10-15 12:56:57 +02:00
Miguel Gonzalez Sanchez	a97a00bf02	Rename pos -> index on Node	2022-10-14 19:56:34 +01:00
clayjohn	b6f44859d7	Implement multiple clip_children modes for CanvasItems	2022-10-14 08:02:28 -07:00
kobewi	072f6feaba	Make some Image methods static	2022-10-14 14:34:15 +02:00
Rémi Verschelde	39534a7aec	Merge pull request #67385 from Sauermann/fix-viewport-mouse-position-update-on-subwindows	2022-10-14 13:31:11 +02:00
Markus Sauermann	b1d6b34662	Always update Viewport's last_mosue_position ... When the mouse cursor is over a embedded Window, the Viewport's last_mouse_position did not get updated. This patch makes sure that the update happens on every InputEventMouse. Document canvas layer of embedded Windows.	2022-10-14 12:51:45 +02:00
bruvzg	4b1937c73f	Abort LineEdit shaping if no font is set to avoid unnecessary error messages.	2022-10-14 12:57:42 +03:00
Rémi Verschelde	7502c808fa	Merge pull request #66665 from Mickeon/editor-do-not-edit-inherited-signals ... Do not allow editing Scene-inherited signal connections	2022-10-14 10:19:47 +02:00
Rémi Verschelde	5f4aa11c62	Merge pull request #63607 from BastiaanOlij/fix_xr_origin ... Add current setting to XROrigin3D and fix double positioning HMD	2022-10-14 09:45:00 +02:00
Rémi Verschelde	46a1b92bb7	Merge pull request #66294 from reduz/optimize-convex-collision	2022-10-13 20:34:00 +02:00
Micky	6a77563b25	Do not allow editing Scene-inherited signal connections ... Inherited connections are also highlighted with the warning color in the Node dock.	2022-10-13 20:13:05 +02:00
Juan Linietsky	71d2e38cb5	Optimize Convex Collision ... Implements the Gauss Mapping optimization to SAT convex collision test. * Described [here](https://ubm-twvideo01.s3.amazonaws.com/o1/vault/gdc2013/slides/822403Gregorius_Dirk_TheSeparatingAxisTest.pdf) by Dirk Gregorius. * Requires adding of face information to edges in MeshData * Took the chance to convert MeshData to LocalVector for performance.	2022-10-13 19:07:53 +02:00
Rémi Verschelde	f32f5b70d8	Merge pull request #67348 from Mickeon/salvage-a-dear-comment ... Comment not to remove `data` structs in some Nodes	2022-10-13 18:40:58 +02:00
Micky	de9e08da76	Comment not to remove data structs in some Nodes	2022-10-13 15:52:35 +02:00
Rémi Verschelde	9eb8eb5f7d	Merge pull request #67336 from jbcolli2/Normal-of-CylinderMesh ... Fix bug in CylinderMesh when computing normals	2022-10-13 15:24:55 +02:00
Rémi Verschelde	2ffb609658	Merge pull request #66337 from EricEzaM/sprite-frames ... Ensure control built-in shortcuts are matched exactly & add shortcuts for SpriteFrames editor	2022-10-13 15:24:39 +02:00
Rémi Verschelde	17db8be33c	Merge pull request #66357 from EricEzaM/shortcut-context-on-node ... Move Shortcut Context to control and fix `shortcut_input` with `shortcut_context`	2022-10-13 15:24:30 +02:00
jbcolli2	491ec622f6	Changed normal of CylinderMesh to account for slanted side.	2022-10-13 08:24:31 -04:00
Eric M	a3ed9e6f2c	Move Shortcut Context to Control and ensure that shortcut_input adheres to contexts. Also ensure that controls with no context are only triggered AFTER nodes which do have a context.	2022-10-13 21:07:19 +10:00
MladoniSzabi	3550354fd3	fixed holding alt while zooming zooms in by 2 increments.	2022-10-13 11:38:25 +01:00
Rémi Verschelde	fad0327503	Merge pull request #66953 from Sauermann/fix-top-level-connect-error ... Fix Control node not disconnecting from signal	2022-10-13 09:04:25 +02:00
Rémi Verschelde	c55c0a2028	Merge pull request #66349 from A-Lamia/Amount_At_Collision ... PARTICLES: adds amount property to collision sub particles.	2022-10-13 09:03:43 +02:00
Bastiaan Olij	3a4866bba4	Add current setting to XROrigin3D and fix double positioning HMD	2022-10-13 13:48:52 +11:00
Lamia	5af6f4a04b	particles: add amount property to sub property collision.	2022-10-13 04:25:18 +11:00
Rémi Verschelde	ea47e03b36	Merge pull request #65714 from benbot/fix-double-particle-collision-calculation	2022-10-12 17:46:17 +02:00
Rémi Verschelde	15b68f7601	Merge pull request #67232 from bruvzg/popup_edit ... Improve Popup / Window behavior in the edited scene tree.	2022-10-12 14:45:14 +02:00
Rémi Verschelde	6fc1715cdf	Merge pull request #65779 from Mickeon/rename-camera-follow ... Rename Camera2D's `smoothing` to `position_smoothing`	2022-10-12 08:53:04 +02:00
Rémi Verschelde	3229194dfc	Merge pull request #67215 from Nidjo123/project-dialog-resize ... Resize project dialog only when necessary	2022-10-11 23:26:37 +02:00
Paulb23	f3eb543e67	Fix select word under caret using caret col instead of line	2022-10-11 20:32:06 +01:00
Nikola Bunjevac	d7e9b8af9a	Set window size after setting new limits ... Otherwise this can fail as the size may not fit into current limits. This is problematic at least on X11.	2022-10-11 17:16:20 +02:00
Micky	43b9cc96da	Rename Camera2D's smoothing to position_smoothing ... For Camera2D: `smoothing_enabled` -> `position_smoothing_enabled` `set_enable_follow_smoothing` -> `set_position_smoothing_enabled` `is_follow_smoothing_enabled` -> `is_position_smoothing_enabled` `smoothing_speed` -> `position_smoothing_speed` `set_follow_smoothing` -> `set_position_smoothing_speed` `get_follow_smoothing` -> `get_position_smoothing_speed`	2022-10-11 16:51:26 +02:00
Rémi Verschelde	042e81f663	Merge pull request #40274 from Juankz/clips_importing_improvement ... Add animation slices for individual animations	2022-10-11 16:18:22 +02:00
Rémi Verschelde	646d59e713	Merge pull request #63271 from Chaosus/fix_texture_error ... Fix error emitting when opening some textures in the inspector	2022-10-11 16:17:15 +02:00
Rémi Verschelde	6d534f6e89	Merge pull request #66221 from Mickeon/painstakingly-appending-ds-en-you-tea-es ... Rename remaining "*_enable" to "*_enabled"	2022-10-11 16:17:02 +02:00
Rémi Verschelde	f21053d189	Merge pull request #67201 from progsource/richtextlabel-icon-spritesheet ... Add Spritesheet support to RichTextLabel BBCode	2022-10-11 13:58:54 +02:00
Yingnan Wu	042d228558	fix typo	2022-10-11 19:58:25 +08:00
Petra Baranski	546e017613	Add Spritesheet support to RichTextLabel BBCode ... BBCode: [img region=0,0,16,16]res://icon.svg[/img]	2022-10-11 13:04:15 +02:00
Rémi Verschelde	e413d1c9c3	Merge pull request #67104 from Calinou/add-viewport-transparent-project-setting ... Add a project setting to make the root viewport transparent	2022-10-11 09:28:43 +02:00
Rémi Verschelde	5606551028	Merge pull request #67219 from KoBeWi/adJUSt_NAMe_cAsIng_PRopERLY ... Fix node name casing issues	2022-10-11 09:27:27 +02:00
Rémi Verschelde	6b8772dbb2	Merge pull request #67192 from RedMser/light-scale-warning ... Show warning when scaling Light3D nodes	2022-10-11 09:26:56 +02:00
Rémi Verschelde	55815998d4	Merge pull request #67194 from RedMser/dirlight2d-height-suffix ... Remove incorrect `px` suffixes	2022-10-11 09:26:49 +02:00
bruvzg	2e1fcbe14b	Prevent Popups it the edited scene tree from closing on focus loss. Hide irrelevant Popup flags from the editor inspector.	2022-10-11 08:55:00 +03:00
Juan Velandia	6e603f202f	Connect signal animation_removed to its proper method	2022-10-10 18:39:49 -05:00
kobewi	b754df2b99	Fix node name casing issues ... Co-authored-by: ryburnj <jordanryburn@gmail.com>	2022-10-10 22:31:26 +02:00
RedMser	87aeb59b5b	Show warning when scaling Light3D nodes	2022-10-10 18:24:28 +02:00
RedMser	a8a4e290fb	Remove incorrect px suffixes	2022-10-10 18:18:15 +02:00
Rémi Verschelde	8017827144	SCons: Re-enable treating #warning as error with werror ... Replace all TODO uses of `#warning` by proper TODO comments, and will open matching bug reports to keep track of them. We don't have a great track record fixing TODOs, but I'd wager we're even worse for fixing these "TODO #warning" so we should prohibit this usage.	2022-10-10 16:12:26 +02:00
Rémi Verschelde	8c24b35b76	Merge pull request #65942 from SaracenOne/animation_change_callback_fix ... Fix animation change callbacks	2022-10-10 13:53:53 +02:00
Rémi Verschelde	ddb97a0b35	Merge pull request #67117 from Jummit/tree-button-color ... Expose TreeItem::set_button_color	2022-10-10 13:52:57 +02:00
Rémi Verschelde	4be5660223	Merge pull request #67145 from Paulb23/tab_textedit ... Fix inserting tabs in TextEdit	2022-10-10 13:52:42 +02:00
kobewi	14b82c36a2	Defer clearing of ResourceUID cache and silence warnings	2022-10-10 11:20:23 +02:00
Rémi Verschelde	104af08e9d	Merge pull request #65805 from MewPurPur/improve-breakpoint-hovering ... Improve bookmark and breakpoint indicators	2022-10-10 10:03:26 +02:00
VolTer	d6e60f45a1	Improved breakpoints hover indicator	2022-10-10 04:36:45 +02:00
Haoyu Qiu	eac9adf7a1	Don't allow removing TextEdit's main caret	2022-10-10 08:30:23 +08:00
Paulb23	7333aa68f4	Handle tab in TextEdit	2022-10-09 17:46:40 +01:00
Jummit	a6c1cfae99	Allow drag-clicking before symbol lookup ... This makes it easier for touch and tablet users to do symbol lookups in the code editor.	2022-10-09 18:42:54 +02:00
Rémi Verschelde	6f6482e82b	Merge pull request #67083 from RedMser/label-font-warning ... Add warning for missing characters in label font	2022-10-09 18:29:06 +02:00
Rémi Verschelde	7c1e15bfb9	Merge pull request #67076 from timothyqiu/hint-enum-suffix ... Remove invalid suffix hint for enum property	2022-10-09 18:27:59 +02:00
Rémi Verschelde	49be2d2cf8	Merge pull request #66524 from microaeris/aeris/text-edit-get-scroll-bar ... Getters for TextEdit scroll bars	2022-10-09 18:27:30 +02:00
Rindbee	3f20108703	Improve caret drawing conditions for LineEdit ... Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.	2022-10-09 22:14:40 +08:00
Jummit	1e28675560	Expose TreeItem::set_button_color	2022-10-09 10:37:55 +02:00
Hugo Locurcio	bab8497fa2	Add a project setting to make the root viewport transparent ... This allows recording videos with a transparent background without having to create a script.	2022-10-09 00:16:07 +02:00
Haoyu Qiu	2a921cc9f8	Fix Label text length mismatch after localization	2022-10-08 23:07:19 +08:00
RedMser	9579d49820	Add warning for missing characters in label font	2022-10-08 17:02:25 +02:00
Rémi Verschelde	2b376437a2	Merge pull request #65983 from Mickeon/rename-audio-player-volume-db ... Rename AudioStreamPlayer3D's `unit_db` to `volume_db`	2022-10-08 13:56:10 +02:00
Rémi Verschelde	0a129645ac	Merge pull request #67062 from timothyqiu/enum-space ... Remove leading spaces from enumerator name hints	2022-10-08 13:55:58 +02:00
Haoyu Qiu	95c860c607	Remove invalid suffix hint for enum property	2022-10-08 19:24:54 +08:00
microaeris	215fe852b8	Getters for TextEdit scrollbars	2022-10-07 23:16:04 -07:00
Haoyu Qiu	344ed9ec6c	Remove leading spaces from enumerator name hints ... For `PROPERTY_HINT_ENUM` properties, enumerator names can be provided as a comma separated list. There're a few properties that add leading spaces to the names (e.g. `First, Second, Third`). These spaces are included in the Inspector dropdown, which is unexpected. It's better to leave the surrounding spaces untouched because it could be part of the resulting string value (the variable is a string enum). And most other enum hints don't contain surrounding whitespaces. This PR removes the spaces and documents this `PROPERTY_HINT_ENUM` behavior.	2022-10-08 11:33:50 +08:00
Arthur J	b18a553a06	declare "_validate_property" as protected ... In other classes, the function _validate_property is declared as protected (in the case of Area2D), but in Area3D it's declared as private, which causes compile errors when trying to extend the class in a C++ module for example.	2022-10-07 18:36:37 -03:00
Cykyrios	f0d7934055	Fix invalid tooltip position	2022-10-07 22:43:49 +02:00
Rémi Verschelde	c723125dfc	Merge pull request #67020 from GuilhermeGSousa/remove-transition-expression-node ... Remove expression base node for transitions	2022-10-07 14:23:00 +02:00
Guilherme Sousa	12940e53c1	Remove expression base node for transitions	2022-10-07 11:13:43 +02:00
bruvzg	0103af1ddd	Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.	2022-10-07 11:32:33 +03:00
Rémi Verschelde	5b7f62af55	Merge pull request #62910 from Vitika9/gsoc-colorpicker-ux ... ColorPicker UX	2022-10-07 09:49:29 +02:00
bruvzg	a750ca7ec1	Add split caret direction markers. Fix block/overtype caret size.	2022-10-07 08:45:52 +03:00
Gilles Roudière	64e0c138d9	Fix TileMap occluders having a wrong transform	2022-10-06 14:06:33 +02:00
Rémi Verschelde	70d8895396	Merge pull request #66954 from Nidjo123/sample-baked-up-vector ... Handle last baked vector index early	2022-10-06 08:56:59 +02:00
Rémi Verschelde	d414872bfe	Merge pull request #66961 from Rindbee/fix-set_custom_color ... Fix wrong condition used in `set_custom_color`	2022-10-06 08:56:52 +02:00
Rémi Verschelde	48e6f84295	Merge pull request #66951 from rburing/restore_recovery_as_collision ... Revert "Turn on recovery as collisions only for floor snapping"	2022-10-06 08:56:44 +02:00
Rémi Verschelde	f5903215d0	Merge pull request #61902 from Paulb23/multi-caret ... Add Multi-caret support to TextEdit	2022-10-06 08:56:34 +02:00
Rindbee	f359abbe01	Fix wrong condition used in set_custom_color	2022-10-06 12:09:02 +08:00