Commit Graph

5813 Commits

Author SHA1 Message Date
Rémi Verschelde
d75c3d7f49
Merge pull request #33970 from Calinou/improve-video-ram-debugger-ux
Improve the Video RAM debugger UX
2020-01-31 11:38:52 +01:00
Rémi Verschelde
ab2f91bdfb
Merge pull request #35502 from Calinou/profiler-csv-save-anywhere
Allow saving anywhere when exporting CSV measures from the profiler
2020-01-31 11:19:29 +01:00
Rémi Verschelde
7e55472655
Merge pull request #35500 from Calinou/profiler-display-milliseconds
Display times as milliseconds in the profiler and performance monitors
2020-01-31 11:19:03 +01:00
Rémi Verschelde
3b80f03c92
Merge pull request #35332 from Calinou/improve-batch-rename-dialog
Improve the batch rename dialog
2020-01-31 10:48:39 +01:00
Rémi Verschelde
43f84445ba
Merge pull request #35340 from Calinou/optimize-editor-icon-generation
Optimize the editor icon generation
2020-01-31 10:15:01 +01:00
Rémi Verschelde
8f9e1858dd
Merge pull request #34939 from YeldhamDev/scriptdiag_valid_specific
Make ScriptCreateDialog's script valid message a bit more clearer
2020-01-31 10:05:01 +01:00
Rémi Verschelde
67c3ce35bd
Merge pull request #33639 from YeldhamDev/replaced_label_location
Make the replaced results appear in the matches counter
2020-01-31 10:04:27 +01:00
Haoyu Qiu
d1b1edba84 Adds pan and zoom gestures to TextureRegion editor 2020-01-30 11:39:13 +08:00
Hugo Locurcio
fa2fda3244
Use the editor background color for the profiler graph
This leads to a better appearance compared to using pure black.
2020-01-30 03:09:00 +01:00
Michael Alexsander
0faadcae8f Clip warning text in the remote dock 2020-01-29 12:52:07 -03:00
Haoyu Qiu
ca537dea76 Fixes invalid read when using fill tool in empty tilemap 2020-01-27 20:39:49 +08:00
Rémi Verschelde
f76009bbcf i18n: Sync translations with Weblate 2020-01-27 08:11:37 +01:00
Hugo Locurcio
ad49425bd8
Don't show an Online Tutorials section if the class has no tutorials 2020-01-27 01:01:11 +01:00
Rémi Verschelde
4cee1cda5e
Merge pull request #35589 from akien-mga/doc-drop-category-property
doc: Drop unused 'category' property from header
2020-01-26 16:34:13 +01:00
Rémi Verschelde
09ced94dd4 doc: Do not expose Variant::NIL as a type in the class reference
Fix signals Variant arguments incorrectly listed as Nil.

Fixes #12520.
2020-01-26 16:08:11 +01:00
Rémi Verschelde
2d20fc39aa doc: Drop unused 'category' property from header
We already removed it from the online docs with #35132.

Currently it can only be "Built-In Types" (Variant types) or "Core"
(everything else), which is of limited use.

We might also want to consider dropping it from `ClassDB` altogether
in Godot 4.0.
2020-01-26 16:02:39 +01:00
Rémi Verschelde
98e5134059
Merge pull request #35526 from nekomatata/inspector-update-rename-node
Fixed Inspector update when a node is renamed
2020-01-24 21:52:12 +01:00
PouleyKetchoupp
9c4a6cf745 Fixed Inspector update when a node is renamed
Whenever any node is renamed, EditorNode::_edit_current() is called and it resets plugins used for current edited properties. This change forces the inspector to update even though the same object is edited, to make sure all plugins are restored properly from unfolded properties/resources/etc.

Fixes #32832
2020-01-24 18:12:05 +01:00
Rémi Verschelde
4dce3427ef
Merge pull request #35519 from yamgent/wrong-guideline-value
Fix wrong guideline values shown during dragging
2020-01-24 18:10:53 +01:00
Tan Wang Leng
ee2f406c73 Fix wrong guideline values shown during dragging
Suppose that the user wants to use some guidelines in 2D mode. The
user has enabled "Use Pixel Snap", and configured the "Grid Step" to
1px.

On some zoom levels, when dragging the guidelines step by step, some
offsets shows the wrong value. The offsets that are wrong vary - it is
affected by the zoom level, so some zoom levels do not display this
problem.

For example, a user may see this while dragging the guideline:

0px   1px   1px   3px   4px   5px   5px   7px   8px

whereby 2px and 6px are missing.

This is due to a floating-point error. The values are printed as
(truncated) integers, but they are actually decimals, so they were
actually 1.9999 and 5.9999 for the missing cases.

Let's fix that by rounding up the values before printing them to get rid
of the errors.

This fixes #35010.
2020-01-24 23:52:43 +08:00
Hugo Locurcio
a002b93d86
Add explanations for errors related to Vector/Quat normalization 2020-01-24 14:19:23 +01:00
Hugo Locurcio
81f33df84b
Allow saving anywhere when exporting CSV measures from the profiler
Previously, the CSV file could only be saved in `res://`. Since this is
an editor tool, it makes sense to allow saving anywhere on
the filesystem.
2020-01-24 12:18:26 +01:00
Hugo Locurcio
f1d9dbfb08
Display times as milliseconds in the profiler and performance monitors
Small values are easier to read as milliseconds compared to seconds.
2020-01-24 12:07:38 +01:00
Haoyu Qiu
0ca102d568 Fixes leak in Animation Track editor 2020-01-24 11:17:56 +08:00
Rémi Verschelde
8a7a216be5 i18n: Sync translations with Weblate 2020-01-23 23:19:54 +01:00
Haoyu Qiu
b420618c46 Fixes scrollbar positions on HiDPI display
* TextureRegion editor
* Ploygon2D UV editor
2020-01-23 08:55:52 +08:00
Rémi Verschelde
b255744e0f
Merge pull request #35449 from bojidar-bg/35439-scenetree-settings
Add settings from SceneTree in the documentation
2020-01-22 22:02:47 +01:00
Rémi Verschelde
37897dba80
Merge pull request #35406 from lawnjelly/ortho-shadow
Replace CameraMatrix::get_viewport_size with get_viewport_half_extents, shadow culling with ortho camera and other affected issues
2020-01-22 22:02:09 +01:00
Bojidar Marinov
b4770c0a27
Add settings from SceneTree in the documentation
Fixes #35439
2020-01-22 22:37:56 +02:00
Rémi Verschelde
91b0be18dc
Merge pull request #35421 from williamd1k0/improve-top-animation-menu
Use an icon in the top Animation Key menu
2020-01-22 21:21:15 +01:00
William Tumeo
cb3fcba99f Use an icon in the top Animation Key menu 2020-01-22 17:06:40 -03:00
lawnjelly
eaf8e5ce52 Change CameraMatrix::get_viewport_size to get_viewport_half_extents
Fixes #26637.
Fixes #19900.

The viewport_size returned by get_viewport_size was previously incorrect, being half the correct value. The function is renamed to get_viewport_half_extents, and now returns a Vector2.

Code which called this function has also been modified accordingly.

This PR also fixes shadow culling when using ortho cameras, because the correct input for CameraMatrix::set_orthogonal should be the full HEIGHT from get_viewport_half_extents, and not half the width.

It also fixes state.ubo_data.viewport_size in rasterizer_scene_gles3.cpp to be the width and the height of the viewport in pixels as stated in the documentation, rather than the current value which is half the viewport extents in worldspace, presumed to be a bug.
2020-01-22 18:22:00 +00:00
Bojidar Marinov
387ee7d763
Get real default values for project settings in documentation
Also, ignore custom project settings and values for input/ entries

Fixes #34154
2020-01-22 15:57:10 +02:00
Hugo Locurcio
56aae0e8bc
Use a loading placeholder for project icons in the project manager
Now that projects are loaded asynchronously, some projects in the
list may be displayed before their icon is done loading. This is
especially common on slower hardware.

In such cases, this makes the project manager display a loading
placeholder instead of the default project icon.
2020-01-21 22:56:19 +01:00
Rémi Verschelde
4faaf6089a Remove unused #if 0'ed code 2020-01-21 21:41:54 +01:00
Rémi Verschelde
d4ac0ca153
Merge pull request #35393 from YeldhamDev/plugin_script_syntax
Make script made via plugin creation obey syntax settings
2020-01-21 13:21:01 +01:00
Rémi Verschelde
423f15262f
Merge pull request #35399 from ericrybick/35367-signals-dock-size-jumps-when-selecting-nodes
Clip text in NodeDock toolbuttons to prevent dock size changes
2020-01-21 11:18:35 +01:00
Eric Rybicki
371b5a450a Clip text in NodeDock toolbuttons to prevent dock size changes
Fixes #35367
2020-01-21 10:23:09 +01:00
Rémi Verschelde
4bc98c105d
Merge pull request #35394 from ericrybick/fix-assetlib-thumbnail-overlay-
Fix asset library video play overlay not being centered on the thumbnail
2020-01-21 08:20:35 +01:00
Eric Rybicki
99346e9654 Fix asset library video play overlay not being centered on the thumbnail 2020-01-21 08:04:32 +01:00
Michael Alexsander
3a0dc52127 Make script made via plugin creation obey syntax settings 2020-01-21 02:05:56 -03:00
Haoyu Qiu
3042b4f4cb Fixes leak in Find in Files utility 2020-01-21 08:47:59 +08:00
Rémi Verschelde
709665b15d
Merge pull request #35379 from dankan1890/quick_fix
TextureRegionEditor: Corrected typo
2020-01-20 21:34:02 +01:00
dankan1890
a2170dcd40 TextureRegionEditor: Corrected typo 2020-01-20 20:58:42 +01:00
Michael Alexsander
324fe76afd Clip text in EditorPath button to avoid dock size changes 2020-01-20 14:25:27 -03:00
Rémi Verschelde
c3fd1012de
Merge pull request #35351 from ericrybick/32342-Resize-snapping-lines-bug
Fix editor drawing snapping lines for wrong edge/corner when resizing elements with smart snapping enabled
2020-01-20 12:57:44 +01:00
Eric Rybicki
b91b26d073 Fix editor drawing snapping lines for wrong edge/corner when resizing elements with smart snapping enabled
fixes #32342
2020-01-20 08:03:20 +01:00
Haoyu Qiu
ce9453ecf4 Prevent negative zero shown in SpotLight gizmo 2020-01-20 09:08:18 +08:00
Hugo Locurcio
9e3393a624
Optimize the editor icon generation
Icons are no longer upsampled when using an integer editor scale.
This makes some icons slightly less crisp, but the icons themselves
can be adjusted to mitigate this. When using a non-integer editor
scale setting, upsampling is kept as it improves crispness in a
far more visible manner.

When upsampling is disabled, this speeds up the theme generation
by about 100 ms on average, making the project manager and editor
start slightly faster. This also speeds up switching between themes.
2020-01-20 00:31:04 +01:00
Rémi Verschelde
7f7ae0712f i18n: Sync translations with Weblate 2020-01-19 23:19:29 +01:00
Hugo Locurcio
ff135065f4
Improve the batch rename dialog
- Use the editor-defined error, warning and success colors for
  preview texts.
- Make the "Regular Expressions" option into a CheckButton
  (as it does something as soon as it's toggled) and move it out
  of the Advanced Options submenu.
- Make it clearer that the error message originates from an invalid
  regular expression.
- Clarify what the number means in the regex error message.
- Tweak some strings' casing for consistency.
2020-01-19 22:37:56 +01:00
Hugo Locurcio
d72f5e0938
Only create the editor theme once
This prevents the editor theme from being created twice.
This speeds up the project editor and editor startup
significantly; startup is now 1.3 times faster on average
(tested on a debug build). RAM usage was also lowered by 7.5 MB
on average.

This partially addresses #35321.
2020-01-19 21:51:21 +01:00
Hugo Locurcio
8f838f33b7
Improve the Video RAM debugger UX
- Refresh tha tab automatically when switching to it.
- Disable the Refresh button if no project is currently being debugged.
- Scale the column widths on hiDPI displays.
- Rename the tab from "Video Mem" to "Video RAM" for consistency.
2020-01-19 19:03:53 +01:00
Rémi Verschelde
e8dc581bfc
Merge pull request #35303 from timothyqiu/hidpi-anitreeplayer
Fixes AnimationTreePlayer editor UI on HiDPI
2020-01-19 10:21:20 +01:00
Rémi Verschelde
d7072e9cd4
Merge pull request #35273 from dankan1890/quick_fix
AssetLibrary layout fix
2020-01-19 10:13:31 +01:00
Rémi Verschelde
7522aa80c2
Merge pull request #35295 from N0hbdy/animation-editor-line-edit-fix
Fix AnimationTree Editor by using CONNECT_DEFERRED on LineEdit
2020-01-19 09:32:00 +01:00
Rémi Verschelde
b2e2ce1643
Merge pull request #35297 from Calinou/2d-zoom-reset-clamp-editor-scale
Clamp the editor scale to 1 when resetting zoom in the 2D editor
2020-01-19 09:30:12 +01:00
Rémi Verschelde
78c2d41ffc
Merge pull request #35304 from raphael10241024/fix_audiobus_editor
fix audio buses layout editor save
2020-01-19 09:13:05 +01:00
RaphaelHunter
4b70985a1a fix audio buses editor not save, close #26683 2020-01-19 10:56:00 +08:00
Haoyu Qiu
2db685da09 Fixes AnimationTreePlayer editor on HiDPI
* The minimum editor size
* The position of buttons and status text
2020-01-19 10:20:53 +08:00
Hugo Locurcio
c9aca9ef81
Clamp the editor scale to 1 when resetting zoom in the 2D editor
This closes #35294.
2020-01-18 22:26:21 +01:00
N0hbdy
3fffb1c031 Fix AnimationTree Editor by using CONNECT_DEFERRED on LineEdit
Not having this causes the LineEdit to be deleted while still processing
signals, which can cause a crash during focus changes.

Fixes 35293
2020-01-18 12:12:13 -08:00
dankan1890
29daba5b0c AssetLibrary when the download size is unknown:
hidden progress bar
added in the description the downloaded bytes
Fixes #35267
2020-01-18 21:07:51 +01:00
Yuri Roubinsky
41acb1f6ba Fix minimap updating in shader tab 2020-01-18 12:31:33 +03:00
Hugo Locurcio
2897918426
Select the first project when searching in the project manager
This makes the project manager usable for opening existing projects
without ever touching the mouse. Just enter text in the autofocused
search box and press Enter.

This partially addresses #8149.
2020-01-18 00:58:52 +01:00
Hugo Locurcio
8bce0b6176
Mark alternate editor display modes as disabled in the GLES2 renderer
This partially addresses #27018.
2020-01-17 16:06:47 +01:00
Lakshay Angrish
1d9e19c7fb show parametric setters and getters in editor help 2020-01-17 15:10:59 +05:30
Rémi Verschelde
045a5ce14a i18n: Sync translation template with current source 2020-01-16 23:47:18 +01:00
Rémi Verschelde
a0f716763b i18n: Sync translations with Weblate 2020-01-16 23:37:56 +01:00
Rémi Verschelde
05e042b06f
Merge pull request #34879 from Phischermen/canvas-item-editor-local-space-mode
Fix issue regarding rotating Canvas Items in editor
2020-01-16 23:10:41 +01:00
Haoyu Qiu
92b36d4706 Adds NULL check before using image loader 2020-01-16 21:49:23 +08:00
Rémi Verschelde
bc34794840
Merge pull request #34091 from andrycodestuffs/master
Fixed unknown ASCII symbols rendered instead of tabs in bookmarks list
2020-01-16 14:11:28 +01:00
andrycodestuffs
d0b3cb89f7 Fixed unknown symbol drawn instead of tabs in breakpoints/bookmarks lists
Tab characters were not rendered properly in the breakpoints and
bookmarks lists of the script editor if the bookmarked line was a
comment, resulting in unknown ASCII symbols “�”.

Fixes #34046.

Also changed formatting a bit to enclose the code in backticks (like in
Markdown) instead of quotes.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2020-01-16 13:50:30 +01:00
asynts
e564b4fd07 Refactor (and fix) how the connect button is disabled.
It should not be possible to click the "Connect" button unless

  - a node is selected, and
  - that node is valid in the current mode.

The modes are the default and advanced modes which allow connecting to scripts
and nodes respectively.
2020-01-16 12:35:41 +01:00
Rémi Verschelde
fc2550c4c8
Merge pull request #35123 from asynts/asynts.crash-on-double-click
Prevent crash described in #34555.
2020-01-16 12:32:52 +01:00
Aaron Franke
5e1dad3b28
Use int64_t for EditorPropertyInteger and warn when out of double range 2020-01-15 23:39:49 -05:00
Rémi Verschelde
f2d45676c9
Merge pull request #35165 from groud/fix_memleak_filesystemdock
Fixes a memory leak in FileSystemDock
2020-01-15 22:58:57 +01:00
Hugo Locurcio
1339a5c1cb
Add an icon for OGG samples
The icon is the same as WAV samples, as both formats are accepted
in AudioStreamPlayer.

This closes #35163.
2020-01-15 22:32:08 +01:00
Gilles Roudière
76d87e6616 Fixes a memory leak in FileSystemDock
Co-authored-by: Rafał Mikrut <mikrutrafal54@gmail.com>
2020-01-15 21:45:13 +01:00
Haoyu Qiu
43ad6e8c96 Fixes AssetLib crash when JPG module is disabled
JPG module is optional, so check it's existence before using.
2020-01-15 22:16:12 +08:00
asynts
181e74855e Don't close the connection dialog when the validation failed.
Currently the connection dialog is closed when

 1. no method name is specified, or

 2. no script is attached and if the method name isn't a buildin.

That's really annoying.
2020-01-15 10:33:50 +01:00
Rémi Verschelde
40f0649e5b Fix typos with codespell
Using codespell 1.16.0.

See ab3bccdb78 for procedure.
2020-01-15 00:49:52 +01:00
Rémi Verschelde
8d60f5a349
Merge pull request #35132 from Calinou/doc-description-below-brief
doc: Move the class description to be just below the brief description
2020-01-15 00:49:31 +01:00
Hugo Locurcio
3c8abbc4bf
doc: Move the class description to be just below the brief description
- Drop the "Brief description" header as it became redundant
  with this change.
- Fix a bug in the editor help where an extraneous newline was added
  after the header if the class isn't inherited by any others.
- Remove the Category line in the rST markup as it's not useful
  for API users.
2020-01-15 00:05:34 +01:00
Michael Alexsander
34bf81fa7c Cleanup unnecessary code from before the scrollbar overlapping fixes 2020-01-14 18:19:12 -03:00
Rémi Verschelde
8f103b1b69
Merge pull request #34801 from Calinou/add-3d-viewport-crosshair
Add a crosshair to the 3D viewport
2020-01-14 21:02:35 +01:00
asynts
71b4b180ba Prevent crash described in #34555.
Normally it wouldn't be possible to click on the "Connect" button if no node
is selected, because the button would be disabled.

However, double clicking on a node is also hooked up to the same signal
and double clicking is possible even if the "Connect" button is disabled.

This caused a crash described in #34555.
2020-01-14 17:02:18 +01:00
Phischermen
becd1fd1d8 Fix issue regarding rotation
Canvas items will now rotate correctly no matter what their global scale happens to be.
2020-01-14 07:26:34 -08:00
Rémi Verschelde
ea4c88f38a
Merge pull request #35116 from YeldhamDev/more_scrollbar_tweaks
Fix more scrollbar anchorings
2020-01-14 13:55:34 +01:00
Michael Alexsander
e69593842e Fix more scrollbar anchorings 2020-01-14 08:25:55 -03:00
Rémi Verschelde
a565c93aeb Export: Properly disable resource preview thread
Fixes #26857.
Fixes #34433.
Fixes #34826.
2020-01-14 11:34:02 +01:00
Rémi Verschelde
dbbfade584
Merge pull request #35082 from akien-mga/dont-count-yer-chicken
EditorNode: Delay addon init to NOTIFICATION_READY
2020-01-14 08:26:08 +01:00
Michael Alexsander
712cd8a97e Fix more instances of overlapping scrollbars 2020-01-13 22:49:17 -03:00
Hugo Locurcio
2b9f34b867
Add a crosshair to the 3D viewport
The crosshair makes freelook navigation a bit easier, while making it
clearer that it's possible to select nodes by clicking while in
freelook mode.

The crosshair is only displayed while in freelook mode.
It uses an icon designed to be visible on any background.
2020-01-13 22:30:34 +01:00
Rémi Verschelde
017b7de2df EditorNode: Delay addon init to NOTIFICATION_READY
Fixes #25635.
2020-01-13 15:02:11 +01:00
Rémi Verschelde
e2bebfbd4c Use MOUSE_FILTER_PASS for all containers (but PanelContainer)
Containers are meant to forward mouse input to their the Controls
they contain.

PanelContainer has a visible Panel stylebox, so it still defaults
to STOP.

Fixes #34933.
2020-01-13 14:49:01 +01:00
Rémi Verschelde
4a95186b4b Animation editor: Set resource name when duplicating
Fixes #25156.
2020-01-13 13:22:06 +01:00
Hugo Locurcio
929dfe1bcc
Clamp the editor scale to 1 for 2D zoom operations
Some people set the editor scale below 1 to fit more content on
screen, even if their display doesn't have a particularly low DPI.

This closes #35059.
2020-01-13 12:16:27 +01:00
Rémi Verschelde
7a15569c6f
Merge pull request #35050 from Calinou/enlarge-item-list-editor
Increase the size of the item list editor popup
2020-01-13 09:14:02 +01:00
Haoyu Qiu
047d66cc6f Fixes the New Window option in macOS dock menu 2020-01-13 08:58:12 +08:00