75f16b8167
Make global scope enums accessible as types in GDScript
...
Add functions to CoreConstant so enums can be properly deduced. Also add
the enums in release builds to make consistent with ClassDB enums and
avoid differences in script compilation between debug and release.
2023-02-19 13:00:07 -03:00
78cd5d813b
Merge pull request #73501 from anvilfolk/oopsiedaisy
...
Fix inability to assign null regression
2023-02-18 04:38:47 +03:00
24344de4f5
Merge pull request #73448 from RandomShaper/fix_sticky_stack
...
Avoid GDScript bookkeeping from referencing objects longer than necessary
2023-02-17 23:22:20 +03:00
5e9400fa50
Avoid GDScript bookkeeping from referencing objects longer than necessary
2023-02-17 18:59:17 +01:00
8fe023ad93
GDScript: Rework type check
2023-02-17 19:57:18 +02:00
9eb4d1e4bf
Fix inability to assign null regression
...
Co-authored-by: Dmitry Maganov <vonagam@gmail.com>
2023-02-17 11:45:56 -05:00
6212da66e8
Merge pull request #72867 from vnen/gdscript-limit-call-depth
...
GDScript: Add limit to call depth
2023-02-17 17:00:46 +03:00
6e0dd6beca
Merge pull request #72925 from vonagam/fix-enum-typed-array-error
...
GDScript: Fix error about enum typed arrays
2023-02-17 16:47:50 +03:00
68807165f4
Merge pull request #73398 from anvilfolk/fix-getter
...
Fix unset getter return types resulting in strange behavior
2023-02-17 00:31:42 +01:00
a845553898
Merge pull request #73364 from anvilfolk/fix-freed
...
Fix crash by freed object assign to typed variable
2023-02-17 00:31:19 +01:00
c45970739e
Fix crash by freed object assign to typed variable
2023-02-16 15:17:46 -05:00
5972ba17a4
GDScript: Fix infer on read-only property
2023-02-16 15:50:17 +02:00
94dfac8da7
Add return type for GDScript getters
2023-02-15 17:54:38 -05:00
d15511725a
GDScript: Fix `MIN_INT` not representable as numeric literal
2023-02-15 17:41:46 +03:00
8d3e682f52
GDScript: Fix default value of exported enum variable
2023-02-14 18:07:50 +03:00
df6aae2eca
GDScript: Fix missing unsafety mark for binary op with weak variables
2023-02-14 17:01:21 +02:00
436bbfebe2
Tweak `@GlobalScope` & `GDScript`'s documentation
2023-02-14 13:26:18 +01:00
9cb2da89d6
GDScript: Fix usage of ints with typed array of floats
2023-02-13 22:06:38 +02:00
d405392847
Revert "Fixed the jumping to function definition using 'Ctrl+LMB'."
...
This reverts commit 7eb6367d5cFixes #73058 .
Fixes #73167 .
This caused regressions, we'll retry with fixes for 4.1.
2023-02-13 17:58:59 +01:00
be4d8a7b2e
Improve GDScript error for method call on null/previously freed instance
...
Fixes #53878 .
2023-02-12 21:52:05 +01:00
cb2e73d578
Merge pull request #73033 from akien-mga/gdscript-fix-gd4-renames-build
...
Clean up ProjectConverter3To4 architecture, move renames map to separate file
2023-02-11 22:05:38 +01:00
532381562e
Merge pull request #72654 from RandomShaper/ptrcall_ret_raw_obj
...
Avoid losing references to objects in the native-scripting boundary
2023-02-11 15:35:01 +01:00
e19e6b09b9
Clean up ProjectConverter3To4 architecture, move renames map to separate file
...
This allows properly limiting what features depend on the RegEx module
(doing the actual conversion) and what features only require the renames
data (GDScript suggestions).
Also better excludes the conversion command line options when actually
disabling deprecated code.
Fixes #73029 .
2023-02-10 14:35:22 +01:00
220898a69f
GDScript: Remove `treat_warnings_as_errors` project setting
2023-02-10 10:16:33 +03:00
dc7f08b556
Merge pull request #72971 from vnen/gdscript-multiline-comment
...
GDScript: Allow strings as multiline comments
2023-02-09 16:19:03 +01:00
6fca54a81b
Merge pull request #72975 from vnen/gdscript-no-ascii-spoof-check
...
GDScript: Be more lenient with identifiers
2023-02-09 16:12:09 +01:00
03ea77407c
GDScript: Be more lenient with identifiers
...
- Allow identifiers similar to keywords if they are in ASCII range.
- Allow constants to be treated as regular identifiers.
- Allow keywords that can be used as identifiers in expressions.
2023-02-09 11:19:05 -03:00
f95967c299
GDScript: Allow strings as multiline comments
...
Bring back the behavior in 3.x that was left out by oversight.
2023-02-09 10:16:00 -03:00
b12bf7ff02
Merge pull request #69550 from Rindbee/fix-script-editor-not-reload-via-lsp
...
Fix internal editor not updating when using external editor via LSP
2023-02-09 14:01:33 +01:00
cedc5fa823
GDScript: Fix error about enum typed arrays
2023-02-09 00:31:40 +02:00
e822182bb7
Fix null message in assert()
2023-02-08 20:19:24 +01:00
34f0a2ca46
GDScript: Add limit to call depth
...
The hard limit is set at 2048 depth which seems sensible between
legitimate recursive calls while still avoiding a crash because of a
stack overflow in most of the cases.
Note that it is still possible to reach the stack limit and get an
overflow before reaching a call depth. This is intended as a half-way
measure to stop crashing in most cases, since there's no reliable nor
portable way to check the amount of stack memory left.
2023-02-07 17:09:40 -03:00
bd267c911b
Merge pull request #72493 from dalexeev/gds-export-flags
...
GDScript: Improve validation and documentation of `@export_flags`
2023-02-07 19:38:21 +01:00
3f95b39cb3
Merge pull request #72789 from Vilcrow/fix-jump-to-definition
...
Fixed the jumping to function definition using 'Ctrl+LMB'.
2023-02-07 19:37:50 +01:00
c8e3d8b5d5
GDScript: Improve validation and documentation of `@export_flags`
2023-02-07 19:32:08 +03:00
826e54fa73
Some code simplifications
...
1. `number_width` isn't used later
2. `return_type` is used only once
3. AudioServer::get_singleton()->get_channel_count() always returns a channel_count of 1 or larger
4. negative `aa->backward` conditional
5. `current_canvas` == `find_world_2d()->get_canvas()`
6. identical if `render_shadows`
2023-02-07 14:30:16 +01:00
54770ba9c5
GDScript: Fix invalid character error message
2023-02-07 10:56:10 +03:00
7eb6367d5c
Fixed the jumping to function definition using 'Ctrl+LMB'.
2023-02-07 05:29:48 +03:00
945207885b
Merge pull request #72546 from vonagam/fix-typed-array-can-reference
...
GDScript: Fix can_reference check for typed arrays
2023-02-06 23:32:47 +03:00
c0edea37ef
Merge pull request #72677 from dalexeev/gds-await-infer-type
...
GDScript: Fix `await` type inference
2023-02-06 23:32:28 +03:00
7b86a082be
Merge pull request #72804 from vnen/gdscript-no-onready-without-node
...
GDScript: Fix inheritance check of @onready for inner classes
2023-02-06 23:03:44 +03:00
685db28e29
GDScript: Fix `await` type inference
2023-02-06 23:02:14 +03:00
9d16250353
Merge pull request #70002 from poohcom1/fix/static-subscript-autocomplete
...
Fix code-completion suggesting non-static members for custom classes
2023-02-06 23:02:12 +03:00
de4369ca4b
Merge pull request #72708 from KoBeWi/PackedMultilineStringArray
...
Fix @export_multiline for PackedStringArray
2023-02-06 23:01:16 +03:00
8400308ab3
GDScript: Fix can_reference check for typed arrays
2023-02-06 22:00:16 +02:00
ed5ddab7e5
GDScript: Fix inheritance check of @onready for inner classes
2023-02-06 14:52:13 -03:00
2fdaf2919c
GDScript: Fix recently merged test not ignoring warnings
2023-02-06 18:19:34 +01:00
eee343210d
Merge pull request #72330 from MinusKube/unreachable_code_bug
...
Fix unreachable code warning for elif block
2023-02-06 17:49:37 +01:00
d201df1ffa
Merge pull request #72512 from vonagam/fix-ternary-type-source
...
GDScript: Fix type certainty for result of ternary operator
2023-02-06 19:41:27 +03:00
8a37fad281
Merge pull request #72794 from vnen/gdscript-no-onready-without-node
...
GDScript: Don't allow @onready without inheriting Node
2023-02-06 15:41:02 +01:00
3941af3d91
GDScript: Don't allow @onready without inheriting Node
2023-02-06 10:45:38 -03:00
31749de128
GDScript: Better handling of `@rpc` annotation and autocompletion
2023-02-05 21:21:37 +03:00
13f0158e49
Merge pull request #72608 from vnen/gdscript-warning-default-error
...
GDScript: Add warnings that are set to error by default (take 2)
2023-02-05 16:00:26 +03:00
2b71ede967
Fix @export_multiline for PackedStringArray
2023-02-04 17:06:58 +01:00
8753b07b05
Merge pull request #71860 from GeroVeni/master
...
Improve docs for rpc annotations
2023-02-04 18:43:15 +03:00
54f2226ce5
Improve docs for rpc annotations
2023-02-04 13:28:41 +00:00
0bcc7bb5c7
Avoid losing references to objects in the native-scripting boundary
2023-02-03 17:48:41 +01:00
604493eb6e
Merge pull request #65910 from KoBeWi/gdsus
...
Cleanup function state connections when destroying instance
2023-02-03 16:13:06 +01:00
a43ec333c4
Merge pull request #72398 from vnen/gdscript-setter-chain
...
GDScript: Improve usability of setter chains
2023-02-02 16:28:07 +01:00
273bf7210f
GDScript: Add warnings that are set to error by default
...
- Adds a list of default levels for all warning so they can be set
individually.
- Add warnings set by default to error for:
- Using `get_node()` without `@onready`.
- Using `@onready` together with `@export`.
- Inferring a static type with a Variant value.
- Overriding a native engine method.
- Adjust how annotations to ignore warnings are treated so they also
apply to method parameters.
- Clean up a bit how ignored warnings are set. There were two sets but
only one was actually being used.
- Set all warnings to the `WARN` level for tests, so they they can be
properly tested.
- Fix enum types in native methods signatures being set to `int`.
- Fix native enums being treated as Dictionary by mistake.
- Make name of native enum types use the class they are defined in, not
the direct super class of the script. This ensures they are always
equal even when coming from different sources.
- Fix error for signature mismatch that was only showing the first
default argument as having a default. Now it shows for all.
2023-02-02 12:07:25 -03:00
5fc7918594
GDScript: Improve usability of setter chains
...
- Consider PackedArrays non-shared since they are copied on C++/script
boundaries.
- Add error messages in the analyzer when assigning to read-only
properties.
- Add specific error message at runtime when assignment fails because
the property is read-only.
2023-02-02 10:20:35 -03:00
9b93bdb4e7
Fix crash in gdscript when autocompleting virtual function and signature does not match base.
2023-02-02 22:52:08 +10:00
824784f80b
Merge pull request #72557 from vonagam/fix-make-value-protection
...
GDScript: Fix getting reduced value of incomplete subscript for autocomplete
2023-02-02 09:49:37 +01:00
4311836be2
GDScript: Fix crash in export group annotations
2023-02-02 08:37:39 +03:00
7b04e3865a
GDScript: Fix getting reduced value of incomplete subscript
2023-02-02 02:15:26 +02:00
1a810ff45e
GDScript: Fix type certainty for result of ternary operator
2023-02-01 14:52:29 +02:00
061b046401
Merge pull request #72499 from vonagam/fix-typed-array-disassembly
...
GDScript: Fix disassembly of typed array assignment and construction
2023-02-01 11:03:25 +01:00
afe3b94ab2
Revert "GDScript: Add warnings that are set to error by default"
...
This reverts commit a166833bfaFixes #72501 .
2023-02-01 10:54:22 +01:00
56aedb256e
GDScript: Fix disassembly of typed array assignment and construction
2023-02-01 11:18:54 +02:00
e101305950
Merge pull request #72487 from vnen/gdscript-warning-default-error
...
GDScript: Add warnings that are set to error by default
2023-02-01 08:23:42 +01:00
9aeda3b282
Merge pull request #72490 from resistor/disasm
...
Fix disassembly of OPCODE_CONSTRUCT_TYPED_ARRAY.
2023-02-01 08:02:04 +01:00
ab2f8ab6ce
Merge pull request #72371 from dalexeev/remove-gds-str-duplicate
...
Remove `@GDScript.str` (duplicate of `@GlobalScope.str`)
2023-02-01 07:25:02 +01:00
835309c0a5
Fix disassembly of OPCODE_CONSTRUCT_TYPED_ARRAY.
...
Found while inspecting the bytecode for godot-benchmarks.
2023-01-31 21:52:51 -06:00
a166833bfa
GDScript: Add warnings that are set to error by default
...
- Adds a list of default levels for all warning so they can be set
individually.
- Add warnings set by default to error for:
- Using `get_node()` without `@onready`.
- Using `@onready` together with `@export`.
- Inferring a static type with a Variant value.
- Overriding a native engine method.
- Adjust how annotations to ignore warnings are treated so they also
apply to method parameters.
- Clean up a bit how ignored warnings are set. There were two sets but
only one was actually being used.
- Set all warnings to the `WARN` level for tests, so they they can be
properly tested.
- Fix enum types in native methods signatures being set to `int`.
- Fix native enums being treated as Dictionary by mistake.
- Make name of native enum types use the class they are defined in, not
the direct super class of the script. This ensures they are always
equal even when coming from different sources.
- Fix error for signature mismatch that was only showing the first
default argument as having a default. Now it shows for all.
2023-02-01 00:05:14 -03:00
925784df03
Merge pull request #72454 from dalexeev/gds-fix-icon-annotation
...
GDScript: Fix `@icon` annotation
2023-01-31 15:58:49 +01:00
6d9c9d30b9
Merge pull request #72206 from vnen/gdscript-allow-void-return-shorthand
...
GDScript: Allow void functions to return calls to other void functions
2023-01-31 15:55:35 +01:00
361f3f1721
Merge pull request #57520 from jordigcs/gd-rename-map
...
Add hint for identifiers renamed from 3.x to 4.0
2023-01-31 15:55:25 +01:00
83cb968965
GDScript: Fix `@icon` annotation
2023-01-31 17:43:54 +03:00
a47d4d57ca
GDScript: Allow void functions to return calls to other void functions
2023-01-31 11:37:30 -03:00
e768e02b78
Merge pull request #72444 from reduz/fix-global-class-parsing
...
Fix global script class parsing.
2023-01-31 13:20:00 +01:00
1bbe0a2b2f
Fix global script class parsing.
...
* Broke with #72226
* Restored previous version of the code, made it even more error tolerant.
* Added a warning to **not** change the code.
Fixes #72226 .
2023-01-31 12:43:25 +01:00
99a44f8469
Merge pull request #69248 from vonagam/fixing-typed-arrays
...
GDScript: Fix typed arrays
2023-01-31 11:04:21 +01:00
5909f9f075
GDScript: Fix issues with typed arrays
2023-01-31 11:54:41 +02:00
b6a8b8e8f7
Merge pull request #72212 from anvilfolk/gdtestnames
...
Add option to print filenames in GDScript unit testing
2023-01-31 10:53:28 +01:00
199e5dbb1e
Add option to print filenames in GDScript unit testing
2023-01-30 22:20:45 -05:00
dc7fb30485
Merge pull request #72400 from vnen/gdscript-match-release-consistency
...
GDScript: Fix match branches return check on release
2023-01-30 20:27:12 +01:00
65407dd42d
GDScript: Fix match branches return check on release
...
The check for existence of `return` only existed on debug builds for
match branches. This could lead on an invalid error after exporting. Now
this is checked on relase too, so it works the same as the editor.
2023-01-30 15:18:36 -03:00
011b3895db
GDScript: Fix vararg method calls with exact arguments
2023-01-30 19:38:07 +02:00
af57bdb193
Merge pull request #72305 from dalexeev/gfs-fix-export-enum
...
GDScript: Fix `@export_enum` works only with `int`
2023-01-30 14:47:12 +01:00
be4f36b87e
Remove `@GDScript.str` (duplicate of `@GlobalScope.str`)
2023-01-30 14:29:07 +03:00
d4b78c352f
GDScript: Fix `@export_enum` works only with `int`
2023-01-30 12:30:37 +03:00
a2817eca03
Merge pull request #72175 from dalexeev/gds-fix-export-group-annotations
...
GDScript: Fix broken export group annotations
2023-01-30 10:00:54 +01:00
2b60d9d6e1
Fix unreachable code warning for elif block
2023-01-29 20:29:23 +01:00
5a283bdbcd
Allow unicode identifier in GDScript syntax highlighter
2023-01-29 13:17:05 +08:00
a3dae9e548
Merge pull request #72285 from vnen/gdscript-variable-match
...
GDScript: Allow variables in match patterns
2023-01-29 02:45:48 +01:00
9420116f6c
Merge pull request #72286 from vnen/gdscript-native-static-call-crash
...
GDScript: Avoid calling non-static methods on native classes
2023-01-29 02:23:55 +01:00
4011a0915e
Merge pull request #71844 from vonagam/fix-constant-conversions
...
GDScript: Fix constant conversions
2023-01-29 02:18:57 +01:00
aee7b7363b
GDScript: Avoid calling non-static methods on native classes
2023-01-28 20:33:01 -03:00
c68b2358d5
GDScript: Allow variables in match patterns
...
To restore an ability available in 3.x and reduce compatibility changes.
2023-01-28 19:53:27 -03:00
31e0ae2012
GDScript: Fix constant conversions
2023-01-29 00:01:53 +02:00
6194a7e0fa
GDScript: Fix implicit conversions for function returns
2023-01-28 23:56:07 +02:00
218bef90af
GDScript: Fix test from #69163 after annotations change
2023-01-28 17:01:19 +01:00
cc6e8379d4
Merge pull request #69163 from vonagam/variant-safe-lines
...
GDScript: Fix wrong marking of some lines related to Variant as unsafe
2023-01-28 15:40:19 +01:00
1d68ce2cce
GDScript: Fix broken export group annotations
2023-01-27 16:25:15 +03:00
abe6d67232
GDScript: Fix test for read-only state of constants
2023-01-27 05:28:08 +02:00
a5c211641f
Merge pull request #71634 from dalexeev/gds-annotations-analyzer
...
GDScript: Allow constant expressions in annotations
2023-01-26 01:07:00 +01:00
944b44243d
Merge pull request #72008 from vonagam/fix-property-access-unsafe-mark
...
GDScript: Fix marking of line with unsafe property access as unsafe
2023-01-26 01:04:57 +01:00
22a0c200c6
[GDScript] Perform update-and-assign operations in place when possible.
...
This turns two bytecode operations into one by using the assignment
destination directly as the output of the binary operator. This manifests
in operations like `+=`.
2023-01-25 10:22:04 -06:00
b004f8180e
GDScript: Allow constant expressions in annotations
2023-01-25 18:43:56 +03:00
e93266b9ff
Merge pull request #71120 from jordigcs/ternary
...
Closes https://github.com/godotengine/godot/issues/71065
2023-01-25 12:23:11 -03:00
41e5f5b093
Merge pull request #71349 from vonagam/disallow-infer-on-weak
...
GDScript: Disallow type inference with untyped initializer
2023-01-25 14:42:20 +01:00
3c308f42e2
GDScript: Fix marking of line with unsafe property access as unsafe
2023-01-25 01:45:40 +02:00
bb9a00889a
Add hint for identifiers renamed since Godot 3
2023-01-24 12:33:55 -06:00
13215638a9
Clarify error message about script-level annotation
2023-01-24 13:10:45 +03:00
ba9491f870
Merge pull request #70948 from vnen/gdscript-ptr-method-name-in-debug
2023-01-23 12:24:15 -03:00
81fe3715b8
Merge pull request #71914 from vnen/gdscript-no-continue-match
...
GDScript: Remove function of `continue` for match statement
2023-01-23 15:35:55 +01:00
80e06b29e7
GDScript: Add names for disassembling function pointers
...
When instructions use function pointers, it's not possible to retrieve
their original names in the disassembly. This stores the names in
vectors (in debug builds) so they can be shown.
2023-01-23 11:04:31 -03:00
5726bf578d
Merge pull request #71676 from vnen/gdscript-unicode-identifiers
...
Add support for Unicode identifiers in GDScript and Expression
2023-01-23 10:24:33 +01:00
9462ae4783
GDScript: Remove function of `continue` for match statement
...
The keyword is confusing and rarely is used in the intended way. It is
removed now in favor of a future feature (pattern guards) to avoid
breaking compatibility later.
2023-01-22 18:45:24 -03:00
64edc7a5c2
Fix internal editor not updating when using external editor via LSP
2023-01-22 18:27:22 +08:00
7548e043fc
Add support for Unicode identifiers in GDScript
...
This is using an adapted version of UAX#31 to not rely on the ICU
database (which isn't available in builds without TextServerAdvanced).
It allows most characters used in diverse scripts but not everything.
2023-01-21 13:39:40 -03:00
ebd0b40f6e
Merge pull request #71687 from reduz/support-script-class-name-in-efs
...
Support script global resource name in EditorFileSystem
2023-01-21 16:54:23 +01:00
dddd8d43f6
Support script global resource name in EditorFileSystem
...
* Works for binary and text files.
* Makes EditorQuickOpen work with custom resources again.
* Information is cached and easily accessible.
Properly fixes #66179 . Supersedes #66215 and supersedes #62417
**WARNING**: This required breaking backwards binary compatibility (.res and .scn files). Files saved after this PR is merged will no longer open in any earlier versions of Godot.
2023-01-21 14:19:27 +01:00
e9d8c261a5
call update_exports from LSP didSave function
...
exports in the inspector were not properly appearing when a gdscript was saved using an external IDE
this commit adds a call to GDScript::UpdateExports toward the end of GDScriptTextDocument::didSave
2023-01-20 19:16:53 -08:00
7e5c2f945d
Remove references to compiled GDScript in export
...
This feature was removed from GDScript so it should not be present on
the interface nor in the saved export presets.
2023-01-20 15:09:07 -03:00
2e488072d0
Allow standalone ternary expressions
2023-01-19 14:27:57 -06:00
807b7ed557
Update `@icon` definition to add a note
2023-01-18 19:48:01 -05:00
4854e723be
Fix unnammed enum crash regression
2023-01-18 09:35:48 -05:00
4005fc4b8d
Merge pull request #71279 from vonagam/fix-iterator-number-type
...
GDScript: Fix typing of iterator in for loop
2023-01-16 22:21:26 +01:00
1c3653e083
Merge pull request #67774 from aaronfranke/script-annotations
...
Make script annotations be placed before `class_name` and `extends`
2023-01-16 22:20:44 +01:00
585a934454
Merge pull request #71434 from adamscott/fix-reduce-identifier-from-base-class-script-retrieval
...
Fix cyclic reference errors while reducing identifiers
2023-01-16 22:15:21 +01:00
629796c333
Merge pull request #69970 from poohcom1/fix/autocomplete-custom-class
...
Fixes https://github.com/godotengine/godot/issues/69941
2023-01-16 09:44:23 -03:00
48e041458f
Fix cyclic reference errors while reducing identifiers.
...
Co-authored-by: Dmitrii Maganov <vonagam@gmail.com>
2023-01-15 19:19:25 -05:00
2e53bf3d36
Fix code-completion suggesting non-static members
...
In GDScript code-completion:
- Fixes class symbols not being marked as meta
- Remove signal in static contexts
Fixes #69928
2023-01-16 00:41:20 +07:00
aa4bceff3e
Add identifier completion for custom classes.
...
Previously, custom class would only auto-complete for types in GDScript.
This applies it to identifiers as well.
2023-01-16 00:25:24 +07:00
4c1f11944e
Update all outdated online documentation links
2023-01-14 19:38:00 +03:00
9bd5ef1836
Fix GDScript script templates to use a PascalCase style for `_CLASS_`
2023-01-14 16:21:05 +03:00
a1e0281b45
GDScript: Disallow type inference with untyped initializer
2023-01-13 20:51:29 +02:00
ef01b49227
Merge pull request #71329 from vnen/gdscript-fix-enum-value-resolution
...
GDScript: Fix infinite recursion in resolution of enum values
2023-01-13 18:02:58 +01:00
4c2dea108e
Merge pull request #70540 from vaartis/multiline-arrays-dictionaries
...
Implement export_multiline support for Array[String] and Dictionary
2023-01-13 18:01:55 +01:00
40613ebd21
GDScript: Fix typing of iterator in for loop
2023-01-13 15:36:11 +02:00
3a5e41293c
GDScript: Fix infinite recursion in resolution of enum values
2023-01-13 10:17:30 -03:00
aaa5158ff9
Merge pull request #70733 from vonagam/fix-assigning-untyped
...
GDScript: Fix some issues with assignments that involve untyped things
2023-01-12 20:08:55 +01:00
40b9c246b6
Merge pull request #71197 from adamscott/add-default-virtual-path-gdscript
...
Add default virtual `gdscript://` path to `GDScript` instances
2023-01-12 17:56:09 +01:00
def592114f
Merge pull request #70700 from vonagam/fix-abstract-extends
...
GDScript: Fix extending abstract classes, forbid their construction
2023-01-12 17:19:51 +01:00
274d49790d
GDScript: Fix extending abstract classes, forbid their construction
2023-01-12 17:47:10 +02:00
e3e55b29ce
Add default virtual `gdscript://` path to `GDScript` instances
2023-01-12 10:27:38 -05:00
ef81b344be
GDScript: Fix wrong marking of some lines related to Variant as unsafe
2023-01-12 17:21:33 +02:00
38c214d483
GDScript: Fix some issues with assignments that involve untyped things
2023-01-12 17:07:45 +02:00
c6f4c0ac54
Merge pull request #70899 from adamscott/fix-vector-inf
...
Fix parse error using Vector{2,3,4}.INF
2023-01-12 15:59:01 +01:00
5980abbcec
GDScript: Fix getting type from PropertyInfo for Variant arguments
2023-01-12 16:47:06 +02:00
75515e4303
Merge pull request #70987 from vonagam/fix-parameter-conversion-assign
2023-01-12 11:34:13 -03:00
7319fa6082
Merge pull request #70713 from vonagam/fix-unnamed-enum-outer-conflicts
2023-01-12 11:22:01 -03:00
0f184379de
GDScript: Fix small inconsistencies with resolve_datatype
2023-01-12 15:52:55 +02:00
66fda2aeea
GDScript: Fix temp values being written without proper clear
...
Temporary values in the stack were not being properly cleared when the
return value of calls were discarded, which can cause memory issues
especially for reference types like PackedByteArray.
2023-01-11 14:24:23 -03:00
5eb161a9c8
Merge pull request #70595 from adamscott/add-gdscript-editorconfig
...
Add GDScript `.editorconfig` rules
2023-01-11 01:10:10 +01:00
04d0e851ea
GDScript: Fix use of conversion assign for variant values
2023-01-10 20:01:11 -03:00
44d1d72af1
Add GDScript `.editorconfig` rules
...
- Uniformize `.gd` unit test files indentation to tabs (where needed)
2023-01-10 12:25:35 -05:00
c894edd4cb
Merge pull request #71140 from vonagam/fix-const-index-subscript-type
...
GDScript: Fix type for index subscript on constant
2023-01-10 07:58:29 +01:00
ff505c9875
GDScript: Fix type for index subscript on constant
2023-01-10 07:10:00 +02:00
fb175d92da
Fix GDScript base and outer classes, signals and functions lookup order
...
- Add outer class lookup test
- Add signal lookup test
Co-authored-by: Dmitrii Maganov <vonagam@gmail.com>
2023-01-09 20:12:10 -05:00
d3fc9d9e41
Merge pull request #71051 from vonagam/consts-are-deep-start
...
GDScript: Begin making constants deep, not shallow or flat
2023-01-09 23:22:59 +01:00
509da86205
Merge pull request #69590 from anvilfolk/enums
...
GDScript enum fixes & refactor
2023-01-09 23:10:37 +01:00
366ec895b1
Assorted enum and native type fixes
2023-01-09 11:08:07 -05:00
df952a32f8
Merge pull request #71107 from vnen/gdscript-fix-nil-address-assign
...
GDScript: Don't use the NIL address to hold return value of functions
2023-01-09 14:22:16 +01:00
c2f7c2d31a
Merge pull request #70655 from vonagam/fix-assert-multiline
...
GDScript: Fix multiline and trailing comma for assert
2023-01-09 14:19:37 +01:00
a1309f1f42
GDScript: Allow using await on calls to void functions
2023-01-09 09:55:05 -03:00
a3816434a6
GDScript: Don't use the NIL address to hold return value of functions
...
This prevents that the NIL address is filled with another value, which
causes problems for some instructions that read from NIL.
2023-01-09 09:20:18 -03:00
b6be2ac621
Merge pull request #71028 from adamscott/make-gdscript-clear-less-prone-to-heap-use-after-free
...
Resolve `GDScript::clear()` `heap-use-after-free` ASAN errors
2023-01-09 09:22:39 +01:00
c45b9245ae
Fix parse error using Vector{2,3,4}.INF
2023-01-08 16:14:40 -05:00
71f7c8a9d3
GDScript: Fix multiline and trailing comma for assert
2023-01-08 20:18:46 +02:00
5e2ac1a31e
GDScript: Begin making constants deep, not shallow or flat
2023-01-08 07:29:10 +02:00
d5e1b4a857
Force double quotes for NodePaths with apostrophes
2023-01-07 20:23:26 -06:00
d22199990e
Resolve `GDScript::clear()` `heap-use-after-free` ASAN errors
2023-01-07 11:51:36 -05:00
163f6f5fe8
Merge pull request #68429 from KoBeWi/PropertySettings
...
Add PropertyInfo overload for GLOBAL_DEF
2023-01-06 22:59:29 +01:00
532ffc30bd
GDScript: Fix typing of lambda functions
2023-01-06 16:38:22 +02:00
a8c2f8a0e1
GDScript: Fix missing conversion for default argument values
2023-01-06 11:49:06 +02:00
10e364bf43
GDScript: Fix array as default value for parameter
2023-01-06 06:25:55 +02:00
a1d06749f1
Unify typing of variables, constants and parameters in GDScript
2023-01-06 01:10:04 +02:00
d95794ec8a
One Copyright Update to rule them all
...
As many open source projects have started doing it, we're removing the
current year from the copyright notice, so that we don't need to bump
it every year.
It seems like only the first year of publication is technically
relevant for copyright notices, and even that seems to be something
that many companies stopped listing altogether (in a version controlled
codebase, the commits are a much better source of date of publication
than a hardcoded copyright statement).
We also now list Godot Engine contributors first as we're collectively
the current maintainers of the project, and we clarify that the
"exclusive" copyright of the co-founders covers the timespan before
opensourcing (their further contributions are included as part of Godot
Engine contributors).
Also fixed "cf." Frenchism - it's meant as "refer to / see".
2023-01-05 13:25:55 +01:00
fc4a734373
Merge pull request #70838 from reduz/gdscript-vm-optimization
...
Optimizations for GDScript VM
2023-01-05 12:57:31 +01:00
dc3175e4cd
Merge pull request #70810 from adamscott/cache-gdscript-even-when-error
...
Cache script when reloading even if there's errors
2023-01-04 11:41:11 +01:00
8203e09330
Merge pull request #70859 from vonagam/fix-preload-native-type
...
GDScript: Fix wrong native type for preloaded class
2023-01-03 23:22:23 +01:00
26bed8aa85
Merge pull request #70875 from MewPurPur/stop-highlighting-invalid-node-refs
...
Stop NodeRef highlighting if you start with a number
2023-01-03 16:17:13 +01:00
52cfd4551d
Stop highlighting node refs if they are invalid identifiers
2023-01-03 16:00:16 +02:00
4e360ac612
Merge pull request #70702 from vnen/gdscript-error-on-assign-void
...
GDScript: Error when assigning return value of void function
2023-01-03 12:23:00 +01:00
e4c1103af4
Merge pull request #70656 from vonagam/fix-void-returns
...
GDScript: Disallow return with value in void functions
2023-01-03 12:20:33 +01:00
a797fa3b3d
Merge pull request #70503 from rune-scape/inner-class-docs
...
Inner classes get their docs back
2023-01-03 12:15:44 +01:00
961b4ac5f5
GDScript: Fix wrong native type for preloaded class
2023-01-03 05:45:06 +02:00
7211e041df
Optimizations for GDScript VM
...
* Removed instruction argument count and instruction prefetching. This is now done on the fly. Reduces jumps.
* OPCODE_DISPATCH now goes directly to the next instruction, like in Godot 3.x.
I have nothing I can use to test performance, so if anyone wants to lend a hand and compare with master (both on debug and release), it would be very welcome.
2023-01-02 23:44:19 +01:00
c3f12592da
Cache script when reloading even if there's errors.
2023-01-01 14:09:17 -05:00
8a98110e3e
Merge pull request #62688 from cdemirer/assignments-and-types
...
Fixes https://github.com/godotengine/godot/issues/62650
2022-12-30 16:38:35 -03:00
bc739a4687
GDScript: Make using return of void function an error
...
Remove the `VOID_ASSIGNMENT` warning since those cases will be errors
now.
2022-12-30 13:35:38 -03:00
33afa82fb0
Merge pull request #70613 from vonagam/fix-enum-as-constant
...
Fixes https://github.com/godotengine/godot/issues/54018
Fixes https://github.com/godotengine/godot/issues/70213
Fixes https://github.com/godotengine/godot/issues/70495
2022-12-30 12:10:50 -03:00
0c15844551
GDScript: Error when assigning return value of void function
...
This also makes built-in method calls empty the return value when the
method is void, to avoid keeping returning a garbage value in such case.
2022-12-30 12:08:58 -03:00
056066ee95
GDScript: Fix false name conflicts for unnamed enums
2022-12-29 22:04:13 +02:00
9507f65e25
GDScript: Disallow return with value in void functions
2022-12-29 03:06:13 +02:00
b6aa4840d8
Fix usage of Enum as constant
2022-12-28 23:04:40 +02:00
f67aa3e46d
GDScript: Fix return type of constructor call for extending class
2022-12-27 23:02:12 +02:00
bbb21c3fd5
Fix type adjustment skipped when value is considered both not hard and not variant
2022-12-25 17:11:30 +03:00
60692b4e45
Implement export_multiline support for Array[String] and Dictionary
...
For arrays, specifically check if it's a string array and pass the
type on to the editor. For dictionaries, save the hint on the type and
use it later to draw the multiline editor, except for when adding a
string key, because that doesn't make much sense. All string values
however will be drawn as multiline.
2022-12-25 01:46:57 +03:00
1b77993257
Inner classes get their docs back
2022-12-23 17:39:24 -05:00
ae4c025da9
Merge pull request #69991 from rune-scape/cast-type
...
GDScript: Fix cast producing null
2022-12-23 09:22:21 +01:00
edfa1e8665
Merge pull request #70220 from adamscott/fix-external-enum
...
Fix external enums not assignable as constants
2022-12-23 09:20:50 +01:00
e1657bd2a7
Merge pull request #70440 from rune-scape/null-again
...
Fix GDScript analyzer null literal
2022-12-22 16:02:19 +01:00
801ef6614d
Merge pull request #70138 from anvilfolk/signals
...
Add MethodInfo to signal datatype
2022-12-22 16:02:11 +01:00
3228fdb88a
Fix GDScript analyzer null literal
2022-12-22 06:02:34 -05:00
abaedb54f1
Remove unused code paragraph from gdscript_editor.cpp/complete_code
2022-12-22 11:10:11 +03:00
d93dbab054
Add MethodInfo to signal datatype
2022-12-21 22:49:51 -05:00
fb418685a0
Unify GDScriptAnalyzer in-editor and runtime autoload checks
2022-12-20 19:01:28 -05:00
6590e1fd8a
Make script annotations placed before class_name and extends
2022-12-19 22:01:29 -06:00
78d296d7ca
Add a note for `inst_to_dict` to prevent using it on built-in instances
2022-12-19 19:12:00 +03:00
e780dc332a
Merge pull request #70275 from rune-scape/autoload-subscript-regression
...
Fix autoload subscript regression
2022-12-19 01:12:35 +01:00
9f6ad59da7
Fix autoload subscript regression
2022-12-18 18:36:41 -05:00
e9f3e7111f
Merge pull request #70237 from quentinguidee/refactor/fix-comma-instead-of-semicolon
...
Fix use of comma instead of semicolon
2022-12-18 16:55:10 +01:00
e0f1e02cc7
Fix use of comma instead of semicolon
...
Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com>
2022-12-17 20:17:04 -05:00
7fc814f697
Fix external enums not assignable as constants
...
- Add external enums test
- Rename external inner class test
- Clean up `GDScriptAnalyzer::reduce_identifier_from_base` class
behavior
2022-12-17 17:59:38 -05:00
1bbb2b4159
Fix outer class lookup
2022-12-17 17:57:00 -05:00
2fefcf7329
Fix inner class constant assignment
2022-12-17 12:03:03 -05:00
8d52eea52b
Merge pull request #70000 from rune-scape/find-more-classes
...
GDScript: Fix built-in script `find_class` bugs
2022-12-17 16:30:34 +01:00
213c94b42f
Fix enum value regression
2022-12-16 22:48:25 -05:00
f18f2740da
Merge pull request #70131 from rune-scape/preload-type-regression
...
Fix preload type regression
2022-12-16 00:31:26 +01:00
2a341a6321
Fixed GDScript crashed when two consecutive unary operators are analysed
2022-12-16 04:45:53 +06:30
17e03c29d6
Fix preload type regression
2022-12-15 16:47:13 -05:00
e1c63fee86
GDScript: Fix built-in script and other `find_class` bugs
2022-12-15 14:56:23 -05:00
3684fd249e
Fix `GDScript::_get_gdscript_from_variant()` crash
...
The crash would happen, theoretically, when getting the type of a invalid
variant.
2022-12-15 12:29:01 -05:00
6debf86d51
Merge pull request #69471 from rune-scape/rune-out-of-order
...
GDScript: Out of order member resolution
2022-12-15 07:56:23 +01:00
2dfc6d5b69
GDScript: Allow out of order member resolution
2022-12-14 21:44:05 -05:00
7d0d6aa16f
GDScript: Fix cast producing null
2022-12-12 19:57:26 -05:00
08449ab16e
Fix String type compatibility being too permissive
2022-12-12 07:27:41 -05:00
1bfaa73e14
Merge pull request #69416 from anvilfolk/default-val
...
Add GDScript implicit type conversion for member variables with initializers
2022-12-11 23:58:22 +01:00
c8293a73b4
Add GDScript member initializer implicit type conversion
2022-12-11 16:55:02 -05:00
8410e7c9c6
Merge pull request #66733 from MewPurPur/unary-op-warnings
...
Fix unary op warnings never showing
2022-12-11 22:33:58 +01:00
7c6b659bd7
Add PropertyInfo overload for GLOBAL_DEF
2022-12-11 21:36:48 +01:00
05097ded0a
Merge pull request #69897 from poohcom1/fix/function-return-completion
...
Fix autocomplete on functions returning variants
2022-12-11 15:18:24 +01:00
98e1a2031d
Fix subscript of preloaded script
2022-12-11 07:59:43 -05:00
1845d927dc
Fix autocomplete on functions returning variants
...
- When guessing return type, check type hints before last return value
2022-12-11 14:17:27 +07:00
0139bd04b2
Fix `GDScriptCache::clear()` crash when clearing packed scenes
2022-12-10 19:10:12 -05:00
8f6f244680
Merge pull request #69587 from adamscott/fix-constant-base-typing-in-extended-class
...
Fix constants scope in extended or inner GDScript classes
2022-12-10 21:58:50 +01:00
beaef88abd
Remove debug macro for GDScriptLanguage script_list
2022-12-10 14:09:04 -05:00
65a49bad5a
Fix constant base typing in extended GDScript class
2022-12-10 13:39:45 -05:00
ff544df926
Fix `GDScriptCache` to not remove scripts/scenes individually when clearing
2022-12-10 12:48:07 -05:00
1ac7e5a334
Merge pull request #69518 from rune-scape/rune-analyze-values
...
GDScript: Preload should make native type
2022-12-10 11:29:50 +01:00
f6ea295bb1
Merge pull request #69467 from rune-scape/rune-subclass-script-path
...
GDScript: Fix subclass script path issues
2022-12-10 10:21:19 +01:00
907298d673
Merge pull request #68747 from rune-scape/rune-stringname-unification
...
GDScript: Unify StringName and String
2022-12-09 18:06:48 +01:00
da65b61edb
Fix autocomplete crash as it would infinite loop
2022-12-08 23:40:17 -05:00
59c6642f2a
Add missing packed scene cache clear inside `GDScriptCache::clear()`
2022-12-07 15:29:18 -05:00
b229a19688
Fix lookup to docs for variables initialized with `get_node`
2022-12-07 15:16:04 +03:00
9bd7ad53f7
Merge pull request #69506 from adamscott/move-gdscript-uninit-to-finalize
...
Move GDScript uninitialization to `GDScriptLanguage::finish()`
2022-12-06 16:11:21 +01:00
88f3045301
Move GDScript uninitialization to `GDScriptLanguage::finalize()`
...
Co-authored-by: Ricardo Buring <ricardo.buring@gmail.com>
Co-authored-by: kleonc <9283098+kleonc@users.noreply.github.com>
2022-12-06 09:35:39 -05:00
George Marques
Yuri Sizov
Pedro J. Estébanez
Dmitrii Maganov
ocean (they/them)
Rémi Verschelde
Danil Alexeev
Micky
pkowal
Rémi Verschelde
kobewi
Markus Sauermann
S.V.I. Vilcrow
GeroVeni
Eric M
Owen Anderson
Juan Linietsky
MinusKube
Haoyu Qiu
jordi
Rindbee
Adam Wardell
Adam Scott
poohcom1
Yuri Sizov
Yuri Rubinsky
VolTer
cdemirer
Ekaterina Vaartis
rune-scape
Aaron Franke
Quentin Guidée
stmSi