Commit Graph

1446 Commits

Author SHA1 Message Date
Rémi Verschelde c5dcbeb160 Scene: Ensure classes match their header filename
Also drop some unused files.

Renamed:
- `scene/2d/navigation2d.h` -> `navigation_2d.h`
- `scene/2d/screen_button.h` -> `touch_screen_button.h`
- `scene/3d/scenario_fx.h` -> `world_environment.h`
- `scene/audio/audio_player.h` -> `audio_stream_player.h`
- `scene/resources/bit_mask.h` -> `bit_map.h`
- `scene/resources/color_ramp.h` -> `gradient.h`
- `scene/resources/shape_line_2d.h` -> `line_shape_2d.h`
- `scene/resources/scene_format_text.h` -> `resource_format_text.h`
- `scene/resources/sky_box.h` -> `sky.h`

Dropped:
- `scene/resources/bounds.h`
2019-02-12 17:21:48 +01:00
Rémi Verschelde b7cc2bb1e2 Core: Ensure classes match their header filename
Also drop some unused files.

Renamed:
- `core/dvector.h` -> `pool_vector.h`
- `core/io/resource_import.h` -> `resource_importer.h`
- `core/sort.h` -> `sort_array.h`
- `core/string_db.h` -> `string_name.h`

Dropped:
- `core/allocators.h`
- `core/os/shell.h`
- `core/variant_construct_string.cpp`
2019-02-12 13:34:25 +01:00
Rémi Verschelde ba0a4a942e i18n: Sync translation template with current source 2019-02-10 13:19:03 +01:00
qarmin c8f084b0d5 Fix latest regression error in SpriteFramesEditor 2019-02-09 12:50:19 +01:00
Rémi Verschelde 8253cdbda3
Merge pull request #25692 from YeldhamDev/spriteframes_editor_changes
Small changes to the SpriteFrames editor
2019-02-08 19:52:20 +01:00
Rémi Verschelde 5e837b3f13
Merge pull request #25552 from groud/better_error_message
Displays errors and warnings in a better way in the script editor
2019-02-08 17:03:55 +01:00
Michael Alexsander Silva Dias d3082c99b5 Small changes to the SpriteFrames editor 2019-02-07 22:54:59 -02:00
hsandt 5165a90ef6 [Script Editor] Refactored ScriptTextEditor::_edit_option by extracting EDIT_TOGGLE_COMMENT case
CodeEditor::toggle_inline_comment is now used by both ScriptTextEditor and ShaderEditor
2019-02-04 20:21:08 +01:00
Gilles Roudière 5f981d7fef Displays errors and warnings in a better way in the script editor 2019-02-01 17:20:59 +01:00
Rémi Verschelde 58de384978
Merge pull request #25540 from JFonS/remove_gizmo_errors
Fix gizmo errors on "Align with view"
2019-02-01 14:12:37 +01:00
JFonS 2232d3336e Fix gizmo errors on "Align with view" 2019-02-01 12:16:05 +01:00
volzhs 1c14da3273 Remove unnecessary call VS::get_singleton() twice 2019-01-29 02:55:13 +09:00
Rémi Verschelde 2ad6212a3f
Merge pull request #25372 from JFonS/add_gizmo_docs
Minor fixes and documentation for Spatial Gizmos
2019-01-27 19:06:42 +01:00
JFonS e90fb5b0ab Minor fixes and documentation for Spatial Gizmos 2019-01-27 18:40:01 +01:00
Rémi Verschelde 1bed784c9a
Merge pull request #25380 from godotengine/fix_pivot
Fixes the pivot setting with control nodes
2019-01-27 18:20:06 +01:00
Juan Linietsky a089061120 Fix pixelized previews, but also instances of breaking ImageTexture cache. Closes #25378. 2019-01-27 13:41:47 -03:00
Gilles Roudiere d3619f8743 Disables the Layout menu when a Control node is child of a container 2019-01-27 16:36:10 +01:00
Gilles Roudiere 3cfd80b0bf Fixes the pivot setting with control nodes 2019-01-27 15:51:45 +01:00
qarmin 6c159acf47 Add third point to move Rectangle Shape 2D in two axis 2019-01-25 09:49:28 +01:00
groud 8676370aa5 Fixes Node2D selection not adapting to editor zoom level 2019-01-24 20:43:11 +01:00
Rémi Verschelde 4a184a79e0
Merge pull request #25215 from akien-mga/scripteditor-goto-line
Fix going to script line on VisualScript errors
2019-01-22 12:19:15 +01:00
Rémi Verschelde 79a4c41b22 Fix going to script line on VisualScript errors
Fixes #18103, which was a regression from #16888.
2019-01-22 10:55:55 +01:00
Michael Alexsander Silva Dias f1cd587bbd Make the Texture Region Editor able to edit regions of Sprite3Ds 2019-01-21 16:52:57 -02:00
groud 056ea997e5 Displays the pivot all the time and rotate the icon 2019-01-18 19:30:45 +01:00
Juan Linietsky 541422a4a2 Clean up and fix issues after merging #21701 , closes #21104 2019-01-18 13:01:24 -03:00
Rémi Verschelde e4f1b995cc Fix radio buttons support in ItemListEditorPlugin
This was missed in bf14a6deff.
2019-01-17 16:14:01 +01:00
jlahman b8a524efa3 Fix order of a nullptr test in canvas item editor 2019-01-16 01:11:11 -05:00
Juan Linietsky 96445cd90e Clear internal vertex counter when redrawing polygons, closes #24862. 2019-01-15 15:43:55 -03:00
Juan Linietsky 6f884cc884 Use SceneTreeDock to replace particles node properly, fixes #24162 2019-01-14 13:41:54 -03:00
Rémi Verschelde 0222841357 i18n: Sync translation template with current source 2019-01-14 16:42:58 +01:00
Rémi Verschelde 8972c05e80
Merge pull request #24899 from YeldhamDev/poly2duv_editor_undoredo_fix
Fix UndoRedo operations for the new features in the Polygon2D UV Editor
2019-01-11 10:08:05 +01:00
Juan Linietsky 2cd15849f9 Fixes to auto triangle editing in BlendSpace2D 2019-01-10 21:40:46 -03:00
Michael Alexsander Silva Dias 7cef10a503 Fix UndoRedo operations for the new features in the Polygon2D UV Editor 2019-01-10 22:20:06 -02:00
groud c48f92e394 Fixes 2D bones selection 2019-01-09 20:55:04 +01:00
Guilherme Felipe c7d4807b7b Hides error_panel of state machine on the first time. 2019-01-09 15:16:41 -02:00
x2f b50fa06c6d
Fix for issue #24810 (find in files logic)
Match case check box was used for whole words as well as match case.
2019-01-09 00:23:46 -05:00
Juan Linietsky e46f28e02d Removed splits in Polygon editor, replace by internal vertices and polygon support. 2019-01-08 19:11:08 -03:00
Rémi Verschelde ac8ae09bc3 i18n: Sync translation template with current source
Misc fixes to source strings.
2019-01-07 16:57:52 +01:00
Rémi Verschelde db33b03f49
Merge pull request #24814 from YeldhamDev/animtree_editor_statemach_scrolls
Move scrolls in the StateMachine editor inside the panel
2019-01-07 15:11:05 +01:00
Michael Alexsander Silva Dias 67ac8fe359 Move scrolls in the StateMachine editor inside the panel 2019-01-07 00:21:48 -02:00
Guilherme Felipe 59df3ca911 Fix state machine scroll 2019-01-06 12:35:12 -02:00
Rémi Verschelde 495e40cff8
Revert "Fix blend tree generating wrong node names" 2019-01-04 19:45:39 +01:00
Timo Schwarzer 163e0e3ebd
Add thumbnails to LargeTexture 2019-01-03 13:09:25 +01:00
Rémi Verschelde f1d1ecb383
Merge pull request #24686 from YeldhamDev/autotile_grid_separation_fix
Fix incorrect grid snapping in TileSet editor with separation
2019-01-01 19:04:04 +01:00
Rémi Verschelde b16c309f82 Update copyright statements to 2019
Happy new year to the wonderful Godot community!
2019-01-01 12:58:10 +01:00
Rémi Verschelde d1f3b622f0 Fix missing/malformed license headers 2019-01-01 12:46:36 +01:00
Michael Alexsander Silva Dias 07fdd2c702 Fix incorrect grid snapping in TileSet editor with separation 2018-12-31 13:36:51 -02:00
Rémi Verschelde ac46862097
Merge pull request #24506 from JFonS/expose_gizmos
Expose the new gizmo plugin system to scripting
2018-12-30 15:42:30 +01:00
Rémi Verschelde 1d7b69ebbc
Merge pull request #24664 from SoIAS/graph_node_headers_statemachine-24458
Removed graph node headers from state machine nodes
2018-12-30 14:06:58 +01:00
Michael Alexsander Silva Dias 4a91f94c13 Add undo-redo to the TileSet editor, and other improvements 2018-12-30 10:54:03 -02:00
Dawid Wdowiak 58ae20f239 Removed graph node headers from state machine nodes 2018-12-30 09:25:13 +01:00
Michael Alexsander Silva Dias 8aad7ef016 General fixes for the TileSet editor 2018-12-24 18:27:43 -02:00
Guilherme Felipe 8a202bc223 Fix blend tree generating wrong node names
Now it's possible to connect nodes again.
2018-12-22 12:18:04 -02:00
JFonS 6b15b4f904 Expose the new gizmo plugin system to scripting 2018-12-21 23:56:39 +01:00
Rémi Verschelde be8c0d57c5
Merge pull request #24519 from Chaosus/error_label_fix
Change LinkLabel back to Label in error status bar
2018-12-21 10:14:04 +01:00
Rémi Verschelde f09956c86c
Merge pull request #24513 from YeldhamDev/fix_tileset_editor_draw
Fix small drawing error in TileSet editor
2018-12-21 10:09:00 +01:00
Chaosus 260b5818f1 Change LinkLabel back to Label in error status bar 2018-12-21 11:39:54 +03:00
Michael Alexsander Silva Dias daf54133c2 Fix small drawing error in TileSet editor 2018-12-20 19:52:56 -02:00
Guilherme Felipe 21bad78bd8 Fixes for TileSetEditor and TileMapEditor
[TileSetEditor] Hide Bitmask and Priority for ATLAS_TILE
[TileMapEditor] Hide "Disable autotile" if the selected tile isn't
autotile
Fix #22756, don't update bitmask when tilemode is ATLAS_TILE
2018-12-20 15:31:45 -02:00
Rémi Verschelde 26058376aa
Merge pull request #24462 from guilhermefelipecgs/fix_copy_paste_tilemap
Fix copy/paste for TileMap
2018-12-19 08:43:52 +01:00
Guilherme Felipe 06a929ace7 Fix copy/paste for TileMap
Fix #24440
2018-12-18 22:48:59 -02:00
Michael Alexsander Silva Dias 2b278a5336 Small fixes for the AnimationTree editor 2018-12-18 15:24:22 -02:00
Rémi Verschelde 1621270f26
Merge pull request #24432 from YeldhamDev/animationtree_editor_fixes
General fixes for the AnimationTree editor
2018-12-18 09:08:10 +01:00
Rémi Verschelde 75c6ad9756
Merge pull request #24427 from guilhermefelipecgs/fix_bread_crumb
Fix bread crumb of AnimationTree
2018-12-18 09:06:57 +01:00
Michael Alexsander Silva Dias 3c9ce2406b Make the AnimationTree editor's path section more obvious 2018-12-17 23:52:14 -02:00
Michael Alexsander Silva Dias b86b497cec General fixes for the AnimationTree editor 2018-12-17 21:03:58 -02:00
Guilherme Felipe 317561863d Fix bread crumb of AnimationTree 2018-12-17 17:08:41 -02:00
Rémi Verschelde 28b10ea668 Fix sometimes uninitialized variable warning raised by Xcode 9.4.1
Fixes this warning raised by Travis CI on macOS:
```
editor/plugins/polygon_2d_editor_plugin.cpp:95:6: warning: variable 'skeleton' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
        if (!node->has_node(node->get_skeleton())) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
editor/plugins/polygon_2d_editor_plugin.cpp:106:7: note: uninitialized use occurs here
        if (!skeleton) {
             ^~~~~~~~
editor/plugins/polygon_2d_editor_plugin.cpp:95:2: note: remove the 'if' if its condition is always false
        if (!node->has_node(node->get_skeleton())) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
editor/plugins/polygon_2d_editor_plugin.cpp:94:22: note: initialize the variable 'skeleton' to silence this warning
        Skeleton2D *skeleton;
                            ^
                             = NULL
```
2018-12-17 12:28:11 +01:00
Michael Alexsander Silva Dias 9d4a996a08 Fix titles in graph editors being invisible when headers are enabled 2018-12-16 23:18:04 -02:00
Guilherme Felipe bcd2659a2f Fix "undo" of the state machine losing node's position 2018-12-16 18:06:26 -02:00
Rémi Verschelde 2f31d31c23
Revert "Use more subtle indentation guides in the script editor" 2018-12-13 19:57:34 +01:00
Rémi Verschelde 17c3c64a80 i18n: Sync translation template with current source
Also French translation update and misc fixes to source strings.
2018-12-13 14:47:24 +01:00
Rémi Verschelde 4d27b1fe4f
Merge pull request #24109 from remorse107/godotengine-path2d-editor-fix
Fixed Path2D Plugin Editor so segments can be split.
2018-12-12 16:02:55 +01:00
Rémi Verschelde c8a5400654
Merge pull request #24241 from Rubonnek/move-to-initializer-list
Moved member variables to initializer list
2018-12-12 09:25:34 +01:00
Wilson E. Alvarez 08f22f1cf0
Moved member variables to initializer list 2018-12-11 18:33:01 -05:00
Mariano Suligoy 1884952ae3 Fix "index -1 out of range" error spam when the Editor is using translations. Fixes #24277 2018-12-11 08:26:36 -03:00
Andrii Doroshenko (Xrayez) feb12559e6 Properly reselect duplicated visual shader nodes
This makes it much easier to drag duplicated nodes away from original ones.
2018-12-10 14:20:58 +02:00
Rémi Verschelde bf59b73250
Merge pull request #20609 from YeldhamDev/menu_hover_explicit
Make opening menus with the same parent on mouse focus explicit
2018-12-09 23:15:33 +01:00
Rémi Verschelde 3a312dbd32
Merge pull request #20725 from Calinou/textedit-subtle-indent-guides
Use more subtle indentation guides in the script editor
2018-12-09 23:10:32 +01:00
Rémi Verschelde dc54ee18ae
Merge pull request #24236 from Xrayez/fix-20212
Fix duplicating visual shader nodes
2018-12-09 21:45:05 +01:00
Andrii Doroshenko (Xrayez) 86eb6951c7 Fix duplicating visual shader nodes 2018-12-09 15:37:57 +02:00
Michael Alexsander Silva Dias 1bb14971e5 Minor changes to the File menu in the Script Editor 2018-12-08 15:59:15 -02:00
Guilherme Felipe 69f6f787c0 Add Z-Index for Autotile 2018-12-07 18:42:56 -02:00
Robert Morse bce3599bd7 Fixed an issue with the Path2D plugin editor not supporting the capability to split curves as its toolbar buttons originally advertised. 2018-12-07 08:27:36 -06:00
Rémi Verschelde c2e96c65b3
Merge pull request #23327 from YeldhamDev/search_shaders
Added "shader" filter to "Find in Files"
2018-12-07 15:11:32 +01:00
Michael Alexsander Silva Dias d514ac405b Hide "Script" section in the "TilesetEditorContext" 2018-12-07 02:18:02 -02:00
Rémi Verschelde 3f1bec5887
Merge pull request #23977 from YeldhamDev/editor_plugins_improvements
General enhancements to the Polygon2D, TextureRegion, and TileSet editors
2018-12-06 16:26:16 +01:00
David Kennedy 29284f628c Fixes editor crashing when editing autotiles issue #24004 2018-12-06 07:15:48 -03:00
Michael Alexsander Silva Dias e4d0ecce7a General enhancements to the Polygon2D, TextureRegion, and TileSet editors 2018-12-06 03:29:27 -02:00
Rémi Verschelde 99640ac583
Merge pull request #24165 from YeldhamDev/light_occluder_reuse_polygon
Make LightOccluder2D Editor use the AbstractPolygon Editor instead of its own
2018-12-05 08:59:29 +01:00
Michael Alexsander Silva Dias 53764a5ee6 Make LightOccluder2D Editor use the AbstractPolygon Editor instead of its own 2018-12-04 18:25:19 -02:00
Michael Alexsander Silva Dias 3ae5eec366 Add tooltips to GraphEdit node 2018-12-04 15:00:27 -02:00
asheraryam 79ca8e7305 Use filename as fallback instead of the class name for mesh instance loaded by dragging from file to editor. 2018-12-02 23:41:09 +02:00
Rémi Verschelde 8dd00ed176
Merge pull request #24117 from Paulb23/txt_file_last_modified_time
Fix text files constantly asking for reload as no last modified time
2018-12-02 21:45:24 +01:00
Paulb23 69fe17639e Fix text files constantly asking for reload as no last modified time 2018-12-02 16:24:23 +00:00
Michael Alexsander Silva Dias 2823251c2f Fix ItemList editor not hiding on node removal 2018-11-30 01:59:29 -02:00
Aaron Franke cb01268562 Fix many errors found by PVS-Studio
Fix errors 2, 3, 4, 6, 8, 9, 11, 12, 13, 14, and 15.
2018-11-28 05:03:24 -05:00
Juan Linietsky cdafb7bce2 Properly show 2D bone previews in 2D skeleton UV editor, fixes #20950 2018-11-22 22:23:19 -03:00
Rémi Verschelde da31d63f76
Merge pull request #23680 from YeldhamDev/unified_help_search_revived
Unified Class and Reference Search 2: Resurrection
2018-11-22 16:16:52 +01:00
Rémi Verschelde edbecf5908
Merge pull request #23875 from Chaosus/error_btn
Allows user to click on error line in status bar to jump into error.
2018-11-22 16:06:39 +01:00
Chaosus 1129d83272 Allows user to click on error line to jump into error. 2018-11-22 11:55:36 +03:00
Juan Linietsky 9018e8b132 Add Discrete and Carry blend modes for BlendSpace2D, allows to fix #20135 2018-11-21 16:07:24 -03:00
Ray Koopa fddffa9eb8 Unify editor class and reference search
Co-authored-by: Michael Alexsander Silva Dias <michaelalexsander@protonmail.com>
2018-11-20 20:52:27 -02:00
Michael Alexsander Silva Dias da7d3c5a58 Make opening menus with the same parent on mouse focus explicit 2018-11-20 20:37:45 -02:00
Rémi Verschelde 57b634ad3d
Merge pull request #23813 from JFonS/change_gizmo_default
Change default gizmo visibility and icons
2018-11-20 08:50:18 +01:00
JFonS e5a4fa5281 Change default gizmo visibility and icons 2018-11-18 22:01:09 +01:00
Rémi Verschelde 9eb4b6d91a
Merge pull request #23748 from groud/fix_drag_and_drop_canvas_items
Fixes drag and drog of image files on scaled nodes
2018-11-17 17:20:50 +01:00
Rémi Verschelde efd4228892 EditorSettings: Rename invert_y-axis to invert_y_axis for consistency
No other option uses a dash in its identifier.
2018-11-17 16:19:02 +01:00
groud 60f2e94c08 Fixes drag and drog of image files on scaled nodes 2018-11-16 16:55:28 +01:00
Juan Linietsky 7f347cc31a It is now possible to cancel on 2D polygon editor. RMB (previously close) and ESC will cancel polygon. Closes #15474 2018-11-13 18:50:54 -03:00
Ibrahn Sahir ed337085cf Fixed various uninitialised member variables in editor plugins. 2018-11-11 17:32:47 +00:00
Juan Linietsky d16ce4a8ed Many fixes to script editor remote debugger, closes #13346 2018-11-11 09:16:27 -03:00
Rémi Verschelde f2873e5d06
Merge pull request #23638 from DualMatrix/tileset_spam
Fixed error spam when deleting cell in tileset
2018-11-10 21:53:11 +01:00
DualMatrix b6c386a3b0 Fixed error spam when deleting cell in tileset
Fixes #23556 and should fix #21549
2018-11-10 18:52:52 +01:00
Juan Linietsky eb2d7228cd Make TextureRegion grid settings occupy less space, closes #12679 2018-11-10 08:08:27 -03:00
Rémi Verschelde d4c62e714c
Merge pull request #23578 from Liangdi/master
fix tile set editor crash when drawing polygon shapes
2018-11-09 15:57:31 +01:00
Rémi Verschelde eef2625ae5
Merge pull request #23059 from groud/change_ci_selection
Allow the Container children selection but don't allow them to move
2018-11-09 10:04:34 +01:00
Juan Linietsky 531dc2f435 Proper time tracking in AnimationNodeAnimation, closes #22887 2018-11-08 16:51:45 -03:00
Liangdi 5116c009c9 fix tile set editor crash when drawing polygon shapes 2018-11-08 02:10:13 +08:00
groud 0ec448d21d Fixes icons in itemlist not working 2018-11-07 18:29:24 +01:00
Rémi Verschelde de0d306558
Merge pull request #23383 from groud/better_tilemap_transform
Enhance the tilemap transform buttons
2018-11-06 22:27:29 +01:00
groud 742a9d9023 Fixes uniform scaling issues (for real this time) 2018-11-06 21:51:48 +01:00
groud c2b6a900fc Fixes uniform scaling weird behavior 2018-11-05 23:31:57 +01:00
Michael Alexsander Silva Dias f6d137d3d0 Added "shader" filter to "Find in Files" 2018-11-05 12:13:08 -02:00
Rémi Verschelde 06a133bdd1
Merge pull request #23518 from volzhs/confirmed_already_connected
Fix error with a specific dock layout
2018-11-05 13:06:27 +01:00
Rémi Verschelde 5f8af252e8 doc: Use HTTPS for docs.godotengine.org and point to latest branch
Fixes #23509.
2018-11-05 08:46:27 +01:00
Rémi Verschelde 935537c531
Merge pull request #23508 from Paulb23/clone_last_line_issue_21811
Fix clone line undo history and extra new line, issue 21811
2018-11-05 08:38:42 +01:00
Rémi Verschelde 4c63772f54
Merge pull request #22622 from JFonS/fix_particle_animation
Remove animation loop from ParticlesMaterial + improvements to CPUParticles2D
2018-11-05 07:59:30 +01:00
volzhs 9f62f79dbb Fix error with a specific dock layout 2018-11-05 11:45:25 +09:00
Paulb23 6c54cb8bff Fix clone line undo history and extra new line, issue 21811 2018-11-04 18:33:16 +00:00
JFonS 85ce4a67ed Remove animation loop from ParticlesMaterial + improvements to CPUParticles2D
Remove animation loop from ParticlesMaterial and move it to
SpatialMaterial for 3D particles and Particles2D for the 2D case.

Added animation to CPUParticles2D as well as the "Convert to
CPUParticles2D" to the PAarticles2D menu.
2018-11-04 15:58:12 +01:00
groud 952f3004f1 Fixes CollisionShape extends not updating when draggind handles 2018-11-03 19:15:10 +01:00
Rémi Verschelde a3501c096f
Merge pull request #21897 from Calinou/3d-display-camera-coordinates
Display camera coordinates in the 3D viewport's information pane
2018-11-02 11:33:22 +01:00
Pedro J. Estébanez d856ec611a Let TileSet editor sanitize out tiles with wrong textures 2018-11-02 04:54:28 +01:00
Rémi Verschelde 91e5782795
Merge pull request #23311 from YeldhamDev/editor_capitalization_fix
Small capitalization fixes across the editor
2018-11-01 21:37:33 +01:00
Juan Linietsky 755249f7d9
Merge pull request #22311 from Xrayez/fix-22037
Fix blend tree editor updating invalid blend tree node graph
2018-11-01 16:59:48 -03:00
Rémi Verschelde 9000b1a75d
Merge pull request #22938 from groud/open_spriteframes_on_animatedsprites_edit
Opens the SpriteFrames editor when editing an AnimatedSprite
2018-11-01 10:49:38 +01:00
Rémi Verschelde c7928bc27f
Merge pull request #23195 from Liangdi/master
support New TileSet Editor zooming use CTRL/CMD + MouseWheel
2018-11-01 10:37:27 +01:00
groud 0c2ebbe626 Add an overlay on editor to display error messages 2018-10-30 18:53:58 +01:00
groud a05ef683a5 Allow the Container children selection but don't allow them to move 2018-10-30 14:56:55 +01:00
groud bdb5282ea0 Enhance the tilemap transform buttons 2018-10-30 14:43:52 +01:00
Michael Alexsander Silva Dias ec00ec08aa Fix issues with the "Search Results" panel 2018-10-27 22:48:09 -03:00
Michael Alexsander Silva Dias f3835282c4 Small capitalization fixes across the editor 2018-10-26 16:11:36 -03:00
Liangdi aaa7f625df support New TileSet Editor zooming use CTRL/CMD + MouseWheel
fixed code style for clang-format

apply clang-format
2018-10-26 23:58:58 +08:00
Michael Alexsander Silva Dias 46d02bade4 Fix inconsistences in some buttons in the Canvas/Spatial editor menubar 2018-10-25 12:15:39 -03:00
Rémi Verschelde 3f23b2ecf4
Merge pull request #23017 from Calinou/increase-source-font-line-spacing
Increase the source font's line spacing
2018-10-25 17:31:24 +02:00
Rémi Verschelde 48c6844b00
Merge pull request #23171 from capnm/fix-orthogonal-mode-freelook
Disable 'freelook' in the orthogonal mode.
2018-10-25 11:35:32 +02:00
Rémi Verschelde bf737ee8da
Merge pull request #23211 from YeldhamDev/spatial_editor_preview_adjustment
Readjust "Preview" button in Spatial editor
2018-10-25 10:58:50 +02:00
M. Huri b46ba24e3b Repaired mistyped of 'its' on several files. 2018-10-25 07:19:21 +07:00
Martin Capitanio 808b46cfc2 Fix 'Align selection with view' in orthogonal mode
Fixes #23096
2018-10-22 17:05:16 +02:00
Michael Alexsander Silva Dias 36575fe628 Readjust "Preview" button in Spatial editor 2018-10-21 23:06:27 -03:00
Rémi Verschelde 3ac0e8d0df
Merge pull request #23181 from Calinou/tweak-min-panel-sizes-hidpi
Resize some editor panel minimum sizes on hiDPI displays
2018-10-21 11:26:58 +02:00
Timo a94e25016b
Merge pull request #22972 from YeldhamDev/3d_view_perspective_button
Make "Perspective" button look like a actual clickable button
2018-10-21 03:59:59 +02:00
Hugo Locurcio f126b61748
Resize some editor panel minimum sizes on hiDPI displays
This also increases the plugin description TextEdit's height,
so that 3 lines can be viewed instead of just 2 (leaving a few pixels
for the scroll bar).
2018-10-20 22:09:42 +02:00
Martin Capitanio 9548707298 Disable 'freelook' in the orthogonal mode.
Fixes #23095
Thanks @aaronfranke for hints.

Fixes #23078
2018-10-20 12:49:33 +02:00
Dualtagh Murray b902a2f2a7 Fixing warnings generated by MSVC
Fixes #22684.
2018-10-19 11:45:24 +02:00
Rémi Verschelde cb30b60de6
Merge pull request #23112 from groud/fix_viewport_not_updating
Fixes viewport scrollbars not updating with plugins
2018-10-19 11:19:49 +02:00
Michael Alexsander Silva Dias 9d69c34990 Make "Perspective" button look like a actual clickable button 2018-10-18 22:36:59 -03:00
groud ced6f43455 Fixes viewport scrollbars not updating with plugins 2018-10-18 14:06:57 +02:00
Rémi Verschelde 0d8284d3d4
Merge pull request #23037 from SeleckyErik/issue-23036
Hide header and footer in AssetLib when not necessary
2018-10-17 16:13:44 +02:00
Zaven Muradyan b58c46fc9c Add tooltip to skeleton menu button.
Fixes #23008.
2018-10-17 00:53:29 -07:00
Rémi Verschelde 49aa1be9b6
Merge pull request #22738 from akerudesu/script_comments
Improve toggle comment function in script editor
2018-10-16 15:07:07 +02:00
Erik cd759c773d Hide header and footer in AssetLib when not necessary
Reduces visual clutter by hiding pages navigator header and footer in AssetLib if no results are
found or when results fit on one page one page.

Fix for issue #23036
2018-10-15 19:26:57 +02:00
Hugo Locurcio 976b3e3284
Increase the source font's line spacing
This also increases line spacing in license texts in the editor's
About dialog.
2018-10-14 21:39:49 +02:00
merumelu 27596f6031 TileSetEditor: Don't crash when adding invalid files 2018-10-11 17:15:01 +02:00
groud 2b71f52831 Opens the SpriteFrames editor when editing an AnimatedSprite 2018-10-11 17:03:14 +02:00
Unknown c3d40e42ce Improve toggle comment function in script editor. 2018-10-09 19:39:45 +02:00
Rémi Verschelde c5da418b0b
Merge pull request #22698 from Calinou/fix-find-files-hidpi
Fix Find in Files font size on hiDPI displays
2018-10-07 11:43:39 +02:00
Rémi Verschelde bf6dcb9105
Merge pull request #22722 from akien-mga/fix-warnings
Fix more "may be used initialized" warnings from GCC 7
2018-10-07 11:07:13 +02:00
Rémi Verschelde 44d82b3a07
Merge pull request #22752 from aaronfranke/equals-redundant
Remove redundant "== true" and "== false" code
2018-10-07 10:58:45 +02:00
Hugo Locurcio 1a2f6cfcb5
Make the 3D viewport menu button easier to read
This closes #22809.
2018-10-06 23:00:33 +02:00
Aaron Franke 4f7b33cdcf Remove redundant "== false" code
Some of this code has been re-organized.
f
2018-10-06 16:20:41 -04:00
Aaron Franke 37386f112b Remove redundant "== true" code
If it can be compared to a boolean, it can be evaluated as one in-place.
2018-10-06 16:12:36 -04:00
Hugo Locurcio 7063878243
Fix Find in Files font size on hiDPI displays
This closes #22692.
2018-10-05 21:37:26 +02:00
William Tumeo af10067727 Improve ResourcePreloader editor plugin
Fix #22724 by adding an Open Resource button
Add a Remove button to each tree item
Remove the old Remove button and its useless code
Adjust columns min width
Remove Resource names and move icons to the left
Add a Resource icon fallback
2018-10-05 14:59:10 -03:00
Rémi Verschelde 3e9740ac93 Fix more "may be used initialized" warnings from GCC 7
Fixes the following GCC 7 warnings:
```
core/cowdata.h:269:47: warning: 'alloc_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/error_macros.h:163:26: warning: 'nearest_point' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1579:5: warning: 'colormap_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1582:12: warning: 'size_height' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1590:23: warning: 'size_width' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1599:29: warning: 'pixel_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/math/face3.cpp:207:15: warning: 'tri_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/math/face3.cpp:209:15: warning: 'tri_min' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:665:22: warning: 'best_used_frame' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/rasterizer_storage_gles3.cpp:865:27: warning: 'blit_target' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/rasterizer_storage_gles3.cpp:980:29: warning: 'blit_target' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/shader_gles3.h:122:9: warning: '<anonymous>.ShaderGLES3::Version::frag_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/shader_gles3.h:122:9: warning: '<anonymous>.ShaderGLES3::Version::id' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/shader_gles3.h:122:9: warning: '<anonymous>.ShaderGLES3::Version::vert_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/plugins/script_editor_plugin.cpp:1980:31: warning: 'se' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/scene_tree_dock.cpp:840:30: warning: 'new_node' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4259:9: warning: 'a1' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4259:9: warning: 'lll' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4259:9: warning: 'lul' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4260:9: warning: 'a2' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4261:9: warning: 'a3' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4265:3: warning: 'enable_lin' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4294:3: warning: 'enable_ang' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4311:34: warning: 'll' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4311:34: warning: 'ul' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1655:47: warning: 'cone_dirs' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1656:73: warning: 'cone_weights' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/gui/texture_progress.cpp:181:6: warning: 'cp' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/gui/texture_progress.cpp:181:6: warning: 'cq' may be used uninitialized in this function [-Wmaybe-uninitialized]
servers/physics/shape_sw.cpp:1056:19: warning: 'support_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
```
2018-10-04 18:54:20 +02:00
Rémi Verschelde 8068d0217a
Merge pull request #22715 from groud/fix_tilemap_editor
Fixes tilemap editor offset tile selection
2018-10-04 18:20:29 +02:00
Simon Wenner 10718b0961 Fix some cppcheck errors
cppcheck: fix broken pre-processor statement
cppcheck: fix Uninitialized struct members in canvas editor plugin
cppcheck: fix uninitialized struct member: method_api.is_virtual
2018-10-04 18:16:04 +02:00
groud c7725aa98a Fixes tilemap editor offset tile selection 2018-10-04 14:20:03 +02:00
Rémi Verschelde 181af9b484
Merge pull request #22713 from akien-mga/fix-warnings
Fix GCC 8 warnings about potentially unitialized variables
2018-10-04 14:19:05 +02:00
the 8th mage f7a9866417 Fix TileMap editor drawing
the tile cursor did not follow the mouse cursor, and the tile grid was displayed wrong,
because the forward_canvas_draw_over_viewport function used the wrong xform and thus its
map_to_world is not the inverse of the mouse interactor world_to_map, making the tiles
draw from 0,0 of the screen instead of 0,0 of the tile map (which is in a different place)
2018-10-04 13:19:55 +02:00
Rémi Verschelde f48ee838e7 Fix GCC 8 warnings about potentially unitialized variables
Fixes the following GCC 8 warnings:
```
core/image.cpp:730:44: warning: 'mip1_weight' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:293:20: warning: 'mip2' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:293:20: warning: 'mip1' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/audio_stream_preview.cpp:58:19: warning: 'vmax' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/audio_stream_preview.cpp:85:19: warning: 'vmin' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/editor_themes.cpp:306:53: warning: 'preset_contrast' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/plugins/animation_blend_space_2d_editor.cpp:459:27: warning: 'prev_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/plugins/animation_blend_space_2d_editor.cpp:443:27: warning: 'prev_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
main/tests/test_oa_hash_map.cpp:57:29: warning: 'value' may be used uninitialized in this function [-Wmaybe-uninitialized]
modules/csg/csg.cpp:764:40: warning: 'max_angle' may be used uninitialized in this function [-Wmaybe-uninitialized]
modules/csg/csg_shape.cpp:1945:3: warning: 'face_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1593:8: warning: 'cone_aperture' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1592:6: warning: 'cone_dir_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/animation/animation_blend_space_2d.cpp:471:8: warning: 'mind' may be used uninitialized in this function [-Wmaybe-uninitialized]

core/os/memory.cpp:94: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
core/os/memory.cpp:95: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
core/os/memory.cpp:98: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
```
2018-10-04 13:08:41 +02:00
Hugo Locurcio 9c1d4f9da2
Use more subtle indentation guides in the script editor 2018-10-03 00:00:25 +02:00
Rémi Verschelde 540db0a0e7
Merge pull request #22329 from DualMatrix/no_select
Made children of Containers not selectable.
2018-10-02 16:39:00 +02:00
Rémi Verschelde c026e3957a Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor]
Fixes the following Clang 7 warnings:
```
editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual]
editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual]
editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual]
editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual]
editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual]
editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual]
main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual]
servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual]

core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
```
2018-10-02 13:40:17 +02:00
Rémi Verschelde 106acb27f9
Merge pull request #22568 from dlasalle/#14959
Explicitly show viewport 0 in the SpatialEditorPlugin if the container is large enough.
2018-10-02 11:26:29 +02:00
Rémi Verschelde dd3f6a04db
Merge pull request #21679 from pgruenbacher/spatial_editor_viewport_get_camera
added get_camera_method to spatial editor plugin viewport
2018-10-02 11:23:14 +02:00
Rémi Verschelde 876456754d
Merge pull request #21421 from YeldhamDev/mult_view_changes
Small improvements to the Spatial Editor's multiple viewport mode
2018-10-02 11:22:49 +02:00
Rémi Verschelde b2bba4be44 Fix warnings about invalid logical not on left hand side [-Wlogical-not-parentheses]
Fixes the following Clang 7 warnings and bugs:
```
editor/plugins/curve_editor_plugin.cpp:208:69: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
editor/plugins/curve_editor_plugin.cpp:214:43: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
```

Changed according to @Zylann's suggestion on
https://github.com/godotengine/godot/pull/22593#discussion_r221699573
2018-10-01 23:21:46 +02:00
Rémi Verschelde b1b625f4f5 Fix various Clang 7 warnings about unused stuff
Namely:
[-Wunneeded-internal-declaration]
[-Wunused-comparison]
[-Wunused-const-variable]
[-Wunused-function]
[-Wunused-private-fields]

Fixes the following Clang 7 warnings:
```
editor/plugins/script_editor_plugin.cpp:1417:20: warning: function '_find_node_with_script' is not needed and will not be emitted [-Wunneeded-internal-declaration]
editor/scene_tree_dock.cpp:1859:14: warning: function '_find_last_visible' is not needed and will not be emitted [-Wunneeded-internal-declaration]

modules/gdscript/gdscript_parser.cpp:7838:19: warning: equality comparison result unused [-Wunused-comparison]

scene/resources/mesh.cpp:549:35: warning: unused variable '_array_types' [-Wunused-const-variable]
scene/resources/mesh.cpp:563:18: warning: unused variable '_format_translate' [-Wunused-const-variable]

drivers/gles3/rasterizer_scene_gles3.cpp:54:28: warning: unused function 'store_transform2d' [-Wunused-function]

core/io/file_access_network.h:50:6: warning: private field 'ml' is not used [-Wunused-private-field]
core/io/file_access_zip.h:93:14: warning: private field 'archive' is not used [-Wunused-private-field]
core/io/resource_format_binary.h:122:6: warning: private field 'bin_meta_idx' is not used [-Wunused-private-field]
core/message_queue.h:47:9: warning: private field 'mutex' is not used [-Wunused-private-field]
main/tests/test_gui.cpp:63:11: warning: private field 'control' is not used [-Wunused-private-field]
modules/gdscript/gdscript_parser.h:558:7: warning: private field 'completion_static' is not used [-Wunused-private-field]
platform/x11/os_x11.h:148:11: warning: private field 'ip_unix' is not used [-Wunused-private-field]
platform/x11/os_x11.h:180:7: warning: private field 'net_wm_icon' is not used [-Wunused-private-field]
platform/x11/os_x11.h:189:6: warning: private field 'audio_driver_index' is not used [-Wunused-private-field]
platform/x11/os_x11.h:190:15: warning: private field 'capture_idle' is not used [-Wunused-private-field]
servers/physics/body_pair_sw.h:79:6: warning: private field 'cc' is not used [-Wunused-private-field]
servers/visual/visual_server_raster.h:62:7: warning: private field 'draw_extra_frame' is not used [-Wunused-private-field]
```
2018-10-01 17:32:12 +02:00
Aaron Franke cd349efb0e Minor nit-picky tweaks in spatial_editor_plugin.cpp
* Orthogonal cameras don't have an FOV that's "near zero". Or zero, or any number of degrees. It's not a measurement of degrees, it's just a fixed width. This comment is more accurate. Also, "terrible" is a better word than "awful" here.

* While I'm editing this file, the "String ortho" variable name could be more intuitive, so I've changed it to "view_mode".

Minor nit-picky changes, I know, but I found it so I may as well improve it.
2018-10-01 02:01:06 -04:00
Dominique LaSalle df06087057 Explicitly show viewport 0 in the SpatialEditorPlugin if the container is large enough. 2018-09-30 10:09:31 -07:00
Rémi Verschelde 62ecb44035 Fix warning about functions defined but not used [-Wunused-function]
Fixes the following GCC 5 warnings:
```
core/io/zip_io.h:128:26: warning: 'zlib_filefunc_def zipio_create_io_from_file(FileAccess**)' defined but not used [-Wunused-function]
core/script_debugger_remote.cpp:110:17: warning: 'ObjectID safe_get_instance_id(const Variant&)' defined but not used [-Wunused-function]
drivers/unix/socket_helpers.h:103:12: warning: 'int _socket_create(IP::Type&, int, int)' defined but not used [-Wunused-function]
drivers/unix/socket_helpers.h:45:15: warning: 'size_t _set_sockaddr(sockaddr_storage*, const IP_Address&, int, IP::Type)' defined but not used [-Wunused-function]
drivers/unix/socket_helpers.h:76:15: warning: 'size_t _set_listen_sockaddr(sockaddr_storage*, int, IP::Type, IP_Address)' defined but not used [-Wunused-function]
editor/editor_fonts.cpp:40:24: warning: 'Ref<BitmapFont> make_font(int, int, int, int, const int*, const Ref<Texture>&)' defined but not used [-Wunused-function]
editor/editor_themes.cpp:85:26: warning: 'Ref<StyleBoxFlat> change_border_color(Ref<StyleBoxFlat>, Color)' defined but not used [-Wunused-function]
editor/import/editor_import_collada.cpp:493:13: warning: 'void _generate_normals(const PoolVector<int>&, const PoolVector<Vector3>&, PoolVector<Vector3>&)' defined but not used [-Wunused-function]
editor/import/editor_import_collada.cpp:524:13: warning: 'void _generate_tangents_and_binormals(const PoolVector<int>&, const PoolVector<Vector3>&, const PoolVector<Vector3>&, const PoolVector<Vector3>&, PoolVector<float>&)' defined but not used [-Wunused-function]
editor/pvrtc_compress.cpp:118:13: warning: 'void _compress_etc(Image*)' defined but not used [-Wunused-function]
modules/etc/image_etc.cpp:89:13: warning: 'void _decompress_etc1(Image*)' defined but not used [-Wunused-function]
modules/etc/image_etc.cpp:93:13: warning: 'void _decompress_etc2(Image*)' defined but not used [-Wunused-function]
modules/gdscript/editor/gdscript_highlighter.cpp:46:13: warning: 'bool _is_whitespace(CharType)' defined but not used [-Wunused-function]
scene/2d/cpu_particles_2d.cpp:510:14: warning: 'float rand_from_seed_m1_p1(uint32_t&)' defined but not used [-Wunused-function]
scene/3d/cpu_particles.cpp:474:14: warning: 'float rand_from_seed_m1_p1(uint32_t&)' defined but not used [-Wunused-function]
scene/resources/default_theme/default_theme.cpp:123:20: warning: 'Ref<Shader> make_shader(const char*, const char*, const char*)' defined but not used [-Wunused-function]
scene/resources/default_theme/default_theme.cpp:130:24: warning: 'Ref<BitmapFont> make_font(int, int, int, int, const int*, const Ref<Texture>&)' defined but not used [-Wunused-function]
```

Had to split `core/io/zip_io.h` into header and .cpp file without 'static' keyword.

Not fixed yet (static definition in header used in some files but not all):
```
modules/websocket/lws_helper.h:111:13: warning: 'void _lws_make_protocols(void*, int (*)(lws*, lws_callback_reasons, void*, void*, size_t), PoolVector<String>, _LWSRef**)' defined but not used [-Wunused-function]
```

Also fixed a couple other warnings missed in previous commits.
2018-09-29 22:26:12 +02:00
Rémi Verschelde 3a2ca68af3 SCons: Build thirdparty code in own env, disable warnings
Also remove unnecessary `Export('env')` in other SCsubs,
Export should only be used when exporting *new* objects.
2018-09-28 14:07:39 +02:00
Rémi Verschelde c7e646c30a
Merge pull request #22447 from akien-mga/fix-warnings-Wswitch
Fix warnings about unhandled enum value in switch [-Wswitch]
2018-09-28 09:47:29 +02:00
Rémi Verschelde 7b081a7fc8 Fix warnings about unhandled enum value in switch [-Wswitch]
Fixes GCC 5 warnings of the form:

core/io/http_client.cpp:288:9: warning: enumeration value 'STATUS_SSL_HANDSHAKE_ERROR' not handled in switch [-Wswitch]
core/io/marshalls.cpp:806:9: warning: enumeration value 'AABB' not handled in switch [-Wswitch]

Those can be trivial cases where adding a default fallback is the solution,
or more complex issues/hidden bugs where missed values are actually meant
to be handled.
2018-09-27 18:34:30 +02:00
Rémi Verschelde 1b63dd83bd
Merge pull request #22482 from groud/text_rulers
Place the ruler text vertically
2018-09-27 18:13:31 +02:00
groud dfe81b9840 Place the ruler text vertically 2018-09-27 16:50:40 +02:00
Rémi Verschelde cdc411fd54 Fix various warnings: [-Waddress], [-Wpointer-arith], [-Wwrite-strings], [-Wreturn-local-addr] and more
Fixes the following GCC 5 warnings:
```
core/os/file_access.cpp:49:19: warning: the address of 'FileAccess::create_func' will always evaluate as 'true' [-Waddress]
servers/audio_server.cpp:192:70: warning: comparison with string literal results in unspecified behaviour [-Waddress]

drivers/gles2/rasterizer_storage_gles2.cpp:4095:90: warning: NULL used in arithmetic [-Wpointer-arith]

modules/gdnative/register_types.cpp:237:3: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
platform/android/export/export.cpp:207:1: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]

modules/gdscript/gdscript.h:150:67: warning: returning reference to temporary [-Wreturn-local-addr]
servers/physics_2d/collision_object_2d_sw.h:119:56: warning: returning reference to temporary [-Wreturn-local-addr]
servers/physics_2d/collision_object_2d_sw.h:123:56: warning: returning reference to temporary [-Wreturn-local-addr]
servers/physics_2d/collision_object_2d_sw.h:127:50: warning: returning reference to temporary [-Wreturn-local-addr]
servers/physics_2d/collision_object_2d_sw.h:131:52: warning: returning reference to temporary [-Wreturn-local-addr]

editor/plugins/skeleton_editor_plugin.cpp:34:36: warning: extra tokens at end of #include directive
modules/bullet/bullet_types_converter.cpp:31:9: warning: #pragma once in main file

editor/import/editor_scene_importer_gltf.cpp:1996:51: warning: name lookup of 'i' changed
modules/visual_script/visual_script_property_selector.cpp:402:45: warning: name lookup of 'E' changed
scene/gui/tree.cpp:1268:25: warning: name lookup of 'i' changed
scene/resources/visual_shader.cpp:808:32: warning: name lookup of 'i' changed
```
2018-09-27 16:33:52 +02:00
Rémi Verschelde d95bbb8922 Fix warnings about set but unused variables [-Wunused-but-set-variable]
Fixes the following GCC 5 warnings:
```
drivers/gles2/rasterizer_canvas_gles2.cpp:814:8: warning: variable 'rt_size' set but not used [-Wunused-but-set-variable]
drivers/gles2/rasterizer_scene_gles2.cpp:2270:11: warning: variable 'vp_height' set but not used [-Wunused-but-set-variable]
drivers/gles2/rasterizer_scene_gles2.cpp:2673:22: warning: variable 'e' set but not used [-Wunused-but-set-variable]
drivers/gles2/rasterizer_scene_gles2.cpp:715:7: warning: variable 'no_cull' set but not used [-Wunused-but-set-variable]
drivers/gles2/shader_gles2.cpp:693:14: warning: variable 'cc' set but not used [-Wunused-but-set-variable]
drivers/gles3/rasterizer_canvas_gles3.cpp:1226:8: warning: variable 'rt_size' set but not used [-Wunused-but-set-variable]
drivers/gles3/rasterizer_scene_gles3.cpp:3039:10: warning: variable 'contrib' set but not used [-Wunused-but-set-variable]
drivers/gles3/rasterizer_scene_gles3.cpp:4504:32: warning: variable 'vp_height' set but not used [-Wunused-but-set-variable]
editor/editor_inspector.cpp:272:9: warning: variable 'guide_color' set but not used [-Wunused-but-set-variable]
editor/editor_themes.cpp:1067:14: warning: variable 'alpha3' set but not used [-Wunused-but-set-variable]
editor/editor_themes.cpp:263:8: warning: variable 'script_bg_color' set but not used [-Wunused-but-set-variable]
editor/plugins/collision_shape_2d_editor_plugin.cpp:326:11: warning: variable 'cpoint' set but not used [-Wunused-but-set-variable]
editor/plugins/mesh_editor_plugin.cpp:72:9: warning: variable 'size' set but not used [-Wunused-but-set-variable]
editor/plugins/shader_editor_plugin.cpp:471:12: warning: variable 'mpos' set but not used [-Wunused-but-set-variable]
editor/plugins/shader_editor_plugin.cpp:89:8: warning: variable 'basetype_color' set but not used [-Wunused-but-set-variable]
editor/plugins/shader_editor_plugin.cpp:90:8: warning: variable 'type_color' set but not used [-Wunused-but-set-variable]
editor/plugins/shader_editor_plugin.cpp:92:8: warning: variable 'string_color' set but not used [-Wunused-but-set-variable]
modules/visual_script/visual_script_editor.cpp:2521:7: warning: variable 'seq_connect' set but not used [-Wunused-but-set-variable]
platform/android/export/export.cpp:580:12: warning: variable 'styles_count' set but not used [-Wunused-but-set-variable]
platform/android/export/export.cpp:584:12: warning: variable 'styles_offset' set but not used [-Wunused-but-set-variable]
platform/osx/export/export.cpp:464:9: warning: variable 'zerr' set but not used [-Wunused-but-set-variable]
scene/2d/tile_map.cpp:260:10: warning: variable 'tcenter' set but not used [-Wunused-but-set-variable]
scene/3d/light.cpp:166:7: warning: variable 'editor_ok' set but not used [-Wunused-but-set-variable]
scene/3d/navigation.cpp:566:11: warning: variable 'closest_navmesh' set but not used [-Wunused-but-set-variable]
scene/gui/rich_text_label.cpp:869:8: warning: variable 'size' set but not used [-Wunused-but-set-variable]
scene/main/viewport.cpp:705:14: warning: variable 'xform' set but not used [-Wunused-but-set-variable]
scene/main/viewport.cpp:706:8: warning: variable 'ss' set but not used [-Wunused-but-set-variable]
scene/main/viewport.cpp:726:14: warning: variable 'xform' set but not used [-Wunused-but-set-variable]
scene/main/viewport.cpp:727:8: warning: variable 'ss' set but not used [-Wunused-but-set-variable]
scene/resources/material.cpp:430:7: warning: variable 'using_world' set but not used [-Wunused-but-set-variable]
servers/visual/shader_language.cpp:2026:7: warning: variable 'all_const' set but not used [-Wunused-but-set-variable]
servers/visual/visual_server_scene.cpp:1383:28: warning: variable 'z_max_cam' set but not used [-Wunused-but-set-variable]
```

Also fixes two [-Wunused-value] warnings:
```
scene/gui/text_edit.cpp:4405:20: warning: statement has no effect [-Wunused-value]
servers/visual/visual_server_scene.cpp:905:48: warning: value computed is not used [-Wunused-value]
```

Some of those are bugs and need further work, they are identified with
`// FIXME` comments.
2018-09-27 16:25:24 +02:00