ab4c5a594a
Merge pull request #88521 from YeldhamDev/atr_regression
...
Fix regression in auto translation overhaul
2024-02-19 00:09:22 +01:00
0c4d8d7a6c
Merge pull request #88473 from Sauermann/fix-mouse-event-global-position
...
Fix global position for `InputEventMouse` in `viewport::push_input`
2024-02-19 00:08:37 +01:00
0f0515a75f
Merge pull request #87743 from WhalesState/camera2d
...
Fix `Camera2D` is enabled when dragging scene files to the `CanvasItemEditor`
2024-02-19 00:07:57 +01:00
dfcecb77bd
Merge pull request #79617 from sepTN/add-screensize-check-popup
...
Add size check to prevent popup bigger than the screen itself
2024-02-19 00:07:01 +01:00
b56774b5bf
Fix regression in auto translation overhaul
2024-02-18 19:33:08 -03:00
451b198c40
Fix dragging scene files to the `CanvasItemEditor`
2024-02-18 21:55:14 +02:00
34210e812a
Add screen size check on `popup`
2024-02-19 00:25:02 +07:00
8de39911c8
Fix global position for `InputEventMouse` in `viewport::push_input`
...
Global position doesn't get adjusted within `InputEventMouse::xformed_by()`.
2024-02-18 03:26:09 +01:00
3475156ae3
Expose pixel snapping settings add pixel-art notes
...
This small in-engine documentation change aims to make it easier to
discover ways to handle pixel art aesthetics.
- I have moved 2D pixel snapping settings out of "Advanced." This now matches other pixel-art-friendly settings for
GUI Snapping and Default Texture filtering.
- I've added notes to the project settings and Sprite/AnimatedSprite sources to hint users towards better understanding of why pixelated sprites may not work correctly and what to do about it. This should help users make informed decisions for their needs.
Context: Proper handling of pixel art in Godot is routinely frustrating for new users: I, like others, assumed that Godot would act on pixels, not subpixels, when I was working a pixel art game. I was confused when my interpolations would appear blurry, and when pixel textures would be distorted for no apparent reason (this was because of centering).
I had naively thought that setting Linear interpolation would be the single "it's a pixel art game" toggle, but that only hid the underlying issues until later. I had no idea there was a snap-to-pixel option because it was hidden in the Advanced options, since my default assumption was that a pixel art game would want no subpixels at all.
Some references for the frustration:
- https://github.com/godotengine/godot/issues/82696
- https://www.reddit.com/r/godot/comments/fah25e/best_way_to_achieve_pixel_perfect_rendering/
- https://shaggydev.com/2021/09/21/project-setup-for-pixel-art/
2024-02-17 23:40:53 +00:00
92fcbe2f5c
Revert "Allow configuration warnings to refer to a property"
...
This reverts commit bf37a9bac6
2024-02-17 19:04:18 +01:00
21f0529aa9
Revert "Update Node::get_configuration_warnings signature"
...
This reverts commit d3852deaa4
2024-02-17 19:03:21 +01:00
7b42c24550
Make auto translation inheritable
2024-02-15 16:51:19 -03:00
921b656f33
Merge pull request #86781 from KoBeWi/scenes_that_are_no_longer_with_us
...
Allow opening scenes with missing scene dependency
2024-02-13 23:43:14 +01:00
be4cbee873
Allow opening scenes with missing scene dependency
2024-02-13 19:46:35 +01:00
8da36031e4
Implement support for application status indicators (tray icons).
2024-02-13 15:59:35 +02:00
67e38709fd
Avoid unqualified-id "near" and "far" in Node3DEditor/Viewport
2024-02-13 18:53:21 +09:00
5306b917e6
Merge pull request #87164 from 0x0ACB/camera_fix
...
Rename camera `near` and `far` private members to avoid conflict with `Windows.h` defines
2024-02-12 23:29:22 +01:00
2b36dcf70a
Merge pull request #75688 from mnemoli/pickone
...
Add setting for picking only top-most overlapping collision object
2024-02-12 13:33:08 +01:00
b457a30311
Merge pull request #87628 from YuriSizov/assets-bigger-better-errors
...
Improve error reporting in the asset library and in related types
2024-02-09 18:09:16 +01:00
58a8eb8617
Merge pull request #84824 from Rindbee/fix-double-internal-node
...
Fix duplicating sub-scene may get two copies of internal node
2024-02-09 12:14:29 +01:00
d3852deaa4
Update Node::get_configuration_warnings signature
2024-02-08 23:05:20 +01:00
bf37a9bac6
Allow configuration warnings to refer to a property
...
This is used by the inspector so it can show a warning icon on
a specific property.
2024-02-08 23:05:20 +01:00
0d88aadd53
Automatically set viewport background to transparent when window flag is set.
2024-02-02 10:40:26 +02:00
0de8a736da
Allow Node.create_tween() outside SceneTree
2024-01-29 20:18:43 +01:00
fa48a51183
Merge pull request #87688 from AThousandShips/what_is_this
...
Remove unnecessary `this->` expressions
2024-01-29 13:18:09 +01:00
9a789adff2
Merge pull request #87632 from Sauermann/fix-remove-unused-group-variable
...
Remove unused internal Variable `Viewport::gui_input_group`
2024-01-29 13:17:48 +01:00
ef9cb3dfa5
Merge pull request #87535 from Mickeon/scene-tree-configuration-warnings-cleanup
...
Improve appearance of Node configuration warnings
2024-01-29 13:17:17 +01:00
15369fdb1d
Remove unnecessary `this->` expressions
2024-01-29 09:59:18 +01:00
3e4e0f08c4
Improve appearance of Node configuration warnings
2024-01-27 13:03:07 +01:00
36c2c4bf0d
Remove unused Variable `Viewport::gui_input_group`
...
The gui input group is not needed during the gui input step.
2024-01-26 23:37:30 +01:00
815038962f
Improve error reporting in the asset library and in related types
...
This also makes errors related to asset image loading
verbose-only, because, frankly, users can't do much about
those errors. Spamming them with error messages
about some assets on the frontend being broken
is pointless.
2024-01-26 20:33:22 +01:00
91ac53ec1b
Merge pull request #87385 from Sauermann/fix-subviewport-physics-picking
...
Fix SubViewport physics picking
2024-01-25 16:27:02 +01:00
adcfe3d1a0
Merge pull request #87252 from ajreckof/Fix-renaming-a-node-to-the-name-of-its-siblings-breaking-NodePath
...
Fix renaming a node to the name of its siblings breaking NodePath
2024-01-24 14:08:20 +01:00
e0f8cf4acb
Merge pull request #77730 from Jummit/fix-subviewport-1
...
Fix `push_input` events not going through after first pressed mouse event
2024-01-22 20:38:22 +01:00
7b00c136a1
Fix SubViewport physics picking
...
Apply the logic of `handle_input_locally` for physics picking.
2024-01-19 21:42:41 +01:00
9dfc012369
Remove unecessary _set_global_invalid added by mistake
2024-01-18 10:48:23 +01:00
fa81059b9d
Merge pull request #85939 from adamscott/single-threaded-godot-4
...
Add `THREADS_ENABLED` macro in order to compile Godot to run on the main thread
2024-01-18 09:33:52 +01:00
bd70b8e1f6
Add THREADS_ENABLED macro in order to compile Godot to run on the main thread
2024-01-17 13:58:29 -05:00
788aab3a96
Merge pull request #87115 from groud/tilemap_layers_as_nodes
...
Make TileMapLayers extend Node2D and work as children of TileMap
2024-01-17 18:53:12 +01:00
0724506cdd
Merge pull request #86841 from groud/fix_global_transform_in_enter_tree
...
Fixes global transform being wrong on entering tree
2024-01-17 18:52:59 +01:00
28cf7fe2f6
Merge pull request #85384 from HolonProduction/unique-name-completion
...
Suggest scene unique nodes in `get_node` autocompletion
2024-01-17 18:52:31 +01:00
48bed5050b
Make TileMapLayers extend Node2D and work as children of TileMap
2024-01-17 16:05:50 +01:00
0a726d692a
Fixes global transform being wrong on entering tree
2024-01-16 16:02:37 +01:00
2f697926b0
Fix renaming a node to the name of its siblings breaking NodePath
...
Also fix cases where node name was not visually updated because name was not changed
Co-Authored-By: Nông Văn Tình <53887662+nongvantinh@users.noreply.github.com>
2024-01-16 15:18:30 +01:00
03767fbf3b
Merge pull request #86446 from reduz/transient-to-focused
...
Implement a `transient_to_focused` Window mode
2024-01-15 13:25:00 +01:00
96b8016a35
Rename camera near and far private members to avoid conflict with Windows.h defines
2024-01-15 12:31:15 +01:00
15144c24bd
Implement a transient_to_focused mode
...
This intends to be the correct way to handle non-child windows becoming covered by the current window when becoming focused.
Enabling this property on select windows, they will become transient to the currently focused one when becoming visible.
This deprecates the "unparent_when_invisible" function introduced by #76025 .
2024-01-14 18:51:44 +01:00
06534f8ad5
Add deprecation notice to a duplicate method of class `Window`
2024-01-12 18:18:28 +01:00
cab27498bd
Merge pull request #86957 from RandomShaper/mt_mends
...
A couple of enhancements to user-visible threading semantics
2024-01-11 17:40:37 +01:00
087a397477
Merge pull request #86301 from KoBeWi/deferred_cleanup
...
Update deferred calls to use Callables
2024-01-11 17:36:29 +01:00
f3fc35eb17
Merge pull request #81506 from twobitadder/reparent_keep_owner
...
Fix `reparent()` losing owner
2024-01-11 17:34:19 +01:00
a407219693
Add Viewport setting for picking only first-encountered CanvasItem physics object
2024-01-11 14:18:37 +00:00
0e8f90f4c8
Update deferred calls to use Callables
2024-01-09 16:11:47 +01:00
631d1e3a86
Let read thread guards allow access to out-of-tree nodes
2024-01-08 10:33:09 +01:00
f996003fb4
Add autocompletion to `get_node_or_null`
2024-01-06 17:33:32 +01:00
fbaab3cf53
Merge pull request #86745 from KoBeWi/internal_error
...
Ignore internal children when replacing node
2024-01-03 15:48:41 +01:00
73c5deff76
Merge pull request #82916 from jsjtxietian/update-scene-tree-tooltip-after-editor-description-chnage
...
Support updating tooltip immediately after editor description change
2024-01-03 15:41:31 +01:00
cd2edfef25
Ignore internal children when replacing node
2024-01-03 13:04:16 +01:00
4acfe4aa3c
Merge pull request #86729 from Mickeon/autocompletion-for-all
...
Fix missing autocompletion for inheriting classes
2024-01-03 10:14:37 +01:00
0d922f61e3
Merge pull request #86220 from Sauermann/fix-embed-subwindow
...
Fix changing `gui_embed_subwindows` while a child window is displayed
2024-01-03 10:13:03 +01:00
62587d2d19
Fix changing `gui_embed_subwindows` while a child window is displayed
...
Changing `gui_embed_subwindows` while a child window is displayed can lead
to crashes or other unintended behavior.
This PR adds checks to prevent the change while child windows are
displayed.
2024-01-03 10:09:51 +01:00
ca2f340384
Fix missing autocompletion for inheriting classes
2024-01-03 00:13:04 +01:00
60b20963ce
Merge pull request #86511 from Sauermann/fix-drag-transform
...
Fix D&D viewport position calculation
2024-01-02 18:05:23 +01:00
957378a69e
Merge pull request #84151 from YeldhamDev/that_was_not_a_resize_you_dunce
...
Fix `NOTIFICATION_WM_SIZE_CHANGED` firing if the size hasn't changed
2024-01-02 15:08:46 +01:00
4b6516c843
Fix D&D viewport position calculation
...
It is necessary to transform screen position to viewport position.
2023-12-25 23:32:29 +01:00
f19c419126
Fix duplicating sub-scene may get two copies of internal node
...
Previously, internal node might be mistaken for `hidden_root` and be duplicated again.
Exclude those internal nodes to avoid this case, unless the owner is set intentionally.
2023-12-20 18:29:25 +08:00
958699a0c4
Implement project-wide node groups
2023-12-19 18:07:19 +01:00
02d4579fa2
Merge pull request #85000 from bruvzg/ed_ui_direction
...
[Editor] Add option to override editor UI layout direction.
2023-12-19 13:01:35 +01:00
8a9aa30348
Merge pull request #81243 from Sauermann/fix-window-events
...
Fix internal events not being delivered to some Window types
2023-12-19 13:01:00 +01:00
fe7725239e
Expose a method to get hovered Control in Viewport
2023-12-18 14:53:52 +01:00
203c8c31d3
Merge pull request #85071 from Rubonnek/remove-unnecessary-assignments
...
Remove unnecessary assignments
2023-12-14 17:38:34 +01:00
16d1d85a56
Merge pull request #78206 from alula/node-count-in-group
...
Add SceneTree.get_node_count_in_group()
2023-12-14 17:38:00 +01:00
80fb8db31f
Remove unnecessary assignments
...
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
2023-12-13 11:06:26 -05:00
dcbb18ded8
Merge pull request #85313 from kitbdev/fix-exit-hide
...
Fix crash on hiding grandparent Control on mouse exit
2023-12-08 15:23:32 +01:00
13305d31b5
Merge pull request #83343 from warriormaster12/node-property-duplication
...
Fix export variable of type Node pointing to a wrong child node when duplicating
2023-12-08 15:22:59 +01:00
b6c15736bd
Merge pull request #78997 from Sauermann/fix-owner-crash
...
Fix crash caused by stale owner
2023-12-08 15:22:39 +01:00
f9c42d9fff
Limit window size updates on title translation change.
2023-12-06 10:51:27 +02:00
36e033bce8
Merge pull request #85312 from YuriSizov/window-and-the-case-of-an-unexpected-shrinkage
...
Make sure `Window`'s title is respected before we compute the size
2023-12-05 13:05:23 +01:00
7957354091
Fix push_input only working the first time
...
Subviewports didn't update their parent's local_input_handled correctly.
Fixes #76439 .
2023-12-02 20:30:26 +01:00
78e1702adb
fix crash on hiding grandparent on mouse exit
2023-12-02 14:24:56 -05:00
5dd11e8eee
Limit window size updates on title change.
2023-11-30 16:04:00 +02:00
bf19ced15d
Fix crash on late mouse enter/exit event arrival.
2023-11-27 08:47:43 +02:00
8cc85515af
Suggest scene unique nodes in `get_node` autocompletion
2023-11-26 15:41:29 +01:00
d9677be0ca
Make sure `Window`'s title is respected before we compute the size
...
Also removes some suspicious and outdated code that forced this particular
dialog to change size when the warning message changed.
2023-11-24 16:31:41 +01:00
3de9afc4a9
Fix crash when hiding a Control during mouse-entering
...
gui.mouse_over can be set to `nullptr` in the `NOTIFICATION_MOUSE_ENTER`-
user-callback a few lines above. This case was previously not handled.
2023-11-23 23:25:00 +01:00
8bebabda18
Let scene replacemnent benefit from certain late pieces of frame logic
2023-11-21 18:32:49 +01:00
d3d00c7039
Fix crash caused by stale owner
...
Adjust `NOTIFICATION_PREDELETE` in `Node` to clean up owned nodes.
Also print a warning, when the owner becomes invalid.
2023-11-17 19:53:58 +01:00
932174fedf
[Editor] Add option to override editor UI layout direction.
2023-11-17 14:56:45 +02:00
4680ced5fa
support updating tooltip after editor description change
2023-11-15 14:27:49 +08:00
a98b94758b
Revert "Fix transform notification not getting sent out for RigidBody2D"
2023-11-14 22:17:26 +01:00
fa02d19fd1
Fix internal events not being delivered to some Window types
...
`AcceptDialog`, `Popup` and `PopupMenu` no longer subscribe to
"window_input" signal, because that is only sent if it is not an
internal signal.
Instead they receive events in `_input_from_window`. They ensure that
the event is also propagated to their super-function, just like
previously the signals would be treated.
2023-11-14 20:29:17 +01:00
9fb0b52608
Fix transform notification not getting sent out for RigidBody2D
2023-11-13 15:44:32 +01:00
15b8185c68
Don't use TTR/RTR for ERR/WARN prints
...
We don't translate those, only editor strings are translated.
2023-11-12 12:00:55 +01:00
d24d73ba31
Make mouse-enter/exit notifications match mouse event propagation
...
`NOTIFICATION_MOUSE_ENTER` and `NOTIFICATION_MOUSE_EXIT` now includes
the areas of children control nodes if the mouse filters allow it.
In order to check if a Control node itself was entered/exited, the newly
introduced `NOTIFICATION_MOUSE_ENTER_SELF` and
`NOTIFICATION_MOUSE_EXIT_SELF` can be used.
Co-authored-by: Markus Sauermann <6299227+Sauermann@users.noreply.github.com>
2023-11-09 09:11:59 -05:00
623b905d2e
Remove unused `NOTIFICATION_NODE_RECACHE_REQUESTED` notification
2023-11-06 12:16:32 +01:00
de1dc6c8d4
Fix node property duplication
2023-11-04 10:45:38 +02:00
62ab9bf1c4
Fix `NOTIFICATION_WM_SIZE_CHANGED` firing if the size hasn't changed
2023-10-31 22:58:12 -03:00
f672198f5e
Revert "Add a Disable 2D property to Viewport"
...
This reverts commit f6cc2603a1
2023-10-27 14:45:59 +02:00
b4aa6ad36e
Fix `reparent` losing owner if relationship to original owner is not broken
2023-10-26 13:08:05 -04:00
73f72409f5
Allow normal maps on TileMaps that use texture padding
2023-10-18 14:55:44 +02:00
7c088f246e
Merge pull request #82846 from SaracenOne/network_authority_instance_placeholders
...
Copy network authority when instancing placeholders
2023-10-16 10:38:34 +02:00
9e02dcd44c
Merge pull request #82100 from bitsawer/fix_shader_globals_override
...
Fix ShaderGlobalsOverride property handling
2023-10-11 22:50:08 +02:00
a1d7c62df7
Merge pull request #83003 from AThousandShips/null_check_extra
...
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-10-09 15:37:14 +02:00
336260b7b3
Merge pull request #83002 from AThousandShips/safety_check
...
Replace `sanity` with `safety` for checks
2023-10-09 15:36:49 +02:00
f18aa00e85
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-10-08 17:23:33 +02:00
034c0f1624
Replace `sanity` with `safety` for checks
2023-10-08 16:22:24 +02:00
f6cc2603a1
Add a Disable 2D property to Viewport
...
This is the 2D counterpart to the existing Disable 3D property.
Its functionality is already internally implemented and used,
but it wasn't exposed.
2023-10-07 17:19:15 +02:00
3b70e30e9b
Merge pull request #77072 from vPumpking/get-tree-string
...
Add `Node.get_tree_string` and `Node.get_tree_string_pretty`
2023-10-05 16:32:12 +02:00
e1803e27d0
Copy network authority when instancing placeholder nodes.
2023-10-05 12:58:17 +01:00
3a990e36e6
Merge pull request #80752 from bitsawer/fix_thread_guard
...
Fix CanvasItem notification thread guard
2023-10-03 17:13:08 +02:00
72e2e47059
[DisplayServer] Add method to estimate window title bar size.
2023-10-03 16:13:52 +03:00
12a2177967
Fix notification thread guards
2023-10-02 19:31:54 +03:00
1e819ae3aa
Merge pull request #82590 from YuriSizov/window-you-come-to-me-on-this-day-the-day-when-my-child-becomes-exclusive-with-a-transient-parent-to-ask-for-this
...
Add more context to some `Window` errors
2023-10-02 13:16:39 +02:00
e95b7e84a4
Merge pull request #80844 from dalexeev/fix-callable-expected-argc
...
Fix expected argument count for `Callable` call errors
2023-10-02 13:15:53 +02:00
53172d9860
Add more context to some `Window` errors
2023-09-30 21:44:05 +02:00
c52db6190c
[FileDialog] Make set_visible compatible with native dialogs.
2023-09-30 00:40:49 +03:00
aff767ef07
Fix expected argument count for `Callable` call errors
2023-09-29 20:00:10 +03:00
9ee82ebe1d
Fix tooltips behaving incorrectly on `Tree` nodes
2023-09-28 11:18:15 -03:00
fcbf7011cc
Make 3D editor gizmos and debug shapes ignore fog
...
This makes them easier to see in their intended colors in scenes with fog.
2023-09-27 00:54:57 +02:00
3a7eda8f87
Check if input marked handled before processing additional CollisionObjects
2023-09-26 20:42:15 +02:00
008b08b5fb
Merge pull request #82358 from jsjtxietian/fix-can-not-set-process-priority-of-node-in-editor
...
Fix can not set process priority of node in certain cases
2023-09-26 13:45:36 +02:00
e36117f557
Fix can not set process priority of node if not any process is processing
2023-09-26 19:29:25 +08:00
79805262f1
Merge pull request #77829 from AThousandShips/mp_fix
...
Disallow nested custom multiplayers in `SceneTree`
2023-09-26 08:17:02 +02:00
e4cfd4e26a
Merge pull request #82195 from AThousandShips/radian_fix
...
Replace `radians` range hint with `radians_as_degrees`
2023-09-25 17:18:38 +02:00
057367bf4f
Add FidelityFX Super Resolution 2.2 (FSR 2.2.1) support.
...
Introduces support for FSR2 as a new upscaler option available from the project settings. Also introduces an specific render list for surfaces that require motion and the ability to derive motion vectors from depth buffer and camera motion.
2023-09-25 10:37:47 -03:00
a5fe392b78
Disallow nested custom multiplayers in `SceneTree`
...
Enables clearing the custom multiplayer
2023-09-25 14:59:05 +02:00
e45927b2f2
Replace `radians` range hint with `radians_as_degrees`
2023-09-25 08:50:19 +02:00
71e32364ee
Fix ShaderGlobalsOverride property handling
2023-09-22 10:21:20 +03:00
dd3638d425
Merge pull request #81669 from kleonc/gui-tooltip-transparent-background
...
Enable transparent background for GUI tooltips
2023-09-15 19:48:37 +02:00
bd575c5fe5
Add 'get_tree_string()' and 'get_tree_string_pretty()' to Node class to complement printing methods
2023-09-15 19:18:53 +02:00
c66dfd2cfe
Enable transparent background for GUI tooltips
2023-09-14 23:39:28 +02:00
56e54b49b6
Merge pull request #81551 from YuriSizov/gui-cache-all-the-theme
...
Bind remaining theme properties to their respective classes
2023-09-14 15:21:45 +02:00
fe000277ea
Bind remaining theme properties to their respective classes
...
This adds binds for GraphEdit/GraphElement/GraphNode, which were
skipped before due to a rework. This also adds binds for Window,
which was skipped before due to a complicated code organization.
Also adds theme cache entries/direct cache access to a few places
that previously missed it. Some theme properties are now exposed
to other classes via friendships or public getters for convenience.
This removes all string-based theme access from scene/ classes.
2023-09-13 19:31:35 +02:00
a29416e332
[Scene,Main] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-12 12:53:06 +02:00
2924bfd4d3
Register theme properties with ThemeDB
2023-09-11 13:45:23 +02:00
7663c69922
Merge pull request #81388 from YuriSizov/core-gdvirtual-but-less-confused-about-itself
...
Extract `ScriptInstance` into its own file to simplify includes
2023-09-07 13:53:45 +02:00
d8ff69d53c
Extract ScriptInstance to simplify includes
...
This allows to include script_instance.h directly in the
generated gdvirtual.gen.inc, and remove excessive includes
from the codebase.
This should also allow Resource to use GDVIRTUAL macros,
which wasn't possible previously due to a circular dependency.
2023-09-06 22:54:38 +02:00
58126e479c
Introduce the concept of global theme contexts
...
This commit adds the default theme context, which replaces
the need to manually check the project and the default theme
all the time; simplifies related code.
It also adds framework for custom theme contexts, to be used
by the editor. Custom contexts can be attached to any node,
and not necessarily a GUI/Window node. Contexts do no break
theme inheritance and only define which global themes a node
uses as a fallback.
Contexts propagate NOTIFICATION_THEME_CHANGED when one of their
global themes changes. This ensures that global themes act just
like themes assigned to individual nodes and can be previewed
live in the editor.
2023-09-06 19:40:43 +02:00
6de34fde27
Add EditorStringNames singleton
2023-09-03 19:58:18 +02:00
39b1d860c3
Merge pull request #75382 from AThousandShips/duplicate_bind
...
Ensure binds are duplicated with `Node` signals
2023-09-01 16:00:05 +02:00
fc0b3f7021
Merge pull request #80320 from Sauermann/fix-remove-invalidation-function
...
Remove `CanvasItem::_invalidate_global_transform`
2023-08-30 08:45:27 +02:00
7f317ef1bf
Remove `CanvasItem::_invalidate_global_transform`
...
The only use of that function can be replaced by `_notify_transform`,
which makes the `propagate_call` unnecessary.
As far as I can tell, the `data.blocked`-checks of `propagate_call`
are not needed in this case, because `_invalidate_global_transform`
causes no user-noticeable changes.
2023-08-30 00:29:42 +02:00
c4705a590b
Fix Object::notification order
...
Previously the `p_reversed` parameter didn't influence the order
in a correct way.
Also script overridden _notification functions were not called in
the correct order.
To fix this some `notification` functions had to add a `p_reversed`
parameter.
This made it necessary to adjust cpp-bindings.
Co-authored-by: David Snopek <dsnopek@gmail.com>
2023-08-30 00:15:55 +02:00
9cf13cedfd
Ensure binds are duplicated with `Node` signals
2023-08-29 16:52:38 +02:00
8b8b6d1e87
Merge pull request #81006 from KurtBliss/Chance-of-crash-when-Control-overrides-mouse-input-on-Area2D-#79371
...
Fix possible crash when Control overrides mouse input on Area2D
2023-08-28 15:04:41 +02:00
072ba70424
Merge pull request #81012 from Jordyfel/center-window
...
Implement center window function.
2023-08-28 12:07:27 +02:00
2c0a74a149
Merge pull request #80105 from Sauermann/fix-global-transform
...
Fix global transform validity for `Node2D` and `Control`
2023-08-28 12:03:53 +02:00
9819ffb166
Implement window center function.
2023-08-26 21:34:21 +03:00
dbb01bc451
Fixed, chance of crash when Control overrides mouse input on Area2D
...
Made Viewport::_cleanup_mouseover_colliders queue up mouse_exit and
mouse_shape_exit signals to emit and at the end of the function's
execution to avoid potential crashes.
2023-08-25 17:51:38 -04:00
b24eb34669
Merge pull request #80780 from HolonProduction/sub-window-focus-crash
...
Fix crash when hiding subwindow during popup of new subwindow
2023-08-21 08:23:23 +02:00
e2cea458a3
Fix crash when hiding subwindow during popup of new subwindow
2023-08-20 17:51:54 +02:00
e73a4a382e
Merge pull request #79201 from Rindbee/fix-setup-state-not-cleared
...
Clear the previously set state when configuring for a new scene root node
2023-08-17 15:43:38 +02:00
77fd8f3416
Merge pull request #80673 from YeldhamDev/give_me_my_windows!
...
Allow to get a list of visible embedded `Window`s
2023-08-16 16:56:31 +02:00
c081d1bd24
Merge pull request #78816 from kleonc/scene-tree-fix-drag-drop-to-parent-with-internal-nodes
...
Fix drag-dropping nodes to parent with internal nodes
2023-08-16 16:54:06 +02:00
de27df5da3
Allow to get a list of visible embedded `Window`s
2023-08-16 10:42:08 -03:00
a7dc4c22a9
Merge pull request #80334 from Sauermann/fix-window-out-of-viewport-events
...
Fix nodes receiving mouse events in black bars of `Window`
2023-08-16 09:12:42 +02:00
33198d0df0
Merge pull request #75784 from Riteo/int-scale
...
Add content scale stretch modes, implement integer scaling
2023-08-11 10:32:11 +02:00
87cfc415a3
Add content scale stretch modes, implement integer scaling
...
Integer scaling is achieved (after aspect expansion) by "lying" to the
stretching code about the window's size, telling it that it's always an
integer multiple of the viewport so that it only gets stretched to an
integer factor.
This approach works with all stretch and aspect modes and doesn't
require handling for each, only requiring to "loosen up" some
self-excluding conditions (in other words, replacing some `else if`s
with just `if`s) regarding viewport offset and margin calculation (black
bars).
Includes a tiny usability change that adds a range hint for the content
scale factor between 0.5 to 8.0.
Co-Authored-By: Hugo Locurcio <hugo.locurcio@hugo.pro>
2023-08-10 19:45:47 +02:00
59c13fea5d
Fix nodes receiving mouse events in black bars of `Window`
...
Previously for InputEvents there was no distinction between
Window-area and Viewport-area.
This was problematic in cases where stretching was used and the Window
contained black bars at the sides of the Viewport.
This PR separates the area of Window and Viewport regarding InputEvents.
2023-08-09 12:34:22 +02:00
4795c3cdfa
Clear the previously set state when configuring for a new scene root node
...
Saving a subscene causes the main scene to be re-instantiated. And the resource
instance in the main scene will be reused when the main scene is re-instantiated.
So for resources with `resource_local_to_scene` enabled, resetting state may be
necessary (at least for `ViewportTexture`).
2023-08-08 23:49:53 +08:00
46c9a1427d
Merge pull request #80364 from Calinou/control-escape-dismiss-tooltips
...
Dismiss currently visible or upcoming tooltips when pressing Escape
2023-08-08 16:57:59 +02:00
1163dac9e3
Merge pull request #80215 from clayjohn/HDR-2D
...
Add option to enable HDR rendering in 2D
2023-08-08 16:57:33 +02:00
af722e2bab
Merge pull request #80187 from Sauermann/fix-mouseover-error-handling
...
Handle potential platform-specific `Window` mouse-enter/exit bugs gracefully
2023-08-08 16:57:09 +02:00
2f8673dc07
Handle potential platform-specific `Window` mouse-enter/exit bugs gracefully
...
Also replace `DEV_ASSERT` by `WARN_PRINT_ONCE`.
2023-08-08 13:05:18 +02:00
152572ac38
Fix global transform validity for `Node2D` and `Control`
...
Set global transform to invalid when changing transform
2023-08-08 12:22:55 +02:00
6307b0be3c
Dismiss currently visible or upcoming tooltips when pressing Escape
...
This is standard UI behavior in most applications out there.
2023-08-08 07:40:39 +02:00
faaf27f284
Fix various typos with codespell
...
Also includes typo fixes from #79993 , #80068 , #80276 , and #80303 .
Co-authored-by: betalars <contact@betalars.de>
Co-authored-by: spaceyjase <429978+spaceyjase@users.noreply.github.com>
Co-authored-by: Swarkin <102416174+Swarkin@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
2023-08-07 13:09:47 +02:00
57eb762bae
Add option to enable HDR rendering in 2D
...
This is needed to allow 2D to fully make use of 3D effects (e.g. glow), and can be used to substantially improve quality of 2D rendering at the cost of performance
Additionally, the 2D rendering pipeline is done in linear space (we skip linear_to_srgb conversion in 3D tonemapping) so the entire Viewport can be kept linear.
This is necessary for proper HDR screen support in the future.
2023-08-07 11:24:03 +02:00
6d2453425b
Improve `Window._get_contents_minimum_size()`'s code
2023-08-03 10:25:05 -03:00
f9d960c925
Merge pull request #80178 from YeldhamDev/override_all_the_things
...
Expose `Window`'s `_get_contents_minimum_size()` to scripting
2023-08-03 14:46:52 +02:00
237bd0a615
Merge pull request #80117 from Sauermann/fix-actually-store-safe-rect
...
Actually store safe-rect in embedder
2023-08-02 21:48:02 +02:00
f270163ab0
Expose `Window`'s `_get_contents_minimum_size()` to scripting
2023-08-02 14:40:38 -03:00
1e9d241809
Actually store safe-rect in embedder
...
`sw` is a copy and not a reference.
Add unit-test for this case.
2023-08-02 17:51:52 +02:00
8c1ce404d7
Fix crash on Windows when closing `Window`
...
Send `WINDOW_EVENT_MOUSE_EXIT` when a window is destroyed.
Ensure, that on Windows, the event_callback is still valid during
destroying the `Window`.
2023-08-02 00:17:25 +02:00
defaac6058
Merge pull request #67791 from Sauermann/fix-visual-mouse-notifications
...
Refactor mouse_entered and mouse_exited signals
2023-08-01 20:03:33 +02:00
fd1ee5d56b
Merge pull request #79332 from AThousandShips/mp_crash
...
Prevent crash when accessing `Node` Multiplayer from thread
2023-08-01 17:25:07 +02:00
1c3c17c608
Refactor mouse_entered and mouse_exited notifications
...
The previous implementation for signals mouse_entered and mouse_exited
had shortcomings that relate to focused windows and pressed mouse buttons.
For example a Control can be hovered by mouse, even if it is occluded by
an embedded window.
This patch changes the behavior, so that Control and Viewport send
their mouse-enter/exit-notifications based solely on mouse position,
visible area, and input restrictions and not on which window has
focus or which mouse buttons are pressed. This implicitly also
changes when the mouse_entered and mouse_exited signals are sent.
This functionality can not be implemented as a part of
Viewport::_gui_input_event, because of its interplay with Windows and
because Viewport::_gui_input_event is based on input and not on
visibility.
2023-08-01 13:28:49 +02:00
7fead979d6
Disable error condition for accessing safe rect
...
This PR removes the error-message, which is currently expected to happen.
The task of correctly fixing the underlying problem of window popup
closing is more complex, so this PR solves the immediate
error-notification-problem.
2023-07-26 20:21:30 +02:00
d50c52652f
Merge pull request #79805 from kumikumi/fix-subviewport-cursor
...
Prevent SubViewportContainer overriding Subviewport's cursor with its own cursor
2023-07-26 18:40:30 +02:00
712f49ec57
Merge pull request #79766 from Sauermann/fix-window-determinant-zero
...
Add determinant check for minimized windows
2023-07-26 18:40:26 +02:00
1de9171c32
Merge pull request #79443 from Sauermann/fix-ingore-hovering
...
Fix physics passive hovering with `MOUSE_FILTER_IGNORE`
2023-07-26 18:40:14 +02:00
67873d0d5d
Merge pull request #79248 from Sauermann/fix-svc-focus-propagation
...
Make `SubViewportContainer` event propagation aware of focused Control
2023-07-26 18:39:57 +02:00
e8df8c5e2c
Merge pull request #78988 from RandomShaper/fix_change_scene
...
Reimplement scene change
2023-07-26 18:39:43 +02:00
96b26574b9
Don't override SubViewport's cursor with SubViewportContainer's cursor
...
Add a warning for having a non-default value of `mouse_default_cursor_shape` in SubViewportContainer
Add test
2023-07-23 22:27:55 +03:00
e0bce0bd7f
Add determinant check for minimized windows
...
When the Window is minimized, the transform-determinant can be 0.
Add a check to prevent this case.
2023-07-22 00:02:37 +02:00
15c0e40375
Merge pull request #79546 from Sauermann/fix-input-handled-physics
...
Separate input-handled-state for different events during physics-picking
2023-07-21 17:15:36 +02:00
de0f7935dd
Merge pull request #79524 from aaronfranke/gds-test-inst-placeholder
...
Change GDScript tests to use InstancePlaceholder as the example abstract class
2023-07-21 17:15:32 +02:00
4d42d6fdf6
Merge pull request #78706 from RedworkDE/node-rename-inplace
...
Allow renaming child nodes in `_ready`
2023-07-21 17:15:26 +02:00
b408b05d7d
Fix physics passive hovering for some cases
...
When the parent `SubViewportContainer` ignores mouse with
`MOUSE_FILTER_IGNORE` and also when the mouse is over a `Control`-node,
then the `SubViewport` shouldn't create mouse-move-events for passive
hovering.
2023-07-19 19:25:04 +02:00
e6386bc843
Make `SubViewportContainer` event propagation aware of focused Control
...
Propagate `InputEvents` without position either
- during the Input-stage, when it has focus or
- during the Unhandled-Input-stage, otherwise
This makes sure that Gui-Input happens in the correct order.
Move "Unhandled key Input" handling before "Unhandled Input" handling,
so that Unicode input with Alt / Ctrl modifiers are sent to the nodes
in the correct order.
Change the default focus mode of `SubViewportContainer` from
`FOCUS_NONE` to `FOCUS_CLICK`, to automatically remove focus from
other `Control`-nodes, when clicking inside a `SubViewport`.
2023-07-17 22:38:35 +02:00
de4a3fa151
Unify and streamline connecting to Resource changes
2023-07-17 19:35:57 +02:00
95d294b97a
Separate input-handled-state for different events during physics-picking
...
Currently the input-handled-state for different events can interfere with
each other.
This PR makes sure, that the input_handled_state is reset before
processing and InputEvent during physics-picking.
2023-07-16 14:36:18 +02:00
6a8a9cd279
Change GDScript tests to use InstancePlaceholder as the example abstract
2023-07-15 18:28:08 -05:00
7e21eb7e00
Extract and reorganize texture resource classes
2023-07-14 20:04:21 +02:00
d8c0d63f07
Merge pull request #79393 from Sauermann/fix-window-focux-indicator
...
Add a default theme for unfocused Windows
2023-07-14 18:50:01 +02:00
576980f960
Add a default theme for unfocused Windows
...
At the moment it is impossible to distinguish between focused and
unfocused embedded Windows.
Add a new `theme_item` that is used for coloring the border of
unfocused Windows.
2023-07-12 22:35:03 +02:00
4790da7900
[macOS] Implement optional native file selection dialog support for sandboxed apps.
2023-07-12 22:36:24 +03:00
7ff2a93952
Merge pull request #72248 from RedwanFox/mainloop_init_order_fix
...
Ensure that SceneTree is initialized and finalized at correct time
2023-07-12 17:16:05 +02:00
223370cb64
Merge pull request #78383 from Sauermann/fix-physics-object-init
...
Fix Physics Picking captured Object initialization
2023-07-12 17:15:45 +02:00
5dff3c4484
Merge pull request #78538 from Sauermann/fix-code-simplifications
...
Remove unnecessary value assignments throughout the codebase
2023-07-12 15:09:26 +02:00
Rémi Verschelde
Michael Alexsander
Mounir Tohami
Septian
Markus Sauermann
Sabs, like Sobs
kobewi
bruvzg
Silc Lizard (Tokage) Renew
RedMser
A Thousand Ships
Micky
Yuri Sizov
Gilles Roudière
Adam Scott
ajreckof
ACB
Juan Linietsky
Jakub Marcowski
mnemoli
Pedro J. Estébanez
风青山
Stanislav Labzyuk
Claire Blackshaw
Wilson E. Alvarez
Jummit
kit
HolonProduction
jsjtxietian
Mikael Hermansson
warriormaster12
clayjohn
twobit
Hugo Locurcio
Saracen
bitsawer
Danil Alexeev
Marcel Admiraal
Dario
vPumpking
kleonc
Jordyfel
KurtBliss
Riteo
Yuri Sizov
Mikko Ankkala
Aaron Franke
Hendrik Brucker