e142c10fc5
Merge pull request #58993 from notSanil/device-limit-exceeded-fix
2022-03-17 19:55:40 +01:00
30a89b3f98
Fix alpha scissor support
2022-03-17 16:17:27 +01:00
36fa7059ed
Fix device limit exceeding for uniform buffer
2022-03-16 16:52:35 +05:30
57e5a33623
Split dummy renderer classes into separate files
...
Split canvas_texture_storage and texture_storage from render_storage class
2022-03-16 17:43:10 +11:00
cfd21adf64
Merge pull request #49092 from BastiaanOlij/multiview_clustered
...
Add multiview support to the clustered forward renderer
2022-03-16 00:17:57 +01:00
51bbcbdec2
Merge pull request #45263 from KoBeWi/ 😕
2022-03-15 13:18:27 +01:00
b6f72f2b4a
Fix D_GGX code which can cause divide-by-zero val
...
When given roughness is lower than 0.01, d value in original code will
be zero. This can make last return value as NAN because of
divide-by-zero. This is well addressed in issue #56373 .
Modified code is referenced on D_GGX function of google/filament
(https://github.com/google/filament/blob/main/shaders/src/brdf.fs#L54-L79 )
Signed-off-by: snowapril <sinjihng@gmail.com>
2022-03-14 13:25:05 +09:00
7ed8d52fb2
Merge pull request #58819 from vreon/fix-eyedir-z
...
Fix flipped EYEDIR.z in sky shaders
2022-03-13 00:55:32 +01:00
39d429e497
Change some math macros to constexpr
...
Changes `MAX`, `MIN`, `ABS`, `CLAMP` and `SIGN`.
2022-03-09 16:24:32 +01:00
d437355f55
Sky renderer: Only flip Z when calculating panorama_coords
2022-03-08 19:51:43 -08:00
1561737055
Merge pull request #49447 from Calinou/remove-shadow-color-property
...
Remove unused `shadow_color` property from Light3D
2022-03-08 07:48:05 +01:00
f488a841c7
Merge pull request #58779 from techiepriyansh/forward-mobile-ambient-accum
2022-03-07 16:46:33 +01:00
ff2a5c04b1
Sky renderer: Don't invert Z component of light direction
2022-03-06 23:58:54 -08:00
b0ca03b0a2
Add a UniformSet cache
...
* Changed syntax usage for RD::Uniform to create faster with a single RID
* Converted render pass setup to use this in clustered renderer to test.
This is the first step into creating a proper uniform set cache system to simplify large parts of the codebase.
2022-03-06 13:03:33 +01:00
80345f7d4e
Fix flipped EYEDIR.z in sky shaders
2022-03-05 17:49:32 -08:00
8c37cfa5bb
use the computed value ambient_accum for ambient_light in scene_forward_mobile.glsl
2022-03-05 14:24:40 +05:30
aea104deb7
Remove unused `shadow_color` property from Light3D
...
This shadow color property was no longer effective since the shaders
were optimized to improve occupancy.
2022-03-04 23:12:18 +01:00
c787f59931
Merge pull request #58734 from Calinou/tweak-render-timestamp-names
...
Tweak render timestamp names for explicitness and consistency
2022-03-04 20:43:08 +01:00
3078b92dff
Merge pull request #58512 from Calinou/light3d-add-distance-fade
2022-03-04 12:26:29 +01:00
c509a3a3a5
Tweak render timestamp names for explicitness and consistency
...
- Add 2D and 3D in timestamp names when needed to avoid ambiguity.
- Use present tense in all render timestamp names.
- Add a space after ">" (begin) and "<" (end) symbols.
- Remove redundant "End" in render timestamp names (indicated by "<").
2022-03-04 08:46:12 +01:00
e4b7a69bb6
Add multiview/stereoscopic rendering support to the clustered forward renderer
2022-03-03 20:06:14 +11:00
0036a41a10
Revert "Fix particle trail glitch"
2022-03-01 20:16:10 +01:00
e7176e6c85
Merge pull request #58614 from Calinou/ssr-roughness-quality-enum-fix-typo
...
Fix typo in SSR roughness quality enum value names
2022-02-28 10:51:20 +01:00
83efe4d8b0
Fix typo in SSR roughness quality enum value names
2022-02-28 01:06:26 +01:00
1675c5375e
Fix particle trail glitch
2022-02-26 13:53:06 +08:00
b1a295b739
Implement distance fade properties in OmniLight3D and SpotLight3D
...
This can be used to fade lights and their shadows in the distance,
similar to Decal nodes. This can bring significant performance
improvements, especially for lights with shadows enabled and when
using higher-than-default shadow quality settings.
While lights can be smoothly faded out over distance, shadows are
currently "all or nothing" since per-light shadow color is no longer
customizable in the Vulkan renderer. This may result in noticeable
pop-in when leaving the shadow cutoff distance, but depending on the
scene, it may not always be that noticeable.
2022-02-25 15:17:35 +01:00
3ce5cceef9
Filament specular fix. Clamp dot product between normal and view vectors. Fixes #58459 .
2022-02-23 18:16:52 +00:00
a78a9fee71
Implementing OpenXR driver
2022-02-23 12:02:24 +01:00
fe49244611
Use Filament specular models and parametrization
2022-02-22 19:39:41 -08:00
0d5472dd1a
Fix GPUParticles2D emission offset in global coords
2022-02-22 17:50:01 +08:00
c77348b468
Merge pull request #58419 from clayjohn/Vulkan-anisotropy-crash
2022-02-22 09:09:16 +01:00
2da35d2b94
Fix shader compilation error with anisotropy
2022-02-21 22:58:33 -08:00
9d104ad839
Use properly use non-perceptual roughness when filtering radiance
2022-02-21 22:53:12 -08:00
7a68ee5134
Merge pull request #58266 from clayjohn/revert-sky-change
2022-02-18 12:07:40 +01:00
488116e4d8
Merge pull request #58236 from bruvzg/win_min_fix
2022-02-18 09:07:10 +01:00
e0384fb70e
Revert "Fix default sky process mode not being Real-Time"
...
This reverts commit aa1cba1d53
2022-02-17 23:13:10 -08:00
e1b8a86b2b
Merge pull request #58177 from clayjohn/VULKAN-prefiltered-radiance
2022-02-17 17:53:42 +01:00
0c27667124
[Windows] Fix Vulkan driver crash on sub-window minimization.
2022-02-17 13:34:08 +02:00
48728a79b6
Use prefiltered radiance
2022-02-16 21:37:18 -08:00
b8b4580448
Style: Cleanup single-line blocks, semicolons, dead code
...
Remove currently unused implementation of TextureBasisU, could be re-added
later on if needed and ported.
2022-02-16 14:06:29 +01:00
a85b000967
Fix antialiasing for beginning/end of line in `canvas_item_add_polyline`
2022-02-16 14:34:42 +03:00
a38c3a763a
Properly exclude lights that are marked as sky only
2022-02-16 00:16:56 -08:00
aa1cba1d53
Fix default sky process mode not being Real-Time
...
The change in 09563e4bd8
2022-02-16 01:51:48 +01:00
4f73d3beb4
Add Particle Shader Userdata
...
* Adds optional vec4 USERDATA1 .. USERDATA6 to particles, allowing to store custom data.
* This data is allocated on demand, so shaders that do not use it do not cost more.
2022-02-15 19:20:31 +01:00
5a6da0b2a9
Merge pull request #57905 from V-Sekai/fix_instance_clear_warnings
...
Free surface vertex_buffers after vertex_arrays to silence warnings
2022-02-15 08:32:32 +01:00
af91a42b0a
Merge pull request #57904 from V-Sekai/fix_double_free_warning
...
Fixes some 'Attempted to free invalid ID' warnings in mobile renderer
2022-02-15 08:30:44 +01:00
d1dbe21c56
Merge pull request #57980 from akien-mga/vulkan-1.3.204
2022-02-12 10:21:27 +01:00
b396fd4eef
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 02:46:22 +01:00
18d6b75ba8
RendererRD: Remove binding specifier for push constants
...
This is unsupported and glslang made it raise an error in 11.7.0:
https://github.com/KhronosGroup/glslang/pull/2810
Co-authored-by: Clay John <claynjohn@gmail.com>
2022-02-11 18:42:32 +01:00
2921cf6a99
Merge pull request #57888 from dusakus/depanoramize-spot-projector
...
remove normal_to_panorama from spotlight projector
2022-02-11 10:41:00 +01:00
66d27df12f
Fix 3D sky update performance regression
2022-02-10 20:21:28 +01:00
e4e6813baf
Merge pull request #57535 from Calinou/visibility-range-fade-use-easing
2022-02-10 18:18:53 +01:00
11cefc2b28
Merge pull request #57104 from clayjohn/VULKAN-sky-conflict
2022-02-10 17:46:42 +01:00
7332aff3fd
Merge pull request #54677 from Calinou/voxelgi-default-low-quality
2022-02-10 17:35:52 +01:00
c6199da8b8
Merge pull request #39965 from Calinou/tweak-sdfgi-defaults
2022-02-10 17:31:54 +01:00
2fafcfebdf
Merge pull request #57707 from Calinou/sdfgi-tweak-default-num-cascades
2022-02-10 17:27:42 +01:00
67c6442844
Merge pull request #57628 from Calinou/shadow-atlas-default-enable-16-bits
2022-02-10 17:19:37 +01:00
824ece9d89
Free surface vertex_buffers after vertex_arrays due dependencies
2022-02-10 10:34:34 +00:00
71eb3f6df5
Fix _free_render_buffer_data freeing shared half_texture and half_fb
2022-02-10 10:04:18 +00:00
38423565e4
remove normal_to_panorama from spotlight projector
2022-02-09 23:47:44 +01:00
2e2c9a27b6
Fixed shader error message for instance qualifier
...
Moved argument from RTR to vformat. Message is now similar to uniform-arrays-error further down.
2022-02-09 21:32:09 +01:00
a6abeb6b20
Merge pull request #57682 from clayjohn/VULKAN-canvas-blur
2022-02-07 10:16:50 +01:00
3ae38edc8e
Merge pull request #56844 from Calinou/ssr-fix-background-line-master
...
Fix visible background line in intersections in screen-space reflections
2022-02-06 23:22:15 +01:00
7721e19ccc
Tweak default SDFGI settings for better quality
...
- Enable Read Sky Light to get proper outdoors lighting out of the box.
- Set bounce feedback to 0.5 by default to get a better quality result.
- Higher values may cause infinite feedback with bright surfaces.
- Increase the number of frames to converge to improve quality
at the cost of latency. Most scenes are fairly static after all.
- Use 75% Y scale by default as most scenes are not highly vertical.
- Reorder the Y scale enum to go from the lowest Y scale to the highest.
Also rename the "Disabled" setting to "100%" for clarity.
2022-02-06 15:28:59 +01:00
b9cfc74f29
Decrease the default number of SDFGI cascades to 4
...
This improves rendering performance noticeably, especially when the
camera moves fast.
On a medium-sized test scene on a GTX 1080 in 2560×1440, going
from 6 to cascades saves 0.5 ms of frame time while looking visually
identical (as most of the scene fits within the 4 cascades).
2022-02-06 15:01:25 +01:00
a2484c3293
Fix unknown identifier error in for loop
2022-02-06 08:38:33 +03:00
60d8df3fee
Optimize and fix backbuffer gaussian blur
2022-02-05 15:03:39 -08:00
74adf0bf2e
Remove RID_Owner.get_rid_by_index
...
* Implementing this function efficiently is not really possible.
* Replaced by an option to get all RIDs into a buffer for performance.
2022-02-05 11:59:34 +01:00
eb371dee01
Merge pull request #57651 from theoniko/theoniko-effects_rc.cpp
...
Fix copy paste bug in renderer_rd/effects_rd.cpp
2022-02-05 10:15:38 +01:00
e01d08159c
Few more fixes to for loop in shaders
2022-02-05 08:42:32 +03:00
0c0ff5da50
Fix copy paste bug in renderer_rd/effects_rd.cpp
2022-02-05 06:41:30 +01:00
e4eafb254a
Enable 16-bit shadow atlas by default in the RenderingServer methods
...
16-bit shadow atlases are already the default in the project settings,
but low-level methods used 24-bit shadows by default.
This makes low-level methods more consistent with the default project
settings to avoid accidental performance issues when users change
the shadow size at run-time.
2022-02-04 16:41:08 +01:00
244db37508
Cleanup and move char functions to the `char_utils.h` header.
2022-02-04 11:35:01 +02:00
f8f19b313d
Merge pull request #57562 from AnilBK/string-add-contains
...
String: Add contains().
2022-02-03 22:21:24 +01:00
adbe948bda
String: Add contains().
2022-02-04 01:28:02 +05:45
58696fd774
Allow multiple declarations in for loop in a shader
2022-02-03 11:35:38 +03:00
20464fd103
Make visibility range alpha fade smoother
...
`smoothstep()` avoids the sudden transparency jump when entering or
leaving an object's alpha fade margin distance. This in turn helps
make opacity transitions less noticeable to the player, as it's
less likely to catch the player's eye.
2022-02-01 23:54:44 +01:00
fc27636999
Vectors: Use clear() and has().
...
Use clear() instead of resize(0).
Use has() instead of "find(p_val) != -1".
2022-02-02 00:11:09 +05:45
b0202c3a7d
Fix orthogonal camera auto LOD calculation
...
- Do not take orthogonal camera's distance into account when calculating LOD.
- Only take into account screen size taken up.
2022-01-30 11:54:27 -05:00
8a0a3accee
simplify formatting scripts, add a clang-tidy script, and run clang-tidy
2022-01-29 04:41:03 -06:00
58324f4df8
Merge pull request #54574 from Ansraer/glow_map
2022-01-26 13:39:51 +01:00
98e5cd24db
Improve XRInterface hooks into rendering
2022-01-26 13:55:44 +11:00
d9fd16c8e4
Merge pull request #53954 from Chaosus/fix_quit_errors
2022-01-25 20:09:52 +01:00
b01065b9a4
Prevent checking of global uniform type outside the editor
2022-01-25 19:22:37 +03:00
238862bddb
Minor fixes to shadow atlases:
...
* Erase shadow owner *before* setting it to RID().
* Add default texture in shadow atlas debug view to avoid error spam when no atlas is present.
* Fix typo.
2022-01-24 15:55:32 +01:00
0e66587dbf
Remove incorrect items from completion of main functions in shader
2022-01-24 10:37:47 +03:00
430d5d64aa
Update Sky lights in sky setup function
2022-01-23 15:06:49 -08:00
3ca57e5157
Fix incorrect unused local var warning in shader blocks
2022-01-23 20:22:31 +03:00
9b9440165b
Merge pull request #54890 from briansemrau/threadsafe-drawpute-lists
...
Make draw/compute lists threadsafe
2022-01-22 20:20:07 +01:00
fdc1b1b03b
Remove TRANSFORM built in from fog shaders
2022-01-21 23:03:41 -08:00
7e3b92f81f
Merge pull request #55360 from Calinou/rename-bake-mode-properties
2022-01-20 17:35:32 +01:00
dbd560cb68
Merge pull request #53857 from briansemrau/rd-free-rid-bind-rename
2022-01-20 17:24:34 +01:00
90652b1755
add support for glow maps
2022-01-20 16:47:25 +01:00
b411a731fe
Add nodiscard to core math classes to catch c++ errors.
...
A common source of errors is to call functions (such as round()) expecting them to work in place, but them actually being designed only to return the processed value. Not using the return value in this case in indicative of a bug, and can be flagged as a warning by using the [[nodiscard]] attribute.
2022-01-20 13:07:49 +00:00
cba2fd2e80
Revert "Add new scaling modes for splash screen"
...
This reverts commit fcc9f5ce39
2022-01-19 16:09:52 +01:00
e0304f83e7
Add translation links to shader errors
2022-01-19 15:16:32 +03:00
8b8e858778
Merge pull request #54489 from briansemrau/texture-delete-update
2022-01-19 10:10:54 +01:00
fcc9f5ce39
Add new scaling modes for splash screen
...
Removes the `fullsize` option which is superseded by `stretch_mode`.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2022-01-18 23:29:11 +01:00
01eefa2c50
Merge pull request #56761 from Calinou/sdfgi-allow-any-number-of-cascades
2022-01-18 16:21:39 +01:00
366d3930ac
Merge pull request #56893 from Chaosus/shader_unify_vardecl
2022-01-18 14:13:56 +03:00
36a82c8c69
Unify variable and array declarations in shaders
2022-01-18 12:42:39 +03:00
ba431a9306
Fix volumetric fog memory leak on resize
2022-01-17 21:30:48 -08:00
2dc7b03a82
Allow using between 1 and 8 cascades for SDFGI
...
This provides more flexibility between performance and quality
adjustments, especially when using SDFGI for small-scale levels
(which can be useful for procedurally generated scenes).
2022-01-17 16:49:02 +01:00
7870cf24f2
Fix invalid read when using LightOccluder2D
2022-01-17 16:02:26 +08:00
d6c7d4ab5d
Fix visible background line in intersections in screen-space reflections
...
Adjusting the step grading by one resolves the issue without affecting
performance or introducing adverse artifacts.
2022-01-16 18:08:07 +01:00
a27b85378b
Merge pull request #56309 from Calinou/remove-pvrtc-support
2022-01-16 11:15:34 +01:00
abd0003e4c
Remove mistakenly added push constant from SSR
2022-01-15 17:03:55 -08:00
08208406ca
Refactor size expression parsing for arrays in the shaders
2022-01-15 15:47:39 +03:00
40be15920f
Remove support for PVRTC texture encoding and decoding
...
On the only platform where PVRTC is supported (iOS),
ETC2 generally supersedes PVRTC in every possible way. The increased
memory usage is not really a problem thanks to modern iOS' devices
processing power being higher than its Android counterparts.
2022-01-14 21:08:22 +01:00
0845b25497
Fix shader crashing when declaring matrix or array varyings
2022-01-14 10:37:39 +03:00
858bcd5058
Fix various typos
...
Found via `codespell -q 3 -S ./thirdparty,*.po,./DONORS.md -L ackward,ang,ans,ba,beng,cas,childs,childrens,dof,doubleclick,expct,fave,findn,gird,hist,inh,inout,leapyear,lod,nd,numer,ois,ony,paket,ro,seeked,sinc,switchs,te,uint,varn,vew`
2022-01-13 23:20:01 -05:00
4201af6649
Fix completion for global constants in shaders
2022-01-13 19:52:06 +03:00
c377891145
Add completion for shader_type
2022-01-13 18:37:13 +03:00
b0356bcb72
Prevent redefinition of main functions in shader
2022-01-13 15:12:35 +03:00
9b1f242feb
Fix cannot use gaussian blur error
2022-01-12 21:58:37 -08:00
586a973b6b
Merge pull request #56169 from dkaste/fix-clip-rects
...
Fix canvas items being drawn outside clip rects
2022-01-12 23:59:42 +01:00
585231a172
Merge pull request #56492 from akien-mga/remove-author-docstrings
2022-01-12 15:24:17 +01:00
422f7b280f
Optimize include files to improve `shader_language.h` compilation speed
2022-01-12 14:19:12 +03:00
bfd0afca58
Merge pull request #55656 from clayjohn/GLSL3-compiler
2022-01-12 11:33:48 +01:00
189662e5bd
Merge pull request #56696 from AnilBK/use-init-lists
2022-01-12 10:04:45 +01:00
99064d57db
New OpenGL batching canvas renderer
2022-01-11 22:26:18 -08:00
6c3a0460a8
Use List Initializations for Vectors.
2022-01-12 10:15:12 +05:45
267bee934a
Merge pull request #56416 from BastiaanOlij/fix_xr_viewport_size_overrule
...
Fix XR viewport size overrule and incorrect usage of internal size
2022-01-11 08:44:36 +01:00
04fa320650
Merge pull request #56627 from Chaosus/shader_better_limit_warning
2022-01-10 14:06:54 +01:00
b0d9e14155
Fix canvas items being drawn outside clip rects
2022-01-09 18:15:46 -05:00
bd61d8f80c
Enhances a shader uniform limit warning
2022-01-08 21:44:37 +03:00
c9f5d88f3a
Use fill() to fill an entire image instead of setting pixels individually.
2022-01-08 17:43:15 +05:45
cd842b65bf
Fix queueing a texture and regular uniform update in RD backend in succession.
2022-01-06 16:05:07 +00:00
ca79373d13
Added material_overlay property to MeshInstance3D
...
Applying overlay materials into multi-surface meshes currently
requires adding a next pass material to all the surfaces, which
might be cumbersome when the material is to be applied to a range
of different geometries. This also makes it not trivial to use
AnimationPlayer to control the material in case of visual effects.
The material_override property is not an option as it works
replacing the active material for the surfaces, not adding a new pass.
This commit adds the material_overlay property to GeometryInstance3D
(and therefore MeshInstance3D), having the same reach as
material_override (that is, all surfaces) but adding a new material
pass on top of the active materials, instead of replacing them.
2022-01-05 11:47:51 +01:00
7c5c351766
Merge pull request #56220 from williamd67/GPULightmapper-implement-sky-ambient-light
...
GPULightmapper: react on sky ambient properties
2022-01-05 10:55:05 +01:00
e976cd0b29
Merge pull request #56208 from williamd67/GPULightmapper-sky-upside-down
2022-01-05 10:51:19 +01:00
c7bbb3a621
Merge pull request #56278 from GanidhuAbey/dof_msaa_bug
2022-01-05 10:47:27 +01:00
679fe92bb3
Fix incorrect format and buffer used for bone weights.
2022-01-05 08:44:59 +02:00
ba2bdc478b
Style: Remove inconsistently used `@author` docstrings
...
Each file in Godot has had multiple contributors who co-authored it over the
years, and the information of who was the original person to create that file
is not very relevant, especially when used so inconsistently.
`git blame` is a much better way to know who initially authored or later
modified a given chunk of code, and most IDEs now have good integration to
show this information.
2022-01-04 20:42:50 +01:00
eab30316ee
Merge pull request #55332 from Calinou/voxelgidata-tweak-default-dynamic-range
...
Decrease the default dynamic range in VoxelGIData to 2.0
2022-01-04 17:18:28 +01:00
3a5a3473be
Merge pull request #54791 from NHodgesVFX/master
...
[4.x] add more OpenGL attributes
2022-01-04 16:52:27 +01:00
bba9d9be14
Merge pull request #56486 from Chaosus/shader_fix_render_mode
2022-01-04 18:44:11 +03:00
095c72b03e
Merge pull request #55790 from Calinou/renderingserver-add-device-type-getter
...
Add `RenderingServer.get_video_adapter_type()` method
2022-01-04 16:43:23 +01:00
851fb16350
Merge pull request #56305 from Calinou/rename-lod-threshold
2022-01-04 15:28:06 +01:00
ff211c8e5a
Merge pull request #55386 from Calinou/allow-disable-depth-prepass
2022-01-04 15:25:11 +01:00
5123ffe4a7
Fix `world_vertex_coords` render mode usage in the shaders
2022-01-04 17:06:12 +03:00
e432181dc3
Merge pull request #55418 from Calinou/voxelgi-dynamic-map-use-16-bit-depth
...
Use 16-bit depth to improve dynamic VoxelGI performance
2022-01-04 14:17:47 +01:00
b74968c2ca
Merge pull request #56477 from Chaosus/fix_device_crash
2022-01-04 13:23:38 +03:00
7f66c16c03
Merge pull request #51206 from clayjohn/Vulkan-ASSGI
2022-01-04 10:00:17 +01:00
34de6d16aa
Merge pull request #54409 from clayjohn/VULKAN-glow-flicker
2022-01-04 09:59:07 +01:00
0e2ef987b1
Add a check for device in shader lang to prevent startup editor crash
2022-01-04 11:50:50 +03:00
370f0a162d
Merge pull request #55424 from Calinou/voxelgi-remove-unused-struct-fields
...
Remove unused struct fields in VoxelGIData
2022-01-04 09:50:00 +01:00
a97889abe4
Merge pull request #55422 from Calinou/gi-shader-remove-unused-define
...
Remove unused code in GI shaders
2022-01-04 09:49:42 +01:00
fe52458154
Update copyright statements to 2022
...
Happy new year to the wonderful Godot community!
2022-01-03 21:27:34 +01:00
fd9c92d4ab
Add a shader warning when the uniform buffer limit is exceeded
2022-01-03 16:24:56 +03:00
9221c0f8ad
Merge pull request #56190 from Chaosus/shader_varying_pass_to_func
2022-01-03 13:08:55 +01:00
c6c834e745
Merge pull request #56187 from Chaosus/fix_default_texture
2022-01-03 13:08:25 +01:00
cd38b42987
Merge pull request #56370 from Chaosus/fix_shader_instance_uniform
2022-01-03 13:06:18 +01:00
a124f1effe
Fix various typos
...
Found via ` codespell -q 3 -S ./thirdparty,*.po,./DONORS.md -L ackward,ang,ans,ba,beng,cas,childs,childrens,dof,doubleclick,expct,fave,findn,gird,hist,inout,leapyear,lod,nd,numer,ois,ony,paket,seeked,sinc,switchs,te,uint,varn`
Update editor/import/resource_importer_layered_texture.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update doc/classes/TileSetScenesCollectionSource.xml
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/gui/graph_edit.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/resources/animation.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/resources/animation.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/resources/animation.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/gui/rich_text_label.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Revert previously committed change
2022-01-02 01:03:58 -05:00
9fe7565014
Fix XR viewport size overrule and incorrect usage of internal size
2022-01-02 11:17:36 +11:00
ab239e9abb
Fix incorrect updating global uniform buffer
2021-12-31 13:31:01 +03:00
df09bc38cb
Rename Lod Threshold to Mesh Lod Threshold
...
This makes it more obvious that the setting only affects mesh LOD,
not manual (H)LOD achieved using visibility ranges.
2021-12-29 00:11:50 +01:00
133486bfba
fixed depth of field bug with msaa
2021-12-26 23:13:47 -08:00
68a5dad226
GPULightmapper: react on sky ambient properties
...
The panorama texture creation, used by GPULightmapper, has been adjusted to
also take the sky ambient properties into account.
2021-12-24 15:47:42 +01:00
246fbd5442
GPULightmapper: cube to panorama copy function flip y based on flag
...
Cube to panorama copy function unconditionally flipped y, while other copy functions flipped y base on FLAG_FLIP_Y. Condition is added.
2021-12-24 00:47:42 +01:00
108b6a2000
Allow pass varyings as out param to the function, when it's possible
2021-12-23 18:03:19 +03:00
8e5008dfbd
Fix default texture of unassigned sampler with hint_normal
2021-12-23 11:15:46 +03:00
e8a457ba89
Refactor render_mode in shaders, forbid declaring duplicates
2021-12-21 22:20:09 +03:00
e880294d9f
[Headless] Workaround texture load failure.
...
Some assets are loaded based on OS/server feature detection, namely
textures (but potentially others).
The ResourceImporter will fail to load a texture if the OS reports not
supporting it. The OS, in turn, checks texture format support via the
RenderingServer.
This commit makes the dummy rasterizer report known texture formats as
supported (although unused), so that scenes can be correctly loaded when
they include references to imported textures.
2021-12-20 09:18:26 +01:00
be83968b6b
Merge pull request #55970 from Chaosus/shader_fix_struct_warning
2021-12-16 13:35:44 +01:00
1414a7be91
Fix struct usage passing to shader warning system
2021-12-15 22:54:46 +03:00
f0a58af12f
Rename shader hint `filter_anisotropy` to `filter_anisotropic`
2021-12-15 22:12:38 +03:00
25a2241e7d
Fix shader array parsing in variable declaration
2021-12-15 17:54:15 +03:00
de8348a9b3
Merge pull request #55903 from Chaosus/shader_struct
2021-12-15 13:07:48 +01:00
864ccb5776
Merge pull request #55913 from Chaosus/fix_shader_crash
2021-12-15 13:07:34 +01:00
09185d76ac
Rename shader hint `filter_aniso` to `filter_anisotropy`
2021-12-15 13:18:32 +03:00
e962900f23
Rename and reorder bake mode properties for consistency
...
The order now goes from least to most computationally expensive:
- Disabled
- Static
- Dynamic
2021-12-14 12:01:12 +01:00
3cbd8ef098
Fix shader crash when assigned array from struct to a variable by index
2021-12-13 21:19:13 +03:00
31cc6ba622
Allow declaring multiple members in one expression in shader structs
2021-12-13 19:10:08 +03:00
8862d1426d
Restore shader parsing errors with lack of semicolon in a block
2021-12-11 17:30:40 +03:00
92e9cca5be
Rename `hint_aniso` to `hint_anisotropy` in the shader language
...
The word "anisotropy" is used in full form in BaseMaterial3D's
anisotropy-related properties.
2021-12-10 17:41:17 +01:00
b3174e7af9
Add `RenderingServer.get_video_adapter_type()` method
...
This can be used to distinguish between integrated, dedicated, virtual
and software-emulated GPUs. This in turn can be used to automatically
adjust graphics settings, or warn users about features that may run
slowly on their hardware.
2021-12-10 17:10:47 +01:00
bcbcf14469
Refactor constant suffix parsing in a shader
2021-12-10 15:38:27 +03:00
f455660e93
Merge pull request #55572 from aaronfranke/ci-double
2021-12-10 10:02:38 +01:00
dcf3594500
Merge pull request #55763 from Chaosus/shader_hint_completion
2021-12-10 11:44:01 +03:00
bdf8340e59
Merge pull request #43181 from nathanfranke/string-empty
...
Replace String comparisons with "", String() to is_empty()
2021-12-10 08:56:31 +01:00
b66510d509
Added completion for uniform hints in a shader
2021-12-10 10:12:25 +03:00
f0b5cd51b6
Merge pull request #55714 from Geometror/fix-fog-spotlight
2021-12-09 18:05:17 +01:00
e9808e3d9a
Add a double-precision editor build to CI
2021-12-09 09:52:48 -06:00
49403cbfa0
Replace String comparisons with "", String() to is_empty()
...
Also:
- Adds two stress tests to test_string.h
- Changes to .empty() on std::strings
2021-12-09 04:48:38 -06:00
1da732af35
Fix volumetric fog in combination with spotlights
2021-12-08 22:17:09 +01:00
76f6c0849c
Make `compile` shader function to use struct instead long parameter list
2021-12-08 11:34:40 +03:00
c5550108c8
Decrease the default dynamic range in VoxelGIData to 2.0
...
This reduces visible banding in indirect lighting and reflections.
Sharp reflections now match more closely the original scene.
The downside of this change is that clipping may appear in reflections
in extremely bright scenes, but this should not be a concern in most
scenes.
2021-12-08 00:28:17 +01:00
46d384060e
Merge pull request #35901 from nathanfranke/pool-byte-array-subarray-exclusive
2021-12-07 14:00:59 +01:00
89ec3d3bc7
Remove or make verbose some debugging prints
...
The message about SpatialMaterial conversion was turned into a warning,
as it can potentially interfere with porting projects from Godot 3.x
(if there's a bug in the conversion code).
2021-12-05 23:22:23 +01:00
10b10ae1fa
Fix `^=` operator in shaders
2021-12-03 10:20:44 +03:00
1398436ab8
Merge pull request #53904 from ChristopheClaustre/bugfix_shader_compile_spirv_from_source
2021-12-02 10:07:35 +01:00
5ee73dc5a6
Fix shader crash when using existed constant name for struct
2021-12-01 18:11:45 +03:00
a48c205191
Fix declaring array size twice in global shader constant
2021-12-01 16:44:25 +03:00
5ba93619fa
Allow using empty statements in the shader, added formatting warning
2021-12-01 11:52:25 +03:00
5643f5e616
Merge pull request #55490 from Chaosus/fix_shader_crash
2021-11-30 20:13:12 +01:00
bdd118e765
Merge pull request #55431 from Chaosus/shader_fix_constants
2021-11-30 19:40:52 +01:00
be7c03779a
Fix shader crash when assigning array to non-array in global constant
2021-11-30 21:28:55 +03:00
5b4d8545ed
Fix `INDEX` built-in in a process function of particle shader
2021-11-29 12:54:24 +03:00
6e80e97b0f
Fix built-in(PI, TAU, E) assignment to a global constant in a shader
2021-11-29 10:32:36 +03:00
36106dba3b
Remove unused struct fields in VoxelGIData
...
This reduces the struct size from 112 bytes to 96 bytes.
2021-11-28 23:09:51 +01:00
0beacf2ce8
Remove unused code in GI shaders
2021-11-28 22:58:54 +01:00
565f9c0448
Use 16-bit depth to improve dynamic VoxelGI performance
...
In a complex scene with several dynamic emissive objects, this
saves over 1 ms of GPU time on a GTX 1080 in 2560×1440.
2021-11-28 18:51:36 +01:00
989a7d9270
Allow disabling the depth prepass in the Vulkan Clustered backend
...
In scenes that have little to no overdraw, disabling the depth prepass
can give a small performance boost. Nonetheless, in most other scenarios,
the depth prepass should be left enabled as it improves performance
significantly.
2021-11-27 17:54:45 +01:00
dd30253cdc
PackedByteArray, Array slice end exclusive, rename subarray to slice
2021-11-26 22:13:12 -06:00
0f1f002e74
Fix `TIME` using in custom functions of particle shader
2021-11-26 19:03:01 +03:00
4813abc6e7
Merge pull request #55311 from Chaosus/fix_uniform_array
...
Fix uniform array alignment to fix a bug
2021-11-26 08:25:14 +01:00
079ae6a03f
Use `WARN_PRINT_ONCE()` for FSR-related warning messages
...
`print_error()` should generally not be used directly. Also,
falling back is best done by printing a warning message instead
of an error message.
2021-11-25 22:47:11 +01:00
43d999e346
Fix uniform array alignment to fix a bug
2021-11-25 23:38:08 +03:00
c73a51fd55
Remove disabled debug code in ClusterBuilderRD
2021-11-25 20:28:50 +01:00
9b1f8f7a96
Revert "Pushes array of uniforms to first place in the buffer"
2021-11-25 16:13:19 +03:00
b7e6e50dd2
[macOS / iOS] Use non atomic operation to store facing bits on MoltenVK.
2021-11-25 12:43:45 +02:00
547c270777
Merge pull request #51679 from Je06jm/fsr
...
AMD FidelityFX Super Resolution
2021-11-24 22:34:48 +01:00
3e3300637e
Merge pull request #55281 from bruvzg/mvk_fog_volumes
2021-11-24 16:59:20 +01:00
5e0a034524
[macOS / iOS] Use storage buffers instead of unsupported images for the volumetric fog on MoltenVK.
2021-11-24 09:16:16 +02:00
e078f970db
Rename `remove()` to `remove_at()` when removing by index
2021-11-23 18:58:57 -07:00
20deb0917d
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 14:16:03 -07:00
c7043dbfdc
Prevent return statement from using in block in shader main functions
2021-11-23 10:36:33 +03:00
f4c0e90fd9
Allow passing non-variable constant to const function param in shaders
2021-11-19 12:14:13 +03:00
fa11b45961
Merge pull request #55084 from JFonS/fix_depth_prepass
...
Fix Depth-Prepass transparency mode
2021-11-18 17:39:46 +01:00
3f9c24a8d7
Merge pull request #55085 from JFonS/transparency_fixes
...
Fix transparency state initialization
2021-11-18 17:17:20 +01:00
4c4b6620a0
Fix Depth-Prepass transparency mode
...
Add mising bits of implementation and ensure depth-prepass objects are
only rendered in the transparency pass.
2021-11-18 12:49:46 +01:00
c30aa372ca
Merge pull request #55029 from clayjohn/VULKAN-SRGB
...
Add SHADER_IS_SRGB define to Vulkan renderer
2021-11-17 08:46:23 +01:00
358820c4b7
Fix SRGB conversions in Vulkan Renderer
2021-11-16 20:56:13 -08:00
038be68649
Merge branch 'godotengine:master' into bugfix_shader_compile_spirv_from_source
2021-11-14 03:23:22 +01:00
df3b42411d
Fix broken light_compute in mobile renderer
2021-11-13 17:24:31 +03:00
716e15cd26
Fix multimesh still drawing when visible instances is zero
2021-11-12 21:51:14 -05:00
dbf20f58a0
Fix transparency state initialization
2021-11-12 12:11:57 +01:00
826e781bfa
Fix default_texture_param in shader pipeline to support uniform arrays
2021-11-12 12:53:40 +03:00
f123a79170
Make draw/compute lists threadsafe
...
Lock the rendering device while command buffers are in use
2021-11-11 13:55:09 -05:00
a45ae7b1c7
Fix shader crashing when using `ALBEDO` or `ALPHA` in light function
2021-11-11 11:59:30 +03:00
5cc0ad5393
Merge pull request #54783 from ator-dev/fix-override-exposure
2021-11-10 18:45:04 +01:00
cc39ba5509
rendering_device: if one compiles with at least on stage without sources, it was always returning an unusable bytecode (because errored)
2021-11-09 22:53:30 +01:00
dbe366a830
add more OpenGL attributes
2021-11-08 20:12:11 -05:00
d7a4187b05
Implement CameraEffects override_exposure
2021-11-08 21:14:56 +00:00
bbfa5f29c7
Pushes array of uniforms to first place in the buffer to prevent bug
2021-11-07 23:30:09 +03:00
0eff109a21
Added SSIL post processing effect
2021-11-06 12:43:19 -07:00
91aa7cf1da
Decrease the default VoxelGI quality to improve performance
...
On a GeForce GTX 1080 in 2002×1447 resolution, decreasing VoxelGI quality
from High to Low quality saves 1.2 ms of GPU time in a medium-sized
test scene. This only results in a minor drop in quality.
2021-11-06 19:40:52 +01:00
ac24070056
Use Callable in RS::request_frame_drawn_callback
2021-11-05 01:59:38 -04:00
c012fbc8b2
Rename `PROPERTY_USAGE_NOEDITOR` to `PROPERTY_USAGE_NO_EDITOR`
...
This is consistent with other constants that include `NO`,
such as `PROPERTY_HINT_COLOR_NO_ALPHA`.
2021-11-03 23:06:17 +01:00
4a1c28460e
Fix materials not updating when texture replaced/deleted
2021-11-01 15:33:59 -04:00
02ae47154c
Merge pull request #54356 from Chaosus/shader_fix_matrix_autocompletion
2021-11-01 14:06:04 +01:00
d86b680e07
Merge pull request #54480 from timothyqiu/texture-replace
2021-11-01 12:56:05 +01:00
10818cfc10
Fix memory leak when using CurveTexture.set_texture_mode
2021-11-01 18:57:59 +08:00
210e6cc167
Merge pull request #54459 from rxlecky/fix-multimesh-buffer-overflow-53603
2021-11-01 11:18:11 +01:00
6b04f08b28
Fix multimesh buffer overflow in RendererStorageRD
2021-10-31 18:48:51 +01:00
1aef3a42b2
Merge pull request #54448 from CakHuri/treshold-to-threshold
...
Repair mistyped of 'threshold' on several files.
2021-10-31 18:32:18 +01:00
16dc607f8a
Merge pull request #54307 from Calinou/add-opengl-renderer-squash
...
Add OpenGL renderer (squashed)
2021-10-31 18:30:38 +01:00
4052d85d05
Repaired mistyped of 'threshold' on several files.
2021-10-31 22:11:42 +07:00
8a10bb7d0d
Use OpenGL 3.3 core profile instead of compatibility profile
...
- Rename OpenGL to GLES3 in the source code per community feedback.
- The renderer is still exposed as "OpenGL 3" to the user.
- Hide renderer selection dropdown until OpenGL support is more mature.
- The renderer can still be changed in the Project Settings or using
the `--rendering-driver opengl` command line argument.
- Remove commented out exporter code.
- Remove some OpenGL/DisplayServer-related debugging prints.
2021-10-31 15:56:45 +01:00
d6f972fad4
Merge pull request #54403 from briansemrau/fix-small-fogvolume
...
FogVolume don't dispatch compute with zero-dimension groups
2021-10-31 09:12:10 +01:00
8f75ad4df2
Don't use Texture image caches if they are rendered to
2021-10-30 13:34:39 -04:00
6b0b1a4c04
Merge pull request #54405 from JFonS/fix_instance_index
...
Fix instance index in forward clustered shader
2021-10-30 14:22:22 +02:00
346e497959
Disallow compute dispatch with zero dimensions.
2021-10-30 02:39:25 -04:00
4d1d2b3900
Weight glow samples to reduce fireflies
2021-10-29 21:41:57 -07:00
6db13d3231
Fix instance index in forward clustered shader
2021-10-30 02:53:09 +02:00
ce97ddbcb1
Rename GLES2 driver to OpenGL to prepare for the upgrade to GLES3
...
- Use lowercase driver names for the `--rendering-driver`
command line argument.
2021-10-30 02:05:49 +02:00
e3491a3744
Add GLES2 2D renderer + Linux display manager
...
First implementation with Linux display manager.
- Add single-threaded mode for EditorResourcePreview (needed for OpenGL).
Co-authored-by: clayjohn <claynjohn@gmail.com>
Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2021-10-30 02:05:48 +02:00
4da0de0085
Fix error spammed to output if `FogVolume` is setted to scene
2021-10-29 23:24:01 +03:00
a6ddfecc9f
Fix crash when opening a converted `FogMaterial`
2021-10-29 14:18:38 +03:00
1b2cd9f251
Addition of FogVolumes, FogShaders, FogMaterial, and overhaul of VolumetricFog
...
Co-authored-by: Brian Semrau <brian.semrau@gmail.com>
2021-10-28 22:02:23 -07:00
04a2053f9b
Removed incorrect autocompletion of matrixes in shader
2021-10-28 20:21:18 +03:00
f7d852b532
Merge pull request #54350 from akien-mga/clang-format-dont-align-operands
2021-10-28 17:10:52 +02:00
e2deec67b9
Merge pull request #54222 from JFonS/instance-fade
2021-10-28 16:05:55 +02:00
3a6be64c12
clang-format: Various fixes to comments alignment from `clang-format` 13
...
All reviewed manually and occasionally rewritten to avoid bad auto formatting.
2021-10-28 15:43:36 +02:00
3b11e33a09
clang-format: Disable alignment of operands, too unreliable
...
Sets `AlignOperands` to `DontAlign`.
`clang-format` developers seem to mostly care about space-based indentation and
every other version of clang-format breaks the bad mismatch of tabs and spaces
that it seems to use for operand alignment. So it's better without, so that it
respects our two-tabs `ContinuationIndentWidth`.
2021-10-28 15:19:35 +02:00
95bc9c40d9
Fix shadow disabling on mobile renderer
2021-10-26 15:37:22 +02:00
c46d1ea2b2
Fix shadow disabling settings
...
Fixes the SHADOW_CASTING_SETTING_OFF setting in
GeometryInstance3D and the "shadows_disabled" render
mode in spatial materials, which were not working
before.
2021-10-25 16:11:32 +02:00
c571e4a7f4
Implement distance fade and transparency
...
The built-in ALPHA in spatial shaders comes pre-set with a per-instance
transparency value. Multiply by it if you want to keep it.
The transparency value of any given GeometryInstance3D is affected by:
- Its new "transparency" property.
- Its own visiblity range when the new "visibility_range_fade_mode"
property is set to "Self".
- Its parent visibility range when the parent's fade mode is
set to "Dependencies".
The "Self" mode will fade-out the instance when reaching the visibility
range limits, while the "Dependencies" mode will fade-in its
dependencies.
Per-instance transparency is only implemented in the forward clustered
renderer, support for mobile should be added in the future.
Co-authored-by: reduz <reduzio@gmail.com>
2021-10-25 11:39:34 +02:00
88d9914519
Fix state inconsistencies in visibility dependencies.
2021-10-25 11:37:53 +02:00
3bebbcacdb
Merge pull request #53992 from Calinou/hard-shadow-mapping-allow-dithering
2021-10-22 19:34:09 +02:00
bbcf8ac672
Merge pull request #54082 from Chaosus/fix_shader_crash
2021-10-21 21:19:24 +03:00
57fd362fe1
Prevent shader crash when passing constant expression to `textureGather`
2021-10-21 19:46:05 +03:00
e87ec8ec17
Add Soft Very Low shadow quality mode for 3D
...
This can be used to improve 3D shadow rendering quality at little
performance cost. Unlike the existing Hard setting which is limited
to variable shadow blur only, it works with both fixed blur and
variable blur.
2021-10-21 18:34:26 +02:00
9142df46b3
Fix built-in texture samplers passing for spatial shader mode
2021-10-21 12:32:32 +03:00
5a354aaf6d
Prevent a rendering crash and error spam for uniform texture array
2021-10-20 21:30:27 +03:00
244faf5588
Merge pull request #53972 from zedutch/fix-shader-time-update
...
Fix shaders using `TIME` not continuously updating
2021-10-19 16:37:55 +02:00
85a8939fa2
Merge pull request #53790 from briansemrau/remove-distant-shadowy-void
2021-10-19 15:17:09 +02:00
4387f9645b
Merge pull request #52940 from groud/toast_notification
2021-10-19 09:57:13 +02:00
723b988fde
Merge pull request #52210 from BastiaanOlij/enhance_xr_trackers
2021-10-19 08:11:32 +02:00
0e31465a59
Fix shaders that use TIME do not force editor to continuously update
2021-10-18 22:53:20 +02:00
2200544141
Validate enum range in RendererViewport::viewport_get_render_info
2021-10-18 22:58:38 +08:00
26a26d6657
Fix errors on quitting from an empty project
2021-10-18 14:24:03 +03:00
5d1ea92daf
Rework XR positional trackers
2021-10-17 12:12:20 +11:00
b4eeeb315a
Swap args of Plane(point, normal) constructor
...
Now (normal, point)
2021-10-15 20:49:42 -05:00
c4513d5add
Rename RD::free binding to free_rid
2021-10-15 15:35:05 -04:00
5a276443bd
Merge pull request #53815 from Chaosus/fix_wireframe_render_mode
2021-10-15 16:19:36 +02:00
31ad85881d
Fix `wireframe` render mode
2021-10-15 06:53:52 +03:00
e9f1b0a0b2
Remove incorrect fog height density remapping
2021-10-14 16:09:45 -04:00
4fefd7cddd
Fix several issues with directional shadows
...
- Internally disable blend splits in orthogonal directional shadow mode
- Fix soft shadows ignoring fade and blend_splits
- Fix soft shadow edge stability
2021-10-14 11:44:32 -04:00
0587e5e018
Implement toast notifications in the editor
2021-10-14 13:30:54 +02:00
a62e240260
Fix the height fog effect
2021-10-14 04:08:39 -04:00
e9b7ffd1fa
Added few more built-ins to shader language
2021-10-13 20:27:36 +03:00
88463c3eee
Merge pull request #53712 from CakHuri/nullptr
...
Replace NULL with nullptr
2021-10-12 22:30:43 +02:00
033dc4dbef
Replaced NULL with nullptr
2021-10-12 20:20:19 +07:00
7e51e4cb84
Fix some LGTM errors of "Multiplication result converted to larger type"
2021-10-12 00:17:27 -05:00
db2ee03fff
Fix shader crash on using METALLIC and ROUGHNESS built-ins in light func
2021-10-11 13:35:53 +03:00
09b0293fad
Merge pull request #53066 from Chaosus/shader_funcs
2021-10-10 21:37:07 +02:00
5ae569560d
Fix missing argument names in bindings
...
While at it, tweak some boolean setters to use `p_enabled` for the bool.
Also renames `draw_minimap()` to `set_draw_minimap()`.
2021-10-09 00:20:10 +02:00
73c6e19acc
Allow any floating-point value as a 3D rendering scale option
...
This allows for finer control over 3D rendering resolution.
Supersampling can also be performed by setting a 3D rendering
resolution above 1.0, which is useful for offline rendering or
for very high-end GPUs.
2021-10-08 18:22:10 +02:00
Rémi Verschelde
Ansraer
notSanil
Bastiaan Olij
snowapril
kobewi
Jesse Dubay
reduz
Priyansh Rathi
Hugo Locurcio
Rémi Verschelde
floppyhammer
Darryl Ryan
clayjohn
bruvzg
Yuri Roubinsky
Hendrik Brucker
SaracenOne
Bartłomiej Dusak
ZuBsPaCe
theoniko
Anilforextra
orosmatthew
Nathan Franke
jfons
lawnjelly
Samuel Pedrajas
Haoyu Qiu
luz paz
Darren Kaste
Fernando Cosentino
JFonS
GanidhuAbey
William Deurwaarder
Fabio Alessandrelli
Aaron Franke
Nathan Franke
Lightning_A
Je06jm
chris.clst
Brian Semrau
NHodgesVFX
Dominic-ATOR
SeleckyErik
M. Huri
Robin Arys
mennomax
Gilles Roudière