3930e755e4
Added Performance.AUDIO_OUTPUT_LATENCY
2018-07-17 08:54:59 -03:00
063a22851a
-Added support for raycast in KinematicBody2D
...
-Added support for snapping in KinematicBody2D
2018-07-16 20:04:07 -03:00
de910f8c26
Finally figured out how to implement AnimatedTexture properly.
2018-07-16 11:43:49 -03:00
e6ad5e23b4
* Small hex/float/integer parsing refactoring
...
* Potential bug fix on hex (cannot be used atm)
* Added optional typing for floats, eg:
"1f" -> "1.0"
"1.f" -> "1.0"
"1.99f" -> "1.99"
"1." -> "1.0"
2018-07-15 14:58:23 +02:00
f6ce73f724
Visual Shaders are back.
2018-07-14 18:16:18 -03:00
7a74d310aa
Fixed error due to bad cursor handling when parsing shader code
...
Fixed completion error log thrown on "no auto-completion found" for typings with no completion.
2018-07-14 19:59:11 +02:00
d488c35efa
Merge pull request #20026 from taylorjoshuaw/fix-window-height-crash
...
Temporary fix to issue #19628 and #19207
2018-07-12 05:29:03 +02:00
118d4f3115
Merge pull request #19540 from muiroc/cylinder
...
Cylinder resource and collision shape (bullet only)
2018-07-12 05:09:37 +02:00
892a4b175a
Changed minimum visible viewport size
...
When the viewport's size.y becomes lower than 2, the storage->frame.current_rt->effects.mip_maps[0].sizes Vector during rendering becomes empty, resulting in crashes in at least GLES3. This is a temporary fix to stop rendering a viewport when its size is below 2 rather than below 1.
2018-07-07 17:10:32 -05:00
7dcaabaf19
Support for CPU based particles, which aids compatibility with OpenGL ES 2.0
2018-07-06 20:21:42 -03:00
92bfde531c
Merge pull request #19786 from JFonS/correct_normal_scaling
...
Add render mode to ensure correct normals when using non-uniform scaling
2018-07-04 15:09:59 +02:00
e179bf0726
Ensure, if a texture meant for a normal map is imported and size limit exists, that it's renormalized after resize.
2018-07-03 10:56:31 -03:00
d280b14e6e
Hacked around duplication bug. I think duplicate needs to be even smarter, maybe pass two bools? (containers and/or resources)
2018-07-03 08:34:06 -03:00
7fc2367508
Added ability for SSAO to affect AO textures too
2018-07-02 16:50:52 -03:00
0a36e974da
added cylinder shape support
2018-07-01 11:16:54 +02:00
3852c5f8a0
Merge pull request #19678 from vnen/remove-latency-print
...
Remove audio latency print
2018-06-29 22:28:29 -03:00
ddc40e5115
Fix typo in y shift
2018-06-23 22:41:29 +10:00
c8cf71753c
Add render mode to ensure correct normals when using non-uniform scaling
2018-06-21 00:12:12 +02:00
5d61cdf5b5
Remove audio latency print
2018-06-20 14:00:19 -03:00
c8a5145a6d
Removed unused AudioServer::update function
2018-06-15 14:13:33 -03:00
3fc9b5d93f
Moved culling, updated lights and shadows into a prepare function so it is only called once for stereo rendering
2018-06-11 21:51:30 +10:00
b659fd6d74
Entirely new (and much improved) animation editor.
2018-06-07 12:52:00 -03:00
35eb7f2d6a
Rasterizers are now in sync with engine
...
The rasterisers (both GLES3 and GLES2) were calculating their own frame delta time
This fix lets the rasterizers get the frame delta through the draw call
That way any regulations to the frame step from the main script will not cause particle systems to process at a different step than the rest of the Engine.
Remove unused rasterizer storage variable
frame.prev_tick variable were not used anywhere and has been removed
2018-06-05 16:33:02 +02:00
2368b31e1e
Fix return type of isnan and isinf in the shader language
2018-06-01 01:34:32 +02:00
e790d4aafa
Merge pull request #18349 from Gorgexpress/master
...
Fixed 2D intersect_shape limiting broadphase results
2018-05-26 18:29:49 +02:00
0ea9c7c4dd
Expose methods area_set_area_monitor_callback and area_set_monitorable in PhysicsServer and Physics2DServer
2018-05-25 20:46:54 +02:00
97b1e8b517
Merge pull request #18868 from bruvzg/clang_6_workaround
...
Workaround for clang 6.0.0 / Xcode 9.3 release (-O3) build bug.
2018-05-16 23:16:43 +02:00
f2ba9a1f65
Fix bad operator check in `ShaderLanguage::_validate_assign`
2018-05-16 21:28:12 +02:00
b68222e4e7
Workaround for clang 6 bug.
2018-05-14 18:11:26 +03:00
5f66734d2d
Implemented physics material
...
Hidden a function
Fixed travis static check
2018-05-11 03:23:09 +02:00
3fa352dc9c
canvas_item_add_triangle_array bind fixup
2018-05-08 21:41:41 -03:00
de9683b605
Merge pull request #17559 from simedis/joint_motors
...
Implemented interface for bullet linear motors
2018-05-08 10:23:41 +02:00
3051bb8a81
Merge pull request #17845 from JFonS/disable_spatial_shadows
...
Added flag on SpatialMaterial to disable shadows
2018-05-07 16:18:25 -03:00
4897373015
Merge pull request #18144 from Crazy-P/Resolves-crash-on-shape2D-culling-for-empty-Concave-shapes
...
Resolves crash on shape2D culling for empty Concave shapes
2018-05-07 15:35:33 -03:00
0db4c576f1
Merge pull request #18533 from JFonS/fix_shader_compile
...
Fix vector reduction in shader language
2018-05-07 14:30:44 -03:00
5b50685b38
Fix vector reduction in shader language
2018-05-07 19:25:31 +02:00
b96cd25305
Merge pull request #18495 from Zylann/partial_texture_update
...
Added partial texture update to VisualServer
2018-05-07 13:20:38 -03:00
35322c0678
Merge pull request #18677 from BastiaanOlij/add_no_blend
...
Add no-blend canvas item render_mode
2018-05-07 09:44:17 -03:00
6103c8d7a3
Add no-blend canvas item render_mode
2018-05-07 22:41:12 +10:00
6f7fefa489
Added option to viewport to keep linear color
2018-05-06 19:28:09 +10:00
b3e4bc562c
Skeleton for 2D WIP
2018-05-03 17:29:56 -03:00
de97339a2d
Merge pull request #18291 from akien-mga/coverity-uninitialized-scalar-var
...
Fix Coverity reports of uninitialized scalar variable
2018-05-01 19:14:07 +02:00
4cce6f3417
Merge pull request #18321 from Crazy-P/Fixes-logically-dead-code
...
Fixes logically dead code (Coverity)
2018-05-01 08:35:10 +02:00
c755cced83
Added partial texture update to VisualServer
2018-04-29 03:09:49 +02:00
1c419531a0
Change ".." punctuation for "..." in editor strings ( #16507 )
2018-04-22 19:36:01 +02:00
1ba106a71e
Fixed 2D intersect_shape limiting broadphase results
...
Physics2DDirectSpaceStateSW was applying the result limit to broadphase
collision detection instead of narrow. This is inconsistent with its 3D
variant, as well as the rest of the 2D direct space state functions.
Broadphase is now limited by INTERSECTION_QUERY_MAX like everything else,
and narrow phase is exited early when the result limit has been reached.
2018-04-22 06:01:29 -04:00
e6deba8d19
Fixes logically dead code (Coverity)
...
Fixes reported logically dead codes by Coverity
* image.cpp: Doesn't really need any modification. But to remove the bug
report then we have to move the MAX call away from the for loop
statement.
* rasterizer_gles3.cpp: Removes unnecessary elif condition since it is
checked earlier in the function
* collada.cpp: If stamement never reached due to macro ERR_CONTINUE does
the same.
* navigation_mesh.cpp: Variables should always be null - however, also
checked for the very same condition in their function call. Leaving this
for review (whether the function call is necessary or not)
* path_editor_plugin.cpp: If cancel is true, then it should restore the
edited value to the original provided.
http://docs.godotengine.org/en/3.0/classes/class_editorspatialgizmo.html#class-editorspatialgizmo-commit-handle
* spatial_editor_gizmos.cpp: the very condition of i >= 3 is
predetermined in the if case right before it. Thus case 1 is always '1'
and case 2 is always '-1'
* grid_map_editor.cpp: Same as above in spatial_editor_gizmos.cpp
* voxel_light_baker.cpp: Same as above in spatial_editor_gizmos.cpp
* visual_server.cpp: Same as above in spatial_editor_gizmos.cpp
* visual_script_expression.cpp: char '-' is already true in the switch
case mechanism. Thus it can never reach to default case.
* particles.cpp: Case 'PARAM_MAX' is unreachable due to index checking
right before the switch execution.
* shader_language.cpp: Invalid index is handled in switch default case.
`type < TYPE_FLOAT && type > TYPE_VEC4` -> `(type < TYPE_FLOAT || type > TYPE_VEC4`)
Fixes the "always false problem" in TODO comment.
2018-04-21 22:35:23 +08:00
bf7ca623a6
Fix Coverity reports of uninitialized scalar variable
...
Fixes most current reports on Coverity Scan of uninitialized scalar
variable (CWE-457): https://cwe.mitre.org/data/definitions/457.html
These happen most of the time (in our code) when instanciating structs
without a constructor (or with an incomplete one), and later returning
the instance. This is sometimes intended though, as some parameters are
only used in some situations and should not be double-initialized for
performance reasons (e.g. `constant` in ShaderLanguage::Token).
2018-04-19 15:20:45 +02:00
9a4110a451
Merge pull request #17391 from PJB3005/18-03-09-fix-canvas-light-shaders
...
Fixes canvas light shaders.
2018-04-18 13:31:28 +02:00
59b816679e
Fix typos in shader_language.cpp
2018-04-17 19:21:00 +07:00
25ba49fd88
Fixes canvas light shaders.
...
Fixes #16904
Restore more out functionality, fix built-ins.
Requested changes, I think?
2018-04-13 15:18:28 +02:00
158c7c72c7
Resolves crash on shape2D culling for empty Concave shapes
...
Fixes https://github.com/godotengine/godot/issues/17789
2018-04-12 18:15:34 +08:00
72aa87758a
Update classref and docs, fix missing parameters' name
2018-04-11 10:20:22 +07:00
20e68fef85
Merge pull request #17151 from ShyRed/disabled_shapes_2d
...
Remove disabled shapes from physics 2D calculations
2018-04-08 11:16:55 -03:00
8a5fb669ae
Merge pull request #17421 from Chaosus/fixshaderbugs
...
Fix few bugs in shader definitions
2018-04-08 09:33:12 -03:00
10448063c4
Merge pull request #17594 from ivodopiviz/float-overflow
...
Changed debug max distance to avoid overflow
2018-04-08 09:14:29 -03:00
1570a72eee
Merge pull request #17742 from marcelofg55/audio_device_list
...
Added new audio device functions to set/get the audio device
2018-04-07 16:40:47 -03:00
9c307d4b6c
Added flag on SpatialMaterial to disable shadows
2018-03-29 18:46:42 +02:00
d974fa1780
Removed redundant abs shader builtin
2018-03-28 12:50:55 +03:00
ecc1b34cbc
Added new audio device functions to set/get the audio device
2018-03-26 17:41:05 -03:00
c537107af9
Merge pull request #17680 from beniwtv/master
...
Fix compressor audio effect sidechain selection
2018-03-23 10:47:11 +01:00
aebe55210a
Merge pull request #17532 from BastiaanOlij/arvr_enhancements
...
A few enhancements on the ARVR Server
2018-03-23 10:15:15 +01:00
9042ef3836
Fix missing const in CapsuleShapeSW::get_area
2018-03-21 23:58:40 -03:00
7792dfe554
Fix compressor audio effect sidechain selection
2018-03-21 22:45:30 +01:00
a238e53da9
Merge pull request #17637 from robfram/fix-draw_polyline_colors-crash
...
Fix crash in `canvas_item_add_polyline` when passing more points than colors
2018-03-20 11:23:15 +01:00
8eedb2afe2
Fix crash in `canvas_item_add_polyline` when passing more points than colors
...
When `p_points.size() > p_colors.size()`, it crashed with invalid
array access to `p_colors`. Also, when `p_colors` was an empty
`Vector` it crashed due a missing `else` checking the `size`
condition, as the code handling that special case exists.
This PR fixes the missing `else` for `p_colors.size == 0` and,
following the `canvas_item_add_multiline` spirit, it only uses the
first color for the whole polyline if points and colors differ in
size.
Fix #17621 .
2018-03-19 19:22:38 +01:00
87ebdd6041
Fix possible crash when audio channels change
2018-03-19 09:00:11 -03:00
55f79f2e80
Changed debug max distance to avoid overflow
...
Changed it to roughly sqrt(FLT_MAX), it's a little less to account for float inaccuracies.
Fixes #1835
2018-03-17 23:32:07 +01:00
09c887f38e
Implemented interface for bullet joint motors
2018-03-16 13:37:15 +01:00
395ecc2235
Merge pull request #16964 from mrcdk/audio_server_bus_changed_fix
...
AudioServer emit bus_layout_changed signal when adding, moving or del…
2018-03-16 00:10:52 +01:00
009b0bab49
Merge pull request #17248 from Cygon/implement-extra-culling-margin
...
Apply culling margin (fixes issue #16115 )
2018-03-15 23:45:59 +01:00
479f531635
Hinted shader uniforms can have a default value
2018-03-15 15:23:40 +01:00
5356423377
A few fixes on the ARVR Server
2018-03-15 23:31:02 +11:00
b1ae5ea407
Merge pull request #17040 from AndreaCatania/patch-2
...
Deprecated Godot 3D physics engine
2018-03-13 13:46:08 +01:00
27a3447790
Merge pull request #17402 from Chaosus/fixmix
...
Fix invalid mix function overload
2018-03-13 08:43:07 +01:00
e9ac87390c
Fixed several leaks in VisualServerScene, RasterizerSceneGLES3 and RasterizerGLES3
2018-03-13 00:22:08 -04:00
2d428a350e
Fix few bugs in shader definitions
2018-03-10 21:00:18 +03:00
97bef8d908
Fix invalid mix function overload
2018-03-10 12:56:43 +03:00
47addcf9d0
Merge pull request #17354 from SaracenOne/shader_token_name_fix
...
Make the shader token names consistent.
2018-03-09 10:39:22 +01:00
b095e21d91
Make the shader token names consistent.
2018-03-07 23:56:47 +00:00
9d7856620c
Bring back Vector2.cross()
2018-03-07 21:10:31 +01:00
4d6bb43931
Remove disabled shapes from physics
...
Disabling a shape removes it from physics calculations. Enabling a shape adds it back to the physics calculations.
2018-03-07 18:03:44 +01:00
fc166f3ee1
Implement VisualServerScene::instance_set_extra_visibility_margin() method to actually apply extra culling margin and mark instance AABB dirty
2018-03-04 14:20:59 +01:00
c6b6af7bb5
Fix floatBitsToUint function
2018-03-03 16:22:36 +03:00
134cca0cf2
Fixed physics server typo
2018-02-27 08:42:09 +01:00
5de5a4140b
Deprecated Godot 3D physics engine
2018-02-26 12:51:30 +01:00
eb63f7b071
[DOCS] Sync classref with current source
2018-02-25 15:14:25 +07:00
56dcf4b983
AudioServer emit bus_layout_changed signal when adding, moving or deleting a bus
2018-02-23 23:42:57 +01:00
7cd867c3fe
2D Skeletons WORK IN PROGRESS
2018-02-21 17:24:00 -03:00
612ab4bbc6
Fix typos with codespell
...
Found via `codespell -q 3 --skip="./thirdparty,./editor/translations" -I ../godot-word-whitelist.txt`
Whitelist consists of:
```
ang
doubleclick
lod
nd
que
te
unselect
```
2018-02-21 19:46:06 +01:00
9e3a1e5401
Add base support for 2D meshes in Godot, including Sprite -> Mesh2D conversion.
2018-02-21 09:39:09 -03:00
497a4e9e25
Merge pull request #16757 from AndreaCatania/kinpush
...
Improved kinematic body, Now can move rigid body
2018-02-20 15:41:10 +01:00
6ed392f47a
Improved kinematic body 2D and 3D, Now can move rigid body
2018-02-20 12:43:47 +01:00
4c56edfb83
Revert "Handle single-argument constructors in uniform default values"
2018-02-20 07:28:22 -03:00
05a8675f82
Merge pull request #15985 from Nallebeorn/uniforms-single-argument-constructors
...
Handle single-argument constructors in uniform default values
2018-02-20 11:26:26 +01:00
b2aeb02e7d
Merge pull request #16530 from AndreaCatania/rays
...
Improved ray shape (2D and 3D) by addiing the possibility to act as r…
2018-02-19 22:15:49 +01:00
ffc3ef8677
Improved ray shape (2D and 3D) by addiing the possibility to act as regular shape
2018-02-19 20:59:57 +01:00
be67f2e4ba
Merge pull request #16751 from AndreaCatania/moreAPIs
...
Added Physics state APIs
2018-02-19 20:22:18 +01:00
9130770ec5
Merge pull request #16794 from Chaosus/new_shader_funcs
...
Adds some missing shader built-in functions
2018-02-19 18:30:16 +01:00
d9f26af533
Merge pull request #16803 from lethiandev/fix-remove-shape2d
...
Fix 2d collision body update on shape remove
2018-02-19 18:22:21 +01:00
fd92e571ac
Readd VS.sync and VS.draw to keep compatibility
...
Those are deprecated as VS.force_sync and VS.force_draw do the same and more explicitly,
but we cannot remove them without marking them as deprecated before that.
Fixes issue introduced in #15892 .
2018-02-19 10:43:07 +01:00
3659df6624
Fix 2d collision body update on shape remove
2018-02-18 20:46:37 +00:00
8f04a13c98
Added missing shader functions
2018-02-18 18:08:18 +03:00
d35e486228
Clean up some bad words from code comments
2018-02-17 16:00:39 +03:00
a930797c31
Added Physics state APIs
2018-02-16 17:48:07 +01:00
574133e4e0
Merge pull request #15892 from Zylann/add_missing_vs_bindings
...
Added all missing VisualServer bindings
2018-02-14 16:05:49 +01:00
dea5a69693
Merge pull request #16408 from Calinou/remove-debugging-prints
...
Remove a few debugging prints
2018-02-14 11:32:10 +01:00
a42765dada
Added physics API in order to enable/disable collisions between rigidbody attached to a joint with bullet physics bullet
...
Fixes #16424
2018-02-05 18:54:07 +01:00
84267915f5
Remove a few debugging prints
2018-02-05 11:30:50 +01:00
08d4bfacaf
Fix inconsistencies and typos in argument names
2018-02-01 16:47:20 +01:00
ff287d8341
Merge pull request #15254 from mrcdk/pitch_scale
...
Added pitch scale property to AudioStreamPlayer, AudioStreamPlayer2D and AudioStreamPlayer3D
2018-02-01 14:26:27 +01:00
5a26e0786c
AudioEffectReverb: max predelay_feedback to 0.98
2018-01-31 00:19:07 +07:00
ed6bf28014
Merge pull request #15980 from mrcdk/audio_stream_get_length
...
Expose audio streams get_length()
2018-01-30 13:43:34 +01:00
8dc62bbc96
Fix VisualServer.free conflicting with Object.free
2018-01-25 00:23:31 +01:00
311e69aa1e
Handle single-argument constructors in shaders.
...
Expand these (fill vectors, fill matrix diagonals) in _reduce_expression() so they're handled properly even as uniform default values (where they previously caused a crash).
2018-01-22 22:32:35 +01:00
8a9f1c2a5d
Expose audio streams get_length()
2018-01-22 20:35:33 +01:00
e415fd05bb
Added all missing VisualServer bindings
...
- Added bindings for multimesh, immediate, skeleton, light, reflection probe, gi probe, lightmap, particles, camera, environment, scenario, instance
- Removed draw and sync, were duplicates of force_* equivalents
- Bumped binders max arguments from 11 to 13
- Wrote some wrappers as not all methods were variant-friendly
2018-01-20 16:59:26 +01:00
e2b50e1abb
improves portability with some compilers
2018-01-18 19:16:34 -03:00
9f479f096c
Fix typos in code and docs with codespell
...
Using v1.11.0 from https://github.com/lucasdemarchi/codespell
2018-01-18 22:01:42 +01:00
bccb4840c8
Fix wrong viewport transparent-bg
2018-01-18 19:11:07 +01:00
ac26bf0fb4
Expose PhysicsDirectBodyState.get_contact_impulse
2018-01-12 15:27:45 -06:00
5876457410
modify default param names in couple of signals
...
'name' default param should not be used since there is problem with name shadowing
2018-01-12 15:45:29 +01:00
9b8e8b2220
Bind many more properties to scripts
...
Notable potentially breaking changes:
- PROPERTY_USAGE_NOEDITOR is now PROPERTY_USAGE_STORAGE | PROPERTY_USAGE_NETWORK, without PROPERTY_USAGE_INTERNAL
- Some properties were renamed, and sometimes even shadowed by new ones
- New getter methods (some virtual) were added
2018-01-12 00:58:14 +02:00
bfeaf27a3e
Properly dispose of instance capture data, fixes #14795
2018-01-06 19:06:04 -03:00
e4213e66b2
Add missing copyright headers and fix formatting
...
Using `misc/scripts/fix_headers.py` on all Godot files.
Some missing header guards were added, and the header inclusion order
was fixed in the Bullet module.
2018-01-05 01:22:23 +01:00
322cb08dd9
Fix macOS and other builds after #15299
...
Commit ammended by @akien-mga to fix more platforms.
2018-01-04 19:48:05 +01:00
0b07d453f7
Merge pull request #15251 from binbitten/fix-assign-vardecl
...
Fix premature declaration of shader variables created with assignment
2018-01-04 15:17:10 +01:00
f066991aa7
found via cppcheck:
...
remove code that will never run
make definition and declaration names for parameters match
change floats that were being set to bool values
remove pointer that is never used
2018-01-03 21:23:48 -07:00
f9f6f250e6
Merge pull request #15191 from Jerome67000/z_renaming
...
renames "z" Node2D property to "z_index"
2018-01-04 00:41:45 +01:00
e3c9a7ed4f
Fix broken Info.plist after copyright update
...
Fixes #15293 .
+ related misc fixes by @akien-mga.
2018-01-03 17:10:07 +01:00
42ae3525a3
#15078 renamed "z" -> "z_index" property in Node2D
2018-01-03 13:02:26 +01:00
f141bafba3
Fix premature declaration of shader variables created with assignment
2018-01-03 07:23:04 +01:00
5bc010e8ee
Added pitch scale property to AudioStreamPlayer, AudioStreamPlayer2D and AudioStreamPlayer3D
2018-01-01 22:23:16 +01:00
b50a9114b1
Update copyright statements to 2018
...
Happy new year to the wonderful Godot community!
2018-01-01 14:40:47 +01:00
52deb679df
Merge pull request #15153 from poke1024/fix12112
...
Delete AudioServer buses after driver shutdown
2018-01-01 18:49:03 +07:00
9b2283382e
Fixed wrong highlighted line when erroring and using single-line comments, fixes #15167
2017-12-29 19:32:21 +01:00
d5ed266078
Delete AudioServer buses after driver shutdown
2017-12-29 11:22:56 +01:00
5c636875e4
Merge pull request #14971 from mrcdk/particles_emitting
...
Set particles emitting to false when particles finish emitting with one-shot enabled
2017-12-27 10:45:36 +07:00
ab444a8ca9
Merge pull request #14996 from neikeq/enums-mono
...
Mono: Make the bindings generator output enums
2017-12-27 10:29:00 +07:00
2b31155baa
Fix sidedness check in material. Also remove SIDE built-in.
2017-12-26 11:09:52 -03:00
0a0a44da8d
Mono: Make the bindings generator output enums
...
- Switch to PascalCase for constants names
2017-12-24 04:20:41 +01:00
1f609b7a82
Set particles emitting to false when particles finish emitting with one-shot enabled
2017-12-23 05:23:41 +01:00
7d9b7f9c47
Merge pull request #14897 from BastiaanOlij/arvr_tweaks
...
Few small tweaks for ARVR
2017-12-23 00:59:09 +01:00
6fd51b6a1b
Reserved controller ids 1 and 2 for left and right hand controllers and added new center on hmd option
2017-12-22 01:21:23 +11:00
045f81023b
Properly silence buffer while not in use, fixes #14866
2017-12-20 13:55:58 -03:00
139daf0e03
Don't try to mix a sample that has already ended
...
On short samples the sample may finish playing before the mixer is done.
This fills the remaining time with zeros and ends mixing. This fixes the
users getting the following error logged:
::_mix_internal: Condition ' !active ' is true.
2017-12-18 00:53:51 +01:00
8f25a2dc11
Cleanup some #if 0'd code
2017-12-17 15:40:24 +01:00
8e2a1ffd6e
Shader Language: Add in-for declared variables within for-block scope.
2017-12-17 01:43:59 +01:00
652c98a7be
Add epic hack so vsync can be toggled in run-time from script. Fixes #14458 .
...
Call needs to be routed via visual server to reach the proper thread.
2017-12-16 17:11:02 -03:00
d03f35f1bc
Bind TextEdit.deselect and update documentation
2017-12-16 21:08:31 +01:00
e946fb8cb0
Made built-in identifiers properly constant in shaders. Fixes #14449 , closes #14629
2017-12-15 18:24:30 -03:00
f3ad14224e
-Add lightmapper
...
-Fixes to unwrapper (remove degenerates), makes Thekla not crash
-Added optional cancel button in EditorProgress
-Added function to force processing of events (needed for cancel button)
2017-12-14 09:01:27 -03:00
5dee44bbc1
Implemented physics linear and angular lock
2017-12-10 17:21:14 +01:00
c3c1d119ec
Fix #14429 GIProbe does not work with SpotLights
2017-12-09 20:57:28 +01:00
65fb961b8b
-Ability to and unwrap lightmap coordinates on import
...
-Added unwrap functionality to Mesh
-Ability to display and debug mesh UVs
-Added multiline draw, so it's easier and faster to draw UVs
-Many fixes to SurfaceTool
-Fixes to Thekla Unwrap, but it's a piece of ass and it keeps crashing. Will have to go away
2017-12-09 14:18:14 -03:00
ccef401700
Merge pull request #13341 from scayze/interp_v2
...
Added interpolation qualifiers to shaderlang
2017-12-09 18:12:14 +01:00
25b36f18d3
Merge pull request #12756 from Stratos695/master
...
Allowing double-axis lock in RigidBody & KinematicBody (Fixes #12500 )
2017-12-09 13:01:41 +01:00
13c2ff9320
Style: Apply new clang-format 5.0 style to all files
2017-12-07 08:02:00 +01:00
0bc573635c
Fixes to some thread safety situations to avoid GIProbe from freezing on save. Fixes #13338
2017-12-06 18:06:34 -03:00
431dfc1458
Attempt to see if this can solve the problem with #13338
2017-12-06 16:41:19 -03:00
d438ac0aed
-Implemented Proxy Textures (needed to solve the problem with ViewportTexture)
...
-Properly use hierarchy to initialize resources local to scene (solves problem of GUI in 3D)
2017-12-04 15:56:17 -03:00
a65c0939fd
disable caching for targets using helper functions
2017-11-28 23:24:12 -04:00
a4a222d62d
use the same cache for all branches for appveyor
2017-11-28 03:23:33 -04:00
cb4c0c630f
doc: Sync classref with current source
2017-11-27 23:37:47 +01:00
b0fb6b1380
Added interpolation modifiers to shaderlang
2017-11-27 16:47:46 +01:00
8dc89e787c
Merge pull request #13294 from RaXaR/master
...
Added overloads of vector parameters for shader Trig functions.
2017-11-27 00:58:14 +01:00
b932d8c37a
Added overloads of vector parameters for shader Trig functions.
...
Ammend: Removed whitespace from blank lines.
Ammend2: Removed extra spaces in an attempt to make Clang happy. :)
2017-11-27 01:18:45 +02:00
ce89b20b20
Merge pull request #13228 from rminderhoud/weights
...
Fix read bug in compressed bone weights
2017-11-26 21:04:48 +01:00
22415e5a31
Merge pull request #12572 from RandomShaper/onion-skinning
...
Onion skinning
2017-11-26 15:13:35 -03:00
b0e556d1a7
Merge pull request #13289 from sketchyfun/3d_selection_fix
...
Fixed issue with 3D selections
2017-11-26 14:55:56 +01:00
541df26184
Tweak the default camera node settings
...
- Increase FOV to 70
- Put the Z-near plane at 0.05 meters
2017-11-25 23:48:30 +01:00
dd5037ba82
Fixed issue with 3D selections losing precsion due to an offset bug
2017-11-25 20:14:54 +00:00
bc2e8d99e5
Made Vector::ptrw explicit for writing, compiler was sometimes using the wrong function,
...
leading to unnecesary copy on writes and reduced performance.
2017-11-25 00:09:40 -03:00
81c49fb536
Update clang-format in modified files
2017-11-25 02:18:28 +01:00
3aa79fc1a3
Add ability to opt-out buffer swapping in `VS::draw()`
2017-11-25 02:18:28 +01:00
2399d11e27
Fix read bug in compressed bone weights
2017-11-23 21:52:14 -06:00
0ca9181ee8
Rename two-parameter arc-tangent function to atan in shader language, as it is in GLSL.
...
Fixes #13214 .
2017-11-23 21:19:11 -05:00
2ea5ac17e8
Merge pull request #13159 from AndreaCatania/ray
...
Removed type_mask and fixed some variable name
2017-11-22 16:40:20 +01:00
d6e413bb9c
Removed type_mask and fixed some variable name
2017-11-21 22:56:40 +01:00
640856f4d4
Merge pull request #11895 from m4nu3lf/rendering/separate_thread
...
Restore rendering on a separate thread
2017-11-21 14:31:14 -03:00
17b9accd0c
Implement per-instance custom bounding box
...
# Conflicts:
# servers/visual/visual_server_scene.h
2017-11-20 20:54:26 +01:00
98cb49283d
Ability to change indirect light energy.
2017-11-19 21:46:00 -03:00
f9a38d2309
CommandQueueMT doesn't lock during command execution
2017-11-18 18:37:44 +00:00
871c47a2bb
Restore rendering on a separate thread
2017-11-18 18:35:25 +00:00
d28763a4c1
Rename Rect3 to AABB.
...
Fixes #12973 .
2017-11-17 11:01:41 -05:00
6277e6d40a
Ability to update parts of an array, and set arrays as dynamic draw
2017-11-14 17:26:35 -03:00
61a693cf78
Merge pull request #12922 from eska014/engine-singletons
...
Singleton management changes
2017-11-14 20:44:55 +01:00
9b7b46143d
Move singleton management from ProjectSettings to Engine
2017-11-14 15:15:13 +01:00
03a080547d
Merge pull request #12014 from hi-ogawa/fix-video-playback
...
Fix video playback
2017-11-13 19:57:18 +01:00
9d3f8418ca
Removed add/remove interface bindings and added get_interfaces
2017-11-13 22:08:43 +11:00
2fce0010f0
classref: Sync with current source
...
[ci skip]
2017-11-13 09:25:53 +01:00
bd5df84199
Allow double-axis lock in RigidBody and KinematicBody
2017-11-10 22:33:54 +01:00
19b1ff0fc5
Disabled filter clip by default and made it optional, fixes #12368 , likely others too
2017-11-10 09:22:25 -03:00
4deac219b0
Remove node from list before calling queries, fixes #10886
2017-11-10 08:32:02 -03:00
192a4d7de5
Reworked how servers preallocate RIDs, should fix #10970
2017-11-09 23:35:34 -03:00
50a9bd4e23
Merge pull request #12713 from AndreaCatania/master
...
Rewritten kinematic system
2017-11-09 16:08:58 -03:00
b37e277303
Fixing bad index used in Space2DSW
...
Fix wrong col_obj access using wrong index variable.
Related with issue #11695
2017-11-08 20:38:49 -02:00
0095d642c7
Merge pull request #11379 from m4nu3lf/feature/no_bias_overrotation
...
Avoid bias over rotation in contact resolution
2017-11-08 08:19:28 +01:00
10f879bf88
Rewritten kinematic system
2017-11-07 15:22:09 +01:00
fb4871c919
Bullet physics engine implementation
...
This is a bullet wrapper that allows Godot to use Bullet physics and benefit about all features.
Also it support all specific Godot physics functionality like multi shape body, areas, RayShape, etc..
It improve the Joints, Trimesh shape, and add support to soft body even if Godot is not yet ready to it.
2017-11-04 20:52:59 +01:00
7715a261d5
Merge pull request #12262 from AndreaCatania/pplug
...
Physics server plug
2017-11-03 23:39:44 -03:00
7a9ca08f16
Implemented physics plug
...
Moved init_physics
Implemented physics 2D plug
Fix clang
Fix clang
Fix static check
Fix clang
Fix static check
Moved physics server initialization
Moved physics server settings initialization
2017-11-04 03:25:51 +01:00
167b7b5533
Adding rumble support to ARVR controllers (if implemented on the ARVR interface)
2017-11-01 23:59:14 +11:00
31c92c5327
Merge pull request #12537 from marcelofg55/wasapi_improvements
...
Improved WASAPI driver logic when devices are connected or disconnected
2017-10-31 23:33:41 +01:00
cb3f594b14
Merge pull request #11249 from m4nu3lf/bugfix/get_euler
...
Fix inertia tensor update & Generic6DOFJoint & Simplify Basis::get_euler()
2017-10-31 23:03:01 +01:00
24b3733f3b
Merge pull request #10770 from RandomShaper/fix-joints
...
Fix joints collision exceptions, plus a bit more
2017-10-31 23:02:37 +01:00
16327bff8a
Improved WASAPI driver logic when devices are connected or disconnected
2017-10-31 13:07:35 -03:00
fd07a283e5
Merge pull request #12523 from RandomShaper/fix-margins-drawn-too-late
...
Fix viewport margins drawn after swapping buffers
2017-10-30 19:47:02 -03:00
793da07a4d
Fix viewport margins drawn after swapping buffers
2017-10-30 21:20:12 +01:00
83f5d7e40a
Refactor bufer to buffer
2017-10-28 19:15:51 +07:00
abea816e54
Revert "Rename Schlick GGX to GGX."
2017-10-23 07:42:36 +02:00
b4f0f59d9f
Many fixes to SSAO, should be good now.
2017-10-22 13:52:48 -03:00
1054c6edee
Merge pull request #12296 from tagcup/ggx_rename
...
Rename Schlick GGX to GGX.
2017-10-22 10:30:11 +02:00
2449d21671
AudioEffectFilter: lowercase dB property to db
2017-10-22 11:36:43 +07:00
cb0bf1edea
Rename Schlick GGX to GGX.
...
Schlick's approximation and GGX are orthogonal concepts.
Furthermore, it's usage so far has been inconsistent: we don't even use it with anisotropic SchlickGGX, and Burley (Disney) diffuse does use it while its name doesn't indicate it.
The use of Schlick's approximation in Burley and GGX is an implementation detail and doesn't need to be reflected to the namig.
2017-10-21 19:35:54 -04:00
01a5a8b86c
Merge pull request #12291 from RandomShaper/fix-raycast-naming
...
Rename RayCasts collision_layer to collision_mask
2017-10-21 23:44:46 +02:00
c9894669a9
Merge pull request #12290 from Noshyaar/enum
...
Bind unbound enums, rearrange some by value
[ci skip]
2017-10-21 23:08:36 +02:00
7b12ae39f2
Rename RayCasts collision_layer to collision_mask
...
The point is that `RayCast`s are checked against objects' `collision_layer`(s), but they themselves are considered no to _belong_ to any layer. Therefore, the correct name for their property is `collision_mask`, rather than `collision_layer`.
Only renaming is needed since the behavior was already the right one, only that it wasn't matching what users would expect from the name and description of the property.
Fixes #7589 , where it's also discussed.
2017-10-21 22:17:47 +02:00
9cadb9e5f3
Bind unbound enums, rearrange some by value
2017-10-22 01:58:02 +07:00
6361e24f29
Cleanup unnecessary debug prints
2017-10-21 20:41:07 +02:00
d67e77e837
Fixed viewport transparent bg when clear mode is enabled.
2017-10-21 02:06:10 -05:00
cf3919b228
Bind some VisualServer functions
2017-10-20 00:24:49 +02:00
7764640f22
Fix crash in shader parsing
...
...that would happen if incorrect syntax was found just after an opening square bracket.
Fixes #12046 .
2017-10-16 21:55:42 +02:00
3266ebbf4f
Merge pull request #12088 from Grosskopf/physics-server-docs
...
Added documentation for 3D Joints, the 2D Pin Joint, and the Physicsservers, also minor Bugfix
2017-10-15 10:12:53 +02:00
f8c7d32987
Added documentation for 3D Joints, the 2D Pin Joint, and the Physicsservers, also a minor bugfix in the 3D Pinjoint.
2017-10-14 22:17:26 +02:00
d030e6ee75
Expose 'request_frame_drawn_callback' to script.
2017-10-14 16:32:27 +01:00
3edd3cd377
Fix video playback
...
This adds support to
- VideoPlayer
- VideoStreamWebm
- VideoStreamTheora
2017-10-14 23:20:39 +09:00
cc37d43f86
Redoing the ARVR GDNative interface as module and tighter implementation
2017-10-14 09:10:18 +11:00
36ca9c9251
Merge pull request #12027 from marcelofg55/collision_crashfix
...
Prevent a possible crash at collision_object_2d_sw.h
2017-10-13 13:58:05 +02:00
79922be693
Prevent a possible crash at collision_object_2d_sw.h
2017-10-12 14:25:40 -03:00
064f2f4763
Merge pull request #12038 from Hinsbart/argument_names
...
Fix argument names in method bindings.
[ci skip]
2017-10-11 23:01:17 +02:00
d7b9847864
Fix argument names in method bindings.
...
Adds a couple of missing argument names.
2017-10-11 20:00:25 +02:00
819d9339c3
Bind VisualServer.sync() method to GDScript
...
This function is needed in Escoria's resource queue (https://github.com/godotengine/escoria/blob/master/device/globals/resource_queue.gd#L94 )
2017-10-11 17:45:19 +02:00
740ef3dc97
Merge pull request #11954 from neikeq/d
...
Added 'exposed' field to ClassInfo for registered classes
2017-10-11 13:54:34 +02:00
0c2e882210
Adds 'exposed' field to ClassInfo
...
This field represents if the class is exposed to the scripting API.
The value is 'true' if the class was registered manually ('ClassDB::register_*class()'), otherwise it's false (registered on '_post_initialize').
- Added missing registration of classes that are meant to be exposed.
2017-10-09 23:49:17 +02:00
8e9b99fe59
Merge pull request #11702 from AndreaCatania/bodyDS
...
Added new API to get body direct state
2017-10-09 11:01:36 +02:00
ce74efacbb
Made a few tweaks to the interface
2017-10-06 20:35:55 +11:00
4501a30ce9
Fix GIProbe light visibility
...
- Fix https://github.com/godotengine/godot/issues/10535
2017-10-04 19:13:07 +09:00
5303efb2fa
Merge pull request #11659 from AndreaCatania/prephysics
...
Renamed fixed_process to physics_process
2017-10-02 23:10:36 +02:00
4537977d6d
Renamed fixed_process to physics_process
2017-09-30 16:19:07 +02:00
d4e20555e8
Ability to set a custom FOV makes it possible to use sky on orthogonal view. Closes #9186
2017-09-29 18:56:52 -03:00
c56c67db39
Added new API to get body direct state
2017-09-29 17:33:30 +02:00
392a94686c
Fixed typo: 'texure' to 'texture'
2017-09-29 04:40:01 +07:00
4f39ce32b9
Fixes to light shaders, should work now..
2017-09-27 21:45:47 -03:00
ffca222d17
Fixed Voice_Count issues in AudioEffectChorus:
...
- Setting voice_count value to 4 (MAX_VOICES) is now allowed
- Fixed slider glitch on setting voice_count value
2017-09-25 20:46:52 +07:00
09800ac650
AudioEffectLimiter: fix wrong soft_clip_ratio getter
2017-09-25 19:41:32 +07:00
1ed5e75dd7
Removed print_line in Physics2DServerWrapMT::init()
2017-09-25 15:05:32 +07:00
d0c42da961
Discarding now works in shaders
...
"discard" has been added to the list of recognised keywords.
A flag specifing when discarding is allowed is now set correctly.
2017-09-24 01:37:53 -06:00
81c9cfdc1b
Added light affect parameter to baked AO
2017-09-23 23:10:34 -03:00
d3ea92257d
-Fixed redraw always on 3D viewprot bug
...
-Changed manipulation inertia default values. Do not touch them again or I'll cut your fingers and eat them.
2017-09-23 17:28:28 -03:00
46af050e93
Rename get_position => get_playback_position and seek_pos => seek on audio classes
2017-09-23 16:55:00 +02:00
0cb8d3ccbf
Fix wrong index in get_euler_xyz and wrong get_euler in G6DF Joint
2017-09-22 20:06:23 +01:00
d4452e3a65
Fix Inertia tensor update & Generic 6DOF Joint
2017-09-22 20:05:02 +01:00
a6c3147c0a
Add inversesqrt to shader language.
2017-09-21 21:02:08 -04:00
bf371dcb32
Added proximity and distance fade to SpatialMaterial
2017-09-21 15:20:28 -03:00
5ad9be4c24
Rename pos to position in user facing methods and variables
...
Rename user facing methods and variables as well as the corresponding
C++ methods according to the folloming changes:
* pos -> position
* rot -> rotation
* loc -> location
C++ variables are left as is.
2017-09-20 13:11:10 +02:00
650d5630af
Avoid bias overrotation in contact resolution
2017-09-18 18:31:58 +01:00
53bbc046ee
Merge pull request #11252 from marcelofg55/fix_noaudio_crash
...
Fix crash when no audio driver is available
2017-09-17 22:48:22 +02:00
d22ceeef1b
correction to one way collision code
2017-09-17 10:18:09 -03:00
5886f810c2
fixes to one way collision, closes #10971
2017-09-17 09:39:03 -03:00
c74bab66aa
Merge pull request #11274 from Rubonnek/keep-argument-names-consistent
...
Renamed function arguments to keep them consistent between declaration and implementation
2017-09-17 12:53:48 +02:00
7dffed485b
Merge pull request #11230 from maxim-sheronov/fix_enum_bindings
...
Fix enums bindings
2017-09-15 08:43:35 +02:00
072e379ffe
Renamed function arguments to keep them consistent between declaration and implementation
2017-09-14 13:49:15 -04:00
7a4c0ff35e
Fix crash when no audio driver is available
2017-09-13 20:54:55 -03:00
0fffa45158
Fix enums bindings
...
Add missed bindings for enums
Move some enums to class to have correct output of api.json
2017-09-13 20:57:07 +03:00
6ec9383706
Merge pull request #11125 from zavb074/master
...
Removed code that flips normal if facing away from test direction
2017-09-13 19:33:01 +02:00
e73e00d369
Style: Apply clang-format to @reduz's changes
...
[ci skip]
2017-09-13 09:13:34 +02:00
730d36f350
Fixed issues with surround sound on audio server
2017-09-12 15:13:28 -03:00
aabbd00284
Merge pull request #10908 from hpvb/fix-unused-variables
...
Fix unused variable warnings
2017-09-12 12:55:53 +02:00
2b50dc5d4f
Merge pull request #11057 from hpvb/fix-various-warnings
...
Fix various assorted warnings
2017-09-12 11:39:47 +02:00
3941e01a57
Merge pull request #11041 from hpvb/fix-clang-format-error
...
Fix serveral recent new clang-format errors
[ci skip]
2017-09-12 11:16:36 +02:00
88fd69c9bb
Merge pull request #11142 from BastiaanOlij/arvr_signal_id
...
Added ID to tracker signals and property for storing hand
2017-09-12 05:10:35 +07:00
92bbd2d713
Script access to formatted arrays and blend_arrays in meshes.
2017-09-11 06:53:34 +01:00
de309c426d
Added ID to tracker signals and property for storing hand
2017-09-10 16:25:12 +10:00
fbeb27b01d
Remove joint freeing logic from physics servers
...
Since joint resources are created by joint nodes and also they take care of freeing them, the physics server doesn't need to free bodies' joints explicitly.
The logic for clearing the constraints map/set is still relevant as there may be collision pairs and in their case its the server itself the one creating them and therefore releasing them.
2017-09-09 21:45:22 +02:00
b11e145ddc
Removed code that flips normal if facing away from test direction
2017-09-09 20:08:35 +01:00
b2a38854fd
Fix unused variable warnings
...
The forth in my quest to make Godot 3.x compile with -Werror on GCC7
2017-09-08 15:03:53 +02:00
67a706fc1b
Fix various assorted warnings
...
Fix various warnings that don't have enough instances to merit
individual commits. Also fixes a potential bug in audio_server.cpp.
2017-09-08 14:57:48 +02:00
5ca3af3371
Ability to use a sky for reflection together with a background color.
2017-09-07 20:45:37 -03:00
5e18967d77
Fix serveral recent new clang-format errors
2017-09-08 00:20:16 +02:00
eedb39091a
Several fixes to directional shadows, closes #10926
...
Added option to change directional light range mode, between optimized and stable. For Orthogonal, you might need to use optimized.
2017-09-07 18:00:47 -03:00
7eb8760477
Added support for for, break and continue. Closes #10560 , closes #10661
2017-09-05 15:25:34 -03:00
adde89e8b1
-Added an optimization so physics shapes are configured later, speeds up grid map loading and editing
2017-09-03 14:54:15 -03:00
281fb4e4fb
Added transmission shader parameter.
2017-09-03 10:30:37 -03:00
459f526119
Fix typos 'a' and 'an'
2017-09-02 21:19:06 +07:00
8e75e7311b
Merge pull request #10858 from letheed/add-shadow_filter-variant
...
add shadow_filter variant PCF7
2017-09-02 12:13:01 +02:00
9c63ab99f0
Fix use of unitialized variables
...
The second in my quest to make Godot 3.x compile with -Werror on GCC7
2017-09-02 01:59:26 +02:00
dac150108a
Merge pull request #10846 from hpvb/fix-sign-compare
...
Fix signed and unsigned comparisons
2017-09-01 21:52:55 +02:00
3694c58d3c
Merge pull request #10775 from marcelofg55/buffersize_fixes
...
Corrections to audio buffer size calculations
2017-09-01 21:41:24 +02:00
5a69a663c7
Merge pull request #10864 from Noshyaar/pr-beginning
...
Fix typo 'begining' to 'beginning'
[ci skip]
2017-09-01 21:29:40 +02:00
8f30c52a37
Removed ontop property, added a material rendering priority system. Fixes #9935 , closes #10135
2017-09-01 13:01:08 -03:00
69ccae3d99
Fix typo 'begining' to 'beginning'
2017-09-01 22:54:57 +07:00
f231eadc9e
Corrections to audio buffer size calculations
2017-09-01 11:12:13 -03:00
3a188015be
add shadow_filter variant PCF7
2017-09-01 15:01:24 +02:00
f9467ec1ea
Fix signed and unsigned comparisons
...
The first in my quest to make Godot 3.x compile with -Werror on GCC7
2017-09-01 08:13:12 +02:00
77ec304966
Fix special case where KinematicBody fails one way collisions by adding exclusion lists, closes #9729
2017-08-31 22:55:01 -03:00
e5aec72bae
Fix typo 'inetria' to 'inertia'
2017-09-01 01:32:29 +07:00
6dd6e05662
Revert "Fix shader function calls being assignable"
2017-08-31 14:19:27 +02:00
3b0b0a1d99
Merge pull request #7269 from Tugsav/simulator_renderer
...
Non-realtime simulation
2017-08-31 11:52:06 +02:00
417113edf3
Renderer/Simulator flags
...
Now hopefully with correct code style
2017-08-30 14:22:43 +02:00
Marcelo Fernandez
Juan Linietsky
Overblob
Max Hilbrunner
Josh Taylor
Rémi Verschelde
muiroc
George Marques
Bastiaan Olij
JFonS
Gustav Lund
Oliver Rausch
MrCdK
nemerle
bruvzg
AndreaCatania
Marc Gilleron
Hugo Locurcio
Michael
Crazy-P
Poommetee Ketson
Pieter-Jan Briers
Chaosus
Benedikt Bär
robfram
Ivan Vodopiviz
Geoffrey
Hein-Pieter van Braam
Wilson E. Alvarez
Saracen
Bernhard Liebl
ShyRed
Markus Ewald
Juan Linietsky
luz.paz
Konrad Nowakowski
Artem Varaksa
Paolo Perkovic
Benjamin
Ariel Manzur
binbitten
Lee Pugh
Unknown
Bojidar Marinov
Duy-Nguyen TA
firefly2442
Razah
Jerome67000
Ignacio Etcheverry
Enzo Nocera
Przemyslaw Czarnota
Rhody Lugo
Scayze
RaXaR
BenH
Pedro J. Estébanez
Ralph Minderhoud
Ferenc Arn
m4nu3lf
Leon Krause
Eric Rybicki
MateusMP
Daniel J. Ramirez
Grosskopf
Matt Hughes
Andreas Haas
Julian Murgia
Ignacio Etcheverry
Hiroshi Ogawa
Andreas Haas
Indah Sylvia
Daniel Doran
letheed
Thomas Herzog
Maxim Sheronov
Lewis
letheed