defaac6058
Merge pull request #67791 from Sauermann/fix-visual-mouse-notifications
...
Refactor mouse_entered and mouse_exited signals
2023-08-01 20:03:33 +02:00
fd1ee5d56b
Merge pull request #79332 from AThousandShips/mp_crash
...
Prevent crash when accessing `Node` Multiplayer from thread
2023-08-01 17:25:07 +02:00
1c3c17c608
Refactor mouse_entered and mouse_exited notifications
...
The previous implementation for signals mouse_entered and mouse_exited
had shortcomings that relate to focused windows and pressed mouse buttons.
For example a Control can be hovered by mouse, even if it is occluded by
an embedded window.
This patch changes the behavior, so that Control and Viewport send
their mouse-enter/exit-notifications based solely on mouse position,
visible area, and input restrictions and not on which window has
focus or which mouse buttons are pressed. This implicitly also
changes when the mouse_entered and mouse_exited signals are sent.
This functionality can not be implemented as a part of
Viewport::_gui_input_event, because of its interplay with Windows and
because Viewport::_gui_input_event is based on input and not on
visibility.
2023-08-01 13:28:49 +02:00
7fead979d6
Disable error condition for accessing safe rect
...
This PR removes the error-message, which is currently expected to happen.
The task of correctly fixing the underlying problem of window popup
closing is more complex, so this PR solves the immediate
error-notification-problem.
2023-07-26 20:21:30 +02:00
d50c52652f
Merge pull request #79805 from kumikumi/fix-subviewport-cursor
...
Prevent SubViewportContainer overriding Subviewport's cursor with its own cursor
2023-07-26 18:40:30 +02:00
712f49ec57
Merge pull request #79766 from Sauermann/fix-window-determinant-zero
...
Add determinant check for minimized windows
2023-07-26 18:40:26 +02:00
1de9171c32
Merge pull request #79443 from Sauermann/fix-ingore-hovering
...
Fix physics passive hovering with `MOUSE_FILTER_IGNORE`
2023-07-26 18:40:14 +02:00
67873d0d5d
Merge pull request #79248 from Sauermann/fix-svc-focus-propagation
...
Make `SubViewportContainer` event propagation aware of focused Control
2023-07-26 18:39:57 +02:00
e8df8c5e2c
Merge pull request #78988 from RandomShaper/fix_change_scene
...
Reimplement scene change
2023-07-26 18:39:43 +02:00
96b26574b9
Don't override SubViewport's cursor with SubViewportContainer's cursor
...
Add a warning for having a non-default value of `mouse_default_cursor_shape` in SubViewportContainer
Add test
2023-07-23 22:27:55 +03:00
e0bce0bd7f
Add determinant check for minimized windows
...
When the Window is minimized, the transform-determinant can be 0.
Add a check to prevent this case.
2023-07-22 00:02:37 +02:00
15c0e40375
Merge pull request #79546 from Sauermann/fix-input-handled-physics
...
Separate input-handled-state for different events during physics-picking
2023-07-21 17:15:36 +02:00
de0f7935dd
Merge pull request #79524 from aaronfranke/gds-test-inst-placeholder
...
Change GDScript tests to use InstancePlaceholder as the example abstract class
2023-07-21 17:15:32 +02:00
4d42d6fdf6
Merge pull request #78706 from RedworkDE/node-rename-inplace
...
Allow renaming child nodes in `_ready`
2023-07-21 17:15:26 +02:00
b408b05d7d
Fix physics passive hovering for some cases
...
When the parent `SubViewportContainer` ignores mouse with
`MOUSE_FILTER_IGNORE` and also when the mouse is over a `Control`-node,
then the `SubViewport` shouldn't create mouse-move-events for passive
hovering.
2023-07-19 19:25:04 +02:00
e6386bc843
Make `SubViewportContainer` event propagation aware of focused Control
...
Propagate `InputEvents` without position either
- during the Input-stage, when it has focus or
- during the Unhandled-Input-stage, otherwise
This makes sure that Gui-Input happens in the correct order.
Move "Unhandled key Input" handling before "Unhandled Input" handling,
so that Unicode input with Alt / Ctrl modifiers are sent to the nodes
in the correct order.
Change the default focus mode of `SubViewportContainer` from
`FOCUS_NONE` to `FOCUS_CLICK`, to automatically remove focus from
other `Control`-nodes, when clicking inside a `SubViewport`.
2023-07-17 22:38:35 +02:00
de4a3fa151
Unify and streamline connecting to Resource changes
2023-07-17 19:35:57 +02:00
95d294b97a
Separate input-handled-state for different events during physics-picking
...
Currently the input-handled-state for different events can interfere with
each other.
This PR makes sure, that the input_handled_state is reset before
processing and InputEvent during physics-picking.
2023-07-16 14:36:18 +02:00
6a8a9cd279
Change GDScript tests to use InstancePlaceholder as the example abstract
2023-07-15 18:28:08 -05:00
7e21eb7e00
Extract and reorganize texture resource classes
2023-07-14 20:04:21 +02:00
d8c0d63f07
Merge pull request #79393 from Sauermann/fix-window-focux-indicator
...
Add a default theme for unfocused Windows
2023-07-14 18:50:01 +02:00
576980f960
Add a default theme for unfocused Windows
...
At the moment it is impossible to distinguish between focused and
unfocused embedded Windows.
Add a new `theme_item` that is used for coloring the border of
unfocused Windows.
2023-07-12 22:35:03 +02:00
4790da7900
[macOS] Implement optional native file selection dialog support for sandboxed apps.
2023-07-12 22:36:24 +03:00
7ff2a93952
Merge pull request #72248 from RedwanFox/mainloop_init_order_fix
...
Ensure that SceneTree is initialized and finalized at correct time
2023-07-12 17:16:05 +02:00
223370cb64
Merge pull request #78383 from Sauermann/fix-physics-object-init
...
Fix Physics Picking captured Object initialization
2023-07-12 17:15:45 +02:00
5dff3c4484
Merge pull request #78538 from Sauermann/fix-code-simplifications
...
Remove unnecessary value assignments throughout the codebase
2023-07-12 15:09:26 +02:00
631d51c46c
Merge pull request #78476 from Sauermann/fix-embedded-safe-area
...
Embedded Popups store their safe_rect in their embedder
2023-07-12 15:09:20 +02:00
7bd3a3a5e5
Prevent crash when accessing `Node` Multiplayer from thread
2023-07-11 12:57:25 +02:00
6cb1162aa0
Merge pull request #79000 from AThousandShips/owner_error
...
Improve error message for `Node.set_owner`
2023-07-11 11:29:30 +02:00
988abb2161
Merge pull request #79016 from bruvzg/fix_win_initial_ne_fs
...
[Windows] Fix setting initial non-exclusive window mode.
2023-07-08 18:21:04 +02:00
0df423756e
Merge pull request #78847 from Sauermann/fix-sibling-fail
...
Fix `Node::add_sibling` parent check
2023-07-08 18:20:14 +02:00
3f6e35bdb2
Fix drag-dropping nodes to parent with internal nodes
2023-07-07 19:24:44 +02:00
7961bc6193
Merge pull request #78078 from Sauermann/fix-drop-physics-mouse-over
...
Ensure that `_drop_physics_mouseover` only happens when necessary
2023-07-07 16:02:13 +02:00
4354cd8d41
Reimplement scene change
2023-07-04 13:29:50 +02:00
db0109b237
[Windows] Fix setting initial non-exclusive window mode.
2023-07-04 13:09:26 +03:00
0183340012
Improve error message for `Node.set_owner`
2023-07-04 08:51:12 +02:00
b02dff6e1c
Fix `Node::add_sibling` parent check
...
Replace `data.blocked > 0` by `data.parent->data.blocked > 0` in order
to check if the parent is busy.
2023-06-29 20:21:37 +02:00
16508ead86
Merge pull request #78745 from RandomShaper/fix_node_pr
...
Fix node processing order
2023-06-27 23:02:02 +02:00
70ca659143
Fix node internal/non-internal processing order
...
Bonus:
Fix issues in group-processing related setters
2023-06-27 19:19:55 +02:00
fb1bcac271
Fix that `ViewportTexture` cannot be setup again after failed setup
...
`vp_pending` is a flag indicating to wait for `ViewportTexture::_setup_local_to_scene`
to be called. Once this method is called, no matter whether the setup will fail or not,
it needs to be reset to `false`.
2023-06-27 06:45:30 +08:00
fc0e37bbe0
Fix change of precedence in fixup
2023-06-26 19:20:34 +02:00
6b91f57042
Fixup compilation warning after #78713
2023-06-26 17:55:08 +02:00
a39b683b12
Ensure default node groups' call queue are processed
2023-06-26 16:56:10 +02:00
2c0caa5828
Allow renaming child nodes in `_ready`
2023-06-26 13:25:48 +02:00
31fab43b8b
Fix scene load crash related to `_ready`
...
The iterator might get invalidated during `_ready`-user-code.
Prevent this by disallowing set_name during iterator-operations.
2023-06-25 22:35:38 +02:00
afe65de110
Merge pull request #78591 from ajreckof/Fix-crash-when-removing-child-during-focus-exit-
...
Fix crash when removing child during focus exit.
2023-06-23 22:45:51 +02:00
f745299c36
Fix crash when removing child during focus exit.
2023-06-23 21:31:18 +02:00
68193bee9a
Revert "Fix that the focus-out notification got sent deferred"
...
This reverts commit 8cdab04d7fFixes #78589 .
2023-06-23 18:03:48 +02:00
60c261ba2d
Re-add `mouse_focus`-nullcheck
2023-06-22 21:58:19 +02:00
283580d0cc
Merge pull request #78566 from kleonc/repeated-sprite-selection-fix
...
Fix click-selecting Sprites with repeated texture
2023-06-22 18:32:01 +02:00
edba45ec8b
Fix click-selecting Sprites with repeated texture
2023-06-22 16:37:08 +02:00
5ec1b698d2
Fix missing enum value for `Window.initial_position`
...
Reorder the properties in a possibly more intuitive order.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-06-21 22:39:43 +02:00
890fdd56df
Code simplifications
...
CPPcheck found most of them.
no need to assign the variable twice:
- AnimationTrackEditTypeAudio
- SSEffects
variable is assigned in all if-else clauses:
- EditorHelp
- AndroidInputHandler
- MenuBar
- ShaderCompiler
same if clause:
- ItemList
clearing an empty bitfield has no effect:
- Viewport
2023-06-21 22:37:26 +02:00
83f065c0ef
Ensure that SceneTree is initialized and finalized at correct time
...
SceneTree should be fully initialized before any tree operation with any node and finalized only after all nodes exited tree.
2023-06-20 23:47:02 +03:00
a12627765f
Embedded Popups store their safe_rect in their embedder
...
Storing it in the DisplayServer didn't make sense in this case,
because the embedded window is unknown to the DisplayServer.
2023-06-20 18:06:26 +02:00
159f1ec301
Merge pull request #78398 from Sauermann/fix-immediate-focus-out
...
Fix that the focus-out notification got sent deferred
2023-06-20 13:14:10 +02:00
cce100a840
Merge pull request #75459 from kleonc/node-fix-find-children
...
Fix recursive `Node.find_children`
2023-06-19 22:33:46 +02:00
8cdab04d7f
Fix that the focus-out notification got sent deferred
...
Currently the window receives a focus-out notification, directly after
it popup, because currently the signal is sent deferred.
The original intention was that the previously focused window must
receive a focus-out notification.
This change makes the notification more precise by only sending the
focus-out to the previously focused window.
2023-06-18 23:06:07 +02:00
5373b67e2a
Respect returned bool from virtual process methods in SceneTree
...
SceneTree overrides the virtual `process` and `physics_process` methods
that it inherits from MainLoop. These methods return a boolean that
determines if the main loop should end.
The SceneTree was ignoring the returned boolean, so scripts inheriting
from SceneTree that override these methods and return true didn't exit
the main loop. Now the boolean is checked.
2023-06-18 20:45:58 +02:00
5b2a5cd2e0
Fix Physics Picking captured Object initialization
...
Initialize variables when a captured object is known.
2023-06-18 00:45:49 +02:00
f1d8ddd9bd
Remove SceneTree debug avoidance hint
...
Removes SceneTree debug avoidance hint.
2023-06-16 17:18:47 +02:00
2ebe692ccc
Merge pull request #78276 from smix8/remove_old_navdebug_materials_4.x
...
Remove legacy navigation debug materials
2023-06-16 10:20:20 +02:00
014b395ef3
Merge pull request #78262 from bruvzg/ds_window_focus
...
[DisplayServer] Add method to check if native window is focused.
2023-06-16 10:19:33 +02:00
28db3c7158
[DisplayServer] Add method to check if native window is focused.
2023-06-16 10:27:52 +03:00
1b506cd49c
Remove legacy navigation debug materials
...
Removes legacy navigation debug materials.
2023-06-15 16:33:55 +02:00
eb391d3302
Display `BitField[Enum]` in docs to distinguish from `Enum`
2023-06-15 17:23:02 +03:00
bddf24645d
Add SceneTree.get_node_count_in_group()
2023-06-14 19:19:30 +02:00
c3e5e4ed4b
Merge pull request #68599 from Rindbee/update-edited_scene_root-in-time
...
Update the edit scene root in time after it is replaced
2023-06-12 17:08:50 +02:00
eb74079dfb
Update the edit scene root in time after it is replaced
...
When changing the type of the edited scene root node, it may be necessary
to update edited scene root in time for the child nodes to work properly.
2023-06-12 21:49:30 +08:00
9fca498647
Merge pull request #78110 from Sauermann/fix-nofocus-focus
...
Fix Tooltip getting removed instantly in embedded Window
2023-06-12 11:55:58 +02:00
9d40f99290
Fix Tooltip getting removed instantly in embedded Window
...
Tooltips are unfocusable Windows. This case was not handled correctly in
`Viewport::_sub_window_register`.
2023-06-11 12:22:59 +02:00
0c16082e1e
Use `get_node_or_null` when null checks are present
...
Avoids duplicate or unnecessary errors
2023-06-10 13:22:56 +02:00
37a96d3957
Fix that `_drop_physics_mouseover` only happens when necessary
...
Previously the call was executed every time, because in the
`_drop_mouse_over();` a few lines above, `gui.mouse_over = nullptr;`
was set.
2023-06-10 09:33:16 +02:00
dcd2b883eb
Use NULL instead of COND checks when appropriate
...
Restricted to scene
2023-06-10 08:56:30 +02:00
8acf6b41a4
Merge pull request #77209 from Rindbee/ViewportTexture-not-change-RID
...
Don't change `RID` when changing `viewport_path` in `ViewportTexture`
2023-06-09 15:10:39 +02:00
7532b2d259
Don't change `RID` when changing `viewport_path` in `ViewportTexture`
...
When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder.
Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
2023-06-09 19:50:26 +08:00
300748e52c
Merge pull request #78044 from RandomShaper/fix_node_prio_ignored
...
Fix node idle process priority being ignored
2023-06-09 13:45:15 +02:00
2a8e83ccad
Merge pull request #78017 from Sauermann/fix-physics-passive-hovering
...
Fix passive mouse hovering for physics
2023-06-09 13:44:05 +02:00
8bbc713ebf
Fix node idle process priority being ignored
2023-06-09 13:05:07 +02:00
543fdc1490
Fix passive mouse hovering for physics
...
Currently mouse hovering doesn't update the state, when collision objects
or the camera move.
This PR fixes this problem by taking the mouse position from the viewport
and not from a nonexistent previous event.
Since previous events could potentially be a long time ago, their
modifier-key state might be outdated. This PR fetches the current
status of modifier-keys from `Input`.
These changes allow the removal of some class-variables and making
additional simplifications.
2023-06-09 12:51:10 +02:00
0cee1e0d4f
Merge pull request #77923 from Sauermann/fix-mouse-position-with-screen-transform
...
Fix mouse position with screen transform
2023-06-09 12:15:56 +02:00
37fc598ee1
Merge pull request #77899 from bruvzg/emb_center
...
Use initial position property for embedded windows to center on parent window.
2023-06-09 12:15:07 +02:00
d1fa284e65
Fix mouse position with screen transform
...
When a Viewport is not directly attached to the screen, the
function `Viewport::get_mouse_position` can't rely on
`get_screen_transform`, because that function is ambiguous in
these situations.
In these cases it is necessary to use the mouse position from
the most recent mouse IputEvent.
2023-06-09 11:29:43 +02:00
fd2f33942b
Merge pull request #78019 from Sauermann/fix-remove-child-inconsistency
...
Fix parent inconsistency in `Node::remove_child`
2023-06-09 11:06:49 +02:00
b083c1dbf5
Merge pull request #78005 from Sauermann/fix-some-simplifications
...
Some code simplifications
2023-06-09 11:06:26 +02:00
166643df32
Merge pull request #74937 from bitsawer/fix_uniform_storage
...
Fix shader uniform storage conversions and crash
2023-06-09 11:04:16 +02:00
7561e176e8
Fix parent inconsistency in `Node::remove_child`
...
`NOTIFICATION_CHILD_ORDER_CHANGED` could be triggered, while there
was an inconsistent state:
- parent node no longer had child listed as child
- child node still had parent node listed as parent
Bring these two in sync, before emitting the notification.
2023-06-08 22:51:07 +02:00
302a10e809
Fix `CanvasItem::draw_string_outline` parameter order
...
Switch `p_font_size` with `p_size` in header, because in all
other locations, `p_font_size` comes before `p_size`.
2023-06-08 18:15:38 +02:00
3a19d81691
Merge pull request #77842 from Sauermann/fix-unfocusable-subwindow
...
Fix input handling for unfocusable embedded windows
2023-06-08 17:38:33 +02:00
5ddab1f363
Some code simplifications
...
AnimationNodeBlendSpace2DEditor:
- `!tree` is always false, because it is checked a few lines above
CurveEdit:
- grabbing != GRAB_NONE is redundant
GradientTexture2DEdit:
- grabbed != HANDLE_FROM is redundant
- grabbed != HANDLE_TO is redundant
Viewport:
- index is not used afterwards
- In these cases `gui.mouse_focus` is always valid. Move check to a DEV_ASSERT
- simplify `stopped` calculation
2023-06-08 16:15:22 +02:00
42e4c41e77
Merge pull request #77888 from Calinou/node-improve-thread-guard-errors
...
Display the node path in Node thread guard errors
2023-06-08 09:10:18 +02:00
bd468cdec7
Display the node path or name in Node thread guard errors
...
This makes it easier to diagnose which node is the source of the issue.
2023-06-07 16:06:53 +02:00
27b402bf73
Merge pull request #77902 from dalexeev/doc-unify-deprecations
...
Documentation: Unify deprecations
2023-06-07 16:06:50 +02:00
b433020aa6
Documentation: Unify deprecations
2023-06-07 16:34:03 +03:00
807431c49a
Cancel tooltip when mouse leaves viewport
2023-06-07 00:56:36 +02:00
f00f4a0209
Fix input handling of unfocusable embedded Windows
...
InputEvents get in some cases sent to the wrong Window.
fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-06 17:51:19 +02:00
2e728e02cc
Merge pull request #77763 from RedworkDE/warning-dialog-crash
...
Prevent crashes when removing Viewport from scene tree in event handler
2023-06-06 12:19:25 +02:00
e5b312a1e8
Use initial position property for embedded windows to center on parent window.
2023-06-06 09:29:13 +03:00
85c908654c
Merge pull request #77867 from Sauermann/revert-move-child-update
...
Don't update mouse cursor state on child order changed
2023-06-05 13:43:11 +02:00
15ee292664
Don't update mouse cursor state on child order changed
...
Partially Revert "Create a virtual mouse move event after moving child nodes"
This reverts parts of commit ce10ca6979
2023-06-05 10:28:55 +02:00
c4db212870
Prevent crashes when removing Viewport from scene tree in event handler
2023-06-03 23:37:31 +02:00
8b42297d7c
Make `Viewport::gui_get_focus_owner` const
2023-06-02 12:36:10 -05:00
2e273f0e35
Merge pull request #77724 from RandomShaper/remove_red_th_cond
...
Remove redundant check from thread guards
2023-06-01 15:52:16 +02:00
8c288918a0
Remove redundant check from thread guards
2023-06-01 11:08:14 +02:00
6d490ce8de
Deprecate push_unhandled_input
...
The functionality of `push_unhandled_input` has changed so that it no
longer propagates input events to SubViewports.
This makes it less predictable and it should be deprecated in favor of
`push_input` which provides the same functionality and more.
Also this deprecation simplifies the Viewport-API by reducing the methods
for pushing input events, so that users don't need to worry about when
to use which function in order to insert input events.
2023-05-31 19:07:04 +02:00
6dd5ccdedd
Merge pull request #66625 from Sauermann/fix-move-child-update
...
Create a virtual mouse move event after moving child nodes in tree
2023-05-30 15:57:21 +02:00
3a895eafc0
Merge pull request #77595 from Sauermann/fix-double-inputevent
...
Fix InputEvent being used twice
2023-05-30 15:25:36 +02:00
ce10ca6979
Create a virtual mouse move event after moving child nodes
...
This updates mouse cursor and mouse-over-states without the need
for additional mouse movements.
2023-05-29 22:46:19 +02:00
ee7b26403b
Merge pull request #77433 from YuriSizov/editor-reparented-popups-fix
...
Fix auto-reparenting logic in the `ProgressDialog`
2023-05-29 17:30:46 +02:00
4c5c7cbb58
Fix auto-reparenting logic in the `ProgressDialog`
...
* Make sure `Popup` signals are disconnected when unparented.
* Remove a fail condition from `Window::is_embedded` when
not in tree.
2023-05-29 17:02:16 +02:00
23c375d6b4
Fix shader uniform storage conversions and crash
2023-05-29 15:17:13 +03:00
a9bf3de08e
Fix InputEvent being used twice
...
A single mouse click can cause multiple actions, which contradicts
the paradigm that a single Input Event should cause only a single
action.
The solution consists of two parts:
1. Physics Picking as the last step during viewport input event
handling, currently doesn't set the event as handled. This PR sets
the event as handled in the case of physics picking.
2. After an InputEvent is processed by a SubVieportContainer, it is
sent to its parent, even if it set as handled within the SubViewport.
This PR adds an additional test to check if the event is handled
before propagating the event to the parent Control.
2023-05-29 02:39:09 +02:00
af04d3fb2c
Fix error when attempting to move a embedded window with a negative title height
2023-05-28 16:46:16 -03:00
adbdf9a86e
Merge pull request #77234 from RandomShaper/fix_rtl_mt
...
Allow threads to mark themselves as safe for nodes
2023-05-24 08:42:59 +02:00
e725b4b02b
Allow threads to mark themselves as safe for nodes
2023-05-24 00:22:58 +02:00
012541763d
Merge pull request #77288 from puchik/expose_get_window_id
...
Expose get_window_id() from Window class
2023-05-23 19:14:24 +02:00
ab935aaac6
Merge pull request #77312 from ajreckof/fix_window_unselectable_for_ViewportTexture_NodePath
...
Fix `Window` derived nodes being unselectable for `ViewportTexture` `NodePath`
2023-05-22 17:02:20 +02:00
250d8d00b5
Fix compile issue in not very conformant compilers
2023-05-22 13:33:40 +02:00
ace7620e55
fix `Window`derived nodes being unselectable for `ViewportTexture` `NodePath`
2023-05-21 16:28:41 +02:00
49890a99c1
Expose get_window_id() from Window class
...
Window classes often need a Window ID for operations. This will help with performing operations on cached Windows.
2023-05-20 14:48:24 -07:00
50cf3d6966
Optimize threading-sensitive node data for single-threaded processing
2023-05-17 02:04:41 +02:00
44cc0d2ec2
Let calls through thread guards in resource loading contexts
2023-05-17 01:43:28 +02:00
755c61b57a
Merge pull request #77064 from brno32/push-input-null-check
...
Check for null event in Viewport::push_input
2023-05-16 11:04:08 +02:00
12b7a56202
Merge pull request #76713 from KoBeWi/TODO_is_now
...
Fix 2D audio in multiple viewports
2023-05-16 11:00:45 +02:00
508a5bf16e
Merge pull request #76025 from YuriSizov/editor-reparentable-windows
...
Expose dialog parent-and-popup logic to the API
2023-05-16 10:49:09 +02:00
59c19a7172
Merge pull request #75250 from bruvzg/lbl_rtl_jst_flags
...
Expose TextServer justification flags to Label, Label3D, TextMesh and RTL. Add flags to control last/single line justification.
2023-05-16 10:48:45 +02:00
8cfa19a078
Merge pull request #77000 from reduz/make-more-base-nodes-thread-safe
...
Make more base nodes thread safe
2023-05-16 00:31:56 +02:00
a5a1c3a03c
check for null event in Viewport::push_input
2023-05-15 20:16:15 +02:00
17f492fb82
Expose dialog parent-and-popup logic to the API
2023-05-15 19:49:28 +02:00
9163d8c336
Expose TextServer justification flags to Label, Label3D, TextMesh and RTL. Add flags to control last/single line justification.
2023-05-15 19:23:54 +03:00
0a9f72d5a8
Make more base nodes thread safe
...
Ongoing work to make more of the base nodes thread safe.
2023-05-15 16:54:10 +02:00
1eb250e17d
Avoid crash when adjusting a node tree that is not in the tree
...
When node tree `A` is not in the tree, `remove_child(B)` will not
automatically clean up the owners of `B` and `B`'s child nodes.
This is convenient for implementing operations like `replace_by()`,
but may have hidden dangers when manipulating the rest of the tree
`A`.
This commit makes it safe to manipulate the rest of `A` after freeing
`B`.
2023-05-11 08:57:39 +08:00
5271186f2f
Merge pull request #75901 from reduz/refactor-node-processing
...
Refactor Node Processing to allow Scene Multithreading
2023-05-10 12:46:44 +02:00
31fc7a8525
Merge pull request #62378 from trollodel/gsoc_2022_multiwindow
...
Add multi window code and shader editors (GSOC'22 Project)
2023-05-10 12:46:19 +02:00
3b8c828159
Merge pull request #69988 from smix8/navigation_rvo_rework_4.x
...
Rework Navigation Avoidance
2023-05-10 10:19:12 +02:00
8e608e9467
Merge pull request #64388 from Rindbee/improve-ViewportTexture
...
Improve the UX of ViewportTexture in the editor
2023-05-10 10:18:43 +02:00
b4d6b47c17
Add multi window code and shader editors
2023-05-10 09:14:21 +02:00
a6ac305f96
Rework Navigation Avoidance
...
Rework Navigation Avoidance.
2023-05-10 05:01:58 +02:00
af58f1e854
Improve the UX of ViewportTexture in the editor
...
The associated `ViewportTexture`s will update the `viewport_path`
in time when the `Viewport`'s nodepath is changed (caused by renaming
the node names or moving in the SceneTree dock).
If the target `Viewport` is changed by resetting the `viewport_path`,
the `ViewportTexture`s will be re-setup and emit `changed` signal in
time.
2023-05-10 09:13:43 +08:00
98c655ec8d
Refactor Node Processing
...
* Node processing works on the concept of process groups.
* A node group can be inherited, run on main thread, or a sub-thread.
* Groups can be ordered.
* Process priority is now present for physics.
This is the first steps towards implementing https://github.com/godotengine/godot-proposals/issues/6424 .
No threading or thread guards exist yet in most of the scene code other than Node. That will have to be added later.
2023-05-09 19:17:51 +02:00
72323a57d0
Merge pull request #57894 from Sauermann/fix-subviewport-1
...
Fix unrestricted mouse-event propagation to SubViewports for Physics-Picking
2023-05-09 10:43:49 +02:00
15f9ac9458
Merge pull request #75751 from KoBeWi/eradicate_ViewportTexture_errors_entirely_and_surely
...
Prevent errors when using ViewportTexture
2023-05-08 16:40:10 +02:00
bbe05b60c8
Merge pull request #57179 from spacechase0/notify-world2d-changed-master
...
Propagate previously unused NOTIFICATION_WORLD_2D_CHANGED, make CanvasItem/CollisionObject2D use it
2023-05-08 16:40:00 +02:00
1b9802fa8c
Prevent errors when using ViewportTexture
2023-05-08 15:56:16 +02:00
8118d0d2f5
Add more uses of appropriate cursors when resizing/moving some UI nodes
2023-05-07 11:14:57 -03:00
fa451ead91
Merge pull request #74883 from dalexeev/fix-thin-multiline-colors
2023-05-05 14:26:37 +02:00
8a41eefb97
Fix 2D audio in multiple viewports
2023-05-03 23:09:40 +02:00
46e06ee1e6
Propogate previously unused NOTIFICATION_WORLD_2D_CHANGED, make CanvasItem/CollisionObject2D use it
2023-05-01 18:26:55 -04:00
4aaa2e6477
Fix wait for thread not started
2023-04-27 20:28:22 +02:00
6aac8af6f1
Merge pull request #69318 from Sauermann/fix-refresh-gui-events
...
Fix scene reload crash related to mouse cursor update
2023-04-25 15:36:26 +02:00
290b09b36c
Expose `determinant` in Transform2D, rename internal method
2023-04-22 13:44:14 -05:00
3695dfb357
Merge pull request #75509 from KoBeWi/In_physics,_the_observer_effect_is_the_disturbance_of_an_observed_system_by_the_act_of_observation._A_common_example_is_checking_CanvasItem's_global_position,_which_causes_its_transform_to_be_re-calculated-
...
Fix invalid global position when read outside tree
2023-04-19 10:13:48 +02:00
520a8d8ed2
Add project manager / editor initial screen settings, implement DisplayServer.get_keyboard_focus_screen method.
2023-04-19 08:54:53 +03:00
727a4ed79a
Fix invalid global position when read outside tree
2023-04-18 22:14:01 +02:00
377d8845da
Merge pull request #75890 from YuriSizov/gui-remember-window-state
...
Always cache parent visibility in `CanvasItem`
2023-04-18 13:07:41 +02:00
97712b3f50
Clamp minimum value of time_left to 0.0
2023-04-17 16:49:04 +02:00
b8b494a16c
Merge pull request #68397 from aaronfranke/get-child
...
Make `Node::get_children()` public
2023-04-17 14:28:37 +02:00
e347d7d64d
Rename internal root canvas group to start with underscore
2023-04-16 17:42:21 -06:00
8eb9986dc5
Make `Node::get_children()` public
2023-04-15 21:59:25 -05:00
347a8e20ae
Merge pull request #69324 from RedMser/advanced-settings-errors
...
Make it easier to solve warnings/errors referring to project settings
2023-04-11 19:39:53 +02:00
c48219f51e
Merge pull request #73658 from smix8/do_not_stop_the_entire_server_cause_you_want_to_pause_4x
...
Keep NavigationServer active while SceneTree is paused
2023-04-10 16:24:26 +02:00
fd6a743823
Always cache parent visibility in CanvasItem
2023-04-10 16:18:46 +02:00
4b0dee080e
Keep NavigationServer active while SceneTree is paused
...
Keep NavigationServer active while SceneTree is paused.
2023-04-10 15:30:22 +02:00
d159123633
Fix recursive Node.find_children
2023-04-09 09:15:21 +02:00
ab5fc22f67
Optimize Node children management
...
* Adding and removing child nodes is now constant time, speed up should be huge.
* Searching for node paths as in ("path/to/node") should be far faster too.
This changes the children management and makes it a hashmap, optimizing most StringName based operations.
Most operations should be severe speed up without breaking compatibility.
This should fix many issues regarding to node access performance, and may also speed up editor start/end, but benchmarks are needed. So if you want to test, please make some benchmarks!
Further performance improvements will be done in the future by removing NOTIFICATION_MOVED_IN_PARENT and replacing by something less laborious.
2023-04-08 10:54:28 +02:00
c151d3231f
Merge pull request #75760 from reduz/optimize-node-add-child-validation
...
Optimize Node::add_child validation
2023-04-07 18:20:28 +02:00
223ce4fcb9
Optimize Node::add_child validation
...
Adding 10k nodes is almost twice as fast.
2023-04-07 13:18:47 +02:00
404f24b5c4
Update sibling indices after a node is removed.
...
With change 104392e
2023-04-06 20:47:57 +02:00
104392ef4e
Remove NOTIFICATION_MOVED_IN_PARENT
...
* This notification makes node children management very inefficient.
* Replaced by a NOTIFICATION_CHILDREN_CHANGED (and children_changed signal).
* Changed Canvas code (and similar) to use the above signal, to perform more efficiently.
This PR breaks compatibility (although this notification was very rarely used, even within the engine), but provides an alternate way to do the same.
It is required for the changes in #75627 to be entirely effective.
2023-04-06 13:57:13 +02:00
91ff34b5b5
Add a warning when trying to access theme items too early
2023-04-03 18:01:10 +02:00
b85fc4aa6d
Merge pull request #73646 from KoBeWi/squish
...
Prevent off-screen controls in editor
2023-04-03 17:07:54 +02:00
aa604c5c47
Do not clamp non-embedded window size to embedder
2023-03-29 22:35:07 +02:00
f818d2b98f
Merge pull request #75141 from rcorre/rrc/dialog-pos
2023-03-28 10:54:37 +02:00
5a5fd33e42
More i18n improvements
...
* Make placeholder in editor layout dialog translatable.
* Make messages in scene import settings dialog translatable.
* Mark theme override property categories for translation.
2023-03-27 22:24:01 +08:00
894ce41180
Apply clamp_to_embedder on parent resize and popup.
...
Fixes #75084 .
The clamp_to_embedder setting was added in 8be16e0704
2023-03-27 07:08:29 -04:00
c95b88cbe9
Merge pull request #75238 from kleonc/canvas-item-fix-notifications-order-on-enter-tree
...
`CanvasItem` Fix `ENTER_CANVAS` / `VISIBILITY_CHANGED` notifications order when entering tree
2023-03-27 13:00:41 +02:00
ed960453b7
Make solving project setting errors easier
...
Show full project setting path in error messages.
Force filtering for advanced settings if filter is not empty.
2023-03-27 08:10:35 +02:00
8f8178bda6
Fix auto-translations in editor
2023-03-22 23:57:12 +01:00
6e3820fd4d
CanvasItem Fix ENTER_CANVAS / VISIBILITY_CHANGED notifications order when entering tree
2023-03-22 20:01:22 +01:00
4d13be3c5e
Add missing documentation for MultiplayerPeerExtension
2023-03-20 08:08:59 -07:00
8836f2160a
Move call of `push_unhandled_input` from `Window` to `Viewport`
...
This solves the problem, that mouse events get sent to SubViewports
even if they are outside of the visible area of the SubViewport.
This changes makes SubViewportContainer::unhandled_input redundand.
Shortcut Events now need to be distributed via push_input, in order for
them to be able to reach SubViewports.
2023-03-17 19:22:24 +01:00
ba985ecf3f
Fix `draw_multiline_colors()` for `width < 0`
2023-03-14 09:43:56 +03:00
81e2b020ba
Prevent infinite loops when printing orphan nodes
2023-03-09 16:47:38 +01:00
0ef3d1bf56
Merge pull request #73188 from Sauermann/fix-inconsistent-viewport-size
...
Fix some ways to create inconsistent Viewport size states
2023-03-07 12:04:00 +01:00
0b98b470cc
Merge pull request #73716 from bruvzg/improve_locale_selection
...
Improve layout direction/locale automatic selection.
2023-03-06 10:57:56 +01:00
0885e4b931
Merge pull request #73365 from bruvzg/no_transient_children
...
Automatically reparent editor message dialogs to avoid error spam.
2023-03-02 11:41:17 +01:00
f9bcaccc11
[MP] Fix orphan StringName on close.
...
Use a static StringName for the registered default interface name.
2023-02-27 09:45:16 +01:00
82d7923c65
Improve layout direction/locale automatic selection.
2023-02-22 08:37:14 +02:00
921f3b7589
Automatically reparent editor message dialogs to avoid error spam.
2023-02-21 12:32:11 +02:00
55b50703d7
Prevent off-screen controls in editor
2023-02-20 20:25:39 +01:00
7246b229e1
Set RTL minimal dash size to 2.0, add invalid dash size error to the `draw_dashed_line`.
2023-02-17 08:53:08 +02:00
b90d70d592
Merge pull request #72764 from Sauermann/fix-color-picking
...
Fix Color Picking
2023-02-17 00:33:20 +01:00
4dfa161120
Add dash and step size checks to draw_dashed_line.
2023-02-16 17:49:18 +02:00
081b31d200
Clear Window before blitting Viewport in gl_compatibility renderer
2023-02-14 10:30:02 -08:00
830eff64a7
Merge pull request #68027 from ktxyz/window-on-top
...
Update sub_windows order with respect to FLAG_ALWAYS_ON_TOP
2023-02-14 13:40:24 +01:00
8a17f94ab2
Some fixes for initial window position and size
...
- X11: set main window position and size hints correctly
- All platforms: update minimum and maximum size of main window at
startup
Fixes #70984
2023-02-14 12:15:14 +01:00
a000c64eea
Cleanup Window callbacks before destroying in to avoid callback calls with invalid object.
2023-02-13 20:39:17 +02:00
34a7fc7447
Fix some ways to create inconsistent Viewport sizes
...
In the editor, it was possible to set the size of a `SubViewport` even
in cases where a parent `SubViewportContainer` had stretch enabled.
This PR disables editing a `SubViewport.size` while the parent disallows
it and it makes necessary adjustments during `NOTIFICATION_ENTER_TREE`.
2023-02-13 08:19:00 +01:00
ab2952580c
Merge pull request #73040 from Rindbee/popup_centered_consider_current_size
...
Calling popup_center* with the default size will use the current size
2023-02-11 14:37:54 +01:00
593598c592
Calling popup_center* with the default size will use the current size
2023-02-11 18:53:53 +08:00
97afa41da3
Merge pull request #73000 from Sauermann/fix-editor-viewport-size-zero-crash
...
Fix crash in editor when setting `SubViewport.size` to zero
2023-02-10 15:06:57 +01:00
5bb66d3cfb
Fix scene reload crash caused by mouse cursor update
...
After a scene reload a mouse cursor updates is performed via a
InputEventMouseMotion, that is exposed to the user.
The state of Input is however not adjusted to this InputEventMouseMotion
which can lead to inconsistencies.
This PR makes sure, that it is not exposed to the user.
It utilizes the method of Viewport::_process_picking for marking
events that are not sent to the user, so that this function doesn't
need to be changed.
2023-02-10 01:16:23 +01:00
d249370cd7
Fix crash in editor when setting `SubViewport.size` to zero
...
`Viewport::_set_size` now verifies, that the minimum size is at least 2x2.
Also fix `RendererViewport::viewport_set_size` fail condition.
2023-02-10 00:25:45 +01:00
88f4e5cc94
Fix that `popup_centered` didn't take the window's size into consideration
2023-02-09 22:05:39 +01:00
888add8418
Fix Color Picking
...
With the 4.x-introduction of Windows the previous method for
color picking was no longer working.
This PR uses the following approach to reintroduce color-picking.
When the Color-Picking-Button is pressed, a quasi-screenshot of the
Window-content is created and displayed in a new Popup-Window.
This new Window allows selecting colors by Mouse-Click.
A Preview of the targeted Color is also displayed.
2023-02-09 01:00:54 +01:00
b8eda519d0
Optimize `draw_dashed_line()` and `draw_rect()`
2023-02-08 10:44:12 +03:00
929333fe26
Merge pull request #62179 from Rindbee/fix-popup_center-off-center
...
Use min_size/max_size to limit window size and position while popup center
2023-02-07 16:30:41 +01:00
743e26d4f9
Merge pull request #72829 from Sauermann/fix-code-simplifications
...
Some code simplifications
2023-02-07 16:30:22 +01:00
826e54fa73
Some code simplifications
...
1. `number_width` isn't used later
2. `return_type` is used only once
3. AudioServer::get_singleton()->get_channel_count() always returns a channel_count of 1 or larger
4. negative `aa->backward` conditional
5. `current_canvas` == `find_world_2d()->get_canvas()`
6. identical if `render_shadows`
2023-02-07 14:30:16 +01:00
c73844f117
Use min_size/max_size to limit the window size and the position while popup center
2023-02-07 21:28:26 +08:00
5312d83f3b
Fix Viewport::get_mouse_position for SubViewports
...
SubViewports don't have a cached mouse position available.
This PR calculates the mouse position from the screen position of
the mouse cursor.
2023-02-07 13:54:47 +01:00
cd0f1e9b10
Merge pull request #72740 from Sauermann/fix-event-device-id
...
Fix mouse/drag/touch InputEvents having no device id
2023-02-06 23:51:26 +01:00
8748f4dcaa
Fix mouse/drag/touch InputEvents having no device id
...
Some internally created emulated/instantiated events didn't have a
device id. This PR sets for these cases a device id.
Also rename `DEVICE_ID_TOUCH_MOUSE` to the more generic
`DEVICE_ID_EMULATION`.
2023-02-06 22:49:42 +01:00
262d84fa90
Fix MOUSE_FILTER_STOP not affecting emulated mouse events
...
Touch and Drag events are now stopped by MOUSE_FILTER_STOP
2023-02-06 22:31:03 +01:00
82ff7b4bce
Merge pull request #68492 from Sauermann/fix-picking-sort
...
Fix propagation order for 2D physics picking events
2023-02-06 15:38:38 +01:00
6e855e3820
Fix propagation order for 2D physics picking events
...
This patch adds a viewport-configuration-option for sorting
physics-picking events by the Z-Index and the scene tree position
of the collision objects.
2023-02-04 22:44:36 +01:00
7331750618
Fix Camera2D crash due to ParallaxBackground node
2023-02-03 15:36:08 +01:00
e3e9da78e8
Remove `Viewport::_get_input_pre_xform`
...
This function is only relevant for `Window`. So this PR moves
the functionality to the `Window`-class.
2023-02-02 22:03:52 +01:00
a16b0fec40
Merge pull request #72618 from Sauermann/fix-simplify-set-size
...
Simplify Viewport::_set_size
2023-02-02 21:05:51 +01:00
6743ac34d3
Simplify Viewport::_set_size
...
`Viewport.to_screen_rect` is used only in a single location to compare it
to `Rect2i()`.
When called from `SubViewport`, `to_screen_rect` is always equal to `Rect2i()`.
When called from `Window`, `to_screen_rect` is always different from `Rect2i()`.
So the comparison `to_screen_rect != Rect2i()` can be replaced by
`Object::cast_to<Window>(this)`.
This allows the removal of `Viewport.to_screen_rect` and the simplification of
`Viewport::_set_size`.
2023-02-02 19:09:14 +01:00
3bc426c9d8
Fix toplevel nomenclature
...
toplevel was 3.x
top_level is 4.x
2023-02-02 17:37:41 +01:00
724d6581d6
Fix Camera2D crashes
2023-02-01 23:49:02 +01:00
e52213e2fa
More codespell fixes, do more changes from previous ignore list
2023-02-01 12:11:36 +01:00
2852d5e613
Merge pull request #67331 from Sauermann/fix-subviewport-no-stretch-update
...
Fix stretch transform when resizing SubViewports
2023-02-01 11:10:01 +01:00
f7397a5ac6
Merge pull request #58610 from Sauermann/fix-physics-mouse
...
Fix execution of physics picking events at unexpected times
2023-02-01 09:41:43 +01:00
394bb0ee2b
Fix various typos with codespell
...
Finally do the childs -> children rename too.
2023-02-01 08:45:41 +01:00
8182f29d40
Fix stretch transform when resizing SubViewports
...
Move calculation of stretch transform from outside to inside
of `Viewport::_set_size` function.
2023-02-01 08:34:40 +01:00
d9ade633b3
Merge pull request #71936 from akien-mga/remove-some-unused-signals
...
Remove some unused signals
2023-02-01 07:53:52 +01:00
e8240031e7
Merge pull request #71479 from raulsntos/virtual-return-type
...
Use enum instead of int in virtual methods return type
2023-02-01 07:45:28 +01:00
51414fc987
Merge pull request #66906 from Sauermann/fix-prohibit-inconsistent-size-state
...
Prohibit inconsistent size state for SubViewport
2023-02-01 07:26:00 +01:00
decbda68d7
Prohibit inconsistent size state for SubViewport
...
Prohibit size changes of SubViewports with parent SubViewportContainers that have stretch mode enabled.
2023-01-31 22:53:43 +01:00
9e9eac4676
Use enum instead of int in virtual methods return type
2023-01-31 19:06:49 +01:00
14a4408e02
Merge pull request #65698 from KoBeWi/cameraman
...
Rework how current Camera2D is determined
2023-01-31 18:56:20 +01:00
b342dcdf04
Remove some unused signals
...
Part of #37604 .
2023-01-31 18:54:04 +01:00
2b710bc336
Fix MSVC shadow local warning
2023-01-31 18:06:21 +01:00
1c42e141d0
Merge pull request #59310 from Sauermann/proposal-event-transform
...
Calculate window input event transform only on window change
2023-01-31 15:57:07 +01:00
4cfdd25384
Merge pull request #67507 from Sauermann/fix-toplevel-root-control-node
...
Fix event propagation to child after set_as_toplevel
2023-01-31 15:55:46 +01:00
bde3310f02
Merge pull request #71995 from Faless/net/4.x_tls_verify
...
[NET] Refactor TLS configuration.
2023-01-30 13:28:31 +01:00
2e0d9efb72
Merge pull request #72115 from AThousandShips/clip_children_fix
...
Hide `clip_children` for some non-drawn CanvasItems
2023-01-30 10:02:54 +01:00
bbf203bc32
Hide clip_children for non-drawn CanvasItems
2023-01-30 08:22:06 +01:00
9f026d5274
Fix Editor Description tooltip not changing until scene is reopened
...
You still need to select another node to see the tooltip updated first,
but you no longer need to save and reopen the scene to view the updated
tooltip.
2023-01-30 00:18:13 +01:00
adba870534
[NET] Refactor TLS configuration.
...
Use a TLSOptions configuration object which is created via static
functions.
- "TLSOptions.client": uses the standard CA and common name verification.
- "TLSOptions.client_unsafe": uses optional CA verification (i.e. if specified)
- "TLSOptions.server": is the standard server configuration (chain + key)
This will allow us to expand the TLS configuration options to include
e.g. mutual authentication without bloating the classes that uses
StreamPeerTLS and PacketPeerDTLS as underlying peers.
2023-01-28 11:08:02 +01:00
aae96945fa
Merge pull request #71470 from YeldhamDev/window_fixes
...
Fix some small bugs in the `Window` node
2023-01-27 19:26:31 +01:00
b15a3ea3a4
Added assertion check
2023-01-26 16:10:32 +01:00
058c61b5b3
Merge pull request #68007 from Sauermann/fix-3d-capture
...
Fix event-content and mouse-signals with 3D-capture-on-drag
2023-01-26 16:00:26 +01:00
13e20fed99
Merge pull request #68627 from Sauermann/fix-tooltip-position
...
Fix position of Tooltips
2023-01-26 16:00:14 +01:00
83fa14a5a9
Include the Window-transform into Viewport::get_final_transform
2023-01-26 15:30:44 +01:00
c4ed247f5f
Fix position of Tooltips
...
CanvasItem::get_screen_transform returns a transform from the CanvasItem
to the coordinate system, where a Popup - created as a child of the
CanvasItem - should be opened.
get_screen_transform makes some simplifications, that work well, when used
in the editor, but not in general cases.
Since Popups like Tooltips are now used more commonly in projects,
it becomes necessary to correct these simplifications.
This solution introduces Viewport::get_popup_base_transform, which makes
the necessary calculations.
2023-01-26 15:15:14 +01:00
2bc0bcbd26
PropertyUsage: Rename "DO_NOT_SHARE_ON_DUPLICATE" to "ALWAYS_DUPLICATE"
2023-01-24 16:05:07 -06:00
fab9926a95
Merge pull request #65137 from dalexeev/editor-naming
...
Rearrange `editor/naming/*` project settings
2023-01-24 22:26:03 +03:00
11e2278844
Merge pull request #57606 from SaracenOne/update_on_reimport
...
Update instances of scenes which have been reimported.
2023-01-23 15:35:44 +01:00
5b1df48c6c
Convert en_GB spelling to en_US with codespell
2023-01-23 11:02:20 +01:00
cd031fd31a
Merge pull request #71663 from bruvzg/init_pos_x
...
Reorganize main and sub-window initial position properties.
2023-01-22 11:25:58 +01:00
229c82690d
Merge pull request #70294 from KoBeWi/treedulate
...
Add a method to get global modulate
2023-01-21 20:51:42 +01:00
7b622ce6e8
Merge pull request #71021 from reduz/prevent-physics-callback-removal
...
Error when removing a physics node during a physics callback
2023-01-21 11:28:02 +01:00
a83093fa80
Merge pull request #71692 from HalcyonGarside/viewport-debug-draw-fix
...
Fix incorrect Viewport Debug Draw effects
2023-01-20 08:49:21 +01:00
9fc40123ab
Merge pull request #71679 from kleonc/draw_polyline_line_strip
...
`CanvasItem::draw_polyline` Support thin polylines drawn using line strip
2023-01-20 08:48:56 +01:00
360b61084a
Merge pull request #41239 from dalexeev/fix_draw_rect
...
Fix `CanvasItem.draw_rect` function with `filled = false`
2023-01-19 22:49:23 +01:00
ef35c4002c
Add 'Lighting' to list of Debug Draw viewport options
2023-01-19 15:23:59 -05:00
728c51e362
CanvasItem::draw_polyline Support thin polylines drawn using line strip
2023-01-19 21:08:25 +01:00
aade5abd4f
Reorganize main and sub-window initial position properties.
2023-01-19 13:44:06 +02:00
52b077ca28
Fix some small bugs in the `Window` node
2023-01-18 21:20:49 -03:00
2050f59e3a
Merge pull request #71623 from kleonc/draw_arc_clamp_to_single_circle
...
`CanvasItem::draw_arc` Clamp angle difference so arc won't overlap itself
2023-01-18 22:28:24 +01:00
43fc483e6c
CanvasItem::draw_arc Clamp angle difference so arc won't overlap itself
2023-01-18 15:16:22 +01:00
a058cedb53
Fix crash on touch release
2023-01-17 19:12:55 -05:00
c046bb8389
Fix `CanvasItem.draw_rect` function with `filled = false`
2023-01-17 09:15:47 +03:00
4628736894
Update instances of scenes which have been reimported.
2023-01-16 13:46:33 -08:00
ae3ca04aba
Merge pull request #69598 from Sauermann/fix-focus-inverse
...
Calculate the mouse focus inverse transform only when needed
2023-01-16 22:11:23 +01:00
47689c7d51
Merge pull request #71502 from bruvzg/tooltip_clickthrough
...
Add `WINDOW_FLAG_MOUSE_PASSTHROUGH` flag and enabled it for tooltips.
2023-01-16 12:48:45 +01:00
a8cbb6245b
Fix scaling issue in `draw_line` and similar methods
2023-01-16 12:49:58 +03:00
34b34b104c
Add `WINDOW_FLAG_MOUSE_PASSTHROUGH` flag and enabled it for tooltips. Expose `window_set_mouse_passthrough` to `Window`.
2023-01-16 11:42:49 +02:00
55bf948fe7
Fix change_scene memory leak due to duplicate instantiation
...
Regression from #71105 .
Fixes #71363 .
2023-01-15 14:05:15 +01:00
9b2843f14f
Improve dashed line alignment and make it optional.
2023-01-13 10:30:12 +02:00
f79c58aac5
Merge pull request #71209 from bruvzg/ed_progress_reparent
...
Automatically reparent editor progress dialog to avoid error spam.
2023-01-13 00:29:48 +01:00
8f706be6fa
Rearrange `editor/naming/*` project settings
2023-01-12 11:41:13 +03:00
baae87e307
Merge pull request #71105 from reduz/unload-current-scene
...
Add SceneTree.unload_current_scene()
2023-01-11 09:46:33 +01:00
19293d1813
Automatically reparent editor progress dialog to avoid error spam.
2023-01-11 10:13:21 +02:00
e5f2c442c7
Add SceneTree.unload_current_scene()
...
Provides an obvious way to unload the currently loaded scene (which is nowhere to be found in the docs).
The SceneTree.change_scene_to() method must now always provide a valid PackedScene.
Fixes #63565 .
2023-01-10 14:02:06 +01:00
ca8b762797
Add Node::get_window() method.
2023-01-10 11:10:46 +02:00
dce8cdbca8
Merge pull request #70863 from bruvzg/win_init_min
...
Set main window min. size via Window object instead of DisplayServer to preserve it during window updates.
2023-01-09 23:08:52 +01:00
0d6d5e6421
Calculate the mouse focus inverse transform only when needed
...
Revival of #49158
Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com>
2023-01-09 21:35:38 +01:00
0ca5a72e90
Clarify some parent item checks in CanvasItem
2023-01-09 19:59:55 +03:00
2b815df3c1
Use BitField<> in core type masks
...
* All core types masks are now correctly marked as bitfields.
* The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks.
* Most bitmask operations replaced by functions in BitField<>
* Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is.
* Documentation and API dump updated to reflect bitfields in core types.
2023-01-08 22:17:40 +01:00
d642274f75
Merge pull request #70939 from bruvzg/win_screen_2
...
Add support for the custom initial screen for the main window, fix primary screen detection.
2023-01-07 13:21:36 +01:00
3579d7a9f7
Merge pull request #36301 from KoBeWi/daddy_node
...
Add reparent methods to Node
2023-01-07 13:20:56 +01:00
398e73c689
Error when removing a phycics node during a physics callback
...
* This behavior is not allowed, the error text suggests using call_deferred().
* Added a check in Node::remove_child to prevent future crashes of this type.
* Fixed a performance regression introduced by #36244 .
Fixes #63718 , probably other crashes too.
2023-01-07 12:57:24 +01:00
2718a7b7d3
Add support for the custom initial screen for the main window, fix primary screen detection.
2023-01-07 11:14:35 +02:00
163f6f5fe8
Merge pull request #68429 from KoBeWi/PropertySettings
...
Add PropertyInfo overload for GLOBAL_DEF
2023-01-06 22:59:29 +01:00
d95794ec8a
One Copyright Update to rule them all
...
As many open source projects have started doing it, we're removing the
current year from the copyright notice, so that we don't need to bump
it every year.
It seems like only the first year of publication is technically
relevant for copyright notices, and even that seems to be something
that many companies stopped listing altogether (in a version controlled
codebase, the commits are a much better source of date of publication
than a hardcoded copyright statement).
We also now list Godot Engine contributors first as we're collectively
the current maintainers of the project, and we clarify that the
"exclusive" copyright of the co-founders covers the timespan before
opensourcing (their further contributions are included as part of Godot
Engine contributors).
Also fixed "cf." Frenchism - it's meant as "refer to / see".
2023-01-05 13:25:55 +01:00
8791e333da
Merge pull request #70624 from bruvzg/cur_sc
...
Improve `window_set_current_screen` and fix secondary window initial mode and positions.
2023-01-03 15:56:05 +01:00
06551dfa3a
Set main window min. size via Window object instead of DisplayServer to preserve it during window updates.
2023-01-03 09:25:45 +02:00
ea33001b95
Add safety-checks before some servers `free()`
2022-12-29 16:23:38 -05:00
f7955633de
Improve `window_set_current_screen` and fix secondary window initial mode and positions.
2022-12-29 09:43:39 +02:00
3161647dab
Fix CanvasItem Z-index referring to Node2D
2022-12-19 20:59:14 -06:00
adc1096b19
Merge pull request #70219 from bruvzg/msdf_outline_scaling
...
Scale MSDF font outline with the font size and MSDF source size to match dynamic font behavior.
2022-12-19 16:26:56 +01:00
f29f3db419
Merge pull request #59682 from Sauermann/fix-following-viewport-transform
...
Include the follow-viewport-transform into CanvasLayer transform calculations
2022-12-19 16:26:19 +01:00
32b0770a73
Add a method to get global modulate
2022-12-19 11:51:37 +01:00
2da2220da7
Include the following-viewport-transform into CanvasLayer transforms
...
The following-viewport-transform was missing from several calculations
2022-12-18 22:44:34 +01:00
20d9457f9d
Scale MSDF font outline with the font size and MSDF source size to match dynamic font behavior.
2022-12-17 22:47:54 +02:00
a1f481a7d6
Merge pull request #70202 from Calinou/viewport-transparent-background-rename-project-setting
...
Move transparent background project setting to a subsection
2022-12-17 20:56:19 +01:00
a3eac5fc7c
Move transparent background project setting to a subsection
...
This prevents the project setting from being located directly within
a root category, which is confusing from an UX perspective in the
project settings editor.
2022-12-17 18:45:21 +01:00
8be126272f
Merge pull request #70075 from Sauermann/fix-missing-shortcut-handled-check
...
Fix missing check if shortcut event is handled for Control-nodes
2022-12-16 13:47:39 +01:00
e173710963
Fix possible Tween leak on exit
2022-12-15 19:09:09 +08:00
57ff04278b
Fix missing check if shortcut event is handled for Control-nodes
...
Control-nodes without a shortcut-context were missing a check if
the event was handled, so that a single shortcut-event was passed to
multiple Control-nodes.
2022-12-14 22:22:24 +01:00
f1edd03d4c
Merge pull request #69718 from groud/finally_rename_gdnative_to_gdextension
...
Rename all gdnative occurences to gdextension
2022-12-12 11:43:59 +01:00
be1c9d677d
Rename all gdnative occurences to gdextension
...
Non-exhaustive list of case-sensitive renames:
GDExtension -> GDNative
GDNATIVE -> GDEXTENSION
gdextension -> gdnative
ExtensionExtension ->Extension (for where there was GDNativeExtension)
EXTENSION_EXTENSION ->EXTENSION (for where there was GDNATIVE_EXTENSION)
gdnlib -> gdextension
gdn_interface -> gde_interface
gdni -> gde_interface
2022-12-12 11:04:57 +01:00
7c6b659bd7
Add PropertyInfo overload for GLOBAL_DEF
2022-12-11 21:36:48 +01:00
29cc86fa6c
Copy local theme overrides from Control to Window
2022-12-07 20:50:51 +03:00
edf13eb5a6
Rename `window_get_real_size` to `window_get_size_with_decorations`, add `window_get_position_with_decorations`.
2022-12-07 11:07:30 +02:00
7e2a8afb57
Rework how current Camera2D is determined
2022-12-02 00:05:02 +01:00
3ff7dd2aa4
Fix routing of InputEventScreenDrag events to Control nodes
2022-11-30 14:06:41 -08:00
e84f45fc93
Move z_index, z_as_relative and y_sort_enabled from Node2D to CanvasItem
2022-11-29 17:11:22 +01:00
ef090ee6ea
Merge pull request #68874 from TokageItLab/fix-unique-path-keying
...
Added option to `get_path_to()` to get the shortest path considering unique name
2022-11-28 14:49:34 +01:00
f4faa507d4
Merge pull request #68836 from Calinou/projectsettings-vrs-texture-allow-more-formats
...
Allow all lossless image formats to be used for VRS texture project setting
2022-11-28 08:38:08 +01:00
438b2e2d02
Merge pull request #59801 from Sauermann/fix-node2d-viewport-root-order
...
Fix Viewport root order after Node2D raise
2022-11-28 08:21:10 +01:00
88e6e1e51c
Revert "`SceneTree` Fix storing removed nodes to be skipped by the group calls"
2022-11-27 13:42:24 +01:00
986a4279fa
Merge pull request #68447 from Grimmr/clean-tooltips-on-WM-focus-off
...
Viewport cancels existing tooltip when window looses focus
2022-11-25 14:04:40 +01:00
aa9b5b917f
Viewport cancels existing tooltip when window looses focus
...
fixes #68197
when NOTIFICATION_WM_WINDOW_FOCUS_OUT is recieved by a viewport it will now call
_gui_cancel_tooltip() to avoid it hanging around after the mouse events stop
coming in
2022-11-25 09:44:04 +00:00
d7e3fce995
Merge pull request #68566 from Mickeon/node-print-orphans-static
...
Make `Node.print_orphan_nodes()` static
2022-11-24 18:55:30 +01:00
885fc1f3e7
Merge pull request #68568 from Mickeon/node-parent-busy-error
...
Update "Parent node is busy" errors to use `Callable.call_deferred()`
2022-11-23 23:11:06 +01:00
c6a355b9e8
Update "Parent node is busy" errors to use `Callable.call_deferred()`
...
Also fixes outdated method names in the messages.
2022-11-23 17:39:34 +01:00
f8df18ef47
Fix CanvasTransform on RenderingServer when Viewport enters Tree
...
Previously the Viewport didn't initialize its canvas transform in the
RenderingServer.
2022-11-22 23:04:23 +01:00
145f07c037
[Net] Fix HTTPRequest gzip with high compression ratio.
...
Decompress each body chunk over multiple iterations, this causes more
reallocations, but it ensures decompression will not fail no matter the
compression ratio.
2022-11-20 22:41:14 +01:00
b9d1550590
Add option to get_path_to() to get the shortest path with unique name
2022-11-19 15:06:25 +09:00
4b13093251
Allow all lossless image formats to be used for VRS texture project setting
...
WebP can also be lossy, but the class reference now warns about the
requirement to use a lossless format for the VRS texture to work correctly.
2022-11-18 22:21:28 +01:00
721e51ac28
Fixed _get_drag_data getting incorrect position on scaled controls
2022-11-18 19:10:57 +02:00
6d2a7cb46d
Merge pull request #68709 from MewPurPur/instance-begone-part3
...
Remove more instances of 'instance' being used as a verb
2022-11-16 14:41:42 +01:00
3b4f5f8a04
Remove more instances of 'instance' being used as a verb
2022-11-16 14:01:53 +01:00
3b08d0e852
Fix crash of queue_free() when main loop is not SceneTree
2022-11-15 08:25:25 +08:00
03f30855d1
Merge pull request #67831 from kleonc/scene-tree-fix-storing-removed-nodes
...
`SceneTree` Fix storing removed nodes to be skipped by the group calls
2022-11-14 23:27:41 +01:00
0dbb632116
Merge pull request #68564 from Mickeon/node-no-remove-group-error
...
Strip ERR_FAIL from `Node.remove_from_group()`
2022-11-14 23:24:14 +01:00
3b14f0334c
Remove redundant Variant-types initializations
2022-11-14 19:35:19 +01:00
d639bb87a7
Merge pull request #68272 from Sauermann/fix-windowfocus-on-resize
...
Fix Windowfocus on resizing
2022-11-14 16:38:00 +01:00
5cf6ebce63
Drop physics mouseover as soon as the mouse moves over a Control
2022-11-14 12:07:26 +01:00
a1c10dbbd8
Strip ERR_FAIL from `Node.remove_from_group()`
...
Also simplifies group check removing unnecessary `!data.grouped.has`
2022-11-13 00:01:18 +01:00
9b42268467
Make `Node.print_orphan_nodes()` static
2022-11-12 17:55:42 +01:00
5c7af7f391
Merge pull request #68418 from Sauermann/fix-escape-dnd
...
Allow canceling Drag and Drop with the Escape-Key
2022-11-11 16:49:09 +01:00
226044b944
Allow canceling Drag and Drop with the Escape-Key
...
This patch implements the functionality to cancel Drag and Drop
by using the escape key or more general, the ui_cancel action.
Since this would be the third location, where the finalization of
Drag and Drop would have to be implemented, that functionality was
put into the private function _perform_drop.
Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging
because they are equivalent.
2022-11-08 19:10:16 +01:00
7601808455
Update sub_windows order with respect to FLAG_ALWAYS_ON_TOP
2022-11-08 13:20:45 +01:00
7445ab95fc
Fix SubViewport with default size being pink
...
A SubViewport with default-size doesn't display its content, but shows
pink color, until it is resized.
This patch makes sure, that the size gets set during initialization.
2022-11-07 09:23:32 +01:00
65647e9c7d
Fix Windowfocus on resizing
...
When resizing a non-focused window, the previously focused
Window got resized.
This patch grabs focus for the actually resized window, before
starting with the resizing.
2022-11-04 22:24:00 +01:00
d4bf7f4458
Fixup Clang -Wtype-limits warnings introduced by #52350
2022-11-02 22:36:01 +01:00
022d24a9ae
Fix Viewport root order after Node2D raise
2022-11-02 21:45:00 +01:00
30e4e7c083
Merge pull request #67917 from Faless/mp/4.x_auth
...
[MP] Add peer authentication support to the default MultiplayerAPI.
2022-11-02 18:53:38 +01:00
604abb434f
Merge pull request #52350 from BimDav/viewport_canvas_cull
...
Added Viewport canvas cull mask feature
2022-11-02 17:14:24 +01:00
33dda2e68a
[MP] Remove connection state signals from MultiplayerPeer.
...
Now handled directly by the MultiplayerAPI implementation.
2022-11-02 15:17:23 +01:00
ad0349c0e3
Merge pull request #59479 from Sauermann/fix-rootorder-on-layerchange
...
Update root order on layer change
2022-11-02 14:20:24 +01:00
0a0e99cadc
Merge pull request #67982 from Faless/mp/4.x_disconnect_close
...
[MP] Add MultiplayerPeer disconnect_peer, close.
2022-11-01 20:35:04 +01:00
fcb9be66a2
Viewport canvas cull mask feature
...
Co-authored-by: Valentin Zagura <puthre@gmail.com>
2022-10-31 14:09:49 +01:00
5947f22be9
Merge pull request #67578 from KoBeWi/GEDITOR
...
Unify usage of GLOBAL/EDITOR_GET
2022-10-31 13:15:58 +01:00
Yuri Sizov
Markus Sauermann
Mikko Ankkala
kobewi
Aaron Franke
Hendrik Brucker
bruvzg
Ninni Pipping
Rémi Verschelde
kleonc
Pedro J. Estébanez
Rémi Verschelde
Rindbee
RedworkDE
ajreckof
jeana helver
Nickolai Korshunov
Raul Santos
smix8
Danil Alexeev
Alula
Hugo Locurcio
Yuri Sizov
bitsawer
Michael Alexsander
Arman Elgudzhyan
Alex Drozd
Juan Linietsky
trollodel
Max Hilbrunner
Chase Warrington
Samuele Panzeri
Chris Hutchinson
angel-721
Haoyu Qiu
Ryan Roden-Corrent
RedMser
David Snopek
Fabio Alessandrelli
clayjohn
Thomas ten Cate
Ninni Pipping
HalcyonGarside
Mai Lavelle
SaracenOne
Adam Scott
Gilles Roudière
Fredia Huya-Kouadio
grimmr
Micky
Silc Renew
Uxeron
VolTer
ktxyz
BimDav