godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
godot/scene/main/viewport.cpp

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

4850 lines
156 KiB
C++
Raw Normal View History

One Copyright Update to rule them all As many open source projects have started doing it, we're removing the current year from the copyright notice, so that we don't need to bump it every year. It seems like only the first year of publication is technically relevant for copyright notices, and even that seems to be something that many companies stopped listing altogether (in a version controlled codebase, the commits are a much better source of date of publication than a hardcoded copyright statement). We also now list Godot Engine contributors first as we're collectively the current maintainers of the project, and we clarify that the "exclusive" copyright of the co-founders covers the timespan before opensourcing (their further contributions are included as part of Godot Engine contributors). Also fixed "cf." Frenchism - it's meant as "refer to / see".
2023-01-05 12:25:55 +00:00
/**************************************************************************/
/* viewport.cpp */
/**************************************************************************/
/* This file is part of: */
/* GODOT ENGINE */
/* https://godotengine.org */
/**************************************************************************/
/* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */
/* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur. */
/* */
/* Permission is hereby granted, free of charge, to any person obtaining */
/* a copy of this software and associated documentation files (the */
/* "Software"), to deal in the Software without restriction, including */
/* without limitation the rights to use, copy, modify, merge, publish, */
/* distribute, sublicense, and/or sell copies of the Software, and to */
/* permit persons to whom the Software is furnished to do so, subject to */
/* the following conditions: */
/* */
/* The above copyright notice and this permission notice shall be */
/* included in all copies or substantial portions of the Software. */
/* */
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/**************************************************************************/
Add missing copyright headers and fix formatting Using `misc/scripts/fix_headers.py` on all Godot files. Some missing header guards were added, and the header inclusion order was fixed in the Bullet module.
2018-01-04 23:50:27 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
#include "viewport.h"
Dead code tells no tales
2017-08-27 19:07:15 +00:00
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 01:46:22 +00:00
#include "core/config/project_settings.h"
Refactor ScriptDebugger. EngineDebugger is the new interface to access the debugger. It tries to be as agnostic as possible on the data that various subsystems can expose. It allows 2 types of interactions: - Profilers: A subsystem can register a profiler, assigning it a unique name. That name can be used to activate the profiler or add data to it. The registered profiler can be composed of up to 3 functions: - Toggle: called when the profiler is activated/deactivated. - Add: called whenever data is added to the debugger (via `EngineDebugger::profiler_add_frame_data`) - Tick: called every frame (during idle), receives frame times. - Captures: (Only relevant in remote debugger for now) A subsystem can register a capture, assigning it a unique name. When receiving a message, the remote debugger will check if it starts with `[prefix]:` and call the associated capture with name `prefix`. Port MultiplayerAPI, Servers, Scripts, Visual, Performance to the new profiler system. Port SceneDebugger and RemoteDebugger to the new capture system. The LocalDebugger also uses the new profiler system for scripts profiling.
2020-02-27 02:30:20 +00:00
#include "core/debugger/engine_debugger.h"
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
#include "core/object/message_queue.h"
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
#include "core/string/translation.h"
Fix some unnecessary includes
2021-08-12 23:05:59 +00:00
#include "core/templates/pair.h"
Fix propagation order for 2D physics picking events This patch adds a viewport-configuration-option for sorting physics-picking events by the Z-Index and the scene tree position of the collision objects.
2022-11-10 21:55:57 +00:00
#include "core/templates/sort_array.h"
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
#include "scene/2d/audio_listener_2d.h"
add viewport.get_camera_2d() * there is now a more clear distinction between camera_2d and camera_3d functions in the engine code * simplified camera2d's exported interface - now everything happens directly with the 'current' variable and make_current and clear_current are no longer exposed- there were some situations where calling one instead of set_current would result in incomplete results * rebased to current godot master
2020-04-28 15:04:07 +00:00
#include "scene/2d/camera_2d.h"
Dead code tells no tales
2017-08-27 19:07:15 +00:00
#include "scene/2d/collision_object_2d.h"
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#ifndef _3D_DISABLED
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
#include "scene/3d/audio_listener_3d.h"
Renamed 2D and 3D nodes to make their types explicit Fixes #30736.
2020-03-26 21:49:16 +00:00
#include "scene/3d/camera_3d.h"
#include "scene/3d/collision_object_3d.h"
Scene: Ensure classes match their header filename Also drop some unused files. Renamed: - `scene/2d/navigation2d.h` -> `navigation_2d.h` - `scene/2d/screen_button.h` -> `touch_screen_button.h` - `scene/3d/scenario_fx.h` -> `world_environment.h` - `scene/audio/audio_player.h` -> `audio_stream_player.h` - `scene/resources/bit_mask.h` -> `bit_map.h` - `scene/resources/color_ramp.h` -> `gradient.h` - `scene/resources/shape_line_2d.h` -> `line_shape_2d.h` - `scene/resources/scene_format_text.h` -> `resource_format_text.h` - `scene/resources/sky_box.h` -> `sky.h` Dropped: - `scene/resources/bounds.h`
2019-02-12 16:18:13 +00:00
#include "scene/3d/world_environment.h"
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#endif // _3D_DISABLED
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
#include "scene/gui/control.h"
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
#include "scene/gui/label.h"
Fix some unnecessary includes
2021-08-12 23:05:59 +00:00
#include "scene/gui/popup.h"
Fix tooltip message working incorrectly in PopupMenu fix
2021-08-20 09:49:19 +00:00
#include "scene/gui/popup_menu.h"
Update the minimum size of ViewportContainer
2020-11-21 21:32:26 +00:00
#include "scene/gui/subviewport_container.h"
Fix picking in CanvasLayer New APIs in 2D physics allow intersection queries filtered by CanvasLayer object instance id. Viewport keep an inventory of its descendant CanvasLayers and takes advantage of all that to test picking with the mouse/touch position correctly transformed for each CanvasLayer.
2018-08-24 22:03:26 +00:00
#include "scene/main/canvas_layer.h"
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
#include "scene/main/window.h"
Dead code tells no tales
2017-08-27 19:07:15 +00:00
#include "scene/resources/mesh.h"
Fix some unnecessary includes
2021-08-12 23:05:59 +00:00
#include "scene/resources/text_line.h"
#include "scene/resources/world_2d.h"
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
#include "scene/scene_string_names.h"
Do all audio mixing in the AudioServer
2021-08-27 17:28:23 +00:00
#include "servers/audio_server.h"
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
#include "servers/rendering/rendering_server_globals.h"
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
void ViewportTexture::setup_local_to_scene() {
Don't change `RID` when changing `viewport_path` in `ViewportTexture` When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder. Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
2023-05-18 14:49:10 +00:00
// For the same target viewport, setup is only allowed once to prevent multiple free or multiple creations.
if (!vp_changed) {
return;
}
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
if (vp_pending) {
return;
}
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 09:53:28 +00:00
Node *loc_scene = get_local_scene();
if (!loc_scene) {
Fix ViewportTexture error when viewport is used from a child scene Fix invalid errors when a separate child scene file contains a viewport and that viewport is used for a texture in the current scene. Fixes #27790.
2021-09-03 00:40:52 +00:00
return;
}
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
if (vp) {
vp->viewport_textures.erase(this);
Improve the UX of ViewportTexture in the editor The associated `ViewportTexture`s will update the `viewport_path` in time when the `Viewport`'s nodepath is changed (caused by renaming the node names or moving in the SceneTree dock). If the target `Viewport` is changed by resetting the `viewport_path`, the `ViewportTexture`s will be re-setup and emit `changed` signal in time.
2022-08-14 11:17:45 +00:00
vp = nullptr;
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
}
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
if (loc_scene->is_ready()) {
_setup_local_to_scene(loc_scene);
basic 2D engine is more or less working with Vulkan, including editor. Still a lot to do
2019-06-24 19:13:06 +00:00
} else {
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
loc_scene->connect(SNAME("ready"), callable_mp(this, &ViewportTexture::_setup_local_to_scene).bind(loc_scene), CONNECT_ONE_SHOT);
vp_pending = true;
basic 2D engine is more or less working with Vulkan, including editor. Still a lot to do
2019-06-24 19:13:06 +00:00
}
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
}
void ViewportTexture::set_viewport_path_in_scene(const NodePath &p_path) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (path == p_path) {
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
path = p_path;
Don't change `RID` when changing `viewport_path` in `ViewportTexture` When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder. Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
2023-05-18 14:49:10 +00:00
vp_changed = true;
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
Improve the UX of ViewportTexture in the editor The associated `ViewportTexture`s will update the `viewport_path` in time when the `Viewport`'s nodepath is changed (caused by renaming the node names or moving in the SceneTree dock). If the target `Viewport` is changed by resetting the `viewport_path`, the `ViewportTexture`s will be re-setup and emit `changed` signal in time.
2022-08-14 11:17:45 +00:00
if (vp) {
vp->viewport_textures.erase(this);
vp = nullptr;
}
Don't change `RID` when changing `viewport_path` in `ViewportTexture` When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder. Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
2023-05-18 14:49:10 +00:00
if (proxy.is_valid() && proxy_ph.is_null()) {
proxy_ph = RS::get_singleton()->texture_2d_placeholder_create();
RS::get_singleton()->texture_proxy_update(proxy, proxy_ph);
Improve the UX of ViewportTexture in the editor The associated `ViewportTexture`s will update the `viewport_path` in time when the `Viewport`'s nodepath is changed (caused by renaming the node names or moving in the SceneTree dock). If the target `Viewport` is changed by resetting the `viewport_path`, the `ViewportTexture`s will be re-setup and emit `changed` signal in time.
2022-08-14 11:17:45 +00:00
}
if (get_local_scene() && !path.is_empty()) {
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
setup_local_to_scene();
Improve the UX of ViewportTexture in the editor The associated `ViewportTexture`s will update the `viewport_path` in time when the `Viewport`'s nodepath is changed (caused by renaming the node names or moving in the SceneTree dock). If the target `Viewport` is changed by resetting the `viewport_path`, the `ViewportTexture`s will be re-setup and emit `changed` signal in time.
2022-08-14 11:17:45 +00:00
} else {
emit_changed();
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
}
}
NodePath ViewportTexture::get_viewport_path_in_scene() const {
return path;
}
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 04:26:35 +00:00
int ViewportTexture::get_width() const {
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
if (!vp) {
if (!vp_pending) {
ERR_PRINT("Viewport Texture must be set to use it.");
}
return 0;
}
Begining of GLES3 renderer: -Most 2D drawing is implemented -Missing shaders -Missing all 3D -Editor needs to be set on update always to be used, otherwise it does not refresh -Large parts of editor not working
2016-10-03 19:33:42 +00:00
return vp->size.width;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 04:26:35 +00:00
int ViewportTexture::get_height() const {
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
if (!vp) {
if (!vp_pending) {
ERR_PRINT("Viewport Texture must be set to use it.");
}
return 0;
}
Begining of GLES3 renderer: -Most 2D drawing is implemented -Missing shaders -Missing all 3D -Editor needs to be set on update always to be used, otherwise it does not refresh -Large parts of editor not working
2016-10-03 19:33:42 +00:00
return vp->size.height;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 04:26:35 +00:00
Size2 ViewportTexture::get_size() const {
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
if (!vp) {
if (!vp_pending) {
ERR_PRINT("Viewport Texture must be set to use it.");
}
return Size2();
}
Begining of GLES3 renderer: -Most 2D drawing is implemented -Missing shaders -Missing all 3D -Editor needs to be set on update always to be used, otherwise it does not refresh -Large parts of editor not working
2016-10-03 19:33:42 +00:00
return vp->size;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 04:26:35 +00:00
RID ViewportTexture::get_rid() const {
basic 2D engine is more or less working with Vulkan, including editor. Still a lot to do
2019-06-24 19:13:06 +00:00
if (proxy.is_null()) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
proxy_ph = RS::get_singleton()->texture_2d_placeholder_create();
proxy = RS::get_singleton()->texture_proxy_create(proxy_ph);
basic 2D engine is more or less working with Vulkan, including editor. Still a lot to do
2019-06-24 19:13:06 +00:00
}
-Implemented Proxy Textures (needed to solve the problem with ViewportTexture) -Properly use hierarchy to initialize resources local to scene (solves problem of GUI in 3D)
2017-12-04 18:55:20 +00:00
return proxy;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 04:26:35 +00:00
bool ViewportTexture::has_alpha() const {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return false;
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Rename Texture.get_data() to get_image()
2021-03-28 11:32:17 +00:00
Ref<Image> ViewportTexture::get_image() const {
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
if (!vp) {
if (!vp_pending) {
ERR_PRINT("Viewport Texture must be set to use it.");
}
return Ref<Image>();
}
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
return RS::get_singleton()->texture_2d_get(vp->texture_rid);
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
}
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
void ViewportTexture::_setup_local_to_scene(const Node *p_loc_scene) {
Fix that `ViewportTexture` cannot be setup again after failed setup `vp_pending` is a flag indicating to wait for `ViewportTexture::_setup_local_to_scene` to be called. Once this method is called, no matter whether the setup will fail or not, it needs to be reset to `false`.
2023-06-26 22:12:50 +00:00
// Always reset this, even if this call fails with an error.
vp_pending = false;
Use `get_node_or_null` when null checks are present Avoids duplicate or unnecessary errors
2023-06-05 12:56:54 +00:00
Node *vpn = p_loc_scene->get_node_or_null(path);
ERR_FAIL_NULL_MSG(vpn, "Path to node is invalid: '" + path + "'.");
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
vp = Object::cast_to<Viewport>(vpn);
Use `get_node_or_null` when null checks are present Avoids duplicate or unnecessary errors
2023-06-05 12:56:54 +00:00
ERR_FAIL_NULL_MSG(vp, "Path to node does not point to a viewport: '" + path + "'.");
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
vp->viewport_textures.insert(this);
ERR_FAIL_NULL(RenderingServer::get_singleton());
if (proxy_ph.is_valid()) {
RS::get_singleton()->texture_proxy_update(proxy, vp->texture_rid);
RS::get_singleton()->free(proxy_ph);
Don't change `RID` when changing `viewport_path` in `ViewportTexture` When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder. Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
2023-05-18 14:49:10 +00:00
proxy_ph = RID();
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
} else {
ERR_FAIL_COND(proxy.is_valid()); // Should be invalid.
proxy = RS::get_singleton()->texture_proxy_create(vp->texture_rid);
}
Don't change `RID` when changing `viewport_path` in `ViewportTexture` When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder. Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
2023-05-18 14:49:10 +00:00
vp_changed = false;
Improve the UX of ViewportTexture in the editor The associated `ViewportTexture`s will update the `viewport_path` in time when the `Viewport`'s nodepath is changed (caused by renaming the node names or moving in the SceneTree dock). If the target `Viewport` is changed by resetting the `viewport_path`, the `ViewportTexture`s will be re-setup and emit `changed` signal in time.
2022-08-14 11:17:45 +00:00
emit_changed();
Prevent errors when using ViewportTexture
2023-04-06 12:47:49 +00:00
}
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
void ViewportTexture::_bind_methods() {
Rename the _MD macro to D_METHOD This new name also makes its purpose a little clearer This is a step towards fixing #56
2017-02-13 11:47:24 +00:00
ClassDB::bind_method(D_METHOD("set_viewport_path_in_scene", "path"), &ViewportTexture::set_viewport_path_in_scene);
ClassDB::bind_method(D_METHOD("get_viewport_path_in_scene"), &ViewportTexture::get_viewport_path_in_scene);
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
fix `Window`derived nodes being unselectable for `ViewportTexture` `NodePath`
2023-05-21 14:28:41 +00:00
ADD_PROPERTY(PropertyInfo(Variant::NODE_PATH, "viewport_path", PROPERTY_HINT_NODE_PATH_VALID_TYPES, "Viewport", PROPERTY_USAGE_DEFAULT | PROPERTY_USAGE_NODE_PATH_FROM_SCENE_ROOT), "set_viewport_path_in_scene", "get_viewport_path_in_scene");
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
}
ViewportTexture::ViewportTexture() {
set_local_to_scene(true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
ViewportTexture::~ViewportTexture() {
if (vp) {
vp->viewport_textures.erase(this);
}
-Implemented Proxy Textures (needed to solve the problem with ViewportTexture) -Properly use hierarchy to initialize resources local to scene (solves problem of GUI in 3D)
2017-12-04 18:55:20 +00:00
Add safety-checks before some servers `free()`
2022-12-12 17:42:37 +00:00
ERR_FAIL_NULL(RenderingServer::get_singleton());
basic 2D engine is more or less working with Vulkan, including editor. Still a lot to do
2019-06-24 19:13:06 +00:00
if (proxy_ph.is_valid()) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->free(proxy_ph);
basic 2D engine is more or less working with Vulkan, including editor. Still a lot to do
2019-06-24 19:13:06 +00:00
}
Vulkan/RD rasterizer now does clean exit.
2019-07-29 21:19:31 +00:00
if (proxy.is_valid()) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->free(proxy);
Vulkan/RD rasterizer now does clean exit.
2019-07-29 21:19:31 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Remove NOTIFICATION_MOVED_IN_PARENT * This notification makes node children management very inefficient. * Replaced by a NOTIFICATION_CHILDREN_CHANGED (and children_changed signal). * Changed Canvas code (and similar) to use the above signal, to perform more efficiently. This PR breaks compatibility (although this notification was very rarely used, even within the engine), but provides an alternate way to do the same. It is required for the changes in #75627 to be entirely effective.
2023-04-05 16:53:32 +00:00
void Viewport::_process_dirty_canvas_parent_orders() {
for (const ObjectID &id : gui.canvas_parents_with_dirty_order) {
Object *obj = ObjectDB::get_instance(id);
if (!obj) {
continue; // May have been deleted.
}
Node *n = static_cast<Node *>(obj);
for (int i = 0; i < n->get_child_count(); i++) {
Node *c = n->get_child(i);
CanvasItem *ci = Object::cast_to<CanvasItem>(c);
if (ci) {
ci->update_draw_order();
continue;
}
CanvasLayer *cl = Object::cast_to<CanvasLayer>(c);
if (cl) {
cl->update_draw_order();
}
}
}
gui.canvas_parents_with_dirty_order.clear();
}
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
void Viewport::_sub_window_update_order() {
Update sub_windows order with respect to FLAG_ALWAYS_ON_TOP
2022-10-30 14:03:01 +00:00
if (gui.sub_windows.size() < 2) {
return;
}
if (!gui.sub_windows[gui.sub_windows.size() - 1].window->get_flag(Window::FLAG_ALWAYS_ON_TOP)) {
int index = gui.sub_windows.size() - 1;
while (index > 0 && gui.sub_windows[index - 1].window->get_flag(Window::FLAG_ALWAYS_ON_TOP)) {
--index;
}
if (index != (gui.sub_windows.size() - 1)) {
SubWindow sw = gui.sub_windows[gui.sub_windows.size() - 1];
gui.sub_windows.remove_at(gui.sub_windows.size() - 1);
gui.sub_windows.insert(index, sw);
}
}
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
for (int i = 0; i < gui.sub_windows.size(); i++) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->canvas_item_set_draw_index(gui.sub_windows[i].canvas_item, i);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
}
void Viewport::_sub_window_register(Window *p_window) {
ERR_FAIL_COND(!is_inside_tree());
for (int i = 0; i < gui.sub_windows.size(); i++) {
ERR_FAIL_COND(gui.sub_windows[i].window == p_window);
}
if (gui.sub_windows.size() == 0) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
subwindow_canvas = RS::get_singleton()->canvas_create();
RS::get_singleton()->viewport_attach_canvas(viewport, subwindow_canvas);
RS::get_singleton()->viewport_set_canvas_stacking(viewport, subwindow_canvas, SUBWINDOW_CANVAS_LAYER, 0);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
SubWindow sw;
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
sw.canvas_item = RS::get_singleton()->canvas_item_create();
RS::get_singleton()->canvas_item_set_parent(sw.canvas_item, subwindow_canvas);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
sw.window = p_window;
gui.sub_windows.push_back(sw);
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
if (gui.subwindow_drag == SUB_WINDOW_DRAG_DISABLED) {
Fix Tooltip getting removed instantly in embedded Window Tooltips are unfocusable Windows. This case was not handled correctly in `Viewport::_sub_window_register`.
2023-06-11 10:22:59 +00:00
if (p_window->get_flag(Window::FLAG_NO_FOCUS)) {
_sub_window_update_order();
} else {
_sub_window_grab_focus(p_window);
}
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
} else {
int index = _sub_window_find(gui.currently_dragged_subwindow);
sw = gui.sub_windows[index];
gui.sub_windows.remove_at(index);
gui.sub_windows.push_back(sw);
_sub_window_update_order();
}
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_parent_viewport(p_window->viewport, viewport);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
void Viewport::_sub_window_update(Window *p_window) {
Prevent subwindow_focused from pointing to a window that is not a subwindow
2022-08-30 19:57:03 +00:00
int index = _sub_window_find(p_window);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
ERR_FAIL_COND(index == -1);
const SubWindow &sw = gui.sub_windows[index];
Transform2D pos;
pos.set_origin(p_window->get_position());
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->canvas_item_clear(sw.canvas_item);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Rect2i r = Rect2i(p_window->get_position(), sw.window->get_size());
if (!p_window->get_flag(Window::FLAG_BORDERLESS)) {
Add a default theme for unfocused Windows At the moment it is impossible to distinguish between focused and unfocused embedded Windows. Add a new `theme_item` that is used for coloring the border of unfocused Windows.
2023-07-12 20:24:05 +00:00
Ref<StyleBox> panel = p_window->get_theme_stylebox(gui.subwindow_focused == p_window ? SNAME("embedded_border") : SNAME("embedded_unfocused_border"));
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
panel->draw(sw.canvas_item, r);
// Draw the title bar text.
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
Ref<Font> title_font = p_window->get_theme_font(SNAME("title_font"));
int font_size = p_window->get_theme_font_size(SNAME("title_font_size"));
Color title_color = p_window->get_theme_color(SNAME("title_color"));
int title_height = p_window->get_theme_constant(SNAME("title_height"));
Rename theme properties to include underscores - check_vadjust -> check_v_adjust - close_h_ofs -> close_h_offset - close_v_ofs -> close_v_offset - commentfocus -> comment_focus - hseparation -> h_separation - ofs -> offset - selectedframe -> selected_frame - state_machine_selectedframe -> state_machine_selected_frame - table_hseparation -> table_h_separation - table_vseparation -> table_v_separation - vseparation -> v_separation
2022-04-14 21:20:28 +00:00
int close_h_ofs = p_window->get_theme_constant(SNAME("close_h_offset"));
int close_v_ofs = p_window->get_theme_constant(SNAME("close_v_offset"));
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Refactor Font configuration and import UI, and Font resources.
2022-05-09 09:47:10 +00:00
TextLine title_text = TextLine(p_window->atr(p_window->get_title()), title_font, font_size);
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
title_text.set_width(r.size.width - panel->get_minimum_size().x - close_h_ofs);
title_text.set_direction(p_window->is_layout_rtl() ? TextServer::DIRECTION_RTL : TextServer::DIRECTION_LTR);
int x = (r.size.width - title_text.get_size().x) / 2;
int y = (-title_height - title_text.get_size().y) / 2;
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
Color font_outline_color = p_window->get_theme_color(SNAME("title_outline_modulate"));
int outline_size = p_window->get_theme_constant(SNAME("title_outline_size"));
[CTL] Add missing font outline drawing routines and theme constants.
2020-12-25 21:45:28 +00:00
if (outline_size > 0 && font_outline_color.a > 0) {
title_text.draw_outline(sw.canvas_item, r.position + Point2(x, y), outline_size, font_outline_color);
}
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
title_text.draw(sw.canvas_item, r.position + Point2(x, y), title_color);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Multiple cosmetic fixes for embedded windows
2021-07-28 02:32:03 +00:00
bool pressed = gui.subwindow_focused == sw.window && gui.subwindow_drag == SUB_WINDOW_DRAG_CLOSE && gui.subwindow_drag_close_inside;
Ref<Texture2D> close_icon = p_window->get_theme_icon(pressed ? "close_pressed" : "close");
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
close_icon->draw(sw.canvas_item, r.position + Vector2(r.size.width - close_h_ofs, -close_v_ofs));
}
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->canvas_item_add_texture_rect(sw.canvas_item, r, sw.window->get_texture()->get_rid());
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
void Viewport::_sub_window_grab_focus(Window *p_window) {
if (p_window == nullptr) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Release current focus.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (gui.subwindow_focused) {
gui.subwindow_focused->_event_callback(DisplayServer::WINDOW_EVENT_FOCUS_OUT);
gui.subwindow_focused = nullptr;
gui.subwindow_drag = SUB_WINDOW_DRAG_DISABLED;
}
Window *this_window = Object::cast_to<Window>(this);
if (this_window) {
this_window->_event_callback(DisplayServer::WINDOW_EVENT_FOCUS_IN);
}
return;
}
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
Prevent subwindow_focused from pointing to a window that is not a subwindow
2022-08-30 19:57:03 +00:00
int index = _sub_window_find(p_window);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
ERR_FAIL_COND(index == -1);
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
if (p_window->get_flag(Window::FLAG_NO_FOCUS)) {
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
// Release current focus.
if (gui.subwindow_focused) {
gui.subwindow_focused->_event_callback(DisplayServer::WINDOW_EVENT_FOCUS_OUT);
gui.subwindow_focused = nullptr;
gui.subwindow_drag = SUB_WINDOW_DRAG_DISABLED;
}
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Can only move to foreground, but no focus granted.
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
SubWindow sw = gui.sub_windows[index];
Rename `remove()` to `remove_at()` when removing by index
2021-07-03 22:17:03 +00:00
gui.sub_windows.remove_at(index);
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
gui.sub_windows.push_back(sw);
_sub_window_update_order();
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
return;
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
}
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (gui.subwindow_focused) {
if (gui.subwindow_focused == p_window) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
return; // Nothing to do.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
gui.subwindow_focused->_event_callback(DisplayServer::WINDOW_EVENT_FOCUS_OUT);
gui.subwindow_drag = SUB_WINDOW_DRAG_DISABLED;
} else {
Window *this_window = Object::cast_to<Window>(this);
if (this_window) {
this_window->_event_callback(DisplayServer::WINDOW_EVENT_FOCUS_OUT);
}
}
Window *old_focus = gui.subwindow_focused;
gui.subwindow_focused = p_window;
gui.subwindow_focused->_event_callback(DisplayServer::WINDOW_EVENT_FOCUS_IN);
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
{ // Move to foreground.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
SubWindow sw = gui.sub_windows[index];
Rename `remove()` to `remove_at()` when removing by index
2021-07-03 22:17:03 +00:00
gui.sub_windows.remove_at(index);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
gui.sub_windows.push_back(sw);
index = gui.sub_windows.size() - 1;
_sub_window_update_order();
}
if (old_focus) {
_sub_window_update(old_focus);
}
_sub_window_update(p_window);
}
void Viewport::_sub_window_remove(Window *p_window) {
Prevent subwindow_focused from pointing to a window that is not a subwindow
2022-08-30 19:57:03 +00:00
int index = _sub_window_find(p_window);
ERR_FAIL_COND(index == -1);
Add safety-checks before some servers `free()`
2022-12-12 17:42:37 +00:00
ERR_FAIL_NULL(RenderingServer::get_singleton());
Refactor mouse_entered and mouse_exited notifications The previous implementation for signals mouse_entered and mouse_exited had shortcomings that relate to focused windows and pressed mouse buttons. For example a Control can be hovered by mouse, even if it is occluded by an embedded window. This patch changes the behavior, so that Control and Viewport send their mouse-enter/exit-notifications based solely on mouse position, visible area, and input restrictions and not on which window has focus or which mouse buttons are pressed. This implicitly also changes when the mouse_entered and mouse_exited signals are sent. This functionality can not be implemented as a part of Viewport::_gui_input_event, because of its interplay with Windows and because Viewport::_gui_input_event is based on input and not on visibility.
2023-01-06 20:48:20 +00:00
SubWindow sw = gui.sub_windows[index];
if (gui.subwindow_over == sw.window) {
sw.window->_mouse_leave_viewport();
gui.subwindow_over = nullptr;
}
RS::get_singleton()->free(sw.canvas_item);
Prevent subwindow_focused from pointing to a window that is not a subwindow
2022-08-30 19:57:03 +00:00
gui.sub_windows.remove_at(index);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (gui.sub_windows.size() == 0) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->free(subwindow_canvas);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
subwindow_canvas = RID();
}
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
if (gui.currently_dragged_subwindow == p_window) {
gui.subwindow_drag = SUB_WINDOW_DRAG_DISABLED;
gui.currently_dragged_subwindow = nullptr;
}
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (gui.subwindow_focused == p_window) {
Prevent subwindow_focused from pointing to a window that is not a subwindow
2022-08-30 19:57:03 +00:00
Window *new_focused_window;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Window *parent_visible = p_window->get_parent_visible_window();
gui.subwindow_focused->_event_callback(DisplayServer::WINDOW_EVENT_FOCUS_OUT);
Prevent subwindow_focused from pointing to a window that is not a subwindow
2022-08-30 19:57:03 +00:00
if (parent_visible) {
new_focused_window = parent_visible;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
} else {
Prevent subwindow_focused from pointing to a window that is not a subwindow
2022-08-30 19:57:03 +00:00
new_focused_window = Object::cast_to<Window>(this);
}
if (new_focused_window) {
int new_focused_index = _sub_window_find(new_focused_window);
if (new_focused_index != -1) {
gui.subwindow_focused = new_focused_window;
} else {
gui.subwindow_focused = nullptr;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
Prevent subwindow_focused from pointing to a window that is not a subwindow
2022-08-30 19:57:03 +00:00
new_focused_window->_event_callback(DisplayServer::WINDOW_EVENT_FOCUS_IN);
} else {
gui.subwindow_focused = nullptr;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
}
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_parent_viewport(p_window->viewport, p_window->parent ? p_window->parent->viewport : RID());
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
Embedded Popups store their safe_rect in their embedder Storing it in the DisplayServer didn't make sense in this case, because the embedded window is unknown to the DisplayServer.
2023-06-20 13:50:44 +00:00
int Viewport::_sub_window_find(Window *p_window) const {
Prevent subwindow_focused from pointing to a window that is not a subwindow
2022-08-30 19:57:03 +00:00
for (int i = 0; i < gui.sub_windows.size(); i++) {
if (gui.sub_windows[i].window == p_window) {
return i;
}
}
return -1;
}
Improve the UX of ViewportTexture in the editor The associated `ViewportTexture`s will update the `viewport_path` in time when the `Viewport`'s nodepath is changed (caused by renaming the node names or moving in the SceneTree dock). If the target `Viewport` is changed by resetting the `viewport_path`, the `ViewportTexture`s will be re-setup and emit `changed` signal in time.
2022-08-14 11:17:45 +00:00
void Viewport::_update_viewport_path() {
if (viewport_textures.is_empty()) {
return;
}
Node *scene_root = get_scene_file_path().is_empty() ? get_owner() : this;
if (!scene_root && is_inside_tree()) {
scene_root = get_tree()->get_edited_scene_root();
}
if (scene_root && (scene_root == this || scene_root->is_ancestor_of(this))) {
NodePath path_in_scene = scene_root->get_path_to(this);
for (ViewportTexture *E : viewport_textures) {
E->path = path_in_scene;
}
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void Viewport::_notification(int p_what) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
switch (p_what) {
SceneMainLoop -> SceneTree -=-=-=-=-=-=-=-=-=-=-=-=-=- *YOUR SOURCE MIGHT NOT WORK* For mor information on fix: https://github.com/okamstudio/godot/wiki/devel_scene_tree Other stuff: -Shower of bullets demo -Fixes all around
2014-11-06 00:20:42 +00:00
case NOTIFICATION_ENTER_TREE: {
Improve the UX of ViewportTexture in the editor The associated `ViewportTexture`s will update the `viewport_path` in time when the `Viewport`'s nodepath is changed (caused by renaming the node names or moving in the SceneTree dock). If the target `Viewport` is changed by resetting the `viewport_path`, the `ViewportTexture`s will be re-setup and emit `changed` signal in time.
2022-08-14 11:17:45 +00:00
_update_viewport_path();
-fixed bug related to mouse cursor changes, fixes #3366
2016-01-18 22:49:11 +00:00
if (get_parent()) {
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 04:26:35 +00:00
parent = get_parent()->get_viewport();
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_parent_viewport(viewport, parent->get_viewport_rid());
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 04:26:35 +00:00
} else {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
parent = nullptr;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
current_canvas = find_world_2d()->get_canvas();
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_attach_canvas(viewport, current_canvas);
Fix CanvasTransform on RenderingServer when Viewport enters Tree Previously the Viewport didn't initialize its canvas transform in the RenderingServer.
2022-11-22 22:04:23 +00:00
RenderingServer::get_singleton()->viewport_set_canvas_transform(viewport, current_canvas, canvas_transform);
Viewport canvas cull mask feature Co-authored-by: Valentin Zagura <puthre@gmail.com>
2021-09-02 18:07:04 +00:00
RenderingServer::get_singleton()->viewport_set_canvas_cull_mask(viewport, canvas_cull_mask);
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
_update_audio_listener_2d();
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#ifndef _3D_DISABLED
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
RenderingServer::get_singleton()->viewport_set_scenario(viewport, find_world_3d()->get_scenario());
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
_update_audio_listener_3d();
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#endif // _3D_DISABLED
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
fixed stupid bug caused by accidentally removed line before commit
2015-09-20 20:29:36 +00:00
add_to_group("_viewports");
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
if (get_tree()->is_debugging_collisions_hint()) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
PhysicsServer2D::get_singleton()->space_set_debug_contacts(find_world_2d()->get_space(), get_tree()->get_collision_debug_contact_count());
contact_2d_debug = RenderingServer::get_singleton()->canvas_item_create();
Some code simplifications 1. `number_width` isn't used later 2. `return_type` is used only once 3. AudioServer::get_singleton()->get_channel_count() always returns a channel_count of 1 or larger 4. negative `aa->backward` conditional 5. `current_canvas` == `find_world_2d()->get_canvas()` 6. identical if `render_shadows`
2022-11-22 22:09:30 +00:00
RenderingServer::get_singleton()->canvas_item_set_parent(contact_2d_debug, current_canvas);
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#ifndef _3D_DISABLED
Change non-existent World to World3D
2020-04-18 09:00:51 +00:00
PhysicsServer3D::get_singleton()->space_set_debug_contacts(find_world_3d()->get_space(), get_tree()->get_collision_debug_contact_count());
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
contact_3d_debug_multimesh = RenderingServer::get_singleton()->multimesh_create();
Fix physics 2D/3D contact points rendering Physics internal process was removed by mistake, it's needed for contact points to be updated each frame. Fixed some multimesh parameters to allow 3D contact points to be drawn, although it's still not working well in 3D as only some of the contact points are drawn, and some of them keep being drawn when the number of visible instances drops to 0 instead of hiding them all.
2021-11-30 16:35:12 +00:00
RenderingServer::get_singleton()->multimesh_allocate_data(contact_3d_debug_multimesh, get_tree()->get_collision_debug_contact_count(), RS::MULTIMESH_TRANSFORM_3D, false);
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->multimesh_set_visible_instances(contact_3d_debug_multimesh, 0);
RenderingServer::get_singleton()->multimesh_set_mesh(contact_3d_debug_multimesh, get_tree()->get_debug_contact_mesh()->get_rid());
contact_3d_debug_instance = RenderingServer::get_singleton()->instance_create();
RenderingServer::get_singleton()->instance_set_base(contact_3d_debug_instance, contact_3d_debug_multimesh);
Change non-existent World to World3D
2020-04-18 09:00:51 +00:00
RenderingServer::get_singleton()->instance_set_scenario(contact_3d_debug_instance, find_world_3d()->get_scenario());
Fix physics 2D/3D contact points rendering Physics internal process was removed by mistake, it's needed for contact points to be updated each frame. Fixed some multimesh parameters to allow 3D contact points to be drawn, although it's still not working well in 3D as only some of the contact points are drawn, and some of them keep being drawn when the number of visible instances drops to 0 instead of hiding them all.
2021-11-30 16:35:12 +00:00
RenderingServer::get_singleton()->instance_geometry_set_flag(contact_3d_debug_instance, RS::INSTANCE_FLAG_DRAW_NEXT_FRAME_IF_VISIBLE, true);
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#endif // _3D_DISABLED
Fix physics 2D/3D contact points rendering Physics internal process was removed by mistake, it's needed for contact points to be updated each frame. Fixed some multimesh parameters to allow 3D contact points to be drawn, although it's still not working well in 3D as only some of the contact points are drawn, and some of them keep being drawn when the number of visible instances drops to 0 instead of hiding them all.
2021-11-30 16:35:12 +00:00
set_physics_process_internal(true);
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 17:06:48 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case NOTIFICATION_READY: {
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#ifndef _3D_DISABLED
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
if (audio_listener_3d_set.size() && !audio_listener_3d) {
AudioListener3D *first = nullptr;
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
for (AudioListener3D *E : audio_listener_3d_set) {
if (first == nullptr || first->is_greater_than(E)) {
first = E;
Added listener spatial node.
2016-03-20 02:10:04 +00:00
}
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (first) {
Added listener spatial node.
2016-03-20 02:10:04 +00:00
first->make_current();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Added listener spatial node.
2016-03-20 02:10:04 +00:00
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (camera_3d_set.size() && !camera_3d) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// There are cameras but no current camera, pick first in tree and make it current.
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
Camera3D *first = nullptr;
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
for (Camera3D *E : camera_3d_set) {
if (first == nullptr || first->is_greater_than(E)) {
first = E;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (first) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
first->make_current();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#endif // _3D_DISABLED
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 17:06:48 +00:00
SceneMainLoop -> SceneTree -=-=-=-=-=-=-=-=-=-=-=-=-=- *YOUR SOURCE MIGHT NOT WORK* For mor information on fix: https://github.com/okamstudio/godot/wiki/devel_scene_tree Other stuff: -Shower of bullets demo -Fixes all around
2014-11-06 00:20:42 +00:00
case NOTIFICATION_EXIT_TREE: {
-Changed how popups work in Viewport to make them a lot less invasive to the scene tree
2016-01-25 13:30:03 +00:00
_gui_cancel_tooltip();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_scenario(viewport, RID());
RenderingServer::get_singleton()->viewport_remove_canvas(viewport, current_canvas);
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
if (contact_2d_debug.is_valid()) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->free(contact_2d_debug);
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
contact_2d_debug = RID();
}
if (contact_3d_debug_multimesh.is_valid()) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->free(contact_3d_debug_multimesh);
RenderingServer::get_singleton()->free(contact_3d_debug_instance);
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
contact_3d_debug_instance = RID();
contact_3d_debug_multimesh = RID();
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
remove_from_group("_viewports");
Editor StringName and Viewport optimizations * Added explicit return type to the SNAME macro. * Add some extra SNAME usages. * Change some ClassDB methods to use const StringName & arguments. * Cache the Window parent in Control because it's used in is_layout_rtl(), which is called often. * Only enable internal processing for viewports that need it. * Change CanvasItem::group to be a StringName because it's only used as that.
2021-07-19 17:25:15 +00:00
set_physics_process_internal(false);
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 04:26:35 +00:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->viewport_set_active(viewport, false);
RenderingServer::get_singleton()->viewport_set_parent_viewport(viewport, RID());
Viewport: Fix missing tooltips w/ disabled physics object picking Previously this option seemed to be the sole responsible for enabling physics processing in Viewport, while several other features like tooltips and debugging collision hints rely on it. All this logic is moved to internal processing (it's incorrect to let it be affected by users disabling physics/idle processing), and disabling physics object picking no longer affects the internal physics processing. Fixes #17001.
2018-03-01 13:44:45 +00:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 17:06:48 +00:00
Improve the UX of ViewportTexture in the editor The associated `ViewportTexture`s will update the `viewport_path` in time when the `Viewport`'s nodepath is changed (caused by renaming the node names or moving in the SceneTree dock). If the target `Viewport` is changed by resetting the `viewport_path`, the `ViewportTexture`s will be re-setup and emit `changed` signal in time.
2022-08-14 11:17:45 +00:00
case NOTIFICATION_PATH_RENAMED: {
_update_viewport_path();
} break;
Viewport: Fix missing tooltips w/ disabled physics object picking Previously this option seemed to be the sole responsible for enabling physics processing in Viewport, while several other features like tooltips and debugging collision hints rely on it. All this logic is moved to internal processing (it's incorrect to let it be affected by users disabling physics/idle processing), and disabling physics object picking no longer affects the internal physics processing. Fixes #17001.
2018-03-01 13:44:45 +00:00
case NOTIFICATION_INTERNAL_PHYSICS_PROCESS: {
Added check for SceneTree being null
2021-12-13 08:55:52 +00:00
if (!get_tree()) {
return;
}
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
if (get_tree()->is_debugging_collisions_hint() && contact_2d_debug.is_valid()) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->canvas_item_clear(contact_2d_debug);
RenderingServer::get_singleton()->canvas_item_set_draw_index(contact_2d_debug, 0xFFFFF); //very high index
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
Vector<Vector2> points = PhysicsServer2D::get_singleton()->space_get_contacts(find_world_2d()->get_space());
int point_count = PhysicsServer2D::get_singleton()->space_get_contact_count(find_world_2d()->get_space());
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
Color ccol = get_tree()->get_debug_collision_contact_color();
for (int i = 0; i < point_count; i++) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->canvas_item_add_rect(contact_2d_debug, Rect2(points[i] - Vector2(2, 2), Vector2(5, 5)), ccol);
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
}
}
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#ifndef _3D_DISABLED
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
if (get_tree()->is_debugging_collisions_hint() && contact_3d_debug_multimesh.is_valid()) {
Change non-existent World to World3D
2020-04-18 09:00:51 +00:00
Vector<Vector3> points = PhysicsServer3D::get_singleton()->space_get_contacts(find_world_3d()->get_space());
int point_count = PhysicsServer3D::get_singleton()->space_get_contact_count(find_world_3d()->get_space());
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->multimesh_set_visible_instances(contact_3d_debug_multimesh, point_count);
Fix contact points debug for 3D Physics Setting each point's position was missing for 3D. Now enabling collision render debug will display contact points for 3D physics, the same way it does for 2D physics. Note: Multimesh rendering seems not to work in this scenario on master, but it's working fine on 3.2.
2021-02-10 01:36:38 +00:00
for (int i = 0; i < point_count; i++) {
Rename Transform to Transform3D in core
2020-10-17 05:08:21 +00:00
Transform3D point_transform;
Fix contact points debug for 3D Physics Setting each point's position was missing for 3D. Now enabling collision render debug will display contact points for 3D physics, the same way it does for 2D physics. Note: Multimesh rendering seems not to work in this scenario on master, but it's working fine on 3.2.
2021-02-10 01:36:38 +00:00
point_transform.origin = points[i];
RS::get_singleton()->multimesh_instance_set_transform(contact_3d_debug_multimesh, i, point_transform);
}
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
}
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#endif // _3D_DISABLED
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 17:06:48 +00:00
Connect notifications from Container to Viewport mouse enter+exit
2022-02-15 21:14:39 +00:00
case NOTIFICATION_VP_MOUSE_ENTER: {
Update variable name to reflect usage
2022-02-19 08:19:15 +00:00
gui.mouse_in_viewport = true;
Fix mouse_over not dropped when mouse leaves window
2021-04-24 12:03:38 +00:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 17:06:48 +00:00
Connect notifications from Container to Viewport mouse enter+exit
2022-02-15 21:14:39 +00:00
case NOTIFICATION_VP_MOUSE_EXIT: {
Update variable name to reflect usage
2022-02-19 08:19:15 +00:00
gui.mouse_in_viewport = false;
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
_drop_physics_mouseover();
Refactor mouse_entered and mouse_exited notifications The previous implementation for signals mouse_entered and mouse_exited had shortcomings that relate to focused windows and pressed mouse buttons. For example a Control can be hovered by mouse, even if it is occluded by an embedded window. This patch changes the behavior, so that Control and Viewport send their mouse-enter/exit-notifications based solely on mouse position, visible area, and input restrictions and not on which window has focus or which mouse buttons are pressed. This implicitly also changes when the mouse_entered and mouse_exited signals are sent. This functionality can not be implemented as a part of Viewport::_gui_input_event, because of its interplay with Windows and because Viewport::_gui_input_event is based on input and not on visibility.
2023-01-06 20:48:20 +00:00
// When the mouse exits the viewport, we don't want to end
// mouse_focus, because, for example, we want to continue
Update variable name to reflect usage
2022-02-19 08:19:15 +00:00
// dragging a scrollbar even if the mouse has left the viewport.
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 17:06:48 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
case NOTIFICATION_WM_WINDOW_FOCUS_OUT: {
Viewport cancels existing tooltip when window looses focus fixes #68197 when NOTIFICATION_WM_WINDOW_FOCUS_OUT is recieved by a viewport it will now call _gui_cancel_tooltip() to avoid it hanging around after the mouse events stop coming in
2022-11-09 11:48:19 +00:00
_gui_cancel_tooltip();
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
_drop_physics_mouseover();
if (gui.mouse_focus && !gui.forced_mouse_focus) {
_drop_mouse_focus();
}
Fix mouse_over not dropped when mouse leaves window
2021-04-24 12:03:38 +00:00
// When the window focus changes, we want to end mouse_focus, but
// not the mouse_over. Note: The OS will trigger a separate mouse
// exit event if the change in focus results in the mouse exiting
// the window.
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
} break;
Make sure to reset the tooltip of its gui_parent when the viewport is removed
2022-10-04 02:12:11 +00:00
case NOTIFICATION_PREDELETE: {
if (gui_parent) {
gui_parent->gui.tooltip_popup = nullptr;
gui_parent->gui.tooltip_label = nullptr;
}
} break;
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
}
}
void Viewport::_process_picking() {
if (!is_inside_tree()) {
return;
}
if (!physics_object_picking) {
return;
}
Simplify Viewport::_set_size `Viewport.to_screen_rect` is used only in a single location to compare it to `Rect2i()`. When called from `SubViewport`, `to_screen_rect` is always equal to `Rect2i()`. When called from `Window`, `to_screen_rect` is always different from `Rect2i()`. So the comparison `to_screen_rect != Rect2i()` can be replaced by `Object::cast_to<Window>(this)`. This allows the removal of `Viewport.to_screen_rect` and the simplification of `Viewport::_set_size`.
2023-02-02 18:00:07 +00:00
if (Object::cast_to<Window>(this) && Input::get_singleton()->get_mouse_mode() == Input::MOUSE_MODE_CAPTURED) {
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
return;
}
Fix execution of physics picking events Fix that physics picking can happen after the mouse has left the viewport
2022-02-27 22:57:51 +00:00
if (!gui.mouse_in_viewport) {
// Clear picking events if mouse has left viewport.
physics_picking_events.clear();
return;
}
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
_drop_physics_mouseover(true);
Ability to visually debug geometry visually: -Visible 2D and 3D Shapes, Polygons, Tile collisions, etc. -Visible Navmesh and Navpoly -Visible collision contacts for 2D and 3D as a red point -Customizable colors in project settings
2015-09-20 16:03:46 +00:00
Bring reusable variables out of while loop
2022-01-24 01:39:00 +00:00
#ifndef _3D_DISABLED
Vector2 last_pos(1e20, 1e20);
CollisionObject3D *last_object = nullptr;
ObjectID last_id;
PhysicsDirectSpaceState3D::RayResult result;
#endif // _3D_DISABLED
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
PhysicsDirectSpaceState2D *ss2d = PhysicsServer2D::get_singleton()->space_get_direct_state(find_world_2d()->get_space());
Fix physics passive hovering for some cases When the parent `SubViewportContainer` ignores mouse with `MOUSE_FILTER_IGNORE` and also when the mouse is over a `Control`-node, then the `SubViewport` shouldn't create mouse-move-events for passive hovering.
2023-07-13 21:23:08 +00:00
SubViewportContainer *parent_svc = Object::cast_to<SubViewportContainer>(get_parent());
bool parent_ignore_mouse = (parent_svc && parent_svc->get_mouse_filter() == Control::MOUSE_FILTER_IGNORE);
bool create_passive_hover_event = true;
if (gui.mouse_over || parent_ignore_mouse) {
// When the mouse is over a Control node, passive hovering would cause input events for Colliders, that are behind Control nodes.
// When parent SubViewportContainer ignores mouse, that setting should be respected.
create_passive_hover_event = false;
} else {
for (const Ref<InputEvent> &e : physics_picking_events) {
Ref<InputEventMouse> m = e;
if (m.is_valid()) {
// A mouse event exists, so passive hovering isn't necessary.
create_passive_hover_event = false;
break;
}
Fix passive mouse hovering for physics Currently mouse hovering doesn't update the state, when collision objects or the camera move. This PR fixes this problem by taking the mouse position from the viewport and not from a nonexistent previous event. Since previous events could potentially be a long time ago, their modifier-key state might be outdated. This PR fetches the current status of modifier-keys from `Input`. These changes allow the removal of some class-variables and making additional simplifications.
2023-06-08 19:04:38 +00:00
}
}
Fix physics passive hovering for some cases When the parent `SubViewportContainer` ignores mouse with `MOUSE_FILTER_IGNORE` and also when the mouse is over a `Control`-node, then the `SubViewport` shouldn't create mouse-move-events for passive hovering.
2023-07-13 21:23:08 +00:00
if (create_passive_hover_event) {
// Create a mouse motion event. This is necessary because objects or camera may have moved.
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// While this extra event is sent, it is checked if both camera and last object and last ID did not move.
// If nothing changed, the event is discarded to avoid flooding with unnecessary motion events every frame.
Fix passive mouse hovering for physics Currently mouse hovering doesn't update the state, when collision objects or the camera move. This PR fixes this problem by taking the mouse position from the viewport and not from a nonexistent previous event. Since previous events could potentially be a long time ago, their modifier-key state might be outdated. This PR fetches the current status of modifier-keys from `Input`. These changes allow the removal of some class-variables and making additional simplifications.
2023-06-08 19:04:38 +00:00
Ref<InputEventMouseMotion> mm;
mm.instantiate();
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
Fix passive mouse hovering for physics Currently mouse hovering doesn't update the state, when collision objects or the camera move. This PR fixes this problem by taking the mouse position from the viewport and not from a nonexistent previous event. Since previous events could potentially be a long time ago, their modifier-key state might be outdated. This PR fetches the current status of modifier-keys from `Input`. These changes allow the removal of some class-variables and making additional simplifications.
2023-06-08 19:04:38 +00:00
mm->set_device(InputEvent::DEVICE_ID_INTERNAL);
mm->set_position(get_mouse_position());
mm->set_global_position(mm->get_position());
mm->set_alt_pressed(Input::get_singleton()->is_key_pressed(Key::ALT));
mm->set_shift_pressed(Input::get_singleton()->is_key_pressed(Key::SHIFT));
mm->set_ctrl_pressed(Input::get_singleton()->is_key_pressed(Key::CTRL));
mm->set_meta_pressed(Input::get_singleton()->is_key_pressed(Key::META));
mm->set_button_mask(Input::get_singleton()->get_mouse_button_mask());
physics_picking_events.push_back(mm);
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
}
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
while (physics_picking_events.size()) {
Separate input-handled-state for different events during physics-picking Currently the input-handled-state for different events can interfere with each other. This PR makes sure, that the input_handled_state is reset before processing and InputEvent during physics-picking.
2023-07-16 12:36:18 +00:00
local_input_handled = false;
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
Ref<InputEvent> ev = physics_picking_events.front()->get();
physics_picking_events.pop_front();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
Vector2 pos;
bool is_mouse = false;
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
Ref<InputEventMouseMotion> mm = ev;
Improve/fix picking Acknowledge mouse button events as position tellers (to make picking more solid; for instance, the touch mouse is raised with a mouse unpressed event that may have a more current position) Forget mouse position for physics if touch mouse raised (because the position known as last is no longer meaningful) Remove needless check for mouse over/exit (now there's code to inject an spurious move for cases where camera/objects have moved) Restrict 2D mouse over/exit to mouse events (including emulated from touch; true touches shouldn't trigger the signals) Fixes #26460.
2019-03-05 21:31:02 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (mm.is_valid()) {
pos = mm->get_position();
is_mouse = true;
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
Ref<InputEventMouseButton> mb = ev;
Improve/fix picking Acknowledge mouse button events as position tellers (to make picking more solid; for instance, the touch mouse is raised with a mouse unpressed event that may have a more current position) Forget mouse position for physics if touch mouse raised (because the position known as last is no longer meaningful) Remove needless check for mouse over/exit (now there's code to inject an spurious move for cases where camera/objects have moved) Restrict 2D mouse over/exit to mouse events (including emulated from touch; true touches shouldn't trigger the signals) Fixes #26460.
2019-03-05 21:31:02 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (mb.is_valid()) {
pos = mb->get_position();
is_mouse = true;
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
Ref<InputEventScreenDrag> sd = ev;
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (sd.is_valid()) {
pos = sd->get_position();
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
Ref<InputEventScreenTouch> st = ev;
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (st.is_valid()) {
pos = st->get_position();
}
input events on Area2D is now supported also added a demo showing how this works
2015-03-22 04:46:18 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (ss2d) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Send to 2D.
input events on Area2D is now supported also added a demo showing how this works
2015-03-22 04:46:18 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
uint64_t frame = get_tree()->get_frame();
Fix picking in CanvasLayer New APIs in 2D physics allow intersection queries filtered by CanvasLayer object instance id. Viewport keep an inventory of its descendant CanvasLayers and takes advantage of all that to test picking with the mouse/touch position correctly transformed for each CanvasLayer.
2018-08-24 22:03:26 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
PhysicsDirectSpaceState2D::ShapeResult res[64];
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
for (const CanvasLayer *E : canvas_layers) {
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 09:53:28 +00:00
Transform2D canvas_layer_transform;
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
ObjectID canvas_layer_id;
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
if (E) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// A descendant CanvasLayer.
Include the following-viewport-transform into CanvasLayer transforms The following-viewport-transform was missing from several calculations
2022-10-07 10:17:10 +00:00
canvas_layer_transform = E->get_final_transform();
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
canvas_layer_id = E->get_instance_id();
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
} else {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// This Viewport's builtin canvas.
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 09:53:28 +00:00
canvas_layer_transform = get_canvas_transform();
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
canvas_layer_id = ObjectID();
}
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 09:53:28 +00:00
Vector2 point = canvas_layer_transform.affine_inverse().xform(pos);
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
Use parameter classes instead of arguments for all physics queries Same as what is already done for shape queries, applied to point and ray queries. Easier to document and more flexible to add more parameters. Also expose intersect_point method to script in 3D. Remove intersect_point_on_canvas in 2D, replaced with a parameter.
2021-11-02 01:00:58 +00:00
PhysicsDirectSpaceState2D::PointParameters point_params;
point_params.position = point;
point_params.canvas_instance_id = canvas_layer_id;
point_params.collide_with_areas = true;
point_params.pick_point = true;
int rc = ss2d->intersect_point(point_params, res, 64);
Fix propagation order for 2D physics picking events This patch adds a viewport-configuration-option for sorting physics-picking events by the Z-Index and the scene tree position of the collision objects.
2022-11-10 21:55:57 +00:00
if (physics_object_picking_sort) {
struct ComparatorCollisionObjects {
bool operator()(const PhysicsDirectSpaceState2D::ShapeResult &p_a, const PhysicsDirectSpaceState2D::ShapeResult &p_b) const {
CollisionObject2D *a = Object::cast_to<CollisionObject2D>(p_a.collider);
CollisionObject2D *b = Object::cast_to<CollisionObject2D>(p_b.collider);
if (!a || !b) {
return false;
}
int za = a->get_effective_z_index();
int zb = b->get_effective_z_index();
if (za != zb) {
return zb < za;
}
return a->is_greater_than(b);
}
};
SortArray<PhysicsDirectSpaceState2D::ShapeResult, ComparatorCollisionObjects> sorter;
sorter.sort(res, rc);
}
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
for (int i = 0; i < rc; i++) {
if (res[i].collider_id.is_valid() && res[i].collider) {
CollisionObject2D *co = Object::cast_to<CollisionObject2D>(res[i].collider);
if (co && co->can_process()) {
bool send_event = true;
if (is_mouse) {
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
HashMap<ObjectID, uint64_t>::Iterator F = physics_2d_mouseover.find(res[i].collider_id);
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (!F) {
physics_2d_mouseover.insert(res[i].collider_id, frame);
co->_mouse_enter();
} else {
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
F->value = frame;
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// It was already hovered, so don't send the event if it's faked.
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (mm.is_valid() && mm->get_device() == InputEvent::DEVICE_ID_INTERNAL) {
send_event = false;
Fix picking in CanvasLayer New APIs in 2D physics allow intersection queries filtered by CanvasLayer object instance id. Viewport keep an inventory of its descendant CanvasLayers and takes advantage of all that to test picking with the mouse/touch position correctly transformed for each CanvasLayer.
2018-08-24 22:03:26 +00:00
}
input events on Area2D is now supported also added a demo showing how this works
2015-03-22 04:46:18 +00:00
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
HashMap<Pair<ObjectID, int>, uint64_t, PairHash<ObjectID, int>>::Iterator SF = physics_2d_shape_mouseover.find(Pair(res[i].collider_id, res[i].shape));
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
if (!SF) {
physics_2d_shape_mouseover.insert(Pair(res[i].collider_id, res[i].shape), frame);
co->_mouse_shape_enter(res[i].shape);
} else {
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
SF->value = frame;
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
}
input events on Area2D is now supported also added a demo showing how this works
2015-03-22 04:46:18 +00:00
}
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (send_event) {
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
co->_input_event_call(this, ev, res[i].shape);
input events on Area2D is now supported also added a demo showing how this works
2015-03-22 04:46:18 +00:00
}
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
}
}
}
}
input events on Area2D is now supported also added a demo showing how this works
2015-03-22 04:46:18 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (is_mouse) {
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
_cleanup_mouseover_colliders(false, false, frame);
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
}
}
input events on Area2D is now supported also added a demo showing how this works
2015-03-22 04:46:18 +00:00
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#ifndef _3D_DISABLED
Fix event-content and mouse-signals with 3D-capture-on-drag Fix for 3D-physics processing: - with enabled input_capture_on_drag now report correct position and normals in _input_event - mouse_enter and mouse_exit signals are emitted when the mouse cursor leaves the visible area of the 3D-object, independently of pressed mouse button or input_capture_on_drag - make sure that collision input events are sent in the right order with respect to mouse_enter and mouse_exit signals
2022-10-29 08:05:52 +00:00
CollisionObject3D *capture_object = nullptr;
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (physics_object_capture.is_valid()) {
Fix event-content and mouse-signals with 3D-capture-on-drag Fix for 3D-physics processing: - with enabled input_capture_on_drag now report correct position and normals in _input_event - mouse_enter and mouse_exit signals are emitted when the mouse cursor leaves the visible area of the 3D-object, independently of pressed mouse button or input_capture_on_drag - make sure that collision input events are sent in the right order with respect to mouse_enter and mouse_exit signals
2022-10-29 08:05:52 +00:00
capture_object = Object::cast_to<CollisionObject3D>(ObjectDB::get_instance(physics_object_capture));
if (!capture_object || !camera_3d || (mb.is_valid() && mb->get_button_index() == MouseButton::LEFT && !mb->is_pressed())) {
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
physics_object_capture = ObjectID();
Fix Physics Picking captured Object initialization Initialize variables when a captured object is known.
2023-06-17 22:14:41 +00:00
} else {
last_id = physics_object_capture;
last_object = capture_object;
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
}
}
Fix event-content and mouse-signals with 3D-capture-on-drag Fix for 3D-physics processing: - with enabled input_capture_on_drag now report correct position and normals in _input_event - mouse_enter and mouse_exit signals are emitted when the mouse cursor leaves the visible area of the 3D-object, independently of pressed mouse button or input_capture_on_drag - make sure that collision input events are sent in the right order with respect to mouse_enter and mouse_exit signals
2022-10-29 08:05:52 +00:00
if (pos == last_pos) {
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (last_id.is_valid()) {
if (ObjectDB::get_instance(last_id) && last_object) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Good, exists.
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
_collision_object_3d_input_event(last_object, camera_3d, ev, result.position, result.normal, result.shape);
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (last_object->get_capture_input_on_drag() && mb.is_valid() && mb->get_button_index() == MouseButton::LEFT && mb->is_pressed()) {
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
physics_object_capture = last_id;
}
}
}
} else {
add viewport.get_camera_2d() * there is now a more clear distinction between camera_2d and camera_3d functions in the engine code * simplified camera2d's exported interface - now everything happens directly with the 'current' variable and make_current and clear_current are no longer exposed- there were some situations where calling one instead of set_current would result in incomplete results * rebased to current godot master
2020-04-28 15:04:07 +00:00
if (camera_3d) {
Vector3 from = camera_3d->project_ray_origin(pos);
Vector3 dir = camera_3d->project_ray_normal(pos);
fix hardcoded raycast distance with viewport object picking having the raycast distance hardcoded to `10000` caused input events to not be registered in very large 3D scenes. This resolves the issue by using the cameras far distance instead. Creating the more predictable behavior of if an object is visible, it will be picked by the viewport. resolves: #49735
2021-10-29 03:08:48 +00:00
real_t far = camera_3d->far;
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
PhysicsDirectSpaceState3D *space = PhysicsServer3D::get_singleton()->space_get_direct_state(find_world_3d()->get_space());
if (space) {
Use parameter classes instead of arguments for all physics queries Same as what is already done for shape queries, applied to point and ray queries. Easier to document and more flexible to add more parameters. Also expose intersect_point method to script in 3D. Remove intersect_point_on_canvas in 2D, replaced with a parameter.
2021-11-02 01:00:58 +00:00
PhysicsDirectSpaceState3D::RayParameters ray_params;
ray_params.from = from;
ray_params.to = from + dir * far;
ray_params.collide_with_areas = true;
ray_params.pick_ray = true;
bool col = space->intersect_ray(ray_params, result);
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
ObjectID new_collider;
Fix event-content and mouse-signals with 3D-capture-on-drag Fix for 3D-physics processing: - with enabled input_capture_on_drag now report correct position and normals in _input_event - mouse_enter and mouse_exit signals are emitted when the mouse cursor leaves the visible area of the 3D-object, independently of pressed mouse button or input_capture_on_drag - make sure that collision input events are sent in the right order with respect to mouse_enter and mouse_exit signals
2022-10-29 08:05:52 +00:00
CollisionObject3D *co = col ? Object::cast_to<CollisionObject3D>(result.collider) : nullptr;
if (co && co->can_process()) {
new_collider = result.collider_id;
if (!capture_object) {
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
last_object = co;
last_id = result.collider_id;
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (co->get_capture_input_on_drag() && mb.is_valid() && mb->get_button_index() == MouseButton::LEFT && mb->is_pressed()) {
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
physics_object_capture = last_id;
}
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
}
}
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (is_mouse && new_collider != physics_object_over) {
if (physics_object_over.is_valid()) {
Fix event-content and mouse-signals with 3D-capture-on-drag Fix for 3D-physics processing: - with enabled input_capture_on_drag now report correct position and normals in _input_event - mouse_enter and mouse_exit signals are emitted when the mouse cursor leaves the visible area of the 3D-object, independently of pressed mouse button or input_capture_on_drag - make sure that collision input events are sent in the right order with respect to mouse_enter and mouse_exit signals
2022-10-29 08:05:52 +00:00
CollisionObject3D *previous_co = Object::cast_to<CollisionObject3D>(ObjectDB::get_instance(physics_object_over));
if (previous_co) {
previous_co->_mouse_exit();
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
}
}
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
if (new_collider.is_valid()) {
Added assertion check
2023-01-26 15:10:32 +00:00
DEV_ASSERT(co);
Fix event-content and mouse-signals with 3D-capture-on-drag Fix for 3D-physics processing: - with enabled input_capture_on_drag now report correct position and normals in _input_event - mouse_enter and mouse_exit signals are emitted when the mouse cursor leaves the visible area of the 3D-object, independently of pressed mouse button or input_capture_on_drag - make sure that collision input events are sent in the right order with respect to mouse_enter and mouse_exit signals
2022-10-29 08:05:52 +00:00
co->_mouse_enter();
Improve/fix picking Acknowledge mouse button events as position tellers (to make picking more solid; for instance, the touch mouse is raised with a mouse unpressed event that may have a more current position) Forget mouse position for physics if touch mouse raised (because the position known as last is no longer meaningful) Remove needless check for mouse over/exit (now there's code to inject an spurious move for cases where camera/objects have moved) Restrict 2D mouse over/exit to mouse events (including emulated from touch; true touches shouldn't trigger the signals) Fixes #26460.
2019-03-05 21:31:02 +00:00
}
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
physics_object_over = new_collider;
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
}
Fix event-content and mouse-signals with 3D-capture-on-drag Fix for 3D-physics processing: - with enabled input_capture_on_drag now report correct position and normals in _input_event - mouse_enter and mouse_exit signals are emitted when the mouse cursor leaves the visible area of the 3D-object, independently of pressed mouse button or input_capture_on_drag - make sure that collision input events are sent in the right order with respect to mouse_enter and mouse_exit signals
2022-10-29 08:05:52 +00:00
if (capture_object) {
_collision_object_3d_input_event(capture_object, camera_3d, ev, result.position, result.normal, result.shape);
} else if (new_collider.is_valid()) {
_collision_object_3d_input_event(co, camera_3d, ev, result.position, result.normal, result.shape);
}
input events on Area2D is now supported also added a demo showing how this works
2015-03-22 04:46:18 +00:00
}
If the mouse is held on notification_wm_mouse_exit, do not drop focus This fixes a bug where users of the scrollbar had to be very careful not to move the mouse outside the viewport, otherwise the scrollbar would drop its drag-action and stop scrolling until clicked again. The existing behaviour had the side-effect of also dropping the cosmetic highlighting of the scrollbar (in addition to the dragging), for the specific case where the mouse was move outside the window. The previous behaviour did nothing to remove the highlight if the mouse was released (but not moved) inside the viewport. This separate issue with the lingering highlight of the scrollbar (until a mouse-movement action is performed inside the viewport) is fixed in an immediate followup to this commit. Closes bug #39634
2020-08-06 13:05:43 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
last_pos = pos;
Force button release when window focuses out, fixes #15318 and likely many other issues.
2018-01-05 18:39:10 +00:00
}
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
}
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#endif // _3D_DISABLED
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
removed duplicated functions in class hierarchy that were bound more than once added a check to detect this case in the future
2017-01-14 14:07:57 +00:00
RID Viewport::get_viewport_rid() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(RID());
remove trailing whitespace
2016-03-08 23:00:52 +00:00
return viewport;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Rewrite how font oversampling is updated more carefully, fixes #24338
2019-01-26 17:56:22 +00:00
void Viewport::update_canvas_items() {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!is_inside_tree()) {
Rewrite how font oversampling is updated more carefully, fixes #24338
2019-01-26 17:56:22 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Rewrite how font oversampling is updated more carefully, fixes #24338
2019-01-26 17:56:22 +00:00
_update_canvas_items(this);
}
Simplify Viewport::_set_size `Viewport.to_screen_rect` is used only in a single location to compare it to `Rect2i()`. When called from `SubViewport`, `to_screen_rect` is always equal to `Rect2i()`. When called from `Window`, `to_screen_rect` is always different from `Rect2i()`. So the comparison `to_screen_rect != Rect2i()` can be replaced by `Object::cast_to<Window>(this)`. This allows the removal of `Viewport.to_screen_rect` and the simplification of `Viewport::_set_size`.
2023-02-02 18:00:07 +00:00
void Viewport::_set_size(const Size2i &p_size, const Size2i &p_size_2d_override, bool p_allocated) {
Fix stretch transform when resizing SubViewports Move calculation of stretch transform from outside to inside of `Viewport::_set_size` function.
2022-10-13 00:17:04 +00:00
Transform2D stretch_transform_new = Transform2D();
if (is_size_2d_override_stretch_enabled() && p_size_2d_override.width > 0 && p_size_2d_override.height > 0) {
Size2 scale = Size2(p_size) / Size2(p_size_2d_override);
stretch_transform_new.scale(scale);
}
Fix crash in editor when setting `SubViewport.size` to zero `Viewport::_set_size` now verifies, that the minimum size is at least 2x2. Also fix `RendererViewport::viewport_set_size` fail condition.
2023-02-09 22:14:46 +00:00
Size2i new_size = p_size.max(Size2i(2, 2));
if (size == new_size && size_allocated == p_allocated && stretch_transform == stretch_transform_new && p_size_2d_override == size_2d_override) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
Fix crash in editor when setting `SubViewport.size` to zero `Viewport::_set_size` now verifies, that the minimum size is at least 2x2. Also fix `RendererViewport::viewport_set_size` fail condition.
2023-02-09 22:14:46 +00:00
size = new_size;
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
size_allocated = p_allocated;
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
size_2d_override = p_size_2d_override;
Fix stretch transform when resizing SubViewports Move calculation of stretch transform from outside to inside of `Viewport::_set_size` function.
2022-10-13 00:17:04 +00:00
stretch_transform = stretch_transform_new;
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
Fix XR rendering in 'opengl3' driver and expose true size via the Viewport node
2022-08-16 21:54:55 +00:00
#ifndef _3D_DISABLED
if (!use_xr) {
#endif
if (p_allocated) {
RS::get_singleton()->viewport_set_size(viewport, size.width, size.height);
} else {
RS::get_singleton()->viewport_set_size(viewport, 0, 0);
}
#ifndef _3D_DISABLED
} // if (!use_xr)
#endif
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
_update_global_transform();
Tweak the Viewport configuration warning to mention 2×2 size requirement
2021-10-01 14:36:28 +00:00
update_configuration_warnings();
-Much improvement to baked light baker -Fixed many bugs in stretch mode -Fixes to camera project and unproject as consequence of the above -added setget to script (documented in script doc) -more fixes to collada exporter for blender
2014-10-28 01:54:32 +00:00
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
update_canvas_items();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Fix Viewport size change not updating textures
2022-08-22 14:34:47 +00:00
for (ViewportTexture *E : viewport_textures) {
E->emit_changed();
}
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("size_changed"));
Apply clamp_to_embedder on parent resize and popup. Fixes #75084. The clamp_to_embedder setting was added in 8be16e0704873f0c9bab8c10dafe2607a00ff78f, but was not set on any of the in-editor dialogs. This patch sets `clamp_to_embedder` on editor dialogs so they cannot be dragged out of the frame. This also modifies `clamp_to_embedder` so a window is clamped to the bounds of an embedder when it pops up and when the parent is resized.
2023-03-19 16:26:22 +00:00
Rect2i limit = get_visible_rect();
for (int i = 0; i < gui.sub_windows.size(); ++i) {
Window *sw = gui.sub_windows[i].window;
Rect2i rect = Rect2i(sw->position, sw->size);
Rect2i new_rect = sw->fit_rect_in_parent(rect, limit);
if (new_rect != rect) {
sw->set_position(new_rect.position);
sw->set_size(new_rect.size);
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
Size2i Viewport::_get_size() const {
Fix XR rendering in 'opengl3' driver and expose true size via the Viewport node
2022-08-16 21:54:55 +00:00
#ifndef _3D_DISABLED
if (use_xr) {
if (XRServer::get_singleton() != nullptr) {
Ref<XRInterface> xr_interface = XRServer::get_singleton()->get_primary_interface();
if (xr_interface.is_valid() && xr_interface->is_initialized()) {
Size2 xr_size = xr_interface->get_render_target_size();
return (Size2i)xr_size;
}
}
return Size2i();
}
#endif // _3D_DISABLED
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
return size;
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
Size2i Viewport::_get_size_2d_override() const {
return size_2d_override;
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
bool Viewport::_is_size_allocated() const {
return size_allocated;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Rect2 Viewport::get_visible_rect() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Rect2());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Rect2 r;
remove trailing whitespace
2016-03-08 23:00:52 +00:00
Begining of GLES3 renderer: -Most 2D drawing is implemented -Missing shaders -Missing all 3D -Editor needs to be set on update always to be used, otherwise it does not refresh -Large parts of editor not working
2016-10-03 19:33:42 +00:00
if (size == Size2()) {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
r = Rect2(Point2(), DisplayServer::get_singleton()->window_get_size());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} else {
Begining of GLES3 renderer: -Most 2D drawing is implemented -Missing shaders -Missing all 3D -Editor needs to be set on update always to be used, otherwise it does not refresh -Large parts of editor not working
2016-10-03 19:33:42 +00:00
r = Rect2(Point2(), size);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
if (size_2d_override != Size2i()) {
r.size = size_2d_override;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
return r;
}
Remove NOTIFICATION_MOVED_IN_PARENT * This notification makes node children management very inefficient. * Replaced by a NOTIFICATION_CHILDREN_CHANGED (and children_changed signal). * Changed Canvas code (and similar) to use the above signal, to perform more efficiently. This PR breaks compatibility (although this notification was very rarely used, even within the engine), but provides an alternate way to do the same. It is required for the changes in #75627 to be entirely effective.
2023-04-05 16:53:32 +00:00
void Viewport::canvas_parent_mark_dirty(Node *p_node) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Remove NOTIFICATION_MOVED_IN_PARENT * This notification makes node children management very inefficient. * Replaced by a NOTIFICATION_CHILDREN_CHANGED (and children_changed signal). * Changed Canvas code (and similar) to use the above signal, to perform more efficiently. This PR breaks compatibility (although this notification was very rarely used, even within the engine), but provides an alternate way to do the same. It is required for the changes in #75627 to be entirely effective.
2023-04-05 16:53:32 +00:00
bool request_update = gui.canvas_parents_with_dirty_order.is_empty();
gui.canvas_parents_with_dirty_order.insert(p_node->get_instance_id());
if (request_update) {
MessageQueue::get_singleton()->push_callable(callable_mp(this, &Viewport::_process_dirty_canvas_parent_orders));
}
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
void Viewport::_update_audio_listener_2d() {
Prevent crash on startup if no audio server
2021-09-01 15:44:47 +00:00
if (AudioServer::get_singleton()) {
AudioServer::get_singleton()->notify_listener_changed();
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
void Viewport::set_as_audio_listener_2d(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
if (p_enable == is_audio_listener_2d_enabled) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
is_audio_listener_2d_enabled = p_enable;
_update_audio_listener_2d();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
bool Viewport::is_audio_listener_2d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
return is_audio_listener_2d_enabled;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
AudioListener2D *Viewport::get_audio_listener_2d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(nullptr);
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
return audio_listener_2d;
Add Listener2D
2020-12-31 20:34:09 +00:00
}
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
void Viewport::enable_canvas_transform_override(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
if (override_canvas_transform == p_enable) {
return;
}
override_canvas_transform = p_enable;
if (p_enable) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_canvas_transform(viewport, find_world_2d()->get_canvas(), canvas_transform_override);
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
} else {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_canvas_transform(viewport, find_world_2d()->get_canvas(), canvas_transform);
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
}
}
Fix various typos with codespell Also includes typo fixes from #79993, #80068, #80276, and #80303. Co-authored-by: betalars <contact@betalars.de> Co-authored-by: spaceyjase <429978+spaceyjase@users.noreply.github.com> Co-authored-by: Swarkin <102416174+Swarkin@users.noreply.github.com> Co-authored-by: Raul Santos <raulsntos@gmail.com>
2023-08-07 10:59:23 +00:00
bool Viewport::is_canvas_transform_override_enabled() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
return override_canvas_transform;
}
void Viewport::set_canvas_transform_override(const Transform2D &p_transform) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
if (canvas_transform_override == p_transform) {
return;
}
canvas_transform_override = p_transform;
if (override_canvas_transform) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_canvas_transform(viewport, find_world_2d()->get_canvas(), canvas_transform_override);
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
}
}
Transform2D Viewport::get_canvas_transform_override() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Transform2D());
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
return canvas_transform_override;
}
Type renames: Matrix32 -> Transform2D Matrix3 -> Basis AABB -> Rect3 RawArray -> PoolByteArray IntArray -> PoolIntArray FloatArray -> PoolFloatArray Vector2Array -> PoolVector2Array Vector3Array -> PoolVector3Array ColorArray -> PoolColorArray
2017-01-11 03:52:51 +00:00
void Viewport::set_canvas_transform(const Transform2D &p_transform) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
canvas_transform = p_transform;
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
if (!override_canvas_transform) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_canvas_transform(viewport, find_world_2d()->get_canvas(), canvas_transform);
Implement game camera override Implemented uniform API in Viewport class to override 2D and/or 3D camera. Added buttons in 2D and 3D editor viewport toolbars that override the running game camera transform with the editor viewport camera transform. Implemented via remote debugger protocol and camera override API. Removed LiveEditFuncs function pointers from ScriptDebugger class. Since the debugger got access to the SceneTree instance (if one exists), there is no need to store the function pointers. The live edit functions in SceneTree are used directly instead. Also removed the static version of live edit functions in SceneTree for the same reason. This reduced the SceneTree -> Debugger coupling too since the function pointers don't need to be set from SceneTree anymore. Moved script_debugger_remote.h/cpp from 'core/' to 'scene/debugger/'. This is because the remote debugger is now using SceneTree directly and 'core/' classes should not depend on 'scene/' classes.
2019-04-06 20:55:01 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Type renames: Matrix32 -> Transform2D Matrix3 -> Basis AABB -> Rect3 RawArray -> PoolByteArray IntArray -> PoolIntArray FloatArray -> PoolFloatArray Vector2Array -> PoolVector2Array Vector3Array -> PoolVector3Array ColorArray -> PoolColorArray
2017-01-11 03:52:51 +00:00
Transform2D Viewport::get_canvas_transform() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Transform2D());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return canvas_transform;
}
void Viewport::_update_global_transform() {
Type renames: Matrix32 -> Transform2D Matrix3 -> Basis AABB -> Rect3 RawArray -> PoolByteArray IntArray -> PoolIntArray FloatArray -> PoolFloatArray Vector2Array -> PoolVector2Array Vector3Array -> PoolVector3Array ColorArray -> PoolColorArray
2017-01-11 03:52:51 +00:00
Transform2D sxform = stretch_transform * global_canvas_transform;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_global_canvas_transform(viewport, sxform);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Type renames: Matrix32 -> Transform2D Matrix3 -> Basis AABB -> Rect3 RawArray -> PoolByteArray IntArray -> PoolIntArray FloatArray -> PoolFloatArray Vector2Array -> PoolVector2Array Vector3Array -> PoolVector3Array ColorArray -> PoolColorArray
2017-01-11 03:52:51 +00:00
void Viewport::set_global_canvas_transform(const Transform2D &p_transform) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
global_canvas_transform = p_transform;
_update_global_transform();
}
Type renames: Matrix32 -> Transform2D Matrix3 -> Basis AABB -> Rect3 RawArray -> PoolByteArray IntArray -> PoolIntArray FloatArray -> PoolFloatArray Vector2Array -> PoolVector2Array Vector3Array -> PoolVector3Array ColorArray -> PoolColorArray
2017-01-11 03:52:51 +00:00
Transform2D Viewport::get_global_canvas_transform() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Transform2D());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return global_canvas_transform;
}
add viewport.get_camera_2d() * there is now a more clear distinction between camera_2d and camera_3d functions in the engine code * simplified camera2d's exported interface - now everything happens directly with the 'current' variable and make_current and clear_current are no longer exposed- there were some situations where calling one instead of set_current would result in incomplete results * rebased to current godot master
2020-04-28 15:04:07 +00:00
void Viewport::_camera_2d_set(Camera2D *p_camera_2d) {
camera_2d = p_camera_2d;
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
void Viewport::_audio_listener_2d_set(AudioListener2D *p_listener) {
if (audio_listener_2d == p_listener) {
Add Listener2D
2020-12-31 20:34:09 +00:00
return;
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
} else if (audio_listener_2d) {
audio_listener_2d->clear_current();
Add Listener2D
2020-12-31 20:34:09 +00:00
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
audio_listener_2d = p_listener;
Add Listener2D
2020-12-31 20:34:09 +00:00
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
void Viewport::_audio_listener_2d_remove(AudioListener2D *p_listener) {
if (audio_listener_2d == p_listener) {
audio_listener_2d = nullptr;
Add Listener2D
2020-12-31 20:34:09 +00:00
}
}
Fix picking in CanvasLayer New APIs in 2D physics allow intersection queries filtered by CanvasLayer object instance id. Viewport keep an inventory of its descendant CanvasLayers and takes advantage of all that to test picking with the mouse/touch position correctly transformed for each CanvasLayer.
2018-08-24 22:03:26 +00:00
void Viewport::_canvas_layer_add(CanvasLayer *p_canvas_layer) {
canvas_layers.insert(p_canvas_layer);
}
void Viewport::_canvas_layer_remove(CanvasLayer *p_canvas_layer) {
canvas_layers.erase(p_canvas_layer);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void Viewport::set_transparent_background(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
transparent_bg = p_enable;
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->viewport_set_transparent_background(viewport, p_enable);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
bool Viewport::has_transparent_background() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return transparent_bg;
}
Add option to enable HDR rendering in 2D This is needed to allow 2D to fully make use of 3D effects (e.g. glow), and can be used to substantially improve quality of 2D rendering at the cost of performance Additionally, the 2D rendering pipeline is done in linear space (we skip linear_to_srgb conversion in 3D tonemapping) so the entire Viewport can be kept linear. This is necessary for proper HDR screen support in the future.
2023-08-03 12:10:01 +00:00
void Viewport::set_use_hdr_2d(bool p_enable) {
ERR_MAIN_THREAD_GUARD;
use_hdr_2d = p_enable;
RS::get_singleton()->viewport_set_use_hdr_2d(viewport, p_enable);
}
bool Viewport::is_using_hdr_2d() const {
ERR_READ_THREAD_GUARD_V(false);
return use_hdr_2d;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void Viewport::set_world_2d(const Ref<World2D> &p_world_2d) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (world_2d == p_world_2d) {
Restore viewport set_world_2d functionality
2016-07-13 18:51:38 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Restore viewport set_world_2d functionality
2016-07-13 18:51:38 +00:00
if (is_inside_tree()) {
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_remove_canvas(viewport, current_canvas);
Restore viewport set_world_2d functionality
2016-07-13 18:51:38 +00:00
}
Fix 2D audio in multiple viewports
2023-05-03 20:57:15 +00:00
if (world_2d.is_valid()) {
world_2d->remove_viewport(this);
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_world_2d.is_valid()) {
Propogate previously unused NOTIFICATION_WORLD_2D_CHANGED, make CanvasItem/CollisionObject2D use it
2022-01-25 03:01:59 +00:00
bool do_propagate = world_2d.is_valid() && is_inside_tree();
Restore viewport set_world_2d functionality
2016-07-13 18:51:38 +00:00
world_2d = p_world_2d;
Propogate previously unused NOTIFICATION_WORLD_2D_CHANGED, make CanvasItem/CollisionObject2D use it
2022-01-25 03:01:59 +00:00
if (do_propagate) {
_propagate_world_2d_changed(this);
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Allow Navigation to be more flexible
2021-03-15 11:45:28 +00:00
WARN_PRINT("Invalid world_2d");
Restore viewport set_world_2d functionality
2016-07-13 18:51:38 +00:00
world_2d = Ref<World2D>(memnew(World2D));
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Fix 2D audio in multiple viewports
2023-05-03 20:57:15 +00:00
world_2d->register_viewport(this);
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
_update_audio_listener_2d();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Restore viewport set_world_2d functionality
2016-07-13 18:51:38 +00:00
if (is_inside_tree()) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
current_canvas = find_world_2d()->get_canvas();
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_attach_canvas(viewport, current_canvas);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
Ref<World2D> Viewport::find_world_2d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Ref<World2D>());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (world_2d.is_valid()) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return world_2d;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else if (parent) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return parent->find_world_2d();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return Ref<World2D>();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
void Viewport::_propagate_viewport_notification(Node *p_node, int p_what) {
p_node->notification(p_what);
for (int i = 0; i < p_node->get_child_count(); i++) {
Node *c = p_node->get_child(i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (Object::cast_to<Viewport>(c)) {
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
_propagate_viewport_notification(c, p_what);
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
Ref<World2D> Viewport::get_world_2d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Ref<World2D>());
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return world_2d;
}
Camera2D *Viewport::get_camera_2d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(nullptr);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return camera_2d;
}
Transform2D Viewport::get_final_transform() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Transform2D());
Remove `Viewport::_get_input_pre_xform` This function is only relevant for `Window`. So this PR moves the functionality to the `Window`-class.
2023-02-02 18:28:14 +00:00
return stretch_transform * global_canvas_transform;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
Rework how current Camera2D is determined
2022-09-12 12:47:24 +00:00
void Viewport::assign_next_enabled_camera_2d(const StringName &p_camera_group) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Rework how current Camera2D is determined
2022-09-12 12:47:24 +00:00
List<Node *> camera_list;
get_tree()->get_nodes_in_group(p_camera_group, &camera_list);
Camera2D *new_camera = nullptr;
Fix Camera2D crashes
2023-02-01 22:32:13 +00:00
for (Node *E : camera_list) {
Camera2D *cam = Object::cast_to<Camera2D>(E);
Fix Camera2D crash due to ParallaxBackground node
2023-02-03 14:36:08 +00:00
if (!cam) {
continue; // Non-camera node (e.g. ParallaxBackground).
}
Rework how current Camera2D is determined
2022-09-12 12:47:24 +00:00
if (cam->is_enabled()) {
Fix Camera2D crashes
2023-02-01 22:32:13 +00:00
new_camera = cam;
Rework how current Camera2D is determined
2022-09-12 12:47:24 +00:00
break;
}
}
_camera_2d_set(new_camera);
if (!camera_2d) {
set_canvas_transform(Transform2D());
}
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
void Viewport::_update_canvas_items(Node *p_node) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (p_node != this) {
Update sub-viewport canvas items to ensure oversampling is applied correctly.
2022-03-29 07:44:09 +00:00
Window *w = Object::cast_to<Window>(p_node);
if (w && (!w->is_inside_tree() || !w->is_embedded())) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
CanvasItem *ci = Object::cast_to<CanvasItem>(p_node);
if (ci) {
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 21:21:24 +00:00
ci->queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
int cc = p_node->get_child_count();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
for (int i = 0; i < cc; i++) {
_update_canvas_items(p_node->get_child(i));
Viewport environment is updated properly when set to own world When own_world property is set, the viewport stores a unique resource for the world. With this change it keeps being updated from changes made to the world property instead of storing a default empty world with environment settings that can't be modified. Fixes #23412
2019-11-29 06:41:25 +00:00
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
Viewport environment is updated properly when set to own world When own_world property is set, the viewport stores a unique resource for the world. With this change it keeps being updated from changes made to the world property instead of storing a default empty world with environment settings that can't be modified. Fixes #23412
2019-11-29 06:41:25 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
Ref<ViewportTexture> Viewport::get_texture() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Ref<ViewportTexture>());
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return default_texture;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
void Viewport::set_positional_shadow_atlas_size(int p_size) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
positional_shadow_atlas_size = p_size;
RS::get_singleton()->viewport_set_positional_shadow_atlas_size(viewport, p_size, positional_shadow_atlas_16_bits);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
Viewport environment is updated properly when set to own world When own_world property is set, the viewport stores a unique resource for the world. With this change it keeps being updated from changes made to the world property instead of storing a default empty world with environment settings that can't be modified. Fixes #23412
2019-11-29 06:41:25 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
int Viewport::get_positional_shadow_atlas_size() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(0);
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
return positional_shadow_atlas_size;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
void Viewport::set_positional_shadow_atlas_16_bits(bool p_16_bits) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
if (positional_shadow_atlas_16_bits == p_16_bits) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
positional_shadow_atlas_16_bits = p_16_bits;
RS::get_singleton()->viewport_set_positional_shadow_atlas_size(viewport, positional_shadow_atlas_size, positional_shadow_atlas_16_bits);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
bool Viewport::get_positional_shadow_atlas_16_bits() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
return positional_shadow_atlas_16_bits;
Shadow map rendering optimization -All shadow rendering is done with raster now (no compute) -All shadow rendering is done by rendering directly to the shadow atlas -Improved how buffer clearing is done to optimize the above. -Ability to set shadows as 16 bits.
2021-01-24 19:00:20 +00:00
}
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
void Viewport::set_positional_shadow_atlas_quadrant_subdiv(int p_quadrant, PositionalShadowAtlasQuadrantSubdiv p_subdiv) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
all light types and shadows are working, pending a lot of clean-up
2016-11-10 02:55:06 +00:00
ERR_FAIL_INDEX(p_quadrant, 4);
ERR_FAIL_INDEX(p_subdiv, SHADOW_ATLAS_QUADRANT_SUBDIV_MAX);
A bit of everything: -IMA-ADPCM support for samples, this means that sound effects can be compressed and use 4 timess less RAM. -New 3D import workflow based on Wavefront OBJ. Import single objects as mesh resources instead of full scenes. Many people prefers to work this way. Just like the rest of the imported resources, these are updated in realtime if modified externally. -Mesh resources now support naming surfaces. This helps reimporting to identify which user-created materials must be kept. -Several fixes and improvements to SurfaceTool. -Anti Aliasing added to WorldEnvironment effects (using FXAA) -2D Physics bodies (RigidBody, KinematicBody, etc), Raycasts, Tilemap, etc support collision layers. This makes easy to group which objects collide against which. -2D Trigger shapes can now also trigger collision reporting in other 2D bodies (it used to be in Area2D before) -Viewport render target textures can now be filtered. -Few fixes in GDscript make it easier to work with static functions and class members. -Several and many bugfixes.
2014-05-14 04:22:15 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
if (positional_shadow_atlas_quadrant_subdiv[p_quadrant] == p_subdiv) {
all light types and shadows are working, pending a lot of clean-up
2016-11-10 02:55:06 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A bit of everything: -IMA-ADPCM support for samples, this means that sound effects can be compressed and use 4 timess less RAM. -New 3D import workflow based on Wavefront OBJ. Import single objects as mesh resources instead of full scenes. Many people prefers to work this way. Just like the rest of the imported resources, these are updated in realtime if modified externally. -Mesh resources now support naming surfaces. This helps reimporting to identify which user-created materials must be kept. -Several fixes and improvements to SurfaceTool. -Anti Aliasing added to WorldEnvironment effects (using FXAA) -2D Physics bodies (RigidBody, KinematicBody, etc), Raycasts, Tilemap, etc support collision layers. This makes easy to group which objects collide against which. -2D Trigger shapes can now also trigger collision reporting in other 2D bodies (it used to be in Area2D before) -Viewport render target textures can now be filtered. -Few fixes in GDscript make it easier to work with static functions and class members. -Several and many bugfixes.
2014-05-14 04:22:15 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
positional_shadow_atlas_quadrant_subdiv[p_quadrant] = p_subdiv;
all light types and shadows are working, pending a lot of clean-up
2016-11-10 02:55:06 +00:00
static const int subdiv[SHADOW_ATLAS_QUADRANT_SUBDIV_MAX] = { 0, 1, 4, 16, 64, 256, 1024 };
Little Bits -=-=-=-=-=- -Fixed small bugs all around -Added ability to show/hide entire sections of the spatial (3D) tree -WIP new vehicle (not ready yet) based on Bullet
2014-08-14 13:31:38 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
RS::get_singleton()->viewport_set_positional_shadow_atlas_quadrant_subdivision(viewport, p_quadrant, subdiv[p_subdiv]);
Little Bits -=-=-=-=-=- -Fixed small bugs all around -Added ability to show/hide entire sections of the spatial (3D) tree -WIP new vehicle (not ready yet) based on Bullet
2014-08-14 13:31:38 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
Viewport::PositionalShadowAtlasQuadrantSubdiv Viewport::get_positional_shadow_atlas_quadrant_subdiv(int p_quadrant) const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(SHADOW_ATLAS_QUADRANT_SUBDIV_DISABLED);
all light types and shadows are working, pending a lot of clean-up
2016-11-10 02:55:06 +00:00
ERR_FAIL_INDEX_V(p_quadrant, 4, SHADOW_ATLAS_QUADRANT_SUBDIV_DISABLED);
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
return positional_shadow_atlas_quadrant_subdiv[p_quadrant];
all light types and shadows are working, pending a lot of clean-up
2016-11-10 02:55:06 +00:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Ref<InputEvent> Viewport::_make_input_local(const Ref<InputEvent> &ev) {
Executing AcceptDialog.push_input no longer crashes
2021-10-09 20:30:14 +00:00
if (ev.is_null()) {
return ev; // No transformation defined for null event
}
-Fixed a few bugs in Viewport -Made a few demos using Viewport to show it's true power! -Fixed some start-up error messages.
2014-04-10 03:18:27 +00:00
Include the Window-transform into Viewport::get_final_transform
2022-10-01 06:40:11 +00:00
Transform2D ai = get_final_transform().affine_inverse();
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
return ev->xformed_by(ai);
-Fixed a few bugs in Viewport -Made a few demos using Viewport to show it's true power! -Fixed some start-up error messages.
2014-04-10 03:18:27 +00:00
}
Rename [gs]et_pos to [gs]et_position for Controls Control set_pos -> set_position Control set_global_pos -> set_global_position [gs]et_mouse_pos -> [gs]et_mouse_position [gs]et_global_mouse_pos -> [gs]et_global_mouse_position fixes #8005
2017-03-29 15:29:38 +00:00
Vector2 Viewport::get_mouse_position() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Vector2());
Fix mouse position with screen transform When a Viewport is not directly attached to the screen, the function `Viewport::get_mouse_position` can't rely on `get_screen_transform`, because that function is ambiguous in these situations. In these cases it is necessary to use the mouse position from the most recent mouse IputEvent.
2023-06-06 18:42:41 +00:00
if (!is_directly_attached_to_screen()) {
// Rely on the most recent mouse coordinate from an InputEventMouse in push_input.
// In this case get_screen_transform is not applicable, because it is ambiguous.
return gui.last_mouse_pos;
} else if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_MOUSE)) {
Add determinant check for minimized windows When the Window is minimized, the transform-determinant can be 0. Add a check to prevent this case.
2023-07-21 22:02:37 +00:00
Transform2D xform = get_screen_transform_internal(true);
if (xform.determinant() == 0) {
// Screen transform can be non-invertible when the Window is minimized.
return Vector2();
}
return xform.affine_inverse().xform(DisplayServer::get_singleton()->mouse_get_position());
Fix Viewport::get_mouse_position for SubViewports SubViewports don't have a cached mouse position available. This PR calculates the mouse position from the screen position of the mouse cursor.
2023-01-20 21:33:05 +00:00
} else {
// Fallback to Input for getting mouse position in case of emulated mouse.
return get_screen_transform_internal().affine_inverse().xform(Input::get_singleton()->get_mouse_position());
}
-Added lookat/get_angle_to functions in 2D, and a demo, closes #1843 -Added get_viewport().get_mouse_pos() to replace Input.get_mouse_pos(), closes #1838
2015-05-12 11:17:09 +00:00
}
Rename warp mouse functions to warp_mouse
2022-03-27 09:17:36 +00:00
void Viewport::warp_mouse(const Vector2 &p_position) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Fix Viewport::get_mouse_position for SubViewports SubViewports don't have a cached mouse position available. This PR calculates the mouse position from the screen position of the mouse cursor.
2023-01-20 21:33:05 +00:00
Transform2D xform = get_screen_transform_internal();
Fix warp_mouse for transient windows, smoother mouse positioning when releasing mouse for spinbox
2022-08-18 09:16:29 +00:00
Vector2 gpos = xform.xform(p_position);
Rename warp mouse functions to warp_mouse
2022-03-27 09:17:36 +00:00
Input::get_singleton()->warp_mouse(gpos);
fixes to mouse warp -can warp now from viewport and control, in their respective coordinate systems -warp is now local to the window on Windows and OSX. IF YOU RUN OSX, PLEASE TEST THIS! And make sure it works!, new code is in OS_OSX::warp_mouse_pos. I don't have OSX so i can't test!
2015-02-14 22:22:06 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
void Viewport::_gui_sort_roots() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!gui.roots_order_dirty) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
gui.roots.sort_custom<Control::CComparator>();
gui.roots_order_dirty = false;
}
void Viewport::_gui_cancel_tooltip() {
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
gui.tooltip_control = nullptr;
Show tooltips even when paused or time_scale is 0
2021-02-26 23:37:20 +00:00
if (gui.tooltip_timer.is_valid()) {
gui.tooltip_timer->release_connections();
gui.tooltip_timer = Ref<SceneTreeTimer>();
}
-Changed how popups work in Viewport to make them a lot less invasive to the scene tree
2016-01-25 13:30:03 +00:00
if (gui.tooltip_popup) {
Rename queue_delete => queue_free # Conflicts: # editor/plugins/tiles/tiles_editor_plugin.cpp
2022-10-24 21:07:02 +00:00
gui.tooltip_popup->queue_free();
-Changed how popups work in Viewport to make them a lot less invasive to the scene tree
2016-01-25 13:30:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
String Viewport::_gui_get_tooltip(Control *p_control, const Vector2 &p_pos, Control **r_tooltip_owner) {
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
Vector2 pos = p_pos;
String tooltip;
while (p_control) {
tooltip = p_control->get_tooltip(pos);
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Temporary solution for PopupMenus.
Fix tooltip message working incorrectly in PopupMenu fix
2021-08-20 09:49:19 +00:00
PopupMenu *menu = Object::cast_to<PopupMenu>(this);
if (menu) {
tooltip = menu->get_tooltip(pos);
}
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
if (r_tooltip_owner) {
*r_tooltip_owner = p_control;
-Fix tooltips in inspector, now they show as rich text.
2018-07-20 21:14:33 +00:00
}
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
// If we found a tooltip, we stop here.
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (!tooltip.is_empty()) {
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
// Otherwise, we check parent controls unless some conditions prevent it.
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_control->data.mouse_filter == Control::MOUSE_FILTER_STOP) {
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
if (p_control->is_set_as_top_level()) {
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
// Transform cursor pos for parent control.
pos = p_control->get_transform().xform(pos);
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
p_control = p_control->get_parent_control();
}
return tooltip;
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
void Viewport::_gui_show_tooltip() {
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
if (!gui.tooltip_control) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
return;
}
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
// Get the Control under cursor and the relevant tooltip text, if any.
Control *tooltip_owner = nullptr;
String tooltip_text = _gui_get_tooltip(
gui.tooltip_control,
Fix bad mouse offset to show tooltips in Tree
2021-12-12 08:12:26 +00:00
gui.tooltip_control->get_global_transform().xform_inv(gui.last_mouse_pos),
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
&tooltip_owner);
Tooltips: Fix unassigned strip_edges() call on text Fixes #43940, was a regression from #43280.
2021-01-05 14:14:27 +00:00
tooltip_text = tooltip_text.strip_edges();
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (tooltip_text.is_empty()) {
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
return; // Nothing to show.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
// Remove previous popup if we change something.
-Changed how popups work in Viewport to make them a lot less invasive to the scene tree
2016-01-25 13:30:03 +00:00
if (gui.tooltip_popup) {
memdelete(gui.tooltip_popup);
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
if (!tooltip_owner) {
Fixed segfault when hovering over scene tree elements and showing tooltips.
2017-08-21 01:48:03 +00:00
return;
}
Made default tooltips (non-custom ones) disappear on mouse enter. Matches 3.X behaviour, but does not break custom tooltips where mouse interaction is needed.
2021-04-25 14:53:50 +00:00
// Popup window which houses the tooltip content.
Remove TooltipPanel and TooltipLabel
2022-06-09 20:23:11 +00:00
PopupPanel *panel = memnew(PopupPanel);
panel->set_theme_type_variation(SNAME("TooltipPanel"));
Made default tooltips (non-custom ones) disappear on mouse enter. Matches 3.X behaviour, but does not break custom tooltips where mouse interaction is needed.
2021-04-25 14:53:50 +00:00
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
// Controls can implement `make_custom_tooltip` to provide their own tooltip.
// This should be a Control node which will be added as child to a TooltipPanel.
Control *base_tooltip = tooltip_owner->make_custom_tooltip(tooltip_text);
-Fix tooltips in inspector, now they show as rich text.
2018-07-20 21:14:33 +00:00
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
// If no custom tooltip is given, use a default implementation.
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
if (!base_tooltip) {
Remove TooltipPanel and TooltipLabel
2022-06-09 20:23:11 +00:00
gui.tooltip_label = memnew(Label);
gui.tooltip_label->set_theme_type_variation(SNAME("TooltipLabel"));
Add `auto_translate` toggle for automatic translation
2021-05-27 17:31:33 +00:00
gui.tooltip_label->set_auto_translate(gui.tooltip_control->is_auto_translating());
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
gui.tooltip_label->set_text(tooltip_text);
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
base_tooltip = gui.tooltip_label;
Made default tooltips (non-custom ones) disappear on mouse enter. Matches 3.X behaviour, but does not break custom tooltips where mouse interaction is needed.
2021-04-25 14:53:50 +00:00
panel->connect("mouse_entered", callable_mp(this, &Viewport::_gui_cancel_tooltip));
-Fix tooltips in inspector, now they show as rich text.
2018-07-20 21:14:33 +00:00
}
-Changed how popups work in Viewport to make them a lot less invasive to the scene tree
2016-01-25 13:30:03 +00:00
Rename Control PRESET_WIDE to PRESET_FULL_RECT
2022-03-19 00:02:57 +00:00
base_tooltip->set_anchors_and_offsets_preset(Control::PRESET_FULL_RECT);
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
[Windows] Add WS_BORDER flag to windows in WINDOW_MODE_FULLSCREEN mode to allow multi-window interface in full-screen. [Windows] Add WINDOW_MODE_EXCLUSIVE_FULLSCREEN without WS_BORDER flag enabled (no multi-window support).
2022-01-28 09:19:53 +00:00
panel->set_transient(true);
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
panel->set_flag(Window::FLAG_NO_FOCUS, true);
Improve popup window handling. Add window FLAG_POPUP and a platform specific routines to control popup auto-hiding and event forwarding.
2022-02-24 09:21:23 +00:00
panel->set_flag(Window::FLAG_POPUP, false);
Add `WINDOW_FLAG_MOUSE_PASSTHROUGH` flag and enabled it for tooltips. Expose `window_set_mouse_passthrough` to `Window`.
2023-01-15 10:05:25 +00:00
panel->set_flag(Window::FLAG_MOUSE_PASSTHROUGH, true);
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
panel->set_wrap_controls(true);
panel->add_child(base_tooltip);
Make sure to reset the tooltip of its gui_parent when the viewport is removed
2022-10-04 02:12:11 +00:00
panel->gui_parent = this;
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
gui.tooltip_popup = panel;
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
tooltip_owner->add_child(gui.tooltip_popup);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 14:43:37 +00:00
Point2 tooltip_offset = GLOBAL_GET("display/mouse_cursor/tooltip_position_offset");
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
Rect2 r(gui.tooltip_pos + tooltip_offset, gui.tooltip_popup->get_contents_minimum_size());
Prevent windows from having a size greater than device limit
2022-08-21 22:16:56 +00:00
r.size = r.size.min(panel->get_max_size());
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
Make tooltips appear on the same display as the editor The `current_screen` field was never being set on tooptip windows, leading to scenarios where, if the editor wasn't on screen 0, tooltips may not appear in the right place, especially when your screens have different resolutions.
2020-08-20 12:08:28 +00:00
Window *window = gui.tooltip_popup->get_parent_visible_window();
Fix invalid tooltip position
2022-10-07 17:14:41 +00:00
Rect2i vr;
if (gui.tooltip_popup->is_embedded()) {
Fix Color Picking With the 4.x-introduction of Windows the previous method for color picking was no longer working. This PR uses the following approach to reintroduce color-picking. When the Color-Picking-Button is pressed, a quasi-screenshot of the Window-content is created and displayed in a new Popup-Window. This new Window allows selecting colors by Mouse-Click. A Preview of the targeted Color is also displayed.
2023-02-05 16:35:39 +00:00
vr = gui.tooltip_popup->get_embedder()->get_visible_rect();
Fix invalid tooltip position
2022-10-07 17:14:41 +00:00
} else {
vr = window->get_usable_parent_rect();
}
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (r.size.x + r.position.x > vr.size.x + vr.position.x) {
Make tooltips be shown at different directions if there's not enough space
2022-07-23 17:51:06 +00:00
// Place it in the opposite direction. If it fails, just hug the border.
r.position.x = gui.tooltip_pos.x - r.size.x - tooltip_offset.x;
if (r.position.x < vr.position.x) {
r.position.x = vr.position.x + vr.size.x - r.size.x;
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else if (r.position.x < vr.position.x) {
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
r.position.x = vr.position.x;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (r.size.y + r.position.y > vr.size.y + vr.position.y) {
Make tooltips be shown at different directions if there's not enough space
2022-07-23 17:51:06 +00:00
// Same as above.
r.position.y = gui.tooltip_pos.y - r.size.y - tooltip_offset.y;
if (r.position.y < vr.position.y) {
r.position.y = vr.position.y + vr.size.y - r.size.y;
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else if (r.position.y < vr.position.y) {
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
r.position.y = vr.position.y;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
gui.tooltip_popup->set_position(r.position);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
gui.tooltip_popup->set_size(r.size);
Improve popup window handling. Add window FLAG_POPUP and a platform specific routines to control popup auto-hiding and event forwarding.
2022-02-24 09:21:23 +00:00
DisplayServer::WindowID active_popup = DisplayServer::get_singleton()->window_get_active_popup();
if (active_popup == DisplayServer::INVALID_WINDOW_ID || active_popup == window->get_window_id()) {
gui.tooltip_popup->show();
}
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
gui.tooltip_popup->child_controls_changed();
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
bool Viewport::_gui_call_input(Control *p_control, const Ref<InputEvent> &p_input) {
bool stopped = false;
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Ref<InputEvent> ev = p_input;
Properly deliver localized coordinates when passing gui events through parents, closes #4215
2016-06-27 12:59:43 +00:00
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
// Returns true if an event should be impacted by a control's mouse filter.
Fix MOUSE_FILTER_STOP not affecting emulated mouse events Touch and Drag events are now stopped by MOUSE_FILTER_STOP
2023-01-19 13:56:32 +00:00
bool is_pointer_event = Ref<InputEventMouse>(p_input).is_valid() || Ref<InputEventScreenDrag>(p_input).is_valid() || Ref<InputEventScreenTouch>(p_input).is_valid();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
Ref<InputEventMouseButton> mb = p_input;
bool is_scroll_event = mb.is_valid() &&
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
(mb->get_button_index() == MouseButton::WHEEL_DOWN ||
mb->get_button_index() == MouseButton::WHEEL_UP ||
mb->get_button_index() == MouseButton::WHEEL_LEFT ||
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
mb->get_button_index() == MouseButton::WHEEL_RIGHT);
Allow mouse wheel to go throuhgh so scroll containers work properly, fixes #4431
2016-06-20 20:16:52 +00:00
Fix indentation issues in last commits Ping @reduz.
2016-06-07 05:39:40 +00:00
CanvasItem *ci = p_control;
while (ci) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
Control *control = Object::cast_to<Control>(ci);
Fix indentation issues in last commits Ping @reduz.
2016-06-07 05:39:40 +00:00
if (control) {
Do not allow controls in ignore mouse to get focus via their children, fixes #17955
2018-11-16 16:46:42 +00:00
if (control->data.mouse_filter != Control::MOUSE_FILTER_IGNORE) {
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
control->_call_gui_input(ev);
Do not allow controls in ignore mouse to get focus via their children, fixes #17955
2018-11-16 16:46:42 +00:00
}
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
if (!control->is_inside_tree() || control->is_set_as_top_level()) {
Fix indentation issues in last commits Ping @reduz.
2016-06-07 05:39:40 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (gui.key_event_accepted) {
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
stopped = true;
Fix indentation issues in last commits Ping @reduz.
2016-06-07 05:39:40 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fix MOUSE_FILTER_STOP not affecting emulated mouse events Touch and Drag events are now stopped by MOUSE_FILTER_STOP
2023-01-19 13:56:32 +00:00
if (control->data.mouse_filter == Control::MOUSE_FILTER_STOP && is_pointer_event && !(is_scroll_event && control->data.force_pass_scroll_events)) {
// Mouse, ScreenDrag and ScreenTouch events are stopped by default with MOUSE_FILTER_STOP, unless we have a scroll event and force_pass_scroll_events set to true
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
stopped = true;
Fix indentation issues in last commits Ping @reduz.
2016-06-07 05:39:40 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fix indentation issues in last commits Ping @reduz.
2016-06-07 05:39:40 +00:00
}
Fix InputEvent being used twice A single mouse click can cause multiple actions, which contradicts the paradigm that a single Input Event should cause only a single action. The solution consists of two parts: 1. Physics Picking as the last step during viewport input event handling, currently doesn't set the event as handled. This PR sets the event as handled in the case of physics picking. 2. After an InputEvent is processed by a SubVieportContainer, it is sent to its parent, even if it set as handled within the SubViewport. This PR adds an additional test to check if the event is handled before propagating the event to the parent Control.
2023-05-28 22:29:44 +00:00
if (is_input_handled()) {
// Break after Physics Picking in SubViewport.
break;
}
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
if (ci->is_set_as_top_level()) {
Fix indentation issues in last commits Ping @reduz.
2016-06-07 05:39:40 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fix indentation issues in last commits Ping @reduz.
2016-06-07 05:39:40 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
ev = ev->xformed_by(ci->get_transform()); // Transform event upwards.
Fix indentation issues in last commits Ping @reduz.
2016-06-07 05:39:40 +00:00
ci = ci->get_parent_item();
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
return stopped;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
respect mouse mode when setting enter/exit notifications and signals, fixes #19785
2019-01-18 20:53:36 +00:00
void Viewport::_gui_call_notification(Control *p_control, int p_what) {
CanvasItem *ci = p_control;
while (ci) {
Control *control = Object::cast_to<Control>(ci);
if (control) {
if (control->data.mouse_filter != Control::MOUSE_FILTER_IGNORE) {
control->notification(p_what);
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!control->is_inside_tree()) {
respect mouse mode when setting enter/exit notifications and signals, fixes #19785
2019-01-18 20:53:36 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
respect mouse mode when setting enter/exit notifications and signals, fixes #19785
2019-01-18 20:53:36 +00:00
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
if (!control->is_inside_tree() || control->is_set_as_top_level()) {
respect mouse mode when setting enter/exit notifications and signals, fixes #19785
2019-01-18 20:53:36 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (control->data.mouse_filter == Control::MOUSE_FILTER_STOP) {
respect mouse mode when setting enter/exit notifications and signals, fixes #19785
2019-01-18 20:53:36 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
respect mouse mode when setting enter/exit notifications and signals, fixes #19785
2019-01-18 20:53:36 +00:00
}
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
if (ci->is_set_as_top_level()) {
respect mouse mode when setting enter/exit notifications and signals, fixes #19785
2019-01-18 20:53:36 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
respect mouse mode when setting enter/exit notifications and signals, fixes #19785
2019-01-18 20:53:36 +00:00
ci = ci->get_parent_item();
}
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Make `MenuButton`'s `switch_on_hover` work again
2021-07-19 20:09:23 +00:00
Control *Viewport::gui_find_control(const Point2 &p_global) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD_V(nullptr);
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Handle subwindows.
-Fix input bug on window ordering due to foretting to sort root items
2016-01-25 13:39:55 +00:00
_gui_sort_roots();
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
for (List<Control *>::Element *E = gui.roots.back(); E; E = E->prev()) {
Control *sw = E->get();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!sw->is_visible_in_tree()) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Type renames: Matrix32 -> Transform2D Matrix3 -> Basis AABB -> Rect3 RawArray -> PoolByteArray IntArray -> PoolIntArray FloatArray -> PoolFloatArray Vector2Array -> PoolVector2Array Vector3Array -> PoolVector3Array ColorArray -> PoolColorArray
2017-01-11 03:52:51 +00:00
Transform2D xform;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
CanvasItem *pci = sw->get_parent_item();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (pci) {
-Some fixes to drag and drop and canvas offset for GUI that were introduced after rewrite
2016-01-19 23:27:27 +00:00
xform = pci->get_global_transform_with_canvas();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
-Fix mouse coordinates not being affected by canvas transform
2016-02-03 12:31:18 +00:00
xform = sw->get_canvas_transform();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Calculate the mouse focus inverse transform only when needed Revival of #49158 Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com>
2022-12-05 09:41:32 +00:00
Control *ret = _gui_find_control_at_pos(sw, p_global, xform);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (ret) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
return ret;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
return nullptr;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Calculate the mouse focus inverse transform only when needed Revival of #49158 Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com>
2022-12-05 09:41:32 +00:00
Control *Viewport::_gui_find_control_at_pos(CanvasItem *p_node, const Point2 &p_global, const Transform2D &p_xform) {
New API for visibility in both CanvasItem and Spatial visible (property) - access set_visible(bool) is_visible() is_visible_in_tree() - true when visible and parents visible show() hide() - for convenience
2017-01-13 13:45:50 +00:00
if (!p_node->is_visible()) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
return nullptr; // Canvas item hidden, discard.
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Type renames: Matrix32 -> Transform2D Matrix3 -> Basis AABB -> Rect3 RawArray -> PoolByteArray IntArray -> PoolIntArray FloatArray -> PoolFloatArray Vector2Array -> PoolVector2Array Vector3Array -> PoolVector3Array ColorArray -> PoolColorArray
2017-01-11 03:52:51 +00:00
Transform2D matrix = p_xform * p_node->get_transform();
Expose `determinant` in Transform2D, rename internal method
2023-04-21 06:21:59 +00:00
// matrix.determinant() == 0.0f implies that node does not exist on scene
if (matrix.determinant() == 0.0f) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
return nullptr;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Make some debug prints verbose-only, remove others
2018-08-24 07:35:07 +00:00
Control *c = Object::cast_to<Control>(p_node);
Remove clips_input() method and use clip_content
2021-06-25 13:46:37 +00:00
if (!c || !c->is_clipping_contents() || c->has_point(matrix.affine_inverse().xform(p_global))) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
for (int i = p_node->get_child_count() - 1; i >= 0; i--) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
CanvasItem *ci = Object::cast_to<CanvasItem>(p_node->get_child(i));
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
if (!ci || ci->is_set_as_top_level()) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Calculate the mouse focus inverse transform only when needed Revival of #49158 Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com>
2022-12-05 09:41:32 +00:00
Control *ret = _gui_find_control_at_pos(ci, p_global, matrix);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (ret) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
return ret;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
}
Fix crash during drag if user freed the drag preview
2021-02-24 11:47:14 +00:00
if (!c || c->data.mouse_filter == Control::MOUSE_FILTER_IGNORE) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
return nullptr;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
matrix.affine_invert();
Fix crash during drag if user freed the drag preview
2021-02-24 11:47:14 +00:00
if (!c->has_point(matrix.xform(p_global))) {
return nullptr;
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix crash during drag if user freed the drag preview
2021-02-24 11:47:14 +00:00
Control *drag_preview = _gui_get_drag_preview();
Rename `is_a_parent_of()` to `is_ancestor_of()`
2021-06-18 22:02:50 +00:00
if (!drag_preview || (c != drag_preview && !drag_preview->is_ancestor_of(c))) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
return c;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fix crash during drag if user freed the drag preview
2021-02-24 11:47:14 +00:00
return nullptr;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
bool Viewport::_gui_drop(Control *p_at_control, Point2 p_at_pos, bool p_just_check) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Attempt grab, try parent controls too.
CanvasItem *ci = p_at_control;
while (ci) {
Control *control = Object::cast_to<Control>(ci);
if (control) {
if (control->can_drop_data(p_at_pos, gui.drag_data)) {
if (!p_just_check) {
control->drop_data(p_at_pos, gui.drag_data);
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
}
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
return true;
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
}
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
if (control->data.mouse_filter == Control::MOUSE_FILTER_STOP) {
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
}
p_at_pos = ci->get_transform().xform(p_at_pos);
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
if (ci->is_set_as_top_level()) {
break;
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
}
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
ci = ci->get_parent_item();
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
}
return false;
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
void Viewport::_gui_input_event(Ref<InputEvent> p_event) {
Add do..while(0) wrappers to macros without one. - Add do..while(0) wrapper to ERR_FAIL_NULL macros. - Add do..while(0) wrapper to ERR_FAIL_COND macros. - Add do..while(0) wrapper to ERR_CONTINUE macros. - Add do..while(0) wrapper to ERR_BREAK macros. - Add do..while(0) wrapper to CRASH_COND macros. - Add do..while(0) wrapper to ERR_FAIL macros. - Add do..while(0) wrapper to ERR_PRINT macros. - Add do..while(0) wrapper to WARN_PRINT macros. - Add do..while(0) wrapper to WARN_DEPRECATED macros. - Add do..while(0) wrapper to CRASH_NOW macros.
2019-11-07 09:37:44 +00:00
ERR_FAIL_COND(p_event.is_null());
fix some crashes
2019-06-22 12:52:51 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Ref<InputEventMouseButton> mb = p_event;
if (mb.is_valid()) {
gui.key_event_accepted = false;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
InputEvent: Renamed "pos" property to "position" Make the naming consistent with other classes.
2017-06-03 08:54:24 +00:00
Point2 mpos = mb->get_position();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (mb->is_pressed()) {
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
if (!gui.mouse_focus_mask.is_empty()) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Do not steal mouse focus and stuff while a focus mask exists.
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
gui.mouse_focus_mask.set_flag(mouse_button_to_mask(mb->get_button_index()));
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
} else {
Calculate the mouse focus inverse transform only when needed Revival of #49158 Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com>
2022-12-05 09:41:32 +00:00
gui.mouse_focus = gui_find_control(mpos);
Fix touch release event on _gui_input
2018-10-26 19:23:47 +00:00
gui.last_mouse_focus = gui.mouse_focus;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (!gui.mouse_focus) {
return;
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
gui.mouse_focus_mask.set_flag(mouse_button_to_mask(mb->get_button_index()));
Update focus mask only if there is a focused control, fixes #26524
2019-03-04 13:26:48 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (mb->get_button_index() == MouseButton::LEFT) {
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
gui.drag_accum = Vector2();
gui.drag_attempted = false;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
Some code simplifications AnimationNodeBlendSpace2DEditor: - `!tree` is always false, because it is checked a few lines above CurveEdit: - grabbing != GRAB_NONE is redundant GradientTexture2DEdit: - grabbed != HANDLE_FROM is redundant - grabbed != HANDLE_TO is redundant Viewport: - index is not used afterwards - In these cases `gui.mouse_focus` is always valid. Move check to a DEV_ASSERT - simplify `stopped` calculation
2023-02-08 17:39:05 +00:00
DEV_ASSERT(gui.mouse_focus);
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
mb = mb->xformed_by(Transform2D()); // Make a copy of the event.
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Calculate the mouse focus inverse transform only when needed Revival of #49158 Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com>
2022-12-05 09:41:32 +00:00
Point2 pos = gui.mouse_focus->get_global_transform_with_canvas().affine_inverse().xform(mpos);
InputEvent: Renamed "pos" property to "position" Make the naming consistent with other classes.
2017-06-03 08:54:24 +00:00
mb->set_position(pos);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
#ifdef DEBUG_ENABLED
Some code simplifications AnimationNodeBlendSpace2DEditor: - `!tree` is always false, because it is checked a few lines above CurveEdit: - grabbing != GRAB_NONE is redundant GradientTexture2DEdit: - grabbed != HANDLE_FROM is redundant - grabbed != HANDLE_TO is redundant Viewport: - index is not used afterwards - In these cases `gui.mouse_focus` is always valid. Move check to a DEV_ASSERT - simplify `stopped` calculation
2023-02-08 17:39:05 +00:00
if (EngineDebugger::get_singleton()) {
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Array arr;
arr.push_back(gui.mouse_focus->get_path());
arr.push_back(gui.mouse_focus->get_class());
Refactor ScriptDebugger. EngineDebugger is the new interface to access the debugger. It tries to be as agnostic as possible on the data that various subsystems can expose. It allows 2 types of interactions: - Profilers: A subsystem can register a profiler, assigning it a unique name. That name can be used to activate the profiler or add data to it. The registered profiler can be composed of up to 3 functions: - Toggle: called when the profiler is activated/deactivated. - Add: called whenever data is added to the debugger (via `EngineDebugger::profiler_add_frame_data`) - Tick: called every frame (during idle), receives frame times. - Captures: (Only relevant in remote debugger for now) A subsystem can register a capture, assigning it a unique name. When receiving a message, the remote debugger will check if it starts with `[prefix]:` and call the associated capture with name `prefix`. Port MultiplayerAPI, Servers, Scripts, Visual, Performance to the new profiler system. Port SceneDebugger and RemoteDebugger to the new capture system. The LocalDebugger also uses the new profiler system for scripts profiling.
2020-02-27 02:30:20 +00:00
EngineDebugger::get_singleton()->send_message("scene:click_ctrl", arr);
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
#endif
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (mb->get_button_index() == MouseButton::LEFT) { // Assign focus.
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
CanvasItem *ci = gui.mouse_focus;
while (ci) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
Control *control = Object::cast_to<Control>(ci);
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (control) {
if (control->get_focus_mode() != Control::FOCUS_NONE) {
if (control != gui.key_focus) {
control->grab_focus();
WIP new AudioServer, with buses, effects, etc.
2017-01-21 22:00:25 +00:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
break;
WIP new AudioServer, with buses, effects, etc.
2017-01-21 22:00:25 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (control->data.mouse_filter == Control::MOUSE_FILTER_STOP) {
WIP new AudioServer, with buses, effects, etc.
2017-01-21 22:00:25 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
WIP new AudioServer, with buses, effects, etc.
2017-01-21 22:00:25 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
if (ci->is_set_as_top_level()) {
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
ci = ci->get_parent_item();
}
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Re-add `mouse_focus`-nullcheck
2023-06-22 19:58:19 +00:00
bool stopped = gui.mouse_focus && gui.mouse_focus->can_process() && _gui_call_input(gui.mouse_focus, mb);
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
if (stopped) {
set_input_as_handled();
}
Improved drag&drop to work as n-piggeon wants to use, closes #5342
2016-07-01 13:34:38 +00:00
Allow canceling Drag and Drop with the Escape-Key This patch implements the functionality to cancel Drag and Drop by using the escape key or more general, the ui_cancel action. Since this would be the third location, where the finalization of Drag and Drop would have to be implemented, that functionality was put into the private function _perform_drop. Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging because they are equivalent.
2022-11-08 18:02:47 +00:00
if (gui.dragging && mb->get_button_index() == MouseButton::LEFT) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Alternate drop use (when using force_drag(), as proposed by #5342).
Allow canceling Drag and Drop with the Escape-Key This patch implements the functionality to cancel Drag and Drop by using the escape key or more general, the ui_cancel action. Since this would be the third location, where the finalization of Drag and Drop would have to be implemented, that functionality was put into the private function _perform_drop. Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging because they are equivalent.
2022-11-08 18:02:47 +00:00
_perform_drop(gui.mouse_focus, pos);
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
_gui_cancel_tooltip();
} else {
Allow canceling Drag and Drop with the Escape-Key This patch implements the functionality to cancel Drag and Drop by using the escape key or more general, the ui_cancel action. Since this would be the third location, where the finalization of Drag and Drop would have to be implemented, that functionality was put into the private function _perform_drop. Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging because they are equivalent.
2022-11-08 18:02:47 +00:00
if (gui.dragging && mb->get_button_index() == MouseButton::LEFT) {
_perform_drop(gui.drag_mouse_over, gui.drag_mouse_over_pos);
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
gui.mouse_focus_mask.clear_flag(mouse_button_to_mask(mb->get_button_index())); // Remove from mask.
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (!gui.mouse_focus) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Release event is only sent if a mouse focus (previously pressed button) exists.
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
return;
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
mb = mb->xformed_by(Transform2D()); // Make a copy.
Calculate the mouse focus inverse transform only when needed Revival of #49158 Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com>
2022-12-05 09:41:32 +00:00
Point2 pos = gui.mouse_focus->get_global_transform_with_canvas().affine_inverse().xform(mpos);
InputEvent: Renamed "pos" property to "position" Make the naming consistent with other classes.
2017-06-03 08:54:24 +00:00
mb->set_position(pos);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
-Make capture dependent on a cell size, not subdivision. -Fixed a bug recently introduced when releasing mouse events and calling popups
2017-12-21 14:03:17 +00:00
Control *mouse_focus = gui.mouse_focus;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Disable mouse focus if needed before calling input,
// this makes popups on mouse press event work better,
// as the release will never be received otherwise.
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
if (gui.mouse_focus_mask.is_empty()) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.mouse_focus = nullptr;
Popups have also been converted to windows Controls using the old modal API have been replaced to use popups.
2020-03-20 02:32:09 +00:00
gui.forced_mouse_focus = false;
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Some code simplifications AnimationNodeBlendSpace2DEditor: - `!tree` is always false, because it is checked a few lines above CurveEdit: - grabbing != GRAB_NONE is redundant GradientTexture2DEdit: - grabbed != HANDLE_FROM is redundant - grabbed != HANDLE_TO is redundant Viewport: - index is not used afterwards - In these cases `gui.mouse_focus` is always valid. Move check to a DEV_ASSERT - simplify `stopped` calculation
2023-02-08 17:39:05 +00:00
bool stopped = mouse_focus && mouse_focus->can_process() && _gui_call_input(mouse_focus, mb);
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
if (stopped) {
set_input_as_handled();
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Ref<InputEventMouseMotion> mm = p_event;
if (mm.is_valid()) {
gui.key_event_accepted = false;
InputEvent: Renamed "pos" property to "position" Make the naming consistent with other classes.
2017-06-03 08:54:24 +00:00
Point2 mpos = mm->get_position();
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Drag & drop.
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
if (!gui.drag_attempted && gui.mouse_focus && (mm->get_button_mask().has_flag(MouseButtonMask::LEFT))) {
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
gui.drag_accum += mm->get_relative();
float len = gui.drag_accum.length();
if (len > 10) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
{ // Attempt grab, try parent controls too.
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
CanvasItem *ci = gui.mouse_focus;
while (ci) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
Control *control = Object::cast_to<Control>(ci);
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (control) {
Avoid misuse of set_drag_preview() function where it shouldn't be. Closes #20100
2018-08-24 13:29:27 +00:00
gui.dragging = true;
Fixed _get_drag_data getting incorrect position on scaled controls
2022-11-18 17:10:57 +00:00
gui.drag_data = control->get_drag_data(control->get_global_transform_with_canvas().affine_inverse().xform(mpos - gui.drag_accum));
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (gui.drag_data.get_type() != Variant::NIL) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.mouse_focus = nullptr;
Popups have also been converted to windows Controls using the old modal API have been replaced to use popups.
2020-03-20 02:32:09 +00:00
gui.forced_mouse_focus = false;
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
gui.mouse_focus_mask.clear();
Properly handle multiple parent drag, fixes #19460
2018-11-19 21:37:39 +00:00
break;
Avoid misuse of set_drag_preview() function where it shouldn't be. Closes #20100
2018-08-24 13:29:27 +00:00
} else {
Fix crash during drag if user freed the drag preview
2021-02-24 11:47:14 +00:00
Control *drag_preview = _gui_get_drag_preview();
if (drag_preview) {
Properly handle multiple parent drag, fixes #19460
2018-11-19 21:37:39 +00:00
ERR_PRINT("Don't set a drag preview and return null data. Preview was deleted and drag request ignored.");
Fix crash during drag if user freed the drag preview
2021-02-24 11:47:14 +00:00
memdelete(drag_preview);
gui.drag_preview_id = ObjectID();
Properly handle multiple parent drag, fixes #19460
2018-11-19 21:37:39 +00:00
}
Avoid misuse of set_drag_preview() function where it shouldn't be. Closes #20100
2018-08-24 13:29:27 +00:00
gui.dragging = false;
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (control->data.mouse_filter == Control::MOUSE_FILTER_STOP) {
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
}
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
if (ci->is_set_as_top_level()) {
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Ability to delete, drag and drop audio buses!
2017-01-24 02:12:08 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
ci = ci->get_parent_item();
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
gui.drag_attempted = true;
Allow canceling Drag and Drop with the Escape-Key This patch implements the functionality to cancel Drag and Drop by using the escape key or more general, the ui_cancel action. Since this would be the third location, where the finalization of Drag and Drop would have to be implemented, that functionality was put into the private function _perform_drop. Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging because they are equivalent.
2022-11-08 18:02:47 +00:00
if (gui.dragging) {
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
_propagate_viewport_notification(this, NOTIFICATION_DRAG_BEGIN);
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix mouse_over not dropped when mouse leaves window
2021-04-24 12:03:38 +00:00
Control *over = nullptr;
Send Mouse Enter/Exit Notifications independently of mouse focus
2022-03-26 16:01:19 +00:00
if (gui.mouse_focus) {
over = gui.mouse_focus;
Refactor mouse_entered and mouse_exited notifications The previous implementation for signals mouse_entered and mouse_exited had shortcomings that relate to focused windows and pressed mouse buttons. For example a Control can be hovered by mouse, even if it is occluded by an embedded window. This patch changes the behavior, so that Control and Viewport send their mouse-enter/exit-notifications based solely on mouse position, visible area, and input restrictions and not on which window has focus or which mouse buttons are pressed. This implicitly also changes when the mouse_entered and mouse_exited signals are sent. This functionality can not be implemented as a part of Viewport::_gui_input_event, because of its interplay with Windows and because Viewport::_gui_input_event is based on input and not on visibility.
2023-01-06 20:48:20 +00:00
} else if (gui.mouse_in_viewport) {
over = gui_find_control(mpos);
Send Mouse Enter/Exit Notifications independently of mouse focus
2022-03-26 16:01:19 +00:00
}
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 13:19:37 +00:00
DisplayServer::CursorShape ds_cursor_shape = (DisplayServer::CursorShape)Input::get_singleton()->get_default_cursor_shape();
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
if (over) {
Transform2D localizer = over->get_global_transform_with_canvas().affine_inverse();
Size2 pos = localizer.xform(mpos);
Rename speed to velocity when it's a directional Vector
2021-12-29 13:22:22 +00:00
Vector2 velocity = localizer.basis_xform(mm->get_velocity());
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
Vector2 rel = localizer.basis_xform(mm->get_relative());
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
mm = mm->xformed_by(Transform2D()); // Make a copy.
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
mm->set_global_position(mpos);
Rename speed to velocity when it's a directional Vector
2021-12-29 13:22:22 +00:00
mm->set_velocity(velocity);
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
mm->set_relative(rel);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
if (mm->get_button_mask().is_empty()) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Nothing pressed.
Hide tooltip if new mouse position's tooltip is empty
2016-07-19 04:27:12 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
bool is_tooltip_shown = false;
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
if (gui.tooltip_popup) {
Don't show tooltips for paused controls
2021-11-29 12:23:28 +00:00
if (gui.tooltip_control) {
Fix bad mouse offset to show tooltips in Tree
2021-12-12 08:12:26 +00:00
String tooltip = _gui_get_tooltip(over, gui.tooltip_control->get_global_transform().xform_inv(mpos));
Fix tooltip flickering in some cases
2022-02-15 15:29:03 +00:00
tooltip = tooltip.strip_edges();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (tooltip.length() == 0) {
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
_gui_cancel_tooltip();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else if (gui.tooltip_label) {
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
if (tooltip == gui.tooltip_label->get_text()) {
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
is_tooltip_shown = true;
}
} else {
Remove Inspector tooltip hack that never actually worked
2022-08-26 13:43:24 +00:00
is_tooltip_shown = true; // Nothing to compare against, likely using custom control, so if it changes there is nothing we can do.
Reworked tooltips to use the popup system.
2020-03-20 20:51:53 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
_gui_cancel_tooltip();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
}
Don't show tooltips for paused controls
2021-11-29 12:23:28 +00:00
if (!is_tooltip_shown && over->can_process()) {
Show tooltips even when paused or time_scale is 0
2021-02-26 23:37:20 +00:00
if (gui.tooltip_timer.is_valid()) {
gui.tooltip_timer->release_connections();
gui.tooltip_timer = Ref<SceneTreeTimer>();
}
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
gui.tooltip_control = over;
gui.tooltip_pos = over->get_screen_transform().xform(pos);
Show tooltips even when paused or time_scale is 0
2021-02-26 23:37:20 +00:00
gui.tooltip_timer = get_tree()->create_timer(gui.tooltip_delay);
gui.tooltip_timer->set_ignore_time_scale(true);
gui.tooltip_timer->connect("timeout", callable_mp(this, &Viewport::_gui_show_tooltip));
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
Don't start a new tooltip timer for the same tooltip
2016-07-18 20:14:57 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
mm->set_position(pos);
Control::CursorShape cursor_shape = Control::CURSOR_ARROW;
{
Control *c = over;
Vector2 cpos = pos;
while (c) {
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
if (!gui.mouse_focus_mask.is_empty() || c->has_point(cpos)) {
Ensure cursor shape changes when exiting window, fixes #37724
2020-07-02 17:15:03 +00:00
cursor_shape = c->get_cursor_shape(cpos);
} else {
cursor_shape = Control::CURSOR_ARROW;
}
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
cpos = c->get_transform().xform(cpos);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (cursor_shape != Control::CURSOR_ARROW) {
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (c->data.mouse_filter == Control::MOUSE_FILTER_STOP) {
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
if (c->is_set_as_top_level()) {
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
c = c->get_parent_control();
}
}
ds_cursor_shape = (DisplayServer::CursorShape)cursor_shape;
Some code simplifications AnimationNodeBlendSpace2DEditor: - `!tree` is always false, because it is checked a few lines above CurveEdit: - grabbing != GRAB_NONE is redundant GradientTexture2DEdit: - grabbed != HANDLE_FROM is redundant - grabbed != HANDLE_TO is redundant Viewport: - index is not used afterwards - In these cases `gui.mouse_focus` is always valid. Move check to a DEV_ASSERT - simplify `stopped` calculation
2023-02-08 17:39:05 +00:00
bool stopped = over->can_process() && _gui_call_input(over, mm);
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
if (stopped) {
set_input_as_handled();
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Allow canceling Drag and Drop with the Escape-Key This patch implements the functionality to cancel Drag and Drop by using the escape key or more general, the ui_cancel action. Since this would be the third location, where the finalization of Drag and Drop would have to be implemented, that functionality was put into the private function _perform_drop. Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging because they are equivalent.
2022-11-08 18:02:47 +00:00
if (gui.dragging) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Handle drag & drop.
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix crash during drag if user freed the drag preview
2021-02-24 11:47:14 +00:00
Control *drag_preview = _gui_get_drag_preview();
if (drag_preview) {
drag_preview->set_position(mpos);
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
gui.drag_mouse_over = over;
gui.drag_mouse_over_pos = Vector2();
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Find the window this is above of.
// See if there is an embedder.
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
Viewport *embedder = nullptr;
Vector2 viewport_pos;
if (is_embedding_subwindows()) {
embedder = this;
viewport_pos = mpos;
} else {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Not an embedder, but may be a subwindow of an embedder.
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
Window *w = Object::cast_to<Window>(this);
if (w) {
if (w->is_embedded()) {
Fix Color Picking With the 4.x-introduction of Windows the previous method for color picking was no longer working. This PR uses the following approach to reintroduce color-picking. When the Color-Picking-Button is pressed, a quasi-screenshot of the Window-content is created and displayed in a new Popup-Window. This new Window allows selecting colors by Mouse-Click. A Preview of the targeted Color is also displayed.
2023-02-05 16:35:39 +00:00
embedder = w->get_embedder();
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
Include the Window-transform into Viewport::get_final_transform
2022-10-01 06:40:11 +00:00
viewport_pos = get_final_transform().xform(mpos) + w->get_position(); // To parent coords.
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
}
}
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
}
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
Viewport *viewport_under = nullptr;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
if (embedder) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Use embedder logic.
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
for (int i = embedder->gui.sub_windows.size() - 1; i >= 0; i--) {
Window *sw = embedder->gui.sub_windows[i].window;
Rect2 swrect = Rect2i(sw->get_position(), sw->get_size());
if (!sw->get_flag(Window::FLAG_BORDERLESS)) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
int title_height = sw->get_theme_constant(SNAME("title_height"));
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
swrect.position.y -= title_height;
swrect.size.y += title_height;
}
if (swrect.has_point(viewport_pos)) {
viewport_under = sw;
viewport_pos -= sw->get_position();
}
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
if (!viewport_under) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Not in a subwindow, likely in embedder.
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
viewport_under = embedder;
}
} else {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Use DisplayServer logic.
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
Vector2i screen_mouse_pos = DisplayServer::get_singleton()->mouse_get_position();
DisplayServer::WindowID window_id = DisplayServer::get_singleton()->get_window_at_screen_position(screen_mouse_pos);
if (window_id != DisplayServer::INVALID_WINDOW_ID) {
ObjectID object_under = DisplayServer::get_singleton()->window_get_attached_instance_id(window_id);
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
if (object_under != ObjectID()) { // Fetch window.
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
Window *w = Object::cast_to<Window>(ObjectDB::get_instance(object_under));
if (w) {
viewport_under = w;
viewport_pos = screen_mouse_pos - w->get_position();
}
}
}
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
if (viewport_under) {
Fix Drag n Drop Transform in main embedding window
2022-03-30 22:43:52 +00:00
if (viewport_under != this) {
Include the Window-transform into Viewport::get_final_transform
2022-10-01 06:40:11 +00:00
Transform2D ai = viewport_under->get_final_transform().affine_inverse();
Fix Drag n Drop Transform in main embedding window
2022-03-30 22:43:52 +00:00
viewport_pos = ai.xform(viewport_pos);
}
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Find control under at position.
Make `MenuButton`'s `switch_on_hover` work again
2021-07-19 20:09:23 +00:00
gui.drag_mouse_over = viewport_under->gui_find_control(viewport_pos);
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
if (gui.drag_mouse_over) {
Transform2D localizer = gui.drag_mouse_over->get_global_transform_with_canvas().affine_inverse();
gui.drag_mouse_over_pos = localizer.xform(viewport_pos);
Fix mouse cursor and notification for force dragging
2021-12-03 10:19:41 +00:00
bool can_drop = _gui_drop(gui.drag_mouse_over, gui.drag_mouse_over_pos, true);
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
Fix mouse cursor and notification for force dragging
2021-12-03 10:19:41 +00:00
if (!can_drop) {
ds_cursor_shape = DisplayServer::CURSOR_FORBIDDEN;
} else {
ds_cursor_shape = DisplayServer::CURSOR_CAN_DROP;
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
}
}
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
} else {
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
gui.drag_mouse_over = nullptr;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
Don't override SubViewport's cursor with SubViewportContainer's cursor Add a warning for having a non-default value of `mouse_default_cursor_shape` in SubViewportContainer Add test
2023-07-23 00:14:41 +00:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_CURSOR_SHAPE) && !Object::cast_to<SubViewportContainer>(over)) {
Avoid warnings about cursor shape change not supported
2022-08-23 09:14:07 +00:00
DisplayServer::get_singleton()->cursor_set_shape(ds_cursor_shape);
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
Ref<InputEventScreenTouch> touch_event = p_event;
if (touch_event.is_valid()) {
Size2 pos = touch_event->get_position();
Fix routing of InputEventScreenDrag events to Control nodes
2022-11-14 00:09:03 +00:00
const int touch_index = touch_event->get_index();
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
if (touch_event->is_pressed()) {
Make `MenuButton`'s `switch_on_hover` work again
2021-07-19 20:09:23 +00:00
Control *over = gui_find_control(pos);
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
if (over) {
Fix routing of InputEventScreenDrag events to Control nodes
2022-11-14 00:09:03 +00:00
gui.touch_focus[touch_index] = over->get_instance_id();
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
bool stopped = false;
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
if (over->can_process()) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
touch_event = touch_event->xformed_by(Transform2D()); // Make a copy.
Calculate the mouse focus inverse transform only when needed Revival of #49158 Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com>
2022-12-05 09:41:32 +00:00
pos = over->get_global_transform_with_canvas().affine_inverse().xform(pos);
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
touch_event->set_position(pos);
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
stopped = _gui_call_input(over, touch_event);
}
if (stopped) {
set_input_as_handled();
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
}
return;
}
Fix routing of InputEventScreenDrag events to Control nodes
2022-11-14 00:09:03 +00:00
} else {
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
bool stopped = false;
Fix routing of InputEventScreenDrag events to Control nodes
2022-11-14 00:09:03 +00:00
ObjectID control_id = gui.touch_focus[touch_index];
Control *over = control_id.is_valid() ? Object::cast_to<Control>(ObjectDB::get_instance(control_id)) : nullptr;
if (over && over->can_process()) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
touch_event = touch_event->xformed_by(Transform2D()); // Make a copy.
Fix crash on touch release
2023-01-17 23:43:16 +00:00
pos = over->get_global_transform_with_canvas().affine_inverse().xform(pos);
Fix routing of InputEventScreenDrag events to Control nodes
2022-11-14 00:09:03 +00:00
touch_event->set_position(pos);
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
Fix routing of InputEventScreenDrag events to Control nodes
2022-11-14 00:09:03 +00:00
stopped = _gui_call_input(over, touch_event);
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
}
if (stopped) {
set_input_as_handled();
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
}
Fix routing of InputEventScreenDrag events to Control nodes
2022-11-14 00:09:03 +00:00
gui.touch_focus.erase(touch_index);
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
return;
}
}
Native pan and zoom for macOS
2017-11-01 20:49:39 +00:00
Ref<InputEventGesture> gesture_event = p_event;
if (gesture_event.is_valid()) {
Fix gesture events being blocked
2018-03-04 21:19:10 +00:00
gui.key_event_accepted = false;
Hide tooltip on gesture input
2017-12-22 18:39:23 +00:00
_gui_cancel_tooltip();
Native pan and zoom for macOS
2017-11-01 20:49:39 +00:00
Size2 pos = gesture_event->get_position();
Make `MenuButton`'s `switch_on_hover` work again
2021-07-19 20:09:23 +00:00
Control *over = gui_find_control(pos);
Native pan and zoom for macOS
2017-11-01 20:49:39 +00:00
if (over) {
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
bool stopped = false;
Native pan and zoom for macOS
2017-11-01 20:49:39 +00:00
if (over->can_process()) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
gesture_event = gesture_event->xformed_by(Transform2D()); // Make a copy.
Calculate the mouse focus inverse transform only when needed Revival of #49158 Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com>
2022-12-05 09:41:32 +00:00
pos = over->get_global_transform_with_canvas().affine_inverse().xform(pos);
Native pan and zoom for macOS
2017-11-01 20:49:39 +00:00
gesture_event->set_position(pos);
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
stopped = _gui_call_input(over, gesture_event);
}
if (stopped) {
set_input_as_handled();
Native pan and zoom for macOS
2017-11-01 20:49:39 +00:00
}
return;
}
}
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
Ref<InputEventScreenDrag> drag_event = p_event;
if (drag_event.is_valid()) {
Fix routing of InputEventScreenDrag events to Control nodes
2022-11-14 00:09:03 +00:00
const int drag_event_index = drag_event->get_index();
ObjectID control_id = gui.touch_focus[drag_event_index];
Control *over = control_id.is_valid() ? Object::cast_to<Control>(ObjectDB::get_instance(control_id)) : nullptr;
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
if (!over) {
Make `MenuButton`'s `switch_on_hover` work again
2021-07-19 20:09:23 +00:00
over = gui_find_control(drag_event->get_position());
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
}
if (over) {
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
bool stopped = false;
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
if (over->can_process()) {
Transform2D localizer = over->get_global_transform_with_canvas().affine_inverse();
Size2 pos = localizer.xform(drag_event->get_position());
Rename speed to velocity when it's a directional Vector
2021-12-29 13:22:22 +00:00
Vector2 velocity = localizer.basis_xform(drag_event->get_velocity());
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
Vector2 rel = localizer.basis_xform(drag_event->get_relative());
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
drag_event = drag_event->xformed_by(Transform2D()); // Make a copy.
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
Rename speed to velocity when it's a directional Vector
2021-12-29 13:22:22 +00:00
drag_event->set_velocity(velocity);
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
drag_event->set_relative(rel);
drag_event->set_position(pos);
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
stopped = _gui_call_input(over, drag_event);
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
}
Keep input event as unhandled if they go through a control set to MOUSE_FILTER_PASS
2022-05-16 13:10:30 +00:00
if (stopped) {
set_input_as_handled();
}
Add handling of touch events in _gui_input_event Fixes #10039
2017-08-07 04:44:46 +00:00
return;
}
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (mm.is_null() && mb.is_null() && p_event->is_action_type()) {
Allow canceling Drag and Drop with the Escape-Key This patch implements the functionality to cancel Drag and Drop by using the escape key or more general, the ui_cancel action. Since this would be the third location, where the finalization of Drag and Drop would have to be implemented, that functionality was put into the private function _perform_drop. Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging because they are equivalent.
2022-11-08 18:02:47 +00:00
if (gui.dragging && p_event->is_action_pressed("ui_cancel") && Input::get_singleton()->is_action_just_pressed("ui_cancel")) {
_perform_drop();
set_input_as_handled();
return;
}
Dismiss currently visible or upcoming tooltips when pressing Escape This is standard UI behavior in most applications out there.
2023-08-07 08:52:28 +00:00
if (p_event->is_action_pressed("ui_cancel")) {
// Cancel tooltip timer or hide tooltip when pressing Escape (this is standard behavior in most applications).
_gui_cancel_tooltip();
if (gui.tooltip_popup) {
// If a tooltip was hidden, prevent other actions associated with `ui_cancel` from occurring.
// For instance, this prevents the node from being deselected when pressing Escape
// to hide a documentation tooltip in the inspector.
set_input_as_handled();
return;
}
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (gui.key_focus && !gui.key_focus->is_visible_in_tree()) {
gui.key_focus->release_focus();
}
Invalidate key focus if not visible, fixes #5354
2016-07-01 13:42:33 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (gui.key_focus) {
gui.key_event_accepted = false;
if (gui.key_focus->can_process()) {
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
gui.key_focus->_call_gui_input(p_event);
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (gui.key_event_accepted) {
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
set_input_as_handled();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
return;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
Control *from = gui.key_focus ? gui.key_focus : nullptr;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (from && p_event->is_pressed()) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
Control *next = nullptr;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix UI navigation with joysticks
2022-03-27 09:41:29 +00:00
Ref<InputEventJoypadMotion> joypadmotion_event = p_event;
if (joypadmotion_event.is_valid()) {
Input *input = Input::get_singleton();
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix UI navigation with joysticks
2022-03-27 09:41:29 +00:00
if (p_event->is_action_pressed("ui_focus_next") && input->is_action_just_pressed("ui_focus_next")) {
next = from->find_next_valid_focus();
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix UI navigation with joysticks
2022-03-27 09:41:29 +00:00
if (p_event->is_action_pressed("ui_focus_prev") && input->is_action_just_pressed("ui_focus_prev")) {
next = from->find_prev_valid_focus();
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix UI navigation with joysticks
2022-03-27 09:41:29 +00:00
if (p_event->is_action_pressed("ui_up") && input->is_action_just_pressed("ui_up")) {
next = from->_get_focus_neighbor(SIDE_TOP);
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix UI navigation with joysticks
2022-03-27 09:41:29 +00:00
if (p_event->is_action_pressed("ui_left") && input->is_action_just_pressed("ui_left")) {
next = from->_get_focus_neighbor(SIDE_LEFT);
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix UI navigation with joysticks
2022-03-27 09:41:29 +00:00
if (p_event->is_action_pressed("ui_right") && input->is_action_just_pressed("ui_right")) {
next = from->_get_focus_neighbor(SIDE_RIGHT);
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix UI navigation with joysticks
2022-03-27 09:41:29 +00:00
if (p_event->is_action_pressed("ui_down") && input->is_action_just_pressed("ui_down")) {
next = from->_get_focus_neighbor(SIDE_BOTTOM);
}
} else {
if (p_event->is_action_pressed("ui_focus_next", true, true)) {
next = from->find_next_valid_focus();
}
if (p_event->is_action_pressed("ui_focus_prev", true, true)) {
next = from->find_prev_valid_focus();
}
if (p_event->is_action_pressed("ui_up", true, true)) {
next = from->_get_focus_neighbor(SIDE_TOP);
}
if (p_event->is_action_pressed("ui_left", true, true)) {
next = from->_get_focus_neighbor(SIDE_LEFT);
}
if (p_event->is_action_pressed("ui_right", true, true)) {
next = from->_get_focus_neighbor(SIDE_RIGHT);
}
if (p_event->is_action_pressed("ui_down", true, true)) {
next = from->_get_focus_neighbor(SIDE_BOTTOM);
}
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (next) {
next->grab_focus();
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
set_input_as_handled();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
}
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
}
Allow canceling Drag and Drop with the Escape-Key This patch implements the functionality to cancel Drag and Drop by using the escape key or more general, the ui_cancel action. Since this would be the third location, where the finalization of Drag and Drop would have to be implemented, that functionality was put into the private function _perform_drop. Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging because they are equivalent.
2022-11-08 18:02:47 +00:00
void Viewport::_perform_drop(Control *p_control, Point2 p_pos) {
// Without any arguments, simply cancel Drag and Drop.
if (p_control) {
gui.drag_successful = _gui_drop(p_control, p_pos, false);
} else {
gui.drag_successful = false;
}
Control *drag_preview = _gui_get_drag_preview();
if (drag_preview) {
memdelete(drag_preview);
gui.drag_preview_id = ObjectID();
}
gui.drag_data = Variant();
gui.dragging = false;
gui.drag_mouse_over = nullptr;
_propagate_viewport_notification(this, NOTIFICATION_DRAG_END);
Create a virtual mouse move event after moving child nodes This updates mouse cursor and mouse-over-states without the need for additional mouse movements.
2022-09-29 21:45:51 +00:00
// Display the new cursor shape instantly.
update_mouse_cursor_state();
Allow canceling Drag and Drop with the Escape-Key This patch implements the functionality to cancel Drag and Drop by using the escape key or more general, the ui_cancel action. Since this would be the third location, where the finalization of Drag and Drop would have to be implemented, that functionality was put into the private function _perform_drop. Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging because they are equivalent.
2022-11-08 18:02:47 +00:00
}
Cleanup internal GUI state, if event is accepted in _input.
2022-03-13 22:54:13 +00:00
void Viewport::_gui_cleanup_internal_state(Ref<InputEvent> p_event) {
ERR_FAIL_COND(p_event.is_null());
Ref<InputEventMouseButton> mb = p_event;
if (mb.is_valid()) {
if (!mb->is_pressed()) {
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
gui.mouse_focus_mask.clear_flag(mouse_button_to_mask(mb->get_button_index())); // Remove from mask.
Cleanup internal GUI state, if event is accepted in _input.
2022-03-13 22:54:13 +00:00
}
}
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
List<Control *>::Element *Viewport::_gui_add_root_control(Control *p_control) {
gui.roots_order_dirty = true;
return gui.roots.push_back(p_control);
}
Fix Viewport root order after Node2D raise
2022-04-01 19:18:16 +00:00
void Viewport::gui_set_root_order_dirty() {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
gui.roots_order_dirty = true;
}
-Some fixes to drag and drop and canvas offset for GUI that were introduced after rewrite
2016-01-19 23:27:27 +00:00
void Viewport::_gui_force_drag(Control *p_base, const Variant &p_data, Control *p_control) {
Remove ERR_EXPLAIN from scene/* code
2019-08-08 20:11:48 +00:00
ERR_FAIL_COND_MSG(p_data.get_type() == Variant::NIL, "Drag data must be a value.");
Improved drag&drop to work as n-piggeon wants to use, closes #5342
2016-07-01 13:34:38 +00:00
Avoid misuse of set_drag_preview() function where it shouldn't be. Closes #20100
2018-08-24 13:29:27 +00:00
gui.dragging = true;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
gui.drag_data = p_data;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.mouse_focus = nullptr;
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
if (p_control) {
-Some fixes to drag and drop and canvas offset for GUI that were introduced after rewrite
2016-01-19 23:27:27 +00:00
_gui_set_drag_preview(p_base, p_control);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Fix mouse cursor and notification for force dragging
2021-12-03 10:19:41 +00:00
_propagate_viewport_notification(this, NOTIFICATION_DRAG_BEGIN);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
-Some fixes to drag and drop and canvas offset for GUI that were introduced after rewrite
2016-01-19 23:27:27 +00:00
void Viewport::_gui_set_drag_preview(Control *p_base, Control *p_control) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
ERR_FAIL_NULL(p_control);
ERR_FAIL_COND(p_control->is_inside_tree());
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
ERR_FAIL_COND(p_control->get_parent() != nullptr);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix crash during drag if user freed the drag preview
2021-02-24 11:47:14 +00:00
Control *drag_preview = _gui_get_drag_preview();
if (drag_preview) {
memdelete(drag_preview);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Renamed toplevel to be top_level
2020-10-01 07:17:33 +00:00
p_control->set_as_top_level(true);
Rename [gs]et_pos to [gs]et_position for Controls Control set_pos -> set_position Control set_global_pos -> set_global_position [gs]et_mouse_pos -> [gs]et_mouse_position [gs]et_global_mouse_pos -> [gs]et_global_mouse_position fixes #8005
2017-03-29 15:29:38 +00:00
p_control->set_position(gui.last_mouse_pos);
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
p_base->get_root_parent_control()->add_child(p_control); // Add as child of viewport.
Rename raise() to move_to_front()
2022-04-10 18:52:55 +00:00
p_control->move_to_front();
Fix double free for drag preview control in viewport
2018-05-08 05:52:38 +00:00
Fix crash during drag if user freed the drag preview
2021-02-24 11:47:14 +00:00
gui.drag_preview_id = p_control->get_instance_id();
}
Control *Viewport::_gui_get_drag_preview() {
if (gui.drag_preview_id.is_null()) {
return nullptr;
} else {
Control *drag_preview = Object::cast_to<Control>(ObjectDB::get_instance(gui.drag_preview_id));
if (!drag_preview) {
ERR_PRINT("Don't free the control set as drag preview.");
gui.drag_preview_id = ObjectID();
}
return drag_preview;
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
void Viewport::_gui_remove_root_control(List<Control *>::Element *RI) {
gui.roots.erase(RI);
}
void Viewport::_gui_unfocus_control(Control *p_control) {
if (gui.key_focus == p_control) {
gui.key_focus->release_focus();
}
}
Fixed minor typo, gui_hid -> gui_hide.
2020-09-09 01:08:21 +00:00
void Viewport::_gui_hide_control(Control *p_control) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
if (gui.mouse_focus == p_control) {
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
_drop_mouse_focus();
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (gui.key_focus == p_control) {
Exposes gui_release_focus and gui_get_focus_owner to Viewport
2022-02-01 14:07:22 +00:00
gui_release_focus();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (gui.mouse_over == p_control) {
Refactor mouse_entered and mouse_exited notifications The previous implementation for signals mouse_entered and mouse_exited had shortcomings that relate to focused windows and pressed mouse buttons. For example a Control can be hovered by mouse, even if it is occluded by an embedded window. This patch changes the behavior, so that Control and Viewport send their mouse-enter/exit-notifications based solely on mouse position, visible area, and input restrictions and not on which window has focus or which mouse buttons are pressed. This implicitly also changes when the mouse_entered and mouse_exited signals are sent. This functionality can not be implemented as a part of Viewport::_gui_input_event, because of its interplay with Windows and because Viewport::_gui_input_event is based on input and not on visibility.
2023-01-06 20:48:20 +00:00
_drop_mouse_over();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (gui.drag_mouse_over == p_control) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.drag_mouse_over = nullptr;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
if (gui.tooltip_control == p_control) {
-Changed how popups work in Viewport to make them a lot less invasive to the scene tree
2016-01-25 13:30:03 +00:00
_gui_cancel_tooltip();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
void Viewport::_gui_remove_control(Control *p_control) {
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
if (gui.mouse_focus == p_control) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.mouse_focus = nullptr;
Popups have also been converted to windows Controls using the old modal API have been replaced to use popups.
2020-03-20 02:32:09 +00:00
gui.forced_mouse_focus = false;
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
gui.mouse_focus_mask.clear();
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
}
Fix possible crash with an invalid last_mouse_focus pointer
2019-02-15 01:16:56 +00:00
if (gui.last_mouse_focus == p_control) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.last_mouse_focus = nullptr;
Fix possible crash with an invalid last_mouse_focus pointer
2019-02-15 01:16:56 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (gui.key_focus == p_control) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.key_focus = nullptr;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (gui.mouse_over == p_control) {
Refactor mouse_entered and mouse_exited notifications The previous implementation for signals mouse_entered and mouse_exited had shortcomings that relate to focused windows and pressed mouse buttons. For example a Control can be hovered by mouse, even if it is occluded by an embedded window. This patch changes the behavior, so that Control and Viewport send their mouse-enter/exit-notifications based solely on mouse position, visible area, and input restrictions and not on which window has focus or which mouse buttons are pressed. This implicitly also changes when the mouse_entered and mouse_exited signals are sent. This functionality can not be implemented as a part of Viewport::_gui_input_event, because of its interplay with Windows and because Viewport::_gui_input_event is based on input and not on visibility.
2023-01-06 20:48:20 +00:00
_drop_mouse_over();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (gui.drag_mouse_over == p_control) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.drag_mouse_over = nullptr;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
if (gui.tooltip_control == p_control) {
gui.tooltip_control = nullptr;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Fix doubleclick on tree item, restore input focus on previous windows. Closes #37335
2020-07-01 13:59:42 +00:00
Window *Viewport::get_base_window() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(nullptr);
Fix Viewport crashes when not in tree
2021-06-13 03:36:32 +00:00
ERR_FAIL_COND_V(!is_inside_tree(), nullptr);
Fix doubleclick on tree item, restore input focus on previous windows. Closes #37335
2020-07-01 13:59:42 +00:00
Viewport *v = const_cast<Viewport *>(this);
Window *w = Object::cast_to<Window>(v);
while (!w) {
v = v->get_parent_viewport();
w = Object::cast_to<Window>(v);
}
return w;
}
void Viewport::_gui_remove_focus_for_window(Node *p_window) {
if (get_base_window() == p_window) {
Exposes gui_release_focus and gui_get_focus_owner to Viewport
2022-02-01 14:07:22 +00:00
gui_release_focus();
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
}
bool Viewport::_gui_control_has_focus(const Control *p_control) {
return gui.key_focus == p_control;
}
void Viewport::_gui_control_grab_focus(Control *p_control) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (gui.key_focus && gui.key_focus == p_control) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// No need for change.
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Make `{call,set,notify}_group()` immediate by default This results in less surprising behavior out of the box. Internal usages were modified to keep the existing behavior identical there.
2021-08-12 21:40:13 +00:00
get_tree()->call_group("_viewports", "_gui_remove_focus_for_window", (Node *)get_base_window());
Fix crash when removing child during focus exit.
2023-06-22 23:47:05 +00:00
if (p_control->is_inside_tree() && p_control->get_viewport() == this) {
gui.key_focus = p_control;
emit_signal(SNAME("gui_focus_changed"), p_control);
p_control->notification(Control::NOTIFICATION_FOCUS_ENTER);
p_control->queue_redraw();
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
void Viewport::_gui_accept_event() {
gui.key_event_accepted = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (is_inside_tree()) {
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
set_input_as_handled();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
void Viewport::_drop_mouse_focus() {
Control *c = gui.mouse_focus;
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
BitField<MouseButtonMask> mask = gui.mouse_focus_mask;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.mouse_focus = nullptr;
Popups have also been converted to windows Controls using the old modal API have been replaced to use popups.
2020-03-20 02:32:09 +00:00
gui.forced_mouse_focus = false;
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
gui.mouse_focus_mask.clear();
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
for (int i = 0; i < 3; i++) {
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if ((int)mask & (1 << i)) {
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
Ref<InputEventMouseButton> mb;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
mb.instantiate();
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
mb->set_position(c->get_local_mouse_position());
Fixes crash, closes #24038
2018-11-28 16:09:56 +00:00
mb->set_global_position(c->get_local_mouse_position());
Use mouse and joypad enums instead of plain integers Also MIDIMessage
2021-03-25 20:56:12 +00:00
mb->set_button_index(MouseButton(i + 1));
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
mb->set_pressed(false);
Fix mouse/drag/touch InputEvents having no device id Some internally created emulated/instantiated events didn't have a device id. This PR sets for these cases a device id. Also rename `DEVICE_ID_TOUCH_MOUSE` to the more generic `DEVICE_ID_EMULATION`.
2023-02-04 22:16:54 +00:00
mb->set_device(InputEvent::DEVICE_ID_INTERNAL);
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
c->_call_gui_input(mb);
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
}
}
}
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
void Viewport::_drop_physics_mouseover(bool p_paused_only) {
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
_cleanup_mouseover_colliders(true, p_paused_only);
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#ifndef _3D_DISABLED
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
if (physics_object_over.is_valid()) {
CollisionObject3D *co = Object::cast_to<CollisionObject3D>(ObjectDB::get_instance(physics_object_over));
if (co) {
Fix errors in mouse detection when removing collision object from tree Now behaves the same way as ui elements, mouse exit is skipped when the object is removed from the tree.
2021-10-20 16:02:05 +00:00
if (!co->is_inside_tree()) {
physics_object_over = ObjectID();
physics_object_capture = ObjectID();
} else if (!(p_paused_only && co->can_process())) {
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
co->_mouse_exit();
physics_object_over = ObjectID();
physics_object_capture = ObjectID();
}
}
}
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#endif // _3D_DISABLED
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
}
void Viewport::_cleanup_mouseover_colliders(bool p_clean_all_frames, bool p_paused_only, uint64_t p_frame_reference) {
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
List<ObjectID> to_erase;
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
for (const KeyValue<ObjectID, uint64_t> &E : physics_2d_mouseover) {
if (!p_clean_all_frames && E.value == p_frame_reference) {
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
continue;
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
Object *o = ObjectDB::get_instance(E.key);
Drop mouseover when mouse not in the window Not that this is critical, but it makes behavior of GUI and 2D/3D picking consistent among them. This also contributes to dropping GUI focus when the mouse leaves the window (in addition to when it loses focus).
2019-03-11 00:18:21 +00:00
if (o) {
CollisionObject2D *co = Object::cast_to<CollisionObject2D>(o);
Fix errors in mouse detection when removing collision object from tree Now behaves the same way as ui elements, mouse exit is skipped when the object is removed from the tree.
2021-10-20 16:02:05 +00:00
if (co && co->is_inside_tree()) {
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
if (p_clean_all_frames && p_paused_only && co->can_process()) {
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
continue;
}
co->_mouse_exit();
}
Drop mouseover when mouse not in the window Not that this is critical, but it makes behavior of GUI and 2D/3D picking consistent among them. This also contributes to dropping GUI focus when the mouse leaves the window (in addition to when it loses focus).
2019-03-11 00:18:21 +00:00
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
to_erase.push_back(E.key);
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
}
while (to_erase.size()) {
physics_2d_mouseover.erase(to_erase.front()->get());
to_erase.pop_front();
Drop mouseover when mouse not in the window Not that this is critical, but it makes behavior of GUI and 2D/3D picking consistent among them. This also contributes to dropping GUI focus when the mouse leaves the window (in addition to when it loses focus).
2019-03-11 00:18:21 +00:00
}
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Per-shape.
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
List<Pair<ObjectID, int>> shapes_to_erase;
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
for (KeyValue<Pair<ObjectID, int>, uint64_t> &E : physics_2d_shape_mouseover) {
if (!p_clean_all_frames && E.value == p_frame_reference) {
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
continue;
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
Object *o = ObjectDB::get_instance(E.key.first);
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
if (o) {
CollisionObject2D *co = Object::cast_to<CollisionObject2D>(o);
Fix errors in mouse detection when removing collision object from tree Now behaves the same way as ui elements, mouse exit is skipped when the object is removed from the tree.
2021-10-20 16:02:05 +00:00
if (co && co->is_inside_tree()) {
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
if (p_clean_all_frames && p_paused_only && co->can_process()) {
continue;
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
co->_mouse_shape_exit(E.key.second);
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
}
Drop mouseover when mouse not in the window Not that this is critical, but it makes behavior of GUI and 2D/3D picking consistent among them. This also contributes to dropping GUI focus when the mouse leaves the window (in addition to when it loses focus).
2019-03-11 00:18:21 +00:00
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 13:04:37 +00:00
shapes_to_erase.push_back(E.key);
Add mouse_shape_entered and mouse_shape_exited signals to CollisionObject2D. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2021-03-26 17:39:05 +00:00
}
while (shapes_to_erase.size()) {
physics_2d_shape_mouseover.erase(shapes_to_erase.front()->get());
shapes_to_erase.pop_front();
Drop mouseover when mouse not in the window Not that this is critical, but it makes behavior of GUI and 2D/3D picking consistent among them. This also contributes to dropping GUI focus when the mouse leaves the window (in addition to when it loses focus).
2019-03-11 00:18:21 +00:00
}
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
void Viewport::_gui_grab_click_focus(Control *p_control) {
Improve popup menus usability It seems that popups were intended to "grab" the mouse click that triggered them, but their intent was being lost. This commit does the necessary changes to let it happen and updates items that were trying to get advantage of it, because the semantics of `Control::grab_click_focus()` have changed a bit. Namely, it must be called **before** showing the modal. This allows to popup a menu and activate an item in it in a single click-point-release cycle, instead of having to click once to open the menu and once more to pick an item. This ability is extended even to context menus activated with the RMB (or any other mouse button, for that matter). The editor benefits from this in the context menu of the tree dock, which has been patched to opt-in for this feature. This improves UX a bit by saving unnecessary clicks. From now on, `PopupMenu` always grabs the click and also invalidates the first button release unless the mouse has moved (that's what `set_invalidate_click_until_motion()` was doing and now it's removed), so there is no longer the need of doing both things at every point a pop-up menu is shown.
2018-03-27 21:41:27 +00:00
gui.mouse_click_grabber = p_control;
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
call_deferred(SNAME("_post_gui_grab_click_focus"));
Improve popup menus usability It seems that popups were intended to "grab" the mouse click that triggered them, but their intent was being lost. This commit does the necessary changes to let it happen and updates items that were trying to get advantage of it, because the semantics of `Control::grab_click_focus()` have changed a bit. Namely, it must be called **before** showing the modal. This allows to popup a menu and activate an item in it in a single click-point-release cycle, instead of having to click once to open the menu and once more to pick an item. This ability is extended even to context menus activated with the RMB (or any other mouse button, for that matter). The editor benefits from this in the context menu of the tree dock, which has been patched to opt-in for this feature. This improves UX a bit by saving unnecessary clicks. From now on, `PopupMenu` always grabs the click and also invalidates the first button release unless the mouse has moved (that's what `set_invalidate_click_until_motion()` was doing and now it's removed), so there is no longer the need of doing both things at every point a pop-up menu is shown.
2018-03-27 21:41:27 +00:00
}
void Viewport::_post_gui_grab_click_focus() {
Control *focus_grabber = gui.mouse_click_grabber;
if (!focus_grabber) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Redundant grab requests were made.
Improve popup menus usability It seems that popups were intended to "grab" the mouse click that triggered them, but their intent was being lost. This commit does the necessary changes to let it happen and updates items that were trying to get advantage of it, because the semantics of `Control::grab_click_focus()` have changed a bit. Namely, it must be called **before** showing the modal. This allows to popup a menu and activate an item in it in a single click-point-release cycle, instead of having to click once to open the menu and once more to pick an item. This ability is extended even to context menus activated with the RMB (or any other mouse button, for that matter). The editor benefits from this in the context menu of the tree dock, which has been patched to opt-in for this feature. This improves UX a bit by saving unnecessary clicks. From now on, `PopupMenu` always grabs the click and also invalidates the first button release unless the mouse has moved (that's what `set_invalidate_click_until_motion()` was doing and now it's removed), so there is no longer the need of doing both things at every point a pop-up menu is shown.
2018-03-27 21:41:27 +00:00
return;
}
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
gui.mouse_click_grabber = nullptr;
Improve popup menus usability It seems that popups were intended to "grab" the mouse click that triggered them, but their intent was being lost. This commit does the necessary changes to let it happen and updates items that were trying to get advantage of it, because the semantics of `Control::grab_click_focus()` have changed a bit. Namely, it must be called **before** showing the modal. This allows to popup a menu and activate an item in it in a single click-point-release cycle, instead of having to click once to open the menu and once more to pick an item. This ability is extended even to context menus activated with the RMB (or any other mouse button, for that matter). The editor benefits from this in the context menu of the tree dock, which has been patched to opt-in for this feature. This improves UX a bit by saving unnecessary clicks. From now on, `PopupMenu` always grabs the click and also invalidates the first button release unless the mouse has moved (that's what `set_invalidate_click_until_motion()` was doing and now it's removed), so there is no longer the need of doing both things at every point a pop-up menu is shown.
2018-03-27 21:41:27 +00:00
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
if (gui.mouse_focus) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (gui.mouse_focus == focus_grabber) {
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
BitField<MouseButtonMask> mask = gui.mouse_focus_mask;
-Fix mouse coordinates not being affected by canvas transform
2016-02-03 12:31:18 +00:00
Point2 click = gui.mouse_focus->get_global_transform_with_canvas().affine_inverse().xform(gui.last_mouse_pos);
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
for (int i = 0; i < 3; i++) {
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if ((int)mask & (1 << i)) {
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
Ref<InputEventMouseButton> mb;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
mb.instantiate();
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Send unclick.
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
mb->set_position(click);
Use mouse and joypad enums instead of plain integers Also MIDIMessage
2021-03-25 20:56:12 +00:00
mb->set_button_index(MouseButton(i + 1));
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
mb->set_pressed(false);
Fix mouse/drag/touch InputEvents having no device id Some internally created emulated/instantiated events didn't have a device id. This PR sets for these cases a device id. Also rename `DEVICE_ID_TOUCH_MOUSE` to the more generic `DEVICE_ID_EMULATION`.
2023-02-04 22:16:54 +00:00
mb->set_device(InputEvent::DEVICE_ID_INTERNAL);
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
gui.mouse_focus->_call_gui_input(mb);
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
}
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Improve popup menus usability It seems that popups were intended to "grab" the mouse click that triggered them, but their intent was being lost. This commit does the necessary changes to let it happen and updates items that were trying to get advantage of it, because the semantics of `Control::grab_click_focus()` have changed a bit. Namely, it must be called **before** showing the modal. This allows to popup a menu and activate an item in it in a single click-point-release cycle, instead of having to click once to open the menu and once more to pick an item. This ability is extended even to context menus activated with the RMB (or any other mouse button, for that matter). The editor benefits from this in the context menu of the tree dock, which has been patched to opt-in for this feature. This improves UX a bit by saving unnecessary clicks. From now on, `PopupMenu` always grabs the click and also invalidates the first button release unless the mouse has moved (that's what `set_invalidate_click_until_motion()` was doing and now it's removed), so there is no longer the need of doing both things at every point a pop-up menu is shown.
2018-03-27 21:41:27 +00:00
gui.mouse_focus = focus_grabber;
-Fix mouse coordinates not being affected by canvas transform
2016-02-03 12:31:18 +00:00
click = gui.mouse_focus->get_global_transform_with_canvas().affine_inverse().xform(gui.last_mouse_pos);
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
for (int i = 0; i < 3; i++) {
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if ((int)mask & (1 << i)) {
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
Ref<InputEventMouseButton> mb;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
mb.instantiate();
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Send click.
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
mb->set_position(click);
Use mouse and joypad enums instead of plain integers Also MIDIMessage
2021-03-25 20:56:12 +00:00
mb->set_button_index(MouseButton(i + 1));
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
mb->set_pressed(true);
Fix mouse/drag/touch InputEvents having no device id Some internally created emulated/instantiated events didn't have a device id. This PR sets for these cases a device id. Also rename `DEVICE_ID_TOUCH_MOUSE` to the more generic `DEVICE_ID_EMULATION`.
2023-02-04 22:16:54 +00:00
mb->set_device(InputEvent::DEVICE_ID_INTERNAL);
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
MessageQueue::get_singleton()->push_callable(callable_mp(gui.mouse_focus, &Control::_call_gui_input), mb);
Improved the mouse focus system (mouse keeps focus on a control while buttons are pressed). Fixes #19154 and likely many others. WARNING: Test well in every OS, if mouse wheel events are not properly sent as pressed+unpressed pair, it will fail and break (and the OS needs to be fixed). Only tested on X11 so far.
2018-11-28 12:31:17 +00:00
}
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
}
}
///////////////////////////////
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
void Viewport::push_text_input(const String &p_text) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (gui.subwindow_focused) {
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
gui.subwindow_focused->push_text_input(p_text);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
return;
}
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
if (gui.key_focus) {
gui.key_focus->call("set_text", p_text);
}
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Viewport::SubWindowResize Viewport::_sub_window_get_resize_margin(Window *p_subwindow, const Point2 &p_point) {
Allow embedded windows to be non-resizable This fixes issue #56869.
2022-01-17 20:17:53 +00:00
if (p_subwindow->get_flag(Window::FLAG_BORDERLESS) || p_subwindow->get_flag(Window::FLAG_RESIZE_DISABLED)) {
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
return SUB_WINDOW_RESIZE_DISABLED;
}
Rect2i r = Rect2i(p_subwindow->get_position(), p_subwindow->get_size());
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
int title_height = p_subwindow->get_theme_constant(SNAME("title_height"));
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
r.position.y -= title_height;
r.size.y += title_height;
if (r.has_point(p_point)) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
return SUB_WINDOW_RESIZE_DISABLED; // It's inside, so no resize.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
int dist_x = p_point.x < r.position.x ? (p_point.x - r.position.x) : (p_point.x > (r.position.x + r.size.x) ? (p_point.x - (r.position.x + r.size.x)) : 0);
int dist_y = p_point.y < r.position.y ? (p_point.y - r.position.y) : (p_point.y > (r.position.y + r.size.y) ? (p_point.y - (r.position.y + r.size.y)) : 0);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
int limit = p_subwindow->get_theme_constant(SNAME("resize_margin"));
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (ABS(dist_x) > limit) {
return SUB_WINDOW_RESIZE_DISABLED;
}
if (ABS(dist_y) > limit) {
return SUB_WINDOW_RESIZE_DISABLED;
}
if (dist_x < 0 && dist_y < 0) {
return SUB_WINDOW_RESIZE_TOP_LEFT;
}
if (dist_x == 0 && dist_y < 0) {
return SUB_WINDOW_RESIZE_TOP;
}
if (dist_x > 0 && dist_y < 0) {
return SUB_WINDOW_RESIZE_TOP_RIGHT;
}
if (dist_x < 0 && dist_y == 0) {
return SUB_WINDOW_RESIZE_LEFT;
}
if (dist_x > 0 && dist_y == 0) {
return SUB_WINDOW_RESIZE_RIGHT;
}
if (dist_x < 0 && dist_y > 0) {
return SUB_WINDOW_RESIZE_BOTTOM_LEFT;
}
if (dist_x == 0 && dist_y > 0) {
return SUB_WINDOW_RESIZE_BOTTOM;
}
if (dist_x > 0 && dist_y > 0) {
return SUB_WINDOW_RESIZE_BOTTOM_RIGHT;
}
return SUB_WINDOW_RESIZE_DISABLED;
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
bool Viewport::_sub_windows_forward_input(const Ref<InputEvent> &p_event) {
if (gui.subwindow_drag != SUB_WINDOW_DRAG_DISABLED) {
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
ERR_FAIL_COND_V(gui.currently_dragged_subwindow == nullptr, false);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Ref<InputEventMouseButton> mb = p_event;
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (mb.is_valid() && !mb->is_pressed() && mb->get_button_index() == MouseButton::LEFT) {
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (gui.subwindow_drag == SUB_WINDOW_DRAG_CLOSE) {
if (gui.subwindow_drag_close_rect.has_point(mb->get_position())) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Close window.
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
gui.currently_dragged_subwindow->_event_callback(DisplayServer::WINDOW_EVENT_CLOSE_REQUEST);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
}
gui.subwindow_drag = SUB_WINDOW_DRAG_DISABLED;
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
if (gui.currently_dragged_subwindow != nullptr) { // May have been erased.
_sub_window_update(gui.currently_dragged_subwindow);
gui.currently_dragged_subwindow = nullptr;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
}
Ref<InputEventMouseMotion> mm = p_event;
if (mm.is_valid()) {
if (gui.subwindow_drag == SUB_WINDOW_DRAG_MOVE) {
Vector2 diff = mm->get_position() - gui.subwindow_drag_from;
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
Rect2i new_rect(gui.subwindow_drag_pos + diff, gui.currently_dragged_subwindow->get_size());
Add ability to clamp embedded subwindows to parent, fixes #37792
2020-07-01 15:39:42 +00:00
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
if (gui.currently_dragged_subwindow->is_clamped_to_embedder()) {
new_rect = gui.currently_dragged_subwindow->fit_rect_in_parent(new_rect, get_visible_rect());
Add ability to clamp embedded subwindows to parent, fixes #37792
2020-07-01 15:39:42 +00:00
}
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
gui.currently_dragged_subwindow->_rect_changed_callback(new_rect);
Add more uses of appropriate cursors when resizing/moving some UI nodes
2023-05-07 14:14:57 +00:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_CURSOR_SHAPE)) {
DisplayServer::get_singleton()->cursor_set_shape(DisplayServer::CURSOR_MOVE);
}
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
if (gui.subwindow_drag == SUB_WINDOW_DRAG_CLOSE) {
gui.subwindow_drag_close_inside = gui.subwindow_drag_close_rect.has_point(mm->get_position());
}
if (gui.subwindow_drag == SUB_WINDOW_DRAG_RESIZE) {
Vector2i diff = mm->get_position() - gui.subwindow_drag_from;
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
Size2i min_size = gui.currently_dragged_subwindow->get_min_size();
Size2i min_size_clamped = gui.currently_dragged_subwindow->get_clamped_minimum_size();
Fix some bugs with `Window`s
2022-08-04 20:11:32 +00:00
Use min_size/max_size to limit the window size and the position while popup center
2022-06-18 10:52:30 +00:00
min_size_clamped.x = MAX(min_size_clamped.x, 1);
min_size_clamped.y = MAX(min_size_clamped.y, 1);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Rect2i r = gui.subwindow_resize_from_rect;
Use min_size/max_size to limit the window size and the position while popup center
2022-06-18 10:52:30 +00:00
Size2i limit = r.size - min_size_clamped;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
switch (gui.subwindow_resize_mode) {
case SUB_WINDOW_RESIZE_TOP_LEFT: {
diff.x = MIN(diff.x, limit.x);
diff.y = MIN(diff.y, limit.y);
r.position += diff;
r.size -= diff;
} break;
case SUB_WINDOW_RESIZE_TOP: {
diff.x = 0;
diff.y = MIN(diff.y, limit.y);
r.position += diff;
r.size -= diff;
} break;
case SUB_WINDOW_RESIZE_TOP_RIGHT: {
diff.x = MAX(diff.x, -limit.x);
diff.y = MIN(diff.y, limit.y);
r.position.y += diff.y;
r.size.y -= diff.y;
r.size.x += diff.x;
} break;
case SUB_WINDOW_RESIZE_LEFT: {
diff.x = MIN(diff.x, limit.x);
diff.y = 0;
r.position += diff;
r.size -= diff;
} break;
case SUB_WINDOW_RESIZE_RIGHT: {
diff.x = MAX(diff.x, -limit.x);
r.size.x += diff.x;
} break;
case SUB_WINDOW_RESIZE_BOTTOM_LEFT: {
diff.x = MIN(diff.x, limit.x);
diff.y = MAX(diff.y, -limit.y);
r.position.x += diff.x;
r.size.x -= diff.x;
r.size.y += diff.y;
} break;
case SUB_WINDOW_RESIZE_BOTTOM: {
diff.y = MAX(diff.y, -limit.y);
r.size.y += diff.y;
} break;
case SUB_WINDOW_RESIZE_BOTTOM_RIGHT: {
diff.x = MAX(diff.x, -limit.x);
diff.y = MAX(diff.y, -limit.y);
r.size += diff;
} break;
default: {
}
}
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
Size2i max_size = gui.currently_dragged_subwindow->get_max_size();
Fix some bugs with `Window`s
2022-08-04 20:11:32 +00:00
if ((max_size.x > 0 || max_size.y > 0) && (max_size.x >= min_size.x && max_size.y >= min_size.y)) {
max_size.x = MAX(max_size.x, 1);
max_size.y = MAX(max_size.y, 1);
if (r.size.x > max_size.x) {
r.size.x = max_size.x;
}
if (r.size.y > max_size.y) {
r.size.y = max_size.y;
}
}
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
gui.currently_dragged_subwindow->_rect_changed_callback(r);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
if (gui.currently_dragged_subwindow) { // May have been erased.
_sub_window_update(gui.currently_dragged_subwindow);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
}
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
return true; // Handled.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
Ref<InputEventMouseButton> mb = p_event;
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// If the event is a mouse button, we need to check whether another window was clicked.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (mb.is_valid() && mb->is_pressed() && mb->get_button_index() == MouseButton::LEFT) {
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
Window *click_on_window = nullptr;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
for (int i = gui.sub_windows.size() - 1; i >= 0; i--) {
Don't obtain a reference to a subwindow Fixes the wrong location being accessed after changing the order of embedded windows. This commit also removes an unused variable.
2021-11-29 23:36:47 +00:00
SubWindow sw = gui.sub_windows.write[i];
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Clicked inside window?
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Rect2i r = Rect2i(sw.window->get_position(), sw.window->get_size());
if (!sw.window->get_flag(Window::FLAG_BORDERLESS)) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Check top bar.
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
int title_height = sw.window->get_theme_constant(SNAME("title_height"));
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Rect2i title_bar = r;
title_bar.position.y -= title_height;
title_bar.size.y = title_height;
Fix error when attempting to move a embedded window with a negative title height
2023-05-28 19:46:16 +00:00
if (title_bar.size.y > 0 && title_bar.has_point(mb->get_position())) {
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
click_on_window = sw.window;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Rename theme properties to include underscores - check_vadjust -> check_v_adjust - close_h_ofs -> close_h_offset - close_v_ofs -> close_v_offset - commentfocus -> comment_focus - hseparation -> h_separation - ofs -> offset - selectedframe -> selected_frame - state_machine_selectedframe -> state_machine_selected_frame - table_hseparation -> table_h_separation - table_vseparation -> table_v_separation - vseparation -> v_separation
2022-04-14 21:20:28 +00:00
int close_h_ofs = sw.window->get_theme_constant(SNAME("close_h_offset"));
int close_v_ofs = sw.window->get_theme_constant(SNAME("close_v_offset"));
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
Ref<Texture2D> close_icon = sw.window->get_theme_icon(SNAME("close"));
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Rect2 close_rect;
Fix some bugs with `Window`s
2022-08-04 20:11:32 +00:00
close_rect.position = Vector2(r.position.x + r.size.x - close_h_ofs, r.position.y - close_v_ofs);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
close_rect.size = close_icon->get_size();
if (gui.subwindow_focused != sw.window) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Refocus.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
_sub_window_grab_focus(sw.window);
}
if (close_rect.has_point(mb->get_position())) {
gui.subwindow_drag = SUB_WINDOW_DRAG_CLOSE;
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
gui.subwindow_drag_close_inside = true; // Starts inside.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
gui.subwindow_drag_close_rect = close_rect;
} else {
gui.subwindow_drag = SUB_WINDOW_DRAG_MOVE;
}
gui.subwindow_drag_from = mb->get_position();
gui.subwindow_drag_pos = sw.window->get_position();
_sub_window_update(sw.window);
} else {
Implemented drag and drop across windows, both OS and embedded.
2020-03-24 23:15:35 +00:00
gui.subwindow_resize_mode = _sub_window_get_resize_margin(sw.window, mb->get_position());
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (gui.subwindow_resize_mode != SUB_WINDOW_RESIZE_DISABLED) {
Fix Windowfocus on resizing When resizing a non-focused window, the previously focused Window got resized. This patch grabs focus for the actually resized window, before starting with the resizing.
2022-11-04 21:24:00 +00:00
if (gui.subwindow_focused != sw.window) {
// Refocus.
_sub_window_grab_focus(sw.window);
}
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
gui.subwindow_resize_from_rect = r;
gui.subwindow_drag_from = mb->get_position();
gui.subwindow_drag = SUB_WINDOW_DRAG_RESIZE;
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
click_on_window = sw.window;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
}
}
if (!click_on_window && r.has_point(mb->get_position())) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Clicked, see if it needs to fetch focus.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (gui.subwindow_focused != sw.window) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Refocus.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
_sub_window_grab_focus(sw.window);
}
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
click_on_window = sw.window;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
if (click_on_window) {
break;
}
}
Fix input handling of unfocusable embedded Windows InputEvents get in some cases sent to the wrong Window. fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-04 17:09:54 +00:00
gui.currently_dragged_subwindow = click_on_window;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
if (!click_on_window && gui.subwindow_focused) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// No window found and clicked, remove focus.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
_sub_window_grab_focus(nullptr);
}
}
if (gui.subwindow_focused) {
Ref<InputEventMouseMotion> mm = p_event;
if (mm.is_valid()) {
SubWindowResize resize = _sub_window_get_resize_margin(gui.subwindow_focused, mm->get_position());
if (resize != SUB_WINDOW_RESIZE_DISABLED) {
DisplayServer::CursorShape shapes[SUB_WINDOW_RESIZE_MAX] = {
DisplayServer::CURSOR_ARROW,
DisplayServer::CURSOR_FDIAGSIZE,
DisplayServer::CURSOR_VSIZE,
DisplayServer::CURSOR_BDIAGSIZE,
DisplayServer::CURSOR_HSIZE,
DisplayServer::CURSOR_HSIZE,
DisplayServer::CURSOR_BDIAGSIZE,
DisplayServer::CURSOR_VSIZE,
DisplayServer::CURSOR_FDIAGSIZE
};
Avoid warnings about cursor shape change not supported
2022-08-23 09:14:07 +00:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_CURSOR_SHAPE)) {
DisplayServer::get_singleton()->cursor_set_shape(shapes[resize]);
}
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
return true; // Reserved for showing the resize cursor.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
}
}
if (gui.subwindow_drag != SUB_WINDOW_DRAG_DISABLED) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
return true; // Dragging, don't pass the event.
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
if (!gui.subwindow_focused) {
return false;
}
Transform2D window_ofs;
window_ofs.set_origin(-gui.subwindow_focused->get_position());
Ref<InputEvent> ev = p_event->xformed_by(window_ofs);
gui.subwindow_focused->_window_input(ev);
return true;
}
Refactor mouse_entered and mouse_exited notifications The previous implementation for signals mouse_entered and mouse_exited had shortcomings that relate to focused windows and pressed mouse buttons. For example a Control can be hovered by mouse, even if it is occluded by an embedded window. This patch changes the behavior, so that Control and Viewport send their mouse-enter/exit-notifications based solely on mouse position, visible area, and input restrictions and not on which window has focus or which mouse buttons are pressed. This implicitly also changes when the mouse_entered and mouse_exited signals are sent. This functionality can not be implemented as a part of Viewport::_gui_input_event, because of its interplay with Windows and because Viewport::_gui_input_event is based on input and not on visibility.
2023-01-06 20:48:20 +00:00
void Viewport::_update_mouse_over() {
// Update gui.mouse_over and gui.subwindow_over in all Viewports.
// Send necessary mouse_enter/mouse_exit signals and the NOTIFICATION_VP_MOUSE_ENTER/NOTIFICATION_VP_MOUSE_EXIT notifications for every Viewport in the SceneTree.
if (is_attached_in_viewport()) {
// Execute this function only, when it is processed by a native Window or a SubViewport, that has no SubViewportContainer as parent.
return;
}
if (get_tree()->get_root()->is_embedding_subwindows() || is_sub_viewport()) {
// Use embedder logic for calculating mouse position.
_update_mouse_over(gui.last_mouse_pos);
} else {
// Native Window: Use DisplayServer logic for calculating mouse position.
Window *receiving_window = get_tree()->get_root()->gui.windowmanager_window_over;
if (!receiving_window) {
return;
}
Vector2 pos = DisplayServer::get_singleton()->mouse_get_position() - receiving_window->get_position();
pos = receiving_window->get_final_transform().affine_inverse().xform(pos);
receiving_window->_update_mouse_over(pos);
}
}
void Viewport::_update_mouse_over(Vector2 p_pos) {
// Look for embedded windows at mouse position.
if (is_embedding_subwindows()) {
for (int i = gui.sub_windows.size() - 1; i >= 0; i--) {
Window *sw = gui.sub_windows[i].window;
Rect2 swrect = Rect2(sw->get_position(), sw->get_size());
Rect2 swrect_border = swrect;
if (!sw->get_flag(Window::FLAG_BORDERLESS)) {
int title_height = sw->get_theme_constant(SNAME("title_height"));
int margin = sw->get_theme_constant(SNAME("resize_margin"));
swrect_border.position.y -= title_height + margin;
swrect_border.size.y += title_height + margin * 2;
swrect_border.position.x -= margin;
swrect_border.size.x += margin * 2;
}
if (swrect_border.has_point(p_pos)) {
if (gui.mouse_over) {
_drop_mouse_over();
} else if (!gui.subwindow_over) {
_drop_physics_mouseover();
}
if (swrect.has_point(p_pos)) {
if (sw != gui.subwindow_over) {
if (gui.subwindow_over) {
gui.subwindow_over->_mouse_leave_viewport();
}
gui.subwindow_over = sw;
if (!sw->is_input_disabled()) {
sw->notification(NOTIFICATION_VP_MOUSE_ENTER);
}
}
if (!sw->is_input_disabled()) {
sw->_update_mouse_over(sw->get_final_transform().affine_inverse().xform(p_pos - sw->get_position()));
}
} else {
if (gui.subwindow_over) {
gui.subwindow_over->_mouse_leave_viewport();
gui.subwindow_over = nullptr;
}
}
return;
}
}
if (gui.subwindow_over) {
// Take care of moving mouse out of any embedded Window.
gui.subwindow_over->_mouse_leave_viewport();
gui.subwindow_over = nullptr;
}
}
// Look for Controls at mouse position.
Control *over = gui_find_control(p_pos);
bool notify_embedded_viewports = false;
if (over != gui.mouse_over) {
if (gui.mouse_over) {
_drop_mouse_over();
} else {
_drop_physics_mouseover();
}
gui.mouse_over = over;
if (over) {
over->notification(Control::NOTIFICATION_MOUSE_ENTER);
notify_embedded_viewports = true;
}
}
if (over) {
SubViewportContainer *c = Object::cast_to<SubViewportContainer>(over);
if (!c) {
return;
}
Vector2 pos = c->get_global_transform_with_canvas().affine_inverse().xform(p_pos);
if (c->is_stretch_enabled()) {
pos /= c->get_stretch_shrink();
}
for (int i = 0; i < c->get_child_count(); i++) {
SubViewport *v = Object::cast_to<SubViewport>(c->get_child(i));
if (!v || v->is_input_disabled()) {
continue;
}
if (notify_embedded_viewports) {
v->notification(NOTIFICATION_VP_MOUSE_ENTER);
}
v->_update_mouse_over(v->get_final_transform().affine_inverse().xform(pos));
}
}
}
void Viewport::_mouse_leave_viewport() {
if (!is_inside_tree() || is_input_disabled()) {
return;
}
if (gui.subwindow_over) {
gui.subwindow_over->_mouse_leave_viewport();
gui.subwindow_over = nullptr;
} else if (gui.mouse_over) {
_drop_mouse_over();
}
notification(NOTIFICATION_VP_MOUSE_EXIT);
}
void Viewport::_drop_mouse_over() {
_gui_cancel_tooltip();
SubViewportContainer *c = Object::cast_to<SubViewportContainer>(gui.mouse_over);
if (c) {
for (int i = 0; i < c->get_child_count(); i++) {
SubViewport *v = Object::cast_to<SubViewport>(c->get_child(i));
if (!v) {
continue;
}
v->_mouse_leave_viewport();
}
}
if (gui.mouse_over->is_inside_tree()) {
gui.mouse_over->notification(Control::NOTIFICATION_MOUSE_EXIT);
}
gui.mouse_over = nullptr;
}
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
void Viewport::push_input(const Ref<InputEvent> &p_event, bool p_local_coords) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
SceneMainLoop -> SceneTree -=-=-=-=-=-=-=-=-=-=-=-=-=- *YOUR SOURCE MIGHT NOT WORK* For mor information on fix: https://github.com/okamstudio/godot/wiki/devel_scene_tree Other stuff: -Shower of bullets demo -Fixes all around
2014-11-06 00:20:42 +00:00
ERR_FAIL_COND(!is_inside_tree());
check for null event in Viewport::push_input
2023-05-14 14:04:12 +00:00
ERR_FAIL_COND(p_event.is_null());
-fixed bug related to mouse cursor changes, fixes #3366
2016-01-18 22:49:11 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (disable_input) {
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
Rename `is_a_parent_of()` to `is_ancestor_of()`
2021-06-18 22:02:50 +00:00
if (Engine::get_singleton()->is_editor_hint() && get_tree()->get_edited_scene_root() && get_tree()->get_edited_scene_root()->is_ancestor_of(this)) {
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
return;
}
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
local_input_handled = false;
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
Ref<InputEvent> ev;
if (!p_local_coords) {
ev = _make_input_local(p_event);
} else {
ev = p_event;
}
Always update Viewport's last_mosue_position When the mouse cursor is over a embedded Window, the Viewport's last_mouse_position did not get updated. This patch makes sure that the update happens on every InputEventMouse. Document canvas layer of embedded Windows.
2022-10-14 08:29:28 +00:00
Ref<InputEventMouse> me = ev;
if (me.is_valid()) {
gui.last_mouse_pos = me->get_position();
Refactor mouse_entered and mouse_exited notifications The previous implementation for signals mouse_entered and mouse_exited had shortcomings that relate to focused windows and pressed mouse buttons. For example a Control can be hovered by mouse, even if it is occluded by an embedded window. This patch changes the behavior, so that Control and Viewport send their mouse-enter/exit-notifications based solely on mouse position, visible area, and input restrictions and not on which window has focus or which mouse buttons are pressed. This implicitly also changes when the mouse_entered and mouse_exited signals are sent. This functionality can not be implemented as a part of Viewport::_gui_input_event, because of its interplay with Windows and because Viewport::_gui_input_event is based on input and not on visibility.
2023-01-06 20:48:20 +00:00
_update_mouse_over();
Always update Viewport's last_mosue_position When the mouse cursor is over a embedded Window, the Viewport's last_mouse_position did not get updated. This patch makes sure that the update happens on every InputEventMouse. Document canvas layer of embedded Windows.
2022-10-14 08:29:28 +00:00
}
Fix coordinate system for stretched viewports for subwindows.
2022-03-13 17:45:09 +00:00
if (is_embedding_subwindows() && _sub_windows_forward_input(ev)) {
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
set_input_as_handled();
return;
}
Ensure embedded mode works again Also implemented application in/out notifications in X11.
2020-07-01 12:27:43 +00:00
if (!_can_consume_input_events()) {
return;
}
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
if (!is_input_handled()) {
Prevent crashes when removing Viewport from scene tree in event handler
2023-06-02 07:47:13 +00:00
ERR_FAIL_COND(!is_inside_tree());
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
get_tree()->_call_input_pause(input_group, SceneTree::CALL_INPUT_TYPE_INPUT, ev, this); //not a bug, must happen before GUI, order is _input -> gui input -> _unhandled input
Check if input is handled before handling it
2017-10-16 12:13:33 +00:00
}
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
if (!is_input_handled()) {
Prevent crashes when removing Viewport from scene tree in event handler
2023-06-02 07:47:13 +00:00
ERR_FAIL_COND(!is_inside_tree());
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
_gui_input_event(ev);
Cleanup internal GUI state, if event is accepted in _input.
2022-03-13 22:54:13 +00:00
} else {
// Cleanup internal GUI state after accepting event during _input().
_gui_cleanup_internal_state(ev);
Check if input is handled before handling it
2017-10-16 12:13:33 +00:00
}
Fix doubleclick on tree item, restore input focus on previous windows. Closes #37335
2020-07-01 13:59:42 +00:00
Move call of `push_unhandled_input` from `Window` to `Viewport` This solves the problem, that mouse events get sent to SubViewports even if they are outside of the visible area of the SubViewport. This changes makes SubViewportContainer::unhandled_input redundand. Shortcut Events now need to be distributed via push_input, in order for them to be able to reach SubViewports.
2022-03-31 09:53:47 +00:00
if (!is_input_handled()) {
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
_push_unhandled_input_internal(ev);
Move call of `push_unhandled_input` from `Window` to `Viewport` This solves the problem, that mouse events get sent to SubViewports even if they are outside of the visible area of the SubViewport. This changes makes SubViewportContainer::unhandled_input redundand. Shortcut Events now need to be distributed via push_input, in order for them to be able to reach SubViewports.
2022-03-31 09:53:47 +00:00
}
Fix doubleclick on tree item, restore input focus on previous windows. Closes #37335
2020-07-01 13:59:42 +00:00
event_count++;
-Fixed a few bugs in Viewport -Made a few demos using Viewport to show it's true power! -Fixed some start-up error messages.
2014-04-10 03:18:27 +00:00
}
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
#ifndef DISABLE_DEPRECATED
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
void Viewport::push_unhandled_input(const Ref<InputEvent> &p_event, bool p_local_coords) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Documentation: Unify deprecations
2023-06-06 08:27:29 +00:00
WARN_DEPRECATED_MSG(R"*(The "push_unhandled_input()" method is deprecated, use "push_input()" instead.)*");
SceneMainLoop -> SceneTree -=-=-=-=-=-=-=-=-=-=-=-=-=- *YOUR SOURCE MIGHT NOT WORK* For mor information on fix: https://github.com/okamstudio/godot/wiki/devel_scene_tree Other stuff: -Shower of bullets demo -Fixes all around
2014-11-06 00:20:42 +00:00
ERR_FAIL_COND(!is_inside_tree());
Documentation: Unify deprecations
2023-06-06 08:27:29 +00:00
ERR_FAIL_COND(p_event.is_null());
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
local_input_handled = false;
-Fixed a few bugs in Viewport -Made a few demos using Viewport to show it's true power! -Fixed some start-up error messages.
2014-04-10 03:18:27 +00:00
Ensure embedded mode works again Also implemented application in/out notifications in X11.
2020-07-01 12:27:43 +00:00
if (disable_input || !_can_consume_input_events()) {
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
Rename `is_a_parent_of()` to `is_ancestor_of()`
2021-06-18 22:02:50 +00:00
if (Engine::get_singleton()->is_editor_hint() && get_tree()->get_edited_scene_root() && get_tree()->get_edited_scene_root()->is_ancestor_of(this)) {
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
return;
}
Ref<InputEvent> ev;
if (!p_local_coords) {
ev = _make_input_local(p_event);
} else {
ev = p_event;
}
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
_push_unhandled_input_internal(ev);
}
#endif // DISABLE_DEPRECATED
void Viewport::_push_unhandled_input_internal(const Ref<InputEvent> &p_event) {
[Input] Add extra `shortcut_input` input processing step to process Unicode character input with Alt / Ctrl modifiers, after processing of shortcuts.
2022-01-11 13:59:52 +00:00
// Shortcut Input.
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
if (Object::cast_to<InputEventKey>(*p_event) != nullptr || Object::cast_to<InputEventShortcut>(*p_event) != nullptr || Object::cast_to<InputEventJoypadButton>(*p_event) != nullptr) {
Prevent crashes when removing Viewport from scene tree in event handler
2023-06-02 07:47:13 +00:00
ERR_FAIL_COND(!is_inside_tree());
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
get_tree()->_call_input_pause(shortcut_input_group, SceneTree::CALL_INPUT_TYPE_SHORTCUT_INPUT, p_event, this);
[Input] Add extra `shortcut_input` input processing step to process Unicode character input with Alt / Ctrl modifiers, after processing of shortcuts.
2022-01-11 13:59:52 +00:00
}
// Unhandled key Input - Used for performance reasons - This is called a lot less than _unhandled_input since it ignores MouseMotion, and to handle Unicode input with Alt / Ctrl modifiers after handling shortcuts.
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
if (!is_input_handled() && (Object::cast_to<InputEventKey>(*p_event) != nullptr)) {
Prevent crashes when removing Viewport from scene tree in event handler
2023-06-02 07:47:13 +00:00
ERR_FAIL_COND(!is_inside_tree());
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
get_tree()->_call_input_pause(unhandled_key_input_group, SceneTree::CALL_INPUT_TYPE_UNHANDLED_KEY_INPUT, p_event, this);
-Fixed a few bugs in Viewport -Made a few demos using Viewport to show it's true power! -Fixed some start-up error messages.
2014-04-10 03:18:27 +00:00
}
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
Make `SubViewportContainer` event propagation aware of focused Control Propagate `InputEvents` without position either - during the Input-stage, when it has focus or - during the Unhandled-Input-stage, otherwise This makes sure that Gui-Input happens in the correct order. Move "Unhandled key Input" handling before "Unhandled Input" handling, so that Unicode input with Alt / Ctrl modifiers are sent to the nodes in the correct order. Change the default focus mode of `SubViewportContainer` from `FOCUS_NONE` to `FOCUS_CLICK`, to automatically remove focus from other `Control`-nodes, when clicking inside a `SubViewport`.
2023-07-09 17:23:19 +00:00
// Unhandled Input.
if (!is_input_handled()) {
ERR_FAIL_COND(!is_inside_tree());
get_tree()->_call_input_pause(unhandled_input_group, SceneTree::CALL_INPUT_TYPE_UNHANDLED_INPUT, p_event, this);
}
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
if (physics_object_picking && !is_input_handled()) {
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 13:19:37 +00:00
if (Input::get_singleton()->get_mouse_mode() != Input::MOUSE_MODE_CAPTURED &&
Fix passive mouse hovering for physics Currently mouse hovering doesn't update the state, when collision objects or the camera move. This PR fixes this problem by taking the mouse position from the viewport and not from a nonexistent previous event. Since previous events could potentially be a long time ago, their modifier-key state might be outdated. This PR fetches the current status of modifier-keys from `Input`. These changes allow the removal of some class-variables and making additional simplifications.
2023-06-08 19:04:38 +00:00
(Object::cast_to<InputEventMouse>(*p_event) ||
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
Object::cast_to<InputEventScreenDrag>(*p_event) ||
Fix passive mouse hovering for physics Currently mouse hovering doesn't update the state, when collision objects or the camera move. This PR fixes this problem by taking the mouse position from the viewport and not from a nonexistent previous event. Since previous events could potentially be a long time ago, their modifier-key state might be outdated. This PR fetches the current status of modifier-keys from `Input`. These changes allow the removal of some class-variables and making additional simplifications.
2023-06-08 19:04:38 +00:00
Object::cast_to<InputEventScreenTouch>(*p_event)
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
Fix passive mouse hovering for physics Currently mouse hovering doesn't update the state, when collision objects or the camera move. This PR fixes this problem by taking the mouse position from the viewport and not from a nonexistent previous event. Since previous events could potentially be a long time ago, their modifier-key state might be outdated. This PR fetches the current status of modifier-keys from `Input`. These changes allow the removal of some class-variables and making additional simplifications.
2023-06-08 19:04:38 +00:00
)) {
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
physics_picking_events.push_back(p_event);
Fix InputEvent being used twice A single mouse click can cause multiple actions, which contradicts the paradigm that a single Input Event should cause only a single action. The solution consists of two parts: 1. Physics Picking as the last step during viewport input event handling, currently doesn't set the event as handled. This PR sets the event as handled in the case of physics picking. 2. After an InputEvent is processed by a SubVieportContainer, it is sent to its parent, even if it set as handled within the SubViewport. This PR adds an additional test to check if the event is handled before propagating the event to the parent Control.
2023-05-28 22:29:44 +00:00
set_input_as_handled();
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
}
}
-Fixed a few bugs in Viewport -Made a few demos using Viewport to show it's true power! -Fixed some start-up error messages.
2014-04-10 03:18:27 +00:00
}
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
void Viewport::set_physics_object_picking(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
physics_object_picking = p_enable;
Editor StringName and Viewport optimizations * Added explicit return type to the SNAME macro. * Add some extra SNAME usages. * Change some ClassDB methods to use const StringName & arguments. * Cache the Window parent in Control because it's used in is_layout_rtl(), which is called often. * Only enable internal processing for viewports that need it. * Change CanvasItem::group to be a StringName because it's only used as that.
2021-07-19 17:25:15 +00:00
if (physics_object_picking) {
add_to_group("_picking_viewports");
} else {
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
physics_picking_events.clear();
Editor StringName and Viewport optimizations * Added explicit return type to the SNAME macro. * Add some extra SNAME usages. * Change some ClassDB methods to use const StringName & arguments. * Cache the Window parent in Control because it's used in is_layout_rtl(), which is called often. * Only enable internal processing for viewports that need it. * Change CanvasItem::group to be a StringName because it's only used as that.
2021-07-19 17:25:15 +00:00
if (is_in_group("_picking_viewports")) {
remove_from_group("_picking_viewports");
}
Viewport: Fix missing tooltips w/ disabled physics object picking Previously this option seemed to be the sole responsible for enabling physics processing in Viewport, while several other features like tooltips and debugging collision hints rely on it. All this logic is moved to internal processing (it's incorrect to let it be affected by users disabling physics/idle processing), and disabling physics object picking no longer affects the internal physics processing. Fixes #17001.
2018-03-01 13:44:45 +00:00
}
}
bool Viewport::get_physics_object_picking() {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Viewport: Fix missing tooltips w/ disabled physics object picking Previously this option seemed to be the sole responsible for enabling physics processing in Viewport, while several other features like tooltips and debugging collision hints rely on it. All this logic is moved to internal processing (it's incorrect to let it be affected by users disabling physics/idle processing), and disabling physics object picking no longer affects the internal physics processing. Fixes #17001.
2018-03-01 13:44:45 +00:00
return physics_object_picking;
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
}
Fix propagation order for 2D physics picking events This patch adds a viewport-configuration-option for sorting physics-picking events by the Z-Index and the scene tree position of the collision objects.
2022-11-10 21:55:57 +00:00
void Viewport::set_physics_object_picking_sort(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Fix propagation order for 2D physics picking events This patch adds a viewport-configuration-option for sorting physics-picking events by the Z-Index and the scene tree position of the collision objects.
2022-11-10 21:55:57 +00:00
physics_object_picking_sort = p_enable;
}
bool Viewport::get_physics_object_picking_sort() {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Fix propagation order for 2D physics picking events This patch adds a viewport-configuration-option for sorting physics-picking events by the Z-Index and the scene tree position of the collision objects.
2022-11-10 21:55:57 +00:00
return physics_object_picking_sort;
}
-Much improvement to baked light baker -Fixed many bugs in stretch mode -Fixes to camera project and unproject as consequence of the above -added setget to script (documented in script doc) -more fixes to collada exporter for blender
2014-10-28 01:54:32 +00:00
Vector2 Viewport::get_camera_coords(const Vector2 &p_viewport_coords) const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Vector2());
Include the Window-transform into Viewport::get_final_transform
2022-10-01 06:40:11 +00:00
Transform2D xf = stretch_transform * global_canvas_transform;
-Much improvement to baked light baker -Fixed many bugs in stretch mode -Fixes to camera project and unproject as consequence of the above -added setget to script (documented in script doc) -more fixes to collada exporter for blender
2014-10-28 01:54:32 +00:00
return xf.xform(p_viewport_coords);
}
Vector2 Viewport::get_camera_rect_size() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Vector2());
PBR more or less working, still working on bringing gizmos back
2016-10-27 14:50:26 +00:00
return size;
-Much improvement to baked light baker -Fixed many bugs in stretch mode -Fixes to camera project and unproject as consequence of the above -added setget to script (documented in script doc) -more fixes to collada exporter for blender
2014-10-28 01:54:32 +00:00
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
void Viewport::set_disable_input(bool p_disable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Drop mouse focus and over when gui input is globally disabled
2022-03-13 11:43:32 +00:00
if (p_disable == disable_input) {
return;
}
if (p_disable) {
_drop_mouse_focus();
Refactor mouse_entered and mouse_exited notifications The previous implementation for signals mouse_entered and mouse_exited had shortcomings that relate to focused windows and pressed mouse buttons. For example a Control can be hovered by mouse, even if it is occluded by an embedded window. This patch changes the behavior, so that Control and Viewport send their mouse-enter/exit-notifications based solely on mouse position, visible area, and input restrictions and not on which window has focus or which mouse buttons are pressed. This implicitly also changes when the mouse_entered and mouse_exited signals are sent. This functionality can not be implemented as a part of Viewport::_gui_input_event, because of its interplay with Windows and because Viewport::_gui_input_event is based on input and not on visibility.
2023-01-06 20:48:20 +00:00
_mouse_leave_viewport();
Drop mouse focus and over when gui input is globally disabled
2022-03-13 11:43:32 +00:00
_gui_cancel_tooltip();
}
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
disable_input = p_disable;
}
bool Viewport::is_input_disabled() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
return disable_input;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
Variant Viewport::gui_get_drag_data() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Variant());
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
return gui.drag_data;
}
-Added configuration warning system for nodes -Added a new "add" and "instance" buttons for scene tree -Added a vformat() function to ease translation work
2016-05-17 21:27:15 +00:00
Change return type of `get_configuration_warnings` to `PackedStringArray`
2022-09-19 15:43:15 +00:00
PackedStringArray Viewport::get_configuration_warnings() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD_V(PackedStringArray());
Change return type of `get_configuration_warnings` to `PackedStringArray`
2022-09-19 15:43:15 +00:00
PackedStringArray warnings = Node::get_configuration_warnings();
Update all get_configuration_warning to retrieve warnings from the parent
2020-05-14 20:59:27 +00:00
Tweak the Viewport configuration warning to mention 2×2 size requirement
2021-10-01 14:36:28 +00:00
if (size.x <= 1 || size.y <= 1) {
warnings.push_back(RTR("The Viewport size must be greater than or equal to 2 pixels on both dimensions to render anything."));
Add size warning to Viewport Node
2020-03-17 20:33:36 +00:00
}
Use Array for node configuration warnings Previously, the warnings were passed as a string and delimitation of which were hard coded at each implementation.
2020-10-29 10:01:28 +00:00
return warnings;
-Added configuration warning system for nodes -Added a new "add" and "instance" buttons for scene tree -Added a vformat() function to ease translation work
2016-05-17 21:27:15 +00:00
}
Begining of GLES3 renderer: -Most 2D drawing is implemented -Missing shaders -Missing all 3D -Editor needs to be set on update always to be used, otherwise it does not refresh -Large parts of editor not working
2016-10-03 19:33:42 +00:00
void Viewport::gui_reset_canvas_sort_index() {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Begining of GLES3 renderer: -Most 2D drawing is implemented -Missing shaders -Missing all 3D -Editor needs to be set on update always to be used, otherwise it does not refresh -Large parts of editor not working
2016-10-03 19:33:42 +00:00
gui.canvas_sort_index = 0;
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Begining of GLES3 renderer: -Most 2D drawing is implemented -Missing shaders -Missing all 3D -Editor needs to be set on update always to be used, otherwise it does not refresh -Large parts of editor not working
2016-10-03 19:33:42 +00:00
int Viewport::gui_get_canvas_sort_index() {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD_V(0);
Begining of GLES3 renderer: -Most 2D drawing is implemented -Missing shaders -Missing all 3D -Editor needs to be set on update always to be used, otherwise it does not refresh -Large parts of editor not working
2016-10-03 19:33:42 +00:00
return gui.canvas_sort_index++;
}
Exposes gui_release_focus and gui_get_focus_owner to Viewport
2022-02-01 14:07:22 +00:00
void Viewport::gui_release_focus() {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Exposes gui_release_focus and gui_get_focus_owner to Viewport
2022-02-01 14:07:22 +00:00
if (gui.key_focus) {
Control *f = gui.key_focus;
gui.key_focus = nullptr;
f->notification(Control::NOTIFICATION_FOCUS_EXIT, true);
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 21:21:24 +00:00
f->queue_redraw();
Exposes gui_release_focus and gui_get_focus_owner to Viewport
2022-02-01 14:07:22 +00:00
}
}
Make `Viewport::gui_get_focus_owner` const
2023-06-02 14:57:10 +00:00
Control *Viewport::gui_get_focus_owner() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(nullptr);
Exposes gui_release_focus and gui_get_focus_owner to Viewport
2022-02-01 14:07:22 +00:00
return gui.key_focus;
}
Implement MSAA for 2D [Vulkan only]
2022-08-12 23:02:32 +00:00
void Viewport::set_msaa_2d(MSAA p_msaa) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Add screen space AA option, with FXAA implementation.
2020-04-12 04:49:10 +00:00
ERR_FAIL_INDEX(p_msaa, MSAA_MAX);
Implement MSAA for 2D [Vulkan only]
2022-08-12 23:02:32 +00:00
if (msaa_2d == p_msaa) {
WIP particle system Ability to enable and change MSAA settings Ability to change VCT quality Ability to enable/disable HDR rendering
2017-01-02 01:16:52 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Implement MSAA for 2D [Vulkan only]
2022-08-12 23:02:32 +00:00
msaa_2d = p_msaa;
RS::get_singleton()->viewport_set_msaa_2d(viewport, RS::ViewportMSAA(p_msaa));
WIP particle system Ability to enable and change MSAA settings Ability to change VCT quality Ability to enable/disable HDR rendering
2017-01-02 01:16:52 +00:00
}
Implement MSAA for 2D [Vulkan only]
2022-08-12 23:02:32 +00:00
Viewport::MSAA Viewport::get_msaa_2d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(MSAA_DISABLED);
Implement MSAA for 2D [Vulkan only]
2022-08-12 23:02:32 +00:00
return msaa_2d;
}
void Viewport::set_msaa_3d(MSAA p_msaa) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Implement MSAA for 2D [Vulkan only]
2022-08-12 23:02:32 +00:00
ERR_FAIL_INDEX(p_msaa, MSAA_MAX);
if (msaa_3d == p_msaa) {
return;
}
msaa_3d = p_msaa;
RS::get_singleton()->viewport_set_msaa_3d(viewport, RS::ViewportMSAA(p_msaa));
}
Viewport::MSAA Viewport::get_msaa_3d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(MSAA_DISABLED);
Implement MSAA for 2D [Vulkan only]
2022-08-12 23:02:32 +00:00
return msaa_3d;
WIP particle system Ability to enable and change MSAA settings Ability to change VCT quality Ability to enable/disable HDR rendering
2017-01-02 01:16:52 +00:00
}
Add screen space AA option, with FXAA implementation.
2020-04-12 04:49:10 +00:00
void Viewport::set_screen_space_aa(ScreenSpaceAA p_screen_space_aa) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Add screen space AA option, with FXAA implementation.
2020-04-12 04:49:10 +00:00
ERR_FAIL_INDEX(p_screen_space_aa, SCREEN_SPACE_AA_MAX);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (screen_space_aa == p_screen_space_aa) {
Add screen space AA option, with FXAA implementation.
2020-04-12 04:49:10 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Add screen space AA option, with FXAA implementation.
2020-04-12 04:49:10 +00:00
screen_space_aa = p_screen_space_aa;
RS::get_singleton()->viewport_set_screen_space_aa(viewport, RS::ViewportScreenSpaceAA(p_screen_space_aa));
}
Viewport::ScreenSpaceAA Viewport::get_screen_space_aa() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(SCREEN_SPACE_AA_DISABLED);
Add screen space AA option, with FXAA implementation.
2020-04-12 04:49:10 +00:00
return screen_space_aa;
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Initial TAA implementation Initial TAA support based on the implementation in Spartan Engine. Motion vectors are correctly generated for camera and mesh movement, but there is no support for other things like particles or skeleton deformations.
2022-04-04 14:10:22 +00:00
void Viewport::set_use_taa(bool p_use_taa) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Initial TAA implementation Initial TAA support based on the implementation in Spartan Engine. Motion vectors are correctly generated for camera and mesh movement, but there is no support for other things like particles or skeleton deformations.
2022-04-04 14:10:22 +00:00
if (use_taa == p_use_taa) {
return;
}
use_taa = p_use_taa;
RS::get_singleton()->viewport_set_use_taa(viewport, p_use_taa);
}
bool Viewport::is_using_taa() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Initial TAA implementation Initial TAA support based on the implementation in Spartan Engine. Motion vectors are correctly generated for camera and mesh movement, but there is no support for other things like particles or skeleton deformations.
2022-04-04 14:10:22 +00:00
return use_taa;
}
Add a debanding property to Viewport It can be enabled in the Project Settings (`rendering/quality/screen_filters/use_debanding`). It's disabled by default as it has a small performance impact and can make PNG screenshots much larger (due to how dithering works). It will also slightly brighten the scene's dark areas. As a result, it should be enabled only when banding is noticeable enough. This closes #17006.
2020-04-20 21:34:47 +00:00
void Viewport::set_use_debanding(bool p_use_debanding) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Style: Apply clang-tidy's `readability-braces-around-statements`
2021-04-05 12:09:59 +00:00
if (use_debanding == p_use_debanding) {
Add a debanding property to Viewport It can be enabled in the Project Settings (`rendering/quality/screen_filters/use_debanding`). It's disabled by default as it has a small performance impact and can make PNG screenshots much larger (due to how dithering works). It will also slightly brighten the scene's dark areas. As a result, it should be enabled only when banding is noticeable enough. This closes #17006.
2020-04-20 21:34:47 +00:00
return;
Style: Apply clang-tidy's `readability-braces-around-statements`
2021-04-05 12:09:59 +00:00
}
Add a debanding property to Viewport It can be enabled in the Project Settings (`rendering/quality/screen_filters/use_debanding`). It's disabled by default as it has a small performance impact and can make PNG screenshots much larger (due to how dithering works). It will also slightly brighten the scene's dark areas. As a result, it should be enabled only when banding is noticeable enough. This closes #17006.
2020-04-20 21:34:47 +00:00
use_debanding = p_use_debanding;
RS::get_singleton()->viewport_set_use_debanding(viewport, p_use_debanding);
}
bool Viewport::is_using_debanding() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Add a debanding property to Viewport It can be enabled in the Project Settings (`rendering/quality/screen_filters/use_debanding`). It's disabled by default as it has a small performance impact and can make PNG screenshots much larger (due to how dithering works). It will also slightly brighten the scene's dark areas. As a result, it should be enabled only when banding is noticeable enough. This closes #17006.
2020-04-20 21:34:47 +00:00
return use_debanding;
}
Rename Lod Threshold to Mesh Lod Threshold This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
2021-12-28 23:10:41 +00:00
void Viewport::set_mesh_lod_threshold(float p_pixels) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Rename Lod Threshold to Mesh Lod Threshold This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
2021-12-28 23:10:41 +00:00
mesh_lod_threshold = p_pixels;
RS::get_singleton()->viewport_set_mesh_lod_threshold(viewport, mesh_lod_threshold);
Implement automatic LOD (Level of Detail) -Happens on import by default for all models -Just works (tm) -Biasing can be later adjusted per node or per viewport (as well as globally) -Disabled AABB.get_support test because its broken
2020-12-17 18:56:59 +00:00
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
Rename Lod Threshold to Mesh Lod Threshold This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
2021-12-28 23:10:41 +00:00
float Viewport::get_mesh_lod_threshold() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(0);
Rename Lod Threshold to Mesh Lod Threshold This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
2021-12-28 23:10:41 +00:00
return mesh_lod_threshold;
Implement automatic LOD (Level of Detail) -Happens on import by default for all models -Just works (tm) -Biasing can be later adjusted per node or per viewport (as well as globally) -Disabled AABB.get_support test because its broken
2020-12-17 18:56:59 +00:00
}
Implement occlusion culling Added an occlusion culling system with support for static occluder meshes. It can be enabled via `Project Settings > Rendering > Occlusion Culling > Use Occlusion Culling`. Occluders are defined via the new `Occluder3D` resource and instanced using the new `OccluderInstance3D` node. The occluders can also be automatically baked from a scene using the built-in editor plugin.
2021-04-20 16:40:24 +00:00
void Viewport::set_use_occlusion_culling(bool p_use_occlusion_culling) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Implement occlusion culling Added an occlusion culling system with support for static occluder meshes. It can be enabled via `Project Settings > Rendering > Occlusion Culling > Use Occlusion Culling`. Occluders are defined via the new `Occluder3D` resource and instanced using the new `OccluderInstance3D` node. The occluders can also be automatically baked from a scene using the built-in editor plugin.
2021-04-20 16:40:24 +00:00
if (use_occlusion_culling == p_use_occlusion_culling) {
return;
}
use_occlusion_culling = p_use_occlusion_culling;
RS::get_singleton()->viewport_set_use_occlusion_culling(viewport, p_use_occlusion_culling);
notify_property_list_changed();
}
bool Viewport::is_using_occlusion_culling() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Implement occlusion culling Added an occlusion culling system with support for static occluder meshes. It can be enabled via `Project Settings > Rendering > Occlusion Culling > Use Occlusion Culling`. Occluders are defined via the new `Occluder3D` resource and instanced using the new `OccluderInstance3D` node. The occluders can also be automatically baked from a scene using the built-in editor plugin.
2021-04-20 16:40:24 +00:00
return use_occlusion_culling;
}
Restored multiple viewport function, as well as view modes.
2017-06-11 18:52:03 +00:00
void Viewport::set_debug_draw(DebugDraw p_debug_draw) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Restored multiple viewport function, as well as view modes.
2017-06-11 18:52:03 +00:00
debug_draw = p_debug_draw;
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->viewport_set_debug_draw(viewport, RS::ViewportDebugDraw(p_debug_draw));
Restored multiple viewport function, as well as view modes.
2017-06-11 18:52:03 +00:00
}
Viewport::DebugDraw Viewport::get_debug_draw() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(DEBUG_DRAW_DISABLED);
Restored multiple viewport function, as well as view modes.
2017-06-11 18:52:03 +00:00
return debug_draw;
}
Fix Render Info * Fixed and redone the process to obtain render information from a viewport * Some stats, such as material changes are too difficult to guess on Vulkan, were removed. * Separated visible and shadow stats, which causes confusion. * Texture, buffer and general video memory can be queried now. * Fixed the performance metrics too.
2021-07-02 23:14:19 +00:00
int Viewport::get_render_info(RenderInfoType p_type, RenderInfo p_info) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(0);
Fix Render Info * Fixed and redone the process to obtain render information from a viewport * Some stats, such as material changes are too difficult to guess on Vulkan, were removed. * Separated visible and shadow stats, which causes confusion. * Texture, buffer and general video memory can be queried now. * Fixed the performance metrics too.
2021-07-02 23:14:19 +00:00
return RS::get_singleton()->viewport_get_render_info(viewport, RS::ViewportRenderInfoType(p_type), RS::ViewportRenderInfo(p_info));
Restored multiple viewport function, as well as view modes.
2017-06-11 18:52:03 +00:00
}
Restored auto snapping of controls to pixels, fixes #10847 and probably several more issues. Made it optional in the project settings but defaults to true.
2017-09-07 14:22:07 +00:00
void Viewport::set_snap_controls_to_pixels(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Fix serveral recent new clang-format errors
2017-09-07 06:57:09 +00:00
snap_controls_to_pixels = p_enable;
Restored auto snapping of controls to pixels, fixes #10847 and probably several more issues. Made it optional in the project settings but defaults to true.
2017-09-07 14:22:07 +00:00
}
bool Viewport::is_snap_controls_to_pixels_enabled() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Restored auto snapping of controls to pixels, fixes #10847 and probably several more issues. Made it optional in the project settings but defaults to true.
2017-09-07 14:22:07 +00:00
return snap_controls_to_pixels;
}
Refactor pixel snapping. -Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes #41814 Solves proposal https://github.com/godotengine/godot-proposals/issues/1666 Supersedes #35606, supersedes #41535, supersedes #41534
2020-10-29 21:09:16 +00:00
void Viewport::set_snap_2d_transforms_to_pixel(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Refactor pixel snapping. -Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes #41814 Solves proposal https://github.com/godotengine/godot-proposals/issues/1666 Supersedes #35606, supersedes #41535, supersedes #41534
2020-10-29 21:09:16 +00:00
snap_2d_transforms_to_pixel = p_enable;
RS::get_singleton()->viewport_set_snap_2d_transforms_to_pixel(viewport, snap_2d_transforms_to_pixel);
}
bool Viewport::is_snap_2d_transforms_to_pixel_enabled() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Refactor pixel snapping. -Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes #41814 Solves proposal https://github.com/godotengine/godot-proposals/issues/1666 Supersedes #35606, supersedes #41535, supersedes #41534
2020-10-29 21:09:16 +00:00
return snap_2d_transforms_to_pixel;
}
void Viewport::set_snap_2d_vertices_to_pixel(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Refactor pixel snapping. -Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes #41814 Solves proposal https://github.com/godotengine/godot-proposals/issues/1666 Supersedes #35606, supersedes #41535, supersedes #41534
2020-10-29 21:09:16 +00:00
snap_2d_vertices_to_pixel = p_enable;
RS::get_singleton()->viewport_set_snap_2d_vertices_to_pixel(viewport, snap_2d_vertices_to_pixel);
}
bool Viewport::is_snap_2d_vertices_to_pixel_enabled() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Refactor pixel snapping. -Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes #41814 Solves proposal https://github.com/godotengine/godot-proposals/issues/1666 Supersedes #35606, supersedes #41535, supersedes #41534
2020-10-29 21:09:16 +00:00
return snap_2d_vertices_to_pixel;
}
Avoid misuse of set_drag_preview() function where it shouldn't be. Closes #20100
2018-08-24 13:29:27 +00:00
bool Viewport::gui_is_dragging() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Avoid misuse of set_drag_preview() function where it shouldn't be. Closes #20100
2018-08-24 13:29:27 +00:00
return gui.dragging;
}
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
Fix drag and drop on LineEdit
2021-10-28 07:07:18 +00:00
bool Viewport::gui_is_drag_successful() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Fix drag and drop on LineEdit
2021-10-28 07:07:18 +00:00
return gui.drag_successful;
}
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
void Viewport::set_input_as_handled() {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Fix Viewport::handle_input_locally related infinite recursion
2021-10-10 10:10:28 +00:00
if (!handle_input_locally) {
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
ERR_FAIL_COND(!is_inside_tree());
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
Viewport *vp = this;
while (true) {
if (Object::cast_to<Window>(vp)) {
break;
}
if (!vp->get_parent()) {
break;
}
vp = vp->get_parent()->get_viewport();
}
Fix Viewport::handle_input_locally related infinite recursion
2021-10-10 10:10:28 +00:00
if (vp != this) {
vp->set_input_as_handled();
return;
}
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
}
Fix Viewport::handle_input_locally related infinite recursion
2021-10-10 10:10:28 +00:00
local_input_handled = true;
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
}
bool Viewport::is_input_handled() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Fix Viewport::handle_input_locally related infinite recursion
2021-10-10 10:10:28 +00:00
if (!handle_input_locally) {
Fix Viewport crashes when not in tree
2021-06-13 03:36:32 +00:00
ERR_FAIL_COND_V(!is_inside_tree(), false);
Fix Viewport::handle_input_locally related infinite recursion
2021-10-10 10:10:28 +00:00
const Viewport *vp = this;
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
while (true) {
if (Object::cast_to<Window>(vp)) {
break;
}
if (!vp->get_parent()) {
break;
}
vp = vp->get_parent()->get_viewport();
}
Fix Viewport::handle_input_locally related infinite recursion
2021-10-10 10:10:28 +00:00
if (vp != this) {
return vp->is_input_handled();
}
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
}
Fix Viewport::handle_input_locally related infinite recursion
2021-10-10 10:10:28 +00:00
return local_input_handled;
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
}
void Viewport::set_handle_input_locally(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
handle_input_locally = p_enable;
}
bool Viewport::is_handling_input_locally() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
return handle_input_locally;
}
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
void Viewport::set_default_canvas_item_texture_filter(DefaultCanvasItemTextureFilter p_filter) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Refactored 2D shader and lighting system -Removed normal/specular properties from nodes -Create CanvasTexture, which can contain normal/specular channels -Refactored, optimized and simplified 2D shaders -Use atlas for light textures. -Use a shadow atlas for shadow textures. -Use both items aboves to make light rendering stateless (faster). -Reorganized uniform sets for more efficiency.
2020-10-24 15:15:43 +00:00
ERR_FAIL_INDEX(p_filter, DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_MAX);
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
if (default_canvas_item_texture_filter == p_filter) {
return;
}
default_canvas_item_texture_filter = p_filter;
Refactored 2D shader and lighting system -Removed normal/specular properties from nodes -Create CanvasTexture, which can contain normal/specular channels -Refactored, optimized and simplified 2D shaders -Use atlas for light textures. -Use a shadow atlas for shadow textures. -Use both items aboves to make light rendering stateless (faster). -Reorganized uniform sets for more efficiency.
2020-10-24 15:15:43 +00:00
switch (default_canvas_item_texture_filter) {
case DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_NEAREST:
RS::get_singleton()->viewport_set_default_canvas_item_texture_filter(viewport, RS::CANVAS_ITEM_TEXTURE_FILTER_NEAREST);
break;
case DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_LINEAR:
RS::get_singleton()->viewport_set_default_canvas_item_texture_filter(viewport, RS::CANVAS_ITEM_TEXTURE_FILTER_LINEAR);
break;
case DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_LINEAR_WITH_MIPMAPS:
RS::get_singleton()->viewport_set_default_canvas_item_texture_filter(viewport, RS::CANVAS_ITEM_TEXTURE_FILTER_LINEAR_WITH_MIPMAPS);
break;
case DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_NEAREST_WITH_MIPMAPS:
RS::get_singleton()->viewport_set_default_canvas_item_texture_filter(viewport, RS::CANVAS_ITEM_TEXTURE_FILTER_NEAREST_WITH_MIPMAPS);
break;
default: {
}
}
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
}
Viewport::DefaultCanvasItemTextureFilter Viewport::get_default_canvas_item_texture_filter() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_NEAREST);
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
return default_canvas_item_texture_filter;
}
void Viewport::set_default_canvas_item_texture_repeat(DefaultCanvasItemTextureRepeat p_repeat) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Refactored 2D shader and lighting system -Removed normal/specular properties from nodes -Create CanvasTexture, which can contain normal/specular channels -Refactored, optimized and simplified 2D shaders -Use atlas for light textures. -Use a shadow atlas for shadow textures. -Use both items aboves to make light rendering stateless (faster). -Reorganized uniform sets for more efficiency.
2020-10-24 15:15:43 +00:00
ERR_FAIL_INDEX(p_repeat, DEFAULT_CANVAS_ITEM_TEXTURE_REPEAT_MAX);
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
if (default_canvas_item_texture_repeat == p_repeat) {
return;
}
Refactored 2D shader and lighting system -Removed normal/specular properties from nodes -Create CanvasTexture, which can contain normal/specular channels -Refactored, optimized and simplified 2D shaders -Use atlas for light textures. -Use a shadow atlas for shadow textures. -Use both items aboves to make light rendering stateless (faster). -Reorganized uniform sets for more efficiency.
2020-10-24 15:15:43 +00:00
default_canvas_item_texture_repeat = p_repeat;
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
Refactored 2D shader and lighting system -Removed normal/specular properties from nodes -Create CanvasTexture, which can contain normal/specular channels -Refactored, optimized and simplified 2D shaders -Use atlas for light textures. -Use a shadow atlas for shadow textures. -Use both items aboves to make light rendering stateless (faster). -Reorganized uniform sets for more efficiency.
2020-10-24 15:15:43 +00:00
switch (default_canvas_item_texture_repeat) {
case DEFAULT_CANVAS_ITEM_TEXTURE_REPEAT_DISABLED:
RS::get_singleton()->viewport_set_default_canvas_item_texture_repeat(viewport, RS::CANVAS_ITEM_TEXTURE_REPEAT_DISABLED);
break;
case DEFAULT_CANVAS_ITEM_TEXTURE_REPEAT_ENABLED:
RS::get_singleton()->viewport_set_default_canvas_item_texture_repeat(viewport, RS::CANVAS_ITEM_TEXTURE_REPEAT_ENABLED);
break;
case DEFAULT_CANVAS_ITEM_TEXTURE_REPEAT_MIRROR:
RS::get_singleton()->viewport_set_default_canvas_item_texture_repeat(viewport, RS::CANVAS_ITEM_TEXTURE_REPEAT_MIRROR);
break;
default: {
}
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
}
}
Refactored 2D shader and lighting system -Removed normal/specular properties from nodes -Create CanvasTexture, which can contain normal/specular channels -Refactored, optimized and simplified 2D shaders -Use atlas for light textures. -Use a shadow atlas for shadow textures. -Use both items aboves to make light rendering stateless (faster). -Reorganized uniform sets for more efficiency.
2020-10-24 15:15:43 +00:00
Viewport::DefaultCanvasItemTextureRepeat Viewport::get_default_canvas_item_texture_repeat() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(DEFAULT_CANVAS_ITEM_TEXTURE_REPEAT_DISABLED);
Refactored 2D shader and lighting system -Removed normal/specular properties from nodes -Create CanvasTexture, which can contain normal/specular channels -Refactored, optimized and simplified 2D shaders -Use atlas for light textures. -Use a shadow atlas for shadow textures. -Use both items aboves to make light rendering stateless (faster). -Reorganized uniform sets for more efficiency.
2020-10-24 15:15:43 +00:00
return default_canvas_item_texture_repeat;
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
}
Adding Variable Rate Shading support to Godot Improve GI renderer and add VRS support Implement render device has_feature and move subgroup settings to limit_get
2022-02-11 11:33:54 +00:00
void Viewport::set_vrs_mode(Viewport::VRSMode p_vrs_mode) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Adding Variable Rate Shading support to Godot Improve GI renderer and add VRS support Implement render device has_feature and move subgroup settings to limit_get
2022-02-11 11:33:54 +00:00
// Note, set this even if not supported on this hardware, it will only be used if it is but we want to save the value as set by the user.
vrs_mode = p_vrs_mode;
switch (p_vrs_mode) {
case VRS_TEXTURE: {
RS::get_singleton()->viewport_set_vrs_mode(viewport, RS::VIEWPORT_VRS_TEXTURE);
} break;
case VRS_XR: {
RS::get_singleton()->viewport_set_vrs_mode(viewport, RS::VIEWPORT_VRS_XR);
} break;
default: {
RS::get_singleton()->viewport_set_vrs_mode(viewport, RS::VIEWPORT_VRS_DISABLED);
} break;
}
notify_property_list_changed();
}
Viewport::VRSMode Viewport::get_vrs_mode() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(VRS_DISABLED);
Adding Variable Rate Shading support to Godot Improve GI renderer and add VRS support Implement render device has_feature and move subgroup settings to limit_get
2022-02-11 11:33:54 +00:00
return vrs_mode;
}
void Viewport::set_vrs_texture(Ref<Texture2D> p_texture) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Adding Variable Rate Shading support to Godot Improve GI renderer and add VRS support Implement render device has_feature and move subgroup settings to limit_get
2022-02-11 11:33:54 +00:00
vrs_texture = p_texture;
// TODO need to add something here in case the RID changes
RID tex = p_texture.is_valid() ? p_texture->get_rid() : RID();
RS::get_singleton()->viewport_set_vrs_texture(viewport, tex);
}
Ref<Texture2D> Viewport::get_vrs_texture() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Ref<Texture2D>());
Adding Variable Rate Shading support to Godot Improve GI renderer and add VRS support Implement render device has_feature and move subgroup settings to limit_get
2022-02-11 11:33:54 +00:00
return vrs_texture;
}
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
DisplayServer::WindowID Viewport::get_window_id() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(DisplayServer::INVALID_WINDOW_ID);
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
return DisplayServer::MAIN_WINDOW_ID;
}
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
Viewport *Viewport::get_parent_viewport() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(nullptr);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
ERR_FAIL_COND_V(!is_inside_tree(), nullptr);
if (!get_parent()) {
return nullptr; //root viewport
}
return get_parent()->get_viewport();
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Cleanup embed subwindows getters
2022-03-13 15:18:44 +00:00
void Viewport::set_embedding_subwindows(bool p_embed) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_THREAD_GUARD;
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
gui.embed_subwindows_hint = p_embed;
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
bool Viewport::is_embedding_subwindows() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
return gui.embed_subwindows_hint;
}
Embedded Popups store their safe_rect in their embedder Storing it in the DisplayServer didn't make sense in this case, because the embedded window is unknown to the DisplayServer.
2023-06-20 13:50:44 +00:00
void Viewport::subwindow_set_popup_safe_rect(Window *p_window, const Rect2i &p_rect) {
int index = _sub_window_find(p_window);
ERR_FAIL_COND(index == -1);
Actually store safe-rect in embedder `sw` is a copy and not a reference. Add unit-test for this case.
2023-08-01 12:44:45 +00:00
gui.sub_windows.write[index].parent_safe_rect = p_rect;
Embedded Popups store their safe_rect in their embedder Storing it in the DisplayServer didn't make sense in this case, because the embedded window is unknown to the DisplayServer.
2023-06-20 13:50:44 +00:00
}
Rect2i Viewport::subwindow_get_popup_safe_rect(Window *p_window) const {
int index = _sub_window_find(p_window);
Disable error condition for accessing safe rect This PR removes the error-message, which is currently expected to happen. The task of correctly fixing the underlying problem of window popup closing is more complex, so this PR solves the immediate error-notification-problem.
2023-07-26 18:15:18 +00:00
// FIXME: Re-enable ERR_FAIL_COND after rewriting embedded window popup closing.
// Currently it is expected, that index == -1 can happen.
if (index == -1) {
return Rect2i();
}
// ERR_FAIL_COND_V(index == -1, Rect2i());
Embedded Popups store their safe_rect in their embedder Storing it in the DisplayServer didn't make sense in this case, because the embedded window is unknown to the DisplayServer.
2023-06-20 13:50:44 +00:00
return gui.sub_windows[index].parent_safe_rect;
}
Popups have also been converted to windows Controls using the old modal API have been replaced to use popups.
2020-03-20 02:32:09 +00:00
void Viewport::pass_mouse_focus_to(Viewport *p_viewport, Control *p_control) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Popups have also been converted to windows Controls using the old modal API have been replaced to use popups.
2020-03-20 02:32:09 +00:00
ERR_FAIL_NULL(p_viewport);
ERR_FAIL_NULL(p_control);
if (gui.mouse_focus) {
p_viewport->gui.mouse_focus = p_control;
p_viewport->gui.mouse_focus_mask = gui.mouse_focus_mask;
p_viewport->gui.key_focus = p_control;
p_viewport->gui.forced_mouse_focus = true;
gui.mouse_focus = nullptr;
gui.forced_mouse_focus = false;
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-07 23:55:54 +00:00
gui.mouse_focus_mask.clear();
Popups have also been converted to windows Controls using the old modal API have been replaced to use popups.
2020-03-20 02:32:09 +00:00
}
}
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
void Viewport::set_sdf_oversize(SDFOversize p_sdf_oversize) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
ERR_FAIL_INDEX(p_sdf_oversize, SDF_OVERSIZE_MAX);
sdf_oversize = p_sdf_oversize;
RS::get_singleton()->viewport_set_sdf_oversize_and_scale(viewport, RS::ViewportSDFOversize(sdf_oversize), RS::ViewportSDFScale(sdf_scale));
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
Viewport::SDFOversize Viewport::get_sdf_oversize() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(SDF_OVERSIZE_100_PERCENT);
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
return sdf_oversize;
}
void Viewport::set_sdf_scale(SDFScale p_sdf_scale) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
ERR_FAIL_INDEX(p_sdf_scale, SDF_SCALE_MAX);
sdf_scale = p_sdf_scale;
RS::get_singleton()->viewport_set_sdf_oversize_and_scale(viewport, RS::ViewportSDFOversize(sdf_oversize), RS::ViewportSDFScale(sdf_scale));
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
Viewport::SDFScale Viewport::get_sdf_scale() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(SDF_SCALE_100_PERCENT);
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
return sdf_scale;
}
Fix using Viewport::warp_mouse within Viewports
2022-03-28 09:01:29 +00:00
Transform2D Viewport::get_screen_transform() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Transform2D());
Fix Viewport::get_mouse_position for SubViewports SubViewports don't have a cached mouse position available. This PR calculates the mouse position from the screen position of the mouse cursor.
2023-01-20 21:33:05 +00:00
return get_screen_transform_internal();
}
Transform2D Viewport::get_screen_transform_internal(bool p_absolute_position) const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Transform2D());
Include the Window-transform into Viewport::get_final_transform
2022-10-01 06:40:11 +00:00
return get_final_transform();
Fix using Viewport::warp_mouse within Viewports
2022-03-28 09:01:29 +00:00
}
Create a virtual mouse move event after moving child nodes This updates mouse cursor and mouse-over-states without the need for additional mouse movements.
2022-09-29 21:45:51 +00:00
void Viewport::update_mouse_cursor_state() {
// Updates need to happen in Window, because SubViewportContainers might be hidden behind other Controls.
Window *base_window = get_base_window();
if (base_window) {
base_window->update_mouse_cursor_state();
}
}
Viewport canvas cull mask feature Co-authored-by: Valentin Zagura <puthre@gmail.com>
2021-09-02 18:07:04 +00:00
void Viewport::set_canvas_cull_mask(uint32_t p_canvas_cull_mask) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Viewport canvas cull mask feature Co-authored-by: Valentin Zagura <puthre@gmail.com>
2021-09-02 18:07:04 +00:00
canvas_cull_mask = p_canvas_cull_mask;
RenderingServer::get_singleton()->viewport_set_canvas_cull_mask(viewport, canvas_cull_mask);
}
uint32_t Viewport::get_canvas_cull_mask() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(0);
Viewport canvas cull mask feature Co-authored-by: Valentin Zagura <puthre@gmail.com>
2021-09-02 18:07:04 +00:00
return canvas_cull_mask;
}
void Viewport::set_canvas_cull_mask_bit(uint32_t p_layer, bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Fixup Clang -Wtype-limits warnings introduced by #52350
2022-11-02 21:36:01 +00:00
ERR_FAIL_UNSIGNED_INDEX(p_layer, 32);
Viewport canvas cull mask feature Co-authored-by: Valentin Zagura <puthre@gmail.com>
2021-09-02 18:07:04 +00:00
if (p_enable) {
set_canvas_cull_mask(canvas_cull_mask | (1 << p_layer));
} else {
set_canvas_cull_mask(canvas_cull_mask & (~(1 << p_layer)));
}
}
bool Viewport::get_canvas_cull_mask_bit(uint32_t p_layer) const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Fixup Clang -Wtype-limits warnings introduced by #52350
2022-11-02 21:36:01 +00:00
ERR_FAIL_UNSIGNED_INDEX_V(p_layer, 32, false);
Viewport canvas cull mask feature Co-authored-by: Valentin Zagura <puthre@gmail.com>
2021-09-02 18:07:04 +00:00
return (canvas_cull_mask & (1 << p_layer));
}
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#ifndef _3D_DISABLED
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
AudioListener3D *Viewport::get_audio_listener_3d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(nullptr);
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
return audio_listener_3d;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
void Viewport::set_as_audio_listener_3d(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
if (p_enable == is_audio_listener_3d_enabled) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
is_audio_listener_3d_enabled = p_enable;
_update_audio_listener_3d();
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
bool Viewport::is_audio_listener_3d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
return is_audio_listener_3d_enabled;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
Little Bits -=-=-=-=-=- -Fixed small bugs all around -Added ability to show/hide entire sections of the spatial (3D) tree -WIP new vehicle (not ready yet) based on Bullet
2014-08-14 13:31:38 +00:00
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
void Viewport::_update_audio_listener_3d() {
Prevent crash on startup if no audio server
2021-09-01 15:44:47 +00:00
if (AudioServer::get_singleton()) {
AudioServer::get_singleton()->notify_listener_changed();
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
Add screen space AA option, with FXAA implementation.
2020-04-12 04:49:10 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
void Viewport::_listener_transform_3d_changed_notify() {
}
Add a debanding property to Viewport It can be enabled in the Project Settings (`rendering/quality/screen_filters/use_debanding`). It's disabled by default as it has a small performance impact and can make PNG screenshots much larger (due to how dithering works). It will also slightly brighten the scene's dark areas. As a result, it should be enabled only when banding is noticeable enough. This closes #17006.
2020-04-20 21:34:47 +00:00
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
void Viewport::_audio_listener_3d_set(AudioListener3D *p_listener) {
if (audio_listener_3d == p_listener) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return;
}
Implement occlusion culling Added an occlusion culling system with support for static occluder meshes. It can be enabled via `Project Settings > Rendering > Occlusion Culling > Use Occlusion Culling`. Occluders are defined via the new `Occluder3D` resource and instanced using the new `OccluderInstance3D` node. The occluders can also be automatically baked from a scene using the built-in editor plugin.
2021-04-20 16:40:24 +00:00
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
audio_listener_3d = p_listener;
Restored multiple viewport function, as well as view modes.
2017-06-11 18:52:03 +00:00
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
_update_audio_listener_3d();
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
_listener_transform_3d_changed_notify();
}
Restored multiple viewport function, as well as view modes.
2017-06-11 18:52:03 +00:00
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
bool Viewport::_audio_listener_3d_add(AudioListener3D *p_listener) {
audio_listener_3d_set.insert(p_listener);
return audio_listener_3d_set.size() == 1;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
Move XR flag from subviewport into viewport
2021-04-29 01:23:24 +00:00
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
void Viewport::_audio_listener_3d_remove(AudioListener3D *p_listener) {
audio_listener_3d_set.erase(p_listener);
if (audio_listener_3d == p_listener) {
audio_listener_3d = nullptr;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
}
-Added ATITC texture support -Fixed bug of some tabs showing wrong names -Exported properties for viewport
2014-02-26 13:08:17 +00:00
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
void Viewport::_audio_listener_3d_make_next_current(AudioListener3D *p_exclude) {
if (audio_listener_3d_set.size() > 0) {
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
for (AudioListener3D *E : audio_listener_3d_set) {
if (p_exclude == E) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
continue;
}
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
if (!E->is_inside_tree()) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
continue;
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
if (audio_listener_3d != nullptr) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return;
}
3D Physics Rework, Other Stuff -=-=-=-=-=-=-=-=-=-=-=-=-=- 3D Physics: -Fixed "Bounce" parameter in 3D -Fixed bug affecting Area (sometims it would not detect properly) -Vehicle Body has seen heavy work -Added Query API for doing space queries in 3D. Needs some docs though. -Added JOINTS! Adapted Bullet Joints: and created easy gizmos for setting them up: -PinJoint -HingeJoint (with motor) -SliderJoint -ConeTwistJoint -Generic6DOFJoint -Added OBJECT PICKING! based on the new query API. Any physics object now (Area or Body) has the following signals and virtual functions: -input_event (mouse or multitouch input over the body) -mouse_enter (mouse entered the body area) -mouse_exit (mouse exited body area) For Area it needs to be activated manually, as it isn't by default (ray goes thru). Other: -Begun working on Windows 8 (RT) port. Compiles but does not work yet. -Added TheoraPlayer library for improved to-texture and portable video support. -Fixed a few bugs in the renderer, collada importer, collada exporter, etc.
2014-09-15 14:33:30 +00:00
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
E->make_current();
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
} else {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Attempt to reset listener to the camera position.
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (camera_3d != nullptr) {
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
_update_audio_listener_3d();
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
_camera_3d_transform_changed_notify();
}
}
}
-Added ATITC texture support -Fixed bug of some tabs showing wrong names -Exported properties for viewport
2014-02-26 13:08:17 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
void Viewport::_collision_object_3d_input_event(CollisionObject3D *p_object, Camera3D *p_camera, const Ref<InputEvent> &p_input_event, const Vector3 &p_pos, const Vector3 &p_normal, int p_shape) {
Transform3D object_transform = p_object->get_global_transform();
Transform3D camera_transform = p_camera->get_global_transform();
ObjectID id = p_object->get_instance_id();
-Added google play services (needed for some stuff) -Added new screen resizing options, stretch_2d is removed, new much more flexible ones. -Fixed bug in viewport (can create more instances in 3d-in-2d demo now) -Can set android permissions and screen sizes manually in the export settings -Changed export templates extension to .tpz (too many people unzipped the manually..) -File dialog now ensures that the proper extension is used (will not allow to save without it) -Fixed bug that made collision exceptions not work in 2D
2014-04-15 01:43:44 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Avoid sending the fake event unnecessarily if nothing really changed in the context.
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (object_transform == physics_last_object_transform && camera_transform == physics_last_camera_transform && physics_last_id == id) {
Ref<InputEventMouseMotion> mm = p_input_event;
if (mm.is_valid() && mm->get_device() == InputEvent::DEVICE_ID_INTERNAL) {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
return; // Discarded.
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
}
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
p_object->_input_event_call(camera_3d, p_input_event, p_pos, p_normal, p_shape);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
physics_last_object_transform = object_transform;
physics_last_camera_transform = camera_transform;
physics_last_id = id;
}
-Added ATITC texture support -Fixed bug of some tabs showing wrong names -Exported properties for viewport
2014-02-26 13:08:17 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
Camera3D *Viewport::get_camera_3d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(nullptr);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return camera_3d;
}
-Added ATITC texture support -Fixed bug of some tabs showing wrong names -Exported properties for viewport
2014-02-26 13:08:17 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
void Viewport::_camera_3d_transform_changed_notify() {
}
-Added ATITC texture support -Fixed bug of some tabs showing wrong names -Exported properties for viewport
2014-02-26 13:08:17 +00:00
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
void Viewport::_camera_3d_set(Camera3D *p_camera) {
if (camera_3d == p_camera) {
return;
}
if (camera_3d) {
camera_3d->notification(Camera3D::NOTIFICATION_LOST_CURRENT);
}
camera_3d = p_camera;
if (!camera_3d_override) {
if (camera_3d) {
RenderingServer::get_singleton()->viewport_attach_camera(viewport, camera_3d->get_camera());
} else {
RenderingServer::get_singleton()->viewport_attach_camera(viewport, RID());
}
}
if (camera_3d) {
camera_3d->notification(Camera3D::NOTIFICATION_BECAME_CURRENT);
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
_update_audio_listener_3d();
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
_camera_3d_transform_changed_notify();
}
bool Viewport::_camera_3d_add(Camera3D *p_camera) {
camera_3d_set.insert(p_camera);
return camera_3d_set.size() == 1;
}
void Viewport::_camera_3d_remove(Camera3D *p_camera) {
camera_3d_set.erase(p_camera);
if (camera_3d == p_camera) {
camera_3d->notification(Camera3D::NOTIFICATION_LOST_CURRENT);
camera_3d = nullptr;
}
}
void Viewport::_camera_3d_make_next_current(Camera3D *p_exclude) {
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
for (Camera3D *E : camera_3d_set) {
if (p_exclude == E) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
continue;
}
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
if (!E->is_inside_tree()) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
continue;
}
if (camera_3d != nullptr) {
return;
}
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
E->make_current();
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
}
void Viewport::enable_camera_3d_override(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (p_enable == camera_3d_override) {
return;
}
if (p_enable) {
camera_3d_override.rid = RenderingServer::get_singleton()->camera_create();
} else {
RenderingServer::get_singleton()->free(camera_3d_override.rid);
camera_3d_override.rid = RID();
}
if (p_enable) {
RenderingServer::get_singleton()->viewport_attach_camera(viewport, camera_3d_override.rid);
} else if (camera_3d) {
RenderingServer::get_singleton()->viewport_attach_camera(viewport, camera_3d->get_camera());
} else {
RenderingServer::get_singleton()->viewport_attach_camera(viewport, RID());
}
}
void Viewport::set_camera_3d_override_perspective(real_t p_fovy_degrees, real_t p_z_near, real_t p_z_far) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (camera_3d_override) {
if (camera_3d_override.fov == p_fovy_degrees && camera_3d_override.z_near == p_z_near &&
camera_3d_override.z_far == p_z_far && camera_3d_override.projection == Camera3DOverrideData::PROJECTION_PERSPECTIVE) {
return;
}
camera_3d_override.fov = p_fovy_degrees;
camera_3d_override.z_near = p_z_near;
camera_3d_override.z_far = p_z_far;
camera_3d_override.projection = Camera3DOverrideData::PROJECTION_PERSPECTIVE;
RenderingServer::get_singleton()->camera_set_perspective(camera_3d_override.rid, camera_3d_override.fov, camera_3d_override.z_near, camera_3d_override.z_far);
}
}
void Viewport::set_camera_3d_override_orthogonal(real_t p_size, real_t p_z_near, real_t p_z_far) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (camera_3d_override) {
if (camera_3d_override.size == p_size && camera_3d_override.z_near == p_z_near &&
camera_3d_override.z_far == p_z_far && camera_3d_override.projection == Camera3DOverrideData::PROJECTION_ORTHOGONAL) {
return;
}
camera_3d_override.size = p_size;
camera_3d_override.z_near = p_z_near;
camera_3d_override.z_far = p_z_far;
camera_3d_override.projection = Camera3DOverrideData::PROJECTION_ORTHOGONAL;
RenderingServer::get_singleton()->camera_set_orthogonal(camera_3d_override.rid, camera_3d_override.size, camera_3d_override.z_near, camera_3d_override.z_far);
}
}
void Viewport::set_disable_3d(bool p_disable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
disable_3d = p_disable;
RenderingServer::get_singleton()->viewport_set_disable_3d(viewport, disable_3d);
}
bool Viewport::is_3d_disabled() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return disable_3d;
}
bool Viewport::is_camera_3d_override_enabled() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return camera_3d_override;
}
void Viewport::set_camera_3d_override_transform(const Transform3D &p_transform) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (camera_3d_override) {
camera_3d_override.transform = p_transform;
RenderingServer::get_singleton()->camera_set_transform(camera_3d_override.rid, p_transform);
}
}
Transform3D Viewport::get_camera_3d_override_transform() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Transform3D());
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (camera_3d_override) {
return camera_3d_override.transform;
}
return Transform3D();
}
Ref<World3D> Viewport::get_world_3d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Ref<World3D>());
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return world_3d;
}
Ref<World3D> Viewport::find_world_3d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Ref<World3D>());
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (own_world_3d.is_valid()) {
return own_world_3d;
} else if (world_3d.is_valid()) {
return world_3d;
} else if (parent) {
return parent->find_world_3d();
} else {
return Ref<World3D>();
}
}
void Viewport::set_world_3d(const Ref<World3D> &p_world_3d) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (world_3d == p_world_3d) {
return;
}
if (is_inside_tree()) {
_propagate_exit_world_3d(this);
}
if (own_world_3d.is_valid() && world_3d.is_valid()) {
Unify and streamline connecting to Resource changes
2023-07-03 19:29:37 +00:00
world_3d->disconnect_changed(callable_mp(this, &Viewport::_own_world_3d_changed));
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
world_3d = p_world_3d;
if (own_world_3d.is_valid()) {
if (world_3d.is_valid()) {
own_world_3d = world_3d->duplicate();
Unify and streamline connecting to Resource changes
2023-07-03 19:29:37 +00:00
world_3d->connect_changed(callable_mp(this, &Viewport::_own_world_3d_changed));
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
} else {
own_world_3d = Ref<World3D>(memnew(World3D));
}
}
if (is_inside_tree()) {
_propagate_enter_world_3d(this);
}
if (is_inside_tree()) {
RenderingServer::get_singleton()->viewport_set_scenario(viewport, find_world_3d()->get_scenario());
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
_update_audio_listener_3d();
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
void Viewport::_own_world_3d_changed() {
ERR_FAIL_COND(world_3d.is_null());
ERR_FAIL_COND(own_world_3d.is_null());
if (is_inside_tree()) {
_propagate_exit_world_3d(this);
}
own_world_3d = world_3d->duplicate();
if (is_inside_tree()) {
_propagate_enter_world_3d(this);
}
if (is_inside_tree()) {
RenderingServer::get_singleton()->viewport_set_scenario(viewport, find_world_3d()->get_scenario());
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
_update_audio_listener_3d();
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
Fix `Viewport.own_world_3d` documentation Also fixed the naming of the setter's parameter and made an `if` block straightforward.
2022-06-06 13:34:40 +00:00
void Viewport::set_use_own_world_3d(bool p_use_own_world_3d) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Fix `Viewport.own_world_3d` documentation Also fixed the naming of the setter's parameter and made an `if` block straightforward.
2022-06-06 13:34:40 +00:00
if (p_use_own_world_3d == own_world_3d.is_valid()) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return;
}
if (is_inside_tree()) {
_propagate_exit_world_3d(this);
}
Fix `Viewport.own_world_3d` documentation Also fixed the naming of the setter's parameter and made an `if` block straightforward.
2022-06-06 13:34:40 +00:00
if (p_use_own_world_3d) {
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
if (world_3d.is_valid()) {
own_world_3d = world_3d->duplicate();
Unify and streamline connecting to Resource changes
2023-07-03 19:29:37 +00:00
world_3d->connect_changed(callable_mp(this, &Viewport::_own_world_3d_changed));
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
} else {
own_world_3d = Ref<World3D>(memnew(World3D));
}
Fix `Viewport.own_world_3d` documentation Also fixed the naming of the setter's parameter and made an `if` block straightforward.
2022-06-06 13:34:40 +00:00
} else {
own_world_3d = Ref<World3D>();
if (world_3d.is_valid()) {
Unify and streamline connecting to Resource changes
2023-07-03 19:29:37 +00:00
world_3d->disconnect_changed(callable_mp(this, &Viewport::_own_world_3d_changed));
Fix `Viewport.own_world_3d` documentation Also fixed the naming of the setter's parameter and made an `if` block straightforward.
2022-06-06 13:34:40 +00:00
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
if (is_inside_tree()) {
_propagate_enter_world_3d(this);
}
if (is_inside_tree()) {
RenderingServer::get_singleton()->viewport_set_scenario(viewport, find_world_3d()->get_scenario());
}
Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D
2021-09-16 19:28:20 +00:00
_update_audio_listener_3d();
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
bool Viewport::is_using_own_world_3d() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return own_world_3d.is_valid();
}
void Viewport::_propagate_enter_world_3d(Node *p_node) {
if (p_node != this) {
if (!p_node->is_inside_tree()) { //may not have entered scene yet
return;
}
if (Object::cast_to<Node3D>(p_node) || Object::cast_to<WorldEnvironment>(p_node)) {
p_node->notification(Node3D::NOTIFICATION_ENTER_WORLD);
} else {
Viewport *v = Object::cast_to<Viewport>(p_node);
if (v) {
if (v->world_3d.is_valid() || v->own_world_3d.is_valid()) {
return;
}
}
}
}
for (int i = 0; i < p_node->get_child_count(); i++) {
_propagate_enter_world_3d(p_node->get_child(i));
}
}
void Viewport::_propagate_exit_world_3d(Node *p_node) {
if (p_node != this) {
if (!p_node->is_inside_tree()) { //may have exited scene already
return;
}
if (Object::cast_to<Node3D>(p_node) || Object::cast_to<WorldEnvironment>(p_node)) {
p_node->notification(Node3D::NOTIFICATION_EXIT_WORLD);
} else {
Viewport *v = Object::cast_to<Viewport>(p_node);
if (v) {
if (v->world_3d.is_valid() || v->own_world_3d.is_valid()) {
return;
}
}
}
}
for (int i = 0; i < p_node->get_child_count(); i++) {
_propagate_exit_world_3d(p_node->get_child(i));
}
}
void Viewport::set_use_xr(bool p_use_xr) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Fix XR rendering in 'opengl3' driver and expose true size via the Viewport node
2022-08-16 21:54:55 +00:00
if (use_xr != p_use_xr) {
use_xr = p_use_xr;
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
Fix XR rendering in 'opengl3' driver and expose true size via the Viewport node
2022-08-16 21:54:55 +00:00
RS::get_singleton()->viewport_set_use_xr(viewport, use_xr);
if (!use_xr) {
// Set viewport to previous size when exiting XR.
if (size_allocated) {
RS::get_singleton()->viewport_set_size(viewport, size.width, size.height);
} else {
RS::get_singleton()->viewport_set_size(viewport, 0, 0);
}
}
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
}
bool Viewport::is_using_xr() {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
return use_xr;
}
Optionally scale 3D render content
2021-08-19 01:52:06 +00:00
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
void Viewport::set_scaling_3d_mode(Scaling3DMode p_scaling_3d_mode) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
if (scaling_3d_mode == p_scaling_3d_mode) {
return;
}
scaling_3d_mode = p_scaling_3d_mode;
RS::get_singleton()->viewport_set_scaling_3d_mode(viewport, (RS::ViewportScaling3DMode)(int)p_scaling_3d_mode);
}
Viewport::Scaling3DMode Viewport::get_scaling_3d_mode() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(SCALING_3D_MODE_BILINEAR);
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
return scaling_3d_mode;
}
void Viewport::set_scaling_3d_scale(float p_scaling_3d_scale) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Allow any floating-point value as a 3D rendering scale option This allows for finer control over 3D rendering resolution. Supersampling can also be performed by setting a 3D rendering resolution above 1.0, which is useful for offline rendering or for very high-end GPUs.
2021-08-29 12:44:09 +00:00
// Clamp to reasonable values that are actually useful.
// Values above 2.0 don't serve a practical purpose since the viewport
// isn't displayed with mipmaps.
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
scaling_3d_scale = CLAMP(p_scaling_3d_scale, 0.1, 2.0);
RS::get_singleton()->viewport_set_scaling_3d_scale(viewport, scaling_3d_scale);
}
float Viewport::get_scaling_3d_scale() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(0);
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
return scaling_3d_scale;
}
void Viewport::set_fsr_sharpness(float p_fsr_sharpness) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
if (fsr_sharpness == p_fsr_sharpness) {
return;
}
if (p_fsr_sharpness < 0.0f) {
p_fsr_sharpness = 0.0f;
}
Optionally scale 3D render content
2021-08-19 01:52:06 +00:00
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
fsr_sharpness = p_fsr_sharpness;
RS::get_singleton()->viewport_set_fsr_sharpness(viewport, p_fsr_sharpness);
Optionally scale 3D render content
2021-08-19 01:52:06 +00:00
}
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
float Viewport::get_fsr_sharpness() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(0);
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
return fsr_sharpness;
}
Allow changing mipmap LOD bias when FSR 1.0 scaling is not used Mipmap LOD bias can be useful to improve the appearance of distant textures without increasing anisotropic filtering (or in situations where anisotropic filtering is not effective). `fsr_mipmap_bias` was renamed to `texture_mipmap_bias` accordingly. The property hint now allows for greater precision as well.
2022-06-11 23:49:59 +00:00
void Viewport::set_texture_mipmap_bias(float p_texture_mipmap_bias) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Allow changing mipmap LOD bias when FSR 1.0 scaling is not used Mipmap LOD bias can be useful to improve the appearance of distant textures without increasing anisotropic filtering (or in situations where anisotropic filtering is not effective). `fsr_mipmap_bias` was renamed to `texture_mipmap_bias` accordingly. The property hint now allows for greater precision as well.
2022-06-11 23:49:59 +00:00
if (texture_mipmap_bias == p_texture_mipmap_bias) {
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
return;
}
Allow changing mipmap LOD bias when FSR 1.0 scaling is not used Mipmap LOD bias can be useful to improve the appearance of distant textures without increasing anisotropic filtering (or in situations where anisotropic filtering is not effective). `fsr_mipmap_bias` was renamed to `texture_mipmap_bias` accordingly. The property hint now allows for greater precision as well.
2022-06-11 23:49:59 +00:00
texture_mipmap_bias = p_texture_mipmap_bias;
RS::get_singleton()->viewport_set_texture_mipmap_bias(viewport, p_texture_mipmap_bias);
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
}
Allow changing mipmap LOD bias when FSR 1.0 scaling is not used Mipmap LOD bias can be useful to improve the appearance of distant textures without increasing anisotropic filtering (or in situations where anisotropic filtering is not effective). `fsr_mipmap_bias` was renamed to `texture_mipmap_bias` accordingly. The property hint now allows for greater precision as well.
2022-06-11 23:49:59 +00:00
float Viewport::get_texture_mipmap_bias() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(0);
Allow changing mipmap LOD bias when FSR 1.0 scaling is not used Mipmap LOD bias can be useful to improve the appearance of distant textures without increasing anisotropic filtering (or in situations where anisotropic filtering is not effective). `fsr_mipmap_bias` was renamed to `texture_mipmap_bias` accordingly. The property hint now allows for greater precision as well.
2022-06-11 23:49:59 +00:00
return texture_mipmap_bias;
Optionally scale 3D render content
2021-08-19 01:52:06 +00:00
}
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#endif // _3D_DISABLED
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
Propogate previously unused NOTIFICATION_WORLD_2D_CHANGED, make CanvasItem/CollisionObject2D use it
2022-01-25 03:01:59 +00:00
void Viewport::_propagate_world_2d_changed(Node *p_node) {
if (p_node != this) {
if (Object::cast_to<CanvasItem>(p_node)) {
p_node->notification(CanvasItem::NOTIFICATION_WORLD_2D_CHANGED);
} else {
Viewport *v = Object::cast_to<Viewport>(p_node);
if (v) {
if (v->world_2d.is_valid()) {
return;
}
}
}
}
for (int i = 0; i < p_node->get_child_count(); ++i) {
_propagate_world_2d_changed(p_node->get_child(i));
}
}
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
void Viewport::_bind_methods() {
ClassDB::bind_method(D_METHOD("set_world_2d", "world_2d"), &Viewport::set_world_2d);
ClassDB::bind_method(D_METHOD("get_world_2d"), &Viewport::get_world_2d);
ClassDB::bind_method(D_METHOD("find_world_2d"), &Viewport::find_world_2d);
ClassDB::bind_method(D_METHOD("set_canvas_transform", "xform"), &Viewport::set_canvas_transform);
ClassDB::bind_method(D_METHOD("get_canvas_transform"), &Viewport::get_canvas_transform);
ClassDB::bind_method(D_METHOD("set_global_canvas_transform", "xform"), &Viewport::set_global_canvas_transform);
ClassDB::bind_method(D_METHOD("get_global_canvas_transform"), &Viewport::get_global_canvas_transform);
ClassDB::bind_method(D_METHOD("get_final_transform"), &Viewport::get_final_transform);
Expose Viewport::get_screen_transform to GDScript
2022-10-15 19:02:58 +00:00
ClassDB::bind_method(D_METHOD("get_screen_transform"), &Viewport::get_screen_transform);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
ClassDB::bind_method(D_METHOD("get_visible_rect"), &Viewport::get_visible_rect);
ClassDB::bind_method(D_METHOD("set_transparent_background", "enable"), &Viewport::set_transparent_background);
ClassDB::bind_method(D_METHOD("has_transparent_background"), &Viewport::has_transparent_background);
Add option to enable HDR rendering in 2D This is needed to allow 2D to fully make use of 3D effects (e.g. glow), and can be used to substantially improve quality of 2D rendering at the cost of performance Additionally, the 2D rendering pipeline is done in linear space (we skip linear_to_srgb conversion in 3D tonemapping) so the entire Viewport can be kept linear. This is necessary for proper HDR screen support in the future.
2023-08-03 12:10:01 +00:00
ClassDB::bind_method(D_METHOD("set_use_hdr_2d", "enable"), &Viewport::set_use_hdr_2d);
ClassDB::bind_method(D_METHOD("is_using_hdr_2d"), &Viewport::is_using_hdr_2d);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
Implement MSAA for 2D [Vulkan only]
2022-08-12 23:02:32 +00:00
ClassDB::bind_method(D_METHOD("set_msaa_2d", "msaa"), &Viewport::set_msaa_2d);
ClassDB::bind_method(D_METHOD("get_msaa_2d"), &Viewport::get_msaa_2d);
ClassDB::bind_method(D_METHOD("set_msaa_3d", "msaa"), &Viewport::set_msaa_3d);
ClassDB::bind_method(D_METHOD("get_msaa_3d"), &Viewport::get_msaa_3d);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
ClassDB::bind_method(D_METHOD("set_screen_space_aa", "screen_space_aa"), &Viewport::set_screen_space_aa);
ClassDB::bind_method(D_METHOD("get_screen_space_aa"), &Viewport::get_screen_space_aa);
Initial TAA implementation Initial TAA support based on the implementation in Spartan Engine. Motion vectors are correctly generated for camera and mesh movement, but there is no support for other things like particles or skeleton deformations.
2022-04-04 14:10:22 +00:00
ClassDB::bind_method(D_METHOD("set_use_taa", "enable"), &Viewport::set_use_taa);
ClassDB::bind_method(D_METHOD("is_using_taa"), &Viewport::is_using_taa);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
ClassDB::bind_method(D_METHOD("set_use_debanding", "enable"), &Viewport::set_use_debanding);
ClassDB::bind_method(D_METHOD("is_using_debanding"), &Viewport::is_using_debanding);
ClassDB::bind_method(D_METHOD("set_use_occlusion_culling", "enable"), &Viewport::set_use_occlusion_culling);
ClassDB::bind_method(D_METHOD("is_using_occlusion_culling"), &Viewport::is_using_occlusion_culling);
ClassDB::bind_method(D_METHOD("set_debug_draw", "debug_draw"), &Viewport::set_debug_draw);
ClassDB::bind_method(D_METHOD("get_debug_draw"), &Viewport::get_debug_draw);
ClassDB::bind_method(D_METHOD("get_render_info", "type", "info"), &Viewport::get_render_info);
ClassDB::bind_method(D_METHOD("get_texture"), &Viewport::get_texture);
ClassDB::bind_method(D_METHOD("set_physics_object_picking", "enable"), &Viewport::set_physics_object_picking);
ClassDB::bind_method(D_METHOD("get_physics_object_picking"), &Viewport::get_physics_object_picking);
Fix propagation order for 2D physics picking events This patch adds a viewport-configuration-option for sorting physics-picking events by the Z-Index and the scene tree position of the collision objects.
2022-11-10 21:55:57 +00:00
ClassDB::bind_method(D_METHOD("set_physics_object_picking_sort", "enable"), &Viewport::set_physics_object_picking_sort);
ClassDB::bind_method(D_METHOD("get_physics_object_picking_sort"), &Viewport::get_physics_object_picking_sort);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
ClassDB::bind_method(D_METHOD("get_viewport_rid"), &Viewport::get_viewport_rid);
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
ClassDB::bind_method(D_METHOD("push_text_input", "text"), &Viewport::push_text_input);
ClassDB::bind_method(D_METHOD("push_input", "event", "in_local_coords"), &Viewport::push_input, DEFVAL(false));
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
#ifndef DISABLE_DEPRECATED
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
ClassDB::bind_method(D_METHOD("push_unhandled_input", "event", "in_local_coords"), &Viewport::push_unhandled_input, DEFVAL(false));
Deprecate push_unhandled_input The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
2023-05-10 19:51:50 +00:00
#endif // DISABLE_DEPRECATED
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
ClassDB::bind_method(D_METHOD("get_camera_2d"), &Viewport::get_camera_2d);
ClassDB::bind_method(D_METHOD("set_as_audio_listener_2d", "enable"), &Viewport::set_as_audio_listener_2d);
ClassDB::bind_method(D_METHOD("is_audio_listener_2d"), &Viewport::is_audio_listener_2d);
Fixes to 2D viewport * Editor 2D viewport now uses embedded subwindows (windows no longer pop up) * Restored the ability to disable 3D on the 2D viewport (makes 3D not display on 2D when there is a camera on the scene)
2021-06-29 16:36:32 +00:00
Rename [gs]et_pos to [gs]et_position for Controls Control set_pos -> set_position Control set_global_pos -> set_global_position [gs]et_mouse_pos -> [gs]et_mouse_position [gs]et_global_mouse_pos -> [gs]et_global_mouse_position fixes #8005
2017-03-29 15:29:38 +00:00
ClassDB::bind_method(D_METHOD("get_mouse_position"), &Viewport::get_mouse_position);
Rename warp mouse functions to warp_mouse
2022-03-27 09:17:36 +00:00
ClassDB::bind_method(D_METHOD("warp_mouse", "position"), &Viewport::warp_mouse);
Create a virtual mouse move event after moving child nodes This updates mouse cursor and mouse-over-states without the need for additional mouse movements.
2022-09-29 21:45:51 +00:00
ClassDB::bind_method(D_METHOD("update_mouse_cursor_state"), &Viewport::update_mouse_cursor_state);
-Added ATITC texture support -Fixed bug of some tabs showing wrong names -Exported properties for viewport
2014-02-26 13:08:17 +00:00
Removes type information from method binds
2017-08-09 11:19:41 +00:00
ClassDB::bind_method(D_METHOD("gui_get_drag_data"), &Viewport::gui_get_drag_data);
Avoid misuse of set_drag_preview() function where it shouldn't be. Closes #20100
2018-08-24 13:29:27 +00:00
ClassDB::bind_method(D_METHOD("gui_is_dragging"), &Viewport::gui_is_dragging);
Fix drag and drop on LineEdit
2021-10-28 07:07:18 +00:00
ClassDB::bind_method(D_METHOD("gui_is_drag_successful"), &Viewport::gui_is_drag_successful);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Exposes gui_release_focus and gui_get_focus_owner to Viewport
2022-02-01 14:07:22 +00:00
ClassDB::bind_method(D_METHOD("gui_release_focus"), &Viewport::gui_release_focus);
ClassDB::bind_method(D_METHOD("gui_get_focus_owner"), &Viewport::gui_get_focus_owner);
Rename the _MD macro to D_METHOD This new name also makes its purpose a little clearer This is a step towards fixing #56
2017-02-13 11:47:24 +00:00
ClassDB::bind_method(D_METHOD("set_disable_input", "disable"), &Viewport::set_disable_input);
ClassDB::bind_method(D_METHOD("is_input_disabled"), &Viewport::is_input_disabled);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Fix doubleclick on tree item, restore input focus on previous windows. Closes #37335
2020-07-01 13:59:42 +00:00
ClassDB::bind_method(D_METHOD("_gui_remove_focus_for_window"), &Viewport::_gui_remove_focus_for_window);
Improve popup menus usability It seems that popups were intended to "grab" the mouse click that triggered them, but their intent was being lost. This commit does the necessary changes to let it happen and updates items that were trying to get advantage of it, because the semantics of `Control::grab_click_focus()` have changed a bit. Namely, it must be called **before** showing the modal. This allows to popup a menu and activate an item in it in a single click-point-release cycle, instead of having to click once to open the menu and once more to pick an item. This ability is extended even to context menus activated with the RMB (or any other mouse button, for that matter). The editor benefits from this in the context menu of the tree dock, which has been patched to opt-in for this feature. This improves UX a bit by saving unnecessary clicks. From now on, `PopupMenu` always grabs the click and also invalidates the first button release unless the mouse has moved (that's what `set_invalidate_click_until_motion()` was doing and now it's removed), so there is no longer the need of doing both things at every point a pop-up menu is shown.
2018-03-27 21:41:27 +00:00
ClassDB::bind_method(D_METHOD("_post_gui_grab_click_focus"), &Viewport::_post_gui_grab_click_focus);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
ClassDB::bind_method(D_METHOD("set_positional_shadow_atlas_size", "size"), &Viewport::set_positional_shadow_atlas_size);
ClassDB::bind_method(D_METHOD("get_positional_shadow_atlas_size"), &Viewport::get_positional_shadow_atlas_size);
all light types and shadows are working, pending a lot of clean-up
2016-11-10 02:55:06 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
ClassDB::bind_method(D_METHOD("set_positional_shadow_atlas_16_bits", "enable"), &Viewport::set_positional_shadow_atlas_16_bits);
ClassDB::bind_method(D_METHOD("get_positional_shadow_atlas_16_bits"), &Viewport::get_positional_shadow_atlas_16_bits);
Shadow map rendering optimization -All shadow rendering is done with raster now (no compute) -All shadow rendering is done by rendering directly to the shadow atlas -Improved how buffer clearing is done to optimize the above. -Ability to set shadows as 16 bits.
2021-01-24 19:00:20 +00:00
Restored auto snapping of controls to pixels, fixes #10847 and probably several more issues. Made it optional in the project settings but defaults to true.
2017-09-07 14:22:07 +00:00
ClassDB::bind_method(D_METHOD("set_snap_controls_to_pixels", "enabled"), &Viewport::set_snap_controls_to_pixels);
ClassDB::bind_method(D_METHOD("is_snap_controls_to_pixels_enabled"), &Viewport::is_snap_controls_to_pixels_enabled);
Refactor pixel snapping. -Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes #41814 Solves proposal https://github.com/godotengine/godot-proposals/issues/1666 Supersedes #35606, supersedes #41535, supersedes #41534
2020-10-29 21:09:16 +00:00
ClassDB::bind_method(D_METHOD("set_snap_2d_transforms_to_pixel", "enabled"), &Viewport::set_snap_2d_transforms_to_pixel);
ClassDB::bind_method(D_METHOD("is_snap_2d_transforms_to_pixel_enabled"), &Viewport::is_snap_2d_transforms_to_pixel_enabled);
ClassDB::bind_method(D_METHOD("set_snap_2d_vertices_to_pixel", "enabled"), &Viewport::set_snap_2d_vertices_to_pixel);
ClassDB::bind_method(D_METHOD("is_snap_2d_vertices_to_pixel_enabled"), &Viewport::is_snap_2d_vertices_to_pixel_enabled);
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
ClassDB::bind_method(D_METHOD("set_positional_shadow_atlas_quadrant_subdiv", "quadrant", "subdiv"), &Viewport::set_positional_shadow_atlas_quadrant_subdiv);
ClassDB::bind_method(D_METHOD("get_positional_shadow_atlas_quadrant_subdiv", "quadrant"), &Viewport::get_positional_shadow_atlas_quadrant_subdiv);
all light types and shadows are working, pending a lot of clean-up
2016-11-10 02:55:06 +00:00
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
ClassDB::bind_method(D_METHOD("set_input_as_handled"), &Viewport::set_input_as_handled);
ClassDB::bind_method(D_METHOD("is_input_handled"), &Viewport::is_input_handled);
ClassDB::bind_method(D_METHOD("set_handle_input_locally", "enable"), &Viewport::set_handle_input_locally);
ClassDB::bind_method(D_METHOD("is_handling_input_locally"), &Viewport::is_handling_input_locally);
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
ClassDB::bind_method(D_METHOD("set_default_canvas_item_texture_filter", "mode"), &Viewport::set_default_canvas_item_texture_filter);
ClassDB::bind_method(D_METHOD("get_default_canvas_item_texture_filter"), &Viewport::get_default_canvas_item_texture_filter);
Cleanup embed subwindows getters
2022-03-13 15:18:44 +00:00
ClassDB::bind_method(D_METHOD("set_embedding_subwindows", "enable"), &Viewport::set_embedding_subwindows);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
ClassDB::bind_method(D_METHOD("is_embedding_subwindows"), &Viewport::is_embedding_subwindows);
Viewport canvas cull mask feature Co-authored-by: Valentin Zagura <puthre@gmail.com>
2021-09-02 18:07:04 +00:00
ClassDB::bind_method(D_METHOD("set_canvas_cull_mask", "mask"), &Viewport::set_canvas_cull_mask);
ClassDB::bind_method(D_METHOD("get_canvas_cull_mask"), &Viewport::get_canvas_cull_mask);
ClassDB::bind_method(D_METHOD("set_canvas_cull_mask_bit", "layer", "enable"), &Viewport::set_canvas_cull_mask_bit);
ClassDB::bind_method(D_METHOD("get_canvas_cull_mask_bit", "layer"), &Viewport::get_canvas_cull_mask_bit);
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
ClassDB::bind_method(D_METHOD("set_default_canvas_item_texture_repeat", "mode"), &Viewport::set_default_canvas_item_texture_repeat);
ClassDB::bind_method(D_METHOD("get_default_canvas_item_texture_repeat"), &Viewport::get_default_canvas_item_texture_repeat);
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
ClassDB::bind_method(D_METHOD("set_sdf_oversize", "oversize"), &Viewport::set_sdf_oversize);
ClassDB::bind_method(D_METHOD("get_sdf_oversize"), &Viewport::get_sdf_oversize);
ClassDB::bind_method(D_METHOD("set_sdf_scale", "scale"), &Viewport::set_sdf_scale);
ClassDB::bind_method(D_METHOD("get_sdf_scale"), &Viewport::get_sdf_scale);
Rename Lod Threshold to Mesh Lod Threshold This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
2021-12-28 23:10:41 +00:00
ClassDB::bind_method(D_METHOD("set_mesh_lod_threshold", "pixels"), &Viewport::set_mesh_lod_threshold);
ClassDB::bind_method(D_METHOD("get_mesh_lod_threshold"), &Viewport::get_mesh_lod_threshold);
Implement automatic LOD (Level of Detail) -Happens on import by default for all models -Just works (tm) -Biasing can be later adjusted per node or per viewport (as well as globally) -Disabled AABB.get_support test because its broken
2020-12-17 18:56:59 +00:00
Implement pause-aware picking This changes the way 2D & 3D physics picking behaves in relation to pause: - When pause is set, every collision object that is hovered or captured (3D only) is released from that condition, getting the relevant mouse-exit callback., unless its pause mode makes it immune from pause. - During the pause. picking only considers collision objects immune from pause, sending input events and enter/exit callbacks to them as expected. - When pause is left, nothing happens. This is a big difference with the classic behavior, which at this point would process all the input events that have been queued against the current state of the 2D/3D world (in other words, checking them against the current position of the objects instead of those at the time of the events).
2021-02-06 20:14:35 +00:00
ClassDB::bind_method(D_METHOD("_process_picking"), &Viewport::_process_picking);
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#ifndef _3D_DISABLED
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
ClassDB::bind_method(D_METHOD("set_world_3d", "world_3d"), &Viewport::set_world_3d);
ClassDB::bind_method(D_METHOD("get_world_3d"), &Viewport::get_world_3d);
ClassDB::bind_method(D_METHOD("find_world_3d"), &Viewport::find_world_3d);
ClassDB::bind_method(D_METHOD("set_use_own_world_3d", "enable"), &Viewport::set_use_own_world_3d);
ClassDB::bind_method(D_METHOD("is_using_own_world_3d"), &Viewport::is_using_own_world_3d);
ClassDB::bind_method(D_METHOD("get_camera_3d"), &Viewport::get_camera_3d);
ClassDB::bind_method(D_METHOD("set_as_audio_listener_3d", "enable"), &Viewport::set_as_audio_listener_3d);
ClassDB::bind_method(D_METHOD("is_audio_listener_3d"), &Viewport::is_audio_listener_3d);
ClassDB::bind_method(D_METHOD("set_disable_3d", "disable"), &Viewport::set_disable_3d);
ClassDB::bind_method(D_METHOD("is_3d_disabled"), &Viewport::is_3d_disabled);
ClassDB::bind_method(D_METHOD("set_use_xr", "use"), &Viewport::set_use_xr);
ClassDB::bind_method(D_METHOD("is_using_xr"), &Viewport::is_using_xr);
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
ClassDB::bind_method(D_METHOD("set_scaling_3d_mode", "scaling_3d_mode"), &Viewport::set_scaling_3d_mode);
ClassDB::bind_method(D_METHOD("get_scaling_3d_mode"), &Viewport::get_scaling_3d_mode);
ClassDB::bind_method(D_METHOD("set_scaling_3d_scale", "scale"), &Viewport::set_scaling_3d_scale);
ClassDB::bind_method(D_METHOD("get_scaling_3d_scale"), &Viewport::get_scaling_3d_scale);
ClassDB::bind_method(D_METHOD("set_fsr_sharpness", "fsr_sharpness"), &Viewport::set_fsr_sharpness);
ClassDB::bind_method(D_METHOD("get_fsr_sharpness"), &Viewport::get_fsr_sharpness);
Allow changing mipmap LOD bias when FSR 1.0 scaling is not used Mipmap LOD bias can be useful to improve the appearance of distant textures without increasing anisotropic filtering (or in situations where anisotropic filtering is not effective). `fsr_mipmap_bias` was renamed to `texture_mipmap_bias` accordingly. The property hint now allows for greater precision as well.
2022-06-11 23:49:59 +00:00
ClassDB::bind_method(D_METHOD("set_texture_mipmap_bias", "texture_mipmap_bias"), &Viewport::set_texture_mipmap_bias);
ClassDB::bind_method(D_METHOD("get_texture_mipmap_bias"), &Viewport::get_texture_mipmap_bias);
Optionally scale 3D render content
2021-08-19 01:52:06 +00:00
Adding Variable Rate Shading support to Godot Improve GI renderer and add VRS support Implement render device has_feature and move subgroup settings to limit_get
2022-02-11 11:33:54 +00:00
ClassDB::bind_method(D_METHOD("set_vrs_mode", "mode"), &Viewport::set_vrs_mode);
ClassDB::bind_method(D_METHOD("get_vrs_mode"), &Viewport::get_vrs_mode);
ClassDB::bind_method(D_METHOD("set_vrs_texture", "texture"), &Viewport::set_vrs_texture);
ClassDB::bind_method(D_METHOD("get_vrs_texture"), &Viewport::get_vrs_texture);
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "disable_3d"), "set_disable_3d", "is_3d_disabled");
Move XR flag from subviewport into viewport
2021-04-29 01:23:24 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "use_xr"), "set_use_xr", "is_using_xr");
Change non-existent World to World3D
2020-04-18 09:00:51 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "own_world_3d"), "set_use_own_world_3d", "is_using_own_world_3d");
doc: Sync classref with current source
2020-05-04 14:55:01 +00:00
ADD_PROPERTY(PropertyInfo(Variant::OBJECT, "world_3d", PROPERTY_HINT_RESOURCE_TYPE, "World3D"), "set_world_3d", "get_world_3d");
Disable Node3D when compiling without 3D and fix disable_3d option
2021-07-04 01:43:23 +00:00
#endif // _3D_DISABLED
Add PROPERTY_USAGE_NONE and use it
2021-06-17 23:10:18 +00:00
ADD_PROPERTY(PropertyInfo(Variant::OBJECT, "world_2d", PROPERTY_HINT_RESOURCE_TYPE, "World2D", PROPERTY_USAGE_NONE), "set_world_2d", "get_world_2d");
Remove use of _SCS from ADD_METHOD This saves typing and is a step towards fixing #56
2017-02-12 00:11:37 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "transparent_bg"), "set_transparent_background", "has_transparent_background");
-Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check) -Add ability for viewports to set input events as handled locally
2018-11-15 16:54:26 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "handle_input_locally"), "set_handle_input_locally", "is_handling_input_locally");
Refactor pixel snapping. -Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes #41814 Solves proposal https://github.com/godotengine/godot-proposals/issues/1666 Supersedes #35606, supersedes #41535, supersedes #41534
2020-10-29 21:09:16 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "snap_2d_transforms_to_pixel"), "set_snap_2d_transforms_to_pixel", "is_snap_2d_transforms_to_pixel_enabled");
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "snap_2d_vertices_to_pixel"), "set_snap_2d_vertices_to_pixel", "is_snap_2d_vertices_to_pixel_enabled");
-Conversion of most properties to a simpler syntax, easier to use by script -Modified help to display properties GDScript can still not make use of them, though.
2017-01-04 04:16:14 +00:00
ADD_GROUP("Rendering", "");
Implement MSAA for 2D [Vulkan only]
2022-08-12 23:02:32 +00:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "msaa_2d", PROPERTY_HINT_ENUM, String::utf8("Disabled (Fastest),2× (Average),4× (Slow),8× (Slowest)")), "set_msaa_2d", "get_msaa_2d");
ADD_PROPERTY(PropertyInfo(Variant::INT, "msaa_3d", PROPERTY_HINT_ENUM, String::utf8("Disabled (Fastest),2× (Average),4× (Slow),8× (Slowest)")), "set_msaa_3d", "get_msaa_3d");
Tweak dozens of editor property hints for consistency - Update Viewport MSAA property hints to match the currently exposed values. - Add some performance hints to property hints.
2021-05-22 02:30:58 +00:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "screen_space_aa", PROPERTY_HINT_ENUM, "Disabled (Fastest),FXAA (Fast)"), "set_screen_space_aa", "get_screen_space_aa");
Initial TAA implementation Initial TAA support based on the implementation in Spartan Engine. Motion vectors are correctly generated for camera and mesh movement, but there is no support for other things like particles or skeleton deformations.
2022-04-04 14:10:22 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "use_taa"), "set_use_taa", "is_using_taa");
Add a debanding property to Viewport It can be enabled in the Project Settings (`rendering/quality/screen_filters/use_debanding`). It's disabled by default as it has a small performance impact and can make PNG screenshots much larger (due to how dithering works). It will also slightly brighten the scene's dark areas. As a result, it should be enabled only when banding is noticeable enough. This closes #17006.
2020-04-20 21:34:47 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "use_debanding"), "set_use_debanding", "is_using_debanding");
Implement occlusion culling Added an occlusion culling system with support for static occluder meshes. It can be enabled via `Project Settings > Rendering > Occlusion Culling > Use Occlusion Culling`. Occluders are defined via the new `Occluder3D` resource and instanced using the new `OccluderInstance3D` node. The occluders can also be automatically baked from a scene using the built-in editor plugin.
2021-04-20 16:40:24 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "use_occlusion_culling"), "set_use_occlusion_culling", "is_using_occlusion_culling");
Rename Lod Threshold to Mesh Lod Threshold This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
2021-12-28 23:10:41 +00:00
ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "mesh_lod_threshold", PROPERTY_HINT_RANGE, "0,1024,0.1"), "set_mesh_lod_threshold", "get_mesh_lod_threshold");
Add 'Lighting' to list of Debug Draw viewport options
2023-01-19 20:23:59 +00:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "debug_draw", PROPERTY_HINT_ENUM, "Disabled,Unshaded,Lighting,Overdraw,Wireframe"), "set_debug_draw", "get_debug_draw");
Add option to enable HDR rendering in 2D This is needed to allow 2D to fully make use of 3D effects (e.g. glow), and can be used to substantially improve quality of 2D rendering at the cost of performance Additionally, the 2D rendering pipeline is done in linear space (we skip linear_to_srgb conversion in 3D tonemapping) so the entire Viewport can be kept linear. This is necessary for proper HDR screen support in the future.
2023-08-03 12:10:01 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "use_hdr_2d"), "set_use_hdr_2d", "is_using_hdr_2d");
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
#ifndef _3D_DISABLED
ADD_GROUP("Scaling 3D", "");
Fix 3D scaling enum size in the editor and improve descriptions
2022-04-09 15:52:38 +00:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "scaling_3d_mode", PROPERTY_HINT_ENUM, "Bilinear (Fastest),FSR 1.0 (Fast)"), "set_scaling_3d_mode", "get_scaling_3d_mode");
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "scaling_3d_scale", PROPERTY_HINT_RANGE, "0.25,2.0,0.01"), "set_scaling_3d_scale", "get_scaling_3d_scale");
Allow changing mipmap LOD bias when FSR 1.0 scaling is not used Mipmap LOD bias can be useful to improve the appearance of distant textures without increasing anisotropic filtering (or in situations where anisotropic filtering is not effective). `fsr_mipmap_bias` was renamed to `texture_mipmap_bias` accordingly. The property hint now allows for greater precision as well.
2022-06-11 23:49:59 +00:00
ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "texture_mipmap_bias", PROPERTY_HINT_RANGE, "-2,2,0.001"), "set_texture_mipmap_bias", "get_texture_mipmap_bias");
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "fsr_sharpness", PROPERTY_HINT_RANGE, "0,2,0.1"), "set_fsr_sharpness", "get_fsr_sharpness");
#endif
Adding Variable Rate Shading support to Godot Improve GI renderer and add VRS support Implement render device has_feature and move subgroup settings to limit_get
2022-02-11 11:33:54 +00:00
ADD_GROUP("Variable Rate Shading", "vrs_");
ADD_PROPERTY(PropertyInfo(Variant::INT, "vrs_mode", PROPERTY_HINT_ENUM, "Disabled,Texture,Depth buffer,XR"), "set_vrs_mode", "get_vrs_mode");
ADD_PROPERTY(PropertyInfo(Variant::OBJECT, "vrs_texture", PROPERTY_HINT_RESOURCE_TYPE, "Texture2D"), "set_vrs_texture", "get_vrs_texture");
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
ADD_GROUP("Canvas Items", "canvas_item_");
Tweak CanvasItem/material sampling property hints for readability The "Anisotropic" term is abbreviated as spelling it out would cause the PopupMenu to overflow the editor window when using the default inspector width.
2020-02-29 17:04:28 +00:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "canvas_item_default_texture_filter", PROPERTY_HINT_ENUM, "Nearest,Linear,Linear Mipmap,Nearest Mipmap"), "set_default_canvas_item_texture_filter", "get_default_canvas_item_texture_filter");
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "canvas_item_default_texture_repeat", PROPERTY_HINT_ENUM, "Disabled,Enabled,Mirror"), "set_default_canvas_item_texture_repeat", "get_default_canvas_item_texture_repeat");
-Conversion of most properties to a simpler syntax, easier to use by script -Modified help to display properties GDScript can still not make use of them, though.
2017-01-04 04:16:14 +00:00
ADD_GROUP("Audio Listener", "audio_listener_");
Remove use of _SCS from ADD_METHOD This saves typing and is a step towards fixing #56
2017-02-12 00:11:37 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "audio_listener_enable_2d"), "set_as_audio_listener_2d", "is_audio_listener_2d");
Fix the Audio Listener 3D property not being grouped with 2D in Viewport
2022-04-15 19:27:39 +00:00
#ifndef _3D_DISABLED
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "audio_listener_enable_3d"), "set_as_audio_listener_3d", "is_audio_listener_3d");
#endif
-Conversion of most properties to a simpler syntax, easier to use by script -Modified help to display properties GDScript can still not make use of them, though.
2017-01-04 04:16:14 +00:00
ADD_GROUP("Physics", "physics_");
Remove use of _SCS from ADD_METHOD This saves typing and is a step towards fixing #56
2017-02-12 00:11:37 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "physics_object_picking"), "set_physics_object_picking", "get_physics_object_picking");
Fix propagation order for 2D physics picking events This patch adds a viewport-configuration-option for sorting physics-picking events by the Z-Index and the scene tree position of the collision objects.
2022-11-10 21:55:57 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "physics_object_picking_sort"), "set_physics_object_picking_sort", "get_physics_object_picking_sort");
-Conversion of most properties to a simpler syntax, easier to use by script -Modified help to display properties GDScript can still not make use of them, though.
2017-01-04 04:16:14 +00:00
ADD_GROUP("GUI", "gui_");
Remove use of _SCS from ADD_METHOD This saves typing and is a step towards fixing #56
2017-02-12 00:11:37 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "gui_disable_input"), "set_disable_input", "is_input_disabled");
Restored auto snapping of controls to pixels, fixes #10847 and probably several more issues. Made it optional in the project settings but defaults to true.
2017-09-07 14:22:07 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "gui_snap_controls_to_pixels"), "set_snap_controls_to_pixels", "is_snap_controls_to_pixels_enabled");
Cleanup embed subwindows getters
2022-03-13 15:18:44 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "gui_embed_subwindows"), "set_embedding_subwindows", "is_embedding_subwindows");
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
ADD_GROUP("SDF", "sdf_");
ADD_PROPERTY(PropertyInfo(Variant::INT, "sdf_oversize", PROPERTY_HINT_ENUM, "100%,120%,150%,200%"), "set_sdf_oversize", "get_sdf_oversize");
ADD_PROPERTY(PropertyInfo(Variant::INT, "sdf_scale", PROPERTY_HINT_ENUM, "100%,50%,25%"), "set_sdf_scale", "get_sdf_scale");
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
ADD_GROUP("Positional Shadow Atlas", "positional_shadow_atlas_");
ADD_PROPERTY(PropertyInfo(Variant::INT, "positional_shadow_atlas_size"), "set_positional_shadow_atlas_size", "get_positional_shadow_atlas_size");
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "positional_shadow_atlas_16_bits"), "set_positional_shadow_atlas_16_bits", "get_positional_shadow_atlas_16_bits");
ADD_PROPERTYI(PropertyInfo(Variant::INT, "positional_shadow_atlas_quad_0", PROPERTY_HINT_ENUM, "Disabled,1 Shadow,4 Shadows,16 Shadows,64 Shadows,256 Shadows,1024 Shadows"), "set_positional_shadow_atlas_quadrant_subdiv", "get_positional_shadow_atlas_quadrant_subdiv", 0);
ADD_PROPERTYI(PropertyInfo(Variant::INT, "positional_shadow_atlas_quad_1", PROPERTY_HINT_ENUM, "Disabled,1 Shadow,4 Shadows,16 Shadows,64 Shadows,256 Shadows,1024 Shadows"), "set_positional_shadow_atlas_quadrant_subdiv", "get_positional_shadow_atlas_quadrant_subdiv", 1);
ADD_PROPERTYI(PropertyInfo(Variant::INT, "positional_shadow_atlas_quad_2", PROPERTY_HINT_ENUM, "Disabled,1 Shadow,4 Shadows,16 Shadows,64 Shadows,256 Shadows,1024 Shadows"), "set_positional_shadow_atlas_quadrant_subdiv", "get_positional_shadow_atlas_quadrant_subdiv", 2);
ADD_PROPERTYI(PropertyInfo(Variant::INT, "positional_shadow_atlas_quad_3", PROPERTY_HINT_ENUM, "Disabled,1 Shadow,4 Shadows,16 Shadows,64 Shadows,256 Shadows,1024 Shadows"), "set_positional_shadow_atlas_quadrant_subdiv", "get_positional_shadow_atlas_quadrant_subdiv", 3);
Add PROPERTY_USAGE_NONE and use it
2021-06-17 23:10:18 +00:00
ADD_PROPERTY(PropertyInfo(Variant::TRANSFORM2D, "canvas_transform", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NONE), "set_canvas_transform", "get_canvas_transform");
ADD_PROPERTY(PropertyInfo(Variant::TRANSFORM2D, "global_canvas_transform", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NONE), "set_global_canvas_transform", "get_global_canvas_transform");
Viewport canvas cull mask feature Co-authored-by: Valentin Zagura <puthre@gmail.com>
2021-09-02 18:07:04 +00:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "canvas_cull_mask", PROPERTY_HINT_LAYERS_2D_RENDER), "set_canvas_cull_mask", "get_canvas_cull_mask");
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
ADD_SIGNAL(MethodInfo("size_changed"));
Scroll ScrollContainer to focused children
2019-12-11 13:29:36 +00:00
ADD_SIGNAL(MethodInfo("gui_focus_changed", PropertyInfo(Variant::OBJECT, "node", PROPERTY_HINT_RESOURCE_TYPE, "Control")));
-Added ATITC texture support -Fixed bug of some tabs showing wrong names -Exported properties for viewport
2014-02-26 13:08:17 +00:00
ClassDB: Provide the enum name of integer constants
2017-08-20 15:45:01 +00:00
BIND_ENUM_CONSTANT(SHADOW_ATLAS_QUADRANT_SUBDIV_DISABLED);
BIND_ENUM_CONSTANT(SHADOW_ATLAS_QUADRANT_SUBDIV_1);
BIND_ENUM_CONSTANT(SHADOW_ATLAS_QUADRANT_SUBDIV_4);
BIND_ENUM_CONSTANT(SHADOW_ATLAS_QUADRANT_SUBDIV_16);
BIND_ENUM_CONSTANT(SHADOW_ATLAS_QUADRANT_SUBDIV_64);
BIND_ENUM_CONSTANT(SHADOW_ATLAS_QUADRANT_SUBDIV_256);
BIND_ENUM_CONSTANT(SHADOW_ATLAS_QUADRANT_SUBDIV_1024);
BIND_ENUM_CONSTANT(SHADOW_ATLAS_QUADRANT_SUBDIV_MAX);
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
BIND_ENUM_CONSTANT(SCALING_3D_MODE_BILINEAR);
BIND_ENUM_CONSTANT(SCALING_3D_MODE_FSR);
BIND_ENUM_CONSTANT(SCALING_3D_MODE_MAX);
doc: Sync classref with current source Add missing enum bindings.
2020-04-20 09:48:00 +00:00
BIND_ENUM_CONSTANT(MSAA_DISABLED);
BIND_ENUM_CONSTANT(MSAA_2X);
BIND_ENUM_CONSTANT(MSAA_4X);
BIND_ENUM_CONSTANT(MSAA_8X);
BIND_ENUM_CONSTANT(MSAA_MAX);
BIND_ENUM_CONSTANT(SCREEN_SPACE_AA_DISABLED);
BIND_ENUM_CONSTANT(SCREEN_SPACE_AA_FXAA);
BIND_ENUM_CONSTANT(SCREEN_SPACE_AA_MAX);
ClassDB: Provide the enum name of integer constants
2017-08-20 15:45:01 +00:00
BIND_ENUM_CONSTANT(RENDER_INFO_OBJECTS_IN_FRAME);
Fix Render Info * Fixed and redone the process to obtain render information from a viewport * Some stats, such as material changes are too difficult to guess on Vulkan, were removed. * Separated visible and shadow stats, which causes confusion. * Texture, buffer and general video memory can be queried now. * Fixed the performance metrics too.
2021-07-02 23:14:19 +00:00
BIND_ENUM_CONSTANT(RENDER_INFO_PRIMITIVES_IN_FRAME);
ClassDB: Provide the enum name of integer constants
2017-08-20 15:45:01 +00:00
BIND_ENUM_CONSTANT(RENDER_INFO_DRAW_CALLS_IN_FRAME);
BIND_ENUM_CONSTANT(RENDER_INFO_MAX);
Fix Render Info * Fixed and redone the process to obtain render information from a viewport * Some stats, such as material changes are too difficult to guess on Vulkan, were removed. * Separated visible and shadow stats, which causes confusion. * Texture, buffer and general video memory can be queried now. * Fixed the performance metrics too.
2021-07-02 23:14:19 +00:00
BIND_ENUM_CONSTANT(RENDER_INFO_TYPE_VISIBLE);
BIND_ENUM_CONSTANT(RENDER_INFO_TYPE_SHADOW);
BIND_ENUM_CONSTANT(RENDER_INFO_TYPE_MAX);
ClassDB: Provide the enum name of integer constants
2017-08-20 15:45:01 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_DISABLED);
BIND_ENUM_CONSTANT(DEBUG_DRAW_UNSHADED);
doc: Sync classref with current source Add missing enum bindings.
2020-04-20 09:48:00 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_LIGHTING);
ClassDB: Provide the enum name of integer constants
2017-08-20 15:45:01 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_OVERDRAW);
BIND_ENUM_CONSTANT(DEBUG_DRAW_WIREFRAME);
doc: Sync classref with current source Add missing enum bindings.
2020-04-20 09:48:00 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_NORMAL_BUFFER);
Rename GI Classes * GIProbe is now VoxelGI * BakedLightmap is now LightmapGI As godot adds more ways to provide GI (as an example, SDFGI in 4.0), the different techniques (which have different pros/cons) need to be properly named to avoid confusion.
2021-06-04 22:47:26 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_VOXEL_GI_ALBEDO);
BIND_ENUM_CONSTANT(DEBUG_DRAW_VOXEL_GI_LIGHTING);
BIND_ENUM_CONSTANT(DEBUG_DRAW_VOXEL_GI_EMISSION);
Auto exposure re-implemented in Vulkan
2020-01-12 01:26:52 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_SHADOW_ATLAS);
BIND_ENUM_CONSTANT(DEBUG_DRAW_DIRECTIONAL_SHADOW_ATLAS);
BIND_ENUM_CONSTANT(DEBUG_DRAW_SCENE_LUMINANCE);
Re-implemented screen space ambient occlusion
2020-01-25 10:18:55 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_SSAO);
Added SSIL post processing effect
2021-08-03 07:07:32 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_SSIL);
Refactored shadowmapping. - Made shadow bias size independent, so it will remain when changing light or camera size. - Implemented normal offset bias, which greatly enhances quality. - Added transmission to subsurface scattering - Reimplemented shadow filter modes Closes #17260
2020-04-08 01:51:52 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_PSSM_SPLITS);
Implement decals Also implemented decal atlas, so projectors and other stuff can be added. Sidenote: Had to make RID hashable, so some unrelated includes changed in order to include it in hashfuncs.h
2020-04-14 03:05:21 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_DECAL_ATLAS);
Addition of SDFGI for open world global illumination Move GI to a deferred pass
2020-06-25 13:33:28 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_SDFGI);
BIND_ENUM_CONSTANT(DEBUG_DRAW_SDFGI_PROBES);
BIND_ENUM_CONSTANT(DEBUG_DRAW_GI_BUFFER);
Implement automatic LOD (Level of Detail) -Happens on import by default for all models -Just works (tm) -Biasing can be later adjusted per node or per viewport (as well as globally) -Disabled AABB.get_support test because its broken
2020-12-17 18:56:59 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_DISABLE_LOD);
Added GPU based cluster builder Clustering is now GPU based, uses an implementation based on the Activision algorithm.
2021-01-17 16:25:38 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_CLUSTER_OMNI_LIGHTS);
BIND_ENUM_CONSTANT(DEBUG_DRAW_CLUSTER_SPOT_LIGHTS);
BIND_ENUM_CONSTANT(DEBUG_DRAW_CLUSTER_DECALS);
BIND_ENUM_CONSTANT(DEBUG_DRAW_CLUSTER_REFLECTION_PROBES);
Implement occlusion culling Added an occlusion culling system with support for static occluder meshes. It can be enabled via `Project Settings > Rendering > Occlusion Culling > Use Occlusion Culling`. Occluders are defined via the new `Occluder3D` resource and instanced using the new `OccluderInstance3D` node. The occluders can also be automatically baked from a scene using the built-in editor plugin.
2021-04-20 16:40:24 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_OCCLUDERS)
Initial TAA implementation Initial TAA support based on the implementation in Spartan Engine. Motion vectors are correctly generated for camera and mesh movement, but there is no support for other things like particles or skeleton deformations.
2022-04-04 14:10:22 +00:00
BIND_ENUM_CONSTANT(DEBUG_DRAW_MOTION_VECTORS)
Auto exposure re-implemented in Vulkan
2020-01-12 01:26:52 +00:00
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
BIND_ENUM_CONSTANT(DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_NEAREST);
BIND_ENUM_CONSTANT(DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_LINEAR);
BIND_ENUM_CONSTANT(DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_LINEAR_WITH_MIPMAPS);
Fix MIMPAMPS typos in constants throughout the engine
2020-02-19 23:31:43 +00:00
BIND_ENUM_CONSTANT(DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_NEAREST_WITH_MIPMAPS);
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
BIND_ENUM_CONSTANT(DEFAULT_CANVAS_ITEM_TEXTURE_FILTER_MAX);
doc: Sync classref with current source Add missing enum bindings.
2020-04-20 09:48:00 +00:00
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
BIND_ENUM_CONSTANT(DEFAULT_CANVAS_ITEM_TEXTURE_REPEAT_DISABLED);
BIND_ENUM_CONSTANT(DEFAULT_CANVAS_ITEM_TEXTURE_REPEAT_ENABLED);
BIND_ENUM_CONSTANT(DEFAULT_CANVAS_ITEM_TEXTURE_REPEAT_MIRROR);
BIND_ENUM_CONSTANT(DEFAULT_CANVAS_ITEM_TEXTURE_REPEAT_MAX);
Implement signed distance fields for 2D shaders
2020-11-26 12:50:21 +00:00
BIND_ENUM_CONSTANT(SDF_OVERSIZE_100_PERCENT);
BIND_ENUM_CONSTANT(SDF_OVERSIZE_120_PERCENT);
BIND_ENUM_CONSTANT(SDF_OVERSIZE_150_PERCENT);
BIND_ENUM_CONSTANT(SDF_OVERSIZE_200_PERCENT);
BIND_ENUM_CONSTANT(SDF_OVERSIZE_MAX);
BIND_ENUM_CONSTANT(SDF_SCALE_100_PERCENT);
BIND_ENUM_CONSTANT(SDF_SCALE_50_PERCENT);
BIND_ENUM_CONSTANT(SDF_SCALE_25_PERCENT);
BIND_ENUM_CONSTANT(SDF_SCALE_MAX);
Adding Variable Rate Shading support to Godot Improve GI renderer and add VRS support Implement render device has_feature and move subgroup settings to limit_get
2022-02-11 11:33:54 +00:00
BIND_ENUM_CONSTANT(VRS_DISABLED);
BIND_ENUM_CONSTANT(VRS_TEXTURE);
BIND_ENUM_CONSTANT(VRS_XR);
BIND_ENUM_CONSTANT(VRS_MAX);
}
Make `_validate_property` a multilevel method
2022-08-12 20:57:11 +00:00
void Viewport::_validate_property(PropertyInfo &p_property) const {
if (vrs_mode != VRS_TEXTURE && (p_property.name == "vrs_texture")) {
p_property.usage = PROPERTY_USAGE_NO_EDITOR;
Adding Variable Rate Shading support to Godot Improve GI renderer and add VRS support Implement render device has_feature and move subgroup settings to limit_get
2022-02-11 11:33:54 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Viewport::Viewport() {
world_2d = Ref<World2D>(memnew(World2D));
Fix 2D audio in multiple viewports
2023-05-03 20:57:15 +00:00
world_2d->register_viewport(this);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
viewport = RenderingServer::get_singleton()->viewport_create();
texture_rid = RenderingServer::get_singleton()->viewport_get_texture(viewport);
- _ready() callback only happens once now, if you want to receive it again, use request_ready() - C++ Nodes mostly do an internal process callback, so it does not conflict with users willing to use their own process callbacks - callbacks such as _input, _process, _fixed_process _unhandled_input, _unhandled_key_input do not requiere calling a function to enable them. They are enabled automatically if found on the script.
2017-01-10 21:02:19 +00:00
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
default_texture.instantiate();
- _ready() callback only happens once now, if you want to receive it again, use request_ready() - C++ Nodes mostly do an internal process callback, so it does not conflict with users willing to use their own process callbacks - callbacks such as _input, _process, _fixed_process _unhandled_input, _unhandled_key_input do not requiere calling a function to enable them. They are enabled automatically if found on the script.
2017-01-10 21:02:19 +00:00
default_texture->vp = const_cast<Viewport *>(this);
viewport_textures.insert(default_texture.ptr());
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
default_texture->proxy = RS::get_singleton()->texture_proxy_create(texture_rid);
- _ready() callback only happens once now, if you want to receive it again, use request_ready() - C++ Nodes mostly do an internal process callback, so it does not conflict with users willing to use their own process callbacks - callbacks such as _input, _process, _fixed_process _unhandled_input, _unhandled_key_input do not requiere calling a function to enable them. They are enabled automatically if found on the script.
2017-01-10 21:02:19 +00:00
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
canvas_layers.insert(nullptr); // This eases picking code (interpreted as the canvas of the Viewport).
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
set_positional_shadow_atlas_size(positional_shadow_atlas_size);
Shadow map rendering optimization -All shadow rendering is done with raster now (no compute) -All shadow rendering is done by rendering directly to the shadow atlas -Improved how buffer clearing is done to optimize the above. -Ability to set shadows as 16 bits.
2021-01-24 19:00:20 +00:00
all light types and shadows are working, pending a lot of clean-up
2016-11-10 02:55:06 +00:00
for (int i = 0; i < 4; i++) {
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
positional_shadow_atlas_quadrant_subdiv[i] = SHADOW_ATLAS_QUADRANT_SUBDIV_MAX;
all light types and shadows are working, pending a lot of clean-up
2016-11-10 02:55:06 +00:00
}
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-04-30 23:40:30 +00:00
set_positional_shadow_atlas_quadrant_subdiv(0, SHADOW_ATLAS_QUADRANT_SUBDIV_4);
set_positional_shadow_atlas_quadrant_subdiv(1, SHADOW_ATLAS_QUADRANT_SUBDIV_4);
set_positional_shadow_atlas_quadrant_subdiv(2, SHADOW_ATLAS_QUADRANT_SUBDIV_16);
set_positional_shadow_atlas_quadrant_subdiv(3, SHADOW_ATLAS_QUADRANT_SUBDIV_64);
-Added google play services (needed for some stuff) -Added new screen resizing options, stretch_2d is removed, new much more flexible ones. -Fixed bug in viewport (can create more instances in 3d-in-2d demo now) -Can set android permissions and screen sizes manually in the export settings -Changed export templates extension to .tpz (too many people unzipped the manually..) -File dialog now ensures that the proper extension is used (will not allow to save without it) -Fixed bug that made collision exceptions not work in 2D
2014-04-15 01:43:44 +00:00
Rename Lod Threshold to Mesh Lod Threshold This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
2021-12-28 23:10:41 +00:00
set_mesh_lod_threshold(mesh_lod_threshold);
Implement automatic LOD (Level of Detail) -Happens on import by default for all models -Just works (tm) -Biasing can be later adjusted per node or per viewport (as well as globally) -Disabled AABB.get_support test because its broken
2020-12-17 18:56:59 +00:00
Makes all Godot API's methods Lower Case
2017-08-07 10:17:31 +00:00
String id = itos(get_instance_id());
-Fixed a few bugs in Viewport -Made a few demos using Viewport to show it's true power! -Fixed some start-up error messages.
2014-04-10 03:18:27 +00:00
input_group = "_vp_input" + id;
gui_input_group = "_vp_gui_input" + id;
unhandled_input_group = "_vp_unhandled_input" + id;
[Input] Add extra `shortcut_input` input processing step to process Unicode character input with Alt / Ctrl modifiers, after processing of shortcuts.
2022-01-11 13:59:52 +00:00
shortcut_input_group = "_vp_shortcut_input" + id;
-Fixed a few bugs in Viewport -Made a few demos using Viewport to show it's true power! -Fixed some start-up error messages.
2014-04-10 03:18:27 +00:00
unhandled_key_input_group = "_vp_unhandled_key_input" + id;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Tooltips: Improve code clarity and docs The return type for `_make_custom_tooltip` is clarified as Control, and users should make sure to return a visible node for proper size calculations. Moreover in the current master branch, a PopupPanel will be added as parent to the provided tooltip to make it a sub-window. Clarifies documentation for `Control._make_custom_tooltip`, and shows how to use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types to style tooltips. Fixes #39677.
2020-11-02 16:18:29 +00:00
// Window tooltip.
Add PropertyInfo overload for GLOBAL_DEF
2022-11-08 18:53:22 +00:00
gui.tooltip_delay = GLOBAL_DEF(PropertyInfo(Variant::FLOAT, "gui/timers/tooltip_delay_sec", PROPERTY_HINT_RANGE, "0,5,0.01,or_greater"), 0.5);
-fixed bug related to mouse cursor changes, fixes #3366
2016-01-18 22:49:11 +00:00
Optionally scale 3D render content
2021-08-19 01:52:06 +00:00
#ifndef _3D_DISABLED
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 09:53:28 +00:00
set_scaling_3d_mode((Viewport::Scaling3DMode)(int)GLOBAL_GET("rendering/scaling_3d/mode"));
Implemented AMD's FSR as a computer shader for upscaling 3D scenes
2021-11-23 21:16:03 +00:00
set_scaling_3d_scale(GLOBAL_GET("rendering/scaling_3d/scale"));
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 09:53:28 +00:00
set_fsr_sharpness((float)GLOBAL_GET("rendering/scaling_3d/fsr_sharpness"));
set_texture_mipmap_bias((float)GLOBAL_GET("rendering/textures/default_filters/texture_mipmap_bias"));
Optionally scale 3D render content
2021-08-19 01:52:06 +00:00
#endif // _3D_DISABLED
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
set_sdf_oversize(sdf_oversize); // Set to server.
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Viewport::~Viewport() {
Clean up Viewport, remove dead code.
2021-09-10 14:58:33 +00:00
// Erase itself from viewport textures.
Use range iterators for RBSet in most cases
2022-05-18 23:43:40 +00:00
for (ViewportTexture *E : viewport_textures) {
E->vp = nullptr;
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
}
Add safety-checks before some servers `free()`
2022-12-12 17:42:37 +00:00
ERR_FAIL_NULL(RenderingServer::get_singleton());
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->free(viewport);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
/////////////////////////////////
void SubViewport::set_size(const Size2i &p_size) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Prohibit inconsistent size state for SubViewport Prohibit size changes of SubViewports with parent SubViewportContainers that have stretch mode enabled.
2022-10-04 19:53:18 +00:00
_internal_set_size(p_size);
}
Update the minimum size of ViewportContainer
2020-11-21 21:32:26 +00:00
Prohibit inconsistent size state for SubViewport Prohibit size changes of SubViewports with parent SubViewportContainers that have stretch mode enabled.
2022-10-04 19:53:18 +00:00
void SubViewport::set_size_force(const Size2i &p_size) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Prohibit inconsistent size state for SubViewport Prohibit size changes of SubViewports with parent SubViewportContainers that have stretch mode enabled.
2022-10-04 19:53:18 +00:00
// Use only for setting the size from the parent SubViewportContainer with enabled stretch mode.
// Don't expose function to scripting.
_internal_set_size(p_size, true);
}
void SubViewport::_internal_set_size(const Size2i &p_size, bool p_force) {
Update the minimum size of ViewportContainer
2020-11-21 21:32:26 +00:00
SubViewportContainer *c = Object::cast_to<SubViewportContainer>(get_parent());
Prohibit inconsistent size state for SubViewport Prohibit size changes of SubViewports with parent SubViewportContainers that have stretch mode enabled.
2022-10-04 19:53:18 +00:00
if (!p_force && c && c->is_stretch_enabled()) {
#ifdef DEBUG_ENABLED
WARN_PRINT("Can't change the size of a `SubViewport` with a `SubViewportContainer` parent that has `stretch` enabled. Set `SubViewportContainer.stretch` to `false` to allow changing the size manually.");
#endif // DEBUG_ENABLED
return;
}
Simplify Viewport::_set_size `Viewport.to_screen_rect` is used only in a single location to compare it to `Rect2i()`. When called from `SubViewport`, `to_screen_rect` is always equal to `Rect2i()`. When called from `Window`, `to_screen_rect` is always different from `Rect2i()`. So the comparison `to_screen_rect != Rect2i()` can be replaced by `Object::cast_to<Window>(this)`. This allows the removal of `Viewport.to_screen_rect` and the simplification of `Viewport::_set_size`.
2023-02-02 18:00:07 +00:00
_set_size(p_size, _get_size_2d_override(), true);
Prohibit inconsistent size state for SubViewport Prohibit size changes of SubViewports with parent SubViewportContainers that have stretch mode enabled.
2022-10-04 19:53:18 +00:00
Update the minimum size of ViewportContainer
2020-11-21 21:32:26 +00:00
if (c) {
c->update_minimum_size();
}
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
Size2i SubViewport::get_size() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Size2());
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
return _get_size();
}
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
void SubViewport::set_size_2d_override(const Size2i &p_size) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Simplify Viewport::_set_size `Viewport.to_screen_rect` is used only in a single location to compare it to `Rect2i()`. When called from `SubViewport`, `to_screen_rect` is always equal to `Rect2i()`. When called from `Window`, `to_screen_rect` is always different from `Rect2i()`. So the comparison `to_screen_rect != Rect2i()` can be replaced by `Object::cast_to<Window>(this)`. This allows the removal of `Viewport.to_screen_rect` and the simplification of `Viewport::_set_size`.
2023-02-02 18:00:07 +00:00
_set_size(_get_size(), p_size, true);
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
Size2i SubViewport::get_size_2d_override() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Size2i());
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
return _get_size_2d_override();
}
void SubViewport::set_size_2d_override_stretch(bool p_enable) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
if (p_enable == size_2d_override_stretch) {
return;
}
size_2d_override_stretch = p_enable;
Simplify Viewport::_set_size `Viewport.to_screen_rect` is used only in a single location to compare it to `Rect2i()`. When called from `SubViewport`, `to_screen_rect` is always equal to `Rect2i()`. When called from `Window`, `to_screen_rect` is always different from `Rect2i()`. So the comparison `to_screen_rect != Rect2i()` can be replaced by `Object::cast_to<Window>(this)`. This allows the removal of `Viewport.to_screen_rect` and the simplification of `Viewport::_set_size`.
2023-02-02 18:00:07 +00:00
_set_size(_get_size(), _get_size_2d_override(), true);
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
bool SubViewport::is_size_2d_override_stretch_enabled() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(false);
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
return size_2d_override_stretch;
}
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
void SubViewport::set_update_mode(UpdateMode p_mode) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
update_mode = p_mode;
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->viewport_set_update_mode(get_viewport_rid(), RS::ViewportUpdateMode(p_mode));
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
SubViewport::UpdateMode SubViewport::get_update_mode() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(UPDATE_DISABLED);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
return update_mode;
}
void SubViewport::set_clear_mode(ClearMode p_mode) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
clear_mode = p_mode;
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RS::get_singleton()->viewport_set_clear_mode(get_viewport_rid(), RS::ViewportClearMode(p_mode));
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
SubViewport::ClearMode SubViewport::get_clear_mode() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(CLEAR_MODE_ALWAYS);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
return clear_mode;
}
DisplayServer::WindowID SubViewport::get_window_id() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(DisplayServer::INVALID_WINDOW_ID);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
return DisplayServer::INVALID_WINDOW_ID;
}
Fix Viewport::get_mouse_position for SubViewports SubViewports don't have a cached mouse position available. This PR calculates the mouse position from the screen position of the mouse cursor.
2023-01-20 21:33:05 +00:00
Transform2D SubViewport::get_screen_transform_internal(bool p_absolute_position) const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Transform2D());
Remove redundant Variant-types initializations
2022-11-14 17:21:06 +00:00
Transform2D container_transform;
Fix using Viewport::warp_mouse within Viewports
2022-03-28 09:01:29 +00:00
SubViewportContainer *c = Object::cast_to<SubViewportContainer>(get_parent());
if (c) {
if (c->is_stretch_enabled()) {
container_transform.scale(Vector2(c->get_stretch_shrink(), c->get_stretch_shrink()));
}
Fix Viewport::get_mouse_position for SubViewports SubViewports don't have a cached mouse position available. This PR calculates the mouse position from the screen position of the mouse cursor.
2023-01-20 21:33:05 +00:00
container_transform = c->get_viewport()->get_screen_transform_internal(p_absolute_position) * c->get_global_transform_with_canvas() * container_transform;
Fix using Viewport::warp_mouse within Viewports
2022-03-28 09:01:29 +00:00
} else {
WARN_PRINT_ONCE("SubViewport is not a child of a SubViewportContainer. get_screen_transform doesn't return the actual screen position.");
}
Remove `Viewport::_get_input_pre_xform` This function is only relevant for `Window`. So this PR moves the functionality to the `Window`-class.
2023-02-02 18:28:14 +00:00
return container_transform * get_final_transform();
Fix using Viewport::warp_mouse within Viewports
2022-03-28 09:01:29 +00:00
}
Fix position of Tooltips CanvasItem::get_screen_transform returns a transform from the CanvasItem to the coordinate system, where a Popup - created as a child of the CanvasItem - should be opened. get_screen_transform makes some simplifications, that work well, when used in the editor, but not in general cases. Since Popups like Tooltips are now used more commonly in projects, it becomes necessary to correct these simplifications. This solution introduces Viewport::get_popup_base_transform, which makes the necessary calculations.
2022-11-13 20:38:29 +00:00
Transform2D SubViewport::get_popup_base_transform() const {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_READ_THREAD_GUARD_V(Transform2D());
Fix position of Tooltips CanvasItem::get_screen_transform returns a transform from the CanvasItem to the coordinate system, where a Popup - created as a child of the CanvasItem - should be opened. get_screen_transform makes some simplifications, that work well, when used in the editor, but not in general cases. Since Popups like Tooltips are now used more commonly in projects, it becomes necessary to correct these simplifications. This solution introduces Viewport::get_popup_base_transform, which makes the necessary calculations.
2022-11-13 20:38:29 +00:00
if (is_embedding_subwindows()) {
return Transform2D();
}
SubViewportContainer *c = Object::cast_to<SubViewportContainer>(get_parent());
if (!c) {
Remove `Viewport::_get_input_pre_xform` This function is only relevant for `Window`. So this PR moves the functionality to the `Window`-class.
2023-02-02 18:28:14 +00:00
return get_final_transform();
Fix position of Tooltips CanvasItem::get_screen_transform returns a transform from the CanvasItem to the coordinate system, where a Popup - created as a child of the CanvasItem - should be opened. get_screen_transform makes some simplifications, that work well, when used in the editor, but not in general cases. Since Popups like Tooltips are now used more commonly in projects, it becomes necessary to correct these simplifications. This solution introduces Viewport::get_popup_base_transform, which makes the necessary calculations.
2022-11-13 20:38:29 +00:00
}
Transform2D container_transform;
if (c->is_stretch_enabled()) {
container_transform.scale(Vector2(c->get_stretch_shrink(), c->get_stretch_shrink()));
}
Remove `Viewport::_get_input_pre_xform` This function is only relevant for `Window`. So this PR moves the functionality to the `Window`-class.
2023-02-02 18:28:14 +00:00
return c->get_screen_transform() * container_transform * get_final_transform();
Fix position of Tooltips CanvasItem::get_screen_transform returns a transform from the CanvasItem to the coordinate system, where a Popup - created as a child of the CanvasItem - should be opened. get_screen_transform makes some simplifications, that work well, when used in the editor, but not in general cases. Since Popups like Tooltips are now used more commonly in projects, it becomes necessary to correct these simplifications. This solution introduces Viewport::get_popup_base_transform, which makes the necessary calculations.
2022-11-13 20:38:29 +00:00
}
Fix mouse position with screen transform When a Viewport is not directly attached to the screen, the function `Viewport::get_mouse_position` can't rely on `get_screen_transform`, because that function is ambiguous in these situations. In these cases it is necessary to use the mouse position from the most recent mouse IputEvent.
2023-06-06 18:42:41 +00:00
bool SubViewport::is_directly_attached_to_screen() const {
// SubViewports, that are used as Textures are not considered to be directly attached to screen.
return Object::cast_to<SubViewportContainer>(get_parent()) && get_parent()->get_viewport() && get_parent()->get_viewport()->is_directly_attached_to_screen();
}
Refactor mouse_entered and mouse_exited notifications The previous implementation for signals mouse_entered and mouse_exited had shortcomings that relate to focused windows and pressed mouse buttons. For example a Control can be hovered by mouse, even if it is occluded by an embedded window. This patch changes the behavior, so that Control and Viewport send their mouse-enter/exit-notifications based solely on mouse position, visible area, and input restrictions and not on which window has focus or which mouse buttons are pressed. This implicitly also changes when the mouse_entered and mouse_exited signals are sent. This functionality can not be implemented as a part of Viewport::_gui_input_event, because of its interplay with Windows and because Viewport::_gui_input_event is based on input and not on visibility.
2023-01-06 20:48:20 +00:00
bool SubViewport::is_attached_in_viewport() const {
return Object::cast_to<SubViewportContainer>(get_parent());
}
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
void SubViewport::_notification(int p_what) {
Make more base nodes thread safe Ongoing work to make more of the base nodes thread safe.
2023-05-12 11:53:15 +00:00
ERR_MAIN_THREAD_GUARD;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 17:06:48 +00:00
switch (p_what) {
case NOTIFICATION_ENTER_TREE: {
RS::get_singleton()->viewport_set_active(get_viewport_rid(), true);
Fix some ways to create inconsistent Viewport sizes In the editor, it was possible to set the size of a `SubViewport` even in cases where a parent `SubViewportContainer` had stretch enabled. This PR disables editing a `SubViewport.size` while the parent disallows it and it makes necessary adjustments during `NOTIFICATION_ENTER_TREE`.
2023-02-12 23:34:16 +00:00
SubViewportContainer *parent_svc = Object::cast_to<SubViewportContainer>(get_parent());
if (parent_svc) {
parent_svc->recalc_force_viewport_sizes();
}
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 17:06:48 +00:00
} break;
case NOTIFICATION_EXIT_TREE: {
RS::get_singleton()->viewport_set_active(get_viewport_rid(), false);
} break;
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
}
}
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
void SubViewport::_bind_methods() {
ClassDB::bind_method(D_METHOD("set_size", "size"), &SubViewport::set_size);
ClassDB::bind_method(D_METHOD("get_size"), &SubViewport::get_size);
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
ClassDB::bind_method(D_METHOD("set_size_2d_override", "size"), &SubViewport::set_size_2d_override);
ClassDB::bind_method(D_METHOD("get_size_2d_override"), &SubViewport::get_size_2d_override);
ClassDB::bind_method(D_METHOD("set_size_2d_override_stretch", "enable"), &SubViewport::set_size_2d_override_stretch);
ClassDB::bind_method(D_METHOD("is_size_2d_override_stretch_enabled"), &SubViewport::is_size_2d_override_stretch_enabled);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
ClassDB::bind_method(D_METHOD("set_update_mode", "mode"), &SubViewport::set_update_mode);
ClassDB::bind_method(D_METHOD("get_update_mode"), &SubViewport::get_update_mode);
ClassDB::bind_method(D_METHOD("set_clear_mode", "mode"), &SubViewport::set_clear_mode);
ClassDB::bind_method(D_METHOD("get_clear_mode"), &SubViewport::get_clear_mode);
Add suffixes to all nodes and resources
2022-05-20 05:24:41 +00:00
ADD_PROPERTY(PropertyInfo(Variant::VECTOR2I, "size", PROPERTY_HINT_NONE, "suffix:px"), "set_size", "get_size");
ADD_PROPERTY(PropertyInfo(Variant::VECTOR2I, "size_2d_override", PROPERTY_HINT_NONE, "suffix:px"), "set_size_2d_override", "get_size_2d_override");
Re-expose a simplified version of the stretch properties in SubViewport
2020-04-01 03:47:58 +00:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "size_2d_override_stretch"), "set_size_2d_override_stretch", "is_size_2d_override_stretch_enabled");
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
ADD_GROUP("Render Target", "render_target_");
ADD_PROPERTY(PropertyInfo(Variant::INT, "render_target_clear_mode", PROPERTY_HINT_ENUM, "Always,Never,Next Frame"), "set_clear_mode", "get_clear_mode");
Fix off by one in Viewport.render_target_update_mode property enum
2021-10-29 02:42:01 +00:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "render_target_update_mode", PROPERTY_HINT_ENUM, "Disabled,Once,When Visible,When Parent Visible,Always"), "set_update_mode", "get_update_mode");
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
doc: Sync classref with current source Add missing enum bindings.
2020-04-20 09:48:00 +00:00
BIND_ENUM_CONSTANT(CLEAR_MODE_ALWAYS);
BIND_ENUM_CONSTANT(CLEAR_MODE_NEVER);
Rename Viewport::ClearMode::CLEAR_MODE_ONLY_NEXT_FRAME to CLEAR_MODE_ONCE
2020-12-10 12:19:04 +00:00
BIND_ENUM_CONSTANT(CLEAR_MODE_ONCE);
doc: Sync classref with current source Add missing enum bindings.
2020-04-20 09:48:00 +00:00
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
BIND_ENUM_CONSTANT(UPDATE_DISABLED);
BIND_ENUM_CONSTANT(UPDATE_ONCE);
BIND_ENUM_CONSTANT(UPDATE_WHEN_VISIBLE);
Open sub-windows as embedded if the OS does not support them
2020-03-14 16:06:39 +00:00
BIND_ENUM_CONSTANT(UPDATE_WHEN_PARENT_VISIBLE);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
BIND_ENUM_CONSTANT(UPDATE_ALWAYS);
}
Fix some ways to create inconsistent Viewport sizes In the editor, it was possible to set the size of a `SubViewport` even in cases where a parent `SubViewportContainer` had stretch enabled. This PR disables editing a `SubViewport.size` while the parent disallows it and it makes necessary adjustments during `NOTIFICATION_ENTER_TREE`.
2023-02-12 23:34:16 +00:00
void SubViewport::_validate_property(PropertyInfo &p_property) const {
if (p_property.name == "size") {
SubViewportContainer *parent_svc = Object::cast_to<SubViewportContainer>(get_parent());
if (parent_svc && parent_svc->is_stretch_enabled()) {
p_property.usage = PROPERTY_USAGE_DEFAULT | PROPERTY_USAGE_READ_ONLY;
} else {
p_property.usage = PROPERTY_USAGE_DEFAULT;
}
}
}
Fix SubViewport with default size being pink A SubViewport with default-size doesn't display its content, but shows pink color, until it is resized. This patch makes sure, that the size gets set during initialization.
2022-11-07 08:23:32 +00:00
SubViewport::SubViewport() {
RS::get_singleton()->viewport_set_size(get_viewport_rid(), get_size().width, get_size().height);
}
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
Initialize class variables with default values in scene/ [2/2]
2021-02-09 17:24:36 +00:00
SubViewport::~SubViewport() {}