godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
29,806 Commits 15 Branches 59 Tags 2.2 GiB
334c4129a4
Commit Graph

6628 Commits

Author SHA1 Message Date
K. S. Ernest (iFire) Lee
f7fdc87789 Custom Skeleton3DEditorPlugin 
Co-authored-by: Marios Staikopoulos <marios@staik.net>
 2020-05-22 09:54:34 -07:00
PouleyKetchoupp
ad8081216c Option in RichTextLabel for height to fit content 2020-05-22 09:20:49 +02:00
Dominik 'dreamsComeTrue' Jasiński
08377b3f04 Clarifies 'icon_separation' in TabContainer (instead of 'hseparation') 
Fixes: #38911
 2020-05-21 21:53:17 +02:00
Rémi Verschelde
d3612d04c7
Merge pull request #38794 from nekomatata/text-edit-search-result 
TextEdit search returns Dictionary instead of Vector
 2020-05-20 13:28:29 +02:00
Rémi Verschelde
aec07538f4
Merge pull request #38309 from SkyLucilfer/AndroidLineEdit 
Fix Android LineEdit editing bugs
 2020-05-20 11:45:59 +02:00
Andrea Catania
7c2794b35c Fixed kinematic body axis lock 2020-05-19 13:37:54 +02:00
Rémi Verschelde
ca3192d18a Style: Fix unnecessary semicolons that confused clang-format 2020-05-19 11:24:58 +02:00
Rémi Verschelde
8896425ee4
Merge pull request #38791 from clayjohn/physical-sky-update 
Add night sky to PhysicalSkyMaterial
 2020-05-18 16:33:50 +02:00
Hugo Locurcio
c9abc63108
Allow searching with keyboard input by default in PopupMenu 
See discussion in https://github.com/godotengine/godot-proposals/issues/43.
 2020-05-17 23:28:24 +02:00
Rémi Verschelde
4c8832701b
Merge pull request #38695 from dreamsComeTrue/node-swap-order-arguments 
Replace 'add_child_below_node' with 'add_sibling' in Node
 2020-05-17 11:36:05 +02:00
PouleyKetchoupp
242b94af1a TextEdit search returns a dictionary instead of Vector 
Easier to use than accessing elements in a Vector using indices given by an enum.
Breaks compatibility on existing scripts using this functionality.
 2020-05-16 23:46:14 +02:00
unknown
634e9460b9 Fix popup window size calculation in popup_centered_ratio by using Rect2 2020-05-17 03:06:42 +05:30
clayjohn
4408efade3 Add night sky to PhysicalSkyMaterial 2020-05-16 12:59:55 -07:00
Rémi Verschelde
163687d17a
Merge pull request #38782 from mbrlabs/text-editor-fix 
Fixed text editor drawing if smooth scrolling is disabled.
 2020-05-16 19:26:55 +02:00
PouleyKetchoupp
3ad694018f Fix Container sorting not working when overriding _sort_children in gdscript 
Remove _sort_children from script bindings:
_sort_children is an internal method which shouldn't be exposed to scripts.

Added support for non-bound methods in MessageQueue:
So we can use deferred calls without exposing internal methods to scripts.

Added debug checks in CallableCustomMethodPointer:
Adding method pointer callables to the message queue was causing crashes
in case an object was destroyed and the same memory was allocated for
another one. The new object had a valid object id but the call was erroneous.
Release will be fixed later, along with Variant which has the same problem and
is also fixed for debug only.
 2020-05-16 18:13:25 +02:00
SkyJJ
cc473b948f Fix Android LineEdit editing bugs 2020-05-16 17:55:27 +02:00
Marcus Brummer
b048eb05ad Fixed text editor drawing if smooth scrolling is disabled. 
Fixes #38778
 2020-05-16 16:31:43 +02:00
Hugo Locurcio
d935a4348d
Remove HQ2X and the Image.expand_2x_hq2x() method 
As of Godot 3.0, HQ2X is no longer used to upscale the editor theme
and icons on hiDPI displays, which limited its effective uses.
HQ2X was also used to upscale the project theme when the "Use Hidpi"
project setting was enabled, but results were often less than ideal.
The new StyleBoxFlat and SVG support also make HQ2X less important
to have as a core feature.

This decreases binary sizes slightly (-150 KB on most platforms,
-212 KB on WebAssembly release).

This partially addresses #12419.
 2020-05-16 16:10:50 +02:00
Rémi Verschelde
ac58372db8
Merge pull request #38463 from smartin015/3.2-fixgedit 
Remove get_local_mouse_position() hack in GraphEdit
 2020-05-16 13:52:20 +02:00
smartin015
00457c68bc Remove get_local_mouse_position() hack in GraphEdit 2020-05-16 13:22:52 +02:00
bruvzg
08e80ccd99
Fix popup positions on multiple screens (with same scaling only). 2020-05-16 14:11:43 +03:00
Dominik 'dreamsComeTrue' Jasiński
7f5c81c32f Replace 'add_child_below_node' with 'add_sibling' in Node 
Fixes: #19642
 2020-05-15 22:02:00 +02:00
Rémi Verschelde
0ee0fa42e6 Style: Enforce braces around if blocks and loops 
Using clang-tidy's `readability-braces-around-statements`.
https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
 2020-05-14 21:57:34 +02:00
Rémi Verschelde
07bc4e2f96 Style: Enforce separation line between function definitions 
I couldn't find a tool that enforces it, so I went the manual route:
```
find -name "thirdparty" -prune \
  -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \
  -o -name "*.glsl" > files
perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files)
misc/scripts/fix_style.sh -c
```

This adds a newline after all `}` on the first column, unless they
are followed by `#` (typically `#endif`). This leads to having lots
of places with two lines between function/class definitions, but
clang-format then fixes it as we enforce max one line of separation.

This doesn't fix potential occurrences of function definitions which
are indented (e.g. for a helper class defined in a .cpp), but it's
better than nothing. Also can't be made to run easily on CI/hooks so
we'll have to be careful with new code.

Part of #33027.
 2020-05-14 16:54:55 +02:00
Rémi Verschelde
0be6d925dc Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 
Which means that reduz' beloved style which we all became used to
will now be changed automatically to remove the first empty line.

This makes us lean closer to 1TBS (the one true brace style) instead
of hybridating it with some Allman-inspired spacing.

There's still the case of braces around single-statement blocks that
needs to be addressed (but clang-format can't help with that, but
clang-tidy may if we agree about it).

Part of #33027.
 2020-05-14 16:54:55 +02:00
Rémi Verschelde
710b34b702 Style: Fix missing/invalid copyright headers 2020-05-14 16:54:54 +02:00
Ignacio Roldán Etcheverry
27b4915fa8
Merge pull request #38718 from neikeq/fix-bindings-after-lightmapper 
Fix C# bindings after lightmapper changes
 2020-05-14 16:12:26 +02:00
Rémi Verschelde
a1aaed5a84 Remove redundant void argument lists 
Using clang-tidy's `modernize-redundant-void-arg`.
https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html
 2020-05-14 13:51:45 +02:00
Rémi Verschelde
dcd1151d77 Enforce use of bool literals instead of integers 
Using clang-tidy's `modernize-use-bool-literals`.
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html
 2020-05-14 13:45:01 +02:00
Rémi Verschelde
1a8167867b Modernize remaining uses of 0/NULL instead of nullptr (C++11) 
Using clang-tidy's `modernize-use-nullptr`.
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html
 2020-05-14 13:45:01 +02:00
Rémi Verschelde
1f6f364a56 Port member initialization from constructor to declaration (C++11) 
Using `clang-tidy`'s `modernize-use-default-member-init` check and
manual review of the changes, and some extra manual changes that
`clang-tidy` failed to do.

Also went manually through all of `core` to find occurrences that
`clang-tidy` couldn't handle, especially all initializations done
in a constructor without using initializer lists.
 2020-05-14 10:01:56 +02:00
Ignacio Etcheverry
af78a69b6f Fix C# bindings after lightmapper changes 2020-05-13 15:54:30 +02:00
Rémi Verschelde
6dfea347b0
Merge pull request #38655 from ice-blaze/minimap-shifted-selection-by-one-line#38532 
Fix minimap selection offset
 2020-05-12 18:02:21 +02:00
Rémi Verschelde
d3bd219362 doc: Sync classref with current source 
Adds API changes from the new GPU lightmapper.
 2020-05-12 10:10:50 +02:00
Rémi Verschelde
66b0b0c153
Merge pull request #38635 from Calinou/tilemap-rename-ysort-index 
Rename various TileMap methods/properties for clarity and consistency
 2020-05-11 23:05:15 +02:00
Rémi Verschelde
83b630b8c2 thirdparty: Cleanup after #38386, document provenance and copyright 
Also renamed `delaunay.h` to `delaunay_2d.h` to match the class name.
 2020-05-11 14:50:06 +02:00
Rémi Verschelde
32133a11b5
Merge pull request #38386 from reduz/new-lightmapper 
New GPU lightmapper
 2020-05-11 13:45:48 +02:00
Rémi Verschelde
f7254cf43c
Merge pull request #38491 from eduardonunesp/input-line-osx-selection 
Using the common behaviour when use command+shift on text line for osx
 2020-05-11 11:13:12 +02:00
Rémi Verschelde
22db301009
Merge pull request #31938 from KoBeWi/a_welcome_lag 
Fix VisibilityEnabler2D behavior on start
 2020-05-11 10:27:42 +02:00
Eduardo Nunes Pereira
d8f8a3c606 Using the common behaviour when use command+shift on text line for osx 
* On press left+command+shift or right+command+shift it should behave like shift+home or shift+end and select the text
* Using home and end events as reference
 2020-05-11 10:25:07 +02:00
etienne.frank
72ab355945 Fix minimap selection offset 
The minimap selection was shifted of 1 line too late.
 2020-05-11 10:02:16 +02:00
Juan Linietsky
1bea8e1eac New lightmapper 
-Added LocalVector (needed it)
-Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too)
-Fixes and changes all around the place
-Added library for 128 bits fixed point (required for Delaunay3D)
 2020-05-10 15:59:09 -03:00
Hugo Locurcio
c64c45ccaf
Rename various TileMap methods/properties for clarity and consistency 
The YSort renames were tracked in https://github.com/godotengine/godot/issues/16863.

This closes https://github.com/godotengine/godot-proposals/issues/814.
 2020-05-10 19:16:38 +02:00
Rémi Verschelde
94721f5ab8 Revert "Renamed plane's d to distance" 
This reverts commit ec7b481170.

This was wrong, `d` is not a distance but the `d` constant in the
parametric equation `ax + by + cz = d` describing the plane.
 2020-05-10 16:47:11 +02:00
Rémi Verschelde
69de7ce38c Style: clang-format: Disable AllowShortCaseLabelsOnASingleLine 
Part of #33027.
 2020-05-10 13:13:54 +02:00
Rémi Verschelde
e956e80c1f Style: clang-format: Disable AllowShortIfStatementsOnASingleLine 
Part of #33027, also discussed in #29848.

Enforcing the use of brackets even on single line statements would be
preferred, but `clang-format` doesn't have this functionality yet.
 2020-05-10 13:12:16 +02:00
Rémi Verschelde
03b13e0c69 Style: Add missing copyright headers 2020-05-10 13:12:16 +02:00
Rémi Verschelde
9cc67b19b8
Merge pull request #38613 from MCrafterzz/plane 
Renamed plane's d to distance
 2020-05-10 13:06:55 +02:00
Marcel Admiraal
68eaaa6d6b Prevent CapsuleShape2D height from being less than zero. 2020-05-10 11:45:27 +01:00
Marcus Elg
ec7b481170 Renamed plane's d to distance 2020-05-10 12:12:51 +02:00
Marcus Elg
9a7e515d50 Rename Lineshapes d to distance 2020-05-09 15:10:00 +02:00
Hugo Locurcio
3a11baaeac
Turn the anisotropic filtering setting into an enum 
Since it only accepts power-of-two values, exposing it as an enum
makes more sense. This also allows for adding property hints to indicate
the performance cost of each value.

This also improves property hints for MSAA and FXAA.
 2020-05-08 12:07:35 +02:00
Tomasz Chabora
d0c5d91032 Fix VisibilityEnabler2D behavior on start 2020-05-08 11:19:52 +02:00
Mateo Kuruk Miccino
e253451a5b GUI: Touch screen button click area now is synced with its draw 
(cherry picked from commit 1cba7fb180)
 2020-05-07 21:21:13 +02:00
Rémi Verschelde
d7b85fbaa1
Merge pull request #31086 from volzhs/underline 
Use underline position and thickness value in font file
 2020-05-07 21:18:41 +02:00
Rémi Verschelde
bef52957d0
Merge pull request #38226 from Calinou/increase-camera3d-fov 
Increase the default Camera3D field of view to 75
 2020-05-07 21:16:21 +02:00
Rémi Verschelde
b62218bbac
Merge pull request #38385 from ThakeeNathees/method-bind-text_edit-set_line 
method bind TextEdit::set_line() added
 2020-05-07 13:43:34 +02:00
Rémi Verschelde
49a1e3db12
Merge pull request #38524 from hoontee/master 
Fix bug with AudioStreamPlayer3D audio position
 2020-05-07 11:18:20 +02:00
hoontee
330bd686ab
Fix bug with AudioStreamPlayer3D audio position 
Applies 0c78a58b64 to `AudioStreamPlayer3D::play`.
 2020-05-07 02:23:50 -05:00
nobuyuki_nyuu
35f30086de PopupMenu.get_current_index() bound to ClassDB 2020-05-06 15:27:35 -05:00
Rémi Verschelde
aca9cfa76c
Merge pull request #38495 from DarkMessiah/tree-bind-suffix 
Bind set_suffix and get_suffix in Tree
 2020-05-06 13:58:34 +02:00
Rémi Verschelde
ca289f4d6f
Merge pull request #38488 from EricEzaM/adjust-stretch-ratio-value-range-and-documentation 
Updated editor spin slider to have better behaviour and adjusted control's size_flags_stretch_ratio value range
 2020-05-06 10:06:53 +02:00
Stanislav Labzyuk
ac8814624d Bind set_suffix/get_suffix in Tree 2020-05-06 14:47:19 +07:00
Eric M
915ab50673 Updated editor spin slider to have better behaviour and adjusted control's size_flags_stretch_ratio value range 2020-05-06 17:43:31 +10:00
Rémi Verschelde
42649565e9
Merge pull request #38475 from Chaosus/vs_quals 
Added uniform qualifiers to visual shaders
 2020-05-06 07:27:35 +02:00
Rémi Verschelde
4d50f747d5
Merge pull request #37293 from Janglee123/ctrl-click-improvements 
Improved go-to definition (Ctrl + Click)
 2020-05-05 16:49:15 +02:00
Rémi Verschelde
88e242116a
Merge pull request #38480 from ThakeeNathees/tween-get-set-fix 
Fix: Tween always return true for _get(), _set()
 2020-05-05 16:43:54 +02:00
Thakee Nathees
2811268231 Fix: Tween always return true for _get(), _set() 2020-05-05 16:32:33 +05:30
Yuri Roubinsky
463e4ad0f5 Some fixes for canvas item visual shader inputs 2020-05-05 13:19:36 +03:00
Yuri Roubinsky
082542b525 Added uniform qualifiers to visual shaders 2020-05-05 11:25:48 +03:00
janglee
be7a353c70 Improved go-to definition (Ctrl + Click) 
Co-Authored-By: Bojidar Marinov <bojidar.marinov.bg@gmail.com>
 2020-05-05 10:46:12 +05:30
Rémi Verschelde
f7ca1c805b doc: Sync classref with current source 2020-05-04 16:55:01 +02:00
Rémi Verschelde
878adb22b7
Merge pull request #37717 from qarmin/world_fix 
Change non-existent World to World3D
 2020-05-04 16:37:40 +02:00
Rémi Verschelde
560510b93b
Merge pull request #38446 from qarmin/navigation_polygon_type 
Fixes type of array in _set_outlines function
 2020-05-04 16:36:16 +02:00
Rémi Verschelde
69f36cea8c Revert "Emit signal when animation ends by seek" 
This reverts commit bf1cc116e1.

This needs more discussion to avoid breaking some users' expectations.
See #38086 for arguments.
 2020-05-04 16:09:19 +02:00
qarmin
4af274756f Fixes type of array in _set_outlines function 2020-05-04 07:39:40 +02:00
Rémi Verschelde
ec542db782
Merge pull request #38394 from reduz/implement-skew 
Implement Skew in Node2D
 2020-05-03 18:17:08 +02:00
Thomas Riedmair
e0f084b924 Fix performance issue in update_bitmask_region fallback 2020-05-03 00:27:47 +02:00
Bastiaan Olij
45d1f41837 Added missing spring enums for generic_6dof_joint 2020-05-02 21:49:56 +10:00
Juan Linietsky
efb1f7d76b Implement Skew in Node2D 
Skew is x-axis only, because it must be bidirectionally convertible to a 2x3 matrix, but you can subtract it  to the rotation to get the effect on y-axis
 2020-05-01 13:38:04 -03:00
Thakee Nathees
b9acf1cedf method bind TextEdit::set_line() added 2020-05-01 18:37:12 +05:30
Rémi Verschelde
b77f0e83ca
Merge pull request #38346 from jitspoe/master.fix_uninitialized_particle_param 
Fix custom w component being uninitialized on CPU particles.
 2020-05-01 14:58:10 +02:00
Hugo Locurcio
ccc4f3899c
Increase the default Camera3D field of view to 75 
A vertical FOV of 75 degrees is roughly equivalent to a 91 degree
horizontal FOV on a 4:3 display (~107.51 degrees on 16:9),
which is close to the typical default FOV used in PC games.

Note that this doesn't apply to the in-editor camera which keeps its
FOV to 70. This is because it doesn't display in fullscreen;
its viewport only displays in the center of the editor (roughly).
This means the viewport won't cover the viewer's eyes as much. Therefore,
the editor camera FOV should be slightly lower to account for this.

Since this changes the default value, this may break existing projects
slightly.

For the record, this was already done in
https://github.com/godotengine/godot-demo-projects/pull/260
for the official demo projects.
 2020-05-01 14:03:27 +02:00
Josh Chandler
8230e08f18 fixed camera2D showing incorrect bounds in editor 2020-04-30 12:25:39 -04:00
Darenn
b4e3042cba Fixed bbcode parsing for built-in RichTextEffects in RichTextLabel 
RichTextEffect can now have a bbcode string starting like one of the built-in.
It was impossible before as the built-in would take precedence over the custom effect that has the same bbcode start.

Example : [fade] would take precedence over [fade_in]
 2020-04-30 11:56:40 +02:00
jitspoe
895ed2aed7 Fix custom w component being uninitialized on CPU particles. 
(cherry picked from commit 38085f2f6982c491935a434bb45e358dbebe1714)
(cherry picked from commit b9c280b73ff6a13ea490d2da0f2728bcef3038dc)
 2020-04-30 01:41:46 -04:00
Rémi Verschelde
b46e5c7b94
Merge pull request #38203 from woollysammoth/multiple-ik-bug 
Fixes SkeletonIK resetting other IK poses
 2020-04-29 17:29:51 +02:00
Rémi Verschelde
f6e29addd4
Merge pull request #37846 from CaptainProton42/text-edit-undo-stack-size 
Add "undo_max_stack_size" property to TextEdit
 2020-04-29 15:56:08 +02:00
volzhs
9f1de2cfdd Use underline position and thickness value in font file 2020-04-29 21:56:15 +09:00
John Wigg
4a82390aaf Limit undo stack size 
The stack size of the undo history of a TextEdit was not limited leading
to potential memory leaks when doing lots of operations on a TextEdit.

This commit adds the option gui/common/text_edit_undo_stack_max_size
to the project settings. The first element of the undo stack is popped
if the stack's size exceeds this value ensuring limited memory usage.

The default stack size setting is 1024.

Fixes #37838.
 2020-04-29 11:31:01 +02:00
Aaron Franke
540156b387
[Core] Rename linear_interpolate to lerp 2020-04-29 04:02:49 -04:00
Rémi Verschelde
dfe38fbf8a
Merge pull request #38287 from JiRuifanCR/animatedtexture-oneshot-pause-set-frame 
Add set_frame, pause, and oneshot to AnimatedTexture
 2020-04-29 09:14:37 +02:00
Tomasz Chabora
9dfb231e00 Remove unneccessary increment in TextEdit 2020-04-29 00:16:48 +02:00
Revan Ji
f5029e18ca Add set_frame, pause, and oneshot to AnimatedTexture 
Add API documentation for said changes.
 2020-04-29 00:26:37 +08:00
Rémi Verschelde
fdf58a5858 Rename InputFilter back to Input 
It changed name as part of the DisplayServer and input refactoring
in #37317, with the rationale that input no longer goes through the
main loop, so the previous Input singleton now only does filtering.

But the gains in consistency are quite limited in the renaming, and
it breaks compatibility for all scripts and tutorials that access
the Input singleton via the scripting language. A temporary option
was suggested to keep the scripting singleton named `Input` even if
its type is `InputFilter`, but that adds inconsistency and breaks C#.

Fixes godotengine/godot-proposals#639.
Fixes #37319.
Fixes #37690.
 2020-04-28 15:19:49 +02:00
Rémi Verschelde
d8066aa6a4
Merge pull request #38286 from bojidar-bg/x-expose-cell-size 
Expose the cell_size affecting VisibilityNotifier2D precision
 2020-04-28 11:19:16 +02:00
Bojidar Marinov
d49ff7aff7
Expose the cell_size affecting VisibilityNotifier2D precision 
Refs: #4803
 2020-04-28 10:33:45 +03:00
Rémi Verschelde
717f053e37
Merge pull request #38121 from JFonS/add_unwrap_caching 
Add caching the lightmap unwrapping on import
 2020-04-27 18:51:32 +02:00
Rémi Verschelde
3031641879
Merge pull request #38243 from KoBeWi/whine 
Make Line2D be white by default
 2020-04-27 08:56:34 +02:00
Rémi Verschelde
2c91b7f27a
Merge pull request #36035 from Xrayez/path2d-fix-self-modulate 
Do not override Path2D.self_modulate property
 2020-04-27 08:55:22 +02:00
Tomasz Chabora
458cbef64e Make Line2D be white by default 2020-04-26 23:40:41 +02:00
Sam
e321d38c0e Resets global pose of IK chain bones being solved, rather than the whole skeleton. Resolves #38026 2020-04-25 10:57:42 -04:00
Rémi Verschelde
cacedac8b7
Merge pull request #38155 from Calinou/tweak-ssao-property-hints 
Tweak SSAO property hints to allow setting more precise values
 2020-04-25 12:55:25 +02:00
Hugo Locurcio
ad55749718
Tweak SSAO property hints to allow setting more precise values 
This was requested by an user on Twitter who was working on a
game with a very small-scale world.
 2020-04-23 21:46:20 +02:00
Rémi Verschelde
a800048071
Merge pull request #38109 from nekomatata/mesh-instance-active-material 
Fix get_active_material when a material is directly set on the mesh
 2020-04-23 12:42:11 +02:00
JFonS
f7dadc4796 Add caching the lightmap unwrapping on import 
This commit adds caching to the lightmap mesh unwraps generated on
import. This speeds up re-imports of meshes that haven't changed and
also makes sure that the unwraps are consistent across imports.

The unwrapping process is not deterministic, so one could end up with
a different mapping every time the scene was imported, breaking any
previously baked lightmaps. The changes in this commit prevent that
from happening.
 2020-04-22 15:34:00 +02:00
PouleyKetchoupp
72ee09082c Fix get_active_material when a material is directly set on the mesh 
Makes MeshInstance3D::get_active_material consistent with the logic
in the rendering system.

Fixes #38108
 2020-04-22 14:35:25 +02:00
Rémi Verschelde
f989a43135
Merge pull request #38086 from volzhs/seek-animation-finished 
Emit signal when animation ends by seek
 2020-04-22 10:07:29 +02:00
volzhs
bf1cc116e1 Emit signal when animation ends by seek 2020-04-22 00:45:44 +09:00
Juan Linietsky
f8ef38efed Add proper type to most public API uses of Array 2020-04-21 12:16:45 -03:00
Juan Linietsky
5d4dc2d45c Add ability to bind typed arrays to script API 
Note: Only replaced 2 instances to test, Node.get_children and TileMap.get_used_cells
Note: Will do a mass replace on later PRs of whathever I can find, but probably need
a tool to grep through doc.
Warning: Mono will break, needs to be fixed (and so do TypeScript and NativeScript, need to ask respective maintainers)
 2020-04-21 10:15:40 +02:00
Juan Linietsky
ae09b55a19 Exposed RenderingDevice to script API 
Also added an easier way to load native GLSL shaders.

Extras:

Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload.

Note:

The precommit hooks are broken because they don't seem to support enums from one class being used in another.
Feel free to fix this after merging this PR.
 2020-04-20 21:21:58 -03:00
Rémi Verschelde
94f0c62789 Fix more GCC -Wmaybe-uninitialized warnings 
Fixes #38005.
 2020-04-20 22:34:20 +02:00
Rémi Verschelde
9cf48b3e99
Merge pull request #38039 from akien-mga/docdata-skip-unexposed 
DocData: Skip unexposed classes
 2020-04-20 15:21:49 +02:00
Rémi Verschelde
0ef8bcac4d DocData: Skip unexposed classes 
Properly expose classes that we actually want accessible.
 2020-04-20 12:51:10 +02:00
Rémi Verschelde
b7b46093d8 doc: Sync classref with current source 
Add missing enum bindings.
 2020-04-20 11:48:00 +02:00
Rémi Verschelde
088c2a0870
Merge pull request #37947 from clayjohn/DOCS-rendering-update 
Update many docs with recent rendering changes
 2020-04-20 11:16:12 +02:00
qarmin
559bc3ca87 Change non-existent World to World3D 2020-04-18 11:00:51 +02:00
clayjohn
b50d954cb0 Update many docs with recent rendering changes 2020-04-17 09:47:59 -07:00
Rémi Verschelde
17304f1aae
Merge pull request #37949 from reduz/implement-global-shader-uniforms 
Implement global and per instance shader uniforms.
 2020-04-17 18:36:06 +02:00
Rémi Verschelde
cfda0e3770
Merge pull request #37953 from clayjohn/VULKAN-sky-sun-size 
Add light size to Sky Shaders
 2020-04-17 18:35:45 +02:00
clayjohn
7cd2ff309c Add light size to Sky Shaders 2020-04-17 09:32:24 -07:00
Rémi Verschelde
077dbdf246
Merge pull request #37964 from AndreaCatania/AndreaCatania-patch-2 
Activate Physics Process in SpringArm3D.
 2020-04-17 17:38:22 +02:00
Juan Linietsky
0e1c66d9fc Implement global and per instance shader uniforms. 
Adds two keywords to shader language for uniforms:
-'global'
-'instance'

This allows them to reference values outside the material.
 2020-04-17 12:35:41 -03:00
Andrea Catania
152303bf51
Activate Physics Process in SpringArm3D. 2020-04-17 16:22:24 +02:00
Rémi Verschelde
51d86c9112
Merge pull request #37047 from YeldhamDev/tabcontainer_doc_control_fix 
Fix incorrect TabContainer documentation for 'get_tab_control()'
 2020-04-16 12:36:42 +02:00
Rémi Verschelde
3c1218a39a
Merge pull request #37914 from clayjohn/VULKAN-decal-fix 
Fix texture check in decal setup
 2020-04-15 21:26:08 +02:00
Rémi Verschelde
9c80674aee
Merge pull request #37911 from madmiraal/fix-32876 
Run SpringArm3D's process within physics.
 2020-04-15 21:21:09 +02:00
clayjohn
61d86190e0 Fix texture check in decal setup 2020-04-15 12:06:02 -07:00
Marcel Admiraal
188bb6f867 Run SpringArm3D's process within physics. 2020-04-15 17:48:46 +01:00
Andrii Doroshenko (Xrayez)
430d1fd795 Bind Shape2D draw method 2020-04-15 18:17:21 +03:00
asheraryam
67c98cb438 Add "node_unselected" signal for GraphEdit 2020-04-15 18:06:21 +03:00
Rémi Verschelde
5b4ea6529a
Merge pull request #37896 from NutmegStudio/decal-enum-constant-fix 
Change DecalTexture bind from BIND_CONSTANT to BIND_ENUM_CONSTANT
 2020-04-15 12:02:19 +02:00
NutmegStudio
fa6d9e0c01 Change DecalTexture bind from BIND_CONSTANT to BIND_ENUM_CONSTANT 2020-04-15 15:00:48 +07:00
NutmegStudio
df863cf7ee Fix typo in light3d (Texture -> Texture2D) 2020-04-15 14:09:48 +07:00
Rémi Verschelde
9db525941f
Merge pull request #37887 from reduz/implement-projectors 
Add support for projectors in spot and omni lights.
 2020-04-14 23:03:32 +02:00
Juan Linietsky
6f293ed795 Add support for projectors in spot and omni lights. 2020-04-14 17:05:45 -03:00
Rémi Verschelde
59a8af2106
Merge pull request #37316 from nekomatata/physical-bone-settings 
Add PhysicalBone rotation, damping, axis lock & can sleep
 2020-04-14 18:33:43 +02:00
Rémi Verschelde
5e5103f460
Merge pull request #37861 from reduz/implement-decals 
Implement decals
 2020-04-14 17:13:20 +02:00
Juan Linietsky
5944eb6e7f Implement decals 
Also implemented decal atlas, so projectors and other stuff can be added.
Sidenote: Had to make RID hashable, so some unrelated includes changed
in order to include it in hashfuncs.h
 2020-04-14 11:13:34 -03:00
PouleyKetchoupp
5c1c03f29a Add PhysicalBone rotation, damping, axis lock & can sleep 2020-04-14 11:55:46 +02:00
janglee
5e64c146bc Fixed 0 width issue of rich text label 
Fixes #37746
 2020-04-13 14:59:38 +05:30
MickeMakaron
2edb59ec88 Handle huge offset values in Path2D and Path3D set_offset 2020-04-13 07:42:47 +02:00
Rémi Verschelde
06748a2b5f
Merge pull request #37749 from clayjohn/Vulkan-improved-ss 
Add vogel filter and settings to soft shadows
 2020-04-13 00:39:37 +02:00
Juan Linietsky
a57dc398db Implement MSAA 2020-04-12 15:33:57 -03:00
Juan Linietsky
16ae2cc1bf Add screen space AA option, with FXAA implementation. 2020-04-12 10:57:18 -03:00
clayjohn
621f6f09a8 Add proper quality settings to soft shadows 2020-04-10 23:09:17 -07:00
Zak Grumbles
a8de034f78 Fix OptionButton docs godotengine#36803 
* item_selected and item_focused docs incorrectly had 'id' as the parameter. Changed to
'index'.
* Fix parameter name in ADD_SIGNAL callin code.
 2020-04-10 20:35:40 -05:00
Rémi Verschelde
5566c5eb8d
Merge pull request #37517 from nekomatata/slider-grab-area-highlight 
Add style for highlighted Slider grab area
 2020-04-10 12:08:02 +02:00
Rémi Verschelde
9ab08f06c8
Merge pull request #37688 from theludovyc/dev 
Remove unused ofs variable in Tree::_draw
 2020-04-10 11:44:11 +02:00
Rémi Verschelde
c2f0d58c36
Merge pull request #37722 from reduz/implement-softshadows 
Support light size and soft shadows
 2020-04-10 10:24:57 +02:00
Juan Linietsky
6a730ffeab Support light size and soft shadows 2020-04-09 15:11:15 -03:00
Bastiaan Olij
afc8c6391c Renaming all ARVR nodes to XR 2020-04-09 15:33:01 +10:00
theludovyc
875c994109 Remove unused ofs variable 2020-04-08 20:00:43 +02:00
Juan Linietsky
26ecd924cc
Merge pull request #37678 from reduz/refactor-shadowmapping 
Refactored shadowmapping.
 2020-04-08 13:59:10 -03:00
Juan Linietsky
4ffc0d6b3f Refactored shadowmapping. 
- Made shadow bias size independent, so it will remain when changing light or camera size.
- Implemented normal offset bias, which greatly enhances quality.
- Added transmission to subsurface scattering
- Reimplemented shadow filter modes

Closes #17260
 2020-04-08 11:19:43 -03:00
theludovyc
7e2de76236 erase : if ( i < offset ) { continue;} in for loops 2020-04-08 11:14:46 +02:00
janglee
9c2c2ab2b0 Fixed underlines and striketrough not respecting visible character 2020-04-07 19:04:13 +05:30
Rémi Verschelde
026ec44b02
Merge pull request #37551 from KoBeWi/found_your_screen 
Add the missing argument in files_dropped signal
 2020-04-07 09:18:38 +02:00
Rémi Verschelde
3586f21519
Merge pull request #37591 from Anutrix/remove_reduntant_class 
Removed redundant class LineEditFileChooser from file_dialog
 2020-04-07 09:14:53 +02:00
Rémi Verschelde
2c6affe084
Merge pull request #37642 from dreamsComeTrue/rich-text-strike-fix 
Calculate strike-through y-position correctly (RichTexteLabel)
 2020-04-07 09:14:29 +02:00
Rémi Verschelde
5d82fa74d9
Merge pull request #37615 from guilhermefelipecgs/fix_37526 
Fix TextureRect::flip_* when used with atlas texture
 2020-04-07 09:10:44 +02:00
Dominik 'dreamsComeTrue' Jasiński
06a79f260c Calculate strike-through position correctly 
Fixes: #37637
 2020-04-06 22:26:58 +02:00
Rémi Verschelde
0d4d96d4b0
Merge pull request #37639 from qarmin/no_more_leaks 
Fixes leaks when running editor
 2020-04-06 21:25:36 +02:00
qarmin
5cbab81564 Fixes leaks when running editor 2020-04-06 20:07:08 +02:00
Guilherme Felipe
fb2d2dd5d0 Fix TextureRect::flip_* when used with atlas texture 
Fix #37526
 2020-04-06 08:36:36 -03:00
Yuri Roubinsky
e0a9879ce4
Merge pull request #37623 from Chaosus/vs_fix_keyword_name 
Adds warning to the uniform name in visual shader if its equal to keyword
 2020-04-06 14:15:20 +03:00
Yuri Roubinsky
8dfe6716ec Adds warning to the uniform name in visual shader if its equal to keyword 2020-04-06 12:29:50 +03:00
Rémi Verschelde
6b07c72d76
Merge pull request #37556 from KoBeWi/kill_get_index 
Remove Node.get_position_in_parent()
 2020-04-06 09:44:38 +02:00
Tomasz Chabora
c1023157eb Remove Node.get_position_in_parent() 2020-04-06 01:19:20 +02:00
Rémi Verschelde
de1d021574
Merge pull request #37397 from Eoin-ONeill-Yokai/Bug37081 
Correction to RichTextLabel Tabulation (Bug 37081)
 2020-04-05 10:07:47 +02:00
unknown
0fa7703565 Removed reduntant class LineEditFileChooser. 2020-04-05 02:50:32 +05:30
Rémi Verschelde
da887714be
Merge pull request #37570 from reduz/implement-sss 
Re-implement subsurface scattering.
 2020-04-04 17:14:48 +02:00
Juan Linietsky
c54f80d35c Re-implement subsurface scattering. 
The size settings are more "just works", with default scale and depth scale
values that don't need much tweaking.

Additionally, a "skin" mode was added so skin looks better.
EDIT: Cleaned up SSR filter shader a bit.
 2020-04-04 11:44:28 -03:00
unknown
4413c562d6 Fix file dialog not showing icons 2020-04-04 17:18:43 +05:30
unknown
7e4db6174d Remove redundant vbx variable in FileDialog 2020-04-04 14:58:57 +05:30
Michael Alexsander
a9e43ac73c Re-expose a simplified version of the stretch properties in SubViewport 2020-04-03 14:11:22 -03:00
Tomasz Chabora
16cbfcf0de Add the missing argument in files_dropped signal 2020-04-03 17:33:53 +02:00
Rémi Verschelde
59d44ee872
Merge pull request #37505 from YeldhamDev/viewcont_rename 
Rename ViewportContainer to SubViewportContainer
 2020-04-03 15:53:35 +02:00
Rémi Verschelde
b50387c8bf
Merge pull request #37521 from akien-mga/more-nullptr 
Replace more occurrences of NULL with nullptr
 2020-04-02 17:37:09 +02:00
Rémi Verschelde
6a38ce1b31
Merge pull request #37512 from reduz/implement-ssr 
Re-Added screen space reflection.
 2020-04-02 17:17:27 +02:00
Juan Linietsky
87c658b304 Re-Added screen space reflection. 2020-04-02 11:25:21 -03:00
PouleyKetchoupp
4c8173af0f Add style for highlighted Slider grab area 2020-04-02 15:05:46 +02:00
Rémi Verschelde
ea7b497065 Replace more occurrences of NULL with nullptr 2020-04-02 14:56:01 +02:00
lupoDharkael
95a1400a2a Replace NULL with nullptr 2020-04-02 13:38:00 +02:00
Rémi Verschelde
5f11e15571
Merge pull request #37504 from qarmin/out_of_bound_cursor 
Fix array out of bounds access caused by uninitialised variables
 2020-04-02 13:07:55 +02:00
Michael Alexsander
0c6851ae53 Rename ViewportContainer to SubViewportContainer 2020-04-01 16:11:44 -03:00
Rafał Mikrut
359bebd8c0 Fix out of bound array access caused by unassigned variable 2020-04-01 19:29:35 +02:00
Rémi Verschelde
2e84b7b916
Merge pull request #37443 from Leleat/master 
Fix PopupMenu's letter jumping on any InputEventKey (instead of just a press)
 2020-04-01 16:51:10 +02:00
Rémi Verschelde
96e654335a
Merge pull request #37481 from ThakeeNathees/bind-method-typo 
some typo in method binds fixed
 2020-04-01 12:57:26 +02:00
Thakee Nathees
cb53b1d88e some typo in method binds fixed 2020-04-01 14:01:18 +05:30
Rémi Verschelde
a30bfe5176
Merge pull request #35765 from clayjohn/master 
Add a method to retrieve active material from MeshInstance
 2020-03-31 18:03:11 +02:00
Rémi Verschelde
3a996faeed
Merge pull request #37442 from YeldhamDev/subviewport_register 
Register SubViewport class
 2020-03-31 16:29:41 +02:00
Rémi Verschelde
e5033d3952 doc: Sync classref with DisplayServer/Window changes 2020-03-31 11:56:58 +02:00
clayjohn
3362e81674 Add a method to retrieve active material from MeshInstance 2020-03-30 16:53:07 -07:00
Leleat
8a5660f3d1 fixed PopupMenus letterjumping on any InputEvent 2020-03-30 21:45:56 +02:00
Michael Alexsander
46a6751302 Register SubViewport class 2020-03-30 16:43:55 -03:00
Rémi Verschelde
f3c74afd28
Merge pull request #37436 from akien-mga/doc-node-renames 
doc: Update classref with node renames
 2020-03-30 20:32:11 +02:00
Rémi Verschelde
6fed21c7cb
Merge pull request #37356 from akien-mga/scons-enable-werror 
SCons: Treat all warnings as errors
 2020-03-30 20:30:54 +02:00
Rémi Verschelde
f097511b96 Fix another batch of -Wmaybe-uninitialized warnings 
And simplify code in CSGShape.
 2020-03-30 18:27:36 +02:00
Rémi Verschelde
eaaee63b62 doc: Update classref with node renames 
A few extra renames for classes which were missed in last week's PRs.
 2020-03-30 18:23:02 +02:00
Juan Linietsky
89e1263117 Move glow upscale quality to a global setting, for consistency 2020-03-30 10:46:03 -03:00
Rémi Verschelde
cd4e46ee65 SCons: Format buildsystem files with psf/black 
Configured for a max line length of 120 characters.

psf/black is very opinionated and purposely doesn't leave much room for
configuration. The output is mostly OK so that should be fine for us,
but some things worth noting:

- Manually wrapped strings will be reflowed, so by using a line length
  of 120 for the sake of preserving readability for our long command
  calls, it also means that some manually wrapped strings are back on
  the same line and should be manually merged again.

- Code generators using string concatenation extensively look awful,
  since black puts each operand on a single line. We need to refactor
  these generators to use more pythonic string formatting, for which
  many options are available (`%`, `format` or f-strings).

- CI checks and a pre-commit hook will be added to ensure that future
  buildsystem changes are well-formatted.
 2020-03-30 09:05:53 +02:00
Eoin O'Neill
2000e110a9 Correction to RichTextLabel Tabulation 
Correct backtrack assignment to prevent excessive tabulation. Worth
noting that tabulation is treated differently in RichTextLabel because
of custom user-asignable tab variable which creates problems with
dynamic fonts specifically.
 2020-03-29 14:33:17 -07:00
Rémi Verschelde
3f7fa93179
Merge pull request #37362 from reduz/audioserver-memory-cleanup 
Remove the audio memory allocator, use regular one instead.
 2020-03-28 15:49:48 +01:00
Rémi Verschelde
60d486acc8 Fix copyright headers for recently added files 2020-03-28 13:29:29 +01:00
Rémi Verschelde
0c320a6bf3 More server renames for consistency after #37361 2020-03-28 13:20:48 +01:00
dankan1890
06e8740184 Fixed missed occurrences in #37361 renamings. 2020-03-28 12:37:44 +01:00
Juan Linietsky
16245f2c29 Remove the audio memory allocator, use regular one instead. 2020-03-27 20:36:43 -03:00
Juan Linietsky
a6f3bc7c69 Renaming of servers for coherency. 
VisualServer -> RenderingServer
PhysicsServer -> PhysicsServer3D
Physics2DServer -> PhysicsServer2D
NavigationServer -> NavigationServer3D
Navigation2DServer -> NavigationServer2D

Also renamed corresponding files.
 2020-03-27 15:21:27 -03:00
Juan Linietsky
307b1b3a58
Merge pull request #37340 from reduz/rename-3d-nodes 
Make 2D and 3D node names more explicit
 2020-03-27 13:47:15 -03:00
Rémi Verschelde
d1acbbce7f Rename more 2D and 3D nodes to follow convention 
Rename editor plugins to match the new node names.
 2020-03-27 16:26:34 +01:00
Rémi Verschelde
92d25e62f7
Merge pull request #37353 from bruvzg/fix_editor_font 
Fix default editor font.
 2020-03-27 15:45:31 +01:00
Rémi Verschelde
c3a760c507 Fix build with disable_3d=yes, remove dependency on WorldEnvironment 2020-03-27 14:55:14 +01:00
Juan Linietsky
eaae4b6408 Renamed 2D and 3D nodes to make their types explicit 
Fixes #30736.
 2020-03-27 14:54:04 +01:00
Martin Liska
c554677c95
Fix various -Wmaybe-uninitialized (#37352). 2020-03-27 13:57:20 +01:00
bruvzg
21c2116744
Fix default editor font. 
Fix popup_centered_clamped definition typo.
 2020-03-27 14:13:01 +02:00
bruvzg
15a9f94346 Add macOS DisplayServer implementation. 
Change global menu to use Callable, add support for check items and submenus.
 2020-03-26 16:24:05 +01:00
Juan Linietsky
197cb4e771 Fixes to X11, still pretty broken 2020-03-26 15:50:00 +01:00
Mateo Kuruk Miccino
f387b9b4f4 Multiple changes to DisplayServerX11 
- Travis: Change x11 to linuxbsd
- SCons: Change x11 plataform to linuxbsd
- Plugins: Remove ; to avoid fallthrough warning
- DisplayServerX11: Implement set_icon
- DisplayServerX11: Fix X11 bug when a window was erased from windows
  map, all the changes from that erased windows are sending to the main
  window
- DisplayServerX11: Reorder create_window commands
- DisplayServerX11: Change every Size2 to Size2i and Rect2 to Rect2i
  where it belongs

+ More X11 fixes which have been integrated directly back into reduz's
original commits while rebasing the branch.
 2020-03-26 15:49:54 +01:00
Juan Linietsky
9a5d15a2dc Implemented drag and drop across windows, both OS and embedded. 2020-03-26 15:49:46 +01:00
Juan Linietsky
047e0b7de5 Reworked tooltips to use the popup system. 2020-03-26 15:49:45 +01:00
Juan Linietsky
b3080bc2f4 Popups have also been converted to windows 
Controls using the old modal API have been replaced to use popups.
 2020-03-26 15:49:44 +01:00
Juan Linietsky
c7b4dcae2f Open sub-windows as embedded if the OS does not support them 2020-03-26 15:49:43 +01:00
Juan Linietsky
441f1a5fe9 Popups are now windows also (broken!) 2020-03-26 15:49:42 +01:00
Juan Linietsky
4758057f20 Working multiple window support, including editor 2020-03-26 15:49:40 +01:00
Juan Linietsky
f51fdc6eef Support for transient windows 2020-03-26 15:49:39 +01:00
Juan Linietsky
8e6960a69e Refactored input, goes all via windows now. 
Also renamed Input to InputFilter because all it does is filter events.
 2020-03-26 15:49:39 +01:00
Juan Linietsky
9e08742de8 Added a Window node, and made it the scene root. 
Still a lot of work to do.
 2020-03-26 15:49:38 +01:00
Juan Linietsky
f8a79a97c7 Effective DisplayServer separation, rename X11 -> LinuxBSD 2020-03-26 15:49:34 +01:00
Juan Linietsky
4396e98834 Refactored Input, create DisplayServer and DisplayServerX11 2020-03-26 15:49:32 +01:00
Rémi Verschelde
4d5705eefa
Merge pull request #37274 from Janglee123/corrected-text-selection-in-color-picker 
Corrected text selection in color picker
 2020-03-26 09:29:18 +01:00
Rémi Verschelde
4507d0cd2b
Merge pull request #37279 from Waridley/fix_22016 
Fix volume interpolation in positional audio nodes
 2020-03-26 09:28:50 +01:00
Yuri Roubinsky
1358febfa1
Merge pull request #37287 from Chaosus/vs_sky 
Added sky shader mode to visual shaders
 2020-03-26 08:38:19 +03:00
Yuri Roubinsky
898b843718 Added sky shader mode to visual shaders 2020-03-25 19:04:42 +03:00
janglee
77b70aa79d Corrected text selection in color picker 
Fixes #35603
 2020-03-25 08:13:31 +00:00
Waridley
ff1fbd2bc5 Fix volume interpolation in positional audio nodes 
Fixes #22016
 2020-03-25 02:37:35 -05:00
Rémi Verschelde
5fede4a81c
Merge pull request #37272 from AndreaCatania/fix_ik_rot 
Fixed IK rotation issue
 2020-03-25 08:25:44 +01:00
Rémi Verschelde
4d7ab010db
Merge pull request #37281 from ThakeeNathees/fix-project-manager-don't-consume-Enter 
Fix: project manager don't consume Enter key #17620
 2020-03-25 08:13:04 +01:00
Thakee Nathees
b98153886f fix project manager don't consume Enter key #17620 2020-03-25 07:09:36 +05:30
Rémi Verschelde
e9ecb06cf3
Merge pull request #37280 from KoBeWi/n 
Make search in RichTextLabel case-insensitive
 2020-03-24 21:31:57 +01:00
Rémi Verschelde
b587f98fcc
Merge pull request #37176 from dkaste/line-edit-secret-fix-2 
Use LineEdit secret character width everywhere
 2020-03-24 21:27:44 +01:00
Tomasz Chabora
b3f83ac115 Make search in RichTextLabel case-insensitive 2020-03-24 20:03:09 +01:00
Rémi Verschelde
641c85a54f
Merge pull request #37268 from clayjohn/VULKAN-sky-color 
Replace subpass textures with color in sky shader
 2020-03-24 19:22:55 +01:00
clayjohn
61c67cd5e1 Replace subpass textures with color in sky shader 2020-03-24 10:11:00 -07:00
Andrea Catania
277696d6c5 Fixed IK rotation issue 2020-03-24 10:06:24 +01:00
Rémi Verschelde
9d24541597 Remove unused classes and stray headers 
Found by reviewing headers with 1 or less matching includes:
```
find -name thirdparty -prune -o -name "*.h" -exec basename {} \; | sort -u > headers
for header in $(cat headers); do echo "$header: "; rg -l "#include \"(.*/)?$header\"" | wc -l; done > list-includes
```
 2020-03-24 09:50:51 +01:00
Dominik 'dreamsComeTrue' Jasiński
f530c38174 Remove unreferenced & undocumented class Space2D 2020-03-24 01:30:28 +01:00
Rémi Verschelde
ed9a0d0484
Merge pull request #37179 from clayjohn/VULKAN-sky-shader 
Implement Sky Shaders
 2020-03-22 20:03:35 +01:00
clayjohn
61a74739ca Working sky shader implementation 2020-03-21 20:43:44 -07:00