godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
29,772 Commits 15 Branches 59 Tags 2.2 GiB
0ccd5ad3c5
Commit Graph

4347 Commits

Author SHA1 Message Date
Marcel Admiraal
d2b02a3d7b Remove do{ } while(0) wrapper around error macros. 
As pointed out by Faless, a do{ } while(0) wrapper around a continue or
break just ends the do{ } while(0) loop. The do{ } while(0) loop exists
to enable the macro to be used as a function which requires a semicolon.

The alternative approach is to use an if(1) { } else ((void)0) wrapper.
Since the macro already has an if(unlikely(m_cond)) { } this patch simply
adds the else ((void)0) to this if statement instead.

For consistency all the macros have been updated in the same way, and
trailing else warnings corrected. However, the wrappers around ERR_PRINT
and WARN_PRINT were removed, because they generated too many ambiguous
trailing else warnings. They are also single line macros so a wrapper is
not needed.
 2020-02-08 11:21:46 +01:00
Rémi Verschelde
da411d1625 Workaround WebM playback bug after AudioServer latency fixes 
af9bb0ea15 fixed AudioServer's
`get_output_delay()` (which used to always return 0) while renaming it
to `get_output_latency()`. It now returns the latency from the
AudioDriver, which can be non-0.

While this was a clear bugfix, it broke playback for WebM files without
audio track. It seems like the playback code, even though it queried
the output delay to calculate a time compensation, was designed to work
even though the delay value was actually bogus. Now that it's correct,
it's not working.

As a workaround we comment out uses of the output latency, restoring
the behavior of Godot 3.1.

This code should still be reviewed by someone more versed in video
playback and fixed to properly account for the non-0 driver latency.

Fixes #35760.
 2020-02-07 21:01:05 +01:00
Rémi Verschelde
4e2dbb1bc0 SCons: Split libmodules.a in folder-based libs 
This removes the need for the hacky split_libmodules logic on Windows,
since all libs are now of manageable size.
 2020-02-07 14:19:51 +01:00
Rémi Verschelde
f3726ee994 Use modules_enabled.gen.h to improve inter dependency checks 
- Fix build with gdscript module disabled. Fixes #31011.
- Remove unused `gdscript` compile option.
- Fix build with regex module disabled.
- Fix ImageLoaderSVG to forward declare thirdparty structs.
 2020-02-07 11:50:40 +01:00
Rémi Verschelde
b7297fb39c SCons: Generate header with info on which modules are enabled 
We already had `MODULE_*_ENABLED` defines but only in the modules
environment, and a few custom `*_ENABLED` defines in the main env
when we needed the information in core.

Now this is defined in a single header which can be included in the
files that need this information.
 2020-02-07 11:31:37 +01:00
unknown
4aac44f173 Remove the last ERR_PRINTS that was missed by #33391 2020-02-07 00:15:46 +05:30
Rémi Verschelde
d0e90cf07a
Merge pull request #35749 from Chaosus/vst_fix_constants 
Fix GlobalConstant/BasicTypeConstant return type in visual scripts
 2020-02-06 11:19:08 +01:00
Rémi Verschelde
7a094fdf40
Merge pull request #35912 from bruce965/fix-empty-audio-loop 
Fix empty audio infinite loop
 2020-02-05 16:36:10 +01:00
Marcel Admiraal
6d69cd40bd Add do..while(0) wrappers to macros without one. 
- Add do..while(0) wrapper to ERR_FAIL_NULL macros.
- Add do..while(0) wrapper to ERR_FAIL_COND macros.
- Add do..while(0) wrapper to ERR_CONTINUE macros.
- Add do..while(0) wrapper to ERR_BREAK macros.
- Add do..while(0) wrapper to CRASH_COND macros.
- Add do..while(0) wrapper to ERR_FAIL macros.
- Add do..while(0) wrapper to ERR_PRINT macros.
- Add do..while(0) wrapper to WARN_PRINT macros.
- Add do..while(0) wrapper to WARN_DEPRECATED macros.
- Add do..while(0) wrapper to CRASH_NOW macros.
 2020-02-05 11:19:12 +01:00
Marcel Admiraal
f0db13502a Remove duplicate WARN_PRINT macro. 2020-02-05 11:13:24 +01:00
Marcel Admiraal
5af3b4ca27 Remove duplicate ERR_PRINT macro. 2020-02-05 11:13:24 +01:00
Fabio Iotti
5ed4ad81c3 Fix empty audio infinite loop 2020-02-04 21:11:38 +00:00
Hugo Locurcio
61bf5bf73f
Improve error explanations related to NetworkedMultiplayerENet 2020-02-02 23:34:47 +01:00
Rémi Verschelde
0edcb8ed58
Merge pull request #35809 from clayjohn/DOCS-update-version 
Update docs to version 4.0
 2020-02-01 19:42:31 +01:00
Rémi Verschelde
739f583151
Merge pull request #35811 from touilleMan/remove-useless-pluginscript-get_rpc-rset_mode 
Remove useless pluginscript godot_pluginscript_script_desc.get_rpc/rset_mode fields
 2020-02-01 17:09:14 +01:00
Emmanuel Leblond
af8905fdf3
Use StringName in pluginscript's set/get_prop and add_global_constant 2020-02-01 05:16:48 +01:00
Emmanuel Leblond
491a6411d9
Remove useless pluginscript godot_pluginscript_script_desc.get_rpc/rset_mode fields 2020-02-01 05:04:47 +01:00
clayjohn
57e27683ba Update docs to version 4.0 2020-01-31 17:15:41 -08:00
Rémi Verschelde
8c3b14bed7
Merge pull request #35778 from touilleMan/remove-gdnative-wrapper 
Remove deprecated GDNative wrapper code
 2020-01-31 13:16:23 +01:00
Emmanuel Leblond
4c5205b550
Remove deprecated GDNative wrapper code 2020-01-31 11:20:25 +01:00
Rémi Verschelde
a5d5579105
Merge pull request #35761 from Calinou/opensimplexnoise-increase-max-octaves 
Increase the maximum number of octaves in OpenSimplexNoise to 9
 2020-01-31 10:38:48 +01:00
Rémi Verschelde
43f84445ba
Merge pull request #35340 from Calinou/optimize-editor-icon-generation 
Optimize the editor icon generation
 2020-01-31 10:15:01 +01:00
Hugo Locurcio
13622d40fc
Increase the maximum number of octaves in OpenSimplexNoise to 9 
An error message is now printed when trying to set the number of octaves
above the maximum allowed value.

The magic constant was also replaced with a define that can be
easily changed.

This closes #28714.
 2020-01-30 23:55:38 +01:00
Yuri Roubinsky
c19933eec4 Fix GlobalConstant/BasicTypeConstant return type in visual scripts 2020-01-30 20:20:33 +03:00
Fabián L
f595486076
Fixed GetNodeOrNull<T> 
GetNodeOrNull<T> was using GetNode instead of GetNodeOrNull
 2020-01-29 14:54:40 -03:00
Aaron Franke
d49e8af8de
Use uint/ulong for Color in C# 2020-01-29 12:53:13 -05:00
Francois Belair
f6968d5f17 Fix static functions loop using class' functions 
Besides being incorrect, it also caused a hard editor crash for purely
static classes or classes with more static functions than methods.
 2020-01-28 14:19:09 -05:00
Fabio Alessandrelli
a48d0b5eef Disable Nagle's algorithm for WebSocket TCP. 
This should greatly decrease latency for the most common use cases.
A new function WebSocketPeer::set_no_delay will allow to configure it if
so desired.
 2020-01-28 14:10:46 +01:00
Rémi Verschelde
f0f0f38d1a
Merge pull request #35516 from Faless/ws/fix_latency_32 
Lower WebSocket latency, fixes.
 2020-01-26 19:03:00 +01:00
Rémi Verschelde
4cee1cda5e
Merge pull request #35589 from akien-mga/doc-drop-category-property 
doc: Drop unused 'category' property from header
 2020-01-26 16:34:13 +01:00
Rémi Verschelde
09ced94dd4 doc: Do not expose Variant::NIL as a type in the class reference 
Fix signals Variant arguments incorrectly listed as Nil.

Fixes #12520.
 2020-01-26 16:08:11 +01:00
Rémi Verschelde
2d20fc39aa doc: Drop unused 'category' property from header 
We already removed it from the online docs with #35132.

Currently it can only be "Built-In Types" (Variant types) or "Core"
(everything else), which is of limited use.

We might also want to consider dropping it from `ClassDB` altogether
in Godot 4.0.
 2020-01-26 16:02:39 +01:00
Rémi Verschelde
fe26e53065
Merge pull request #35581 from akien-mga/doc-color-constants 
doc: Document named color constants
 2020-01-26 13:36:44 +01:00
Rémi Verschelde
cbdbfb00ca doc: Document named color constants 
Busywork but it's good for our completion rate :)
 2020-01-26 12:08:16 +01:00
Rémi Verschelde
bb6c0d3e8b doc: Complete documentation for VideoStreams 
Also quick clean up of the matching C++ files.
 2020-01-26 11:29:07 +01:00
Rémi Verschelde
139ff35e76
Merge pull request #35567 from Xrayez/doc-noise-null-data 
Mention that `NoiseTexture` uses threads internally
 2020-01-26 10:22:26 +01:00
clayjohn
c5700f7464 Complete various class references 2020-01-26 00:27:51 -08:00
Andrii Doroshenko (Xrayez)
5b1c6656d3 Mention that NoiseTexture uses threads internally 
Provided a snippet on how to properly retrieve the noise texture data
given that it's generated in a thread.
 2020-01-26 02:40:09 +02:00
Rémi Verschelde
c96f08dc86
Merge pull request #35527 from neikeq/issue-35259 
Mono/C#: Fix _update_exports possible crash with Reference types
 2020-01-24 21:51:57 +01:00
Rémi Verschelde
75ab07546b
Merge pull request #35524 from neikeq/issue-35496 
Fix C# preprocessor infinite loop and incorrect parsing of `#if!`
 2020-01-24 21:51:38 +01:00
Ignacio Etcheverry
966a126186 Mono/C#: Fix _update_exports possible crash with Reference types 
The code was attempting to dynamic cast the native instance to Reference after
the managed instance was disposed. As the managed instance acts as a Ref,
the native instance was freed during that disposal.
This made the dynamic cast fail and we attempted to memdelete a second time.

The fix is to make the dynamic cast before disposal.
 2020-01-24 18:28:40 +01:00
Ignacio Etcheverry
0604b1839d Fix C# preprocessor infinite loop and incorrect parsing of #if! 2020-01-24 17:53:17 +01:00
Fabio Alessandrelli
5bd9f14ad9 Lower WebSocket latency, fixes. 
WSLPeer now tries to flush packet queue after put_packet call.
WSLServer::listen correctly returns TCP_Server::listen return value.
 2020-01-24 14:50:53 +01:00
Hugo Locurcio
a002b93d86
Add explanations for errors related to Vector/Quat normalization 2020-01-24 14:19:23 +01:00
Rémi Verschelde
55f580b24a
Merge pull request #35491 from neikeq/issue-35450 
Mono/C#: Lighten up unsafe reference checks
 2020-01-23 23:06:58 +01:00
Ignacio Etcheverry
55b2e58a98 Mono/C#: Lighten up unsafe reference checks 
Because of the weird case with multi-threading and ResourceLoader, it can be the case that a resource is GCed while being referenced again in the main thread. In such cases, a new unsafe reference is created before the finalizer thread removes the previous one.
 2020-01-23 21:23:32 +01:00
Rémi Verschelde
cadf946863
Merge pull request #35478 from neikeq/issue-32260 
Mono/C#: Add setting to include I18N assemblies in the exported game
 2020-01-23 18:24:15 +01:00
Ignacio Etcheverry
59ec19d5a8 Mono/C#: Add setting to include I18N assemblies in the exported game 2020-01-23 17:47:09 +01:00
Rémi Verschelde
b75fff5a56
Merge pull request #35473 from neikeq/default-to-net47 
Mono/C#: Default to net47 for new projects
 2020-01-23 17:23:33 +01:00
Ignacio Roldán Etcheverry
8dc7f3960c
Merge pull request #35472 from neikeq/issue-35448 
Mono/C#: Add Basis.Slerp, update Quat.Xform and add some math checks
 2020-01-23 16:21:09 +01:00
Ignacio Etcheverry
82b0899e54 Mono/C#: Add Basis.Slerp, update Quat.Xform and add some math checks 2020-01-23 16:13:28 +01:00
Ignacio Etcheverry
d9ff5f7fc2 Mono/C#: Default to net47 for new projects 2020-01-23 15:57:47 +01:00
clayjohn
6b66957b85 Finish documenting CSG* and *probes 2020-01-23 13:54:17 +01:00
Rémi Verschelde
ba177ccaec doc: Misc updates for AnimationNode* and others 
- Add some missing descriptions.
- Add links to tutorials for ARVR and AnimationTree.
- Style fixes.
- Engine changes:
  * Make `AnimationNodeTransition.input_<number>` properties internal
    so that they don't appear in the docs. They still appear in the
    inspector based on the actual number of inputs requested.
  * Drop unimplemented `CPUParticles.flatness`. It's only used for 3D
    particles in `ParticlesMaterial`, and thus only relevant for
    `CPUParticles3D`.
 2020-01-23 12:37:33 +01:00
Rémi Verschelde
36e11d1c34
Merge pull request #35412 from DaividFrank/check_overriding_self 
Disabled re-assigning 'self'
 2020-01-22 20:47:52 +01:00
DaividFrank
badabdf8b9 GDScript: Added checks in assign operations to disable re-assigning 'self' 2020-01-22 19:00:54 +02:00
Rémi Verschelde
4faaf6089a Remove unused #if 0'ed code 2020-01-21 21:41:54 +01:00
Rémi Verschelde
79aaafc686
Merge pull request #35408 from Faless/ws/fix_packet_count 
Fix MultiplayerAPI crash when peer implementation misbehave.
 2020-01-21 21:06:11 +01:00
Fabio Alessandrelli
50f1b035b8 Fix MultiplayerAPI crash when peer impl misbehave. 
Also fix WebSocketMultiplayer::get_available_packet_count() return value
when peer is not configured to use the multiplayer API.
 2020-01-21 20:46:32 +01:00
Ignacio Roldán Etcheverry
24960e2254
Merge pull request #35407 from neikeq/issue-27285 
Add dummy preprocessor for the C# script class parser
 2020-01-21 20:39:23 +01:00
Ignacio Etcheverry
d53c15b12c Make script class parser errors to not abort the build 
As our script class parser is error prone, we should not impede the build from continuing because of a parsing error.
This should be reverted in the future once we switch to Roslyn.
 2020-01-21 20:07:26 +01:00
Ignacio Etcheverry
378fc592b1 Add dummy preprocessor for the C# script class parser 
No attempts are made at conditional compilation. The main if branch is always assumed to be true.
 2020-01-21 19:57:38 +01:00
Rémi Verschelde
41b21dee01 Bullet: Prevent potential division by zero 
Fixes #33715.
 2020-01-21 00:20:57 +01:00
Ignacio Etcheverry
e4330e33e6 Mono/C#: Fix error when parsing nested generics 
Also fixed the editor not including the parse error message in the error.
 2020-01-20 19:08:08 +01:00
Hugo Locurcio
9e3393a624
Optimize the editor icon generation 
Icons are no longer upsampled when using an integer editor scale.
This makes some icons slightly less crisp, but the icons themselves
can be adjusted to mitigate this. When using a non-integer editor
scale setting, upsampling is kept as it improves crispness in a
far more visible manner.

When upsampling is disabled, this speeds up the theme generation
by about 100 ms on average, making the project manager and editor
start slightly faster. This also speeds up switching between themes.
 2020-01-20 00:31:04 +01:00
Rémi Verschelde
f70438ac45
Merge pull request #35270 from ChibiDenDen/fix_extends_sub_subclass 
Fix subclass finding in extend statement for sub-sub classes
 2020-01-19 23:18:40 +01:00
Ignacio Etcheverry
a6105c8ea0 Fix ClassDB API portability with some android and editor classes 
- `EditorNavigationMeshGenerator` was being registered as part of the Core API,
even after d3f48f88bb. We must make sure to
set Editor as the current ClassDB API type before creating an instance.

- The `VisualScriptEngineSingleton.constant` property has a property hint string
that's different between tools and non-tools builds. This commit makes the
hint string to no longer be set in `_bind_methods`, and to instead set it in
`_validate_property`. This way it's ignored when calculating the API hash.

- `JavaClassWrapper` is now registered in ClassDB on all platforms,
using a dummy implementation on platforms other than Android.
This fixes API portability between Android and other platforms.

- Updated `--class-db-json` command to ignore non-virtual methods that start
with an underscore (see: 4be87c6016).
 2020-01-19 20:15:13 +01:00
Dani Frank
8f5e424c66 Fix subclass finding in extend statement for sub-sub classes 
lookup was always done on top level script instead of advancing to subclass each time.
this commit changes the lookup to always be at last found subclass
 2020-01-18 11:55:27 +02:00
Rémi Verschelde
ba7aca4199
Merge pull request #35224 from ChibiDenDen/constant_lookup_through_subclass_instance 
Fix constant access in base class through subclass instance
 2020-01-17 06:58:00 +01:00
ChibiDenDen
9ffa9a6bac Fix constant access in base class through subclass instance 
Fixes as issue where a subclass calls a base class method that tries to access a constant from the script.
The original code went through every ower class, and for each owner, went through its inheritance tree.
This seems like the wrong order, the modified code goes to each base class, and for each base class goes through the owner tree.
This is more in line with what the parser does, as the current impelemtation allows an access that the parser does not support.
This change should not negatively affect existing code due to the way the parser works
 2020-01-17 00:12:45 +02:00
Rémi Verschelde
4c99301d69
Merge pull request #34789 from Faless/enet/disconnect_relay 
ENet optional server_relay when disconnecting peer
 2020-01-16 23:12:40 +01:00
Rémi Verschelde
8b0e2a409b
Merge pull request #35218 from bojidar-bg/26691-parse-error-errors 
Fix errors raised when showing parse errors in the editor
 2020-01-16 22:32:49 +01:00
Ignacio Roldán Etcheverry
1191d26ddc
Merge pull request #35208 from neikeq/mono-lazy-thread-attach 
Mono/C#: Script interface calls now attach the current thread
 2020-01-16 21:27:08 +01:00
Bojidar Marinov
da5b138e64
Fix errors raised when showing parse errors in the editor 
Fixes #26691
 2020-01-16 22:12:24 +02:00
Ignacio Etcheverry
d68b9c20d6 Mono/C#: Script interface calls now attach the current thread 
Added guards to all C# script interface calls to attach the current thread
for the current scope if the thread is not already attached.
This is far from ideal, as attaching the thread is not cheap and all managed
thread local storage is lost when we detach the thread at the end of the calls.
However, it's the best we can do for now to avoid crashing
when an unattached thread tries to interact with C# code.
 2020-01-16 17:47:36 +01:00
Rémi Verschelde
f2aa99a8e2
Merge pull request #35201 from bojidar-bg/27582-gdfunction-validate-instance 
Validate instances of objects before trying to check their type in GDScript
 2020-01-16 15:57:44 +01:00
Rémi Verschelde
4998983bd5
Merge pull request #35199 from dalexeev/master 
Fix function arguments hint format in GDScript editor
 2020-01-16 15:53:28 +01:00
Rémi Verschelde
df13245408
Merge pull request #35203 from timothyqiu/image-loader-null 
Adds null check before using image loader
 2020-01-16 15:51:46 +01:00
Rémi Verschelde
cd7b51b943
Merge pull request #35102 from ChibiDenDen/reuse_orphaned_subclass 
#34161: Keep a weak reference to orphan subclasses to reuse on class reload
 2020-01-16 15:49:52 +01:00
Bojidar Marinov
dc4455d819
Validate instances of objects before trying to check their type in GDScript 
Fixes #27582
 2020-01-16 16:39:59 +02:00
Rémi Verschelde
9986f3804c
Merge pull request #35198 from bojidar-bg/27575-poolarrayexport-default 
Fix slight problems related to default values of exported typed arrays
 2020-01-16 14:58:06 +01:00
Haoyu Qiu
92b36d4706 Adds NULL check before using image loader 2020-01-16 21:49:23 +08:00
Bojidar Marinov
19ce2d5159
Fix slight problems related to default values of exported typed arrays 2020-01-16 14:50:29 +02:00
Danil Alexeev
45b510b332 Fix function arguments hint format in GDScript editor 
for consistency with the format of the documentation:
"type func_name(arg1: type, arg2: type)"
 2020-01-16 15:41:02 +03:00
Rémi Verschelde
1de633205f Validate input in (CPU)Particles set_emission_shape() 
Fixes #29777.

Co-authored-by: Cameron Reikes <cameronreikes@gmail.com>
 2020-01-16 11:08:51 +01:00
Ignacio Etcheverry
1a40f250bd Mono/C#: Fix false positive in unsafe reference checks 2020-01-15 23:46:42 +01:00
ChibiDenDen
86aa12e806 Keep a weak reference to orphan subclasses to reuse on class reload 2020-01-15 22:54:01 +02:00
Rémi Verschelde
5f99e3396f
Merge pull request #35156 from MadEqua/fix-grid-map 
Fix GridMap getter of baked meshes.
 2020-01-15 17:55:52 +01:00
Bruno Lourenço
da9eede933 Fix GridMap getter of baked meshes. 2020-01-15 14:30:17 +00:00
Rémi Verschelde
9b8d1383ce Mono: Fix parsing assembly names as UTF-8 
Fixes #27185.
 2020-01-15 11:51:03 +01:00
Houkime
e1a0ce5af9 Prevent GDScript language server from listening to external hosts by default 
* Add bind_ip property to WebSocketServer defaulting to "*" (listen to everyone)
* Set default for GDscript Language Server to listen only to localhost

Fixes potential security issue with GDScript language server being exposed to the
broad net by default.
Since it is the server which primary usage is to provide utility to the local
editor there is no need to expose it.
 2020-01-15 00:29:59 +00:00
Rémi Verschelde
40f0649e5b Fix typos with codespell 
Using codespell 1.16.0.

See ab3bccdb78 for procedure.
 2020-01-15 00:49:52 +01:00
Rémi Verschelde
3d88a7bb22
Merge pull request #35122 from ChibiDenDen/fully_qualified_name_gdscript 
Add fully_qualified_name for GDScript class
 2020-01-14 18:54:52 +01:00
Rémi Verschelde
1bafd2d2c8
Merge pull request #35120 from Faless/docs/html5_restrictions 
Update documentation to reflect HTML5 limitations.
 2020-01-14 17:23:54 +01:00
Dani Frank
d6f10cd08e Add fully_qualified_name for GDScript class 2020-01-14 17:33:33 +02:00
Fabio Alessandrelli
aa744aee7d Update documentation to reflect HTML5 limitations. 2020-01-14 15:42:47 +01:00
Haoyu Qiu
ddde73cc62 Makes adding port in Visual Script nodes deferred 2020-01-14 21:03:09 +08:00
Rémi Verschelde
f06372cb73
Merge pull request #35097 from neikeq/issue-34954 
Mono/C#: Fix _update_exports() leaking temporary Object/Node instances
 2020-01-13 22:01:11 +01:00
Ignacio Etcheverry
a6a5ef0fd6 Mono/C#: Add error checks to detect possible Reference leaks 2020-01-13 21:00:07 +01:00
Ignacio Etcheverry
ea737db43c Mono/C#: Fix _update_exports() leaking temporary Object/Node instances 2020-01-13 20:58:46 +01:00
George Marques
1d129f9bec
GDScript: Check function arguments on release too 
Needed because otherwise the certain type operations (such as type
casting) used as a function argument might become unresolved on release,
causing a compilation failure.

Fix #28680
 2020-01-13 15:58:53 -03:00
Rémi Verschelde
c7b701dfd2 Image: Include S3TC compression via Squish in non-tools build 
We already build Squish in templates build for S3TC decompression,
so we can as well expose the compression feature.

Fixes #25640.
 2020-01-13 15:58:49 +01:00
Rémi Verschelde
e32d232053
Merge pull request #35076 from vnen/gdscript-type-match-assign 
Type match on assignment only if operators have type
 2020-01-13 13:14:57 +01:00
George Marques
e6060706ca
GDScript: Type match on assignment only if operators have type 
This ensures that a value without type won't be wrongly assigned to a
typed variable when the types mismatch.
 2020-01-13 08:51:24 -03:00
Geequlim
d5e1890c85 Fix infinite loop error in document link parsing 2020-01-13 19:23:29 +08:00
geequlim
e804eebfe5 Remove completion triggers for ',' and '(' which may conflict with signature helper 2020-01-11 23:51:25 +08:00
geequlim
d901d5993b Allow enable/disable threading for LSP server 
Restart LSP server when configurations change without restart the editor
 2020-01-11 23:50:32 +08:00
Rémi Verschelde
0b185278f3
Merge pull request #34225 from madmiraal/fix-34210 
Add check for zero length motion at beginning of each sweep test loop in SpaceBullet::test_body_motion
 2020-01-11 11:57:41 +01:00
Rémi Verschelde
0ab1726b43
Merge pull request #35003 from vnen/gdscript-forbid-script-as-member 
GDScript: Forbid using "script" as member name
 2020-01-11 00:03:55 +01:00
George Marques
4c20d9407d
GDScript: Forbid using "script" as member name 
Avoids the user breaking things by creating a "script" variable with
something else, effectively overwriting the "script" slot on Object.
 2020-01-10 19:43:33 -03:00
K. S. Ernest (iFire) Lee
dfb713bce6 Use cycle and loop hint flags in FBX. 2020-01-10 08:23:24 -08:00
Rémi Verschelde
673f4fabd8
Merge pull request #34962 from KoBeWi/randocs 
Complete documentation of various classes
 2020-01-10 14:41:30 +01:00
Tomasz Chabora
508e624b87 Complete documentation of various classes 2020-01-10 14:14:07 +01:00
toasteater
677e72d2f6 Expose instance_from_id to GDNative 
This function is available to GDScript but not to GDNative. When exposed, it
allows building more ergonomic safe abstractions over the GDNative APIs, and
covers the use cases of the original PR.

Close #28478. Supersedes #28791.

Co-authored-by: Markus Ewald <cygon@nuclex.org>
 2020-01-10 11:59:37 +00:00
Rémi Verschelde
0d2993659b
Merge pull request #34978 from GodotExplorer/lsp-fix-bracket-completion 
LSP: Fix bracket completion for functions with one argument
 2020-01-10 07:58:26 +01:00
Rémi Verschelde
09aa12a0dd
Merge pull request #34958 from vnen/gdscript-is-check-valid-instance 
GDScript: Validate object instance on `is` operation
 2020-01-10 07:40:56 +01:00
Geequlim
6190d42825 LSP: Fix bracket completion for functions with one argument 2020-01-10 14:23:01 +08:00
George Marques
76678b2609
GDScript: Fix type name on error message for function parameters 2020-01-09 15:50:06 -03:00
George Marques
1aef8bfeb1
GDScript: Fix resolution of default parameter values 
Fix #26556
 2020-01-09 15:42:31 -03:00
George Marques
3718f8f592
GDScript: Validate object instance on is operation 
Avoids crashes on debug mode. Instead it now breaks the execution and
show the error in-editor. Will still crash on release.

Also add a similar check to Marshalls to ensure the debugger doesn't
crash when trying to serialize the invalid instance.
 2020-01-09 13:59:33 -03:00
George Marques
cc9ca9eb34
GDScript: Don't re-evaluate index on assigment with operation 
Pass the calculated index from the stack and use the same to get and set
the value. This avoids a function with side effects being evaluated
twice when using indexing in an assignment with operation statement
(e.g. a[function()] += 1).
 2020-01-09 10:43:29 -03:00
Rémi Verschelde
e97e951741
Merge pull request #34948 from vnen/gdscript-copy-constructor 
GDScript: Allow copy constructor for built-in types
 2020-01-09 13:42:10 +01:00
George Marques
41ed905c1a
GDScript: Allow copy constructor for built-in types 
Those are implicitly defined in Variant.
 2020-01-09 09:03:09 -03:00
George Marques
7d4fc79eb3
Add GDScript warning for standalone expression 
This makes the error message clearer as it might be used to call
functions with side effects.
 2020-01-09 08:30:14 -03:00
George Marques
e7b7dc57fc
GDScript: set assign operation on local var made by match 
This is needed in a all local variables with assigment to properly set
the typed operation.

Fix #34928
 2020-01-08 19:28:07 -03:00
Rémi Verschelde
b9a553f99d
Merge pull request #34921 from akien-mga/bullet-2.89 
bullet: Sync with upstream 2.89
 2020-01-08 21:17:33 +01:00
Rémi Verschelde
5a8107f70a
Merge pull request #34920 from GodotExplorer/lsp-signatureHelper 
GDScript LSP: Implement signatureHelp
 2020-01-08 18:29:39 +01:00
Rémi Verschelde
c456d87ee6
Merge pull request #34918 from vnen/gdscript-assign-op 
GDScript: enable type checks on release mode
 2020-01-08 18:22:38 +01:00
Rémi Verschelde
29e07dfa4e bullet: Sync with upstream 2.89 
This allows distro unbundling again for distros that ship Bullet 2.89+.
 2020-01-08 18:05:43 +01:00
geequlim
d35c018a7a GDScript LSP: Implement signatureHelp 
Enable smart resolve default to true as it is required for script symbol lookup
 2020-01-09 00:57:54 +08:00
George Marques
d26414f9fe
GDScript: enable type checks on release mode 
Also make builtin GDScript functions report return type as Variant in
release so type is converted when needed.
 2020-01-08 12:38:18 -03:00
George Marques
899f7999b4
GDScript: properly set type of local variable initialization 
Properly sets the type of the identifier for the local variable
that is stored in the assignment operation. This makes sure that the
compiler is aware of typing for local variables when they are
initialized with the declaration.
 2020-01-08 11:36:50 -03:00
Rémi Verschelde
cd408c5256
Merge pull request #34886 from JFonS/fix_32699 
Make NoiseTexture threading more robust
 2020-01-07 12:46:43 +01:00
JFonS
4e10c62024 Make NoiseTexture threading more robust 
Fixes crash when a NoiseTexture was freed before the generation thread finished.
 2020-01-07 11:35:34 +01:00
geequlim
eb5861f9f1 GDScript LSP: Implement goto declaration 2020-01-04 20:02:26 +08:00
Rémi Verschelde
34c71157f0
Merge pull request #34795 from dankan1890/mono_cs_icon 
[Mono]: the C# script icon is now visible in the editor.
 2020-01-04 00:03:38 +01:00
dankan1890
51c601d2e3 [Mono]: the C# script icon is now visible in the editor. 2020-01-03 22:49:22 +01:00
Rémi Verschelde
db1a01501b
Merge pull request #34790 from clayjohn/ETC-support-alpha 
Add support for Lum-alpha textures to ETC fallback
 2020-01-03 22:48:22 +01:00
Fabio Alessandrelli
411f08c506 Fix ENet max clients highest value. 
Was 4096, while actually it's 4095. Fixed now in both docs and
`create_server` check.
 2020-01-03 20:18:33 +01:00
clayjohn
cd21200944 Add support for Lum-alpha textures to ETC fallback 2020-01-03 11:10:44 -08:00
Fabio Alessandrelli
ce47d5af77 ENet optional server_relay when disconnecting peer 
Was not correctly enforced before, always notifying other peers of the
disconnection.
 2020-01-03 20:09:49 +01:00
Rémi Verschelde
399e53e8c3
Merge pull request #34784 from neikeq/fix-hintpath-godottools 
Mono/C#: Fix wrong HintPath for package in GodotTools
 2020-01-03 16:34:08 +01:00
Ignacio Etcheverry
9ce0ddcf0d Mono/C#: Fix wrong HintPath for package in GodotTools 2020-01-03 15:53:16 +01:00
Rémi Verschelde
09b4327805
Merge pull request #34452 from aaronfranke/color-arith 
[Mono] Color arithmetic operators
 2020-01-03 15:07:17 +01:00
Rémi Verschelde
136846a6ec
Merge pull request #34772 from clayjohn/ETC-support-alpha 
Fallback to RGBA4444 for textures with alpha set to ETC compression
 2020-01-03 14:29:19 +01:00
Aaron Franke
68ba2588b8
[Mono] Color arithmetic operators 2020-01-03 06:00:14 -05:00
Rémi Verschelde
9d3424f61d
Merge pull request #34688 from sheepandshepherd/gdnative_class_ptr 
Expose is_class_ptr to GDNative for dynamic casts
 2020-01-03 11:32:01 +01:00
clayjohn
7a9fc69a16 Fallback to RGBA4444 for textures with alpha set to ETC compression 2020-01-02 21:37:48 -08:00
sheepandshepherd
3056c4bd5a Expose cast_to to GDNative for dynamic casts 2020-01-03 04:27:13 +01:00
Aaron Franke
0b3f1cc70a
[Mono] Make Sign methods consistent with GDScript and System.Math 2020-01-02 16:41:41 -05:00
Rémi Verschelde
d84cf797a2
Merge pull request #34758 from neikeq/mono-bindings-void-vararg 
Mono/C#: Fix bindings generator with void vararg methods
 2020-01-02 18:34:38 +01:00
Rémi Verschelde
1fe8dedf33
Merge pull request #34756 from bojidar-bg/34689-export-line-break 
Allow the usage of newlines in export hints
 2020-01-02 18:20:28 +01:00
Ignacio Etcheverry
c1ff3ef9e8 Mono/C#: Fix comment generation for non-constant param default 
- Generate the comment for the param, even if the method has no description.
- Generate the comment outside the <summary> element.
 2020-01-02 18:10:02 +01:00
Ignacio Etcheverry
f3aa793ba3 Mono/C#: Fix bindings generator with void vararg methods 
Commit 4d727f1ee6 made it possible for vararg
methods to return void. This broke the C# bindings generator which was
assuming in one place that vararg methods always return Variant.
 2020-01-02 18:02:48 +01:00
Bojidar Marinov
b93b7aca74
Allow the usage of newlines in export hints 
Fixes #34689
 2020-01-02 18:03:11 +02:00
Ignacio Etcheverry
844a8d215b Mono/C#: Make 'GD.Print' and its variants fallback to 'ToString()' 
Up until now, 'GD.Print' would convert parameters first to
Variant and only then to String. This meant parameters that cannot be
converted to Variant would be printed as "Null".
This commit makes 'GD.Print' fallback to 'System.Object.ToString()'
if the parameter could not be converted to Variant.
The same applies to all 'GD.Print' variants:
'GD.PrintS', 'GD.PrintT', 'GD.PrintErr' and 'GD.PrintRaw'.
 2020-01-02 13:54:20 +01:00
Ignacio Etcheverry
ea75ea50d2 Mono/C#: Fix GD.PrintErr now showing in the Output panel 2020-01-02 13:13:22 +01:00
Rémi Verschelde
5aa96b72c7
Merge pull request #34706 from KoBeWi/grindput 
Don't handle Gridmap input when have no effect
 2020-01-01 11:35:39 +01:00
Rémi Verschelde
a7f49ac9a1 Update copyright statements to 2020 
Happy new year to the wonderful Godot community!

We're starting a new decade with a well-established, non-profit, free
and open source game engine, and tons of further improvements in the
pipeline from hundreds of contributors.

Godot will keep getting better, and we're looking forward to all the
games that the community will keep developing and releasing with it.
 2020-01-01 11:16:22 +01:00
Ignacio Roldán Etcheverry
7fddf5eb7c
Merge pull request #34699 from van800/godot-guid 
Custom property for Godot generated project
 2019-12-31 20:28:14 +01:00
Tomasz Chabora
bf143c05d2 Don't handle Gridmap input when have no effect 2019-12-30 23:35:43 +01:00
Rémi Verschelde
e37ad996a1
Merge pull request #34625 from timothyqiu/i18n 
Makes more editor strings translatable
 2019-12-30 17:28:11 +01:00
Rémi Verschelde
edf2ed5e50
Merge pull request #34582 from timothyqiu/forward-decl 
Cleans up headers included in editor_node.h
 2019-12-30 16:28:47 +01:00
Ivan Shakhov
af2e6e12d1 add custom property to csproj, which identifies that project is generated by Godot 2019-12-30 16:16:47 +01:00
Haoyu Qiu
8cf941a8cb Makes more editor strings translatable 
* Title of Sprite Editor convert preview dialogs
* Title of UV Channel Debug dialog
* Various editor warnings
* GridMap popup menu item "Paste Selects"
* Tileset editor shape button texts
* MeshLibrary update confirmation text
 2019-12-30 10:36:31 +08:00
Dan Kramer
1b26f2c505 Fix msbuild target argument 2019-12-29 17:03:21 -05:00
Ignacio Etcheverry
86274b9fc9 Mono/C#: Re-structure API solution and GodotTools post-build target 
Previously we had a placeholder solution called 'Managed' to benefit from
tooling while editing the a part of the C# API.
Later the bindings generator would create the final 'GodotSharp' solution
including these C# files as well as the auto-generated C# API.
Now we replaced the 'Managed' solution with the final 'GodotSharp' solution
which is no longer auto-generated, and the bindings generator only takes
care of the auto-generated C# API.
This has the following benefits:
- It's less confusing as there will no longer be two versions of the same file
(the original and a generated copy of it). Now there's only one.
- We no longer need placeholder for auto-generated API classes, like Node or
Resource. We used them for benefiting from tooling. Now we can just use the
auto-generated API itself.
- Simplifies the build system and bindings generator. Removed lot of code
that is not needed anymore.

Also added a post-build target to the GodotTools project to copy the output to
the data dir. This makes it easy to iterate when doing changes to GodotTools,
as SCons doesn't have to be executed anymore just to copy these new files.
 2019-12-28 20:48:55 +01:00
Ignacio Roldán Etcheverry
318c693516
Merge pull request #34595 from van800/mac_rider 
Fix search for Rider path on Mac
 2019-12-26 02:16:55 +01:00
Ignacio Roldán Etcheverry
f90e8c41a2
Merge pull request #34604 from neikeq/issue-27674 
Mono/C#: Fix memory leak with new Reference instances created from C#
 2019-12-25 20:47:07 +01:00
Ignacio Etcheverry
0ef635c0e3 Mono/C#: Fix memory leak with new Reference instances created from C# 2019-12-25 19:33:59 +01:00
Ivan.Shakhov
682dd04b2d fix Rider path on Mac 2019-12-25 00:14:31 +01:00
Haoyu Qiu
078c0d75f2 Cleans up headers included in editor_node.h 2019-12-24 21:46:05 +08:00
Rémi Verschelde
e4ecfe90f9
Merge pull request #34515 from Faless/ws/closing_ws 
WSLPeer now prevents receiving data after close.
 2019-12-22 12:32:52 +01:00
Dan Kramer
097d1c9383 add suggested fix 2019-12-21 13:26:29 -05:00
Rémi Verschelde
a10449bbbc
Merge pull request #34514 from neikeq/remove-dep-on-mono-posix 
Mono/C#: Remove GodotTools dependency on the Mono.Posix assembly
 2019-12-21 17:07:18 +01:00
Fabio Alessandrelli
9afdb9dcd3 WSLPeer now prevents receiving data after close. 
Used to spit error and report empty packets when connection was still
half-closed (waiting for confirmation from other end).
 2019-12-21 16:38:36 +01:00
Ignacio Etcheverry
5a3ccf4f14 Mono/C#: Remove GodotTools dependency on the Mono.Posix assembly 
MSBuild on Windows uses the system .NET Framework BCL instead of Mono's. Because
of this, it may not be able to find the Mono.Posix assembly, so it's better
not to depend on it. We needed Mono.Posix to call Syscall.access, so we can
replace this with an internal call that does the same in C++.
 2019-12-21 15:55:45 +01:00
Haoyu Qiu
0693718164 Makes more editor strings translatable 
* "Add" button text in Groups Editor
* "Receiver Method" in Connect Signal Dialog
* "Play Mode" in Animation State Machine Editor
* "Mesh Library" button text in Mesh Library editor plugin
* Compose Array node button texts in Visual Script
* Various button texts in TileSet Editor
* Various Run Script errors
 2019-12-21 20:58:17 +08:00
Rémi Verschelde
2a4c528d06
Merge pull request #34465 from neikeq/no-hardcode-debugger-wait 
Mono/C#: Remove hard-coded debugger wait at initialization
 2019-12-19 21:27:59 +01:00
Ignacio Etcheverry
f3c6c63b94 Mono/C#: Remove hard-coded debugger wait at initialization 
Up until now debug builds would always wait up to 500 ms during initialization
to give time for debuggers to attach to the game.
We no longer want this as it increases startup time unnecesarily.
The way forward is to setup the debugger agent as client instead of server.
This way it's the game that connect to the debugger, not the other way around.
If server mode is still desired, suspend=y can be used to indefinitely wait
for the debugger to attach. This all can be specified with the environment
variable 'GODOT_MONO_DEBUGGER_AGENT' when launching the game.
 2019-12-19 17:07:20 +01:00
Ignacio Etcheverry
98dc07f25f Mono/C#: Fix Variant -> MonoString* when type is Variant:NIL 
`Variant::operator String()` returns "Null" if the type is `Variant:NIL`.
We must consider that and return a null `MonoString*` instead when marshalling.
This was also causing a "Null" error to be displayed when exporting a game
because null string members would be set to "Null" during hot-reload.
 2019-12-19 16:51:32 +01:00
Rémi Verschelde
1c6b9bfdff Mono: Copy native and btls libs on macOS 2019-12-18 08:39:37 +01:00
Ignacio Etcheverry
20d7013c60 Mono/C#: Fix project export and fix FindLast/GetFile regression 
d09193b08a introduced a regression in
StringExtensions.FindLast. StringExtensions.GetFile was also affected as it
relies on FindLast. This in turn broke the project exporter as it uses GetFile.
The cause of the regression is that now FindLast is calling LastIndexOf
with 'startIndex: 0'. This should be 'startIndex: str.Length - 1' instead.

Also fixed another regression in the project exporter:
de7c2ad21b moved 'GodotTools/GodotSharpExport.cs'
to 'GodotTools/Export/ExportPlugin.cs' and in doing so accidently reverted
the changes from commit e439581198.
 2019-12-17 13:06:41 +01:00
Haoyu Qiu
9adeec789c Fixes size of create function dialog 2019-12-17 09:04:30 +08:00
Rémi Verschelde
c3ea4ea9b7
Merge pull request #34382 from van800/profiler 
Allow attaching any external profiler, including JetBrains dotTrace
 2019-12-16 22:00:36 +01:00
Ivan Shakhov
7c64779516 Allow attaching any external profiler, including JetBrains dotTrace 2019-12-16 20:34:30 +01:00
Rémi Verschelde
a866028a7a Mono: Enable threads suspend workaround on Windows 
This appears to be necessary for current official builds cross-compiled
with MinGW from Linux, using Mono 6.6.0.160.

Follow-up to #31784, see #29812 for details.
 2019-12-16 15:40:26 +01:00
Rémi Verschelde
d4601776db
Merge pull request #34377 from timothyqiu/i18n 
Makes more strings in editor translatable
 2019-12-16 09:56:23 +01:00
Haoyu Qiu
7a9c337dfe Makes more strings in editor translatable 
* File type names in file dialogs
* Layout option names
* Visual shader editor UI
 2019-12-16 16:41:07 +08:00
Rémi Verschelde
74977277fa
Merge pull request #34280 from zaksnet/fix-yield-documentation 
Fix documentation for yield
 2019-12-16 08:49:32 +01:00
Haoyu Qiu
468fcd80bb Updates docs for GDScript built-in functions 
* Adds description for `ord()`
* Adds relationship description between `char()` and `ord()`
* Describes the argument of `char()` as Unicode code point instead of ASCII code
* Fixes wrong interval notation in `randi()` description
 2019-12-15 19:06:29 +08:00
Rémi Verschelde
12ee35737f
Merge pull request #34334 from neikeq/issue-33503 
Mono/C#: Fix class parser bug with 'where T : struct'
 2019-12-13 20:13:28 +01:00
Rémi Verschelde
e65db6a16b
Merge pull request #34333 from vnen/gdscript-assign-op 
Fix some cases where typed assignment gets invalid
 2019-12-13 20:13:12 +01:00
Ignacio Etcheverry
f2a2293709 Mono/C#: Fix class parser incorrectly handling nested namespaces 
It would incorrectly error thinking the nested namespace is being declared inside a struct/class. This was because of an incorrect nesting level being used for classes and structs.
 2019-12-13 19:55:32 +01:00
Ignacio Etcheverry
c1ab956dd0 Mono/C#: Fix class parser bug with 'where T : struct' 
The struct decl parsing was outdated. Make both struct decl and class declparsing share the same code.
 2019-12-13 19:50:42 +01:00
George Marques
cb887324e6
GDScript: Convert values when setting member variables 
This allows doing: self.x = 1 even if self.x is declared as float.
 2019-12-13 12:51:53 -03:00
George Marques
475d7f0e52
GDScript: Fix type conversion in assignment with operation 2019-12-13 12:51:08 -03:00
Rémi Verschelde
9f68626fb2 doc: Sync classref with current source 
Also apply clang-format.
 2019-12-13 10:41:06 +01:00
Zak
0fd7186971 Fix documentation for yield 
#33872 PR was misleading as i though inheritance from GDScriptFunctionState was optional.
 2019-12-13 11:17:12 +02:00
Rémi Verschelde
d39284a65f
Merge pull request #34295 from aaronfranke/potato-knishes 
[Mono] Fix string Find methods having reversed case sensitivity
 2019-12-13 08:47:26 +01:00
Rémi Verschelde
f065b34e96
Merge pull request #34286 from bojidar-bg/31818-cast-autocomplete 
Fix GDScript autocompletion with "as" or typed variables
 2019-12-12 14:53:38 +01:00
Aaron Franke
d09193b08a
Fix string Find methods having reversed case sensitivity 2019-12-12 02:21:16 -05:00
Bojidar Marinov
a665b3878b
Fix GDScript autocompletion with as or typed variables 
Fixes #31818, fixes #33434
 2019-12-12 01:16:23 +02:00
Aaron Franke
5771f9959c
Mono formatting 
No space for casting, add spaces inside braces, 4 space indentation, remove trailing indentation, remove BOM.
 2019-12-11 16:32:47 -05:00
Michael Alexsander
6cc3bb2d9b Add note in 'load()' docs that the path must be absolute 2019-12-11 17:14:58 -03:00
Rémi Verschelde
98c3990f7d
Merge pull request #34271 from vnen/gdscript-unused-class-variable-disable 
Disable GDScript warning for unused class variable by default
 2019-12-11 16:27:42 +01:00
Rémi Verschelde
70a8c37957
Merge pull request #34227 from akien-mga/scons-mingw-split-libmodules 
SCons: Add 'split_libmodules' option to workaround linker issue
 2019-12-11 16:21:16 +01:00
Rémi Verschelde
c320a82213 SCons: Add 'split_libmodules' option to workaround linker issue 
The new 'split_libmodules=yes' option is useful to work around linker
command line size limitations when linking a huge number of objects.
We're currently over 64k chars when linking libmodules.a on Windows
with MinGW, which triggers issues as seen in #30892.

Even on Linux, we can also reach linker command line size limitations
by adding more custom modules.

We force this option to True for MinGW on Windows, which fixes #30892.

Additional changes to lib splitting:

- Fix linking of the split module libs with interdependent symbols,
  hacking our way into LINKCOM and SHLINKCOM to set the `--start-group`
  and `--end-group` flags.
- Fix Python 3 compatibility in `methods.split_lib()`.
- Drop seemingly obsolete condition for 'msys' on 'posix'.
- Drop the unnecessary 'split_drivers' as the drivers lib is no longer
  too big since we moved all thirdparty builds to modules.

Co-authored-by: Hein-Pieter van Braam-Stewart <hp@tmm.cx>
 2019-12-11 15:40:28 +01:00
Rémi Verschelde
df2e3e3f7f
Merge pull request #33018 from Xrayez/fix-inst2dict-getters 
Fix `inst2dict` calling to getters to retrieve value
 2019-12-11 15:06:38 +01:00
George Marques
cbf5641a74
Disable GDScript warning for unused class variable by default 2019-12-11 11:02:07 -03:00
Rémi Verschelde
cd9d513285
Merge pull request #34181 from van800/rider 
Support Rider as external editor for Godot mono version
 2019-12-11 09:20:31 +01:00
Ivan Shakhov
8fbc9d33fd Support Rider as External Editor 2019-12-11 08:39:04 +01:00
Rémi Verschelde
2845e6a21a
Merge pull request #34040 from qarmin/unused_variable_more_precise_numbers 
Removed unused variables, add some constants numbers
 2019-12-10 08:25:31 +01:00
Marcel Admiraal
e0d252311e Add check for zero length motion at beginning of each sweep test loop 
in SpaceBullet::test_body_motion.
 2019-12-10 08:16:32 +01:00
Rafał Mikrut
ed1c4bc77d Removed unused variables, add some constants numbers 2019-12-10 05:13:02 +01:00
Marcel Admiraal
78055cbdaf Check that motion is not zero before doing a sweep test. 
Fixes #25476.
 2019-12-09 09:21:38 +01:00
Rémi Verschelde
4eff13d768 doc: Markup fixes for enums and constants 2019-12-06 23:09:20 +01:00
Jonas
11258db001
Fix missing null checks in Mono Binding of GD 
The print methods of mono binding was missing null checks for the params
 2019-12-06 11:56:50 +01:00
Ignacio Roldán Etcheverry
6544a0e908
Merge pull request #34018 from dsge/show-template-directory-path-in-error-message 
Make sure to include the path in the "Data template directory not found" error message
 2019-12-05 14:17:23 +01:00
codecustard
601d870ae9 Fixes wrong position when adding node in VS editor 
When adding a node in the visual script editor while zoomed in, the position of the newly added node would be wrong.
 2019-12-04 17:12:01 -08:00
Ignacio Etcheverry
066ae9d83b Mono/C#: Several android fixes 
- Added correct config file for android dllmaps.
- Fix __Internal DllImports with a dlopen fallback.
- Add missing P/Invoke functions and internal calls expected by the monodroid BCL and our custom version of the 'Android.Runtime.AndroidEnvironment' class (this last one can be found in the godot-mono-builds repo).
- Make sure to set 'btls' instead of 'legacy' as the default TLS provider on Android.
 2019-12-04 19:03:42 +01:00
Ignacio Etcheverry
3797f19926 C#: Add Duplicate method to the Array and Dictionary bindings 2019-12-04 15:22:30 +01:00
Rémi Verschelde
fc8bbaa8e9
Merge pull request #34094 from volzhs/compile-windows-on-linux 
Fix compile error for Windows on Linux
 2019-12-04 07:08:23 +01:00
Rémi Verschelde
f326913f4d
Merge pull request #34067 from bojidar-bg/32370-retype-message 
Make error when accidentially redeclaring a variable's type clearer
 2019-12-04 06:52:22 +01:00
volzhs
d1270f3d4c Fix compile error for Windows on Linux 2019-12-04 08:06:07 +09:00
Hugo Locurcio
1fcdeaee39
Mention that int() can be used as an alternative to floor() 2019-12-03 08:43:24 +01:00
Bojidar Marinov
79c26344e8
Make error when accidentially redeclaring a variable's type clearer 
Fixes #32370
 2019-12-02 22:26:05 +02:00
Rémi Verschelde
e64a663c59
Merge pull request #33992 from bruvzg/ios_modular_build 
iOS modular build and export implementation.
 2019-12-01 22:35:45 +01:00
bruvzg
2ef8c5fac5
iOS modular build and export implementation. 2019-12-01 21:57:18 +02:00
Emmanuel Leblond
fb9b010384
Add missing on error manifest struct destroy in pluginscript script init 2019-12-01 16:15:31 +01:00
Rémi Verschelde
ea7f3037da
Merge pull request #34002 from KoBeWi/crashonat 
Don't try to initialize empty NativeLibrary
 2019-12-01 11:53:19 +01:00
Rémi Verschelde
7140d766a2
Merge pull request #33997 from akien-mga/doc-makerst-escape 
makerst: Escape default values using reST markup
 2019-12-01 11:52:20 +01:00
Aaron Franke
3231fca934
Add docs for is_equal_approx on structures 2019-11-30 16:52:27 -05:00
miere43
d747c61187 Fixed typo in docs for Script and GDScript classes ("exends" -> "extends") 2019-11-30 21:16:11 +03:00
dsge
81cae314b4 Make sure to include the path in the "Data template directory not found" error message 2019-11-30 15:44:18 +01:00
Rémi Verschelde
52e3944846
Merge pull request #34009 from flyingpimonster/gridmap-docs 
Docs: GridMap and MeshLibrary
 2019-11-30 11:13:42 +01:00
James Westman
7ef16ca136 Docs: GridMap and MeshLibrary 
The only methods left to document are resource_changed, set_clip, and
the methods dealing with baked meshes.
 2019-11-29 18:21:34 -06:00
Tomasz Chabora
f4a1a79d01 Don't try to initialize empty NativeLibrary 2019-11-29 21:10:20 +01:00
Rémi Verschelde
55676b16da makerst: Escape default values using reST markup 
Otherwise the docs would complain about values like "godot_"
which reST tries to interpret as an identifier.
 2019-11-29 14:25:37 +01:00
Rémi Verschelde
fa0e682027
Merge pull request #33982 from neikeq/issue-29349 
Mono/C#: Add option to export assemblies outside of PCK
 2019-11-29 11:37:18 +01:00
Ignacio Etcheverry
85d8c42763 Mono/C#: Fix crash on exported games that don't use C# 2019-11-29 01:35:46 +01:00
Ignacio Etcheverry
66de28eda8 Mono/C#: Add option to export assemblies outside of PCK 
When using this options, assemblies will be saved in the Assemblies folder of the  data directory: 'data_AppName/Assemblies/'.
 2019-11-29 00:36:05 +01:00
Hugo Locurcio
247767eb89
Document how to bypass the unused argument/variable warning in message 
Note that prefixing with an underscore only works with unused arguments
and local variables, not class variables and signals.

This closes #26056.
 2019-11-27 22:52:43 +01:00
Hugo Locurcio
4c1b2171b0
Implement zooming using Ctrl + Mouse wheel in the GridMap editor 
The minimum value of the slider was changed to 0.2 as zooming
works in increments of 0.2. This way, the value can go back to 1
after you've reached the slider's minimum value.
 2019-11-27 20:16:53 +01:00
Rémi Verschelde
aae9e11a1e
Merge pull request #33946 from NeoSpark314/remove_exr_dbgprint 
Remove .exr saver debug print
 2019-11-27 17:55:23 +01:00
Holger Dammertz
365c5bd0e5 Remove .exr saver debug print 2019-11-27 17:17:29 +01:00
marcosjouron
6d2b21c6a4 VideoStreamGDNative: Fix playing video files without audio stream 2019-11-27 16:40:16 +01:00
Rémi Verschelde
a87e2f85ee
Merge pull request #33939 from KoBeWi/grideprecatedmap 
Remove deprecated theme property from GridMap
 2019-11-27 15:32:59 +01:00
Tomasz Chabora
96b30e7727 Remove deprecated theme property from GridMap 2019-11-27 14:40:43 +01:00
Rémi Verschelde
31272d0956
Merge pull request #33921 from Faless/enet/no_relay 
Add ENet option to disable server relaying.
 2019-11-27 14:35:44 +01:00
Fabio Alessandrelli
7e592f9641 Add ENet option to disable server relaying. 
It's useless when building fully authoritative servers, and prevents
various kinds of abuse.
 2019-11-27 11:48:31 +01:00
Hugo Locurcio
4f14a1f59c
Remove type hint from the @GDScript class documentation 
The current consensus in the Godot documentation is to avoid using
type hints unless they're relevant to the behavior explained.
 2019-11-26 19:13:55 +01:00
Fabio Alessandrelli
391f6ff2c6 Fix memory leak in NetworkedMultiplayerENet. 
Dynamically allocated ids of peers where not correctly freed when
calling close_connection and disconnect_peer (with now=true).
 2019-11-26 16:00:55 +01:00
James Buck
9e44739324 Trigger an error when trying to define a preexisting signal in GDScript 
A class can't have multiple signals with the same name, but previously users
would not be alerted to a conflict while editing the script where it occurred.
Now a helpful error will appear in the editor during script parsing.
 2019-11-25 13:40:03 -06:00
Zak Stam
5cfff77ca6 Added missing documentation for yield() 
Added some missing documentation about yield() being able to wait for a function also. I cant believe something like that was missing from the docs, it would have saved me so much time (and others i assume).
 2019-11-25 18:08:18 +02:00
Rémi Verschelde
636bc5c32f
Merge pull request #33828 from neikeq/貴様 
Mono/C#: Prevent SCons from building API solutions in parallel
 2019-11-23 11:24:48 +01:00
Ignacio Etcheverry
ebdd2bc474 Mono/C#: Prevent SCons from building API solutions in parallel 2019-11-22 23:42:24 +01:00
Rémi Verschelde
c41c24562d Style: Add missing copyright headers 2019-11-22 08:37:09 +01:00
Rémi Verschelde
ab3bccdb78 Fix typos with codespell 
Using codespell 1.16.0.

Method:
```
$ cat > ../godot-word-whitelist.txt << EOF
ang
curvelinear
dof
doubleclick
leapyear
lod
merchantibility
nd
numer
ois
ony
que
seeked
synching
te
uint
unselect
webp
EOF

$ codespell -w -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"
$ git diff // undo unwanted changes
```
 2019-11-22 08:35:03 +01:00
Ignacio Roldán Etcheverry
63b321dbbb
Merge pull request #33791 from neikeq/issue-33761 
C#: Fix PathWhich on Windows when name already has extension
 2019-11-21 21:34:12 +01:00
Ignacio Etcheverry
f91416d9ac C#: Fix PathWhich on Windows when name already has extension 
Also make the Posix version of PathWhich check if the file has executable access.
 2019-11-21 14:53:00 +01:00
Rémi Verschelde
719254ae0d
Merge pull request #33759 from bruvzg/arkit_dyn_load 
[iOS] Link and load ARKit framework dynamically.
 2019-11-20 21:17:43 +01:00
K. S. Ernest (iFire) Lee
5d70a95fe1 33714 Check if the image is null before use. 2019-11-20 11:22:35 -08:00
Rémi Verschelde
73323a2838
Merge pull request #33763 from neikeq/issue-33725 
Fix C# export error dialog showing up when it should not
 2019-11-20 13:23:20 +01:00
Ignacio Etcheverry
d79aeca599 Fix C# export error dialog showing up when it should not 2019-11-20 13:07:26 +01:00
bruvzg
a9fef1a774
[iOS] Link and load ARKit framework dynamically. 2019-11-20 11:18:01 +02:00
Rémi Verschelde
02913f53d3 pcre2: Use scons option to disable JIT on some platforms 
Third-party platforms (e.g. console ports) need to be able to
disable JIT support in the regex module too, so it can't be
hardcoded in the module SCsub. This is cleaner this way anyway.

Fixes #19316.
 2019-11-20 08:54:52 +01:00
Ignacio Etcheverry
3f247ea507 Mono/C#: Bundle libmono-btls-shared.dll on Windows if it exists 2019-11-19 17:22:06 +01:00
Rémi Verschelde
8450658fa2
Merge pull request #33673 from YeldhamDev/script_templates_lines_style 
Make the script templates' blank lines conform with the official style guide
 2019-11-19 10:41:36 +01:00
Ignacio Etcheverry
008769aee9 C#: Throw NullReferenceException for null NodePath/RID params 2019-11-18 12:23:54 +01:00
Rémi Verschelde
46ae64cd60 Revert "Update opus to 1.3.1 and opusfile to 0.11" 
This reverts commit e00426c512.

The way we handle platform-specific intrinsics is not good, so the
current state will not compile on armv8. This commit also requires
SSE4.1 support, which is likely not a good idea for portable binaries.

We'll have to redo this with more caution after 3.2 is released, or
we might simply drop opus as we're only using it as dependency for
theora right now.

Fixes #33606.
 2019-11-18 09:56:48 +01:00
Michael Alexsander
7ecaff578b Make the script templates' blank lines conform with the official style guide 2019-11-17 08:54:43 -03:00
Rémi Verschelde
3c83137771
Merge pull request #33662 from touilleMan/issue-30577 
Add singleton_name field to autogenerated json api
 2019-11-16 23:00:07 +01:00
Rémi Verschelde
e9f905dccc
Merge pull request #33637 from madmiraal/fix-c4334-warning 
Fix Visual Studio throwing C4334 warning.
 2019-11-16 22:55:09 +01:00
Rémi Verschelde
53bc47a4da
Merge pull request #33643 from Calinou/visual-script-multiply-sign 
Use the Unicode "multiply" sign for the "A x B" visual script node
 2019-11-16 22:54:41 +01:00
Rémi Verschelde
6cde380cee
Merge pull request #33603 from neikeq/ばか 
Mono/C#: WebAssembly and initial AOT support
 2019-11-16 22:44:13 +01:00
Emmanuel Leblond
03e1568aeb
Add singleton_name field to autogenerated json api 2019-11-16 20:29:54 +01:00
Hugo Locurcio
08b4671e03
Use the Unicode "multiply" sign for the "A x B" visual script node 2019-11-15 19:06:53 +01:00
Marcel Admiraal
8fa72a20f3 Fix Visual Studio throwing C4334 warning. 2019-11-15 14:11:12 +01:00
Ignacio Etcheverry
8cbe4a3db4 Make C# internal calls return structs as ref parameters 
The Mono IL interpreter's WebAssembly to native trampolines don't support passing structs by value, so we need to do it this way.

Also now we pass and return long, ulong, float and double as ref parameters as well. This is due to missing trampolines for float and long types. This is likely a temporary workaround that will be reverted in the future. The correct solution would be to patch 'mono/mini/m2n-gen.cs' when building the Mono runtime for WASM in order to generate the trampolines we need.
 2019-11-15 03:22:25 +01:00
Ignacio Etcheverry
2b67924a0b Mono/C#: Initial exporter support for AOT compilation 2019-11-15 03:22:18 +01:00
lupoDharkael
9254961297 Parser: Check all the arguments of the ternary operator 2019-11-15 01:29:18 +01:00
Ignacio Etcheverry
de7c2ad21b Mono/C#: WebAssembly support 2019-11-13 21:41:11 +01:00
Rémi Verschelde
30d4c923cb
Merge pull request #32966 from ffaristocrat/fix-hex-parsing 
Fix base 16 hex literal parsing
 2019-11-12 23:04:20 +01:00
Micheál Keane
4b9fd961d6 Fixes #32963 by correctly parsing bin/hex literals 2019-11-12 15:57:38 -05:00
Ignacio Roldán Etcheverry
953f37f49b
Merge pull request #33249 from JoshLee0915/MonoHeadlessServer 
Added missing server platform checks to template dir and shared lib copy in mono_configure.py
 2019-11-12 14:57:29 +01:00
Rémi Verschelde
ba4c808721
Merge pull request #33311 from SneakyFish5/update-opus 
Update opus to 1.3.1 and opusfile to 0.11
 2019-11-12 07:55:25 +01:00
Rémi Verschelde
51d1be5156 AudioStreamOGGVorbis: Expose loop and loop_offset as properties 
Fixes #11231.
 2019-11-11 15:14:37 +01:00
Rémi Verschelde
6b1628f9fc
Merge pull request #33517 from madmiraal/fix-_MSG-macros 
Send *_MSG macros' explanations directly to the _err_print_error().
 2019-11-11 13:27:51 +01:00
Marcel Admiraal
83069a3c0f Remove ERR_EXPLAIN macros and the scaffolding they needed. 2019-11-11 10:57:00 +01:00
Marcel Admiraal
d18b2e599d Remove all uses of ERR_EXPLAIN macros. 2019-11-11 10:24:04 +01:00
Rémi Verschelde
2143f46df2
Merge pull request #33516 from qarmin/small_fixes 
Memory leaks and crash fixes
 2019-11-10 10:17:19 +01:00
Rafał Mikrut
7dda9309f9 Memory leak and crash fixes 2019-11-10 09:49:13 +01:00
unknown
e00426c512 Update opus to 1.3.1 and opusfile to 0.11 2019-11-09 13:06:56 -06:00
mashumafi
d7137a6b72 Add setting to exclude addons from script warnings 2019-11-07 23:01:22 -05:00
Rémi Verschelde
77816fea8b
Merge pull request #32477 from aaronfranke/equal-approx-separate 
Make is_equal_approx separate and make == exact again
 2019-11-07 14:54:15 +01:00
Rémi Verschelde
f0fc28f0fd
Merge pull request #33160 from aaronfranke/alphabetize-mathf 
[Mono] Alphabetize Mathf
 2019-11-07 13:37:33 +01:00
Rémi Verschelde
91518defa5
Merge pull request #33257 from aaronfranke/printraw 
Document behavior of GDScript printraw
 2019-11-07 13:21:09 +01:00
Rémi Verschelde
c4ecec1d33
Merge pull request #32853 from OsamaElHariri/visual_script_setter_props_fix 
Set the properties of a Set node after add_node
 2019-11-07 13:13:33 +01:00
RevoluPowered
5fb160c7c6 Updated assimp to 308db73 from https://github.com/assimp/assimp/ 2019-11-05 20:38:26 +00:00
RevoluPowered
0bd877780f FBX Importer Generation 3 
Basic skin support

Various fixes

- Fixes bind mount id and mesh index
- Fixed duplicate nodes being created
- Prevented leak when instances being freed during re-import.
- Improved camera and light transform import
- skeleton handling and technical debt removal
- ASSIMP: bone nodes were unlinked from bones by this code
- bone_add working can distinguish between armatutes
- Updated transform to be the correct offset
- Added safety for state.root node errors
- Fixed memory leak with leaf bones
- Implemented children re-parenting for mesh template
- import_animation fixes to basic skeleton data
- Adds some more debug messages
- Fixed Godot import segfault
- Fix build failing on mono
- Clear resources we use which are no longer required after import
- Fixed bone duplication issue
- Working skeleton_bone_map which can lookup armatures properly now.
- Fixed stack being used up when mesh swapped & Fixed bone ID

Additional notes:
We use a mesh template which is a fake node to instance the initial
mesh nodes . This is to ensure the entire tree can be built.

We replace mesh node templates with the real mesh after the
skeleton is available, since this makes it ensure that the fully
built skeleton exists with all bones, all nodes, etc.

The bone stack is a stack which pops when it finds bones,
this overcomes duplicate bones with the same names.

FBX has lots of these because animation armature has bone names like bone001
and another armature will also have bone001
Fixed errors in node path assignment

Simple explanation:
- Every mesh uses a node from the stack
- Node stack was empties before completed
- Every time node not found, stack must be rebuilt to maintain correct armature order :)

Additional fixes:
- Fixes destructor in assimp
- Implements aiNode* mArmature in bone data
- Implements aiNode* mParent in bone data
- Fixes parent ID on bones.

Implemented skeleton assignment in generate_mesh_indicies

This is the only place we can safely do a lookup for the skeleton for the mesh.h
I used a pointer reference so we can pass this back out, since the skeleton assignment happens inside the function.

Added mesh re-parenting to the armature node this is a permanent feature and must be enforced, just like GLTF2 specification.

Fixed import_animation spawning tracks per skin
 2019-11-05 17:54:57 +00:00
Rémi Verschelde
6dca64140c
Merge pull request #33330 from nekomatata/fix-label-autowrap-size 
Fixed cases where labels with autowrap can overflow the editor ui
 2019-11-04 16:57:53 +01:00
PouleyKetchoupp
13c88878c4 Fixed cases where labels with autowrap can overflow the editor ui 
Fixes #33155
 2019-11-04 10:12:36 +01:00
Rémi Verschelde
76aa975460
Merge pull request #33266 from Xrayez/inst2dict-original-path 
Use GDScript resource path over script path for `inst2dict`
 2019-11-04 08:59:30 +01:00
Rémi Verschelde
0195ecdb0f
Merge pull request #33258 from aaronfranke/color8 
Fix Color8 GDScript documentation
 2019-11-02 23:08:23 +01:00
bruvzg
047ecffaac
Restore GDNative compatibility by moving new functions introduced in #33210 to core API 1.2 extension. 2019-11-02 15:25:43 +02:00
Andrii Doroshenko (Xrayez)
7f40b69022 Use GDScript resource path over script path for inst2dict 
The resource path holds the original path which can be used to convert
a dictionary to instance consistently both within editor and exported projects
as the original path is automatically remapped from `gd` to `gdc` or `gde` in
exported projects.
 2019-11-02 15:11:52 +02:00
Aaron Franke
c4e46b8800
Document behavior of printraw 2019-11-02 04:55:39 -04:00
Aaron Franke
b67f252016
Fix Color8 GDScript documentation 2019-11-02 04:48:08 -04:00
Rémi Verschelde
af4fd9de9c
Merge pull request #33238 from qarmin/other_fixes 
Fix some crashes, overflows and using variables without  values
 2019-11-01 22:12:47 +01:00
George Marques
9fcd38fc70
GDScript: validate instance before accessing it on error 
Make sure the instance is valid before trying to access the script in
after an error happened. If the instance is not valid it's possible that
the script is invalid as well.

Fix #29623
 2019-11-01 14:41:52 -03:00
Rafał Mikrut
9ddb3265e1 Fix some crashes, overflows and using variables without values 2019-11-01 16:16:31 +01:00
Omicron
79a59a3587
Fix: typo atleast -> at least 
Typo found in source string, reported by linux-man on weblate
 2019-11-01 16:10:21 +01:00
George Marques
15800b4db8
GDScript: Avoid editor crashes when there's cyclic inheritance 
Make sure the script is fully compiled before looking into the base.
 2019-11-01 12:00:20 -03:00
Rémi Verschelde
962fc725c0
Merge pull request #33210 from nekomatata/pool-array-empty 
Added empty() function to pool array types
 2019-11-01 14:04:16 +01:00
PouleyKetchoupp
475115c0c3 Added empty() function to pool array types 2019-10-31 16:27:32 +01:00
Andrii Doroshenko (Xrayez)
56925b9c28 Provide and print error messages for JSON parsing 
Core is not touched, only for binding and scripting.
 2019-10-31 13:15:44 +02:00
PouleyKetchoupp
bcbe5b5850 Fixed leak in gdscript when creating empty WeakRef 
Fixes #33150
 2019-10-29 23:53:56 +01:00
Aaron Franke
4922a48a9e
[Mono] Alphabetize Mathf 2019-10-29 10:10:24 -04:00
Rémi Verschelde
b8daad9779 i18n: Sync translation template with current source 2019-10-29 13:57:45 +01:00
Osama El Hariri
858afd53d8 Set the properties of a Set node after add_node 2019-10-28 21:03:12 +02:00
Rémi Verschelde
63c5cd7eb8
Merge pull request #33104 from qarmin/fix_some_crashes 
Fix some crashes and using null pointers
 2019-10-28 08:37:59 +01:00
Rafał Mikrut
e53e1c566a Fix some crashes and using null pointers 2019-10-28 08:07:29 +01:00
Rémi Verschelde
aa0fa6b14f doc: Sync classref with current source 2019-10-26 16:40:41 +02:00
Rémi Verschelde
e38fd9a5e6
Merge pull request #32915 from Nehluxhes/gridmap_scaling 
Gridmap : Mesh preview now scales + grid update on cell size change
 2019-10-25 23:33:11 +02:00
Rémi Verschelde
c43c3747cf
Merge pull request #32808 from bojidar-bg/30937-less-strict-mixed-spacing 
Allow mixed tabs and spaces when indentation does not depend on tab size
 2019-10-25 23:16:04 +02:00
bruvzg
1a0306abb1
Fix missing z_verbose and z_error symbols in debug iOS build. 2019-10-25 15:51:17 +03:00
Bojidar Marinov
afbde3314a
Allow mixed tabs and spaces when indentation does not depend on tab size 
(hopefully) Closes #30937, fixes #32612
 2019-10-25 14:54:57 +03:00
Andrii Doroshenko (Xrayez)
1b9a7e1c21 Fix inst2dict calling to getters to retrieve value 
Use `GDScriptInstance` to iterate through all members directly instead.
This is similar to how `dict2inst` works and makes the serialization
behaviour more consistent.
 2019-10-24 14:45:04 +03:00
SeleckyErik
61bda112bd Refactor VideoPlayer and VideoStream 
VideoStream:
- Fix const correctenss

VideoPlayer:
- Remove unused member variable last_frame
- Move _mix_audios function definition to source file
- Fix function parameter naming to match p_ convention
- Fix const correctness
- Add null checking
 2019-10-24 01:35:47 +01:00
Rémi Verschelde
e96319c7f3
Merge pull request #32670 from aaronfranke/mono-plane 
[Mono] Change Plane intersect methods to return nullable Vector3
 2019-10-23 21:44:05 +02:00
Rémi Verschelde
4952e19ad0
Merge pull request #32991 from Chaosus/fix_bug2 
Fix gridmap error spam at startup
 2019-10-22 20:38:14 +02:00
Rémi Verschelde
365558b8b7
Merge pull request #32969 from Nehluxhes/palette_vanish 
Fix gridmap palette remaining invisible
 2019-10-22 18:51:11 +02:00
Yuri Roubinsky
51e5bcfc2c Fix gridmap error spam at startup 2019-10-22 18:21:42 +03:00
Rémi Verschelde
8228b93fcd
Merge pull request #32919 from vnen/gdscript-unused-args 
Fix wrong counting of function argument usage
 2019-10-22 14:15:58 +02:00
Rémi Verschelde
e4cfb77961
Merge pull request #32903 from madmiraal/fix-27649-part9 
Remove duplicate valid value check in gdscript_tokenizer.cpp.
 2019-10-22 13:51:28 +02:00
Rémi Verschelde
fddc60c85c
Merge pull request #32878 from EbbDrop/no_autocompletion_for_singeltons 
Fixes auto completion for singletons
 2019-10-22 13:50:25 +02:00
Rémi Verschelde
10518d5d84
Merge pull request #32893 from Nehluxhes/delete_gridmap 
Disable gridmap selection actions when nothing is selected
 2019-10-22 12:55:18 +02:00
JoshLee0915
cbd98d0fcf Added the server platform checks to template dir and shared lib copy 2019-10-21 20:47:24 -06:00
Nehluxhes
d67a9d1a94 Fix gridmap palette remaining invisible 2019-10-21 23:57:23 +02:00
Nehluxhes
fa53c0b774 Mesh preview now scales + grid update on cell size change 
The mesh preview now correctly scales with cell_scale
Refactor the grids creation into _draw_grids() and call it if the cell_size property is changed
 2019-10-21 23:11:30 +02:00
Rémi Verschelde
3564547208
Merge pull request #32750 from Faless/js/fix_ws_refactor 
Fix HTML5 build after 67a4c30.
 2019-10-21 22:26:33 +02:00
Rémi Verschelde
f5dd4d574f
Merge pull request #32863 from JFonS/navmesh_from_group 
Add option to create navmesh from objects in group
 2019-10-21 16:02:38 +02:00
George Marques
05465b9693
GDScript: Add _ prefix on class name in type compatibility check 
This makes sure that the classes internally represented with an
underscore (_) prefix, such as singletons, are still properly checked
for inheritance in the ClassDB.
 2019-10-19 13:45:52 -03:00
George Marques
bb20e420af
Fix wrong counting of function argument usage 
There's no need to subtract 1 from the assignment usages because it's
not incremented anywhere else.

Also put back the assignment with operators because they should not
count as usage if the argument is on the left side.
 2019-10-19 10:59:57 -03:00
Marcel Admiraal
5b96233c34 Remove duplicate valid value check in gdscript_tokenizer.cpp. 2019-10-18 11:58:34 +02:00
Nehluxhes
28c274bc27 Disable gridmap selection actions when nothing is selected 2019-10-18 01:45:49 +02:00
EbbDrop
f70fd781fc Fix autocompletion for singletons 2019-10-17 10:48:13 +02:00
Fabio Alessandrelli
2bb3e358e0 Trim protocol field from spaces in WS classes. 2019-10-16 16:16:27 +02:00
jfons
298bd3f88a Add option to create navmesh from objects in group 
Adds a new NavigationMesh property to select which objects will be taken
into account for the generation.

By default it will use all the NavigationMeshInstance children to keep
compatibility. The new modes allow to build the NavigationMesh from
all the nodes belonging to a specific group, and optionally include
their children too.
 2019-10-16 12:01:10 +02:00
Fabio Alessandrelli
d75e0de729 Fix HTML5 build after 67a4c30. 
I messed up a rebase and a commit was partly skipped
 2019-10-15 14:15:02 +02:00
Rémi Verschelde
a1033aea51
Merge pull request #32830 from timoschwarzer/remove-redundant-compiler-directives 
Remove redundant compiler directives
 2019-10-15 09:57:46 +02:00
Rémi Verschelde
44293db446
Merge pull request #32820 from qarmin/small_fixes_static_analyzer 
Small fixes to redundand code, copy paste bugs
 2019-10-15 09:54:58 +02:00
Aaron Franke
218f38c7ec
Expose is_equal_approx and restore == to be exact again 
This commit changes behavior for GDScript and C#.

Also did some organizing of the order to logically group related methods, mostly for Rect2 and AABB.
 2019-10-14 16:48:59 -04:00
Aaron Franke
aeb7075628
Replace vector == and is_zero_approx(distance) with is_equal_approx 
Internal changes only
 2019-10-14 16:47:42 -04:00
Aaron Franke
86922ff70b
Make is_equal_approx separate for structures 
This commit adds exposed behavior for C#
 2019-10-14 16:46:54 -04:00
Timo Schwarzer
c69ae35d4d
Remove redundant compiler directives 
Closes #32817
 2019-10-14 16:23:13 +02:00
qarmin
616ab4fac2 Small fixes to redundand code, copy paste bugs 2019-10-14 11:40:55 +02:00
Marcel Admiraal
0539023fd4 Call activate function when setting RigidBodyBullet activation state. 2019-10-14 10:04:44 +02:00
Ignacio Etcheverry
8a0c0371d4 C#: Fix regression from #32732 caused a crash on domain reload 2019-10-12 21:27:56 +02:00
Rémi Verschelde
26bbb26738
Merge pull request #32641 from nekomatata/change-collision-layer 
Fixed RigidBody stuttering when changing collision layer/mask
 2019-10-12 14:07:55 +02:00
Rémi Verschelde
3cc94b2c0b Mono: Fix template build after #32732 2019-10-11 15:17:36 +02:00
Rémi Verschelde
e49b40a974
Merge pull request #32591 from HaSa1002/lsp-fatal-crash 
fix #32588 out of range crash in language server
 2019-10-11 15:16:10 +02:00
HaSa1002
d9dfc4496c fix #32588 crash in language server 2019-10-11 14:43:39 +02:00
Rémi Verschelde
d655a7c097 doc: Sync classref with current source 2019-10-11 08:45:03 +02:00
Rémi Verschelde
be446038bb
Merge pull request #32683 from Faless/ws/improve_pr 
WebSocket improvements, SSL server, custom headers.
 2019-10-11 08:28:47 +02:00
Ignacio Etcheverry
8c438a2197 C#: Fix detection of outdated release Godot API assemblies 2019-10-11 01:46:06 +02:00
Hugo Locurcio
7f49c5dd42
Decrease polling frequency to 20 Hz in the GDScript language server 
This decreases the language server's CPU usage.
 2019-10-10 16:42:05 +02:00
Marcel Admiraal
a8836ba28d Remove dependency on the editor directory being in the build's include path. 
- Add or remove the necessary subdirectorires to the includes to remove
dependency on the editor directory being in the build's include path.
- Ensure includes in modified files conform to style guideline.
- Remove editor from the build include path.
 2019-10-10 08:57:00 +02:00
Rémi Verschelde
781e4f8673
Merge pull request #32673 from aaronfranke/vs-inheritance 
Make VisualScript check inheritance for port info
 2019-10-09 17:52:51 +02:00
Rémi Verschelde
08725bdc28
Merge pull request #32684 from Faless/crypto/self_signed_cert_key_check 
Fix crash when passing invalid key to Crypto.
 2019-10-09 16:52:20 +02:00
Fabio Alessandrelli
e9abcbac3b Fix crash when passing invalid key to Crypto. 
In generate_self_signed_certificate
 2019-10-09 15:59:17 +02:00
Fabio Alessandrelli
2c557787c1 Document all this new improvements. 2019-10-09 13:53:04 +02:00
Fabio Alessandrelli
67a4c3033b Custom headers support in WebSocketClient. 
This commit also converts all PoolVector<String> parameters to
`const Vector<String>` in both WebSocketServer and WebSocketClient.
 2019-10-09 13:53:04 +02:00
Fabio Alessandrelli
c723a8b6aa Implement WebSocketServer SSL support. 2019-10-09 13:53:04 +02:00
Fabio Alessandrelli
33644d7118 WebSocketClient can now use custom SSL certificate 
Via the `trusted_ssl_certificate` property.
 2019-10-09 13:53:04 +02:00
Fabio Alessandrelli
025cc04d9e Re-implement WebSocket get host/port. 
Was lost during library switch
 2019-10-09 13:53:04 +02:00
Rémi Verschelde
55ef6a0f25
Merge pull request #32671 from GodotExplorer/lsp-send-godot-class-tree 
lsp: Send godot class tree to clients
 2019-10-09 08:35:05 +02:00
Aaron Franke
13779b70e0
Make VisualScript check inheritance for port info 2019-10-09 01:47:05 -04:00
Geequlim
1ab34bc3c2 lsp: Send godot class tree to clients 2019-10-09 13:40:50 +08:00
Aaron Franke
643874f8ca
[Mono] Change Plane intersect methods to return nullable Vector3 2019-10-08 22:47:22 -04:00
Geequlim
2b5b5874a2 lsp: Fix signature of void returned functions in native methods 2019-10-09 10:01:48 +08:00
PouleyKetchoupp
655694b394 Fixed RigidBody stuttering when changing collision layer/mask 
- Changing collision layer/mask now only updates the broadphase proxy to avoid the velocity to be reset each time (also avoids unnecessary computations)
- No rigid body update at all when the collision layer/mask stays the same
- Same changes for Area for optimization purpose

Fixes #32577
 2019-10-08 14:40:24 +02:00
Hugo Locurcio
9499eef4da
Document the GDNative singleton method prefix being changeable 
This also tweaks error messages to remove hardcoded references to
the default `godot_` prefix.
 2019-10-07 15:59:57 +02:00
sheepandshepherd
04dbcd7f5a Document GDNativeLibrary 2019-10-06 17:38:51 +02:00
noname1477
3659e3db9d
Fixed some obvious typos in error messages 
In some errors, there were closing quotation marks but no opening (e. g. "Unable to iterate on object of type  " + 
Variant::get_type_name(container->get_type()) + "'."
 2019-10-05 15:33:30 +02:00
Rémi Verschelde
872af14e6f
Merge pull request #32544 from GodotExplorer/gdscript-lsp-show_native_symbol 
Improvements for gdscript-lsp server
 2019-10-05 11:00:51 +02:00
geequlim
9f27a4838c Format documentations to markdown only when needed 2019-10-05 14:09:38 +08:00
geequlim
e199488bc7 Add custom api textDocument/nativeSymbol to allow inspect native symbols from LSP clients 2019-10-04 23:00:33 +08:00
geequlim
39813939fc Fix enumeration value of SymbolKind. 
Add custom notification 'gdscript/show_native_symbol' to show native symbols in clients.
Close client connections when stop gdscript-lsp
 2019-10-04 19:36:40 +08:00
Rémi Verschelde
f3f2fdfbab Mono: Fix detection of MsBuild from Visual Studio 
This was a wrong check as an exit code of 0 means success,
not failure. It used to be fine as blocking mode always returned
-2, but this was changed in #32033 to return the exit code.

Fixes #32424.
 2019-10-03 14:13:41 +02:00
Rémi Verschelde
d66cce0215
Merge pull request #32517 from GodotExplorer/gdscript-lsp 
GDScript LSP server improvement
 2019-10-03 13:40:09 +02:00
geequlim
6a8303f82f Implement DocumentLink of GDScript LSP Server 2019-10-03 18:51:03 +08:00
Rémi Verschelde
c9781df316
Merge pull request #32403 from yeonghoey/enforce4space 
Print errors when tab indent found in [codeblock]
 2019-10-03 08:41:21 +02:00
geequlim
d1a6964d39 Fix codeblock formating to markdown 2019-10-03 14:22:26 +08:00
Rémi Verschelde
42fca4ba27
Merge pull request #32485 from Calinou/macros-add-semicolons 
Add missing semicolons to `BIND_ENUM_CONSTANT` macro uses
 2019-10-02 11:53:19 +02:00
Hugo Locurcio
aba157865a
Add missing semicolons to BIND_ENUM_CONSTANT macro uses 2019-10-02 09:57:12 +02:00
Hugo Locurcio
621bafb948
Tweak the default function definition color when using a dark theme 
This decreases its saturation to make it less visually jarring.
The code was also refactored for clarity and to avoid repetition.
 2019-10-02 09:36:47 +02:00
Yeongho Kim
d4a55fb639 Print errors when tab indent found in [codeblock] 2019-10-01 23:39:45 +09:00
Rémi Verschelde
d66d970fdb
Merge pull request #32172 from WindyDarian/gdscript_allow_null_weakref 
Allow weakref(null) in gdscript
 2019-10-01 10:35:37 +02:00
Chaosus
a9d981d26c Fix theme in visual script dialogs (at startup) 2019-09-30 10:51:05 +03:00
Rémi Verschelde
cd63cc7df1
Merge pull request #32402 from YeldhamDev/fix_vs_add_function 
Fix VS editor's "Create Function" dialog
 2019-09-29 21:36:57 +02:00
Rémi Verschelde
784595fda1
Merge pull request #32430 from swarnimarun/vs-decomp 
Deconstruct node for Visualscript
 2019-09-29 21:27:21 +02:00
Swarnim Arun
cf4d476d6e
Deconstruct node for Visualscript 
Adds deconstruct nodes for the built-in types and adds default text to function rename_input_box for the visualscript.
 2019-09-29 23:00:08 +05:30
Michael Alexsander Silva Dias
13e752190f Fix VS editor's "Create Function" dialog 2019-09-28 11:57:13 -03:00
Bojidar Marinov
db89fef8fa
Highlight singletons and class_names in GDScript 
Also, implement a small QoL change for auto-typed variables.
Closes #5739
 2019-09-28 13:13:18 +03:00
Rémi Verschelde
e636563d5d
Merge pull request #32398 from YeldhamDev/cleanup_vs_editor_left 
Cleanup VS editor's left menu
 2019-09-28 07:35:46 +02:00
Rémi Verschelde
26e5e3e507
Merge pull request #32399 from swarnimarun/vs-patch01 
Fix edit function button
 2019-09-28 07:33:38 +02:00
Ignacio Roldán Etcheverry
763a4d8402
Merge pull request #32401 from neikeq/Kisaama! 
Mono: Don't compare API hashes on release builds
 2019-09-28 03:31:37 +02:00
Michael Alexsander Silva Dias
c9328aa068 Cleanup VS editor's left menu 2019-09-27 21:20:43 -03:00
Ignacio Etcheverry
1509890dbc Mono: Don't compare API hashes on release builds 
API hashes cannot be calculated on release builds, as bindings information is lacking. Therefore, we should not be comparing it with the generated glue hash as they will never match.
 2019-09-28 01:07:57 +02:00
Swarnim Arun
4967e4a913
Fix Edit function button 2019-09-28 02:16:11 +05:30
Rémi Verschelde
d0e45e78a4 doc: Sync classref with current source 
And various fixes to bindings, hyperlinks and an uninitialized variable.
 2019-09-27 22:16:42 +02:00
Rémi Verschelde
5cb926a001
Merge pull request #29681 from swarnimarun/vs-graph-unification 
Visual Script Graph Unification
 2019-09-27 15:54:37 +02:00
Rémi Verschelde
e067a54988
Merge pull request #32353 from neikeq/yamero 
Mono: Improve API assembly load error message on exported games
 2019-09-26 07:31:03 +02:00
Rémi Verschelde
0a10e07124
Merge pull request #32352 from neikeq/issue-32237 
Mono: Don't use project settings for debugger agent on exported games
 2019-09-26 07:29:25 +02:00
Ignacio Etcheverry
2325fb11a8 Mono: Improve API assembly load error message on exported games 2019-09-25 22:32:39 +02:00
Swarnim Arun
59738e3fa3
Visualscript editor graph unification & refactoring 
Removes the need to have separate graphs per function for the VisualScript Nodes, and refactoring UI and other improvements such as fuzzy search, right click search boxes and in-graph editable nodes
 2019-09-26 01:53:58 +05:30
Ignacio Etcheverry
5ff4e0516b Mono: Don't use project settings for debugger agent on exported games 2019-09-25 22:03:24 +02:00
Rémi Verschelde
9b8c355eab
Merge pull request #32199 from starryalley/fix_seek 
Fix VideostreamGDNative seek
 2019-09-25 13:01:50 +02:00
Rémi Verschelde
dec10dd776
Merge pull request #32051 from qarmin/some_error_explanation 
Added some obvious errors explanations
 2019-09-25 11:51:54 +02:00
qarmin
17732fe698 Added some obvious errors explanations 2019-09-25 10:28:50 +02:00
George Marques
64d09b7de5
GDScript: Fix type resolution not being return in some cases 
Some situations caused the parser node type to not being update when
trying to resolve the type, returning invalid data and breaking the
parsing when it shouldn't. This patch fix the behavior.
 2019-09-24 18:05:20 -03:00
Rémi Verschelde
e95e847c01
Merge pull request #32307 from neikeq/mesege 
Fix wrong defval in EditorSpatialGizmo.add_mesh method bind
 2019-09-24 15:44:37 +02:00
Ignacio Etcheverry
c4fa027614 Improve C# bindings generator errors for default param values 2019-09-24 15:09:54 +02:00
Rémi Verschelde
a7ac8ec876 doc: Fix parsing of self-closing XML tags 
Follow-up to #31925, `<member />` tags just before `</members>` would cause
a parsing issue, and we'd never notice that we're no longer parsing members.

Also added space before closing `/>`.
 2019-09-24 13:34:05 +02:00
Rémi Verschelde
2f52d73c21
Merge pull request #31925 from bojidar-bg/31855-overriden-properties-docs 
Add overriden properties to the documentation
 2019-09-24 11:53:43 +02:00
Rémi Verschelde
4f294b958f doc: Sync classref with current source 
Fix a few missing bindings or unspecified argument names and default values.
 2019-09-24 11:52:06 +02:00
Rémi Verschelde
cf540f853d
Merge pull request #31974 from YeldhamDev/tilegrid_map_fixes 
Small fixes for the Tile/GridMap editors
 2019-09-24 11:06:34 +02:00
Rémi Verschelde
0ea54eeb06
Merge pull request #30497 from Calinou/editor-gizmos-change-notify 
Notify changes in properties that can be edited by 3D gizmos
 2019-09-23 22:22:49 +02:00
Rémi Verschelde
2f228cdda4
Merge pull request #32278 from Calinou/lsp-fix-double-assignment 
Fix `line` being assigned to twice in the GDScript language server
 2019-09-23 18:50:12 +02:00
Hugo Locurcio
c1fcb22677
Fix line being assigned to twice in the GDScript language server 
This closes #32090.
 2019-09-23 15:27:30 +02:00
Rémi Verschelde
2114898cb5
Merge pull request #31172 from creikey/add-array-slicing 
Add array slice method
 2019-09-23 15:26:27 +02:00
Rémi Verschelde
159470df08
Merge pull request #32275 from godotengine/skin_support 
Added skin support and simplified APIs to override bone position + glTF 2.0 import fixes
 2019-09-23 15:02:15 +02:00
Rémi Verschelde
30e16fff57
Merge pull request #32198 from starryalley/fix_audio_buffer 
Fix VideostreamGDNative audio buffer handling
 2019-09-23 15:01:43 +02:00
Harley Laue
0fbd00f656 Allow building cvtt with system squish 
It looks like the SCsub for cvtt was copied from squish and it left
the `if env['build_squish']:` line intact. This means that using
`scons builtin_squish=no modules/cvtt` would fail and overal builds
would also fail because they'd fail to find `ConvectionKernels.h`
 2019-09-23 02:59:59 -07:00
Rémi Verschelde
393a0152ea
Merge pull request #32055 from qarmin/some_code_fixes 
Changed some code found by Clang Tidy and Coverity
 2019-09-23 10:00:31 +02:00
Rémi Verschelde
72d87cfbce
Merge pull request #30852 from swarnimarun/vs_tools_script 
Tool Mode for Visualscript
 2019-09-22 21:21:59 +02:00
qarmin
50be65bf43 Changed some code found by Clang Tidy and Coverity 2019-09-22 18:45:08 +02:00
Swarnim Arun
097f47f064
Tool Mode for Visualscript 
Add the ability to VisualScript to function in Tool mode aka the Editor itself similar to GDScript or Mono
 2019-09-21 18:42:27 +05:30
Rémi Verschelde
25a1bfed5c
Merge pull request #32210 from Calinou/editor-log-distinguish-messages 
Distinguish editor-originating messages in the editor log
 2019-09-20 20:22:43 +02:00
Rémi Verschelde
a34b77e271
Merge pull request #32095 from KoBeWi/silly_user 
Properly remove GridMap node from editor on undo
 2019-09-20 17:52:39 +02:00
Rémi Verschelde
9c116f4f1d
Merge pull request #32223 from neikeq/cs_glue_version_fix 
C#: Make sure cs_glue_version is present when building export templates
 2019-09-20 17:46:34 +02:00
Ignacio Etcheverry
95c685143a C#: Make sure cs_glue_version is present when building export templates 2019-09-20 17:41:20 +02:00
Rémi Verschelde
fdc2463a1b
Merge pull request #32150 from luzpaz/typos 
Fix misc. source comment typos
 2019-09-20 17:09:05 +02:00
Hugo Locurcio
ba566dff2e
Distinguish editor-originating messages in the editor log 
This fades out messages originating from the editor to make messages
printed by the project stand out more.

This also tweaks wording in some editor messages for consistency.
 2019-09-20 01:59:02 +02:00
luz.paz
91ecd7b6a6 Fix misc. source comment typos 
Found using `codespell -q 3 -S ./thirdparty,*.po -L ang,ba,cas,dof,doubleclick,fave,hist,leapyear,lod,nd,numer,ois,paket,seeked,sinc,switchs,te,uint -D ~/Projects/codespell/codespell_lib/data/dictionary.txt `
 2019-09-19 14:36:52 -04:00
Rémi Verschelde
c3d5c96494
Merge pull request #31921 from bojidar-bg/28978-uninitialized-array-value 
Fix uninitialized arrays and dictionaries retaining value
 2019-09-19 20:31:12 +02:00
Rémi Verschelde
f9db6ad8c5
Merge pull request #31919 from m4gr3d/use_aar_for_custom_build 
Leverage Android archive (AAR) file for Godot custom build
 2019-09-19 20:22:09 +02:00
Rémi Verschelde
291f408fcf
Merge pull request #32100 from SaracenOne/gdscript_parent_const_types 
Fix const deceleration for inherited scripts above immediate parent
 2019-09-19 20:11:37 +02:00
Rémi Verschelde
fc9985b770
Merge pull request #31961 from YeldhamDev/info_messages 
Add informational messages to various editors
 2019-09-19 20:06:44 +02:00
Rémi Verschelde
b5f14cc6f7
Merge pull request #31934 from mitchcurtis/28187 
Produce an error when a class has the same name as a Singleton
 2019-09-19 20:05:41 +02:00
Rémi Verschelde
318ac6ee13
Merge pull request #31142 from mitchcurtis/assert-message 
GDScript: add an optional message parameter to assert()
 2019-09-19 19:56:05 +02:00
Rémi Verschelde
996e30ee94
Merge pull request #32019 from RevoluPowered/feature/implement-pbr-materials 
FBX Importer - Maya material PBR path is read properly now
 2019-09-19 19:02:27 +02:00
RevoluPowered
269ba00fd3 Implemented maya stingray support 2019-09-19 16:45:33 +01:00
RevoluPowered
efd6f6dbad Implemented basic texture mapping for PBR material definitions 
This reads materials properly from Maya and expands on existing functionality to make this work properly.

aiTextureType_SHININESS no longer used as not appropriate for PBR texture as it is legacy.

This fix will be also present in assimp soon.
 2019-09-19 16:45:33 +01:00
RevoluPowered
ff8864e020 Fixed blend shapes disappearing 
Co-authored-by: K. S. Ernest (iFire) Lee <ernest.lee@chibifire.com>
 2019-09-19 16:34:14 +01:00
Mark Kuo
8d2efe75ae Fix VideostreamGDNative audio buffer handling 
Fix the audio buffer start when there are previous remains
 2019-09-19 15:28:33 +10:00
Mark Kuo
ec9c5171d2 Fix VideostreamGDNative seek 
When seeking video, make sure audio buffers are reset and video time
is updated.
 2019-09-19 15:27:31 +10:00
Juan Linietsky
d81ddaf33e Added skin support and simplified APIs to override bone position. 2019-09-18 19:46:32 -03:00
Windy Darian
628f467605 Allow weakref(null) in gdscript 
Tiny addition I personally found useful - this allows us to `var my_ref := weakref(null)` for nullable weak ref (with type hint!). When trying to test if `my_ref` is holding valid reference, we can just `if my_ref.get_ref():` instead of `if my_ref and my_ref.get_ref():` everywhere.
 2019-09-16 23:15:34 -04:00
Chaosus89
46bb523db7 [Mono] Corrected rectangle intersection 2019-09-16 09:49:04 +03:00
Cameron Reikes
757c509437 Add array slice method 2019-09-14 13:08:28 -07:00
Tomasz Chabora
6290616c0a Properly remove GridMap node from editor on undo 2019-09-11 23:56:11 +02:00
Mitch Curtis
aa8e3e7b0f GDScript: add an optional message parameter to assert() 
Before this patch, assert() only took the condition to assert on:

    assert(item_data)

Now, it can optionally take a string that will be printed upon failure:

    assert(item_data, item_name + " has no item data in ItemDatabase")

This makes it easier to immediately see what the issue is by being
able to write informative failure messages.

Thanks to @wiped1 for sharing their patch, upon which this is based.

Closes #17082
 2019-09-11 15:37:11 +02:00
Saracen
cf00f35a8e Allow for constant deceleration to be detected inherited scripts above the immediate parent. 2019-09-11 06:19:20 +01:00
Rémi Verschelde
24e1039eb6
Merge pull request #32045 from neikeq/fix-cannot-create-mono-log-file 
Mono: Fix unable to create log file due to str_format bug
 2019-09-08 22:31:52 +02:00
Ignacio Etcheverry
3dcd7e54f4 Mono: Fix unable to create log file due to str_format bug 2019-09-08 19:40:17 +02:00
Ignacio Roldán Etcheverry
da2af72d73
Merge pull request #32022 from neikeq/fix-mono-export-windows-backslash 
Mono: Fix PCK assembly paths when exporting from Windows
 2019-09-07 21:39:27 +02:00
Ignacio Etcheverry
93897fb884 Fix missing method for internal_MonoWindowsInstallRoot 2019-09-07 02:31:01 +02:00
Ignacio Etcheverry
e439581198 Mono: Fix PCK assembly paths when exporting from Windows 
Assembly paths were written to PCK files with backslash as path separator and PackedData only supports forward slash.
This would make exported games unable to find the assemblies.
 2019-09-07 02:19:25 +02:00
Mitch Curtis
8f5ffeeacc Produce an error when a class has the same name as a Singleton 
If you somehow end up with a Singleton.gd that looks like this:

	extends Node

	class_name Singleton

	func foo():
	    pass

You will get an error when using it in another file:

	extends Node2D

	func _init():
	    # Parser Error: Non-static function "foo" can only be called from an instance.
	    Singleton.foo()

This error is confusing. This patch ensures that an error on the class_name line will be produced:

    Parse Error: The class "Singleton" conflicts with the AutoLoad singleton of the same name, and is therefore redundant. Remove the class_name declaration to fix this error.

Fixes #28187.
 2019-09-06 17:12:43 +02:00
fhuya
7fabfd402f Split the Android platform java logic into an Android library module (lib) and an application module (app). 
The application module `app` serves double duties of providing the prebuilt Godot binaries ('android_debug.apk', 'android_release.apk') and the Godot custom build template ('android_source.zip').
 2019-09-04 16:20:22 -07:00
Michael Alexsander Silva Dias
fd0dace4b5 Small fixes for the Tile/GridMap editors 2019-09-04 16:54:05 -03:00
Michael Alexsander Silva Dias
5f3a55acb7 Add informational messages to various editors 2019-09-04 12:37:11 -03:00
Bojidar Marinov
b397bcf4a1
Run doctool after overridden properties changes 2019-09-04 15:26:08 +03:00
Rémi Verschelde
75cbcb596a
Merge pull request #30982 from iwek7/feature/skip_breakpoints 
Adds skip-breakpoints feature
 2019-09-04 01:31:08 +02:00
Rémi Verschelde
9bd35a5a4b
Merge pull request #31908 from 64epicks/master 
Implemented `ord` function in VisualScript
 2019-09-04 01:19:05 +02:00
Rémi Verschelde
d2900347bf
Merge pull request #31931 from fire/assimp_map_mode 
Assimp map mode is not initialized before use.
 2019-09-03 23:31:42 +02:00
iwek7
617797c47c Adds skip-breakpoints feature 2019-09-03 20:49:09 +02:00
K. S. Ernest (iFire) Lee
1094522d76 Assimp map mode is not initialized before use. 2019-09-03 10:11:03 -07:00
64epicks
e430f8ca61 Implemented ord function in VisualScript 2019-09-03 17:06:11 +02:00
MrCdK
9e9c16c1e5 Try and show all the properties added with _get_property_list() when triggering completion. 
Closes https://github.com/godotengine/godot/issues/25097
 2019-09-03 14:27:27 +02:00
Rémi Verschelde
40a9cc66a9
Merge pull request #31871 from aaronfranke/equal-approx-inf 
Check for exact equality before approximate equality
 2019-09-03 12:00:56 +02:00
Bojidar Marinov
3ca7b4ee45
Fix uninitialized arrays and dictionaries retaining value 
Fixes #28978
 2019-09-03 10:39:04 +03:00
Rémi Verschelde
10b040ab20
Merge pull request #31893 from bojidar-bg/25081-gdscript-index-self 
Re-allow indexing on objects and other non-builtin types
 2019-09-02 20:25:14 +02:00
Rémi Verschelde
85955c5f25
Merge pull request #31843 from 2shady4u/parserCtrlClick 
Solves ctrl+click on functions by ignoring the cursor
 2019-09-02 19:56:35 +02:00
Bojidar Marinov
e3d05fa42d
Re-allow indexing on "self" and object types in GDScript 
Fixes #25081
 2019-09-02 20:18:15 +03:00
Rémi Verschelde
eb38bc6c0a gdscript: Fix build after #24925 
The PR did not use the ScriptCodeCompletionOption system introduced
later on, and somehow this did not generate a merge conflict even
though neighboring code was changed.
 2019-09-02 16:31:43 +02:00
Rémi Verschelde
877912b23c
Merge pull request #24925 from Mr-Slurpy/typed-autoload 
Added autoloads as a potential type.
 2019-09-02 16:05:05 +02:00
Rémi Verschelde
d767edb9b3
Merge pull request #21443 from deepmax/ord_function 
Add ord() function to return Unicode code point of a string of length one
 2019-09-02 15:28:15 +02:00
shaderbeast
dbd253d7a2 Solves ctrl+click on functions by ignoring the cursor 
Obeyed CLANG format rules


Obeying CLANG format rules attempt 2


Obeying CLANG format rules attempt 3


Clean up


Fixed runaway while loop


Removed int initialization
 2019-09-02 13:46:38 +02:00
Hugo Locurcio
7e01986ce1
Make JSONRPC constants uppercase for consistency with other classes 2019-09-01 23:48:38 +02:00
Rémi Verschelde
7dceba3afc
Merge pull request #31587 from RevoluPowered/feature/fbx-importer 
FBX Importer
 2019-09-01 22:14:17 +02:00
Gordon MacPherson
ad214c0356 Assimp FBX Import support 
Issues fixed:
- Updated assimp to latest and backported fixes into godot.
- Fixed file scale being ignored from FBX file.
- Fixed bone removal
- Implemented proper armature binding
- Fixed recursion not always going through the entire path
- Implemented assimp global scaling system
- Fixed assimp global scale process to support unit conversion
- Implemented proper fbx scaling
- Fixed asserts caused by missing faces in some models which could crash
- Fixed valid bone removal
- Fixed root node being overwriten by assimp which caused data loss
- Fixed armature construction so that it works with multiple roots
- Implemented basic support for FBX standard materials
- Refactoring to improve code quality and improve function reuse.
- Simplified node creation from assimp scene into subsections: create_light, create_mesh, create_bone.
- Creating meshes is now done after hierarchy is created so that the skeleton is always available.
- Added support to assimp to support file scale in all formats which call SetFileScale.
- Many other fixes provided into assimp.

Known issues:
- FBX pivots from Maya do not currently work. (workaround: for now use blender import and export to remove pivot tracks)
- Hierarchy creates an extra node for each mesh - this was done intentionally but we intended to do a pass to remove these as they're a required node.
- When an animated mesh has not executed any animation the rest pose is wrong.

Co-authored-by: K. S. Ernest (iFire) Lee <ernest.lee@chibifire.com>
 2019-09-01 19:08:34 +01:00
Aaron Franke
f8b4cf0fc4
Check for exact equality before approximate equality 2019-09-01 14:02:14 -04:00
Chaosus89
8fd8589547 Fix resizer icon visiblity on light theme in GraphNode 2019-09-01 09:12:26 +03:00
Ignacio Etcheverry
5a6070dde3 Mono: Force preemptive thread suspend mode as a temporary workaround 2019-08-30 01:33:50 +02:00
Rémi Verschelde
a5e0aa32d9
Merge pull request #31770 from neikeq/supercedes-31008 
Fix GodotTools.ProjectEditor HintPaths for referenced packages
 2019-08-29 21:16:49 +02:00
Ignacio Etcheverry
6d2883c9bf Fix GodotTools.ProjectEditor HintPaths for referenced packages 2019-08-29 18:19:01 +02:00
Rémi Verschelde
65d61d0360 doc: Sync classref with current source 2019-08-29 15:33:52 +02:00
Thomas Karcher
02ed79f7f7
Updated description for "stepify" 
Mentioned the possibility to use stepify as a rounding function; +code examples
 2019-08-29 14:03:18 +02:00
Rémi Verschelde
b97169740e
Merge pull request #31741 from akien-mga/lsp-requires-websocket-jsonrpc 
GDScript: Disable LSP if either jsonrpc or websocket are disabled
 2019-08-29 08:37:40 +02:00
Rémi Verschelde
7995ce03f3
Merge pull request #31738 from bojidar-bg/31056-class_name-extends 
Remove check for class_name and extends order
 2019-08-29 08:33:51 +02:00
Rémi Verschelde
65d1b0b427
Merge pull request #31729 from aaronfranke/mono-color 
[Mono] Various Color fixes and improvements
 2019-08-28 21:29:47 +02:00
Masoud Montazeri
5565f5591f Add ord() function to return Unicode code point of a string of length one 2019-08-28 16:14:11 +02:00
Rémi Verschelde
4a6b445a93
Merge pull request #31728 from fire/improve-uvatlas 
Tweak xatlas and import new version b4b5426
 2019-08-28 15:46:58 +02:00
Rémi Verschelde
b791efdb16
Merge pull request #31737 from bojidar-bg/31455-stack-underflow 
Fix yield check in GDScriptFunction
 2019-08-28 15:36:08 +02:00
Rémi Verschelde
4aed4b44b6
Merge pull request #31454 from lliberadzki/gridmap-navmesh-baking 
Support baking gridmap navmesh.
 2019-08-28 15:29:54 +02:00
Rémi Verschelde
b994124df3 GDScript: Disable LSP if either jsonrpc or websocket are disabled 
Follow-up to #29780.
 2019-08-28 13:29:37 +02:00
Rémi Verschelde
46ad60385b
Merge pull request #29780 from GodotExplorer/gdscript-lsp 
Add Language Server Protocol for GDScript
 2019-08-28 13:06:51 +02:00
Bojidar Marinov
b70b16a20f
Remove check for class_name and extends order 
Closes #31056
 2019-08-28 12:05:21 +03:00
Bojidar Marinov
112aa6e367
Fix yield check in GDScriptFunction 
Fixes #31455
 2019-08-28 11:15:43 +03:00
K. S. Ernest Lee
c3c805aff8 Tweak xatlas and import new version b4b5426 
* Avoid xatlas crash
* Enable alignment and disable bruteforce for speedups
* Update xatlas to b4b5426
* Delete old patches
 2019-08-28 01:12:56 -07:00
Rémi Verschelde
538328898b Style: Fix copyright headers in new files 2019-08-28 09:19:52 +02:00
Rémi Verschelde
185072015f
Merge pull request #31606 from toasteater/fix/nativescript-new-json-return-type 
Fix the return type of NativeScript::new in API json
 2019-08-28 09:15:40 +02:00
Michael Alexsander Silva Dias
a8826ad3b8 Make 'break' and 'continue' be marked as safe 2019-08-27 23:10:33 -03:00
Aaron Franke
34ab6549b1
[Mono] Various Color improvements 
I also slid in a fix to C++ Vector3 > and >=
 2019-08-27 22:05:18 -04:00
Rémi Verschelde
92ead83913 Mono: Fix OSX build due to invalid function call 2019-08-27 09:48:54 +02:00
Rémi Verschelde
1cea44de19
Merge pull request #31607 from Calinou/improve-gdscript-messages 
Improve writing style in GDScript error/warning messages
 2019-08-26 21:58:33 +02:00
toasteater
e2121c97ae Make VarArg methods return types show up as Variant in API json 
VarArg methods have the return type Object in the API json for GDNative. This
can cause undefined behavior in some language bindings due to lack of
documentation on VarArg methods' behavior.

This changes the MethodInfo of:

- CSharpScript::_new
- GDScript::_new
- PluginScript::_new
 2019-08-26 16:36:51 +00:00
Ignacio Roldán Etcheverry
be99e7b68f
Merge pull request #31680 from neikeq/fix-android-gen-sources 
Fix 'android_mono_config.gen.cpp' not compiled first time it's generated
 2019-08-26 18:28:12 +02:00
Ignacio Etcheverry
aa805e2699 Fix 'android_mono_config.gen.cpp' not compiled first time it's generated 2019-08-26 17:46:57 +02:00
Rémi Verschelde
57afa90f0c
Merge pull request #31652 from Calinou/csharp-alpha-dialog-android 
Mention Android support in the C# alpha dialog message
 2019-08-26 10:18:27 +02:00
Ignacio Etcheverry
3af8bd071e Set C# 7 as LangVersion for GodotTools and Godot API projects 
This will make it harder for someone to accidentally commit code that requires a newer version.
 2019-08-25 15:53:47 +02:00
Hugo Locurcio
27f5ab2d7b
Mention Android support in the C# alpha dialog message 2019-08-25 15:08:32 +02:00
lamonte
1df0e88ae8 default is only supported by 7.1, reverted to support 7.0 out of the box (no conflict) 2019-08-25 06:48:37 -05:00
Hugo Locurcio
a4794af5df
Improve writing style in GDScript error/warning messages 
This uses double quotes everywhere for consistency.
 2019-08-23 20:55:50 +02:00
Rémi Verschelde
51d50e167d
Merge pull request #31094 from aaronfranke/vector-sign-mod-etc 
Add Vector2/3 sign and posmod functions, axis, docs, misc additions
 2019-08-23 09:07:47 +02:00
Rémi Verschelde
ccf294b92f
Merge pull request #31566 from Faless/ssl/fix_custom_cert 
Fix StreamPeerSSL connect_to_stream w/ custom cert.
 2019-08-22 20:44:20 +02:00
Fabio Alessandrelli
17d5b471b9 Better error handling in SSLContext, Crypto 2019-08-22 16:49:11 +02:00
Fabio Alessandrelli
99f657d89f Fix StreamPeerSSL connect_to_stream w/ custom cert 
Follow up on #29871.
Was checking the wrong parameter, causing the code to ignore provided
stream-specific SSL certificate.
 2019-08-22 16:42:37 +02:00
Ignacio Etcheverry
dae2a335c5 Make sure '.mono/metadata/' exists before creating file 
Fixes #31549
 2019-08-22 14:32:55 +02:00
Fabio Alessandrelli
b223b207c4 Fix regression in StreamPeerSSL 
Validate that base stream is valid before accepting/connecting.
Also remove unnecessary includes.
 2019-08-22 00:14:01 +02:00
Rémi Verschelde
22df2b79b6
Merge pull request #30851 from TheDevelo/webrtc-buffer 
Allow setting buffer size of WebRTCDataChannel
 2019-08-21 21:17:48 +02:00
Robert Fuchs
5f9ed1979d Allow setting buffer size of WebRTCDataChannel 2019-08-21 13:27:56 -05:00
Rémi Verschelde
99980d856b
Merge pull request #29871 from Faless/crypto/initial_pr 
More Crypto, SSL server, crt/key as Resource, HashingContext
 2019-08-21 18:03:03 +02:00
Fabio Alessandrelli
ce5a3f56a6 Rewrite StreamPeerSSL with SSLContext helper class 
connect_to_stream now accepts optional parameter to specify which
certificates to trust.
Implement accept_stream (SSL server) with key/cert parameters to specify
the RSA key and X509 certificate resources.
 2019-08-21 16:59:38 +02:00
Fabio Alessandrelli
dd8107caa4 New CryptoMbedTLS Crypto implementation. 
Allows random bytes, RSA keys, and X509 certificates generation.
 2019-08-21 16:59:38 +02:00
Rémi Verschelde
a8db4c848d
Merge pull request #31395 from ptrojahn/floatsarenasty 
Replace is_zero_approx(A.distance_to(B)) with A==B
 2019-08-20 12:54:40 +02:00
Rémi Verschelde
f2c9252b6e
Merge pull request #31483 from Faless/ws/fix_double_relay 
Fix WebSocketServer relaying message twice.
 2019-08-20 12:49:15 +02:00
Fabio Alessandrelli
d1539db2c6 Fix WebSocketServer relaying message 2 times. 
The WebSocketMultiplayerPeer was relaying the same message two times,
both in _server_relay and _process_multiplayer (which was only supposed
to store the packet, given the server was one of the destination).

_process_multiplayer now only store the packet, and calls _server_relay
which will relay the message to other clients if needed.
 2019-08-19 18:18:13 +02:00
Paul Trojahn
7c9c6df7e4 Replace is_zero_approx(A.distance_to(B)) with A==B 
Related to #22988 (Fixes the holes in the shape of
the first comment)
 2019-08-19 18:16:58 +02:00
Fabio Alessandrelli
17be67b8c7 WebSocketServer now sanitize destination peers. 
When relaying messages in multiplayer mode.
Could cause a crash in case a malicious client sends a bogus packet and
for those cases where a peer has just disconnected and a message arrive
from another peer with the disconnected one as destination.
 2019-08-19 17:26:07 +02:00
Fabio Alessandrelli
c19871af6d Move CryptoCore to it's own folder. 
Crypto classes will be placed in core/crypto.
 2019-08-19 16:31:05 +02:00
lukasz.liberadzki
82acd436b4 Baking gridmap navmesh. 2019-08-18 13:24:58 +02:00
Aaron Franke
092346d82b
Add Vector2/3 sign and posmod functions, misc additions 
Also make the docs more consistent, add Axis enum to Vector2, add > and >=. and C# also gets % and an override for vector-vector mod.
 2019-08-17 18:31:55 -04:00
Rémi Verschelde
d3153c28f0 Replace last occurrences of 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' 
The last remaining ERR_EXPLAIN call is in FreeType code and makes sense as is
(conditionally defines the error message).

There are a few ERR_EXPLAINC calls for C-strings where String is not included
which can stay as is to avoid adding additional _MSGC macros just for that.

Part of #31244.
 2019-08-17 13:31:22 +02:00
Rémi Verschelde
188a10df8b
Merge pull request #31263 from Chaosus/vs_plugin 
Plugin support for visual shaders
 2019-08-14 15:52:21 +02:00
Yuri Roubinski
33e9fce1bb Plugin support for visual shaders 2019-08-14 15:52:27 +03:00
Rémi Verschelde
6c607c3564
Merge pull request #31266 from IAmActuallyCthulhu/pr/remove-redundant-author-comments 
Remove redundant author doc comments
 2019-08-14 13:45:54 +02:00
Rémi Verschelde
8995d95da0
Merge pull request #31347 from neikeq/monodevelop-addin 
C#: Add Ide Connection library and server for the editor
 2019-08-14 11:39:41 +02:00
Rémi Verschelde
f8574da2c2
Merge pull request #31338 from Calinou/reorganize-menus 
Reorganize various menus for consistency and conciseness
 2019-08-13 16:52:42 +02:00
Rémi Verschelde
5f1dce4354
Merge pull request #31336 from Calinou/scons-libs-use-lists 
Always use lists for `LIBS` in SCons
 2019-08-13 12:32:57 +02:00
Hugo Locurcio
9e1c23a353
Reorganize various menus for consistency and conciseness 
- Clean up the recent scripts dialog to match the recent scenes dialog
- Add "..." at the end of shortcuts that cause a modal dialog to appear

This closes #31148.
 2019-08-13 11:52:10 +02:00
Rémi Verschelde
4403744ef9
Merge pull request #31335 from Xenoamor/bugfix/GridMapListTextCutoff 
Fix GridMap list text not expanding when palette is resized
 2019-08-13 08:32:48 +02:00
Hugo Locurcio
05daf5c78b
Always use lists for LIBS in SCons 
This closes #31288.
 2019-08-12 22:31:55 +02:00
Xenoamor
69438149f5
Fix GridMap list text not expanding when palette is resized 
This is to close #31304
 2019-08-12 21:14:20 +01:00
Ignacio Etcheverry
bda461c2b1 Add C# language editor icon 2019-08-12 18:57:26 +02:00
Ignacio Roldán Etcheverry
3c78837218
Merge pull request #31322 from neikeq/mono-gitignore-override-sln 
Make git no longer ignore solution files inside the mono module
 2019-08-12 16:50:18 +02:00
Ignacio Etcheverry
33c0d47273 Make git no longer ignore solution files inside the mono module 2019-08-12 15:59:06 +02:00
Rémi Verschelde
37a16fee05 Export: Remove temp files from cache after export 
So far we left most temporary files lying around, so this attempts to
fix that.

I added a helper method to DirAccess to factor out the boilerplate of
creating a DirAccess, checking if the file exists, remove it or print
an error on failure.
 2019-08-12 13:31:59 +02:00
Rémi Verschelde
5441aaf768
Merge pull request #31228 from aaronfranke/identity-constants 
Add Basis constants and format Transform constants
 2019-08-12 12:42:30 +02:00
Rémi Verschelde
b1de92fbdf
Merge pull request #31314 from BastiaanOlij/fix_api_struct_gen 
Fix self reference issue in core structures for GDNative plugins
 2019-08-12 11:45:33 +02:00
IAmActuallyCthulhu
82b9557803
Remove redundant author doc comments 2019-08-12 04:26:38 -05:00
Bastiaan Olij
bf9a97c2cb Fix self reference issue in core structures for GDNative plugins 2019-08-12 19:21:32 +10:00
Robin Hübner
8aeade74db Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in rest of 'modules/' 2019-08-12 10:15:54 +02:00
geequlim
e5b91a15e6 Improve code compeletion for virtual methods with signatures 2019-08-11 14:06:39 +08:00
geequlim
72d11cd173 Add optional goto definition support for native symbols 
This action will show help for target symbol in godot editor and bring the godot editor window to foreground
Improved markdown documentation for symbols.
 2019-08-11 13:30:15 +08:00
Geequlim
666ed89011 Add generate script api to dictionary support 
Expose GDScriptLanguageProtocol singleton and classes for editor plugins (Not visiable in class tree)
Fix minor bug in symbol resolve
 2019-08-11 13:30:15 +08:00
Geequlim
9618b0c63e Check client workspace directory is valid 
Drop test initialize message sent to client
Remove unused code property for the parser class
 2019-08-11 13:30:15 +08:00
Geequlim
b2f02317fa Improve symbol resolve for inner classes 
Only level one inner classes would be resolved currently but it sould cover most real world use case
Improve documation parseing for const values
Improve documation format for native symbols
 2019-08-11 13:30:15 +08:00
Geequlim
76c9e4ceb7 Improved performance for completion and symbol resolvation. 
Improved uri and workspace path translatation on windows platform.
The smart resolvation is much faster than builtin's in the server side.
The smart resolve mode is still disabled as default as the clients might be slow with a planty of completion items.
 2019-08-11 13:30:15 +08:00
geequlim
fa6d6a329c Add optional smart resolve sulotion 
The smart resolvaion can guess most symbols but it might be slow so disabled by default users can turn on it in the editor setting
 2019-08-11 13:30:15 +08:00
geequlim
37aafaaa9c Add a symbol pool to cache all native symbols and workspackes symbols. 
Implement hover
Implement completion documentation resolve
Implement hover documentation
Implement go to definition
 2019-08-11 13:30:15 +08:00
geequlim
f58560ac36 Add GDScript Language Protocol plugin 2019-08-11 13:30:15 +08:00
geequlim
61ed6efa5b Add JSONRPC-2.0 implementation as a module 2019-08-11 13:30:15 +08:00
Aaron Franke
85f13a0d24
Add Basis constants and format Transform constants 2019-08-09 11:34:54 -07:00
Rémi Verschelde
3ea33c0e45
Merge pull request #31221 from neikeq/err-explain-to-msg-mono 
Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in 'modules/mono'
 2019-08-09 12:40:05 +02:00
Rémi Verschelde
80c7cb6378
Merge pull request #31227 from profan/fix/err-explain-usages 
Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in "platform", "modules/gdnative", "modules/gdscript" directories.
 2019-08-09 12:28:06 +02:00
Ignacio Etcheverry
c55ce204b3 Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in 'modules/mono' 
And 'CRASH_*_MSG' as well.

Also make error messages puntuation and quotation more consistent.
 2019-08-09 12:13:21 +02:00
Robin Hübner
6ab118c464 Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in "platform", "modules/gdnative", "modules/gdscript" directories. 2019-08-09 11:13:24 +02:00
Cameron Reikes
2339e85b78 Expression before 'is' may be null 2019-08-09 01:24:03 -07:00
Rémi Verschelde
1d5ae6da5b
Merge pull request #31047 from Zylann/save_exr 
Add Image.save_exr()
 2019-08-08 08:53:02 +02:00
Aaron Franke
50fd2deede
[Mono] Make all structs seralizable 2019-08-07 18:34:52 -07:00
Marc Gilleron
cd2de77b04 Add Image.save_exr() 2019-08-07 21:17:47 +01:00
Rémi Verschelde
ba541bceca
Merge pull request #31077 from qarmin/coverity_bugs 
Change some code proposed by Coverity and Cppcheck
 2019-08-07 13:49:33 +02:00
qarmin
e0b5b21863 Add some code changes/fixes proposed by Coverity and Clang Tidy 2019-08-07 12:54:30 +02:00
PouleyKetchoupp
189e4e59ad Fixed KinematicCollision.get_local_shape() - the local shape id was never set during move_and_collide() 
Fixes #31144
 2019-08-07 12:32:32 +02:00
Rémi Verschelde
45be9c67ef
Merge pull request #31091 from aaronfranke/wrap 
Optimize Wrap functions
 2019-08-05 09:55:57 +02:00
Rémi Verschelde
be3b2f3ff9
Merge pull request #31041 from 2shady4u/master 
Mark class_name line as safe in editor
 2019-08-05 08:05:49 +02:00
Aaron Franke
a9c10450bd
[Core] [Mono] Optimize Wrap functions 
Use is_zero_approx(), avoid a negative, and also rename "rng" to "range".
 2019-08-04 20:38:38 -07:00
Ignacio Roldán Etcheverry
7126654eaf
Merge pull request #31068 from neikeq/issue-31065 
C#: Fix Color.ToHtml()
 2019-08-04 08:53:52 +02:00
Ignacio Etcheverry
57fe284fe6 C#: Fix Color.ToHtml() 2019-08-04 05:04:39 +02:00
Ignacio Etcheverry
0b94203a79 C#: Add Ide Connection library and server for the editor 
This will be used for communicating between the Godot editor and external IDEs/editors, for things like opening files, triggering hot-reload and running the game with a debugger attached.
 2019-08-04 01:57:53 +02:00
shaderbeast
1e6a52b215 Mark class_name line as safe in editor 2019-08-02 20:07:54 +02:00
Emmanuel Barroga
5c447cecd2 Add descriptive tooltips in VS editor 
In the Visual Script editor, the override icon is not very clear what it's intended purpose is for. Currently, its tooltip just says: "Function:" which is the same tooltip as the "add new function" icon.

To resolve this issue, this PR adds descriptive tooltips to the following icons in the Visual Script editor: 
-Override Function
-Add Function
-Add Variable
-Add Signal
 2019-07-31 20:10:19 -07:00
RevoluPowered
243f400ee2 Updated assimp to commit 1d565b0 with iFire 
Signed-off-by: RevoluPowered <gordon@gordonite.tech>
Signed-off-by: K. S. Ernest (iFIre) Lee <ernest.lee@chibifire.com>
 2019-07-30 18:59:29 +01:00
Rémi Verschelde
d15090e275
Merge pull request #30909 from Kaligule/patch-1 
Add a reference to pow to the description of exp.
 2019-07-30 00:06:30 +02:00
Rémi Verschelde
adffd9aaef
Merge pull request #30935 from YeldhamDev/gdnative_plugin_fix 
Fix 'GDNativeLibrary' editor being incorrectly opened
 2019-07-29 21:38:37 +02:00
Rémi Verschelde
baa1d0c3d0
Merge pull request #30923 from NilsIrl/better_dropdown 
Improve platform selection in the GDNativeLibrary dock
 2019-07-29 21:38:21 +02:00
Michael Alexsander Silva Dias
147990cb6d Fix 'GDNativeLibrary' editor being incorrectly opened 2019-07-29 15:05:49 -03:00
Rémi Verschelde
b90ef52ece Find trailing whitespace and indentation in gdnative_api.json 2019-07-29 18:48:21 +02:00
Kaligule
a2c81a7455 Add a reference to pow to the description of exp. 
This might be especially usefull since godot script doesn't support ** or ^ as operators, so beginners might search for the exponential function, when what they really need is the pow function.

This is exactly what happened to me and since I couldn't find helpfull information in the documentation I had to look it up online, where I found the answer on a helpfull [reddit thread](https://www.reddit.com/r/godot/comments/3mvwz0/how_do_i_do_exponents_in_godot/).

@akien-mga told me how to reference methods here:
godotengine#30909
 2019-07-29 18:17:52 +02:00
NilsIrl
d69409338b Improve platform selection in the GDNativeLibrary dock 
* Replace button text with currently selected platforms
* Expand button size horizontally
 2019-07-29 14:54:08 +02:00
Rémi Verschelde
d06da7193d
Merge pull request #30869 from NilsIrl/#30841 
Replace radion buttons with checkboxes in GDNativeLibrary editor
 2019-07-29 10:11:56 +02:00
Aaron Franke
7dbbb5eac7
[Mono] Deprecate Set methods 
These silently fail, so they should be removed. I accidentally added most of these last year, trying to make everything else consistent with Quat, sorry!

Also, a few tiny nitpicking changes are included, like whitespace and misspellings.
 2019-07-28 17:49:22 -04:00
Fabio Alessandrelli
d6c9b377b9 Fix WebSocketClient crash when unref during signal 
Always call disconnect before emitting signals, to avoid calling it on a
freed object if the user decides to unreference it in a signal.
 2019-07-28 15:23:20 +02:00
NilsIrl
ba63e0a5a2 Replace radion buttons with checkboxes in GDNativeLibrary editor 2019-07-27 16:46:14 +02:00
Rémi Verschelde
1107799de5
Merge pull request #30849 from bojidar-bg/7898-mixed-indentation 
Disallow using of both tabs and spaces for indentation in the same file
 2019-07-27 10:48:31 +02:00
Ignacio Etcheverry
d54df7b904 C#: Fix Transform2D.AffineInverse() 2019-07-27 02:15:29 +02:00
Bojidar Marinov
f12f3cf726
Disallow using of both tabs and spaces for indentation in the same file 
Closes #7898
 2019-07-26 21:24:34 +03:00
Rémi Verschelde
140e7e5edf
Merge pull request #30788 from Chaosus/direction_to_gdnative 
Added Vector2/3.direction_to methods to GDNative
 2019-07-26 18:58:25 +02:00
Ignacio Roldán Etcheverry
6697ad2c4f
Merge pull request #30842 from neikeq/fix-custom-props-msbuild 
Mono: Fix custom defines for Mono's MSBuild; remove xbuild
 2019-07-26 18:33:52 +02:00
Ignacio Etcheverry
8821569689 Mono: Fix custom defines for Mono's MSBuild; remove xbuild 
Mono's MSBuild and System/VisualStudio's MSBuild expect a different format for surrounding property values with quotes on the command line.

xbuild does not seem to support semicolons in property values from the command line: https://xamarin.github.io/bugzilla-archives/16/16465/bug.html
It's a good time to just remove xbuild support entirely.
 2019-07-26 17:17:17 +02:00
Ignacio Roldán Etcheverry
a82420fbe8
Merge pull request #30825 from neikeq/heya 
Fix incorrectly updating csproj and not closing build issues file
 2019-07-26 16:54:11 +02:00
Ignacio Etcheverry
4e84478f4e Fix incorrectly updating csproj and not closing build issues file 2019-07-25 21:06:40 +02:00
Ignacio Roldán Etcheverry
3a68b24171
Merge pull request #30820 from neikeq/issue-28394 
Mono: Don't try to update project assemblies from project manager
 2019-07-25 19:00:10 +02:00
Ignacio Etcheverry
c9befa63d2 Mono: Don't try to update project assemblies from project manager 
Previously, when running the project manager, we would try to load the API assemblies from the project and fail because we were not editing any project. This would make us try to copy the prebuilt API assemblies to the project. Since there is no project, it would try to copy them to the executable location. This would fail if Godot doesn't have permissions to write to that location.
This commit fixes that by instead trying to load the prebuilt API assemblies in the first place, if running the project manager.
 2019-07-25 17:52:45 +02:00
Rémi Verschelde
1481d299ea
Merge pull request #30776 from akien-mga/editor-configurable-float-step 
Inspector: Make default float step configurable
 2019-07-25 10:33:45 +02:00
Rémi Verschelde
336846e547 Inspector: Fix PROPERTY_HINT_SPRITE_FRAME not behaving as RANGE 
This was a regression in 3.1 and later from the new inspector, where
PROPERTY_HINT_SPRITE_FRAME was not fully re-implemented. It's meant to
be a normal PROPERTY_HINT_RANGE which also automatically increments its
value when keyed in the animation player.

To avoid code duplication, I made the frames properties use the actual
PROPERTY_HINT_RANGE and introduced a PROPERTY_USAGE_KEYING_INCREMENTS
usage flag instead.
 2019-07-25 09:29:51 +02:00
Ignacio Etcheverry
c0cdbb7938 Mono: Fix regression: external editors not working on Windows 2019-07-24 23:19:24 +02:00
Ignacio Etcheverry
513cc78f85 Mono: Add option to keep running after unhandled exceptions 
By default, an unhandled exception will cause the application to be terminated; but the project setting `mono/unhandled_exception_policy` was added to change this behaviour.
The editor is hard-coded to never terminate because of unhandled exceptions, as that would make writing editor plugins a painful task, and we cannot kill the editor because of a mistake in a thirdparty plugin.
 2019-07-24 23:19:15 +02:00
Chaosus
bf237f651c Added direction_to to GDNative 2019-07-24 11:16:20 +03:00
Rémi Verschelde
aa062c54fc
Merge pull request #25090 from Chaosus/string_count 
Added String.count method
 2019-07-24 08:32:42 +02:00
Michael Alexsander Silva Dias
12ae7a4c02 Update some dead links in the codebase 2019-07-23 21:06:12 -03:00
Chaosus
080c0bb7fe Added count method to String 2019-07-23 18:55:54 +03:00
Rémi Verschelde
d844e30614 Inspector: Make default float step configurable 
Also allow lifting the decimal step formatting with a hint range step
of 0. A new `range_step_decimals()` is added for this to avoid breaking
compatibility on the general purpose `step_decimals()` (which still
returns 0 for an input step of 0).

Supersedes #25470.
Partial fix for #18251.
 2019-07-23 17:31:38 +02:00
Rémi Verschelde
4c943cca2c
Merge pull request #30716 from qarmin/fixed_static_analiser_code 
Fix some code found by Coverity Scan and PVS Studio
 2019-07-23 15:08:44 +02:00
qarmin
aab8da25ad Fix some code found by Coverity Scan and PVS Studio 2019-07-23 09:14:31 +02:00
Rémi Verschelde
77724fde60 Fix type mismatch in iOS interface orientation checks 
Not sure why this error popped up when I enabled C++11 on the codebase,
but I guess this should fix it.
 2019-07-22 20:31:15 +02:00
Rémi Verschelde
5dae2ea777 SCons: Enable C++11 on the whole codebase 
**Important:** This does not mean *yet* that C++11 features should be used
in contributions to Godot's codebase.

For now this change is done solely for feature branches working on Vulkan
support and GDScript typed instruction sets for Godot 4.0, which will both
use C++11 features and are based on the master branch.

The plan is to start porting the codebase to C++11 after Godot 3.2 is
released, following upcoming guidelines on the subset of new features that
should be used, and when/how to use them.

We will advertise clearly when C++11 contributions are open, especially
once we start a coordinated effort to port Godot's massive codebase. In the
meantime, please bear with us and good ol' C++03. :)
 2019-07-22 17:17:30 +02:00
Rémi Verschelde
66d09a6b4c SCons: Fix uses of [].append instead of env.add_source_files() 
Also added support for SCons project-absolute paths (starting with #) and
warning about duplicates in add_source_files(), and fixed
default_controller_mappings.gen.cpp being included twice after first build
due to *.cpp globbing.

Part of #30270.
 2019-07-22 15:08:32 +02:00
Rémi Verschelde
07e289963c doc: Sync classref with current source 2019-07-22 12:27:52 +02:00
Ignacio Etcheverry
0197d86ab4 Mono: Fix editor API assembly not being updated 
If both the core and editor API assemblies are missing or out of sync, Godot will only update the former and then abort when trying to load them again because the latter was not updated. Godot will update it correctly the next time it's started, but this should not be needed and it should work the first time. This commit fixes that.
 2019-07-22 00:16:24 +02:00
Ignacio Roldán Etcheverry
4379395892
Merge pull request #30710 from neikeq/issue-30526 
Fix mono module build errors for release templates
 2019-07-20 16:20:49 +02:00
Ignacio Etcheverry
ec679dfffa Fix mono module build errors for release templates 2019-07-20 15:52:26 +02:00
Rémi Verschelde
60efd67034
Merge pull request #30693 from Chaosus/lerp_angle 
Added lerp_angle built-in function
 2019-07-20 13:37:13 +02:00
Rémi Verschelde
e466dc2daa
Merge pull request #30698 from Anutrix/assimp-pass-by-ref 
Changed large const string values to const string ref in some assimp functions
 2019-07-20 12:06:58 +02:00
Rémi Verschelde
d15cf7b672
Merge pull request #30576 from qarmin/lgtm_coverage 
Changed some code reported by LGTM and Coverity
 2019-07-20 12:00:13 +02:00
Chaosus
6694c119d0 Added lerp_angles built-in function 
Co-authored-by: Xrayez <https://github.com/Xrayez>
Co-authored-by: DleanJeans <https://github.com/DleanJeans>
 2019-07-20 12:59:41 +03:00
qarmin
6cbaf7662f Changed some code showed in LGTM and Coverage 2019-07-20 08:09:57 +02:00
unknown
1b4d3f7d56 Changed large const string values to string ref in some assimp functions 2019-07-20 00:53:21 +05:30
Ivan Hilaire
5d88f74677 Remove added pluginscript resource format loaders and savers on cleanup 
Properly release added resource loader and save references. Otherwise PluginScript API
may cause "ObjectDB Instances still exist!" warnings and segmentation faults on exit.
 2019-07-19 22:13:44 +03:00
Rémi Verschelde
f796779f7c
Merge pull request #23310 from aaronfranke/posmod-int 
Add integer posmod and rename default arg names
 2019-07-19 15:07:49 +02:00
K. S. Ernest (iFIre) Lee
bdf54a7f9e Visualscript: Add types for base type get and set. 2019-07-19 00:04:46 -07:00
Aaron Franke
a60f242982 Add integer posmod and rename default arg names 
"posmod" is the integer version of "fposmod". We do not need a "mod" because of the % operator.

I changed the default arg names from "x" and "y" to "a" and "b" because they are not coordinates. I also changed pow's arg names to "base" and "exp". Also, I reorganized the code in the VS built-in funcs switch statement.
 2019-07-18 16:33:43 -04:00
Rémi Verschelde
950153757b
Merge pull request #30648 from NilsIrl/useless_casts 
Remove useless casts to String
 2019-07-18 09:34:55 +02:00
Bojidar Marinov
8336590154
Fix stack underflows when yielding twice 
Also, refactor GDScriptFunctionState::_signal_callback, removing some excessive repetition.
Fixes #30269.
 2019-07-17 23:48:49 +03:00
Andrii Doroshenko (Xrayez)
422a8ffe02 Fix BMP loader to distinguish between compression types 
Some of the values in compression enumeration represent uncompressed formats:

https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-wmf/4e588f70-bd92-4a6f-b77f-35d0feaf7a57

This allows the loader to proceed with uncompressed formats.
Note that loading compressed BMP's is still not supported.
 2019-07-17 20:28:35 +03:00
Nils ANDRÉ-CHANG
074115338e Remove useless casts to String 2019-07-17 11:31:42 +01:00
Andrii Doroshenko (Xrayez)
d5c5aabbf2 Fix BMP loader incorrectly interpreting color table size 
Color table should exist for images with bit count <= 8. Importing 16-bit
BMP images could also likely have a color table but they're not currently
supported in Godot.
 2019-07-17 01:43:33 +03:00
Rémi Verschelde
7b1ee28a03
Merge pull request #30567 from NilsIrl/static_func_inside_class 
Show static functions inside classes in method list
 2019-07-16 08:53:02 +02:00
Rémi Verschelde
efd55631e2 doc: Sync classref with current source 2019-07-15 20:45:30 +02:00
Nils ANDRÉ-CHANG
9e3455cb1e Show static functions inside classes in method list 2019-07-15 17:16:57 +01:00
Rémi Verschelde
75f2575f28
Merge pull request #30552 from kawa-yoiko/match-unreachable 
Fix unreachable code detection in match statements
 2019-07-15 08:13:57 +02:00
Ignacio Roldán Etcheverry
7f3490c5e1
Merge pull request #30584 from neikeq/yatta 
Mono: Better handling of missing/outdated API assemblies
 2019-07-14 19:39:26 +02:00
Ignacio Etcheverry
e59ac40712 Mono: Better handling of missing/outdated API assemblies 
Remove the old API assembly invalidation system. It's pretty simple since now the editor has a hard dependency on the API assemblies and SCons takes care of prebuilding them.
If we fail to load a project's API assembly because it was either missing or outdated, we just copy the prebuilt assemblies to the project and try again. We also do this when creating the solution and before building, just in case the user removed them from the disk after they were loaded.
This way the API assemblies will be always loaded successfully. If they are not, it's a bug.

Also fixed:

- EditorDef was behaving like GlobalDef in GodotTools.
- NullReferenceException because we can't serialize System.WeakReference yet. Use Godot.WeakRef in the mean time.
 2019-07-14 19:17:07 +02:00
Shiqing
206d515783 Fix unreachable code detection in match statements 2019-07-13 19:31:49 +08:00
Rémi Verschelde
eb98c5e047
Merge pull request #30129 from fire/xatlas_update 
[WIP] Update xatlas to latest upstream commit (1efe581).
 2019-07-11 19:44:55 +02:00
unknown
f236b460e5 Some small fixes to warnings in python scripts 2019-07-11 22:26:04 +05:30
Ignacio Etcheverry
4061e132ff Mono: Add old TTRs to GodotTools 2019-07-11 13:59:06 +02:00
Rémi Verschelde
518e23424e pcre2: Update to upstream version 10.33 2019-07-11 10:35:39 +02:00
Ignacio Roldán Etcheverry
2c6daf73f3
Merge pull request #30502 from neikeq/chotto-matte-kudasai 
Mono: Fix Api HintPath and update old game projects
 2019-07-10 22:36:06 +02:00
Ignacio Roldán Etcheverry
1700ab9bc6
Merge pull request #30501 from neikeq/dispose-godotsharpexport 
Mono: Fix null dereference in EditorExportPlatformAndroid
 2019-07-10 22:35:54 +02:00
Ignacio Etcheverry
9eb0729a05 Mono: Fix Api HintPath and update old game projects 
Fixed Api assembly references with more than one HintPath.
Also made the editor update old C# projects use the new Api assembly HintPaths.
 2019-07-10 22:00:31 +02:00
Ignacio Etcheverry
2a8294ff24 Mono: Fix null dereference in EditorExportPlatformAndroid 
We need to dispose the GodotSharpExport export plugin before the editor destroys EditorSettings. Otherwise, if the GC disposes it at a later time, EditorExportPlatformAndroid will be freed after EditorSettings already was, and its device polling thread will try to access the EditorSettings singleton, resulting in null dereferencing.
 2019-07-10 21:51:47 +02:00
Ignacio Roldán Etcheverry
c3da4f854d
Merge pull request #30486 from neikeq/fix-indexoutofbounds-msbuildfinder 
Fix IndexOutOfBounds in FindMsBuildToolsPathOnWindows
 2019-07-10 21:43:17 +02:00
Hugo Locurcio
696a8fb657
Notify changes in properties that can be edited by 3D gizmos 
This makes the Inspector always display an up-to-date value
after editing properties using 3D gizmos.
 2019-07-10 20:07:48 +02:00
Rémi Verschelde
34d7484039
Merge pull request #30455 from qarmin/const_reference 
Pass by reference to const
 2019-07-10 15:43:15 +02:00
Ignacio Roldán Etcheverry
8b778f6234
Merge pull request #30489 from neikeq/fix-nullexc-on-gengameproj 
Mono: Fix null exception in GenerateGameProject
 2019-07-10 15:40:25 +02:00
Ignacio Etcheverry
caf20492cf Mono: Fix null exception in GenerateGameProject 
Also fix pdb files for GodotTools.*.dll assemblies not being copied to the output directory.
 2019-07-10 15:03:05 +02:00
Ignacio Roldán Etcheverry
63c4d5af72
Merge pull request #30485 from neikeq/remove-frameworkpathoverride-from-scons 
SCons no longer passes FrameworkPathOverride to MSBuild
 2019-07-10 13:35:40 +02:00
Ignacio Etcheverry
ace0c6ce38 Fix IndexOutOfBounds in FindMsBuildToolsPathOnWindows 2019-07-10 13:30:03 +02:00
Ignacio Etcheverry
c0a4f12fcc SCons no longer passes FrameworkPathOverride to MSBuild 2019-07-10 13:19:52 +02:00
Ignacio Etcheverry
2da83a278b Mono: Add missing GodotTools.sln 2019-07-10 12:30:12 +02:00
qarmin
01cc7a996b Use reference to constant in functions 2019-07-10 11:54:12 +02:00
K. S. Ernest (iFire) Lee
d81d29dcbf Update xatlas to b7d7bb. 2019-07-09 15:24:10 -07:00
Ignacio Etcheverry
d3f48f88bb Fix EditorNavigationMeshGenerator registered in Core API 
Also added an option to output a json file with all the ClassDB registered classes and its members. This can be used to compare the API of two different builds by a simple diff.
 2019-07-09 23:33:29 +02:00
Rémi Verschelde
d2e620b8fc
Merge pull request #30463 from neikeq/fix-search-dirs 
Fix export templates ignoring assemblies in 'res://.mono/assemblies'
 2019-07-09 21:59:32 +02:00
Ignacio Etcheverry
4af03e52bd Make SCons check for System MSBuild before Mono's 2019-07-09 16:49:06 +02:00
Ignacio Etcheverry
df6d1656fe Fix export templates ignoring assemblies in 'res://.mono/assemblies' 2019-07-09 16:49:02 +02:00
Rémi Verschelde
2fd902a08f
Merge pull request #30438 from Calinou/use-color-constructors 
Use base `Color()` constructors instead of `Color::html()`
 2019-07-09 08:30:10 +02:00
Rémi Verschelde
dcffa0ee64
Merge pull request #30434 from Faless/ws/wslay_fix_handshake_break 
Fix WebSocketClient consuming data during hanshake
 2019-07-09 08:28:01 +02:00
Rémi Verschelde
29ca79bd68
Merge pull request #30428 from neikeq/gitcheckout-b 
Misc Mono Fixes
 2019-07-09 08:26:48 +02:00
Hugo Locurcio
28d3a6051c
Use base Color() constructors instead of Color::html() 
This results in slightly smaller binaries (-17 KB for an editor binary)
as no strings need to be allocated.
 2019-07-08 21:17:10 +02:00
Fabio Alessandrelli
3e305ea036 Fix WebSocketClient consuming data during hanshake 
Was missing a break of the while loop on connection.
This potentially caused early data frames to be trashed.
 2019-07-08 19:24:27 +02:00
Ignacio Etcheverry
069af23bdb Mono: Fix build errors with tools=no 2019-07-08 18:07:20 +02:00
Ignacio Etcheverry
dd22cc7527 C#: Fix some crashes during assemblies reloading 2019-07-08 18:07:20 +02:00
Ignacio Etcheverry
aa3b8f7dbb Fix Godot.Object.ToString() infinite recursion 
Should not be using Variant to String conversion as that would call ToString() again
 2019-07-08 18:07:20 +02:00
Ignacio Etcheverry
5ed3d34cd9 Fix --generate-mono-glue bug when directory doesn't exist 
DirAccess::get_full_path(path) only works if the path exists. Implement our own abspath function.
 2019-07-08 18:07:15 +02:00
Ignacio Etcheverry
2c83255013 Fix C# bindings detection of abstract classes 
ClassDB::can_instance was changed recently breaking our code, as the editor is not yet initialized. Check ClassInfo::creation_func directly.
 2019-07-08 15:13:57 +02:00
Ignacio Etcheverry
b0cbf4e2b2 Fix InvalidCastException when loading script metadata 
Old value wasn't string so we have to keep that in mind
 2019-07-08 15:12:04 +02:00
Rémi Verschelde
9da5fdc955
Merge pull request #30419 from Faless/ws/wslay_server_proto 
(Re-)Implement subprotocols in websocket server.
 2019-07-08 08:18:00 +02:00
Rémi Verschelde
af80182016
Merge pull request #30407 from qarmin/small_fixess 
Fixes minor issues found by static analyzer
 2019-07-08 08:16:50 +02:00
Fabio Alessandrelli
11452dcf91 (Re-)Implement subprotocols in websocket server. 2019-07-08 07:48:26 +02:00
qarmin
9a77d748c0 Fixes minor issues found by static analyzer 2019-07-07 23:08:51 +02:00
Remi Rampin
ddfd67401f DOC: Fix spelling 
See also https://github.com/godotengine/godot-docs/pull/2595
 2019-07-06 16:54:01 -04:00
Rémi Verschelde
ba211bd58c
Merge pull request #30352 from bojidar-bg/28727-enum-value-check 
Fix parsing of enums allowing for juxtaposed identifiers
 2019-07-06 20:28:53 +02:00
Ibrahn Sahir
4e4697b1c4 Added release function to PoolVector::Access. 
For clarity, assign-to-release idiom for PoolVector::Read/Write
replaced with a function call.
Existing uses replaced (or removed if already handled by scope)
 2019-07-06 12:04:27 +01:00